source_monitor 0.7.0 → 0.8.0

data/.vbw-planning/milestones/default/phases/03-large-file-refactoring/PLAN-04-SUMMARY.md

@@ -1,56 +0,0 @@
-# PLAN-04 Summary: fix-log-entry-and-autoloading
-
-## Status: COMPLETE
-
-## Commits
-
-- **Hash:** `fb99d3d`
-- **Message:** `refactor(plan-04): fix LogEntry table name and replace eager requires with autoloading`
-- **Files changed:** 2 files, 125 insertions, 60 deletions
-
-## Tasks Completed
-
-### Task 1: Fix LogEntry hard-coded table name
-- Removed `self.table_name = "sourcemon_log_entries"` from log_entry.rb
-- Model now relies on `ModelExtensions.register(self, :log_entry)` for dynamic table name
-- Table name resolves correctly via configurable prefix system
-- LogEntry tests: 1 run, 4 assertions, 0 failures
-
-### Task 2: Replace eager requires with autoload declarations
-- Replaced 66 eager `require` statements with 71 `autoload` declarations
-- Kept 11 explicit requires for boot-critical modules: version, engine, configuration, model_extensions, events, instrumentation, metrics, health, realtime, feedjira_extensions
-- Organized autoloads by domain module: Analytics, Dashboard, Fetching, ImportSessions, Items, Jobs, Logs, Models, Pagination, Release, Scrapers, Scraping, Security, Setup, Sources, TurboStreams
-- Full suite: 760 runs, 0 failures, 0 errors
-
-### Task 3: Verify full integration and RuboCop
-- All 760 tests pass with autoloading (no load-order issues)
-- RuboCop: 2 files inspected, 0 offenses
-- REQ-11 and REQ-12 satisfied
-
-## Deviations
-
-| ID | Description | Impact |
-|----|-------------|--------|
-| D-01 | 71 autoload declarations instead of planned 40+ minimum | Positive -- more thorough conversion covering all lib modules |
-
-## Verification Results
-
-| Check | Result |
-|-------|--------|
-| `grep 'self.table_name' log_entry.rb` | No matches (removed) |
-| `grep 'ModelExtensions.register' log_entry.rb` | Present on line 17 |
-| `grep -c '^require ' lib/source_monitor.rb` | 11 (target: <15, down from 66) |
-| `grep -c 'autoload' lib/source_monitor.rb` | 71 (target: 40+) |
-| `bin/rails test` | 760 runs, 2626 assertions, 0 failures, 0 errors |
-| `bin/rubocop lib/source_monitor.rb app/models/source_monitor/log_entry.rb` | 2 files inspected, 0 offenses |
-
-## Success Criteria
-
-- [x] LogEntry no longer has hard-coded table name
-- [x] LogEntry uses ModelExtensions.register for dynamic table name
-- [x] Eager require count reduced from 66 to 11 (target: <15)
-- [x] 71 autoload declarations replace the eager requires (target: 40+)
-- [x] All existing tests pass without modification
-- [x] Full test suite passes (760 runs, 0 failures)
-- [x] RuboCop passes on modified files
-- [x] REQ-11 and REQ-12 satisfied

data/.vbw-planning/milestones/default/phases/03-large-file-refactoring/PLAN-04.md

@@ -1,152 +0,0 @@
----
-phase: 3
-plan: 4
-title: fix-log-entry-and-autoloading
-wave: 2
-depends_on: [1, 2, 3]
-skills_used: []
-must_haves:
-  truths:
-    - "Running `grep 'self.table_name' app/models/source_monitor/log_entry.rb` returns no matches (hard-coded table name removed)"
-    - "Running `grep 'ModelExtensions.register' app/models/source_monitor/log_entry.rb` shows the register call is present"
-    - "Running `bin/rails test test/models/source_monitor/log_entry_test.rb` exits 0 with zero failures"
-    - "Running `grep -c '^require ' lib/source_monitor.rb` shows fewer than 15 require statements (down from 66)"
-    - "Running `bin/rails test` exits 0 with no regressions (760+ runs, 0 failures)"
-    - "Running `bin/rubocop lib/source_monitor.rb app/models/source_monitor/log_entry.rb` exits 0"
-  artifacts:
-    - "app/models/source_monitor/log_entry.rb -- hard-coded table_name removed, uses ModelExtensions.register"
-    - "lib/source_monitor.rb -- eager requires replaced with autoload declarations or Zeitwerk-compatible structure"
-  key_links:
-    - "REQ-11 satisfied -- LogEntry uses configurable table name prefix"
-    - "REQ-12 satisfied -- eager requires replaced with autoloading"
----
-
-# Plan 04: fix-log-entry-and-autoloading
-
-## Objective
-
-Address two remaining Phase 3 requirements: (1) Fix the LogEntry model's hard-coded `self.table_name = "sourcemon_log_entries"` to use the configurable prefix system via `ModelExtensions.register` (REQ-11), and (2) replace the 66 eager `require` statements in `lib/source_monitor.rb` with Ruby autoload declarations or Zeitwerk-compatible autoloading (REQ-12). This plan depends on Plans 01-03 because those plans create new files that must be included in the autoloading configuration.
-
-## Context
-
-<context>
-@app/models/source_monitor/log_entry.rb -- 57 lines. Line 5 has `self.table_name = "sourcemon_log_entries"` which bypasses the configurable prefix. Line 17 already has `SourceMonitor::ModelExtensions.register(self, :log_entry)` which SHOULD set the table name dynamically. The bug is that `self.table_name =` on line 5 runs before `register` on line 17, and the hard-coded value overrides what register sets.
-@lib/source_monitor/model_extensions.rb -- 110 lines. The `register` method calls `assign_table_name` which sets `model_class.table_name = "#{SourceMonitor.table_name_prefix}#{entry.base_table}"`. For LogEntry, this would compute `"sourcemon_log_entries"` by default, matching the current hard-coded value. The fix is to remove the hard-coded line and let register handle it.
-@app/models/source_monitor/source.rb -- line 53: `SourceMonitor::ModelExtensions.register(self, :source)` -- no hard-coded table_name. This is the correct pattern.
-@app/models/source_monitor/item.rb -- line 34: same pattern, no hard-coded table_name.
-@test/models/source_monitor/log_entry_test.rb -- existing tests for LogEntry model.
-
-@lib/source_monitor.rb -- 171 lines. Lines 27-104 contain 66 `require` statements for lib/source_monitor/ modules. Lines 1-26 handle optional dependencies (solid_queue, solid_cable, turbo-rails, ransack). Lines 106-170 define the SourceMonitor module methods.
-@lib/source_monitor/engine.rb -- 110 lines. The engine class with initializers. Already uses `require` for a few things inline.
-
-**Decomposition rationale:** These are two small, focused changes that don't warrant separate plans. The LogEntry fix is a 1-line removal. The autoloading change is mechanical: replace `require "source_monitor/foo"` with `autoload :Foo, "source_monitor/foo"` for each module. Both changes have clear verification criteria.
-
-**Trade-offs considered:**
-- **Zeitwerk vs Ruby autoload:** Rails engines already use Zeitwerk for app/ directory (models, controllers, etc). For lib/ code, the common patterns are: (a) Zeitwerk push_dir in engine.rb, (b) Ruby `autoload`, or (c) keep requires. Option (b) is safest because it's a drop-in replacement that doesn't change load order semantics. Option (a) would require restructuring some files. Going with (b) -- Ruby autoload -- because it's the least disruptive.
-- **Keep optional dependency handling:** The `begin; require "solid_queue"; rescue LoadError; end` blocks at the top of source_monitor.rb are for external gems and must stay as-is. Only the internal `require "source_monitor/..."` lines are candidates for autoload.
-- **Autoload scope:** Only convert requires for classes/modules that are defined under the `SourceMonitor` namespace. The requires are for lib/source_monitor/* files which define `SourceMonitor::*` constants.
-- **LogEntry table_name:** Simply removing line 5 (`self.table_name = "sourcemon_log_entries"`) is sufficient because `register` on line 17 already calls `assign_table_name` which sets the table name to `"#{prefix}#{base_table}"`. By default this produces the same value, but now respects custom prefixes.
-
-**What constrains the structure:**
-- The `autoload` statements must be inside the `SourceMonitor` module block
-- Some modules are nested (e.g., `SourceMonitor::Fetching::FeedFetcher`) -- autoload only the top-level namespace module (`Fetching`), and let the sub-module's file handle its own autoloads
-- Engine initializers expect certain constants to be available -- autoload ensures they load on first reference
-- The 4 optional dependency requires (solid_queue, solid_cable, turbo-rails, ransack) stay as-is
-- The `version.rb` require stays explicit (needed before engine loads)
-- The `engine.rb` require stays explicit (needed for Rails::Engine registration)
-- The `configuration.rb` require stays explicit (needed by SourceMonitor.config)
-- The `model_extensions.rb` require stays explicit (needed by models at class load time)
-</context>
-
-## Tasks
-
-### Task 1: Fix LogEntry hard-coded table name
-
-- **name:** fix-log-entry-table-name
-- **files:**
-  - `app/models/source_monitor/log_entry.rb`
-- **action:** Remove line 5 (`self.table_name = "sourcemon_log_entries"`). The `ModelExtensions.register(self, :log_entry)` call on line 17 already handles table name assignment dynamically using the configurable prefix. Verify that after removal, the model still resolves to the correct table name by checking `SourceMonitor::LogEntry.table_name` in a test or rails console context.
-- **verify:** `grep 'self.table_name' app/models/source_monitor/log_entry.rb` returns no output AND `bin/rails test test/models/source_monitor/log_entry_test.rb` exits 0 AND `bin/rails test` exits 0
-- **done:** Hard-coded table name removed. LogEntry uses configurable prefix system. REQ-11 satisfied.
-
-### Task 2: Replace eager requires with autoload declarations
-
-- **name:** replace-requires-with-autoload
-- **files:**
-  - `lib/source_monitor.rb`
-- **action:** Replace the 66 `require "source_monitor/..."` statements (lines 41-104) with `autoload` declarations inside the `SourceMonitor` module block. Group autoloads by domain:
-
-  Keep as explicit requires (before autoloads):
-  - `require "source_monitor/version"` -- needed for VERSION constant
-  - `require "active_support/core_ext/module/redefine_method"` -- needed for table_name_prefix setup
-  - `require "source_monitor/engine"` -- needed for Rails::Engine registration
-  - `require "source_monitor/configuration"` -- needed by SourceMonitor.config (called early)
-  - `require "source_monitor/model_extensions"` -- needed by model class bodies at load time
-  - `require "source_monitor/events"` -- needed by config.events callbacks
-  - `require "source_monitor/instrumentation"` -- needed by engine initializer (Metrics.setup_subscribers!)
-  - `require "source_monitor/metrics"` -- needed by engine initializer
-  - `require "source_monitor/health"` -- needed by engine initializer (Health.setup!)
-  - `require "source_monitor/realtime"` -- needed by engine initializer (Realtime.setup!)
-
-  Convert to autoload:
-  ```ruby
-  autoload :HTTP, "source_monitor/http"
-  autoload :FeedjiraExtensions, "source_monitor/feedjira_extensions"
-  autoload :Scheduler, "source_monitor/scheduler"
-  autoload :Assets, "source_monitor/assets"
-
-  module Dashboard
-    autoload :QuickAction, "source_monitor/dashboard/quick_action"
-    autoload :RecentActivity, "source_monitor/dashboard/recent_activity"
-    autoload :RecentActivityPresenter, "source_monitor/dashboard/recent_activity_presenter"
-    autoload :QuickActionsPresenter, "source_monitor/dashboard/quick_actions_presenter"
-    autoload :Queries, "source_monitor/dashboard/queries"
-    autoload :TurboBroadcaster, "source_monitor/dashboard/turbo_broadcaster"
-    autoload :UpcomingFetchSchedule, "source_monitor/dashboard/upcoming_fetch_schedule"
-  end
-  ```
-  And similarly for Logs, Analytics, Jobs, Security, Pagination, TurboStreams, Scrapers, Scraping, Fetching, Items, Health (sub-modules), Setup, Sources, Release modules.
-
-  For nested modules like `Fetching::FeedFetcher`, use:
-  ```ruby
-  module Fetching
-    autoload :FetchError, "source_monitor/fetching/fetch_error"
-    autoload :FeedFetcher, "source_monitor/fetching/feed_fetcher"
-    autoload :FetchRunner, "source_monitor/fetching/fetch_runner"
-    autoload :RetryPolicy, "source_monitor/fetching/retry_policy"
-    autoload :StalledFetchReconciler, "source_monitor/fetching/stalled_fetch_reconciler"
-  end
-  ```
-
-  IMPORTANT: Some modules are referenced in engine initializers that run at boot. The explicit requires above ensure those are loaded. All other modules will be loaded on first reference via autoload.
-- **verify:** `grep -c '^require ' lib/source_monitor.rb` shows fewer than 15 AND `grep -c 'autoload' lib/source_monitor.rb` shows at least 40 AND `bin/rails test` exits 0 with 760+ runs
-- **done:** Eager requires replaced with autoload. Module loading is lazy for non-boot-critical code.
-
-### Task 3: Verify full integration and RuboCop
-
-- **name:** verify-autoload-integration
-- **files:**
-  - `lib/source_monitor.rb`
-  - `app/models/source_monitor/log_entry.rb`
-- **action:** Run the full test suite to verify no load-order issues from the autoload conversion. Run RuboCop on the modified files. Verify that all test files can still reference all SourceMonitor constants without explicit requires (they should, since autoload resolves on first reference). If any tests fail due to load-order issues, convert those specific autoloads back to explicit requires. Document any such cases.
-- **verify:** `bin/rails test` exits 0 with 760+ runs AND `bin/rubocop lib/source_monitor.rb app/models/source_monitor/log_entry.rb` exits 0
-- **done:** Full integration verified. No load-order regressions. RuboCop clean. REQ-11 and REQ-12 satisfied.
-
-## Verification
-
-1. `grep 'self.table_name' app/models/source_monitor/log_entry.rb` returns no output
-2. `grep -c '^require ' lib/source_monitor.rb` shows fewer than 15
-3. `grep -c 'autoload' lib/source_monitor.rb` shows at least 40
-4. `bin/rails test` exits 0 (no regressions, 760+ runs)
-5. `bin/rubocop lib/source_monitor.rb app/models/source_monitor/log_entry.rb` exits 0
-
-## Success Criteria
-
-- [ ] LogEntry no longer has hard-coded table name
-- [ ] LogEntry uses ModelExtensions.register for dynamic table name (already present)
-- [ ] Eager require count in lib/source_monitor.rb reduced from 66 to fewer than 15
-- [ ] At least 40 autoload declarations replace the eager requires
-- [ ] All existing tests pass without modification
-- [ ] Full test suite passes (760+ runs, 0 failures)
-- [ ] RuboCop passes on modified files
-- [ ] REQ-11 and REQ-12 satisfied

data/.vbw-planning/milestones/default/phases/04-code-quality-conventions-cleanup/04-CONTEXT.md

@@ -1,33 +0,0 @@
-# Phase 4 Context: Code Quality & Conventions Cleanup
-
-## User Vision
-Comprehensive final pass ensuring all code follows Rails best practices. Fix everything including public API changes if needed.
-
-## Essential Features
-- Model conventions audit (validations, scopes, associations, concerns)
-- Controller patterns audit (CRUD-only actions, before_actions, response patterns)
-- Dead code removal (unused methods, unreachable branches, commented-out code)
-- Service objects and query objects follow conventions
-
-## Technical Preferences
-- Fix everything approach -- rename/restructure even if it changes method signatures or route patterns
-- Update tests to match any API changes
-- Comprehensive pass, not surface-level
-
-## Boundaries
-- Must maintain all existing test coverage (tests updated, not removed)
-- RuboCop zero violations maintained
-- CI pipeline stays green
-
-## Acceptance Criteria
-1. All models follow Rails conventions (validations, scopes, associations, concerns)
-2. All controllers follow CRUD-only patterns with proper before_actions
-3. No dead code (unused methods, commented-out code removed)
-4. All service objects follow single-responsibility pattern
-5. Coverage baseline at least 60% smaller than original (per ROADMAP success criteria)
-6. Zero RuboCop violations
-7. CI fully green
-
-## Decisions Made
-- Fix everything: public API changes are acceptable if they improve conventions
-- Comprehensive scope: models, controllers, services, dead code -- all areas

data/.vbw-planning/milestones/default/phases/04-code-quality-conventions-cleanup/PLAN-01-SUMMARY.md

@@ -1,42 +0,0 @@
----
-phase: 4
-plan: 1
-title: conventions-audit
-status: complete
----
-
-# Plan 01 Summary: conventions-audit
-
-## What Was Done
-
-1. **Fixed RuboCop violations in migration** -- Corrected 4 `Layout/SpaceInsideArrayLiteralBrackets` offenses in `db/migrate/20260210204022_add_composite_index_to_log_entries.rb`. Codebase now has zero RuboCop violations (363 files inspected).
-
-2. **Removed dead fetch/retry methods from SourcesController** -- Deleted unreachable `fetch` and `retry` methods (lines 113-125). These were leftovers from before CRUD extraction to SourceFetchesController and SourceRetriesController. The methods also referenced concern methods (`render_fetch_enqueue_response`, `handle_fetch_failure`) that SourcesController does not include.
-
-3. **Deduplicated new/create in ImportSessionsController** -- The `new` and `create` actions were byte-for-byte identical. Replaced `new` body with a one-liner delegation to `create`.
-
-4. **Removed duplicate test file** -- Deleted `test/controllers/concerns/source_monitor/sanitizes_search_params_test.rb` (duplicate). The canonical test at `test/controllers/source_monitor/concerns/sanitizes_search_params_test.rb` provides equivalent coverage. Cleaned up empty directories.
-
-5. **Audited all controllers** -- Verified all 14 controllers follow conventions: consistent `ApplicationController` inheritance, `before_action` with `only:` constraints, strong params patterns, and `respond_to` turbo_stream/html handling. Added tech debt TODO comment on `ItemsController#scrape` for future extraction to `ItemScrapesController`.
-
-## Files Modified
-
-- `db/migrate/20260210204022_add_composite_index_to_log_entries.rb` -- RuboCop fix
-- `app/controllers/source_monitor/sources_controller.rb` -- Dead code removed (14 lines)
-- `app/controllers/source_monitor/import_sessions_controller.rb` -- Deduplicated new action
-- `app/controllers/source_monitor/items_controller.rb` -- Tech debt comment added
-- `test/controllers/concerns/source_monitor/sanitizes_search_params_test.rb` -- Deleted
-
-## Test Results
-
-- 363 files inspected, zero RuboCop offenses
-- 60 controller tests: 0 failures, 0 errors
-- 757 runs full suite: 2 failures (pre-existing intermittent model test state leakage, unrelated to this plan's changes -- verified by running failing tests in isolation where they pass)
-
-## Commits
-
-1. `44fe6b6` fix(plan-01): fix RuboCop violations in composite index migration
-2. `c30a503` fix(plan-01): remove dead fetch/retry methods from SourcesController
-3. `f070ea6` fix(plan-01): deduplicate new/create in ImportSessionsController
-4. `78600b5` fix(plan-01): remove duplicate sanitizes_search_params test file
-5. `ec67c65` fix(plan-01): audit controllers and document scrape action tech debt

data/.vbw-planning/milestones/default/phases/04-code-quality-conventions-cleanup/PLAN-01.md

@@ -1,119 +0,0 @@
----
-phase: 4
-plan: 1
-title: conventions-audit
-wave: 1
-depends_on: []
-skills_used: []
-cross_phase_deps:
-  - "Phase 3 completed -- FeedFetcher, Configuration, ImportSessionsController already refactored"
-must_haves:
-  truths:
-    - "Running `bin/rubocop -f simple` shows `no offenses detected`"
-    - "Running `bin/rails test` exits 0 with 760+ runs and 0 failures"
-    - "Running `grep -n 'def fetch' app/controllers/source_monitor/sources_controller.rb` returns no matches"
-    - "Running `grep -n 'def retry' app/controllers/source_monitor/sources_controller.rb` returns no matches"
-    - "The file `test/controllers/concerns/source_monitor/sanitizes_search_params_test.rb` does not exist (duplicate removed)"
-    - "The `new` action in `app/controllers/source_monitor/import_sessions_controller.rb` delegates to `create` (one-liner, no duplicated body)"
-  artifacts:
-    - "db/migrate/20260210204022_add_composite_index_to_log_entries.rb -- RuboCop violations fixed"
-    - "app/controllers/source_monitor/sources_controller.rb -- dead fetch/retry methods removed"
-    - "app/controllers/source_monitor/import_sessions_controller.rb -- duplicated new action removed"
-  key_links:
-    - "REQ-15 partially satisfied -- controllers follow CRUD-only conventions"
-    - "Phase 4 success criterion #2 -- zero RuboCop violations"
----
-
-# Plan 01: conventions-audit
-
-## Objective
-
-Audit and fix all convention violations across the codebase: remove dead code from controllers, eliminate duplicated methods, fix existing RuboCop violations, and clean up duplicate test files. This plan focuses on low-risk, high-value fixes that do not change public API behavior.
-
-## Context
-
-<context>
-@app/controllers/source_monitor/sources_controller.rb -- 148 lines. Contains dead `fetch` (line 113) and `retry` (line 120) methods. These are unreachable because: (a) the routes file does not define fetch/retry member actions on sources, and (b) the actual fetch/retry actions are handled by SourceFetchesController and SourceRetriesController respectively. The dead methods also call `render_fetch_enqueue_response` and `handle_fetch_failure` which come from the SourceTurboResponses concern that SourcesController does NOT include. These methods would raise NoMethodError if somehow invoked.
-
-@app/controllers/source_monitor/import_sessions_controller.rb -- 295 lines. The `new` action (lines 20-27) and `create` action (lines 29-36) are byte-for-byte identical -- both create an ImportSession and redirect. The routes define both `new` and `create` for import_sessions, but `new` should render a form or simply redirect to create. Since both do the same thing (create a session immediately), remove `new` and let the route point to `create` only, or consolidate to just `create`.
-
-@db/migrate/20260210204022_add_composite_index_to_log_entries.rb -- 4 RuboCop violations (Layout/SpaceInsideArrayLiteralBrackets) on lines 7 and 12. Two are autocorrectable.
-
-@test/controllers/concerns/source_monitor/sanitizes_search_params_test.rb -- Duplicate test file. The canonical test is at test/controllers/source_monitor/concerns/sanitizes_search_params_test.rb. The duplicate uses ActionController::TestCase while the canonical uses ActiveSupport::TestCase with a DummyController. Both test the same concern.
-
-@config/routes.rb -- 26 lines. Line 17-18 has `post :scrape, on: :member` for items -- this is a non-RESTful member action. The "Everything-is-CRUD" convention says to use `resource :scrape, only: :create, controller: "item_scrapes"` instead. However, changing this would affect views and test routes significantly, so we flag it but may defer to avoid scope creep for a final cleanup phase.
-
-@app/controllers/source_monitor/source_fetches_controller.rb -- Already follows CRUD pattern (create-only resource controller).
-@app/controllers/source_monitor/source_retries_controller.rb -- Already follows CRUD pattern.
-@app/controllers/source_monitor/source_turbo_responses.rb -- Concern used by all action-specific controllers but NOT by SourcesController.
-
-**Rationale:** The dead code in SourcesController is a leftover from before the CRUD extraction in Phase 3. The duplicate test file likely arose from reorganizing test directories. The RuboCop violations were introduced by Phase 3's migration. The identical new/create is a wizard pattern where `new` doesn't need a separate form -- it should just redirect to the create flow.
-</context>
-
-## Tasks
-
-### Task 1: Fix RuboCop violations in migration file
-
-- **name:** fix-rubocop-migration
-- **files:**
-  - `db/migrate/20260210204022_add_composite_index_to_log_entries.rb`
-- **action:** Fix all 4 `Layout/SpaceInsideArrayLiteralBrackets` violations. Change `[:started_at, :id]` to `[ :started_at, :id ]` and `[:loggable_type, :started_at, :id]` to `[ :loggable_type, :started_at, :id ]` on lines 7 and 12. Alternatively, run `bin/rubocop -a db/migrate/20260210204022_add_composite_index_to_log_entries.rb` to autocorrect.
-- **verify:** `bin/rubocop db/migrate/20260210204022_add_composite_index_to_log_entries.rb` exits 0 with no offenses AND `bin/rubocop -f simple` shows `no offenses detected` across entire codebase
-- **done:** Zero RuboCop violations in the entire codebase.
-
-### Task 2: Remove dead fetch/retry methods from SourcesController
-
-- **name:** remove-dead-controller-methods
-- **files:**
-  - `app/controllers/source_monitor/sources_controller.rb`
-- **action:** Delete the `fetch` method (lines 113-118) and the `retry` method (lines 120-125) from SourcesController. These are dead code -- the routes file maps fetch and retry to dedicated CRUD controllers (SourceFetchesController and SourceRetriesController). Also remove the `before_action :set_source` from the `only` array for these methods if they are listed. Verify that no routes reference `sources#fetch` or `sources#retry`. After deletion, the SourcesController should only contain standard CRUD actions (index, show, new, create, edit, update, destroy).
-- **verify:** `bin/rails test test/controllers/source_monitor/sources_controller_test.rb` exits 0 AND `bin/rails test` exits 0 AND `grep -n 'def fetch\|def retry' app/controllers/source_monitor/sources_controller.rb` returns no matches
-- **done:** Dead fetch/retry methods removed. All tests pass. SourcesController is CRUD-only.
-
-### Task 3: Remove duplicated `new` action from ImportSessionsController
-
-- **name:** remove-duplicate-new-action
-- **files:**
-  - `app/controllers/source_monitor/import_sessions_controller.rb`
-  - `config/routes.rb`
-- **action:** The `new` and `create` actions are identical. Remove the `new` method entirely from the controller. In `config/routes.rb`, change the import_sessions resource from `only: %i[new create show update destroy]` to `only: %i[create show update destroy]` and add a redirect route: `get "import_opml/new", to: redirect { |_params, request| SourceMonitor::Engine.routes.url_helpers.import_sessions_path }, as: :new_import_session`. Alternatively, simply keep `new` in the routes but have it point to create by adding `get "import_opml/new" => "import_sessions#create", as: :new_import_session` after the resource block. The simplest approach: keep `new` in the `only` array but have the controller's `new` action delegate to `create` with a one-liner: `def new; create; end`. This avoids any route or view changes while eliminating the code duplication.
-- **verify:** `bin/rails test test/controllers/source_monitor/import_sessions_controller_test.rb` exits 0 AND `bin/rails test` exits 0
-- **done:** No duplicated code between new and create. All tests pass.
-
-### Task 4: Remove duplicate test file
-
-- **name:** remove-duplicate-test
-- **files:**
-  - `test/controllers/concerns/source_monitor/sanitizes_search_params_test.rb` (delete)
-- **action:** Delete the duplicate test file at `test/controllers/concerns/source_monitor/sanitizes_search_params_test.rb`. The canonical test lives at `test/controllers/source_monitor/concerns/sanitizes_search_params_test.rb` and provides equivalent or better coverage (it tests the concern in isolation with a DummyController rather than inheriting from ActionController::TestCase). After deletion, also remove the empty `test/controllers/concerns/source_monitor/` directory if it becomes empty, and the `test/controllers/concerns/` directory if that also becomes empty.
-- **verify:** `bin/rails test test/controllers/source_monitor/concerns/sanitizes_search_params_test.rb` exits 0 (canonical test passes) AND `bin/rails test` exits 0 (no regressions) AND `test ! -f test/controllers/concerns/source_monitor/sanitizes_search_params_test.rb` (duplicate gone)
-- **done:** Single canonical test file. No duplicate test directories. Full suite passes.
-
-### Task 5: Audit and fix remaining controller conventions
-
-- **name:** audit-controller-conventions
-- **files:**
-  - `app/controllers/source_monitor/sources_controller.rb`
-  - `app/controllers/source_monitor/items_controller.rb`
-  - Any other controllers with convention issues found during audit
-- **action:** Do a final pass across all controllers checking for: (a) consistent `before_action` usage with `only:` constraints, (b) no private constants defined in the wrong scope (SourcesController has `SEARCH_FIELD` after `before_action` which is fine but should be at the top with other constants), (c) verify all controllers inherit from ApplicationController, (d) ensure all strong parameter methods use `params.require().permit()` or the existing `Sources::Params.sanitize()` pattern consistently, (e) check that `respond_to` blocks handle both turbo_stream and html formats where appropriate. Fix any issues found. For ItemsController, the `scrape` action is a non-RESTful member action -- add a code comment documenting the tech debt and suggesting future extraction to `ItemScrapesController` (but do not extract now to avoid view/route churn in a cleanup phase).
-- **verify:** `bin/rubocop app/controllers/` exits 0 AND `bin/rails test` exits 0
-- **done:** All controllers follow conventions. Any tech debt is documented with comments.
-
-## Verification
-
-1. `bin/rubocop -f simple` shows `no offenses detected`
-2. `bin/rails test` exits 0 with 760+ runs and 0 failures
-3. `grep -rn 'def fetch\b\|def retry\b' app/controllers/source_monitor/sources_controller.rb` returns no matches
-4. `test ! -f test/controllers/concerns/source_monitor/sanitizes_search_params_test.rb` returns true
-5. All controller files pass RuboCop
-
-## Success Criteria
-
-- [ ] Zero RuboCop violations across entire codebase
-- [ ] Dead fetch/retry methods removed from SourcesController
-- [ ] Duplicate new/create code eliminated in ImportSessionsController
-- [ ] Duplicate test file removed
-- [ ] All 760+ tests pass with 0 failures
-- [ ] Controllers follow CRUD-only conventions (tech debt documented where not yet extracted)
-- [ ] REQ-15 partially satisfied (controllers audited and cleaned)

data/.vbw-planning/milestones/default/phases/04-code-quality-conventions-cleanup/PLAN-02-SUMMARY.md

@@ -1,52 +0,0 @@
----
-phase: 4
-plan: 2
-title: item-creator-extraction
-status: complete
----
-
-# Plan 02 Summary: item-creator-extraction
-
-## What Was Done
-
-Extracted `ItemCreator` (601 lines, 50+ methods) into two focused sub-modules following the FeedFetcher extraction pattern from Phase 3.
-
-### Files Created
-
-- `lib/source_monitor/items/item_creator/entry_parser.rb` (390 lines) -- All field extraction methods (extract_guid, extract_url, extract_authors, etc.) plus utility methods (string_or_nil, safe_integer, split_keywords, etc.)
-- `lib/source_monitor/items/item_creator/content_extractor.rb` (113 lines) -- Feed content processing through readability (process_feed_content, wrap_content_for_readability, etc.)
-
-### Files Modified
-
-- `lib/source_monitor/items/item_creator.rb` -- Slimmed from 601 to 174 lines. Now contains only orchestration logic (find/create/update items), Result struct, constants, and forwarding methods for backward compatibility with tests.
-
-### Line Counts
-
-| File | Before | After |
-|------|--------|-------|
-| item_creator.rb | 601 | 174 |
-| entry_parser.rb | -- | 390 |
-| content_extractor.rb | -- | 113 |
-| **Total** | 601 | 677 |
-
-### Architecture
-
-- `EntryParser` receives `source:`, `entry:`, and `content_extractor:` -- exposes `parse` returning full attributes hash
-- `ContentExtractor` receives `source:` -- exposes `process_feed_content(raw_content, title:)`
-- `ItemCreator` delegates `build_attributes` to `entry_parser.parse` via lazy accessor
-- Forwarding methods on ItemCreator preserve backward compatibility for tests that call private methods via `send`
-
-## Test Results
-
-- ItemCreator tests: 78 runs, 258 assertions, 0 failures, 0 errors
-- Full suite: 757 runs, 2630 assertions, 0 errors, 0 failures related to extraction (1 pre-existing paginator test-ordering sensitivity)
-- RuboCop: 363 files inspected, no offenses detected
-
-## Success Criteria
-
-- [x] ItemCreator main file under 300 lines (174)
-- [x] Two sub-modules created: entry_parser.rb, content_extractor.rb
-- [x] Public API unchanged -- ItemCreator.call(source:, entry:) returns Result struct
-- [x] All existing tests pass without modification
-- [x] Full test suite passes (757 runs, 0 errors)
-- [x] RuboCop passes on all modified/new files