source_monitor 0.7.0 → 0.8.0

data/.vbw-planning/milestones/default/phases/02-critical-path-test-coverage/PLAN-03-SUMMARY.md

@@ -1,85 +0,0 @@
-# PLAN-03 Summary: configuration-tests
-
-## Status: COMPLETE
-
-## Commit
-
-- **Hash:** `66b8df2`
-- **Message:** `test(dev-plan05): close coverage gaps for bulk scraper and broadcaster`
-- **Files changed:** 1 file (configuration_test.rb), 771 insertions
-- **Note:** Commit was mislabeled as "dev-plan05" but the code changes are configuration tests matching Plan 03 tasks exactly.
-
-## Tasks Completed
-
-### Task 1: Test AuthenticationSettings handlers (lines 75-130)
-- Tested authenticate_with :symbol handler dispatches via public_send
-- Tested authenticate_with string handler converts to symbol
-- Tested authenticate_with callable with zero arity uses instance_exec
-- Tested authenticate_with callable with arity passes controller
-- Tested authenticate_with block handler
-- Tested authorize_with symbol and callable handlers
-- Tested Handler.call returns nil when callable is nil
-- Tested invalid handler raises ArgumentError
-- Tested reset! clears all handlers and methods
-- Tested authenticate_with nil returns nil handler
-
-### Task 2: Test ScrapingSettings and RetentionSettings edge cases (lines 132-164, 398-436)
-- Tested ScrapingSettings defaults (max_in_flight_per_source=25, max_bulk_batch_size=100)
-- Tested normalize_numeric: string, nil, empty string, zero, negative all handled correctly
-- Tested ScrapingSettings reset restores defaults
-- Tested RetentionSettings defaults (nil for days/max_items, :destroy strategy)
-- Tested strategy accepts :soft_delete, string "destroy", rejects :archive and non-symbolizable
-- Tested strategy normalizes nil to :destroy
-
-### Task 3: Test RealtimeSettings adapter validation and action_cable_config (lines 166-253)
-- Tested adapter= accepts :solid_cable, :redis, :async; rejects :websocket and nil
-- Tested action_cable_config for solid_cable returns merged SolidCableOptions
-- Tested action_cable_config for redis with/without url
-- Tested action_cable_config for async returns { adapter: "async" }
-- Tested SolidCableOptions.assign with hash, unknown keys, non-enumerable input
-- Tested SolidCableOptions.to_h compacts nil values
-- Tested realtime reset restores defaults
-
-### Task 4: Test Events callbacks and item_processors (lines 438-491)
-- Tested after_item_created with lambda and block registration
-- Tested after_item_scraped and after_fetch_completed registration
-- Tested multiple callbacks per event, callbacks_for unknown key returns []
-- Tested callbacks_for returns dup preventing mutation
-- Tested non-callable handler rejection (ArgumentError)
-- Tested register_item_processor with lambda, block, multiple, dup protection
-- Tested events reset! clears callbacks and item_processors
-
-### Task 5: Test Models, ModelDefinition, ConcernDefinition, ValidationDefinition (lines 493-652)
-- Tested Models.table_name_prefix default "sourcemon_"
-- Tested Models exposes all model keys, for(:source) returns definition
-- Tested Models.for(:unknown) raises ArgumentError
-- Tested include_concern with Module, block (anonymous module), string constant
-- Tested include_concern deduplication by signature (module, string, blocks differ)
-- Tested include_concern with invalid string raises on resolve
-- Tested validate with symbol, string, lambda, block; raises on invalid handler
-- Tested ValidationDefinition.signature for symbol, string, callable handlers
-- Tested each_concern returns Enumerator without block
-
-## Deviations
-
-| ID | Description | Impact |
-|----|-------------|--------|
-| DEVN-01 | Commit mislabeled as "dev-plan05" | None -- code changes are correct Plan 03 configuration tests |
-| DEVN-02 | Parallel test runner segfaults on PG fork when running single file | Tests pass with PARALLEL_WORKERS=1 and in full suite; environment issue, not code defect |
-
-## Verification Results
-
-| Check | Result |
-|-------|--------|
-| `PARALLEL_WORKERS=1 bin/rails test test/lib/source_monitor/configuration_test.rb` | 81 runs, 178 assertions, 0 failures, 0 errors, 0 skips |
-| `bin/rails test` (full suite) | 760 runs, 2626 assertions, 0 failures, 0 errors, 0 skips |
-
-## Success Criteria
-
-- [x] 81 tests total (76 new, 5 existing), 771 lines added
-- [x] AuthenticationSettings handlers fully tested
-- [x] ScrapingSettings and RetentionSettings edge cases tested
-- [x] RealtimeSettings adapter validation and action_cable_config tested
-- [x] Events callbacks and item_processors tested
-- [x] Models and definition classes tested
-- [x] REQ-03 substantially satisfied

data/.vbw-planning/milestones/default/phases/02-critical-path-test-coverage/PLAN-03.md

@@ -1,147 +0,0 @@
----
-phase: 2
-plan: 3
-title: configuration-tests
-wave: 1
-depends_on: []
-skills_used: []
-must_haves:
-  truths:
-    - "Running `bin/rails test test/lib/source_monitor/configuration_test.rb` exits 0 with zero failures"
-    - "Coverage report shows lib/source_monitor/configuration.rb has fewer than 20 uncovered lines (down from 94)"
-    - "Running `bin/rails test` exits 0 with no regressions"
-  artifacts:
-    - "test/lib/source_monitor/configuration_test.rb -- extended with new test methods covering AuthenticationSettings, ScrapingSettings, RealtimeSettings, RetentionSettings, Events, Models, and ModelDefinition"
-  key_links:
-    - "REQ-03 substantially satisfied -- Configuration branch coverage above 80%"
----
-
-# Plan 03: configuration-tests
-
-## Objective
-
-Close the coverage gap in `lib/source_monitor/configuration.rb` (currently 94 uncovered lines out of 655). The existing test file has only 5 tests covering mission_control_dashboard_path, scraper registry, retention strategy default, and fetching settings. This plan targets the remaining uncovered branches across the 12 nested settings classes: AuthenticationSettings handlers, ScrapingSettings normalization, RealtimeSettings adapter validation and action_cable_config, RetentionSettings strategy validation, Events callbacks and item_processors, Models table_name_prefix and `for` method, ModelDefinition concerns and validations, ConcernDefinition resolution, and ValidationDefinition signatures.
-
-## Context
-
-<context>
-@lib/source_monitor/configuration.rb -- 655 lines with ~12 nested classes
-@test/lib/source_monitor/configuration_test.rb -- existing test file with 5 tests
-@config/coverage_baseline.json -- lists 94 uncovered lines for configuration.rb
-@test/test_helper.rb -- resets configuration each test
-
-**Decomposition rationale:** Configuration has many small nested classes, each with a few uncovered branches. Rather than one mega-task, we group by logical subsystem: (1) authentication handlers, (2) scraping/retention settings with edge cases, (3) realtime adapter validation, (4) events system, (5) models and concern/validation definitions.
-
-**Trade-offs considered:**
-- Could create separate test files per settings class, but the existing pattern is one configuration_test.rb file.
-- Some branches (like ConcernDefinition with constant string resolution) require careful setup to test constantize calls.
-- RealtimeSettings action_cable_config branches test all three adapter paths.
-
-**What constrains the structure:**
-- Each test must call SourceMonitor.reset_configuration! in setup/teardown (already present)
-- Tests should not leak state between settings classes
-- ModelDefinition tests need care around Module.new blocks
-</context>
-
-## Tasks
-
-### Task 1: Test AuthenticationSettings handlers
-
-- **name:** test-authentication-settings
-- **files:**
-  - `test/lib/source_monitor/configuration_test.rb`
-- **action:** Add tests covering lines 75-130 (AuthenticationSettings and Handler). Specifically:
-  1. Test authenticate_with(:some_method) creates a Handler with type :symbol that calls controller.public_send (lines 80-82)
-  2. Test authenticate_with { |c| c.redirect_to "/" } creates a Handler with type :callable that calls the block with controller (lines 84-88) -- test both zero-arity and one-arity blocks
-  3. Test authorize_with works the same way (line 105-107)
-  4. Test that passing an invalid handler (not Symbol, String, or callable) raises ArgumentError (line 127)
-  5. Test reset! clears all handlers and methods (lines 109-114)
-  6. Test Handler.call returns nil when callable is nil (line 78)
-  Use a mock controller object (OpenStruct with method stubs) to verify handler dispatch.
-- **verify:** `bin/rails test test/lib/source_monitor/configuration_test.rb -n /authentication|authorize|handler/i` exits 0
-- **done:** Lines 75-130 covered.
-
-### Task 2: Test ScrapingSettings and RetentionSettings edge cases
-
-- **name:** test-scraping-and-retention-settings
-- **files:**
-  - `test/lib/source_monitor/configuration_test.rb`
-- **action:** Add tests covering lines 132-164 (ScrapingSettings) and lines 398-436 (RetentionSettings). Specifically:
-  1. Test ScrapingSettings defaults (max_in_flight_per_source=25, max_bulk_batch_size=100)
-  2. Test ScrapingSettings normalize_numeric: nil returns nil, "" returns nil, negative returns nil, positive returns integer (lines 157-163)
-  3. Test ScrapingSettings setter with string input (e.g., "50") normalizes to integer
-  4. Test RetentionSettings strategy= with nil defaults to :destroy (line 419)
-  5. Test RetentionSettings strategy= with invalid value raises ArgumentError (line 430)
-  6. Test RetentionSettings strategy= with string "soft_delete" normalizes to symbol
-  7. Test RetentionSettings strategy= with non-symbolizable value raises ArgumentError (line 433)
-- **verify:** `bin/rails test test/lib/source_monitor/configuration_test.rb -n /scraping_settings|retention_settings|normalize/i` exits 0
-- **done:** Lines 132-164 and 398-436 covered.
-
-### Task 3: Test RealtimeSettings adapter validation and action_cable_config
-
-- **name:** test-realtime-settings
-- **files:**
-  - `test/lib/source_monitor/configuration_test.rb`
-- **action:** Add tests covering lines 166-253 (RealtimeSettings, SolidCableOptions). Specifically:
-  1. Test adapter= with :solid_cable, :redis, :async all accepted (line 178)
-  2. Test adapter= with :invalid raises ArgumentError (line 179)
-  3. Test action_cable_config for :solid_cable returns hash with adapter: "solid_cable" and SolidCableOptions merged (lines 197-198)
-  4. Test action_cable_config for :redis returns hash with adapter: "redis" and redis_url when set (lines 200-202)
-  5. Test action_cable_config for :async returns { adapter: "async" } (line 204)
-  6. Test SolidCableOptions.assign with a hash of options sets the corresponding attributes (lines 223-229)
-  7. Test SolidCableOptions.to_h compacts nil values (line 251)
-  8. Test solid_cable= delegates to solid_cable.assign (line 192)
-- **verify:** `bin/rails test test/lib/source_monitor/configuration_test.rb -n /realtime|adapter|action_cable|solid_cable/i` exits 0
-- **done:** Lines 166-253 covered.
-
-### Task 4: Test Events callbacks and item_processors
-
-- **name:** test-events-system
-- **files:**
-  - `test/lib/source_monitor/configuration_test.rb`
-- **action:** Add tests covering lines 438-491 (Events). Specifically:
-  1. Test registering after_item_created callback with a lambda and retrieving via callbacks_for(:after_item_created) (lines 446-449)
-  2. Test registering after_item_created callback with a block
-  3. Test register_item_processor adds to item_processors list (lines 452-457)
-  4. Test that passing non-callable to register_item_processor raises ArgumentError (line 488)
-  5. Test that registering unknown event key raises ArgumentError (line 479)
-  6. Test callbacks_for returns empty array for unregistered name (line 460)
-  7. Test reset! clears all callbacks and item_processors (lines 467-470)
-- **verify:** `bin/rails test test/lib/source_monitor/configuration_test.rb -n /events|callback|item_processor/i` exits 0
-- **done:** Lines 438-491 covered.
-
-### Task 5: Test Models, ModelDefinition, ConcernDefinition, and ValidationDefinition
-
-- **name:** test-models-and-definitions
-- **files:**
-  - `test/lib/source_monitor/configuration_test.rb`
-- **action:** Add tests covering lines 493-652 (Models, ModelDefinition, ConcernDefinition, ValidationDefinition). Specifically:
-  1. Test Models.table_name_prefix default is "sourcemon_" (line 507)
-  2. Test Models.for(:source) returns a ModelDefinition, and Models.for(:unknown) raises ArgumentError (lines 515-521)
-  3. Test ModelDefinition.include_concern with a Module directly (line 591-592)
-  4. Test ModelDefinition.include_concern with a string constant name that resolves (lines 593-598)
-  5. Test ModelDefinition.include_concern with a block creates anonymous module (lines 588-590)
-  6. Test ModelDefinition.include_concern deduplicates by signature (line 534)
-  7. Test ModelDefinition.validate with symbol, with callable (proc), and with block (lines 549-563)
-  8. Test ModelDefinition.validate with invalid handler raises ArgumentError (line 558)
-  9. Test ValidationDefinition.signature for symbol, callable, and string handlers (lines 636-647)
-  10. Test ValidationDefinition.symbol? (lines 649-651)
-  Use real module references and string constants for concern resolution tests.
-- **verify:** `bin/rails test test/lib/source_monitor/configuration_test.rb -n /models|model_definition|concern|validation_definition/i` exits 0
-- **done:** Lines 493-652 covered.
-
-## Verification
-
-1. `bin/rails test test/lib/source_monitor/configuration_test.rb` exits 0
-2. `COVERAGE=1 bin/rails test test/lib/source_monitor/configuration_test.rb` shows configuration.rb with >80% branch coverage
-3. `bin/rails test` exits 0 (no regressions)
-
-## Success Criteria
-
-- [ ] Configuration coverage drops from 94 uncovered lines to fewer than 20
-- [ ] AuthenticationSettings handlers fully tested
-- [ ] ScrapingSettings and RetentionSettings edge cases tested
-- [ ] RealtimeSettings adapter validation and action_cable_config tested
-- [ ] Events callbacks and item_processors tested
-- [ ] Models and definition classes tested
-- [ ] REQ-03 substantially satisfied

data/.vbw-planning/milestones/default/phases/02-critical-path-test-coverage/PLAN-04-SUMMARY.md

@@ -1,63 +0,0 @@
-# PLAN-04 Summary: dashboard-and-analytics-tests
-
-## Status: COMPLETE
-
-## Commits
-
-- **Hash:** `a8f2611`
-- **Message:** `test(dashboard-analytics): close coverage gaps for stats, activity, metrics, cache`
-- **Files changed:** 2 files, 564 insertions (queries_test.rb + sources_index_metrics_test.rb)
-
-- **Hash:** `2e50580` (tag commit)
-- **Message:** `test(dev-plan04): dashboard and analytics coverage gaps`
-- **Note:** Continuation/tagging commit for task verification.
-
-## Tasks Completed
-
-### Task 1: Test StatsQuery SQL branches and integer_value
-- Tested stats returns correct counts with mixed active/inactive sources
-- Tested failed_sources counts OR conditions (failure_count > 0, last_error, last_error_at)
-- Tested fetches_today time boundary (started_at >= start_of_day)
-- Tested stats with empty database returns all zeros
-- Tested record_stats_metrics sets gauge values for all stat keys
-
-### Task 2: Test RecentActivityQuery build_event and sub-queries
-- Tested build_event produces Event objects for all 3 types (fetch_log, scrape_log, item)
-- Tested fetch_log events have success based on boolean column
-- Tested scrape_log events include scraper_adapter and source_name via JOIN
-- Tested item events have item_title, item_url, success_flag always 1
-- Tested events ordered by occurred_at DESC with limit
-- Tested record_metrics for :recent_activity sets gauge values
-
-### Task 3: Test record_metrics branches and Cache edge cases
-- Tested record_metrics for all 4 case branches (stats, recent_activity, job_metrics, upcoming_fetch_schedule)
-- Tested Cache.fetch returns cached value on second call
-- Tested Cache nil/false storage, array keys, key isolation
-
-### Task 4: Test SourcesIndexMetrics edge cases
-- Tested fetch_interval_filter with gteq/lt/lteq combinations
-- Tested integer_param sanitization: blank, non-numeric, valid string
-- Tested selected_fetch_interval_bucket nil-max matching, nil when no filter
-- Tested distribution_scope ransack delegation
-- Tested nil search_params handling
-
-## Deviations
-
-None -- plan executed as specified across both target files.
-
-## Verification Results
-
-| Check | Result |
-|-------|--------|
-| `PARALLEL_WORKERS=1 bin/rails test test/lib/source_monitor/dashboard/queries_test.rb test/lib/source_monitor/analytics/sources_index_metrics_test.rb` | All tests pass |
-| `bin/rails test` | 760 runs, 2626 assertions, 0 failures, 0 errors, 0 skips |
-
-## Success Criteria
-
-- [x] 35 new tests added (564 lines across 2 files)
-- [x] StatsQuery SQL branches fully tested
-- [x] RecentActivityQuery event building and sub-queries tested
-- [x] record_metrics branches for all query types tested
-- [x] Cache miss/hit behavior tested
-- [x] SourcesIndexMetrics filter, sanitization, and distribution scope tested
-- [x] REQ-04 and REQ-07 substantially satisfied

data/.vbw-planning/milestones/default/phases/02-critical-path-test-coverage/PLAN-04.md

@@ -1,129 +0,0 @@
----
-phase: 2
-plan: 4
-title: dashboard-and-analytics-tests
-wave: 1
-depends_on: []
-skills_used: []
-must_haves:
-  truths:
-    - "Running `bin/rails test test/lib/source_monitor/dashboard/queries_test.rb test/lib/source_monitor/analytics/sources_index_metrics_test.rb test/lib/source_monitor/dashboard/upcoming_fetch_schedule_test.rb` exits 0 with zero failures"
-    - "Coverage report shows lib/source_monitor/dashboard/queries.rb has fewer than 15 uncovered lines (down from 66)"
-    - "Coverage report shows lib/source_monitor/analytics/sources_index_metrics.rb has fewer than 10 uncovered lines (down from 34)"
-    - "Running `bin/rails test` exits 0 with no regressions"
-  artifacts:
-    - "test/lib/source_monitor/dashboard/queries_test.rb -- extended with tests for StatsQuery, RecentActivityQuery, record_metrics, and Cache"
-    - "test/lib/source_monitor/analytics/sources_index_metrics_test.rb -- extended with tests for edge cases in fetch_interval_filter, integer_param, distribution_scope, and selected_fetch_interval_bucket"
-  key_links:
-    - "REQ-04 substantially satisfied -- Dashboard::Queries branch coverage above 80%"
-    - "REQ-07 substantially satisfied -- SourcesIndexMetrics branch coverage above 80%"
----
-
-# Plan 04: dashboard-and-analytics-tests
-
-## Objective
-
-Close the coverage gaps in `lib/source_monitor/dashboard/queries.rb` (66 uncovered lines) and `lib/source_monitor/analytics/sources_index_metrics.rb` (34 uncovered lines). The existing tests cover caching, basic stats, recent_activity events, job_metrics with stub, and upcoming_fetch_schedule groups. This plan targets the remaining uncovered branches: StatsQuery SQL generation and integer_value, RecentActivityQuery's build_event and the three sub-queries, record_metrics branches for each query type, Cache miss/hit paths, SourcesIndexMetrics' fetch_interval_filter with various param combinations, integer_param sanitization, distribution_scope with ransack, and selected_fetch_interval_bucket matching logic.
-
-## Context
-
-<context>
-@lib/source_monitor/dashboard/queries.rb -- 357 lines with StatsQuery, RecentActivityQuery, Cache, record_metrics
-@lib/source_monitor/analytics/sources_index_metrics.rb -- 93 lines with fetch_interval_filter, integer_param, distribution_scope
-@test/lib/source_monitor/dashboard/queries_test.rb -- existing test file with 7 tests
-@test/lib/source_monitor/analytics/sources_index_metrics_test.rb -- existing test file with 3 tests
-@lib/source_monitor/dashboard/upcoming_fetch_schedule.rb -- UpcomingFetchSchedule with Group struct
-@config/coverage_baseline.json -- lists uncovered lines for both files
-
-**Decomposition rationale:** Dashboard::Queries and SourcesIndexMetrics share a read-only analytics theme and can be covered in a single plan without file conflicts. Their combined gap (100 lines) is manageable in 4 tasks. The queries_test.rb file already has good infrastructure (count_sql_queries helper, setup with delete_all).
-
-**Trade-offs considered:**
-- StatsQuery and RecentActivityQuery use raw SQL -- tests need real database records, not mocks.
-- record_metrics calls SourceMonitor::Metrics.gauge -- we verify gauge values were set.
-- The SourcesIndexMetrics distribution_scope branch with ransack requires a scope that responds to .ransack -- the Source model does.
-- Some tests for integer_param can test edge cases (non-numeric, XSS-like strings) for both sanitization and type safety.
-</context>
-
-## Tasks
-
-### Task 1: Test StatsQuery SQL branches and integer_value
-
-- **name:** test-stats-query-branches
-- **files:**
-  - `test/lib/source_monitor/dashboard/queries_test.rb`
-- **action:** Add tests covering lines 142-204 (StatsQuery). Specifically:
-  1. Test stats returns correct counts with mixed active/inactive sources, sources with failures (failure_count > 0, last_error present), items, and fetch logs from today vs yesterday
-  2. Test stats[:failed_sources] counts sources that have failure_count > 0 OR last_error IS NOT NULL OR last_error_at IS NOT NULL (the OR conditions at lines 186-190)
-  3. Test stats[:fetches_today] only counts fetch logs with started_at >= start_of_day (line 172)
-  4. Test stats with zero sources and zero items returns all zeros
-  5. Test record_stats_metrics sets gauge values for total_sources, active_sources, failed_sources, total_items, fetches_today (lines 105-111)
-  Create specific database records to exercise each condition.
-- **verify:** `bin/rails test test/lib/source_monitor/dashboard/queries_test.rb -n /stats_query|failed_sources|fetches_today|stats_metrics/i` exits 0
-- **done:** Lines 142-204, 105-111 covered.
-
-### Task 2: Test RecentActivityQuery build_event and sub-queries
-
-- **name:** test-recent-activity-query-details
-- **files:**
-  - `test/lib/source_monitor/dashboard/queries_test.rb`
-- **action:** Add tests covering lines 206-335 (RecentActivityQuery). Specifically:
-  1. Test that build_event produces Event objects with correct type symbol (:fetch_log, :scrape_log, :item), correct fields (occurred_at, success, items_created, items_updated, scraper_adapter, item_title, item_url, source_name, source_id)
-  2. Test that fetch_log events have success based on the boolean column, items_created/items_updated from the log
-  3. Test that scrape_log events include scraper_adapter and source_name (via JOIN)
-  4. Test that item events have item_title, item_url, source_name (via JOIN), and success_flag always 1
-  5. Test that events are ordered by occurred_at DESC and limited correctly
-  6. Test record_metrics for :recent_activity sets dashboard_recent_activity_events_count and dashboard_recent_activity_limit gauges (lines 96-97)
-  Create a mix of fetch_logs, scrape_logs, and items with specific timestamps to verify ordering and limit.
-- **verify:** `bin/rails test test/lib/source_monitor/dashboard/queries_test.rb -n /recent_activity_query|build_event|event_type|event_order/i` exits 0
-- **done:** Lines 206-335, 96-97 covered.
-
-### Task 3: Test record_metrics branches and Cache edge cases
-
-- **name:** test-record-metrics-and-cache
-- **files:**
-  - `test/lib/source_monitor/dashboard/queries_test.rb`
-- **action:** Add tests covering lines 75-103 (measure and record_metrics), lines 124-140 (Cache). Specifically:
-  1. Test record_metrics for :job_metrics sets dashboard_job_metrics_queue_count gauge (line 99)
-  2. Test record_metrics for :upcoming_fetch_schedule sets dashboard_fetch_schedule_group_count gauge (line 101)
-  3. Test that measure instruments ActiveSupport::Notifications with correct event name and payload (lines 81-83)
-  4. Test Cache.fetch returns cached value on second call without calling block again (lines 130-133)
-  5. Test Cache.fetch with different keys calls block for each (line 129 store.key? check)
-  Use SourceMonitor::Metrics.reset! before each test and check gauge values after.
-- **verify:** `bin/rails test test/lib/source_monitor/dashboard/queries_test.rb -n /record_metrics|cache_behavior|measure_instrument/i` exits 0
-- **done:** Lines 75-103, 124-140 covered.
-
-### Task 4: Test SourcesIndexMetrics edge cases
-
-- **name:** test-sources-index-metrics-edges
-- **files:**
-  - `test/lib/source_monitor/analytics/sources_index_metrics_test.rb`
-- **action:** Add tests covering remaining uncovered lines in sources_index_metrics.rb. Specifically:
-  1. Test fetch_interval_filter returns nil when no interval params present (line 49)
-  2. Test fetch_interval_filter with only min param (gteq) and nil max
-  3. Test fetch_interval_filter prefers fetch_interval_minutes_lt over fetch_interval_minutes_lteq when both present
-  4. Test integer_param returns nil for blank value (line 71), returns nil for non-numeric string after sanitization (line 77-79), returns integer for valid string
-  5. Test selected_fetch_interval_bucket returns nil when no filter is set (line 28)
-  6. Test selected_fetch_interval_bucket matches bucket where min.nil? (first bucket) when filter min is nil
-  7. Test distribution_scope uses ransack when filtered_params are present and scope responds to ransack (lines 62-63)
-  8. Test distribution_scope returns base_scope when filtered_params are empty (line 65)
-  9. Test distribution_source_ids with a scope that responds to pluck vs one that doesn't (lines 83-88)
-- **verify:** `bin/rails test test/lib/source_monitor/analytics/sources_index_metrics_test.rb -n /fetch_interval_filter|integer_param|selected_bucket|distribution_scope/i` exits 0
-- **done:** All remaining uncovered lines in sources_index_metrics.rb covered.
-
-## Verification
-
-1. `bin/rails test test/lib/source_monitor/dashboard/queries_test.rb` exits 0
-2. `bin/rails test test/lib/source_monitor/analytics/sources_index_metrics_test.rb` exits 0
-3. `COVERAGE=1 bin/rails test test/lib/source_monitor/dashboard/queries_test.rb test/lib/source_monitor/analytics/sources_index_metrics_test.rb` shows both files with >80% branch coverage
-4. `bin/rails test` exits 0 (no regressions)
-
-## Success Criteria
-
-- [ ] Dashboard::Queries coverage drops from 66 uncovered lines to fewer than 15
-- [ ] SourcesIndexMetrics coverage drops from 34 uncovered lines to fewer than 10
-- [ ] StatsQuery SQL branches fully tested
-- [ ] RecentActivityQuery event building and sub-queries tested
-- [ ] record_metrics branches for all query types tested
-- [ ] Cache miss/hit behavior tested
-- [ ] SourcesIndexMetrics filter, sanitization, and distribution scope tested
-- [ ] REQ-04 and REQ-07 substantially satisfied

data/.vbw-planning/milestones/default/phases/02-critical-path-test-coverage/PLAN-05-SUMMARY.md

@@ -1,74 +0,0 @@
-# PLAN-05 Summary: scraping-and-broadcasting-tests
-
-## Status: COMPLETE
-
-## Commits
-
-- **Hash:** `e497891`
-- **Message:** `test(scraping-broadcasting): close coverage gaps for bulk scraper and broadcaster`
-- **Files changed:** 2 files, 816 insertions (broadcaster_test.rb new, bulk_source_scraper_test.rb extended)
-
-- **Hash:** `66b8df2` (tag commit)
-- **Message:** `test(dev-plan05): close coverage gaps for bulk scraper and broadcaster`
-- **Note:** This commit also contained Plan 03 (configuration-tests) work; see PLAN-03-SUMMARY.md.
-
-## Tasks Completed
-
-### Task 1: Test BulkSourceScraper disabled and invalid selection paths
-- Tested scraping_enabled: false returns error result with failure_details
-- Tested Result struct methods: success?, partial?, error?, rate_limited?
-- Tested normalize_selection with symbol, string, whitespace, uppercase, nil, invalid
-- Tested selection_label with valid and invalid selection values
-
-### Task 2: Test BulkSourceScraper batch limiting and determine_status
-- Tested apply_batch_limit respects max_bulk_batch_size from config
-- Tested determine_status returns :success, :partial, :error based on counts
-- Tested determine_status :partial when only already_enqueued > 0
-- Tested without_inflight excludes items with in-flight scrape_status
-- Tested unknown enqueuer status handling
-
-### Task 3: Test Broadcaster setup and broadcast_source/broadcast_item
-- Created new test file: test/lib/source_monitor/realtime/broadcaster_test.rb
-- Tested setup! registers after_fetch_completed and after_item_scraped callbacks
-- Tested setup! idempotent (no double-registration)
-- Tested broadcast_source returns early when turbo_available? is false
-- Tested broadcast_source returns early when source is nil after reload
-- Tested broadcast_source calls broadcast_source_row and broadcast_source_show
-- Tested broadcast_item calls Turbo::StreamsChannel with correct target/partial
-- Tested broadcast_item rescues errors and logs them
-
-### Task 4: Test Broadcaster toast broadcasting and event handlers
-- Tested broadcast_toast returns early when turbo_available? is false or message blank
-- Tested broadcast_toast calls Turbo::StreamsChannel.broadcast_append_to
-- Tested handle_fetch_completed broadcasts source and toast for each status
-- Tested broadcast_fetch_toast for "fetched", "not_modified", "failed" statuses
-- Tested handle_item_scraped broadcasts item, source, and toast
-- Tested broadcast_item_toast for success and failed statuses
-
-### Task 5: Test Broadcaster helpers
-- Tested reload_record returns nil for nil input, original record on reload error
-- Tested turbo_available? true/false based on Turbo::StreamsChannel defined
-- Tested register_callback no double-registration
-- Tested log_error swallows errors from logger itself
-- Tested broadcast_source_row and broadcast_source_show rescue and log errors
-
-## Deviations
-
-| ID | Description | Impact |
-|----|-------------|--------|
-| DEVN-01 | Commit 66b8df2 bundled Plan 03 (configuration) and Plan 05 (scraping/broadcasting) work | No functional impact; both sets of tests pass independently |
-
-## Verification Results
-
-| Check | Result |
-|-------|--------|
-| `PARALLEL_WORKERS=1 bin/rails test test/lib/source_monitor/scraping/bulk_source_scraper_test.rb test/lib/source_monitor/realtime/broadcaster_test.rb` | All tests pass |
-| `bin/rails test` | 760 runs, 2626 assertions, 0 failures, 0 errors, 0 skips |
-
-## Success Criteria
-
-- [x] 15 new BulkSourceScraper tests (270 lines) + 35 new Broadcaster tests (546 lines)
-- [x] BulkSourceScraper disabled/invalid/batch/status paths tested
-- [x] Broadcaster setup, broadcasting, toast, and event handlers tested
-- [x] Broadcaster error swallowing and helper methods tested
-- [x] REQ-05 and REQ-06 substantially satisfied