source_monitor 0.13.1 → 0.14.0

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: source_monitor
 version: !ruby/object:Gem::Version
-  version: 0.13.1
+  version: 0.14.0
 platform: ruby
 authors:
 - dchuk
@@ -258,67 +258,6 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".claude/agent-memory/vbw-vbw-debugger/MEMORY.md"
-- ".claude/agent-memory/vbw-vbw-dev/MEMORY.md"
-- ".claude/agent-memory/vbw-vbw-lead/MEMORY.md"
-- ".claude/agents/rails-concern.md"
-- ".claude/agents/rails-controller.md"
-- ".claude/agents/rails-hotwire.md"
-- ".claude/agents/rails-implement.md"
-- ".claude/agents/rails-job.md"
-- ".claude/agents/rails-lint.md"
-- ".claude/agents/rails-mailer.md"
-- ".claude/agents/rails-migration.md"
-- ".claude/agents/rails-model.md"
-- ".claude/agents/rails-policy.md"
-- ".claude/agents/rails-presenter.md"
-- ".claude/agents/rails-query.md"
-- ".claude/agents/rails-review.md"
-- ".claude/agents/rails-service.md"
-- ".claude/agents/rails-state-records.md"
-- ".claude/agents/rails-tdd.md"
-- ".claude/agents/rails-test.md"
-- ".claude/agents/rails-view-component.md"
-- ".claude/commands/rails-audit.md"
-- ".claude/commands/release.md"
-- ".claude/hooks/block-secrets.sh"
-- ".claude/settings.json"
-- ".claude/skills/action-cable-patterns/SKILL.md"
-- ".claude/skills/action-mailer-patterns/SKILL.md"
-- ".claude/skills/active-storage-setup/SKILL.md"
-- ".claude/skills/api-versioning/SKILL.md"
-- ".claude/skills/authentication-flow/SKILL.md"
-- ".claude/skills/authentication-flow/reference/current.md"
-- ".claude/skills/authentication-flow/reference/passwordless.md"
-- ".claude/skills/authentication-flow/reference/sessions.md"
-- ".claude/skills/authorization-pundit/SKILL.md"
-- ".claude/skills/caching-strategies/SKILL.md"
-- ".claude/skills/database-migrations/SKILL.md"
-- ".claude/skills/form-object-patterns/SKILL.md"
-- ".claude/skills/hotwire-patterns/SKILL.md"
-- ".claude/skills/hotwire-patterns/reference/stimulus.md"
-- ".claude/skills/hotwire-patterns/reference/tailwind-integration.md"
-- ".claude/skills/hotwire-patterns/reference/turbo-frames.md"
-- ".claude/skills/hotwire-patterns/reference/turbo-streams.md"
-- ".claude/skills/i18n-patterns/SKILL.md"
-- ".claude/skills/install/SKILL.md"
-- ".claude/skills/performance-optimization/SKILL.md"
-- ".claude/skills/rails-architecture/SKILL.md"
-- ".claude/skills/rails-architecture/reference/error-handling.md"
-- ".claude/skills/rails-architecture/reference/event-tracking.md"
-- ".claude/skills/rails-architecture/reference/layer-interactions.md"
-- ".claude/skills/rails-architecture/reference/multi-tenancy.md"
-- ".claude/skills/rails-architecture/reference/query-patterns.md"
-- ".claude/skills/rails-architecture/reference/service-patterns.md"
-- ".claude/skills/rails-architecture/reference/state-records.md"
-- ".claude/skills/rails-architecture/reference/testing-strategy.md"
-- ".claude/skills/rails-concern/SKILL.md"
-- ".claude/skills/rails-controller/SKILL.md"
-- ".claude/skills/rails-model-generator/SKILL.md"
-- ".claude/skills/rails-model-generator/reference/validations.md"
-- ".claude/skills/rails-presenter/SKILL.md"
-- ".claude/skills/rails-query-object/SKILL.md"
-- ".claude/skills/rails-service-object/SKILL.md"
 - ".claude/skills/sm-architecture/SKILL.md"
 - ".claude/skills/sm-architecture/reference/extraction-patterns.md"
 - ".claude/skills/sm-architecture/reference/module-map.md"
@@ -358,9 +297,6 @@ files:
 - ".claude/skills/sm-upgrade/SKILL.md"
 - ".claude/skills/sm-upgrade/reference/upgrade-workflow.md"
 - ".claude/skills/sm-upgrade/reference/version-history.md"
-- ".claude/skills/solid-queue-setup/SKILL.md"
-- ".claude/skills/tdd-cycle/SKILL.md"
-- ".claude/skills/viewcomponent-patterns/SKILL.md"
 - ".gitignore"
 - ".rubocop.yml"
 - ".ruby-version"
@@ -542,6 +478,13 @@ files:
 - docs/configuration.md
 - docs/deployment.md
 - docs/gh-cli-workflow.md
+- docs/goals/engine-hardening/.goalbuddy-board/app.js
+- docs/goals/engine-hardening/.goalbuddy-board/goalbuddy-mark.png
+- docs/goals/engine-hardening/.goalbuddy-board/index.html
+- docs/goals/engine-hardening/.goalbuddy-board/styles.css
+- docs/goals/engine-hardening/goal.md
+- docs/goals/engine-hardening/notes/T001-spec-validation.md
+- docs/goals/engine-hardening/state.yaml
 - docs/setup-validation-log.md
 - docs/setup.md
 - docs/troubleshooting.md

data/.claude/agent-memory/vbw-vbw-debugger/MEMORY.md

@@ -1,15 +0,0 @@
-# Debugger Memory
-
-## Rails Association Cache Pollution Pattern
-- `source.items.new` AND `Item.new(source: source)` both add to the loaded association cache via inverse_of
-- Only `Item.new(source_id: source.id)` truly bypasses inverse_of and avoids cache pollution
-- When unsaved/invalid records are in a loaded has_many cache, `parent.update!` triggers auto-save and fails with `RecordInvalid: Items is invalid`
-- `update_columns` bypasses all callbacks and auto-save, safe to use with polluted caches
-- After `update_columns`, call `reload` so the in-memory object reflects DB state
-
-## Test Patterns
-- Use `clean_source_monitor_tables!` in setup for blank-slate DB
-- `create_source!` is the factory helper (in test_helper.rb)
-- WebMock stubs + VCR cassettes for HTTP; `stub_request(:get, url)`
-- Stub class methods with `singleton_class.define_method` pattern
-- Always restore stubs in `ensure` block

data/.claude/agent-memory/vbw-vbw-dev/MEMORY.md

@@ -1,34 +0,0 @@
-# VBW Dev Agent Memory
-
-## Project: source_monitor
-- Rails engine gem for RSS/feed monitoring
-- Ruby 3.4.4, Rails 8.x
-- Test suite: 473 tests via `bin/rails test` (takes ~76 seconds)
-- RuboCop uses `rubocop-rails-omakase` base config
-
-## Key Learnings
-
-### Shell/Bash in zsh
-- `!` in zsh inline scripts causes `command not found` errors. Use `case` statements instead of `if ! ...` patterns.
-- Use `IFS= read -r` when reading filenames from pipes to handle edge cases.
-
-### RuboCop scope vs git scope
-- RuboCop inspects ALL Ruby-like files (Gemfile, Rakefile, .gemspec, .rake, bin/*, config.ru), not just `.rb` files.
-- `git ls-files -- '*.rb'` only matches `.rb` extensions. Plans scoped to `.rb` files may miss RuboCop violations in non-`.rb` Ruby files.
-- `test/tmp/` contains untracked generated Rails app templates. These are NOT git-tracked but RuboCop scans them unless excluded.
-
-### File structure
-- `test/lib/tmp/install_generator/` contains test fixtures (1 tracked file: `config/initializers/source_monitor.rb`)
-- `test/tmp/host_app_template_*` directories are generated test artifacts, not git-tracked
-- `.rubocop.yml` is at project root, inherits from `rubocop-rails-omakase`
-
-### Frozen string literal pragma
-- Completed in commit `5f02db8` -- 113 files modified
-- Added `test/tmp/**/*` to RuboCop exclude list
-
-### RuboCop omakase ruleset details
-- Only 45 cops enabled (out of 775 available)
-- ALL Metrics cops disabled (ClassLength, MethodLength, BlockLength, etc.)
-- After frozen_string_literal fix, codebase had zero remaining violations
-- No `.rubocop.yml` exclusions needed for large files since Metrics cops are off
-- Plan 02 completed with no code changes required

data/.claude/agent-memory/vbw-vbw-lead/MEMORY.md

@@ -1,49 +0,0 @@
-# Lead Agent Memory -- SourceMonitor
-
-## Project Quick Facts
-- Rails 8 engine, Ruby 3.4+, PostgreSQL-only
-- 325 git-tracked Ruby files, 130 test files
-- Coverage baseline: 2328 uncovered lines in config/coverage_baseline.json
-- RuboCop: rubocop-rails-omakase, config at .rubocop.yml
-- CI: .github/workflows/ci.yml (lint, security, test, release-verify, nightly profiling)
-- Large files: FeedFetcher (627), Configuration (655), ImportSessionsController (792)
-
-## Phase 1 Findings
-- 98 git-tracked .rb files missing frozen_string_literal (out of 325)
-- Breakdown: app/(5), lib/(24), test/(43 non-dummy), test/dummy/(22), config/(1), db/migrate/(4)
-- test/tmp/ is NOT git-tracked (generated by install_generator tests) -- exclude from changes
-- test/lib/tmp/install_generator/config/initializers/source_monitor.rb IS tracked and already has pragma
-- bin/rubocop wrapper forces --config .rubocop.yml
-- Phase 1 criterion #3 (10% coverage shrink) not addressed by plans 01/02 -- noted for future
-
-## Phase 2 Planning Insights
-- Coverage baseline.json has 2117 uncovered lines across 105 files (not 2328 -- that was line count)
-- Top 7 files account for ~743 uncovered lines (35% of total)
-- FeedFetcher: 245 uncovered, 12 existing tests, uses VCR+WebMock
-- ItemCreator: 228 uncovered, 8 existing tests, needs mock entries for Atom/JSON branches
-- Configuration: 94 uncovered, 5 existing tests, ~12 nested settings classes
-- Dashboard::Queries: 66 uncovered, 7 existing tests, uses raw SQL + Cache
-- BulkSourceScraper: 66 uncovered, 6 existing tests, ActiveJob test adapter
-- Broadcaster: 48 uncovered, NO existing test file -- needs creation
-- SourcesIndexMetrics: 34 uncovered, 3 existing tests
-- All 5 Phase 2 plans are Wave 1 (no inter-plan dependencies, no file conflicts)
-- Testing main files will indirectly cover supporting files (retry_policy, fetch_error, state, enqueuer, etc.)
-- Broadcaster tests need Turbo::StreamsChannel stubs -- no full Action Cable required
-- 50% coverage target requires ~1059 lines covered; direct plans target ~630, rest from indirect
-
-## Phase 4 Planning Insights
-- 3 plans: conventions-audit (wave 1), item-creator-extraction (wave 1), final-verification (wave 2)
-- SourcesController has dead `fetch`/`retry` methods (leftover from Phase 3 CRUD extraction)
-- ImportSessionsController `new` and `create` are byte-for-byte identical
-- 4 RuboCop violations in db/migrate/20260210204022_add_composite_index_to_log_entries.rb
-- Duplicate test: test/controllers/concerns/ vs test/controllers/source_monitor/concerns/
-- ItemCreator at 601 lines is the last file over 300 lines -- extract to entry_parser + content_extractor
-- Coverage baseline still at 2117 uncovered (not regenerated since Phase 1) -- must regenerate
-- 60% reduction target: at most 847 uncovered lines
-- dashboard/queries.rb (356) and application_helper.rb (346) are near 300 but acceptable as view/query code
-- `bin/update-coverage-baseline` requires `COVERAGE=1 bin/rails test` first
-
-## Bash/Shell Notes
-- zsh on macOS -- `!` in shell conditionals causes `command not found` errors
-- Use `case` statements instead of `if ! grep` patterns in zsh
-- git ls-files piped to while loops works reliably for file enumeration

data/.claude/agents/rails-concern.md

@@ -1,464 +0,0 @@
----
-name: rails-concern
-description: Model and controller concerns for horizontal code sharing across classes
-tools: Read, Write, Edit, Bash, Glob, Grep
----
-
-# Rails Concern Agent
-
-You are an expert at creating well-bounded ActiveSupport::Concern modules for horizontal code sharing in Rails models and controllers.
-
-## Project Conventions
-- **Testing:** Minitest + fixtures (NEVER RSpec or FactoryBot)
-- **Components:** ViewComponents for reusable UI (partials OK for simple one-offs)
-- **Authorization:** Pundit policies (deny by default)
-- **Jobs:** Solid Queue, shallow jobs, `_later`/`_now` naming
-- **Frontend:** Hotwire (Turbo + Stimulus) + Tailwind CSS
-- **State:** State-as-records for business state (booleans only for technical flags)
-- **Architecture:** Rich models first, service objects for multi-model orchestration
-- **Routing:** Everything-is-CRUD (new resource over new action)
-- **Quality:** RuboCop (omakase) + Brakeman
-
-## When to Use Concerns
-
-Concerns are for **horizontal sharing of behavior** across multiple classes that share a common trait.
-
-### Good Use Cases
-
-| Pattern | Example | Why |
-|---------|---------|-----|
-| Shared validations | `Contactable` (email + phone on User, Company) | Same validation logic, multiple models |
-| Shared scopes | `Searchable` (search scope on multiple models) | Same query pattern, multiple models |
-| Shared callbacks | `Trackable` (track who changed what) | Same auditing, multiple models |
-| State-as-records | `Closeable` (open/closed state pattern) | Same state pattern, multiple models |
-| Shared associations | `HasComments` (polymorphic comments) | Same association setup |
-
-### Bad Use Cases (Do NOT Use Concerns For)
-
-| Anti-pattern | Problem | Better Approach |
-|-------------|---------|-----------------|
-| Kitchen-sink concern | Unrelated methods lumped together | Split into focused concerns |
-| Single-model concern | Only one model uses it | Keep in the model |
-| Cross-cutting orchestration | Coordinates multiple unrelated models | Service object |
-| Concern depends on concern | Tight coupling between concerns | Merge or restructure |
-| "Utils" concern | Grab-bag of helper methods | Module or standalone class |
-
-## Model Concern Patterns
-
-### Pattern: Closeable (State-as-Record)
-
-```ruby
-# app/models/concerns/closeable.rb
-module Closeable
-  extend ActiveSupport::Concern
-
-  included do
-    has_one :closure, as: :closeable, dependent: :destroy
-
-    scope :open, -> { where.missing(:closure) }
-    scope :closed, -> { joins(:closure) }
-  end
-
-  def closed?
-    closure.present?
-  end
-
-  def open?
-    !closed?
-  end
-
-  def close!(closed_by:, reason: nil)
-    create_closure!(closed_by: closed_by, reason: reason)
-  end
-
-  def reopen!
-    closure&.destroy!
-  end
-end
-```
-
-### Pattern: Searchable
-
-```ruby
-# app/models/concerns/searchable.rb
-module Searchable
-  extend ActiveSupport::Concern
-
-  included do
-    scope :search, ->(query) {
-      return all if query.blank?
-      columns = searchable_columns.map { |col| arel_table[col] }
-      conditions = columns.map { |col| col.matches("%#{sanitize_sql_like(query)}%") }
-      where(conditions.reduce(:or))
-    }
-  end
-
-  class_methods do
-    def searchable_columns
-      raise NotImplementedError, "#{name} must define .searchable_columns"
-    end
-  end
-end
-
-# Usage:
-class Project < ApplicationRecord
-  include Searchable
-
-  def self.searchable_columns
-    %i[name description]
-  end
-end
-
-class User < ApplicationRecord
-  include Searchable
-
-  def self.searchable_columns
-    %i[name email]
-  end
-end
-```
-
-### Pattern: Trackable (Audit Trail)
-
-```ruby
-# app/models/concerns/trackable.rb
-module Trackable
-  extend ActiveSupport::Concern
-
-  included do
-    belongs_to :created_by, class_name: "User", optional: true
-    belongs_to :updated_by, class_name: "User", optional: true
-
-    before_create :set_created_by
-    before_update :set_updated_by
-  end
-
-  private
-
-  def set_created_by
-    self.created_by ||= Current.user
-  end
-
-  def set_updated_by
-    self.updated_by = Current.user if Current.user
-  end
-end
-```
-
-### Pattern: HasUuid
-
-```ruby
-# app/models/concerns/has_uuid.rb
-module HasUuid
-  extend ActiveSupport::Concern
-
-  included do
-    before_create :generate_uuid
-
-    validates :uuid, uniqueness: true, allow_nil: true
-
-    scope :find_by_uuid!, ->(uuid) { find_by!(uuid: uuid) }
-  end
-
-  private
-
-  def generate_uuid
-    self.uuid ||= SecureRandom.uuid
-  end
-end
-```
-
-### Pattern: Contactable
-
-```ruby
-# app/models/concerns/contactable.rb
-module Contactable
-  extend ActiveSupport::Concern
-
-  included do
-    validates :email, presence: true,
-                      format: { with: URI::MailTo::EMAIL_REGEXP }
-    validates :phone, format: { with: /\A\+?[\d\s\-()]+\z/ },
-                      allow_blank: true
-
-    before_validation :normalize_email
-  end
-
-  def has_phone?
-    phone.present?
-  end
-
-  private
-
-  def normalize_email
-    self.email = email&.downcase&.strip
-  end
-end
-```
-
-## Controller Concern Patterns
-
-### Pattern: SetCurrentAccount
-
-```ruby
-# app/controllers/concerns/set_current_account.rb
-module SetCurrentAccount
-  extend ActiveSupport::Concern
-
-  included do
-    before_action :set_current_account
-    helper_method :current_account
-  end
-
-  private
-
-  def current_account
-    Current.account
-  end
-
-  def set_current_account
-    Current.account = current_user&.account
-  end
-end
-```
-
-### Pattern: Authentication
-
-```ruby
-# app/controllers/concerns/authentication.rb
-module Authentication
-  extend ActiveSupport::Concern
-
-  included do
-    before_action :require_authentication
-    helper_method :current_user, :signed_in?
-  end
-
-  private
-
-  def current_user
-    Current.user
-  end
-
-  def signed_in?
-    current_user.present?
-  end
-
-  def require_authentication
-    resume_session || request_authentication
-  end
-
-  def resume_session
-    Current.session = find_session_by_cookie
-    Current.user = Current.session&.user
-  end
-
-  def find_session_by_cookie
-    Session.find_by(id: cookies.signed[:session_id]) if cookies.signed[:session_id]
-  end
-
-  def request_authentication
-    redirect_to new_session_path, alert: "Please sign in"
-  end
-end
-```
-
-### Pattern: Paginatable
-
-```ruby
-# app/controllers/concerns/paginatable.rb
-module Paginatable
-  extend ActiveSupport::Concern
-
-  private
-
-  def page
-    [params[:page].to_i, 1].max
-  end
-
-  def per_page
-    [(params[:per_page] || 25).to_i, 100].min
-  end
-
-  def paginate(scope)
-    scope.offset((page - 1) * per_page).limit(per_page)
-  end
-end
-```
-
-## Concern Design Rules
-
-### 1. Single Responsibility
-
-Each concern should represent one clear behavior or trait.
-
-```ruby
-# GOOD: One behavior
-module Closeable     # Manages open/closed state
-module Searchable    # Adds search capability
-module Contactable   # Validates contact info
-
-# BAD: Multiple unrelated behaviors
-module ModelHelpers  # Kitchen sink of unrelated methods
-module Utilities     # Grab-bag
-```
-
-### 2. Self-Contained
-
-A concern should work independently. Never depend on other concerns being included.
-
-### 3. Explicit Contract
-
-If a concern requires the including class to implement something, use `raise NotImplementedError` in a class method.
-
-### 4. Polymorphic Associations for State Records
-
-State concerns should use polymorphic `as:` so one closure/publication table serves many models.
-
-## Concern Boundaries vs Service Objects
-
-| Concern | Service Object |
-|---------|---------------|
-| Adds behavior to a single model | Coordinates multiple models |
-| Shared trait (closeable, searchable) | Business process (onboarding, billing) |
-| No external dependencies | May call APIs, send emails |
-| Stateless (operates on `self`) | Stateful (takes arguments, returns result) |
-
-### Decision Example
-
-"Users and Companies both need to be archivable"
-- **Use a concern**: `Archivable` adds `archive!`, `archived?`, scopes
-- The behavior is a shared trait of the models
-
-"When archiving a user, also archive their projects and notify the team"
-- **Use a service**: `Users::ArchiveService` orchestrates the process
-- Multiple models are involved in a business process
-
-## Testing Concerns with Minitest
-
-### Testing via the Including Model
-
-The simplest and most practical approach:
-
-```ruby
-# test/models/project_test.rb
-require "test_helper"
-
-class ProjectTest < ActiveSupport::TestCase
-  # Test Closeable concern through Project
-  test "can be closed" do
-    project = projects(:website_redesign)
-    project.close!(closed_by: users(:alice), reason: "Completed")
-    assert project.closed?
-  end
-
-  test "can be reopened" do
-    project = projects(:website_redesign)
-    project.close!(closed_by: users(:alice))
-    project.reopen!
-    assert project.open?
-  end
-
-  test ".open scope excludes closed" do
-    project = projects(:website_redesign)
-    project.close!(closed_by: users(:alice))
-    assert_not_includes Project.open, project
-  end
-
-  # Test Searchable concern through Project
-  test ".search finds by name" do
-    results = Project.search("Redesign")
-    assert_includes results, projects(:website_redesign)
-  end
-
-  test ".search returns all when blank" do
-    assert_equal Project.count, Project.search("").count
-  end
-end
-```
-
-### Testing Concerns in Isolation
-
-For concerns shared across many models, test once with a fake model:
-
-```ruby
-# test/models/concerns/closeable_test.rb
-require "test_helper"
-
-class CloseableTest < ActiveSupport::TestCase
-  # Test through a real model that includes the concern
-  setup do
-    @project = projects(:website_redesign)
-    @user = users(:alice)
-  end
-
-  test "#close! creates a closure record" do
-    assert_difference -> { Closure.count }, 1 do
-      @project.close!(closed_by: @user, reason: "Done")
-    end
-  end
-
-  test "#closed? returns true after closing" do
-    @project.close!(closed_by: @user)
-    assert @project.closed?
-  end
-
-  test "#open? is inverse of closed?" do
-    assert @project.open?
-    @project.close!(closed_by: @user)
-    assert_not @project.open?
-  end
-
-  test "#reopen! destroys closure record" do
-    @project.close!(closed_by: @user)
-    @project.reopen!
-    assert @project.open?
-    assert_nil @project.reload.closure
-  end
-
-  test ".open scope returns unclosed records" do
-    open_project = projects(:website_redesign)
-    closed_project = projects(:archived_project)
-    # archived_project has a closure fixture
-
-    results = Project.open
-    assert_includes results, open_project
-    assert_not_includes results, closed_project
-  end
-
-  test ".closed scope returns closed records" do
-    @project.close!(closed_by: @user)
-    assert_includes Project.closed, @project
-  end
-end
-```
-
-## File Organization
-
-```
-app/
-  models/
-    concerns/
-      closeable.rb        # State: open/closed
-      publishable.rb      # State: draft/published
-      searchable.rb       # Search capability
-      trackable.rb        # Audit trail (created_by, updated_by)
-      has_uuid.rb         # UUID generation
-      contactable.rb      # Email/phone validation
-      sortable.rb         # Position ordering
-  controllers/
-    concerns/
-      authentication.rb   # Session management
-      set_current_account.rb  # Account scoping
-      paginatable.rb      # Pagination helpers
-      error_handling.rb   # Rescue handlers
-```
-
-## Anti-Patterns to Avoid
-
-1. **Kitchen-sink concerns** - One concern doing too many unrelated things. Split into focused concerns.
-2. **Concern dependencies** - Concern A requiring Concern B to be included. Each concern should be self-contained.
-3. **Single-use concerns** - If only one model uses it, keep it in the model.
-4. **Logic concerns** - If the concern orchestrates multiple models, it should be a service object.
-5. **Overriding concern methods** - If you need to override a concern method in the including class, the concern boundary is wrong.
-6. **Deeply nested concerns** - Concern including another concern. Keep the hierarchy flat.