solidus_six_saferpay 0.2.0 → 0.3.0

data/spec/support/shared_examples/inquire_payment.rb

@@ -0,0 +1,118 @@
+RSpec.shared_examples 'inquire_payment' do
+
+  before do
+    allow(subject).to receive(:gateway).and_return(double('gateway', inquire: gateway_response))
+  end
+
+  context 'when gateway response is not successful' do
+    let(:gateway_success) { false }
+    let(:error_behaviour) { "ABORT" }
+    let(:error_name) { "VALIDATION_FAILED" }
+    let(:error_message) { "Request validation failed" }
+    let(:api_response) { nil }
+    let(:translated_general_error) { "General Error" }
+    let(:translated_user_message) { "User Message" }
+
+    let(:gateway_response) do
+      ::SolidusSixSaferpay::GatewayResponse.new(
+        gateway_success,
+        "initialize success: #{gateway_success}",
+        api_response,
+        error_name: error_name,
+      )
+    end
+
+    it 'still indicates success' do
+      subject.call
+
+      expect(subject).to be_success
+    end
+
+    it 'adds the error message to the response hash' do
+      expect { subject.call }.to change { payment.response_hash }.from({}).to({error: error_name})
+    end
+
+    it 'sets the user message according to the api error code' do
+      expect(I18n).to receive(:t).with(:general_error, scope: [:solidus_six_saferpay, :errors]).once.and_return(translated_general_error)
+      expect(I18n).to receive(:t).with(error_name, scope: [:six_saferpay, :error_names]).once.and_return(translated_user_message)
+
+      subject.call
+
+      expect(subject.user_message).to eq("#{translated_general_error}: #{translated_user_message}")
+    end
+  end
+
+  context 'when gateway response is successful' do
+    let(:transaction_status) { "AUTHORIZED" }
+    let(:transaction_id) { "723n4MAjMdhjSAhAKEUdA8jtl9jb" }
+    let(:transaction_date) { "2015-01-30T12:45:22.258+01:00" }
+    let(:amount_value) { "100" }
+    let(:amount_currency) { "USD" }
+    let(:brand_name) { 'PaymentBrand' }
+    let(:display_text) { "xxxx xxxx xxxx 1234" }
+    let(:six_transaction_reference) { "0:0:3:723n4MAjMdhjSAhAKEUdA8jtl9jb" }
+
+    let(:payment_means) do
+      SixSaferpay::ResponsePaymentMeans.new(
+        brand: SixSaferpay::Brand.new(name: brand_name),
+        display_text: display_text
+      )
+    end
+
+    # https://saferpay.github.io/jsonapi/#Payment_v1_PaymentPage_Assert
+    # https://saferpay.github.io/jsonapi/#Payment_v1_Transaction_Authorize
+    let(:api_response) do
+      api_response_class.new(
+        response_header: SixSaferpay::ResponseHeader.new(request_id: 'test', spec_version: 'test'),
+        transaction: SixSaferpay::Transaction.new(
+          type: "PAYMENT",
+          status: transaction_status,
+          id: transaction_id,
+          date: transaction_date,
+          amount: SixSaferpay::Amount.new(value: amount_value, currency_code: amount_currency),
+          six_transaction_reference: six_transaction_reference,
+        ),
+        payment_means: payment_means
+      )
+    end
+
+    let(:gateway_success) { true }
+    let(:gateway_response) do
+      ::SolidusSixSaferpay::GatewayResponse.new(
+        gateway_success,
+        "initialize success: #{gateway_success}",
+        api_response
+      )
+    end
+
+    it 'updates the transaction_id' do
+      expect { subject.call }.to change { payment.transaction_id }.from(nil).to(transaction_id)
+    end
+
+    it 'updates the transaction status' do
+      expect { subject.call }.to change { payment.transaction_status }.from(nil).to(transaction_status)
+    end
+
+    it 'updates the transaction date' do
+      expect { subject.call }.to change { payment.transaction_date }.from(nil).to(DateTime.parse(transaction_date))
+    end
+
+    it 'updates the six_transaction_reference' do
+      expect { subject.call }.to change { payment.six_transaction_reference }.from(nil).to(six_transaction_reference)
+    end
+
+    it 'updates the display_text' do
+      expect { subject.call }.to change { payment.display_text }.from(nil).to(display_text)
+    end
+
+    it 'updates the response hash' do
+      expect { subject.call }.to change { payment.response_hash }.from(payment.response_hash).to(api_response.to_h)
+    end
+
+    it 'indicates success' do
+      subject.call
+
+      expect(subject).to be_success
+    end
+  end
+end

data/spec/support/shared_examples/process_authorized_payment.rb

@@ -0,0 +1,202 @@
+RSpec.shared_examples 'process_authorized_payment' do
+  before do
+    allow(subject).to receive(:gateway).and_return(double('gateway'))
+  end
+
+  context 'liability_shift check' do
+
+    before do
+      # ensure other methods don't modify outcome
+      allow(subject).to receive(:validate_payment!)
+      allow(subject).to receive(:cancel_old_solidus_payments)
+      allow(payment).to receive(:create_solidus_payment!)
+    end
+
+    context 'when liability shift is required' do
+      context 'and liability shift is not granted' do
+
+        let(:payment) { create(:six_saferpay_payment, :authorized, :without_liability_shift) }
+
+        it 'cancels the payment' do
+          expect(payment.payment_method.preferred_require_liability_shift).to be true
+          expect(payment.liability.liability_shift).to be false
+
+          expect(subject.gateway).to receive(:void).with(payment.transaction_id)
+
+          subject.call
+        end
+
+        it 'indicates failure' do
+          expect(payment.payment_method.preferred_require_liability_shift).to be true
+          expect(payment.liability.liability_shift).to be false
+
+          expect(subject.gateway).to receive(:void).with(payment.transaction_id)
+
+          subject.call
+
+          expect(subject).not_to be_success
+        end
+
+      end
+
+      context 'and liability shift is granted' do
+        it "doesn't cancel the payment" do
+          expect(payment.payment_method.preferred_require_liability_shift).to be true
+          expect(payment.liability.liability_shift).to be true
+
+          expect(subject.gateway).not_to receive(:void)
+
+          subject.call
+        end
+
+        it 'passes the liability shift check' do
+          expect(payment.payment_method.preferred_require_liability_shift).to be true
+          expect(payment.liability.liability_shift).to be true
+
+          subject.call
+
+          expect(subject).to be_success
+        end
+      end
+    end
+
+    context 'when liability shift is not required' do
+      let(:payment_method) { create(:saferpay_payment_method, :no_require_liability_shift) }
+
+      context 'and liability shift is not granted' do
+        let(:payment) { create(:six_saferpay_payment, :authorized, :without_liability_shift, payment_method: payment_method) }
+
+        it "doesn't cancel the payment" do
+          expect(payment.payment_method.preferred_require_liability_shift).to be false
+          expect(payment.liability.liability_shift).to be false
+
+          expect(subject.gateway).not_to receive(:void)
+
+          subject.call
+        end
+
+        it 'passes the liability shift check' do
+          expect(payment.payment_method.preferred_require_liability_shift).to be false
+          expect(payment.liability.liability_shift).to be false
+          subject.call
+
+          expect(subject).to be_success
+        end
+      end
+
+      context 'and liability shift is granted' do
+        let(:payment) { create(:six_saferpay_payment, :authorized, payment_method: payment_method) }
+        it "doesn't cancel the payment" do
+          expect(payment.payment_method.preferred_require_liability_shift).to be false
+          expect(payment.liability.liability_shift).to be true
+
+          expect(subject.gateway).not_to receive(:void)
+
+          subject.call
+        end
+
+        it 'passes the liability shift check' do
+          expect(payment.payment_method.preferred_require_liability_shift).to be false
+          expect(payment.liability.liability_shift).to be true
+          subject.call
+
+          expect(subject).to be_success
+        end
+      end
+    end
+  end
+
+  context 'payment validation' do
+    before do
+      allow(subject).to receive(:gateway).and_return(double('gateway'))
+
+
+      # ensure other methods don't modify outcome
+      allow(subject).to receive(:check_liability_shift_requirements!)
+      allow(subject).to receive(:cancel_old_solidus_payments)
+      allow(payment).to receive(:create_solidus_payment!)
+    end
+
+    it 'validates the payment' do
+      expect(Spree::SolidusSixSaferpay::PaymentValidator).to receive(:call).with(payment)
+      subject.call
+    end
+
+    context 'when the payment is invalid' do
+      it 'cancels the payment' do
+        expect(subject.gateway).to receive(:void).with(payment.transaction_id)
+
+        subject.call
+      end
+
+      it 'indicates failure' do
+        allow(subject.gateway).to receive(:void).with(payment.transaction_id)
+
+        subject.call
+
+        expect(subject).not_to be_success
+      end
+    end
+
+    context 'when the payment is valid' do
+      before do
+        allow(Spree::SolidusSixSaferpay::PaymentValidator).to receive(:call).with(payment).and_return(true)
+      end
+
+      it "doesn't cancel the payment" do
+        expect(subject.gateway).not_to receive(:void)
+
+        subject.call
+      end
+
+      it 'indicates success' do
+        subject.call
+
+        expect(subject).to be_success
+      end
+    end
+  end
+
+  context 'when the payment has passed all validations' do
+    before do
+      allow(subject).to receive(:check_liability_shift_requirements!).and_return(true)
+      allow(subject).to receive(:validate_payment!).and_return(true)
+    end
+
+    context 'when previous solidus payments exist for this order' do
+      let(:order) { payment.order }
+      let!(:previous_payment_invalid) { create(:payment_using_saferpay, order: order) }
+      let!(:previous_payment_checkout) { create(:payment_using_saferpay, order: order) }
+
+      before do
+        # This is bad practice because we mock which payments are invalidated here.
+        # The reason is that you can't stub methods on AR objects that
+        # are loaded from the DB and because #solidus_payments_to_cancel
+        # is just AR scopes, I prefer this test over using stuff like
+        # #expect_any_instance_of
+        allow(subject).to receive(:solidus_payments_to_cancel).and_return([previous_payment_checkout])
+      end
+
+      it 'cancels old solidus payments' do
+        expect(previous_payment_invalid).not_to receive(:cancel!)
+        expect(previous_payment_checkout).to receive(:cancel!)
+
+        subject.call
+      end
+    end
+
+    it 'creates a new solidus payment' do
+      expect(payment).to receive(:create_solidus_payment!)
+
+      subject.call
+    end
+
+    it 'indicates success' do
+      allow(payment).to receive(:create_solidus_payment!)
+
+      subject.call
+
+      expect(subject).to be_success
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: solidus_six_saferpay
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Simon Kiener
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-05-27 00:00:00.000000000 Z
+date: 2020-06-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: solidus_core
@@ -216,12 +216,12 @@ files:
 - app/services/spree/solidus_six_saferpay/assert_payment_page.rb
 - app/services/spree/solidus_six_saferpay/authorize_payment.rb
 - app/services/spree/solidus_six_saferpay/authorize_transaction.rb
+- app/services/spree/solidus_six_saferpay/cancel_authorized_payment.rb
 - app/services/spree/solidus_six_saferpay/initialize_payment.rb
 - app/services/spree/solidus_six_saferpay/initialize_payment_page.rb
 - app/services/spree/solidus_six_saferpay/initialize_transaction.rb
 - app/services/spree/solidus_six_saferpay/inquire_payment.rb
 - app/services/spree/solidus_six_saferpay/inquire_payment_page_payment.rb
-- app/services/spree/solidus_six_saferpay/inquire_transaction.rb
 - app/services/spree/solidus_six_saferpay/inquire_transaction_payment.rb
 - app/services/spree/solidus_six_saferpay/payment_validator.rb
 - app/services/spree/solidus_six_saferpay/process_authorized_payment.rb
@@ -233,7 +233,7 @@ files:
 - app/views/spree/api/payments/source_views/_saferpay_payment.json.jbuilder
 - app/views/spree/checkout/payment/_saferpay_payment.html.erb
 - app/views/spree/six_saferpay_payments/_six_saferpay_payment.html.erb
-- app/views/spree/solidus_six_saferpay/checkout/iframe_breakout_redirect.html.erb
+- app/views/spree/solidus_six_saferpay/checkout/iframe_breakout_redirect.erb
 - bin/console
 - bin/rails
 - bin/rake
@@ -257,7 +257,6 @@ files:
 - lib/solidus_six_saferpay/transaction_gateway.rb
 - lib/solidus_six_saferpay/version.rb
 - solidus_six_saferpay.gemspec
-- spec/controllers/spree/solidus_six_saferpay/checkout_controller_spec.rb
 - spec/controllers/spree/solidus_six_saferpay/payment_page/checkout_controller_spec.rb
 - spec/controllers/spree/solidus_six_saferpay/transaction/checkout_controller_spec.rb
 - spec/dummy/.ruby-version
@@ -325,6 +324,7 @@ files:
 - spec/services/spree/solidus_six_saferpay/assert_payment_page_spec.rb
 - spec/services/spree/solidus_six_saferpay/authorize_payment_spec.rb
 - spec/services/spree/solidus_six_saferpay/authorize_transaction_spec.rb
+- spec/services/spree/solidus_six_saferpay/cancel_authorized_payment_spec.rb
 - spec/services/spree/solidus_six_saferpay/initialize_payment_page_spec.rb
 - spec/services/spree/solidus_six_saferpay/initialize_payment_spec.rb
 - spec/services/spree/solidus_six_saferpay/initialize_transaction_spec.rb
@@ -343,6 +343,10 @@ files:
 - spec/solidus_six_saferpay/transaction_gateway_spec.rb
 - spec/spec_helper.rb
 - spec/support/route_access.rb
+- spec/support/shared_examples/authorize_payment.rb
+- spec/support/shared_examples/checkout_controller.rb
+- spec/support/shared_examples/inquire_payment.rb
+- spec/support/shared_examples/process_authorized_payment.rb
 - spec/support/uses_payment_page_gateway.rb
 - spec/support/uses_transaction_gateway.rb
 homepage: https://github.com/fadendaten/solidus_six_saferpay
@@ -372,7 +376,6 @@ signing_key:
 specification_version: 4
 summary: Saferpay Payment Page and Transaction payment methods for Solidus
 test_files:
-- spec/controllers/spree/solidus_six_saferpay/checkout_controller_spec.rb
 - spec/controllers/spree/solidus_six_saferpay/payment_page/checkout_controller_spec.rb
 - spec/controllers/spree/solidus_six_saferpay/transaction/checkout_controller_spec.rb
 - spec/dummy/.ruby-version
@@ -440,6 +443,7 @@ test_files:
 - spec/services/spree/solidus_six_saferpay/assert_payment_page_spec.rb
 - spec/services/spree/solidus_six_saferpay/authorize_payment_spec.rb
 - spec/services/spree/solidus_six_saferpay/authorize_transaction_spec.rb
+- spec/services/spree/solidus_six_saferpay/cancel_authorized_payment_spec.rb
 - spec/services/spree/solidus_six_saferpay/initialize_payment_page_spec.rb
 - spec/services/spree/solidus_six_saferpay/initialize_payment_spec.rb
 - spec/services/spree/solidus_six_saferpay/initialize_transaction_spec.rb
@@ -458,5 +462,9 @@ test_files:
 - spec/solidus_six_saferpay/transaction_gateway_spec.rb
 - spec/spec_helper.rb
 - spec/support/route_access.rb
+- spec/support/shared_examples/authorize_payment.rb
+- spec/support/shared_examples/checkout_controller.rb
+- spec/support/shared_examples/inquire_payment.rb
+- spec/support/shared_examples/process_authorized_payment.rb
 - spec/support/uses_payment_page_gateway.rb
 - spec/support/uses_transaction_gateway.rb

data/app/services/spree/solidus_six_saferpay/inquire_transaction.rb

@@ -1,7 +0,0 @@
-module Spree
-  module SolidusSixSaferpay
-    class InquireTransactionPayment < InquirePayment
-      include UseTransactionGateway
-    end
-  end
-end

data/spec/controllers/spree/solidus_six_saferpay/checkout_controller_spec.rb

@@ -1,41 +0,0 @@
-require 'rails_helper'
-
-RSpec.describe Spree::SolidusSixSaferpay::CheckoutController, type: :controller do
-  routes { Spree::Core::Engine.routes }
-
-  let(:user) { create(:user) }
-  let(:order) { create(:order) }
-  let(:payment_method) { create(:saferpay_payment_method_transaction) }
-  let(:payment) { create(:six_saferpay_payment) }
-
-  let(:subject) { described_class.new }
-
-  before do
-    allow(controller).to receive_messages try_spree_current_user: user
-    allow(controller).to receive_messages current_order: order
-  end
-
-  describe '#initialize_payment' do
-    it 'is not implemented in this superclass' do
-      expect { subject.send(:initialize_payment, order, payment_method) }.to raise_error(NotImplementedError)
-    end
-  end
-
-  describe '#authorize_payment' do
-    it 'is not implemented in this superclass' do
-      expect { subject.send(:authorize_payment, payment) }.to raise_error(NotImplementedError)
-    end
-  end
-
-  describe '#process_authorization' do
-    it 'is not implemented in this superclass' do
-      expect { subject.send(:process_authorization, payment) }.to raise_error(NotImplementedError)
-    end
-  end
-
-  describe '#inquire_payment' do
-    it 'is not implemented in this superclass' do
-      expect { subject.send(:inquire_payment, payment) }.to raise_error(NotImplementedError)
-    end
-  end
-end