solidus_six_saferpay 0.2.0 → 0.3.0

data/spec/services/spree/solidus_six_saferpay/assert_payment_page_spec.rb

@@ -14,135 +14,9 @@ module Spree
       end
 
       describe '#call' do
-        let(:transaction_status) { "AUTHORIZED" }
-        let(:transaction_id) { "723n4MAjMdhjSAhAKEUdA8jtl9jb" }
-        let(:transaction_date) { "2015-01-30T12:45:22.258+01:00" }
-        let(:amount_value) { "100" }
-        let(:amount_currency) { "USD" }
-        let(:brand_name) { 'PaymentBrand' }
-        let(:display_text) { "xxxx xxxx xxxx 1234" }
-        let(:six_transaction_reference) { "0:0:3:723n4MAjMdhjSAhAKEUdA8jtl9jb" }
-
-        let(:payment_means) do
-          SixSaferpay::ResponsePaymentMeans.new(
-            brand: SixSaferpay::Brand.new(name: brand_name),
-            display_text: display_text
-          )
-        end
-
-        # https://saferpay.github.io/jsonapi/#Payment_v1_PaymentPage_Initialize
-        let(:api_response) do
-          SixSaferpay::SixPaymentPage::AssertResponse.new(
-            response_header: SixSaferpay::ResponseHeader.new(request_id: 'test', spec_version: 'test'),
-            transaction: SixSaferpay::Transaction.new(
-              type: "PAYMENT",
-              status: transaction_status,
-              id: transaction_id,
-              date: transaction_date,
-              amount: SixSaferpay::Amount.new(value: amount_value, currency_code: amount_currency),
-              six_transaction_reference: six_transaction_reference,
-            ),
-            payment_means: payment_means
-          )
-        end
-        
-        let(:gateway_response) do
-          ::SolidusSixSaferpay::GatewayResponse.new(
-            gateway_success,
-            "initialize success: #{gateway_success}",
-            api_response
-          )
-        end
-
-        # stub gateway to return our mock response
-        before do
-          allow(subject).to receive(:gateway).
-            and_return(double('gateway', authorize: gateway_response))
-        end
-
-        context 'when not successful' do
-          let(:gateway_success) { false }
-
-          it 'indicates failure' do
-            subject.call
-
-            expect(subject).not_to be_success
-          end
-
-          it 'does not update the payment attributes' do
-            expect { subject.call }.not_to change { payment.transaction_id }
-            expect { subject.call }.not_to change { payment.transaction_status }
-            expect { subject.call }.not_to change { payment.transaction_date }
-            expect { subject.call }.not_to change { payment.six_transaction_reference }
-            expect { subject.call }.not_to change { payment.display_text }
-            expect { subject.call }.not_to change { payment.response_hash }
-          end
-        end
-
-        context 'when successful' do
-          let(:gateway_success) { true }
-
-          it 'updates the transaction_id' do
-            expect { subject.call }.to change { payment.transaction_id }.from(nil).to(transaction_id)
-          end
-
-          it 'updates the transaction status' do
-            expect { subject.call }.to change { payment.transaction_status }.from(nil).to(transaction_status)
-          end
-
-          it 'updates the transaction date' do
-            expect { subject.call }.to change { payment.transaction_date }.from(nil).to(DateTime.parse(transaction_date))
-          end
-
-          it 'updates the six_transaction_reference' do
-            expect { subject.call }.to change { payment.six_transaction_reference }.from(nil).to(six_transaction_reference)
-          end
-
-          it 'updates the display_text' do
-            expect { subject.call }.to change { payment.display_text }.from(nil).to(display_text)
-          end
-
-          it 'updates the response hash' do
-            expect { subject.call }.to change { payment.response_hash }.from(payment.response_hash).to(api_response.to_h)
-          end
-
-          context 'when the payment was made with a card' do
-            let(:masked_number) { "xxxx xxxx xxxx 5555" }
-            let(:exp_year) { "19" }
-            let(:exp_month) { "5" }
-            let(:payment_means) do
-              SixSaferpay::ResponsePaymentMeans.new(
-                brand: SixSaferpay::Brand.new(name: brand_name),
-                display_text: display_text,
-                card: SixSaferpay::ResponseCard.new(
-                  masked_number: masked_number,
-                  exp_year: exp_year,
-                  exp_month: exp_month
-                )
-              )
-            end
-
-            it 'updates the masked number' do
-              expect { subject.call }.to change { payment.masked_number }.from(nil).to(masked_number)
-            end
-
-            it 'updates the expiry year' do
-              expect { subject.call }.to change { payment.expiration_year }.from(nil).to(exp_year)
-            end
-
-            it 'updates the expiry month' do
-              expect { subject.call }.to change { payment.expiration_month }.from(nil).to(exp_month)
-            end
-          end
-
-          it 'indicates success' do
-            subject.call
-
-            expect(subject).to be_success
-          end
-        end
+        let(:api_response_class) { SixSaferpay::SixPaymentPage::AssertResponse }
+        it_behaves_like "authorize_payment"
       end
-
     end
   end
 end

data/spec/services/spree/solidus_six_saferpay/authorize_transaction_spec.rb

@@ -14,135 +14,11 @@ module Spree
       end
 
       describe '#call' do
-        let(:transaction_status) { "AUTHORIZED" }
-        let(:transaction_id) { "723n4MAjMdhjSAhAKEUdA8jtl9jb" }
-        let(:transaction_date) { "2015-01-30T12:45:22.258+01:00" }
-        let(:amount_value) { "100" }
-        let(:amount_currency) { "USD" }
-        let(:brand_name) { 'PaymentBrand' }
-        let(:display_text) { "xxxx xxxx xxxx 1234" }
-        let(:six_transaction_reference) { "0:0:3:723n4MAjMdhjSAhAKEUdA8jtl9jb" }
-
-        let(:payment_means) do
-          SixSaferpay::ResponsePaymentMeans.new(
-            brand: SixSaferpay::Brand.new(name: brand_name),
-            display_text: display_text
-          )
-        end
-
-        # https://saferpay.github.io/jsonapi/#Payment_v1_PaymentPage_Initialize
-        let(:api_response) do
-          SixSaferpay::SixPaymentPage::AssertResponse.new(
-            response_header: SixSaferpay::ResponseHeader.new(request_id: 'test', spec_version: 'test'),
-            transaction: SixSaferpay::Transaction.new(
-              type: "PAYMENT",
-              status: transaction_status,
-              id: transaction_id,
-              date: transaction_date,
-              amount: SixSaferpay::Amount.new(value: amount_value, currency_code: amount_currency),
-              six_transaction_reference: six_transaction_reference,
-            ),
-            payment_means: payment_means
-          )
-        end
-        
-        let(:gateway_response) do
-          ::SolidusSixSaferpay::GatewayResponse.new(
-            gateway_success,
-            "initialize success: #{gateway_success}",
-            api_response
-          )
-        end
-
-        # stub gateway to return our mock response
-        before do
-          allow(subject).to receive(:gateway).
-            and_return(double('gateway', authorize: gateway_response))
-        end
-
-        context 'when not successful' do
-          let(:gateway_success) { false }
-
-          it 'indicates failure' do
-            subject.call
-
-            expect(subject).not_to be_success
-          end
-
-          it 'does not update the payment attributes' do
-            expect { subject.call }.not_to change { payment.transaction_id }
-            expect { subject.call }.not_to change { payment.transaction_status }
-            expect { subject.call }.not_to change { payment.transaction_date }
-            expect { subject.call }.not_to change { payment.six_transaction_reference }
-            expect { subject.call }.not_to change { payment.display_text }
-            expect { subject.call }.not_to change { payment.response_hash }
-          end
-        end
-
-        context 'when successful' do
-          let(:gateway_success) { true }
-
-          it 'updates the transaction_id' do
-            expect { subject.call }.to change { payment.transaction_id }.from(nil).to(transaction_id)
-          end
-
-          it 'updates the transaction status' do
-            expect { subject.call }.to change { payment.transaction_status }.from(nil).to(transaction_status)
-          end
-
-          it 'updates the transaction date' do
-            expect { subject.call }.to change { payment.transaction_date }.from(nil).to(DateTime.parse(transaction_date))
-          end
-
-          it 'updates the six_transaction_reference' do
-            expect { subject.call }.to change { payment.six_transaction_reference }.from(nil).to(six_transaction_reference)
-          end
-
-          it 'updates the display_text' do
-            expect { subject.call }.to change { payment.display_text }.from(nil).to(display_text)
-          end
-
-          it 'updates the response hash' do
-            expect { subject.call }.to change { payment.response_hash }.from(payment.response_hash).to(api_response.to_h)
-          end
-
-          context 'when the payment was made with a card' do
-            let(:masked_number) { "xxxx xxxx xxxx 5555" }
-            let(:exp_year) { "19" }
-            let(:exp_month) { "5" }
-            let(:payment_means) do
-              SixSaferpay::ResponsePaymentMeans.new(
-                brand: SixSaferpay::Brand.new(name: brand_name),
-                display_text: display_text,
-                card: SixSaferpay::ResponseCard.new(
-                  masked_number: masked_number,
-                  exp_year: exp_year,
-                  exp_month: exp_month
-                )
-              )
-            end
-
-            it 'updates the masked number' do
-              expect { subject.call }.to change { payment.masked_number }.from(nil).to(masked_number)
-            end
-
-            it 'updates the expiry year' do
-              expect { subject.call }.to change { payment.expiration_year }.from(nil).to(exp_year)
-            end
-
-            it 'updates the expiry month' do
-              expect { subject.call }.to change { payment.expiration_month }.from(nil).to(exp_month)
-            end
-          end
-
-          it 'indicates success' do
-            subject.call
-
-            expect(subject).to be_success
-          end
-        end
+        let(:api_response_class) { SixSaferpay::SixTransaction::AuthorizeResponse }
+        it_behaves_like "authorize_payment"
       end
 
+
     end
   end
 end

data/spec/services/spree/solidus_six_saferpay/cancel_authorized_payment_spec.rb

@@ -0,0 +1,58 @@
+require 'rails_helper'
+
+module Spree
+  module SolidusSixSaferpay
+    RSpec.describe CancelAuthorizedPayment do
+
+
+      let(:service) { described_class.new(payment) }
+
+      describe '.call' do
+        let(:payment) { create(:six_saferpay_payment) }
+
+        it 'calls an initialized service with given order and payment method' do
+          expect(described_class).to receive(:new).with(payment).and_return(service)
+          expect(service).to receive(:call)
+
+          described_class.call(payment)
+        end
+      end
+
+      describe '#call' do
+        let(:gateway) { instance_double(::SolidusSixSaferpay::Gateway) }
+
+        before do
+          allow(service).to receive(:gateway).and_return(gateway)
+        end
+
+        context 'when the payment has not been authorized yet' do
+          let(:payment) { create(:six_saferpay_payment) }
+
+          it 'does not cancel the payment' do
+            expect(gateway).not_to receive(:void)
+
+            service.call
+          end
+
+          it 'is treated as an error' do
+            expect(::SolidusSixSaferpay::ErrorHandler).to receive(:handle).with(instance_of(::SolidusSixSaferpay::InvalidSaferpayPayment))
+
+            service.call
+          end
+        end
+
+        context 'when the payment has been authorized already' do
+          let(:payment) { create(:six_saferpay_payment, :authorized) }
+
+          it 'voids the payment' do
+            expect(gateway).to receive(:void).with(payment.transaction_id)
+
+            service.call
+          end
+
+        end
+      end
+
+    end
+  end
+end

data/spec/services/spree/solidus_six_saferpay/initialize_payment_page_spec.rb

@@ -9,7 +9,6 @@ module Spree
 
       subject { described_class.new(order, payment_method) }
 
-
       describe '#gateway' do
         it_behaves_like "it uses the payment page gateway"
       end
@@ -37,7 +36,6 @@ module Spree
           )
         end
 
-        # stub gateway to return our mock response
         before do
           allow(subject).to receive(:gateway).
             and_return(double('gateway', initialize_payment: gateway_response))

data/spec/services/spree/solidus_six_saferpay/initialize_transaction_spec.rb

@@ -39,7 +39,6 @@ module Spree
           )
         end
 
-        # stub gateway to return our mock response
         before do
           allow(subject).to receive(:gateway).
             and_return(double('gateway', initialize_payment: gateway_response))

data/spec/services/spree/solidus_six_saferpay/inquire_payment_page_payment_spec.rb

@@ -5,112 +5,16 @@ module Spree
     RSpec.describe InquirePaymentPagePayment do
 
       let(:payment) { create(:six_saferpay_payment) }
-
       subject { described_class.new(payment) }
 
-
       describe '#gateway' do
         it_behaves_like "it uses the payment page gateway"
       end
 
-
       describe '#call' do
-
-        before do
-          allow(subject).to receive(:gateway).and_return(double('gateway', inquire: gateway_response))
-        end
-        
-        context 'when gateway response is not successful' do
-          let(:gateway_success) { false }
-          let(:error_behaviour) { "ABORT" }
-          let(:error_name) { "VALIDATION_FAILED" }
-          let(:error_message) { "Request validation failed" }
-          let(:api_response) { nil }
-          let(:translated_general_error) { "General Error" }
-          let(:translated_user_message) { "User Message" }
-
-          let(:gateway_response) do
-            ::SolidusSixSaferpay::GatewayResponse.new(
-              gateway_success,
-              "initialize success: #{gateway_success}",
-              api_response,
-              error_name: error_name,
-            )
-          end
-
-          it 'still indicates success' do
-            subject.call
-
-            expect(subject).to be_success
-          end
-
-          it 'adds the error message to the response hash' do
-            expect { subject.call }.to change { payment.response_hash }.from({}).to({error: error_name})
-          end
-
-          it 'sets the user message according to the api error code' do
-            expect(I18n).to receive(:t).with(:general_error, scope: [:solidus_six_saferpay, :errors]).and_return(translated_general_error)
-            expect(I18n).to receive(:t).with(error_name, scope: [:six_saferpay, :error_names]).and_return(translated_user_message)
-            subject.call
-
-            expect(subject.user_message).to eq("#{translated_general_error}: #{translated_user_message}")
-          end
-        end
-
-        context 'when successful' do
-          let(:transaction_status) { "AUTHORIZED" }
-          let(:transaction_id) { "723n4MAjMdhjSAhAKEUdA8jtl9jb" }
-          let(:transaction_date) { "2015-01-30T12:45:22.258+01:00" }
-          let(:amount_value) { "100" }
-          let(:amount_currency) { "USD" }
-          let(:brand_name) { 'PaymentBrand' }
-          let(:display_text) { "xxxx xxxx xxxx 1234" }
-          let(:six_transaction_reference) { "0:0:3:723n4MAjMdhjSAhAKEUdA8jtl9jb" }
-
-          let(:payment_means) do
-            SixSaferpay::ResponsePaymentMeans.new(
-              brand: SixSaferpay::Brand.new(name: brand_name),
-              display_text: display_text
-            )
-          end
-
-          # https://saferpay.github.io/jsonapi/#Payment_v1_PaymentPage_Assert
-          let(:api_response) do
-            SixSaferpay::SixPaymentPage::AssertResponse.new(
-              response_header: SixSaferpay::ResponseHeader.new(request_id: 'test', spec_version: 'test'),
-              transaction: SixSaferpay::Transaction.new(
-                type: "PAYMENT",
-                status: transaction_status,
-                id: transaction_id,
-                date: transaction_date,
-                amount: SixSaferpay::Amount.new(value: amount_value, currency_code: amount_currency),
-                six_transaction_reference: six_transaction_reference,
-              ),
-              payment_means: payment_means
-            )
-          end
-
-          let(:gateway_success) { true }
-          let(:gateway_response) do
-            ::SolidusSixSaferpay::GatewayResponse.new(
-              gateway_success,
-              "initialize success: #{gateway_success}",
-              api_response
-            )
-          end
-
-          it 'updates the response hash' do
-            expect { subject.call }.to change { payment.response_hash }.from(payment.response_hash).to(api_response.to_h)
-          end
-
-          it 'indicates success' do
-            subject.call
-
-            expect(subject).to be_success
-          end
-        end
+        let(:api_response_class) { SixSaferpay::SixPaymentPage::AssertResponse }
+        it_behaves_like "inquire_payment"
       end
-
     end
   end
 end