solidus_core 2.5.2 → 2.6.0.rc1

data/lib/spree/testing_support/factories/order_promotion_factory.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spree/testing_support/factories/order_factory'
 require 'spree/testing_support/factories/promotion_factory'
 

data/lib/spree/testing_support/factories/payment_factory.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spree/testing_support/factories/payment_method_factory'
 require 'spree/testing_support/factories/credit_card_factory'
 require 'spree/testing_support/factories/order_factory'
@@ -8,26 +10,26 @@ FactoryBot.define do
     association(:payment_method, factory: :credit_card_payment_method)
     source { create(:credit_card, user: order.user, address: order.bill_address) }
     order
-    state { 'checkout' }
-    response_code { '12345' }
+    state 'checkout'
+    response_code '12345'
 
     trait :completed do
-      state { 'completed' }
+      state 'completed'
     end
 
     trait :failing do
-      response_code { '00000' }
+      response_code '00000'
       association(:source, :failing, { factory: :credit_card })
     end
 
     factory :payment_with_refund do
       transient do
-        refund_amount { 5 }
+        refund_amount 5
       end
 
       amount { refund_amount }
 
-      state { 'completed' }
+      state 'completed'
 
       refunds { build_list :refund, 1, amount: refund_amount }
     end

data/lib/spree/testing_support/factories/payment_method_factory.rb

@@ -1,30 +1,32 @@
+# frozen_string_literal: true
+
 FactoryBot.define do
   factory :payment_method, aliases: [:credit_card_payment_method], class: 'Spree::PaymentMethod::BogusCreditCard' do
-    name { 'Credit Card' }
-    available_to_admin { true }
-    available_to_users { true }
+    name 'Credit Card'
+    available_to_admin true
+    available_to_users true
   end
 
   factory :check_payment_method, class: 'Spree::PaymentMethod::Check' do
-    name { 'Check' }
-    available_to_admin { true }
-    available_to_users { true }
+    name 'Check'
+    available_to_admin true
+    available_to_users true
   end
 
   # authorize.net was moved to spree_gateway.
   # Leaving this factory in place with bogus in case anyone is using it.
   factory :simple_credit_card_payment_method, class: 'Spree::PaymentMethod::SimpleBogusCreditCard' do
-    name { 'Credit Card' }
-    available_to_admin { true }
-    available_to_users { true }
+    name 'Credit Card'
+    available_to_admin true
+    available_to_users true
   end
 
   factory :store_credit_payment_method, class: 'Spree::PaymentMethod::StoreCredit' do
-    name          { "Store Credit" }
-    description   { "Store Credit" }
-    active        { true }
-    available_to_admin { false }
-    available_to_users { false }
-    auto_capture { true }
+    name          "Store Credit"
+    description   "Store Credit"
+    active        true
+    available_to_admin false
+    available_to_users false
+    auto_capture true
   end
 end

data/lib/spree/testing_support/factories/price_factory.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 require 'spree/testing_support/factories/variant_factory'
 
 FactoryBot.define do
   factory :price, class: 'Spree::Price' do
     variant
-    amount { 19.99 }
-    currency { 'USD' }
+    amount 19.99
+    currency 'USD'
   end
 end

data/lib/spree/testing_support/factories/product_factory.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spree/testing_support/sequences'
 require 'spree/testing_support/factories/shipping_category_factory'
 require 'spree/testing_support/factories/stock_location_factory'
@@ -7,20 +9,20 @@ require 'spree/testing_support/factories/product_option_type_factory'
 FactoryBot.define do
   factory :base_product, class: 'Spree::Product' do
     sequence(:name) { |n| "Product ##{n} - #{Kernel.rand(9999)}" }
-    description { "As seen on TV!" }
-    price { 19.99 }
-    cost_price { 17.00 }
+    description "As seen on TV!"
+    price 19.99
+    cost_price 17.00
     sku { generate(:sku) }
     available_on { 1.year.ago }
-    deleted_at { nil }
+    deleted_at nil
     shipping_category { |r| Spree::ShippingCategory.first || r.association(:shipping_category) }
 
     # ensure stock item will be created for this products master
     before(:create) { create(:stock_location) if Spree::StockLocation.count == 0 }
 
     factory :custom_product do
-      name { 'Custom Product' }
-      price { 17.99 }
+      name 'Custom Product'
+      price 17.99
 
       tax_category { |r| Spree::TaxCategory.first || r.association(:tax_category) }
     end

data/lib/spree/testing_support/factories/product_option_type_factory.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spree/testing_support/factories/product_factory'
 require 'spree/testing_support/factories/option_type_factory'
 

data/lib/spree/testing_support/factories/product_property_factory.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spree/testing_support/factories/product_factory'
 require 'spree/testing_support/factories/property_factory'
 

data/lib/spree/testing_support/factories/promotion_category_factory.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 FactoryBot.define do
   factory :promotion_category, class: 'Spree::PromotionCategory' do
-    name { 'Promotion Category' }
+    name 'Promotion Category'
   end
 end

data/lib/spree/testing_support/factories/promotion_code_factory.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spree/testing_support/sequences'
 require 'spree/testing_support/factories/promotion_factory'
 

data/lib/spree/testing_support/factories/promotion_factory.rb

@@ -1,12 +1,14 @@
+# frozen_string_literal: true
+
 require 'spree/testing_support/factories/promotion_code_factory'
 require 'spree/testing_support/factories/variant_factory'
 
 FactoryBot.define do
   factory :promotion, class: 'Spree::Promotion' do
-    name { 'Promo' }
+    name 'Promo'
 
     transient do
-      code { nil }
+      code nil
     end
     before(:create) do |promotion, evaluator|
       if evaluator.code
@@ -16,7 +18,7 @@ FactoryBot.define do
 
     trait :with_line_item_adjustment do
       transient do
-        adjustment_rate { 10 }
+        adjustment_rate 10
       end
 
       after(:create) do |promotion, evaluator|
@@ -29,7 +31,7 @@ FactoryBot.define do
 
     trait :with_order_adjustment do
       transient do
-        weighted_order_adjustment_amount { 10 }
+        weighted_order_adjustment_amount 10
       end
 
       after(:create) do |promotion, evaluator|
@@ -44,7 +46,7 @@ FactoryBot.define do
 
     trait :with_item_total_rule do
       transient do
-        item_total_threshold_amount { 10 }
+        item_total_threshold_amount 10
       end
 
       after(:create) do |promotion, evaluator|

data/lib/spree/testing_support/factories/property_factory.rb

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 FactoryBot.define do
   factory :property, class: 'Spree::Property' do
-    name { 'baseball_cap_color' }
-    presentation { 'cap color' }
+    name 'baseball_cap_color'
+    presentation 'cap color'
   end
 end

data/lib/spree/testing_support/factories/refund_factory.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spree/testing_support/factories/payment_factory'
 require 'spree/testing_support/factories/refund_reason_factory'
 
@@ -6,10 +8,10 @@ FactoryBot.define do
 
   factory :refund, class: 'Spree::Refund' do
     transient do
-      payment_amount { 100 }
+      payment_amount 100
     end
 
-    amount { 100.00 }
+    amount 100.00
     transaction_id { generate(:refund_transaction_id) }
     payment do
       association(:payment, state: 'completed', amount: payment_amount)

data/lib/spree/testing_support/factories/refund_reason_factory.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 FactoryBot.define do
   factory :refund_reason, class: 'Spree::RefundReason' do
     sequence(:name) { |n| "Refund for return ##{n}" }

data/lib/spree/testing_support/factories/reimbursement_factory.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 require 'spree/testing_support/factories/customer_return_factory'
 
 FactoryBot.define do
   factory :reimbursement, class: 'Spree::Reimbursement' do
     transient do
-      return_items_count { 1 }
+      return_items_count 1
     end
 
     customer_return { create(:customer_return_with_accepted_items, line_items_count: return_items_count) }

data/lib/spree/testing_support/factories/reimbursement_type_factory.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 FactoryBot.define do
   factory :reimbursement_type, class: 'Spree::ReimbursementType' do
     sequence(:name) { |n| "Reimbursement Type #{n}" }
-    active { true }
-    mutable { true }
+    active true
+    mutable true
   end
 end

data/lib/spree/testing_support/factories/return_authorization_factory.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spree/testing_support/factories/order_factory'
 require 'spree/testing_support/factories/stock_location_factory'
 require 'spree/testing_support/factories/return_reason_factory'
@@ -7,7 +9,7 @@ FactoryBot.define do
     association(:order, factory: :shipped_order)
     association(:stock_location, factory: :stock_location)
     association(:reason, factory: :return_reason)
-    memo { 'Items were broken' }
+    memo 'Items were broken'
   end
 
   factory :new_return_authorization, class: 'Spree::ReturnAuthorization' do

data/lib/spree/testing_support/factories/return_item_factory.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spree/testing_support/factories/inventory_unit_factory'
 require 'spree/testing_support/factories/return_reason_factory'
 require 'spree/testing_support/factories/return_authorization_factory'

data/lib/spree/testing_support/factories/return_reason_factory.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 FactoryBot.define do
   factory :return_reason, class: 'Spree::ReturnReason' do
     sequence(:name) { |n| "Defect ##{n}" }

data/lib/spree/testing_support/factories/role_factory.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 FactoryBot.define do
   factory :role, class: 'Spree::Role' do
     sequence(:name) { |n| "Role ##{n}" }
 
     factory :admin_role do
-      name { 'admin' }
+      name 'admin'
     end
   end
 end

data/lib/spree/testing_support/factories/shipment_factory.rb

@@ -1,17 +1,19 @@
+# frozen_string_literal: true
+
 require 'spree/testing_support/factories/order_factory'
 require 'spree/testing_support/factories/stock_location_factory'
 require 'spree/testing_support/factories/shipping_method_factory'
 
 FactoryBot.define do
   factory :shipment, class: 'Spree::Shipment' do
-    tracking { 'U10000' }
-    cost { 100.00 }
-    state { 'pending' }
+    tracking 'U10000'
+    cost 100.00
+    state 'pending'
     order
     stock_location
 
     transient do
-      shipping_method { nil }
+      shipping_method nil
     end
 
     after(:create) do |shipment, evaluator|

data/lib/spree/testing_support/factories/shipping_category_factory.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 FactoryBot.define do
   factory :shipping_category, class: 'Spree::ShippingCategory' do
     sequence(:name) { |n| "ShippingCategory ##{n}" }

data/lib/spree/testing_support/factories/shipping_method_factory.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spree/testing_support/factories/calculator_factory'
 require 'spree/testing_support/factories/shipping_category_factory'
 require 'spree/testing_support/factories/zone_factory'
@@ -14,15 +16,15 @@ FactoryBot.define do
       [Spree::Zone.find_by(name: 'GlobalZone') || FactoryBot.create(:global_zone)]
     end
 
-    name { 'UPS Ground' }
-    code { 'UPS_GROUND' }
-    carrier { 'UPS' }
-    service_level { '1DAYGROUND' }
+    name 'UPS Ground'
+    code 'UPS_GROUND'
+    carrier 'UPS'
+    service_level '1DAYGROUND'
 
     calculator { |s| s.association(:shipping_calculator, strategy: :build, preferred_amount: s.cost, preferred_currency: s.currency) }
 
     transient do
-      cost { 10.0 }
+      cost 10.0
       currency { Spree::Config[:currency] }
     end
 
@@ -33,7 +35,7 @@ FactoryBot.define do
     end
 
     factory :free_shipping_method, class: 'Spree::ShippingMethod' do
-      cost { nil }
+      cost nil
       association(:calculator, factory: :shipping_no_amount_calculator, strategy: :build)
     end
   end

data/lib/spree/testing_support/factories/shipping_rate_factory.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spree/testing_support/factories/shipping_method_factory'
 require 'spree/testing_support/factories/shipment_factory'
 

data/lib/spree/testing_support/factories/state_factory.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 require 'spree/testing_support/factories/country_factory'
 
 FactoryBot.define do
   factory :state, class: 'Spree::State' do
     transient do
-      country_iso { 'US' }
-      state_code { 'AL' }
+      country_iso 'US'
+      state_code 'AL'
 
       carmen_subregion do
         carmen_country = Carmen::Country.coded(country.iso)

data/lib/spree/testing_support/factories/stock_item_factory.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 require 'spree/testing_support/factories/stock_location_factory'
 require 'spree/testing_support/factories/variant_factory'
 
 FactoryBot.define do
   factory :stock_item, class: 'Spree::StockItem' do
-    backorderable { true }
+    backorderable true
     association :stock_location, factory: :stock_location_without_variant_propagation
     variant
 

data/lib/spree/testing_support/factories/stock_location_factory.rb

@@ -1,16 +1,18 @@
+# frozen_string_literal: true
+
 require 'spree/testing_support/factories/country_factory'
 require 'spree/testing_support/factories/state_factory'
 require 'spree/testing_support/factories/product_factory'
 
 FactoryBot.define do
   factory :stock_location, class: 'Spree::StockLocation' do
-    name { 'NY Warehouse' }
-    address1 { '1600 Pennsylvania Ave NW' }
-    city { 'Washington' }
-    zipcode { '20500' }
-    phone { '(202) 456-1111' }
-    active { true }
-    backorderable_default { true }
+    name 'NY Warehouse'
+    address1 '1600 Pennsylvania Ave NW'
+    city 'Washington'
+    zipcode '20500'
+    phone '(202) 456-1111'
+    active true
+    backorderable_default true
 
     country  { |stock_location| Spree::Country.first || stock_location.association(:country) }
     state do |stock_location|
@@ -21,7 +23,7 @@ FactoryBot.define do
     end
 
     factory :stock_location_without_variant_propagation do
-      propagate_all_variants { false }
+      propagate_all_variants false
     end
 
     factory :stock_location_with_items do