solidus_core 2.5.2 → 2.6.0.rc1

data/lib/spree/permission_sets/configuration_display.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Spree
   module PermissionSets
     class ConfigurationDisplay < PermissionSets::Base

data/lib/spree/permission_sets/configuration_management.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Spree
   module PermissionSets
     class ConfigurationManagement < PermissionSets::Base

data/lib/spree/permission_sets/dashboard_display.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Spree
   module PermissionSets
     class DashboardDisplay < PermissionSets::Base

data/lib/spree/permission_sets/default_customer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Spree
   module PermissionSets
     class DefaultCustomer < PermissionSets::Base

data/lib/spree/permission_sets/order_display.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Spree
   module PermissionSets
     class OrderDisplay < PermissionSets::Base

data/lib/spree/permission_sets/order_management.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Spree
   module PermissionSets
     class OrderManagement < PermissionSets::Base

data/lib/spree/permission_sets/product_display.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Spree
   module PermissionSets
     class ProductDisplay < PermissionSets::Base

data/lib/spree/permission_sets/product_management.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Spree
   module PermissionSets
     class ProductManagement < PermissionSets::Base

data/lib/spree/permission_sets/promotion_display.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Spree
   module PermissionSets
     class PromotionDisplay < PermissionSets::Base

data/lib/spree/permission_sets/promotion_management.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Spree
   module PermissionSets
     class PromotionManagement < PermissionSets::Base

data/lib/spree/permission_sets/report_display.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Spree
   module PermissionSets
     class ReportDisplay < PermissionSets::Base

data/lib/spree/permission_sets/restricted_stock_display.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Spree
   module PermissionSets
     class RestrictedStockDisplay < PermissionSets::Base

data/lib/spree/permission_sets/restricted_stock_management.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Spree
   module PermissionSets
     class RestrictedStockManagement < PermissionSets::Base

data/lib/spree/permission_sets/stock_display.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Spree
   module PermissionSets
     class StockDisplay < PermissionSets::Base

data/lib/spree/permission_sets/stock_management.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Spree
   module PermissionSets
     class StockManagement < PermissionSets::Base

data/lib/spree/permission_sets/super_user.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Spree
   module PermissionSets
     class SuperUser < PermissionSets::Base

data/lib/spree/permission_sets/user_display.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Spree
   module PermissionSets
     class UserDisplay < PermissionSets::Base

data/lib/spree/permission_sets/user_management.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Spree
   module PermissionSets
     class UserManagement < PermissionSets::Base

data/lib/spree/permitted_attributes.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Spree
   # Spree::PermittedAttributes contains the attributes permitted through strong
   # params in various controllers in the frontend. Extensions and stores that

data/lib/spree/preferences/configuration.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spree/preferences/preferable'
 
 module Spree::Preferences

data/lib/spree/preferences/preferable.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spree/preferences/preferable_class_methods'
 require 'active_support/concern'
 require 'active_support/core_ext/hash/keys'

data/lib/spree/preferences/preferable_class_methods.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Spree::Preferences
   module PreferableClassMethods
     DEFAULT_ADMIN_FORM_PREFERENCE_TYPES = %i(

data/lib/spree/preferences/scoped_store.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Spree::Preferences
   class ScopedStore
     def initialize(prefix, suffix = nil)

data/lib/spree/preferences/static_model_preferences.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Spree
   module Preferences
     class StaticModelPreferences

data/lib/spree/preferences/statically_configurable.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Spree
   module Preferences
     module StaticallyConfigurable

data/lib/spree/preferences/store.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Use singleton class Spree::Preferences::Store.instance to access
 #
 

data/lib/spree/promo/environment.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Spree
   module Promo
     class Environment

data/lib/spree/testing_support/ability_helpers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.shared_examples_for 'access granted' do
   it 'should allow read' do
     expect(ability).to be_able_to(:read, resource, token) if token

data/lib/spree/testing_support/authorization_helpers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cancan'
 
 module Spree

data/lib/spree/testing_support/bar_ability.rb

@@ -1,4 +1,9 @@
+# frozen_string_literal: true
+
+Spree::Deprecation.warn "BarAbility is deprecated. Use stub_authorization! instead"
+
 # Fake ability for testing administration
+# @private
 class BarAbility
   include CanCan::Ability
 

data/lib/spree/testing_support/caching.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Spree
   module TestingSupport
     module Caching
@@ -5,18 +7,7 @@ module Spree
         @cache_write_events
       end
 
-      def assert_written_to_cache(key)
-        unless @cache_write_events.detect { |event| event[:key].starts_with?(key) }
-          fail %{Expected to find #{key} in the cache, but didn't.
-
-  Cache writes:
-  #{@cache_write_events.join("\n")}
-          }
-        end
-      end
-
       def clear_cache_events
-        @cache_read_events = []
         @cache_write_events = []
       end
     end
@@ -29,11 +20,6 @@ RSpec.configure do |config|
   config.before(:each, caching: true) do
     ActionController::Base.perform_caching = true
 
-    ActiveSupport::Notifications.subscribe("read_fragment.action_controller") do |_event, _start_time, _finish_time, _, details|
-      @cache_read_events ||= []
-      @cache_read_events << details
-    end
-
     ActiveSupport::Notifications.subscribe("write_fragment.action_controller") do |_event, _start_time, _finish_time, _, details|
       @cache_write_events ||= []
       @cache_write_events << details

data/lib/spree/testing_support/capybara_ext.rb

@@ -1,122 +1,125 @@
-module CapybaraExt
-  def page!
-  end
-
-  def click_icon(type)
-    find(".fa-#{type}").click
-  end
-
-  def eventually_fill_in(field, options = {})
-    expect(page).to have_css('#' + field)
-    fill_in field, options
-  end
-
-  def within_row(num, &block)
-    within("table.index tbody tr:nth-of-type(#{num})", &block)
-  end
-
-  def column_text(num)
-    find("td:nth-of-type(#{num})").text
-  end
-
-  def fill_in_quantity(table_column, selector, quantity)
-    Spree::Deprecation.warn <<-WARN.strip_heredoc
-      fill_in_quantity is deprecated. Instead use:
-        within(#{table_column.inspect}) do
-          fill_in #{selector.inspect}, with: #{quantity.inspect}
+# frozen_string_literal: true
+
+module Spree
+  module TestingSupport
+    module CapybaraExt
+      def click_icon(type)
+        find(".fa-#{type}").click
+      end
+
+      def eventually_fill_in(field, options = {})
+        expect(page).to have_css('#' + field)
+        fill_in field, options
+      end
+
+      def within_row(num, &block)
+        within("table.index tbody tr:nth-of-type(#{num})", &block)
+      end
+
+      def column_text(num)
+        find("td:nth-of-type(#{num})").text
+      end
+
+      def fill_in_quantity(table_column, selector, quantity)
+        Spree::Deprecation.warn <<-WARN.strip_heredoc
+          fill_in_quantity is deprecated. Instead use:
+            within(#{table_column.inspect}) do
+              fill_in #{selector.inspect}, with: #{quantity.inspect}
+            end
+        WARN
+        within(table_column) do
+          fill_in selector, with: quantity
         end
-    WARN
-    within(table_column) do
-      fill_in selector, with: quantity
-    end
-  end
-
-  def select2_search(value, options)
-    options = {
-      search: value, # by default search for the value
-      select: true
-    }.merge(options)
-    label = find_label_by_text(options[:from])
-    within label.first(:xpath, ".//..") do
-      options[:from] = "##{find('.select2-container')['id']}"
-    end
-    select2_search_without_selection(options[:search], from: options[:from])
-    select_select2_result(value) if options[:select]
-  end
-
-  def select2_search_without_selection(value, options)
-    find("#{options[:from]}:not(.select2-container-disabled):not(.select2-offscreen)").click
-
-    within_entire_page do
-      find("input.select2-input.select2-focused").set(value)
-    end
-  end
+      end
+
+      def select2_search(value, options)
+        options = {
+          search: value, # by default search for the value
+          select: true
+        }.merge(options)
+        label = find_label_by_text(options[:from])
+        within label.first(:xpath, ".//..") do
+          options[:from] = "##{find('.select2-container')['id']}"
+        end
+        select2_search_without_selection(options[:search], from: options[:from])
+        select_select2_result(value) if options[:select]
+      end
 
-  def targetted_select2_search(value, options)
-    select2_search_without_selection(value, from: options[:from])
-    select_select2_result(value)
-  end
+      def select2_search_without_selection(value, options)
+        find("#{options[:from]}:not(.select2-container-disabled):not(.select2-offscreen)").click
 
-  # Executes the given block within the context of the entire capybara
-  # document. Can be used to 'escape' from within the context of another within
-  # block.
-  def within_entire_page(&block)
-    within(:xpath, '//body', &block)
-  end
+        within_entire_page do
+          find("input.select2-input.select2-focused").set(value)
+        end
+      end
 
-  def select2(value, options)
-    label = find_label_by_text(options[:from])
+      def targetted_select2_search(value, options)
+        select2_search_without_selection(value, from: options[:from])
+        select_select2_result(value)
+      end
 
-    within label.first(:xpath, ".//..") do
-      options[:from] = "##{find('.select2-container')['id']}"
-    end
-    targetted_select2(value, options)
-  end
+      # Executes the given block within the context of the entire capybara
+      # document. Can be used to 'escape' from within the context of another within
+      # block.
+      def within_entire_page(&block)
+        within(:xpath, '//body', &block)
+      end
 
-  def select2_no_label(value, options = {})
-    raise "Must pass a hash containing 'from'" if !options.is_a?(Hash) || !options.key?(:from)
+      def select2(value, options)
+        label = find_label_by_text(options[:from])
 
-    placeholder = options[:from]
+        within label.first(:xpath, ".//..") do
+          options[:from] = "##{find('.select2-container')['id']}"
+        end
+        targetted_select2(value, options)
+      end
 
-    click_link placeholder
+      def select2_no_label(value, options = {})
+        raise "Must pass a hash containing 'from'" if !options.is_a?(Hash) || !options.key?(:from)
 
-    select_select2_result(value)
-  end
+        placeholder = options[:from]
 
-  def targetted_select2(value, options)
-    # find select2 element and click it
-    find(options[:from]).find('a').click
-    select_select2_result(value)
-  end
+        click_link placeholder
 
-  def select_select2_result(value)
-    # results are in a div appended to the end of the document
-    within_entire_page do
-      page.find("div.select2-result-label", text: /#{Regexp.escape(value)}/i, match: :prefer_exact).click
-    end
-  end
+        select_select2_result(value)
+      end
 
-  def find_label_by_text(text)
-    # This used to find the label by it's text using an xpath query, so we use
-    # a case insensitive search to avoid breakage with existing usage.
-    # We need to select labels which are not .select2-offscreen, as select2
-    # makes a duplicate label with the same text, and we want to be sure to
-    # find the original.
-    find('label:not(.select2-offscreen)', text: /#{Regexp.escape(text)}/i, match: :one)
-  end
+      def targetted_select2(value, options)
+        # find select2 element and click it
+        find(options[:from]).find('a').click
+        select_select2_result(value)
+      end
 
-  def wait_for_ajax
-    Spree::Deprecation.warn <<-WARN.squish, caller
-      wait_for_ajax has been deprecated.
-      Please refer to the capybara documentation on how to properly wait for asyncronous behavior:
-      https://github.com/teamcapybara/capybara#asynchronous-javascript-ajax-and-friends
-    WARN
-
-    counter = 0
-    while page.evaluate_script("typeof($) === 'undefined' || $.active > 0")
-      counter += 1
-      sleep(0.1)
-      raise "AJAX request took longer than 5 seconds." if counter >= 50
+      def select_select2_result(value)
+        # results are in a div appended to the end of the document
+        within_entire_page do
+          page.find("div.select2-result-label", text: /#{Regexp.escape(value)}/i, match: :prefer_exact).click
+        end
+      end
+
+      def find_label_by_text(text)
+        # This used to find the label by it's text using an xpath query, so we use
+        # a case insensitive search to avoid breakage with existing usage.
+        # We need to select labels which are not .select2-offscreen, as select2
+        # makes a duplicate label with the same text, and we want to be sure to
+        # find the original.
+        find('label:not(.select2-offscreen)', text: /#{Regexp.escape(text)}/i, match: :one)
+      end
+
+      def wait_for_ajax
+        Spree::Deprecation.warn <<-WARN.squish, caller
+          wait_for_ajax has been deprecated.
+          Please refer to the capybara documentation on how to properly wait for asyncronous behavior:
+          https://github.com/teamcapybara/capybara#asynchronous-javascript-ajax-and-friends
+        WARN
+
+        counter = 0
+        while page.evaluate_script("typeof($) === 'undefined' || $.active > 0")
+          counter += 1
+          sleep(0.1)
+          raise "AJAX request took longer than 5 seconds." if counter >= 50
+        end
+      end
     end
   end
 end
@@ -126,7 +129,7 @@ RSpec::Matchers.define :have_meta do |name, expected|
     has_css?("meta[name='#{name}'][content='#{expected}']", visible: false)
   end
 
-  failure_message do |actual|
+  failure_message do
     actual = first("meta[name='#{name}']")
     if actual
       "expected that meta #{name} would have content='#{expected}' but was '#{actual[:content]}'"
@@ -136,6 +139,9 @@ RSpec::Matchers.define :have_meta do |name, expected|
   end
 end
 
+# @private
+CapybaraExt = ActiveSupport::Deprecation::DeprecatedConstantProxy.new('CapybaraExt', 'Spree::TestingSupport::CapybaraExt')
+
 RSpec.configure do |c|
-  c.include CapybaraExt
+  c.include Spree::TestingSupport::CapybaraExt
 end