solidus_core 2.10.5 → 2.11.0

data/spec/models/spree/address_spec.rb

@@ -1,399 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe Spree::Address, type: :model do
-  subject { Spree::Address }
-
-  context "aliased attributes" do
-    let(:address) { Spree::Address.new firstname: 'Ryan', lastname: 'Bigg' }
-
-    it " first_name" do
-      expect(address.first_name).to eq("Ryan")
-    end
-
-    it "last_name" do
-      expect(address.last_name).to eq("Bigg")
-    end
-  end
-
-  context "validation" do
-    let(:country) { create :country, states_required: true }
-    let(:state) { Spree::State.new name: 'maryland', abbr: 'md', country: country }
-    let(:address) { build(:address, country: country) }
-
-    before do
-      allow(country.states).to receive_messages with_name_or_abbr: [state]
-    end
-
-    context 'address does not require state' do
-      before do
-        stub_spree_preferences(address_requires_state: false)
-      end
-
-      it "address_requires_state preference is false" do
-        address.state = nil
-        address.state_name = nil
-        expect(address).to be_valid
-      end
-    end
-
-    context 'address requires state' do
-      before do
-        stub_spree_preferences(address_requires_state: true)
-      end
-
-      it "state_name is not nil and country does not have any states" do
-        address.state = nil
-        address.state_name = 'alabama'
-        expect(address).to be_valid
-      end
-
-      it "errors when state_name is nil" do
-        address.state_name = nil
-        address.state = nil
-        expect(address).not_to be_valid
-      end
-
-      it "full state name is in state_name and country does contain that state" do
-        address.state_name = 'alabama'
-        # called by state_validate to set up state_id.
-        # Perhaps this should be a before_validation instead?
-        expect(address).to be_valid
-        expect(address.state).not_to be_nil
-        expect(address.state_name).to be_nil
-      end
-
-      it "state abbr is in state_name and country does contain that state" do
-        address.state_name = state.abbr
-        expect(address).to be_valid
-        expect(address.state_id).not_to be_nil
-        expect(address.state_name).to be_nil
-      end
-
-      context 'when the country does not match the state' do
-        context 'when the country requires states' do
-          it 'is invalid' do
-            address.state = state
-            address.country = Spree::Country.new(states_required: true)
-            address.valid?
-            expect(address.errors["state"]).to eq(['is invalid', 'does not match the country'])
-          end
-        end
-
-        context 'when the country does not require states' do
-          it 'is invalid' do
-            address.state = state
-            address.country = Spree::Country.new(states_required: false)
-            address.valid?
-            expect(address.errors["state"]).to eq(['does not match the country'])
-          end
-        end
-      end
-
-      it "both state and state_name are entered but country does not contain the state" do
-        address.state = state
-        address.state_name = 'maryland'
-        address.country = create :country, states_required: true
-        expect(address).to be_valid
-        expect(address.state_id).to be_nil
-      end
-
-      it "both state and state_name are entered and country does contain the state" do
-        address.state = state
-        address.state_name = 'maryland'
-        expect(address).to be_valid
-        expect(address.state_name).to be_nil
-      end
-    end
-
-    it "requires phone" do
-      address.phone = ""
-      address.valid?
-      expect(address.errors["phone"]).to eq(["can't be blank"])
-    end
-
-    it "requires zipcode" do
-      address.zipcode = ""
-      address.valid?
-      expect(address.errors['zipcode']).to include("can't be blank")
-    end
-
-    context "phone not required" do
-      before { allow(address).to receive_messages require_phone?: false }
-
-      it "shows no errors when phone is blank" do
-        address.phone = ""
-        address.valid?
-        expect(address.errors[:phone].size).to eq 0
-      end
-    end
-
-    context "zipcode not required" do
-      before { allow(address).to receive_messages require_zipcode?: false }
-
-      it "shows no errors when zipcode is blank" do
-        address.zipcode = ""
-        address.valid?
-        expect(address.errors[:zipcode]).to be_blank
-      end
-    end
-  end
-
-  context ".build_default" do
-    context "no user given" do
-      let!(:default_country) { create(:country) }
-
-      context 'has a default country' do
-        before do
-          stub_spree_preferences(default_country_iso: default_country.iso)
-        end
-
-        it "sets up a new record with Spree::Config[:default_country_iso]" do
-          expect(Spree::Address.build_default.country).to eq default_country
-        end
-
-        it 'accepts other attributes' do
-          address = Spree::Address.build_default(first_name: 'Ryan')
-
-          expect(address.country).to eq default_country
-          expect(address.first_name).to eq 'Ryan'
-        end
-
-        it 'accepts a block' do
-          address = Spree::Address.build_default do |record|
-            record.first_name = 'Ryan'
-          end
-
-          expect(address.country).to eq default_country
-          expect(address.first_name).to eq 'Ryan'
-        end
-
-        it 'can override the country' do
-          another_country = build :country
-          address = Spree::Address.build_default(country: another_country)
-
-          expect(address.country).to eq another_country
-        end
-      end
-
-      # Regression test for https://github.com/spree/spree/issues/1142
-      it "raises ActiveRecord::RecordNotFound if :default_country_iso is set to an invalid value" do
-        stub_spree_preferences(default_country_iso: "00")
-        expect {
-          Spree::Address.build_default.country
-        }.to raise_error(ActiveRecord::RecordNotFound)
-      end
-    end
-  end
-
-  context '.factory' do
-    context 'with attributes that use setters defined in Address' do
-      let(:address_attributes) { attributes_for(:address, country_id: nil, country_iso: country.iso) }
-      let(:country) { create(:country, iso: 'ZW') }
-
-      it 'uses the setters' do
-        expect(subject.factory(address_attributes).country_id).to eq(country.id)
-      end
-    end
-  end
-
-  context ".immutable_merge" do
-    RSpec::Matchers.define :be_address_equivalent_attributes do |expected|
-      fields_of_interest = [:firstname, :lastname, :company, :address1, :address2, :city, :zipcode, :phone, :alternative_phone]
-      match do |actual|
-        expected_attrs = expected.symbolize_keys.slice(*fields_of_interest)
-        actual_attrs = actual.symbolize_keys.slice(*fields_of_interest)
-        expected_attrs == actual_attrs
-      end
-    end
-
-    let(:new_address_attributes) { attributes_for(:address) }
-    subject { Spree::Address.immutable_merge(existing_address, new_address_attributes) }
-
-    context "no existing address supplied" do
-      let(:existing_address) { nil }
-
-      context 'and there is not a matching address in the database' do
-        it "returns new Address matching attributes given" do
-          expect(subject.attributes).to be_address_equivalent_attributes(new_address_attributes)
-        end
-      end
-
-      context 'and there is a matching address in the database' do
-        let(:new_address_attributes) { Spree::Address.value_attributes(matching_address.attributes) }
-        let!(:matching_address) { create(:address, firstname: 'Jordan') }
-
-        it "returns the matching address" do
-          expect(subject.attributes).to be_address_equivalent_attributes(new_address_attributes)
-          expect(subject.id).to eq(matching_address.id)
-        end
-      end
-    end
-
-    context "with existing address" do
-      let(:existing_address) { create(:address) }
-
-      it "returns a new Address of merged data" do
-        merged_attributes = subject.attributes.merge(new_address_attributes.symbolize_keys)
-        expect(subject.attributes).to be_address_equivalent_attributes merged_attributes
-        expect(subject.id).not_to eq existing_address.id
-      end
-
-      context "and no changes to attributes" do
-        let(:new_address_attributes) { existing_address.attributes }
-
-        it "returns existing address" do
-          expect(subject).to eq existing_address
-          expect(subject.id).to eq existing_address.id
-        end
-      end
-
-      context 'and changed address matches an existing address' do
-        let(:new_address_attributes) { Spree::Address.value_attributes(matching_address.attributes) }
-        let!(:matching_address) { create(:address, firstname: 'Jordan') }
-
-        it 'returns the matching address' do
-          expect(subject.attributes).to be_address_equivalent_attributes(new_address_attributes)
-          expect(subject.id).to eq(matching_address.id)
-        end
-      end
-    end
-  end
-
-  describe '.value_attributes' do
-    subject do
-      Spree::Address.value_attributes(base_attributes, merge_attributes)
-    end
-
-    context 'with symbols and strings' do
-      let(:base_attributes) { { 'address1' => '1234 way', 'address2' => 'apt 2' } }
-      let(:merge_attributes) { { address1: '5678 way' } }
-
-      it 'stringifies and merges the keys' do
-        expect(subject).to eq('address1' => '5678 way', 'address2' => 'apt 2')
-      end
-    end
-
-    context 'with database-only attributes' do
-      let(:base_attributes) do
-        {
-          'id' => 1,
-          'created_at' => Time.current,
-          'updated_at' => Time.current,
-          'address1' => '1234 way'
-        }
-      end
-      let(:merge_attributes) do
-        {
-          'updated_at' => Time.current,
-          'address2' => 'apt 2'
-        }
-      end
-
-      it 'removes the database-only addresses' do
-        expect(subject).to eq('address1' => '1234 way', 'address2' => 'apt 2')
-      end
-    end
-
-    context 'with aliased attributes' do
-      let(:base_attributes) { { 'first_name' => 'Jordan' } }
-      let(:merge_attributes) { { 'last_name' => 'Brough' } }
-
-      it 'renames them to the normalized value' do
-        expect(subject).to eq('firstname' => 'Jordan', 'lastname' => 'Brough')
-      end
-
-      it 'does not modify the original hashes' do
-        subject
-        expect(base_attributes).to eq('first_name' => 'Jordan')
-        expect(merge_attributes).to eq('last_name' => 'Brough')
-      end
-    end
-  end
-
-  describe '.taxation_attributes' do
-    context 'both taxation and non-taxation attributes are present ' do
-      let(:address) { Spree::Address.new firstname: 'Michael', lastname: 'Jackson', state_id: 1, country_id: 2, zipcode: '12345' }
-
-      it 'removes the non-taxation attributes' do
-        expect(address.taxation_attributes).not_to eq('firstname' => 'Michael', 'lastname' => 'Jackson')
-      end
-
-      it 'returns only the taxation attributes' do
-        expect(address.taxation_attributes).to eq('state_id' => 1, 'country_id' => 2, 'zipcode' => '12345')
-      end
-    end
-
-    context 'taxation attributes are blank' do
-      let(:address) { Spree::Address.new firstname: 'Michael', lastname: 'Jackson' }
-
-      it 'returns a subset of the attributes with the correct keys and nil values' do
-        expect(address.taxation_attributes).to eq('state_id' => nil, 'country_id' => nil, 'zipcode' => nil)
-      end
-    end
-  end
-
-  context '#country_iso=' do
-    let(:address) { build(:address, country_id: nil) }
-    let(:country) { create(:country, iso: 'ZW') }
-
-    it 'sets the country to the country with the matching iso code' do
-      address.country_iso = country.iso
-      expect(address.country_id).to eq(country.id)
-    end
-
-    it 'raises an exception if the iso is not found' do
-      expect {
-        address.country_iso = "NOCOUNTRY"
-      }.to raise_error(::ActiveRecord::RecordNotFound, "Couldn't find Spree::Country")
-    end
-  end
-
-  context '#full_name' do
-    context 'both first and last names are present' do
-      let(:address) { Spree::Address.new firstname: 'Michael', lastname: 'Jackson' }
-      specify { expect(address.full_name).to eq('Michael Jackson') }
-    end
-
-    context 'first name is blank' do
-      let(:address) { Spree::Address.new firstname: nil, lastname: 'Jackson' }
-      specify { expect(address.full_name).to eq('Jackson') }
-    end
-
-    context 'last name is blank' do
-      let(:address) { Spree::Address.new firstname: 'Michael', lastname: nil }
-      specify { expect(address.full_name).to eq('Michael') }
-    end
-
-    context 'both first and last names are blank' do
-      let(:address) { Spree::Address.new firstname: nil, lastname: nil }
-      specify { expect(address.full_name).to eq('') }
-    end
-  end
-
-  context '#state_text' do
-    context 'state is blank' do
-      let(:address) { Spree::Address.new state: nil, state_name: 'virginia' }
-      specify { expect(address.state_text).to eq('virginia') }
-    end
-
-    context 'both name and abbr is present' do
-      let(:state) { Spree::State.new name: 'virginia', abbr: 'va' }
-      let(:address) { Spree::Address.new state: state }
-      specify { expect(address.state_text).to eq('va') }
-    end
-
-    context 'only name is present' do
-      let(:state) { Spree::State.new name: 'virginia', abbr: nil }
-      let(:address) { Spree::Address.new state: state }
-      specify { expect(address.state_text).to eq('virginia') }
-    end
-  end
-
-  context '#requires_phone' do
-    subject { described_class.new }
-
-    it { is_expected.to be_require_phone }
-  end
-end

data/spec/models/spree/adjustment_reason_spec.rb

@@ -1,11 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe Spree::AdjustmentReason do
-  describe 'creation' do
-    it 'is successful' do
-      create(:adjustment_reason)
-    end
-  end
-end

data/spec/models/spree/adjustment_spec.rb

@@ -1,339 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe Spree::Adjustment, type: :model do
-  let!(:store) { create :store }
-  let(:order) { Spree::Order.new }
-  let(:line_item) { create :line_item, order: order }
-
-  let(:adjustment) { Spree::Adjustment.create!(label: 'Adjustment', adjustable: order, order: order, amount: 5) }
-
-  context '#save' do
-    let(:adjustment) { Spree::Adjustment.create(label: "Adjustment", amount: 5, order: order, adjustable: line_item) }
-
-    it 'touches the adjustable' do
-      line_item.update_columns(updated_at: 1.day.ago)
-      expect { adjustment.save! }.to change { line_item.updated_at }
-    end
-  end
-
-  describe 'non_tax scope' do
-    subject do
-      Spree::Adjustment.non_tax.to_a
-    end
-
-    let!(:tax_adjustment) do
-      create(:adjustment, adjustable: order, order: order, source: create(:tax_rate))
-    end
-
-    let!(:non_tax_adjustment_with_source) do
-      create(:adjustment, adjustable: order, order: order, source_type: 'Spree::Order', source_id: nil)
-    end
-
-    let!(:non_tax_adjustment_without_source) do
-      create(:adjustment, adjustable: order, order: order, source: nil)
-    end
-
-    it 'select non-tax adjustments' do
-      expect(subject).to_not include tax_adjustment
-      expect(subject).to     include non_tax_adjustment_with_source
-      expect(subject).to     include non_tax_adjustment_without_source
-    end
-  end
-
-  context '#currency' do
-    let(:order) { Spree::Order.new currency: 'JPY' }
-
-    it 'returns the adjustables currency' do
-      expect(adjustment.currency).to eq 'JPY'
-    end
-
-    context 'adjustable is nil' do
-      before do
-        adjustment.adjustable = nil
-      end
-      it 'uses the global currency of USD' do
-        expect(adjustment.currency).to eq 'USD'
-      end
-    end
-  end
-
-  context "#display_amount" do
-    before { adjustment.amount = 10.55 }
-
-    it "shows the amount" do
-      expect(adjustment.display_amount.to_s).to eq "$10.55"
-    end
-
-    context "with currency set to JPY" do
-      let(:order) { Spree::Order.new currency: 'JPY' }
-
-      context "when adjustable is set to an order" do
-        it "displays in JPY" do
-          expect(adjustment.display_amount.to_s).to eq "¥11"
-        end
-      end
-    end
-  end
-
-  context '#recalculate' do
-    subject { adjustment.recalculate }
-    let(:adjustment) do
-      line_item.adjustments.create!(
-        label: 'Adjustment',
-        order: order,
-        adjustable: order,
-        amount: 5,
-        finalized: finalized,
-        source: source,
-      )
-    end
-    let(:order) { create(:order_with_line_items, line_items_price: 100) }
-    let(:line_item) { order.line_items.to_a.first }
-
-    context "when adjustment is finalized" do
-      let(:finalized) { true }
-
-      context 'with a promotion adjustment' do
-        let(:source) { promotion.actions.first! }
-        let(:promotion) { create(:promotion, :with_line_item_adjustment, adjustment_rate: 7) }
-
-        it 'does not update the adjustment' do
-          expect { subject }.not_to change { adjustment.amount }
-        end
-      end
-
-      context 'with a tax adjustment' do
-        let(:source) { mock_model(Spree::TaxRate, compute_amount: 10) }
-
-        it 'updates the adjustment' do
-          expect { subject }.to change { adjustment.amount }.from(5).to(10)
-        end
-      end
-
-      context 'with a sourceless adjustment' do
-        let(:source) { nil }
-
-        it 'does nothing' do
-          expect { subject }.not_to change { adjustment.amount }
-        end
-      end
-    end
-
-    context "when adjustment isn't finalized" do
-      let(:finalized) { false }
-
-      context 'with a promotion adjustment' do
-        let(:source) { promotion.actions.first! }
-        let(:promotion) { create(:promotion, :with_line_item_adjustment, adjustment_rate: 7) }
-
-        context 'when the promotion is eligible' do
-          it 'updates the adjustment' do
-            expect { subject }.to change { adjustment.amount }.from(5).to(-7)
-          end
-
-          it 'sets the adjustment elgiible to true' do
-            subject
-            expect(adjustment.eligible).to eq(true)
-          end
-        end
-
-        context 'when the promotion is not eligible' do
-          before do
-            promotion.update!(starts_at: 1.day.from_now)
-          end
-
-          it 'zeros out the adjustment' do
-            expect { subject }.to change { adjustment.amount }.from(5).to(0)
-          end
-
-          it 'sets the adjustment elgiible to false' do
-            subject
-            expect(adjustment.eligible).to eq(false)
-          end
-        end
-      end
-
-      context 'with a tax adjustment' do
-        let(:source) { mock_model(Spree::TaxRate, compute_amount: 10) }
-
-        it 'updates the adjustment' do
-          expect { subject }.to change { adjustment.amount }.from(5).to(10)
-        end
-      end
-
-      context 'with a sourceless adjustment' do
-        let(:source) { nil }
-
-        it 'does nothing' do
-          expect { subject }.to_not change { adjustment.amount }
-        end
-      end
-    end
-  end
-
-  describe "promotion code presence error" do
-    subject do
-      adjustment.valid?
-      adjustment.errors[:promotion_code]
-    end
-
-    context "when the adjustment is not a promotion adjustment" do
-      let(:adjustment) { build(:adjustment) }
-
-      it { is_expected.to be_blank }
-    end
-
-    context "when the adjustment is a promotion adjustment" do
-      let(:adjustment) { build(:adjustment, source: promotion.actions.first) }
-      let(:promotion) { create(:promotion, :with_order_adjustment) }
-
-      context "when the promotion does not have a code" do
-        it { is_expected.to be_blank }
-      end
-
-      context "when the promotion has a code" do
-        let!(:promotion_code) { create(:promotion_code, promotion: promotion) }
-
-        it { is_expected.to include("can't be blank") }
-      end
-    end
-  end
-
-  describe 'repairing adjustment associations' do
-    context 'on create' do
-      let(:adjustable) { order }
-      let(:adjustment_source) { promotion.actions[0] }
-      let(:order) { create(:order) }
-      let(:promotion) { create(:promotion, :with_line_item_adjustment) }
-
-      def expect_deprecation_warning
-        expect(Spree::Deprecation).to(
-          receive(:warn).
-          with(
-            /Adjustment \d+ was not added to #{adjustable.class} #{adjustable.id}/,
-            instance_of(Array),
-          )
-        )
-      end
-
-      context 'when adding adjustments via the wrong association' do
-        def create_adjustment
-          adjustment_source.adjustments.create!(
-            amount: 10,
-            adjustable: adjustable,
-            order: order,
-            label: 'some label',
-          )
-        end
-
-        context 'when adjustable.adjustments is loaded' do
-          before { adjustable.adjustments.to_a }
-
-          it 'repairs adjustable.adjustments' do
-            expect_deprecation_warning
-            adjustment = create_adjustment
-            expect(adjustable.adjustments).to include(adjustment)
-          end
-
-          context 'when the adjustment is destroyed before after_commit runs' do
-            it 'does not repair' do
-              expect(Spree::Deprecation).not_to receive(:warn)
-              Spree::Adjustment.transaction do
-                adjustment = create_adjustment
-                adjustment.destroy!
-              end
-            end
-          end
-        end
-
-        context 'when adjustable.adjustments is not loaded' do
-          it 'does repair' do
-            expect(Spree::Deprecation).not_to receive(:warn)
-            create_adjustment
-          end
-        end
-      end
-
-      context 'when adding adjustments via the correct association' do
-        def create_adjustment
-          adjustable.adjustments.create!(
-            amount: 10,
-            source: adjustment_source,
-            order: order,
-            label: 'some label',
-          )
-        end
-
-        context 'when adjustable.adjustments is loaded' do
-          before { adjustable.adjustments.to_a }
-
-          it 'does not repair' do
-            expect(Spree::Deprecation).not_to receive(:warn)
-            create_adjustment
-          end
-        end
-
-        context 'when adjustable.adjustments is not loaded' do
-          it 'does not repair' do
-            expect(Spree::Deprecation).not_to receive(:warn)
-            create_adjustment
-          end
-        end
-      end
-    end
-
-    context 'on destroy' do
-      let(:adjustment) { create(:adjustment) }
-      let(:adjustable) { adjustment.adjustable }
-
-      def expect_deprecation_warning(adjustable)
-        expect(Spree::Deprecation).to(
-          receive(:warn).
-          with(
-            /Adjustment #{adjustment.id} was not removed from #{adjustable.class} #{adjustable.id}/,
-            instance_of(Array),
-          )
-        )
-      end
-
-      context 'when destroying adjustments not via association' do
-        context 'when adjustable.adjustments is loaded' do
-          before { adjustable.adjustments.to_a }
-
-          it 'repairs adjustable.adjustments' do
-            expect_deprecation_warning(adjustable)
-            adjustment.destroy!
-            expect(adjustable.adjustments).not_to include(adjustment)
-          end
-        end
-
-        context 'when adjustable.adjustments is not loaded' do
-          it 'does not repair' do
-            expect(Spree::Deprecation).not_to receive(:warn)
-            adjustment.destroy!
-          end
-        end
-      end
-
-      context 'when destroying adjustments via the association' do
-        context 'when adjustable.adjustments is loaded' do
-          before { adjustable.adjustments.to_a }
-
-          it 'does not repair' do
-            expect(Spree::Deprecation).not_to receive(:warn)
-            adjustable.adjustments.destroy(adjustment)
-          end
-        end
-
-        context 'when adjustable.adjustments is not loaded' do
-          it 'does not repair' do
-            expect(Spree::Deprecation).not_to receive(:warn)
-            adjustable.adjustments.destroy(adjustment)
-          end
-        end
-      end
-    end
-  end
-end