solidus_core 2.10.5 → 2.11.0

data/spec/lib/spree/core/role_configuration_spec.rb

@@ -1,155 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe Spree::RoleConfiguration do
-  class DummyPermissionSet < Spree::PermissionSets::Base
-    def activate!
-      can :manage, :things
-    end
-  end
-  class OtherDummyPermissionSet < Spree::PermissionSets::Base; end
-
-  let(:instance) { Spree::RoleConfiguration.new }
-
-  describe ".configure" do
-    around(:each) do |example|
-      Spree::Deprecation.silence { example.run }
-    end
-
-    it "yields with the instance" do
-      expect { |b| described_class.configure(&b) }.to yield_with_args(described_class.instance)
-    end
-
-    it "only yields once" do
-      expect { |b| described_class.configure(&b) }.to yield_control.once
-    end
-  end
-
-  describe "#assign_permissions" do
-    let(:name) { "thing" }
-    subject { instance.assign_permissions name, [DummyPermissionSet] }
-
-    context "when a role for the name exists" do
-      before do
-        instance.roles[name] = described_class::Role.new(name, Set.new(existing_roles))
-      end
-
-      context "when adding duplicate permission sets" do
-        let(:existing_roles) { [DummyPermissionSet] }
-
-        it "does not add another role" do
-          expect{ subject }.to_not change{ instance.roles.count }
-        end
-
-        it "does not add duplicate permission sets" do
-          subject
-          role = instance.roles.values.detect { |r| r.name == name }
-          expect(role.permission_sets).to match_array([DummyPermissionSet])
-        end
-      end
-
-      context "when adding new permission sets to an existing role" do
-        let(:existing_roles) { [OtherDummyPermissionSet] }
-
-        it "does not add another role" do
-          expect{ subject }.to_not change{ instance.roles.count }
-        end
-
-        it "appends the permission set to the existing role" do
-          subject
-          role = instance.roles.values.detect { |r| r.name == name }
-          expect(role.permission_sets).to match_array([OtherDummyPermissionSet, DummyPermissionSet])
-        end
-      end
-    end
-
-    context "when a role for the name does not yet exist" do
-      it "creates a new role" do
-        expect{ subject }.to change{ instance.roles.count }.from(0).to(1)
-      end
-
-      it "sets the roles name accordingly" do
-        subject
-        expect(instance.roles.values.first.name).to eql(name)
-      end
-
-      it "sets the permission sets accordingly" do
-        subject
-        expect(instance.roles.values.first.permission_sets).to match_array([DummyPermissionSet])
-      end
-    end
-  end
-
-  describe "#activate_permissions!" do
-    let(:user) { build :user }
-    let(:role_name) { "testrole" }
-    let(:ability) { DummyAbility.new }
-
-    before do
-      user.spree_roles = user_roles.map do |role|
-        Spree::Role.create!(name: role)
-      end
-    end
-
-    subject { instance.activate_permissions! ability, user }
-
-    context "when the configuration has roles" do
-      before do
-        instance.roles[role_name] = described_class::Role.new(role_name, [DummyPermissionSet])
-      end
-
-      context "default_role" do
-        let(:role_name) { 'default' }
-
-        context "when the user has no roles" do
-          let(:user_roles) { [] }
-
-          it "activates the applicable permissions on the ability" do
-            expect{ subject }.to change{ ability.can? :manage, :things }.
-              from(false).
-              to(true)
-          end
-        end
-
-        context "when the user has a different role" do
-          let(:user_roles) { [] }
-
-          it "activates the applicable permissions on the ability" do
-            expect{ subject }.to change{ ability.can? :manage, :things }.
-              from(false).
-              to(true)
-          end
-        end
-      end
-
-      context "when the configuration has applicable roles" do
-        let(:user_roles) { [role_name, "someotherrandomrole"] }
-
-        it "activates the applicable permissions on the ability" do
-          expect{ subject }.to change{ ability.can? :manage, :things }.
-            from(false).
-            to(true)
-        end
-      end
-
-      context "when the configuration does not have applicable roles" do
-        let(:user_roles) { ["somerandomrole"] }
-
-        it "doesn't activate non matching roles" do
-          subject
-          expect(ability.can?(:manage, :things)).to be false
-        end
-      end
-    end
-
-    context "when the configuration does not have roles" do
-      let(:user_roles) { ["somerandomrole"] }
-
-      it "doesnt activate any new permissions" do
-        subject
-        expect(ability.can?(:manage, :things)).to be false
-      end
-    end
-  end
-end

data/spec/lib/spree/core/stock_configuration_spec.rb

@@ -1,95 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe Spree::Core::StockConfiguration do
-  describe '#coordinator_class' do
-    let(:stock_configuration) { described_class.new }
-    subject { stock_configuration.coordinator_class }
-
-    it "returns Spree::Stock::Coordinator" do
-      is_expected.to be ::Spree::Stock::SimpleCoordinator
-    end
-
-    context "with another constant name assiged" do
-      MyCoordinator = Class.new
-      before { stock_configuration.coordinator_class = MyCoordinator.to_s }
-
-      it "returns the constant" do
-        is_expected.to be MyCoordinator
-      end
-    end
-  end
-
-  describe '#estimator_class' do
-    let(:stock_configuration) { described_class.new }
-    subject { stock_configuration.estimator_class }
-
-    it "returns Spree::Stock::Estimator" do
-      is_expected.to be ::Spree::Stock::Estimator
-    end
-
-    context "with another constant name assiged" do
-      MyEstimator = Class.new
-      before { stock_configuration.estimator_class = MyEstimator.to_s }
-
-      it "returns the constant" do
-        is_expected.to be MyEstimator
-      end
-    end
-  end
-
-  describe '#location_filter_class' do
-    let(:stock_configuration) { described_class.new }
-    subject { stock_configuration.location_filter_class }
-
-    it "returns Spree::Stock::LocationFilter::Active" do
-      is_expected.to be ::Spree::Stock::LocationFilter::Active
-    end
-
-    context "with another constant name assiged" do
-      MyFilter = Class.new
-      before { stock_configuration.location_filter_class = MyFilter.to_s }
-
-      it "returns the constant" do
-        is_expected.to be MyFilter
-      end
-    end
-  end
-
-  describe '#location_sorter_class' do
-    let(:stock_configuration) { described_class.new }
-    subject { stock_configuration.location_sorter_class }
-
-    it "returns Spree::Stock::LocationSorter::Unsorted" do
-      is_expected.to be ::Spree::Stock::LocationSorter::Unsorted
-    end
-
-    context "with another constant name assiged" do
-      MySorter = Class.new
-      before { stock_configuration.location_sorter_class = MySorter.to_s }
-
-      it "returns the constant" do
-        is_expected.to be MySorter
-      end
-    end
-  end
-
-  describe '#allocator_class' do
-    let(:stock_configuration) { described_class.new }
-    subject { stock_configuration.allocator_class }
-
-    it "returns Spree::Stock::Allocator::OnHandFirst" do
-      is_expected.to be ::Spree::Stock::Allocator::OnHandFirst
-    end
-
-    context "with another constant name assiged" do
-      MyAllocator = Class.new
-      before { stock_configuration.allocator_class = MyAllocator.to_s }
-
-      it "returns the constant" do
-        is_expected.to be MyAllocator
-      end
-    end
-  end
-end

data/spec/lib/spree/core/testing_support/factories/address_factory_spec.rb

@@ -1,61 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-require 'spree/testing_support/factories/address_factory'
-
-RSpec.describe 'address factory' do
-  let(:factory_class) { Spree::Address }
-
-  describe 'plain address' do
-    let(:factory) { :address }
-
-    it_behaves_like 'a working factory'
-  end
-
-  describe 'ship_address' do
-    let(:factory) { :ship_address }
-
-    it_behaves_like 'a working factory'
-  end
-
-  describe 'bill address' do
-    let(:factory) { :bill_address }
-
-    it_behaves_like 'a working factory'
-  end
-
-  describe 'when passing in a country iso code' do
-    subject { build(:address, country_iso_code: "RO") }
-
-    it 'creates a valid address with actually valid data' do
-      expect(subject).to be_valid
-    end
-  end
-
-  describe 'when passing in a state and country' do
-    subject { build(:address, country_iso_code: country_iso_code, state_code: state_code) }
-
-    context 'when the country has a state with proper code' do
-      let(:country_iso_code) { "US" }
-      let(:state_code) { "NY" }
-
-      it 'works' do
-        expect(subject).to be_valid
-        expect(subject.state.abbr).to eq("NY")
-        expect(subject.country.iso).to eq("US")
-      end
-    end
-  end
-
-  describe 'creating multiple addresses' do
-    let!(:address1) { create(:address) }
-    let!(:address2) { create(:address) }
-
-    it 'shares the same country and state objects' do
-      expect(address1.country).to eq(address2.country)
-      expect(address1.state).to eq(address2.state)
-      expect(Spree::Country.count).to eq(1)
-      expect(Spree::State.count).to eq(1)
-    end
-  end
-end

data/spec/lib/spree/core/testing_support/factories/adjustment_factory_spec.rb

@@ -1,20 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-require 'spree/testing_support/factories/adjustment_factory'
-
-RSpec.describe 'adjustment factory' do
-  let(:factory_class) { Spree::Adjustment }
-
-  describe 'plain adjustment' do
-    let(:factory) { :adjustment }
-
-    it_behaves_like 'a working factory'
-  end
-
-  describe 'tax adjustment' do
-    let(:factory) { :tax_adjustment }
-
-    it_behaves_like 'a working factory'
-  end
-end

data/spec/lib/spree/core/testing_support/factories/adjustment_reason_factory_spec.rb

@@ -1,14 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-require 'spree/testing_support/factories/adjustment_reason_factory'
-
-RSpec.describe 'adjustment reason factory' do
-  let(:factory_class) { Spree::AdjustmentReason }
-
-  describe 'adjustment reason' do
-    let(:factory) { :adjustment_reason }
-
-    it_behaves_like 'a working factory'
-  end
-end

data/spec/lib/spree/core/testing_support/factories/calculator_factory_spec.rb

@@ -1,44 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-require 'spree/testing_support/factories/calculator_factory'
-
-RSpec.describe 'calculator factory' do
-  let(:factory_class) { Spree::Calculator }
-
-  describe 'calculator' do
-    let(:factory) { :calculator }
-
-    it_behaves_like 'a working factory'
-  end
-
-  describe 'no amount calculator' do
-    let(:factory) { :no_amount_calculator }
-
-    it_behaves_like 'a working factory'
-  end
-
-  describe 'default_tax_calculator' do
-    let(:factory) { :default_tax_calculator }
-
-    it_behaves_like 'a working factory'
-  end
-
-  describe 'shipping calculator' do
-    let(:factory) { :shipping_calculator }
-
-    it_behaves_like 'a working factory'
-  end
-
-  describe 'shipping no amount calculator' do
-    let(:factory) { :shipping_no_amount_calculator }
-
-    it_behaves_like 'a working factory'
-  end
-
-  describe 'percent on item calculator' do
-    let(:factory) { :percent_on_item_calculator }
-
-    it_behaves_like 'a working factory'
-  end
-end

data/spec/lib/spree/core/testing_support/factories/carton_factory_spec.rb

@@ -1,14 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-require 'spree/testing_support/factories/carton_factory'
-
-RSpec.describe 'carton factory' do
-  let(:factory_class) { Spree::Carton }
-
-  describe 'plain adjustment' do
-    let(:factory) { :carton }
-
-    it_behaves_like 'a working factory'
-  end
-end

data/spec/lib/spree/core/testing_support/factories/country_factory_spec.rb

@@ -1,14 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-require 'spree/testing_support/factories/country_factory'
-
-RSpec.describe 'country factory' do
-  let(:factory_class) { Spree::Country }
-
-  describe 'plain adjustment' do
-    let(:factory) { :country }
-
-    it_behaves_like 'a working factory'
-  end
-end

data/spec/lib/spree/core/testing_support/factories/credit_card_factory_spec.rb

@@ -1,14 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-require 'spree/testing_support/factories/credit_card_factory'
-
-RSpec.describe 'credit card factory' do
-  let(:factory_class) { Spree::CreditCard }
-
-  describe 'plain credit card' do
-    let(:factory) { :credit_card }
-
-    it_behaves_like 'a working factory'
-  end
-end

data/spec/lib/spree/core/testing_support/factories/customer_return_factory_spec.rb

@@ -1,39 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-require 'spree/testing_support/factories/customer_return_factory'
-
-RSpec.describe 'customer return factory' do
-  let(:factory_class) { Spree::CustomerReturn }
-
-  describe 'customer return' do
-    let(:factory) { :customer_return }
-
-    it_behaves_like 'a working factory'
-
-    # Regression test for https://github.com/solidusio/solidus/pull/697
-    it "creates only one of dependent records" do
-      create(:customer_return, line_items_count: 2)
-      aggregate_failures "items created" do
-        expect(Spree::Order.count).to eq(1)
-        expect(Spree::ReturnAuthorization.count).to eq(1)
-      end
-    end
-  end
-
-  describe 'customer return with accepted items' do
-    let(:factory) { :customer_return_with_accepted_items }
-
-    it_behaves_like 'a working factory'
-  end
-
-  describe 'customer return without return items' do
-    let(:factory) { :customer_return_without_return_items }
-
-    it "builds successfully" do
-      expect(build(factory)).to be_a(factory_class)
-    end
-
-    # No create test, because this factory is (intentionally) invalid
-  end
-end