solidus_backend 1.1.0 → 1.1.1

data/spec/controllers/spree/admin/product_properties_controller_spec.rb

@@ -0,0 +1,69 @@
+require 'spec_helper'
+
+module Spree
+  module Admin
+    describe ProductPropertiesController, type: :controller do
+      stub_authorization!
+
+      describe "#index" do
+        subject { spree_get :index, parameters }
+
+        context "no option values are provided" do
+          let(:product) { create(:product) }
+          let(:parameters) do
+            { product_id: product.to_param }
+          end
+
+          before { subject }
+
+          it "instantiates a new variant property rule" do
+            expect(assigns(:variant_property_rule)).to_not be_persisted
+          end
+
+          it "instantiates a new variant property rule value" do
+            expect(assigns(:variant_property_rule).values.size).to eq 1
+            expect(assigns(:variant_property_rule).values.first).to_not be_persisted
+          end
+        end
+
+        context "option values are provided" do
+          let(:size) { create(:option_type, name: 'size') }
+          let(:product) { create(:product, option_types: [size]) }
+          let(:size_small) { create(:option_value, name: 'small', option_type: size) }
+          let(:size_large) { create(:option_value, name: 'large', option_type: size) }
+          let!(:first_rule) { create(:variant_property_rule, product: product, option_value: size_small) }
+
+          context "no rules match the option values" do
+            let(:parameters) do
+              {
+                product_id: product.to_param,
+                ovi: [size_large.id]
+              }
+            end
+
+            before { subject }
+
+            it "instantiates a new variant property rule" do
+              expect(assigns(:variant_property_rule)).to_not be_persisted
+            end
+          end
+
+          context "a rule matches the option values" do
+            let(:parameters) do
+              {
+                product_id: product.to_param,
+                ovi: [size_small.id]
+              }
+            end
+
+            before { subject }
+
+            it "assigns the property rule to the only property rule that matches the option values" do
+              expect(assigns(:variant_property_rule)).to eq first_rule
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/spec/controllers/spree/admin/products_controller_spec.rb

@@ -0,0 +1,162 @@
+require 'spec_helper'
+
+describe Spree::Admin::ProductsController, :type => :controller do
+  stub_authorization!
+
+  context "#index" do
+    let(:ability_user) { stub_model(Spree::LegacyUser, :has_spree_role? => true) }
+
+    # Regression test for #1259
+    it "can find a product by SKU" do
+      product = create(:product, :sku => "ABC123")
+      spree_get :index, :q => { :sku_start => "ABC123" }
+      expect(assigns[:collection]).not_to be_empty
+      expect(assigns[:collection]).to include(product)
+    end
+  end
+
+  # regression test for #1370
+  context "adding properties to a product" do
+    let!(:product) { create(:product) }
+    specify do
+      spree_put :update, :id => product.to_param, :product => { :product_properties_attributes => { "1" => { :property_name => "Foo", :value => "bar" } } }
+      expect(flash[:success]).to eq("Product #{product.name.inspect} has been successfully updated!")
+    end
+  end
+
+  describe "creating variant property rules" do
+    let(:first_property) { create(:property) }
+    let(:second_property) { create(:property) }
+    let(:option_value) { create(:option_value) }
+    let!(:product) { create(:product, option_types: [option_value.option_type]) }
+    let(:payload) do
+      {
+        id: product.to_param,
+        product: {
+          id: product.id,
+          variant_property_rules_attributes: {
+            "0" => {
+              option_value_ids: option_value.id,
+              values_attributes: {
+                "0" => {
+                  property_name: first_property.name,
+                  value: "First"
+                },
+                "1" => {
+                  property_name: second_property.name,
+                  value: "Second"
+                }
+              }
+            }
+          }
+        }
+      }
+    end
+
+    subject { spree_put :update, payload }
+
+    it "creates a variant property rule" do
+      expect { subject }.to change { product.variant_property_rules.count }.by(1)
+    end
+
+    it "creates a variant property rule condition" do
+      expect { subject }.to change { product.variant_property_rule_conditions.count }.by(1)
+    end
+
+    it "creates a variant property rule value for the 'First' value" do
+      subject
+      expect(product.variant_property_rule_values.find_by(value: 'First')).to_not be_nil
+    end
+
+    it "creates a variant property rule value for the 'Second' value" do
+      subject
+      expect(product.variant_property_rule_values.find_by(value: 'Second')).to_not be_nil
+    end
+
+    it "redirects to the product properties page" do
+      subject
+      expect(response).to redirect_to(spree.admin_product_product_properties_path(product, ovi: [option_value.id]))
+    end
+  end
+
+  describe "updating variant property rules" do
+    let(:first_property) { create(:property) }
+    let(:second_property) { create(:property) }
+    let(:option_value) { create(:option_value) }
+    let(:original_option_value) { create(:option_value) }
+    let!(:product) { create(:product, option_types: [option_value.option_type]) }
+    let!(:rule) do
+      create(:variant_property_rule, product: product, option_value: original_option_value)
+    end
+    let(:payload) do
+      {
+        id: product.to_param,
+        product: {
+          id: product.id,
+          variant_property_rules_attributes: {
+            "0" => {
+              id: rule.id,
+              option_value_ids: option_value.id,
+              values_attributes: {
+                "0" => {
+                  property_name: first_property.name,
+                  value: "First Edit"
+                },
+                "1" => {
+                  property_name: second_property.name,
+                  value: "Second Edit"
+                }
+              }
+            }
+          }
+        }
+      }
+    end
+
+    subject { spree_put :update, payload }
+
+    it "does not create any new rules" do
+      expect { subject }.to_not change { Spree::VariantPropertyRule.count }
+    end
+
+    it "replaces the rule's condition" do
+      expect { subject }.to change { rule.option_value_ids }.from([original_option_value.id]).to([option_value.id])
+    end
+
+    it "adds two values to the rule" do
+      expect { subject }.to change { rule.values.count }.by(2)
+    end
+
+    it "creates the 'First Edit' value" do
+      subject
+      expect(rule.values.find_by(value: 'First Edit')).to_not be_nil
+    end
+
+    it "creates the 'Second Edit' value" do
+      subject
+      expect(rule.values.find_by(value: 'Second Edit')).to_not be_nil
+    end
+
+    it "redirects to the product properties page" do
+      subject
+      expect(response).to redirect_to(spree.admin_product_product_properties_path(product, ovi: [option_value.id]))
+    end
+  end
+
+  # regression test for #801
+  context "destroying a product" do
+    let(:product) do
+      product = create(:product)
+      create(:variant, :product => product)
+      product
+    end
+
+    it "deletes all the variants (including master) for the product" do
+      spree_delete :destroy, :id => product
+      expect(product.reload.deleted_at).not_to be_nil
+      product.variants_including_master.each do |variant|
+        expect(variant.reload.deleted_at).not_to be_nil
+      end
+    end
+  end
+end

data/spec/controllers/spree/admin/promotion_actions_controller_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe Spree::Admin::PromotionActionsController, :type => :controller do
+  stub_authorization!
+
+  let!(:promotion) { create(:promotion) }
+
+  it "can create a promotion action of a valid type" do
+    spree_post :create, :promotion_id => promotion.id, :action_type => "Spree::Promotion::Actions::CreateAdjustment"
+    expect(response).to be_redirect
+    expect(response).to redirect_to spree.edit_admin_promotion_path(promotion)
+    expect(promotion.actions.count).to eq(1)
+  end
+
+  it "can not create a promotion action of an invalid type" do
+    spree_post :create, :promotion_id => promotion.id, :action_type => "Spree::InvalidType"
+    expect(response).to be_redirect
+    expect(response).to redirect_to spree.edit_admin_promotion_path(promotion)
+    expect(promotion.rules.count).to eq(0)
+  end
+end

data/spec/controllers/spree/admin/promotion_codes_controller_spec.rb

@@ -0,0 +1,18 @@
+require 'spec_helper'
+
+describe Spree::Admin::PromotionCodesController do
+  stub_authorization!
+  render_views
+
+  let!(:promotion) { create(:promotion) }
+  let!(:code1) { create(:promotion_code, promotion: promotion) }
+  let!(:code2) { create(:promotion_code, promotion: promotion) }
+  let!(:code3) { create(:promotion_code, promotion: promotion) }
+
+  it "can create a promotion rule of a valid type" do
+    spree_get :index, promotion_id: promotion.id, format: 'csv'
+    expect(response).to be_success
+    parsed = CSV.parse(response.body, headers: true)
+    expect(parsed.entries.map(&:to_h)).to eq([{"Code" => code1.value}, {"Code" => code2.value}, {"Code" => code3.value}])
+  end
+end

data/spec/controllers/spree/admin/promotion_rules_controller_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe Spree::Admin::PromotionRulesController, :type => :controller do
+  stub_authorization!
+
+  let!(:promotion) { create(:promotion) }
+
+  it "can create a promotion rule of a valid type" do
+    spree_post :create, :promotion_id => promotion.id, :promotion_rule => { :type => "Spree::Promotion::Rules::Product" }
+    expect(response).to be_redirect
+    expect(response).to redirect_to spree.edit_admin_promotion_path(promotion)
+    expect(promotion.rules.count).to eq(1)
+  end
+
+  it "can not create a promotion rule of an invalid type" do
+    spree_post :create, :promotion_id => promotion.id, :promotion_rule => { :type => "Spree::InvalidType" }
+    expect(response).to be_redirect
+    expect(response).to redirect_to spree.edit_admin_promotion_path(promotion)
+    expect(promotion.rules.count).to eq(0)
+  end
+end

data/spec/controllers/spree/admin/promotions_controller_spec.rb

@@ -0,0 +1,122 @@
+require 'spec_helper'
+
+describe Spree::Admin::PromotionsController, :type => :controller do
+  stub_authorization!
+
+  let!(:promotion1) { create(:promotion, name: "name1", code: "code1", path: "path1") }
+  let!(:promotion2) { create(:promotion, name: "name2", code: "code2", path: "path2") }
+  let!(:category) { create :promotion_category }
+
+  describe "#index" do
+
+    it "succeeds" do
+      spree_get :index
+      expect(assigns[:promotions]).to match_array [promotion2, promotion1]
+    end
+
+    it "assigns promotion categories" do
+      spree_get :index
+      expect(assigns[:promotion_categories]).to match_array [category]
+    end
+
+    context "search" do
+      it "pages results" do
+        spree_get :index, per_page: '1'
+        expect(assigns[:promotions]).to eq [promotion2]
+      end
+
+      it "filters by name" do
+        spree_get :index, q: {name_cont: promotion1.name}
+        expect(assigns[:promotions]).to eq [promotion1]
+      end
+
+      it "filters by code" do
+        spree_get :index, q: {codes_value_cont: promotion1.codes.first.value }
+        expect(assigns[:promotions]).to eq [promotion1]
+      end
+
+      it "filters by path" do
+        spree_get :index, q: {path_cont: promotion1.path}
+        expect(assigns[:promotions]).to eq [promotion1]
+      end
+    end
+  end
+
+  describe "#create" do
+    subject { spree_post :create, params }
+    let(:params) { {promotion: {name: 'some promo'}} }
+
+    context "it succeeds" do
+      it "creates a promotion" do
+        expect { subject }.to change { Spree::Promotion.count }.by(1)
+      end
+
+      it "sets the flash message" do
+        subject
+        expect(flash[:success]).to eq "Promotion has been successfully created!"
+      end
+
+      it "redirects to promotion edit" do
+        subject
+        expect(response).to redirect_to "http://test.host/admin/promotions/#{assigns(:promotion).id}/edit"
+      end
+
+      context "with one promo codes" do
+        let(:params) do
+          super().merge(promotion_builder: { base_code: 'abc', number_of_codes: 1 })
+        end
+
+        it "succeeds and creates one code" do
+          expect {
+            expect {
+              subject
+            }.to change { Spree::Promotion.count }.by(1)
+          }.to change { Spree::PromotionCode.count }.by(1)
+
+          expect(assigns(:promotion).codes.first.value).to eq ('abc')
+        end
+      end
+
+      context "with multiple promo codes" do
+        let(:params) do
+          super().merge(promotion_builder: { base_code: 'abc', number_of_codes: 2 })
+        end
+
+        it "succeeds and creates multiple codes" do
+          expect {
+            expect {
+              subject
+            }.to change { Spree::Promotion.count }.by(1)
+          }.to change { Spree::PromotionCode.count }.by(2)
+
+          codes = assigns(:promotion).codes.map(&:value).sort
+          expect(codes.length).to be 2
+          expect(codes[0]).to match(/abc_[a-z]{6}/)
+          expect(codes[1]).to match(/abc_[a-z]{6}/)
+        end
+      end
+    end
+
+    context "it fails" do
+      let(:params) { {} }
+
+      it "does not create a promotion" do
+        expect {
+          subject
+        }.not_to change { Spree::Promotion.count }
+      end
+
+      it "sets the flash error" do
+        subject
+        expect(flash[:error]).to eq "Name can't be blank"
+      end
+
+      it "renders new" do
+        subject
+        expect(response).to render_template :new
+      end
+    end
+
+  end
+
+end

data/spec/controllers/spree/admin/refunds_controller_spec.rb

@@ -0,0 +1,32 @@
+require 'spec_helper'
+
+describe Spree::Admin::RefundsController do
+  stub_authorization!
+
+  describe "POST create" do
+    context "a Spree::Core::GatewayError is raised" do
+
+      let(:payment) { create(:payment) }
+
+      subject do
+        spree_post :create,
+                   refund: { amount: "50.0", refund_reason_id: "1" },
+                   order_id: payment.order_id,
+                   payment_id: payment.id
+      end
+
+      before(:each) do
+        def controller.create
+          raise Spree::Core::GatewayError.new('An error has occurred')
+        end
+      end
+
+      it "sets an error message with the correct text" do
+        subject
+        expect(flash[:error]).to eq 'An error has occurred'
+      end
+
+      it { is_expected.to render_template(:new) }
+    end
+  end
+end

data/spec/controllers/spree/admin/reimbursements_controller_spec.rb

@@ -0,0 +1,124 @@
+require 'spec_helper'
+
+describe Spree::Admin::ReimbursementsController, :type => :controller do
+  stub_authorization!
+
+  let!(:default_refund_reason) do
+    Spree::RefundReason.find_or_create_by!(name: Spree::RefundReason::RETURN_PROCESSING_REASON, mutable: false)
+  end
+
+  describe '#edit' do
+    let(:reimbursement) { create(:reimbursement) }
+    let(:order) { reimbursement.order }
+    let!(:active_stock_location) { create(:stock_location, active: true) }
+    let!(:inactive_stock_location) { create(:stock_location, active: false) }
+
+    subject do
+      spree_get :edit, order_id: order.to_param, id: reimbursement.to_param
+    end
+
+    it "loads all the active stock locations" do
+      subject
+      expect(assigns(:stock_locations)).to include(active_stock_location)
+      expect(assigns(:stock_locations)).not_to include(inactive_stock_location)
+    end
+  end
+
+  describe '#create' do
+    let(:customer_return)  { create(:customer_return, line_items_count: 1) }
+    let(:order) { customer_return.order }
+    let(:return_item) { customer_return.return_items.first }
+    let(:payment) { order.payments.first }
+    before { return_item.receive! }
+
+    subject do
+      spree_post :create, order_id: order.to_param, build_from_customer_return_id: customer_return.id
+    end
+
+    it 'creates the reimbursement' do
+      expect { subject }.to change { order.reimbursements.count }.by(1)
+      expect(assigns(:reimbursement).return_items.to_a).to eq customer_return.return_items.to_a
+    end
+
+    it 'redirects to the edit page' do
+      subject
+      expect(response).to redirect_to(spree.edit_admin_order_reimbursement_path(order, assigns(:reimbursement)))
+    end
+
+    context 'when create fails' do
+      before do
+        allow_any_instance_of(Spree::Reimbursement).to receive(:valid?) do |reimbursement, *args|
+          reimbursement.errors.add(:base, 'something bad happened')
+          false
+        end
+      end
+
+      context 'when a referer header is present' do
+        let(:referer) { spree.edit_admin_order_customer_return_path(order, customer_return) }
+
+        it 'redirects to the referer' do
+          request.env["HTTP_REFERER"] = referer
+          expect {
+            spree_post :create, order_id: order.to_param
+          }.to_not change { Spree::Reimbursement.count }
+          expect(response).to redirect_to(referer)
+          expect(flash[:error]).to eq("something bad happened")
+        end
+      end
+
+      context 'when a referer header is not present' do
+        it 'redirects to the admin root' do
+          expect {
+            spree_post :create, order_id: order.to_param
+          }.to_not change { Spree::Reimbursement.count }
+          expect(response).to redirect_to(spree.admin_path)
+          expect(flash[:error]).to eq("something bad happened")
+        end
+      end
+    end
+  end
+
+  describe "#perform" do
+    let(:reimbursement) { create(:reimbursement) }
+    let(:customer_return) { reimbursement.customer_return }
+    let(:order) { reimbursement.order }
+    let(:return_items) { reimbursement.return_items }
+    let(:payment) { order.payments.first }
+
+    subject do
+      spree_post :perform, order_id: order.to_param, id: reimbursement.to_param
+    end
+
+    it 'redirects to customer return page' do
+      subject
+      expect(response).to redirect_to spree.admin_order_reimbursement_path(order, reimbursement)
+    end
+
+    it 'performs the reimbursement' do
+      expect {
+        subject
+      }.to change { payment.refunds.count }.by(1)
+      expect(payment.refunds.last.amount).to be > 0
+      expect(payment.refunds.last.amount).to eq return_items.to_a.sum(&:total)
+    end
+
+    context "a Spree::Core::GatewayError is raised" do
+      before(:each) do
+        def controller.perform
+          raise Spree::Core::GatewayError.new('An error has occurred')
+        end
+      end
+
+      it "sets an error message with the correct text" do
+        subject
+        expect(flash[:error]).to eq 'An error has occurred'
+      end
+
+      it 'redirects to the edit page' do
+        subject
+        redirect_path = spree.edit_admin_order_reimbursement_path(order, assigns(:reimbursement))
+        expect(response).to redirect_to(redirect_path)
+      end
+    end
+  end
+end