solidus_backend 1.1.0 → 1.1.1

data/spec/features/admin/products/option_types_spec.rb

@@ -0,0 +1,114 @@
+require 'spec_helper'
+
+describe "Option Types", :type => :feature do
+  stub_authorization!
+
+  before(:each) do
+    visit spree.admin_path
+    click_link "Products"
+  end
+
+  context "listing option types" do
+    it "should list existing option types" do
+      create(:option_type, :name => "tshirt-color", :presentation => "Color")
+      create(:option_type, :name => "tshirt-size", :presentation => "Size")
+
+      click_link "Option Types"
+      within("table#listing_option_types") do
+        expect(page).to have_content("Color")
+        expect(page).to have_content("tshirt-color")
+        expect(page).to have_content("Size")
+        expect(page).to have_content("tshirt-size")
+      end
+    end
+  end
+
+  context "creating a new option type" do
+    it "should allow an admin to create a new option type", :js => true do
+      click_link "Option Types"
+      click_link "new_option_type_link"
+      expect(page).to have_content("NEW OPTION TYPE")
+      fill_in "option_type_name", :with => "shirt colors"
+      fill_in "option_type_presentation", :with => "colors"
+      click_button "Create"
+      expect(page).to have_content("successfully created!")
+
+      page.find('#option_type_option_values_attributes_0_name').set('color')
+      page.find('#option_type_option_values_attributes_0_presentation').set('black')
+
+      click_button "Update"
+      expect(page).to have_content("successfully updated!")
+    end
+  end
+
+  context "editing an existing option type" do
+    it "should allow an admin to update an existing option type" do
+      create(:option_type, :name => "tshirt-color", :presentation => "Color")
+      create(:option_type, :name => "tshirt-size", :presentation => "Size")
+      click_link "Option Types"
+      within('table#listing_option_types') { click_link "Edit" }
+      fill_in "option_type_name", :with => "foo-size 99"
+      click_button "Update"
+      expect(page).to have_content("successfully updated!")
+      expect(page).to have_content("foo-size 99")
+    end
+  end
+
+  # Regression test for #2277
+  it "can remove an option value from an option type", :js => true do
+    create(:option_value)
+    click_link "Option Types"
+    within('table#listing_option_types') { click_icon :edit }
+    expect(page).to have_content("Editing Option Type")
+    expect(all("tbody#option_values tr").count).to eq(1)
+    within("tbody#option_values") do
+      find('.spree_remove_fields').click
+    end
+    # Assert that the field is hidden automatically
+    expect(all("tbody#option_values tr").select(&:visible?).count).to eq(0)
+
+    # Then assert that on a page refresh that it's still not visible
+    visit page.current_url
+    # What *is* visible is a new option value field, with blank values
+    # Sometimes the page doesn't load before the all check is done
+    # lazily finding the element gives the page 10 seconds
+    expect(page).to have_css("tbody#option_values")
+    all("tbody#option_values tr input").all? { |input| input.value.blank? }
+  end
+  
+  # Regression test for #3204
+  it "can remove a non-persisted option value from an option type", :js => true do
+    create(:option_type)
+    click_link "Option Types"
+    within('table#listing_option_types') { click_icon :edit }
+
+    wait_for_ajax
+    page.find("tbody#option_values", :visible => true)
+
+    expect(all("tbody#option_values tr").select(&:visible?).count).to eq(1)
+
+    # Add a new option type
+    click_link "Add Option Value"
+    expect(all("tbody#option_values tr").select(&:visible?).count).to eq(2)
+
+    # Remove default option type
+    within("tbody#option_values") do
+      find('.fa-trash').click
+    end
+    # Check that there was no HTTP request
+    expect(all("div#progress[style]").count).to eq(0)
+    # Assert that the field is hidden automatically
+    expect(all("tbody#option_values tr").select(&:visible?).count).to eq(1)
+
+    # Remove added option type
+    within("tbody#option_values") do
+      find('.fa-trash').click
+    end
+    # Check that there was no HTTP request
+    expect(all("div#progress[style]").count).to eq(0)
+    # Assert that the field is hidden automatically
+    expect(all("tbody#option_values tr").select(&:visible?).count).to eq(0)
+
+  end
+
+end

data/spec/features/admin/products/products_spec.rb

@@ -0,0 +1,395 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe "Products", :type => :feature do
+  context "as admin user" do
+    stub_authorization!
+
+    before(:each) do
+      visit spree.admin_path
+    end
+
+    def build_option_type_with_values(name, values)
+      ot = FactoryGirl.create(:option_type, :name => name)
+      values.each do |val|
+        ot.option_values.create(:name => val.downcase, :presentation => val)
+      end
+      ot
+    end
+
+    context "listing products" do
+      context "sorting" do
+        before do
+          create(:product, :name => 'apache baseball cap', :price => 10)
+          create(:product, :name => 'zomg shirt', :price => 5)
+        end
+
+        it "should list existing products with correct sorting by name" do
+          click_link "Products"
+          # Name ASC
+          within_row(1) { expect(page).to have_content('apache baseball cap') }
+          within_row(2) { expect(page).to have_content("zomg shirt") }
+
+          # Name DESC
+          click_link "admin_products_listing_name_title"
+          within_row(1) { expect(page).to have_content("zomg shirt")  }
+          within_row(2) { expect(page).to have_content('apache baseball cap') }
+        end
+
+        it "should list existing products with correct sorting by price" do
+          click_link "Products"
+
+          # Name ASC (default)
+          within_row(1) { expect(page).to have_content('apache baseball cap') }
+          within_row(2) { expect(page).to have_content("zomg shirt") }
+
+          # Price DESC
+          click_link "admin_products_listing_price_title"
+          within_row(1) { expect(page).to have_content("zomg shirt") }
+          within_row(2) { expect(page).to have_content('apache baseball cap') }
+        end
+      end
+
+      context "currency displaying" do
+        context "using Russian Rubles" do
+          before do
+            Spree::Config[:currency] = "RUB"
+          end
+
+          let!(:product) do
+            create(:product, :name => "Just a product", :price => 19.99)
+          end
+
+          # Regression test for #2737
+          context "uses руб as the currency symbol" do
+            it "on the products listing page" do
+              visit spree.admin_products_path
+              within_row(1) { expect(page).to have_content("19.99 ₽") }
+            end
+          end
+        end
+      end
+    end
+
+    context "searching products" do
+      it "should be able to search deleted products", :js => true do
+        create(:product, :name => 'apache baseball cap', :deleted_at => "2011-01-06 18:21:13")
+        create(:product, :name => 'zomg shirt')
+
+        click_link "Products"
+        expect(page).to have_content("zomg shirt")
+        expect(page).not_to have_content("apache baseball cap")
+        check "Show Deleted"
+        click_icon :search
+        expect(page).to have_content("zomg shirt")
+        expect(page).to have_content("apache baseball cap")
+        uncheck "Show Deleted"
+        click_icon :search
+        expect(page).to have_content("zomg shirt")
+        expect(page).not_to have_content("apache baseball cap")
+      end
+
+      it "should be able to search products by their properties" do
+        create(:product, :name => 'apache baseball cap', :sku => "A100")
+        create(:product, :name => 'apache baseball cap2', :sku => "B100")
+        create(:product, :name => 'zomg shirt')
+
+        click_link "Products"
+        fill_in "q_name_cont", :with => "ap"
+        click_icon :search
+        expect(page).to have_content("apache baseball cap")
+        expect(page).to have_content("apache baseball cap2")
+        expect(page).not_to have_content("zomg shirt")
+
+        fill_in "q_variants_including_master_sku_cont", :with => "A1"
+        click_icon :search
+        expect(page).to have_content("apache baseball cap")
+        expect(page).not_to have_content("apache baseball cap2")
+        expect(page).not_to have_content("zomg shirt")
+      end
+    end
+
+    context "creating a new product from a prototype" do
+      def build_option_type_with_values(name, values)
+        ot = FactoryGirl.create(:option_type, :name => name)
+        values.each do |val|
+          ot.option_values.create(:name => val.downcase, :presentation => val)
+        end
+        ot
+      end
+
+      let(:product_attributes) do
+        # FactoryGirl.attributes_for is un-deprecated!
+        #   https://github.com/thoughtbot/factory_girl/issues/274#issuecomment-3592054
+        FactoryGirl.attributes_for(:simple_product)
+      end
+
+      let(:prototype) do
+        size = build_option_type_with_values("size", %w(Small Medium Large))
+        FactoryGirl.create(:prototype, :name => "Size", :option_types => [ size ])
+      end
+
+      let(:option_values_hash) do
+        hash = {}
+        prototype.option_types.each do |i|
+          hash[i.id.to_s] = i.option_value_ids
+        end
+        hash
+      end
+
+      before(:each) do
+        @option_type_prototype = prototype
+        @property_prototype = create(:prototype, :name => "Random")
+        @shipping_category = create(:shipping_category)
+        click_link "Products"
+        click_link "admin_new_product"
+        within('#new_product') do
+          expect(page).to have_content("SKU")
+        end
+      end
+
+      it "should allow an admin to create a new product and variants from a prototype", :js => true do
+        fill_in "product_name", :with => "Baseball Cap"
+        fill_in "product_sku", :with => "B100"
+        fill_in "product_price", :with => "100"
+        fill_in "product_available_on", :with => "2012/01/24"
+        select "Size", :from => "Prototype"
+        check "Large"
+        select @shipping_category.name, from: "product_shipping_category_id"
+        click_button "Create"
+        expect(page).to have_content("successfully created!")
+        expect(Spree::Product.last.variants.length).to eq(1)
+      end
+
+      it "should not display variants when prototype does not contain option types", :js => true do
+        select "Random", :from => "Prototype"
+
+        fill_in "product_name", :with => "Baseball Cap"
+
+        expect(page).not_to have_content("Variants")
+      end
+
+      it "should keep option values selected if validation fails", :js => true do
+        fill_in "product_name", :with => "Baseball Cap"
+        fill_in "product_sku", :with => "B100"
+        fill_in "product_price", :with => "100"
+        select "Size", :from => "Prototype"
+        check "Large"
+        click_button "Create"
+        expect(page).to have_content("Shipping category can't be blank")
+        expect(field_labeled("Size")).to be_checked
+        expect(field_labeled("Large")).to be_checked
+        expect(field_labeled("Small")).not_to be_checked
+      end
+    end
+
+    context "creating a new product" do
+      before(:each) do
+        @shipping_category = create(:shipping_category)
+        click_link "Products"
+        click_link "admin_new_product"
+        within('#new_product') do
+          expect(page).to have_content("SKU")
+        end
+      end
+
+      it "should allow an admin to create a new product", :js => true do
+        fill_in "product_name", :with => "Baseball Cap"
+        fill_in "product_sku", :with => "B100"
+        fill_in "product_price", :with => "100"
+        fill_in "product_available_on", :with => "2012/01/24"
+        select @shipping_category.name, from: "product_shipping_category_id"
+        click_button "Create"
+        expect(page).to have_content("successfully created!")
+        click_button "Update"
+        expect(page).to have_content("successfully updated!")
+      end
+
+      it "should show validation errors", :js => true do
+        fill_in "product_name", :with => "Baseball Cap"
+        fill_in "product_sku", :with => "B100"
+        fill_in "product_price", :with => "100"
+        click_button "Create"
+        expect(page).to have_content("Shipping category can't be blank")
+      end
+
+      context "using a locale with a different decimal format " do
+        before do
+          # change English locale’s separator and delimiter to match 19,99 format
+          I18n.backend.store_translations(:en,
+            :number => {
+              :currency => {
+                :format => {
+                  :separator => ",",
+                  :delimiter => "."
+                }
+              }
+            })
+        end
+
+        after do
+          # revert changes to English locale
+          I18n.backend.store_translations(:en,
+            :number => {
+              :currency => {
+                :format => {
+                  :separator => ".",
+                  :delimiter => ","
+                }
+              }
+            })
+        end
+
+        it "should show localized price value on validation errors", :js => true do
+          fill_in "product_price", :with => "19,99"
+          click_button "Create"
+          expect(find('input#product_price').value).to eq('19,99')
+        end
+      end
+
+      # Regression test for #2097
+      it "can set the count on hand to a null value", :js => true do
+        fill_in "product_name", :with => "Baseball Cap"
+        fill_in "product_price", :with => "100"
+        select @shipping_category.name, from: "product_shipping_category_id"
+        click_button "Create"
+        expect(page).to have_content("successfully created!")
+        click_button "Update"
+        expect(page).to have_content("successfully updated!")
+      end
+    end
+
+
+    context "cloning a product", :js => true do
+      it "should allow an admin to clone a product" do
+        create(:product)
+
+        click_link "Products"
+        within_row(1) do
+          click_icon :copy
+        end
+
+        expect(page).to have_content("Product has been cloned")
+      end
+
+      context "cloning a deleted product" do
+        it "should allow an admin to clone a deleted product" do
+          create(:product, :name => "apache baseball cap")
+
+          click_link "Products"
+          check "Show Deleted"
+          click_button "Search"
+
+          expect(page).to have_content("apache baseball cap")
+
+          within_row(1) do
+            click_icon :copy
+          end
+
+          expect(page).to have_content("Product has been cloned")
+        end
+      end
+    end
+
+    context 'updating a product', :js => true do
+      let(:product) { create(:product) }
+
+      let(:prototype) do
+        size = build_option_type_with_values("size", %w(Small Medium Large))
+        FactoryGirl.create(:prototype, :name => "Size", :option_types => [ size ])
+      end
+
+      before(:each) do
+        @option_type_prototype = prototype
+        @property_prototype = create(:prototype, :name => "Random")
+      end
+
+      it 'should parse correctly available_on' do
+        visit spree.admin_product_path(product)
+        fill_in "product_available_on", :with => "2012/12/25"
+        click_button "Update"
+        expect(page).to have_content("successfully updated!")
+        expect(Spree::Product.last.available_on).to eq('Tue, 25 Dec 2012 00:00:00 UTC +00:00')
+      end
+
+      it 'should add option_types when selecting a prototype' do
+        visit spree.admin_product_path(product)
+        click_link 'Product Properties'
+        expect(page).to have_content("SELECT FROM PROTOTYPE")
+        click_link "Select From Prototype"
+
+        row = find('#prototypes tr', text: 'Size')
+        row.click_link 'Select'
+
+        # The following is unfortunate.
+        # It is tough to distinguish between the different fields, so we assert
+        # that there are two rows (ensuring one has been added) and then
+        # inspect the first one.
+        expect(page).to have_css('#product_properties .product_property', count: 2)
+        within('#product_properties .product_property:nth-child(1)') do
+          expect(find('input[type=text]').value).to eq('baseball_cap_color')
+        end
+      end
+    end
+
+    context 'deleting a product', :js => true do
+      let!(:product) { create(:product) }
+
+      it "is still viewable" do
+        visit spree.admin_products_path
+
+        expect(page).to have_content(product.name)
+        accept_alert do
+          click_icon :trash
+        end
+
+        expect(page).to have_no_content(product.name)
+
+        # This will show our deleted product
+        check "Show Deleted"
+        click_icon :search
+        click_link product.name
+        expect(page).to have_field('Master Price', with: product.price.to_f)
+      end
+    end
+  end
+
+  context 'with only product permissions' do
+
+    before do
+      allow_any_instance_of(Spree::Admin::BaseController).to receive(:spree_current_user).and_return(nil)
+    end
+
+    custom_authorization! do |user|
+      can [:admin, :update, :index, :read], Spree::Product
+    end
+    let!(:product) { create(:product) }
+
+    it "should only display accessible links on index" do
+      visit spree.admin_products_path
+      expect(page).to have_link('Products')
+      expect(page).not_to have_link('Option Types')
+      expect(page).not_to have_link('Properties')
+      expect(page).not_to have_link('Prototypes')
+
+      expect(page).not_to have_link('New Product')
+      expect(page).not_to have_css('a.clone')
+      expect(page).to have_css('a.edit')
+      expect(page).not_to have_css('a.delete-resource')
+    end
+
+    it "should only display accessible links on edit" do
+      visit spree.admin_product_path(product)
+
+      # product tabs should be hidden
+      expect(page).to have_link('Product Details')
+      expect(page).not_to have_link('Images')
+      expect(page).not_to have_link('Variants')
+      expect(page).not_to have_link('Product Properties')
+      expect(page).not_to have_link('Stock Management')
+
+      # no create permission
+      expect(page).not_to have_link('New Product')
+    end
+  end
+end

data/spec/features/admin/products/properties_spec.rb

@@ -0,0 +1,139 @@
+require 'spec_helper'
+
+describe "Properties", :type => :feature do
+  stub_authorization!
+
+  before(:each) do
+    visit spree.admin_path
+    click_link "Products"
+  end
+
+  context "Property index" do
+    before do
+      create(:property, :name => 'shirt size', :presentation => 'size')
+      create(:property, :name => 'shirt fit', :presentation => 'fit')
+      click_link "Properties"
+    end
+
+    context "listing product properties" do
+      it "should list the existing product properties" do
+        within_row(1) do
+          expect(column_text(1)).to eq("shirt size")
+          expect(column_text(2)).to eq("size")
+        end
+
+        within_row(2) do
+          expect(column_text(1)).to eq("shirt fit")
+          expect(column_text(2)).to eq("fit")
+        end
+      end
+    end
+
+    context "searching properties" do
+      it 'should list properties matching search query', :js => true do
+        fill_in "q_name_cont", :with => "size"
+        click_icon :search
+
+        expect(page).to have_content("shirt size")
+        expect(page).not_to have_content("shirt fit")
+      end
+    end
+  end
+
+  context "creating a property" do
+    it "should allow an admin to create a new product property", :js => true do
+      click_link "Properties"
+      click_link "new_property_link"
+      within('#new_property') { expect(page).to have_content("NEW PROPERTY") }
+
+      fill_in "property_name", :with => "color of band"
+      fill_in "property_presentation", :with => "color"
+      click_button "Create"
+      expect(page).to have_content("successfully created!")
+    end
+  end
+
+  context "editing a property" do
+    before(:each) do
+      create(:property)
+      click_link "Properties"
+      within_row(1) { click_icon :edit }
+    end
+
+    it "should allow an admin to edit an existing product property" do
+      fill_in "property_name", :with => "model 99"
+      click_button "Update"
+      expect(page).to have_content("successfully updated!")
+      expect(page).to have_content("model 99")
+    end
+
+    it "should show validation errors" do
+      fill_in "property_name", :with => ""
+      click_button "Update"
+      expect(page).to have_content("Name can't be blank")
+    end
+  end
+
+  context "linking a property to a product", :js => true do
+    before do
+      create(:product)
+      visit spree.admin_products_path
+      click_icon :edit
+      click_link "Product Properties"
+    end
+
+    # Regression test for #2279
+    it "successfully create and then remove product property" do
+      fill_in_property
+
+      check_property_row_count(2)
+
+      delete_product_property
+
+      check_property_row_count(1)
+    end
+
+    # Regression test for #4466
+    it "successfully remove and create a product property at the same time" do
+      fill_in_property
+
+      expect(page).to have_css('tr.product_property', count: 2)
+
+      within '#spree_new_product_property' do
+        find('[id$=_property_name]').set("New Property")
+        find('[id$=_value]').set("New Value")
+      end
+
+      delete_product_property
+
+      # Give fadeOut time to complete
+      expect(page).to have_css('tr.product_property', count: 1)
+
+      click_button "Update"
+
+      expect(page).not_to have_content("Product is not found")
+
+      check_property_row_count(2)
+    end
+
+    def fill_in_property
+      expect(page).to have_content('Editing Product')
+      fill_in "product_product_properties_attributes_0_property_name", :with => "A Property"
+      fill_in "product_product_properties_attributes_0_value", :with => "A Value"
+      click_button "Update"
+      click_link "Product Properties"
+    end
+
+    def delete_product_property
+      accept_alert do
+        click_icon :trash
+      end
+      expect(page).to have_content 'successfully removed'
+    end
+
+    def check_property_row_count(expected_row_count)
+      click_link "Product Properties"
+      expect(page).to have_css("tbody#product_properties tr", count: expected_row_count)
+    end
+  end
+end