solargraph 0.56.0 → 0.58.2

data/lib/solargraph/version.rb

@@ -1,5 +1,5 @@
-# frozen_string_literal: true
-
-module Solargraph
-  VERSION = '0.56.0'
-end
+# frozen_string_literal: true
+
+module Solargraph
+  VERSION = '0.58.2'
+end

data/lib/solargraph/workspace/config.rb

@@ -1,239 +1,255 @@
-# frozen_string_literal: true
-
-require 'yaml'
-
-module Solargraph
-  class Workspace
-    # Configuration data for a workspace.
-    #
-    class Config
-      # The maximum number of files that can be added to a workspace.
-      # The workspace's .solargraph.yml can override this value.
-      MAX_FILES = 5000
-
-      # @return [String]
-      attr_reader :directory
-
-      # @todo To make this strongly typed we'll need a record syntax
-      # @return [Hash{String => Array, Hash, Integer, nil}]
-      attr_reader :raw_data
-
-      # @param directory [String]
-      def initialize directory = ''
-        @directory = File.absolute_path(directory)
-        @raw_data = config_data
-        included
-        excluded
-      end
-
-      # An array of files included in the workspace (before calculating excluded files).
-      #
-      # @return [Array<String>]
-      def included
-        return [] if directory.empty? || directory == '*'
-        @included ||= process_globs(@raw_data['include'])
-      end
-
-      # An array of files excluded from the workspace.
-      #
-      # @return [Array<String>]
-      def excluded
-        return [] if directory.empty? || directory == '*'
-        @excluded ||= process_exclusions(@raw_data['exclude'])
-      end
-
-      # @param filename [String]
-      def allow? filename
-        filename = File.absolute_path(filename, directory)
-        filename.start_with?(directory) &&
-          !excluded.include?(filename) &&
-          excluded_directories.none? { |d| filename.start_with?(d) }
-      end
-
-      # The calculated array of (included - excluded) files in the workspace.
-      #
-      # @return [Array<String>]
-      def calculated
-        Solargraph.logger.info "Indexing workspace files in #{directory}" unless @calculated || directory.empty? || directory == '*'
-        @calculated ||= included - excluded
-      end
-
-      # An array of domains configured for the workspace.
-      # A domain is a namespace that the ApiMap should include in the global
-      # namespace. It's typically used to identify available DSLs.
-      #
-      # @return [Array<String>]
-      def domains
-        raw_data['domains']
-      end
-
-      # An array of required paths to add to the workspace.
-      #
-      # @return [Array<String>]
-      def required
-        raw_data['require']
-      end
-
-      # An array of load paths for required paths.
-      #
-      # @return [Array<String>]
-      def require_paths
-        raw_data['require_paths'] || []
-      end
-
-      # An array of reporters to use for diagnostics.
-      #
-      # @return [Array<String>]
-      def reporters
-        raw_data['reporters']
-      end
-
-      # A hash of options supported by the formatter
-      #
-      # @sg-ignore pending https://github.com/castwide/solargraph/pull/905
-      # @return [Hash]
-      def formatter
-        raw_data['formatter']
-      end
-
-      # An array of plugins to require.
-      #
-      # @return [Array<String>]
-      def plugins
-        raw_data['plugins']
-      end
-
-      # The maximum number of files to parse from the workspace.
-      #
-      # @sg-ignore pending https://github.com/castwide/solargraph/pull/905
-      # @return [Integer]
-      def max_files
-        raw_data['max_files']
-      end
-
-      private
-
-      # @return [String]
-      def global_config_path
-        ENV['SOLARGRAPH_GLOBAL_CONFIG'] ||
-          File.join(Dir.home, '.config', 'solargraph', 'config.yml')
-      end
-
-      # @return [String]
-      def workspace_config_path
-        return '' if @directory.empty?
-        File.join(@directory, '.solargraph.yml')
-      end
-
-      # @return [Hash{String => Array<undefined>, Hash{String => undefined}, Integer}]
-      def config_data
-        workspace_config = read_config(workspace_config_path)
-        global_config = read_config(global_config_path)
-
-        defaults = default_config
-        defaults.merge({'exclude' => []}) unless workspace_config.nil?
-
-        defaults
-          .merge(global_config || {})
-          .merge(workspace_config || {})
-      end
-
-      # Read a .solargraph yaml config
-      #
-      # @param config_path [String]
-      # @return [Hash{String => Array, Hash, Integer}, nil]
-      def read_config config_path = ''
-        return nil if config_path.empty?
-        return nil unless File.file?(config_path)
-        YAML.safe_load(File.read(config_path))
-      end
-
-      # @return [Hash{String => Array, Hash, Integer}]
-      def default_config
-        {
-          'include' => ['**/*.rb'],
-          'exclude' => ['spec/**/*', 'test/**/*', 'vendor/**/*', '.bundle/**/*'],
-          'require' => [],
-          'domains' => [],
-          'reporters' => %w[rubocop require_not_found],
-          'formatter' => {
-            'rubocop' => {
-              'cops' => 'safe',
-              'except' => [],
-              'only' => [],
-              'extra_args' =>[]
-            }
-          },
-          'require_paths' => [],
-          'plugins' => [],
-          'max_files' => MAX_FILES
-        }
-      end
-
-      # Get an array of files from the provided globs.
-      #
-      # @param globs [Array<String>]
-      # @return [Array<String>]
-      def process_globs globs
-        result = globs.flat_map do |glob|
-          Dir[File.absolute_path(glob, directory)]
-            .map{ |f| f.gsub(/\\/, '/') }
-            .select { |f| File.file?(f) }
-        end
-        result
-      end
-
-      # Modify the included files based on excluded directories and get an
-      # array of additional files to exclude.
-      #
-      # @param globs [Array<String>]
-      # @return [Array<String>]
-      def process_exclusions globs
-        remainder = globs.select do |glob|
-          if glob_is_directory?(glob)
-            exdir = File.absolute_path(glob_to_directory(glob), directory)
-            included.delete_if { |file| file.start_with?(exdir) }
-            false
-          else
-            true
-          end
-        end
-        process_globs remainder
-      end
-
-      # True if the glob translates to a whole directory.
-      #
-      # @example
-      #   glob_is_directory?('path/to/dir')       # => true
-      #   glob_is_directory?('path/to/dir/**/*)   # => true
-      #   glob_is_directory?('path/to/file.txt')  # => false
-      #   glob_is_directory?('path/to/*.txt')     # => false
-      #
-      # @param glob [String]
-      # @return [Boolean]
-      def glob_is_directory? glob
-        File.directory?(glob) || File.directory?(glob_to_directory(glob))
-      end
-
-      # Translate a glob to a base directory if applicable
-      #
-      # @example
-      #   glob_to_directory('path/to/dir/**/*') # => 'path/to/dir'
-      #
-      # @param glob [String]
-      # @return [String]
-      def glob_to_directory glob
-        glob.gsub(/(\/\*|\/\*\*\/\*\*?)$/, '')
-      end
-
-      # @return [Array<String>]
-      def excluded_directories
-        # @type [Array<String>]
-        excluded = @raw_data['exclude']
-        excluded
-          .select { |g| glob_is_directory?(g) }
-          .map { |g| File.absolute_path(glob_to_directory(g), directory) }
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+
+require 'yaml'
+
+module Solargraph
+  class Workspace
+    # Configuration data for a workspace.
+    #
+    class Config
+      # The maximum number of files that can be added to a workspace.
+      # The workspace's .solargraph.yml can override this value.
+      MAX_FILES = 5000
+
+      # @return [String]
+      attr_reader :directory
+
+      # @todo To make JSON strongly typed we'll need a record syntax
+      # @return [Hash{String => undefined, nil}]
+      attr_reader :raw_data
+
+      # @param directory [String]
+      def initialize directory = ''
+        @directory = File.absolute_path(directory)
+        @raw_data = config_data
+        included
+        excluded
+      end
+
+      # An array of files included in the workspace (before calculating excluded files).
+      #
+      # @return [Array<String>]
+      def included
+        return [] if directory.empty? || directory == '*'
+        @included ||= process_globs(@raw_data['include'])
+      end
+
+      # An array of files excluded from the workspace.
+      #
+      # @return [Array<String>]
+      def excluded
+        return [] if directory.empty? || directory == '*'
+        @excluded ||= process_exclusions(@raw_data['exclude'])
+      end
+
+      # @param filename [String]
+      def allow? filename
+        filename = File.absolute_path(filename, directory)
+        filename.start_with?(directory) &&
+          !excluded.include?(filename) &&
+          excluded_directories.none? { |d| filename.start_with?(d) }
+      end
+
+      # The calculated array of (included - excluded) files in the workspace.
+      #
+      # @return [Array<String>]
+      def calculated
+        Solargraph.logger.info "Indexing workspace files in #{directory}" unless @calculated || directory.empty? || directory == '*'
+        @calculated ||= included - excluded
+      end
+
+      # An array of domains configured for the workspace.
+      # A domain is a namespace that the ApiMap should include in the global
+      # namespace. It's typically used to identify available DSLs.
+      #
+      # @return [Array<String>]
+      # @sg-ignore Need to validate config
+      def domains
+        raw_data['domains']
+      end
+
+      # An array of required paths to add to the workspace.
+      #
+      # @return [Array<String>]
+      # @sg-ignore Need to validate config
+      def required
+        raw_data['require']
+      end
+
+      # An array of load paths for required paths.
+      #
+      # @return [Array<String>]
+      def require_paths
+        raw_data['require_paths'] || []
+      end
+
+      # An array of reporters to use for diagnostics.
+      #
+      # @sg-ignore Need to validate config
+      # @return [Array<String>]
+      def reporters
+        raw_data['reporters']
+      end
+
+      # A hash of options supported by the formatter
+      #
+      # @sg-ignore Need to validate config
+      # @return [Hash]
+      def formatter
+        raw_data['formatter']
+      end
+
+      # An array of plugins to require.
+      #
+      # @sg-ignore Need to validate config
+      # @return [Array<String>]
+      def plugins
+        raw_data['plugins']
+      end
+
+      # The maximum number of files to parse from the workspace.
+      #
+      # @sg-ignore Need to validate config
+      # @return [Integer]
+      def max_files
+        raw_data['max_files']
+      end
+
+      # @return [Hash{Symbol => Symbol}]
+      def type_checker_rules
+        # @type [Hash{String => String}]
+        raw_rules = raw_data.fetch('type_checker', {}).fetch('rules', {})
+        raw_rules.to_h do |k, v|
+          [k.to_sym, v.to_sym]
+        end
+      end
+
+      private
+
+      # @return [String]
+      def global_config_path
+        ENV['SOLARGRAPH_GLOBAL_CONFIG'] ||
+          File.join(Dir.home, '.config', 'solargraph', 'config.yml')
+      end
+
+      # @return [String]
+      def workspace_config_path
+        return '' if @directory.empty?
+        File.join(@directory, '.solargraph.yml')
+      end
+
+      # @return [Hash{String => undefined}]
+      def config_data
+        workspace_config = read_config(workspace_config_path)
+        global_config = read_config(global_config_path)
+
+        defaults = default_config
+        defaults.merge({'exclude' => []}) unless workspace_config.nil?
+
+        defaults
+          .merge(global_config || {})
+          .merge(workspace_config || {})
+      end
+
+      # Read a .solargraph yaml config
+      #
+      # @param config_path [String]
+      # @return [Hash{String => Array, Hash, Integer}, nil]
+      def read_config config_path = ''
+        return nil if config_path.empty?
+        return nil unless File.file?(config_path)
+        YAML.safe_load(File.read(config_path))
+      end
+
+      # @return [Hash{String => Array, Hash, Integer}]
+      def default_config
+        {
+          'include' => ['Rakefile', 'Gemfile', '*.gemspec', '**/*.rb'],
+          'exclude' => ['spec/**/*', 'test/**/*', 'vendor/**/*', '.bundle/**/*'],
+          'require' => [],
+          'domains' => [],
+          'reporters' => %w[rubocop require_not_found],
+          'formatter' => {
+            'rubocop' => {
+              'cops' => 'safe',
+              'except' => [],
+              'only' => [],
+              'extra_args' =>[]
+            }
+          },
+          'type_checker' => {
+            'rules' => { }
+          },
+          'require_paths' => [],
+          'plugins' => [],
+          'max_files' => MAX_FILES
+        }
+      end
+
+      # Get an array of files from the provided globs.
+      #
+      # @param globs [Array<String>]
+      # @return [Array<String>]
+      def process_globs globs
+        result = globs.flat_map do |glob|
+          Dir[File.absolute_path(glob, directory)]
+            .map{ |f| f.gsub(/\\/, '/') }
+            .select { |f| File.file?(f) }
+        end
+        result
+      end
+
+      # Modify the included files based on excluded directories and get an
+      # array of additional files to exclude.
+      #
+      # @param globs [Array<String>]
+      # @return [Array<String>]
+      def process_exclusions globs
+        remainder = globs.select do |glob|
+          if glob_is_directory?(glob)
+            exdir = File.absolute_path(glob_to_directory(glob), directory)
+            included.delete_if { |file| file.start_with?(exdir) }
+            false
+          else
+            true
+          end
+        end
+        process_globs remainder
+      end
+
+      # True if the glob translates to a whole directory.
+      #
+      # @example
+      #   glob_is_directory?('path/to/dir')       # => true
+      #   glob_is_directory?('path/to/dir/**/*)   # => true
+      #   glob_is_directory?('path/to/file.txt')  # => false
+      #   glob_is_directory?('path/to/*.txt')     # => false
+      #
+      # @param glob [String]
+      # @return [Boolean]
+      def glob_is_directory? glob
+        File.directory?(glob) || File.directory?(glob_to_directory(glob))
+      end
+
+      # Translate a glob to a base directory if applicable
+      #
+      # @example
+      #   glob_to_directory('path/to/dir/**/*') # => 'path/to/dir'
+      #
+      # @param glob [String]
+      # @return [String]
+      def glob_to_directory glob
+        glob.gsub(/(\/\*|\/\*\*\/\*\*?)$/, '')
+      end
+
+      # @return [Array<String>]
+      def excluded_directories
+        # @type [Array<String>]
+        excluded = @raw_data['exclude']
+        excluded
+          .select { |g| glob_is_directory?(g) }
+          .map { |g| File.absolute_path(glob_to_directory(g), directory) }
+      end
+    end
+  end
+end

data/lib/solargraph/workspace/require_paths.rb

@@ -0,0 +1,97 @@
+# frozen_string_literal: true
+
+require 'open3'
+
+module Solargraph
+  # A workspace consists of the files in a project's directory and the
+  # project's configuration. It provides a Source for each file to be used
+  # in an associated Library or ApiMap.
+  #
+  class Workspace
+    # Manages determining which gemspecs are available in a workspace
+    class RequirePaths
+      attr_reader :directory, :config
+
+      # @param directory [String, nil]
+      # @param config [Config, nil]
+      def initialize directory, config
+        @directory = directory
+        @config = config
+      end
+
+      # Generate require paths from gemspecs if they exist or assume the default
+      # lib directory.
+      #
+      # @return [Array<String>]
+      def generate
+        result = require_paths_from_gemspec_files
+        return configured_require_paths if result.empty?
+        result.concat(config.require_paths.map { |p| File.join(directory, p) }) if config
+        result
+      end
+
+      private
+
+      # @return [Array<String>]
+      def require_paths_from_gemspec_files
+        results = []
+        gemspec_file_paths.each do |gemspec_file_path|
+          results.concat require_path_from_gemspec_file(gemspec_file_path)
+        end
+        results
+      end
+
+      # Get an array of all gemspec files in the workspace.
+      #
+      # @return [Array<String>]
+      def gemspec_file_paths
+        return [] if directory.nil?
+        @gemspec_file_paths ||= Dir[File.join(directory, '**/*.gemspec')].select do |gs|
+          config.nil? || config.allow?(gs)
+        end
+      end
+
+      # Get additional require paths defined in the configuration.
+      #
+      # @return [Array<String>]
+      def configured_require_paths
+        return ['lib'] unless directory
+        return [File.join(directory, 'lib')] if !config || config.require_paths.empty?
+        config.require_paths.map { |p| File.join(directory, p) }
+      end
+
+      # Generate require paths from gemspecs if they exist or assume the default
+      # lib directory.
+      #
+      # @param gemspec_file_path [String]
+      # @return [Array<String>]
+      def require_path_from_gemspec_file gemspec_file_path
+        base = File.dirname(gemspec_file_path)
+        # HACK: Evaluating gemspec files violates the goal of not running
+        #   workspace code, but this is how Gem::Specification.load does it
+        #   anyway.
+        cmd = ['ruby', '-e',
+               "require 'rubygems'; " \
+               "require 'json'; " \
+               "spec = eval(File.read('#{gemspec_file_path}'), TOPLEVEL_BINDING, '#{gemspec_file_path}'); " \
+               'return unless Gem::Specification === spec; ' \
+               'puts({name: spec.name, paths: spec.require_paths}.to_json)']
+        o, e, s = Open3.capture3(*cmd)
+        if s.success?
+          begin
+            hash = o && !o.empty? ? JSON.parse(o.split("\n").last) : {}
+            return [] if hash.empty?
+            hash['paths'].map { |path| File.join(base, path) }
+          rescue StandardError => e
+            Solargraph.logger.warn "Error reading #{gemspec_file_path}: [#{e.class}] #{e.message}"
+            []
+          end
+        else
+          Solargraph.logger.warn "Error reading #{gemspec_file_path}"
+          Solargraph.logger.warn e
+          []
+        end
+      end
+    end
+  end
+end