solargraph 0.56.0 → 0.58.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (191) hide show
  1. checksums.yaml +4 -4
  2. data/.gitattributes +2 -0
  3. data/.github/workflows/linting.yml +127 -0
  4. data/.github/workflows/plugins.yml +183 -7
  5. data/.github/workflows/rspec.yml +55 -5
  6. data/.github/workflows/typecheck.yml +6 -3
  7. data/.gitignore +6 -0
  8. data/.overcommit.yml +72 -0
  9. data/.rspec +1 -0
  10. data/.rubocop.yml +66 -0
  11. data/.rubocop_todo.yml +1279 -0
  12. data/.yardopts +1 -0
  13. data/CHANGELOG.md +92 -1
  14. data/README.md +8 -4
  15. data/Rakefile +125 -13
  16. data/bin/solargraph +3 -0
  17. data/lib/solargraph/api_map/cache.rb +110 -109
  18. data/lib/solargraph/api_map/constants.rb +279 -0
  19. data/lib/solargraph/api_map/index.rb +193 -175
  20. data/lib/solargraph/api_map/source_to_yard.rb +97 -88
  21. data/lib/solargraph/api_map/store.rb +384 -266
  22. data/lib/solargraph/api_map.rb +945 -973
  23. data/lib/solargraph/bench.rb +1 -0
  24. data/lib/solargraph/complex_type/type_methods.rb +228 -222
  25. data/lib/solargraph/complex_type/unique_type.rb +482 -475
  26. data/lib/solargraph/complex_type.rb +444 -423
  27. data/lib/solargraph/convention/active_support_concern.rb +111 -0
  28. data/lib/solargraph/convention/base.rb +17 -0
  29. data/lib/solargraph/convention/data_definition/data_assignment_node.rb +61 -0
  30. data/lib/solargraph/convention/data_definition/data_definition_node.rb +91 -0
  31. data/lib/solargraph/convention/data_definition.rb +105 -0
  32. data/lib/solargraph/convention/gemspec.rb +3 -2
  33. data/lib/solargraph/convention/struct_definition/struct_assignment_node.rb +61 -60
  34. data/lib/solargraph/convention/struct_definition/struct_definition_node.rb +102 -100
  35. data/lib/solargraph/convention/struct_definition.rb +164 -101
  36. data/lib/solargraph/convention.rb +32 -2
  37. data/lib/solargraph/diagnostics/require_not_found.rb +53 -53
  38. data/lib/solargraph/diagnostics/rubocop.rb +118 -113
  39. data/lib/solargraph/diagnostics/rubocop_helpers.rb +68 -66
  40. data/lib/solargraph/diagnostics/type_check.rb +55 -55
  41. data/lib/solargraph/doc_map.rb +439 -405
  42. data/lib/solargraph/environ.rb +9 -2
  43. data/lib/solargraph/equality.rb +34 -33
  44. data/lib/solargraph/gem_pins.rb +98 -88
  45. data/lib/solargraph/language_server/host/diagnoser.rb +89 -89
  46. data/lib/solargraph/language_server/host/dispatch.rb +130 -128
  47. data/lib/solargraph/language_server/host/message_worker.rb +112 -109
  48. data/lib/solargraph/language_server/host/sources.rb +99 -99
  49. data/lib/solargraph/language_server/host.rb +878 -871
  50. data/lib/solargraph/language_server/message/base.rb +2 -1
  51. data/lib/solargraph/language_server/message/extended/check_gem_version.rb +114 -114
  52. data/lib/solargraph/language_server/message/extended/document.rb +23 -23
  53. data/lib/solargraph/language_server/message/text_document/completion.rb +56 -56
  54. data/lib/solargraph/language_server/message/text_document/definition.rb +40 -38
  55. data/lib/solargraph/language_server/message/text_document/document_symbol.rb +26 -26
  56. data/lib/solargraph/language_server/message/text_document/formatting.rb +148 -131
  57. data/lib/solargraph/language_server/message/text_document/hover.rb +58 -58
  58. data/lib/solargraph/language_server/message/text_document/signature_help.rb +24 -24
  59. data/lib/solargraph/language_server/message/text_document/type_definition.rb +25 -24
  60. data/lib/solargraph/language_server/message/workspace/did_change_workspace_folders.rb +2 -0
  61. data/lib/solargraph/language_server/message/workspace/workspace_symbol.rb +23 -23
  62. data/lib/solargraph/language_server/progress.rb +8 -0
  63. data/lib/solargraph/language_server/request.rb +4 -1
  64. data/lib/solargraph/library.rb +683 -666
  65. data/lib/solargraph/location.rb +82 -79
  66. data/lib/solargraph/logging.rb +37 -28
  67. data/lib/solargraph/page.rb +3 -0
  68. data/lib/solargraph/parser/comment_ripper.rb +69 -62
  69. data/lib/solargraph/parser/flow_sensitive_typing.rb +255 -227
  70. data/lib/solargraph/parser/node_processor/base.rb +92 -87
  71. data/lib/solargraph/parser/node_processor.rb +62 -46
  72. data/lib/solargraph/parser/parser_gem/class_methods.rb +149 -159
  73. data/lib/solargraph/parser/parser_gem/flawed_builder.rb +1 -0
  74. data/lib/solargraph/parser/parser_gem/node_chainer.rb +166 -164
  75. data/lib/solargraph/parser/parser_gem/node_methods.rb +486 -497
  76. data/lib/solargraph/parser/parser_gem/node_processors/and_node.rb +22 -21
  77. data/lib/solargraph/parser/parser_gem/node_processors/args_node.rb +59 -59
  78. data/lib/solargraph/parser/parser_gem/node_processors/begin_node.rb +15 -15
  79. data/lib/solargraph/parser/parser_gem/node_processors/block_node.rb +46 -45
  80. data/lib/solargraph/parser/parser_gem/node_processors/casgn_node.rb +1 -21
  81. data/lib/solargraph/parser/parser_gem/node_processors/def_node.rb +53 -53
  82. data/lib/solargraph/parser/parser_gem/node_processors/if_node.rb +23 -21
  83. data/lib/solargraph/parser/parser_gem/node_processors/ivasgn_node.rb +40 -40
  84. data/lib/solargraph/parser/parser_gem/node_processors/lvasgn_node.rb +29 -29
  85. data/lib/solargraph/parser/parser_gem/node_processors/masgn_node.rb +59 -53
  86. data/lib/solargraph/parser/parser_gem/node_processors/namespace_node.rb +0 -22
  87. data/lib/solargraph/parser/parser_gem/node_processors/opasgn_node.rb +98 -41
  88. data/lib/solargraph/parser/parser_gem/node_processors/orasgn_node.rb +17 -16
  89. data/lib/solargraph/parser/parser_gem/node_processors/resbody_node.rb +38 -37
  90. data/lib/solargraph/parser/parser_gem/node_processors/sclass_node.rb +52 -43
  91. data/lib/solargraph/parser/parser_gem/node_processors/send_node.rb +291 -271
  92. data/lib/solargraph/parser/parser_gem/node_processors/sym_node.rb +1 -0
  93. data/lib/solargraph/parser/parser_gem/node_processors/while_node.rb +29 -29
  94. data/lib/solargraph/parser/parser_gem/node_processors.rb +70 -66
  95. data/lib/solargraph/parser/region.rb +69 -66
  96. data/lib/solargraph/parser/snippet.rb +17 -15
  97. data/lib/solargraph/pin/base.rb +729 -651
  98. data/lib/solargraph/pin/base_variable.rb +126 -125
  99. data/lib/solargraph/pin/block.rb +104 -103
  100. data/lib/solargraph/pin/breakable.rb +9 -9
  101. data/lib/solargraph/pin/callable.rb +231 -218
  102. data/lib/solargraph/pin/closure.rb +72 -74
  103. data/lib/solargraph/pin/common.rb +79 -75
  104. data/lib/solargraph/pin/constant.rb +2 -0
  105. data/lib/solargraph/pin/conversions.rb +123 -123
  106. data/lib/solargraph/pin/delegated_method.rb +120 -120
  107. data/lib/solargraph/pin/documenting.rb +114 -114
  108. data/lib/solargraph/pin/instance_variable.rb +34 -34
  109. data/lib/solargraph/pin/keyword.rb +20 -20
  110. data/lib/solargraph/pin/local_variable.rb +75 -76
  111. data/lib/solargraph/pin/method.rb +672 -651
  112. data/lib/solargraph/pin/method_alias.rb +34 -31
  113. data/lib/solargraph/pin/namespace.rb +115 -115
  114. data/lib/solargraph/pin/parameter.rb +275 -261
  115. data/lib/solargraph/pin/proxy_type.rb +39 -35
  116. data/lib/solargraph/pin/reference/override.rb +47 -33
  117. data/lib/solargraph/pin/reference/superclass.rb +15 -10
  118. data/lib/solargraph/pin/reference.rb +39 -22
  119. data/lib/solargraph/pin/search.rb +61 -56
  120. data/lib/solargraph/pin/signature.rb +61 -59
  121. data/lib/solargraph/pin/symbol.rb +53 -48
  122. data/lib/solargraph/pin/until.rb +18 -18
  123. data/lib/solargraph/pin/while.rb +18 -18
  124. data/lib/solargraph/pin.rb +44 -44
  125. data/lib/solargraph/pin_cache.rb +245 -185
  126. data/lib/solargraph/position.rb +132 -116
  127. data/lib/solargraph/range.rb +112 -107
  128. data/lib/solargraph/rbs_map/conversions.rb +823 -773
  129. data/lib/solargraph/rbs_map/core_fills.rb +18 -0
  130. data/lib/solargraph/rbs_map/core_map.rb +58 -51
  131. data/lib/solargraph/rbs_map/stdlib_map.rb +43 -43
  132. data/lib/solargraph/rbs_map.rb +163 -150
  133. data/lib/solargraph/shell.rb +352 -268
  134. data/lib/solargraph/source/chain/call.rb +337 -333
  135. data/lib/solargraph/source/chain/constant.rb +26 -89
  136. data/lib/solargraph/source/chain/hash.rb +34 -34
  137. data/lib/solargraph/source/chain/if.rb +28 -28
  138. data/lib/solargraph/source/chain/instance_variable.rb +13 -13
  139. data/lib/solargraph/source/chain/link.rb +11 -2
  140. data/lib/solargraph/source/chain/literal.rb +48 -48
  141. data/lib/solargraph/source/chain/or.rb +23 -23
  142. data/lib/solargraph/source/chain.rb +291 -282
  143. data/lib/solargraph/source/change.rb +82 -82
  144. data/lib/solargraph/source/cursor.rb +166 -167
  145. data/lib/solargraph/source/encoding_fixes.rb +23 -23
  146. data/lib/solargraph/source/source_chainer.rb +194 -194
  147. data/lib/solargraph/source/updater.rb +55 -55
  148. data/lib/solargraph/source.rb +498 -495
  149. data/lib/solargraph/source_map/clip.rb +226 -234
  150. data/lib/solargraph/source_map/data.rb +34 -30
  151. data/lib/solargraph/source_map/mapper.rb +259 -259
  152. data/lib/solargraph/source_map.rb +212 -200
  153. data/lib/solargraph/type_checker/checks.rb +124 -124
  154. data/lib/solargraph/type_checker/param_def.rb +37 -35
  155. data/lib/solargraph/type_checker/problem.rb +32 -32
  156. data/lib/solargraph/type_checker/rules.rb +84 -62
  157. data/lib/solargraph/type_checker.rb +814 -699
  158. data/lib/solargraph/version.rb +5 -5
  159. data/lib/solargraph/workspace/config.rb +255 -239
  160. data/lib/solargraph/workspace/require_paths.rb +97 -0
  161. data/lib/solargraph/workspace.rb +220 -249
  162. data/lib/solargraph/yard_map/helpers.rb +44 -16
  163. data/lib/solargraph/yard_map/mapper/to_constant.rb +5 -5
  164. data/lib/solargraph/yard_map/mapper/to_method.rb +130 -134
  165. data/lib/solargraph/yard_map/mapper/to_namespace.rb +31 -30
  166. data/lib/solargraph/yard_map/mapper.rb +79 -79
  167. data/lib/solargraph/yard_map/to_method.rb +89 -88
  168. data/lib/solargraph/yardoc.rb +87 -49
  169. data/lib/solargraph.rb +105 -90
  170. data/rbs/fills/bundler/0/bundler.rbs +4271 -0
  171. data/rbs/fills/open3/0/open3.rbs +172 -0
  172. data/rbs/fills/rubygems/0/basic_specification.rbs +326 -0
  173. data/rbs/fills/rubygems/0/errors.rbs +364 -0
  174. data/rbs/fills/rubygems/0/spec_fetcher.rbs +107 -0
  175. data/rbs/fills/rubygems/0/specification.rbs +1753 -0
  176. data/rbs/fills/{tuple.rbs → tuple/tuple.rbs} +2 -3
  177. data/rbs/shims/ast/0/node.rbs +5 -0
  178. data/rbs/shims/ast/2.4/.rbs_meta.yaml +9 -0
  179. data/rbs/shims/ast/2.4/ast.rbs +73 -0
  180. data/rbs/shims/parser/3.2.0.1/builders/default.rbs +195 -0
  181. data/rbs/shims/parser/3.2.0.1/manifest.yaml +7 -0
  182. data/rbs/shims/parser/3.2.0.1/parser.rbs +201 -0
  183. data/rbs/shims/parser/3.2.0.1/polyfill.rbs +4 -0
  184. data/rbs/shims/thor/1.2.0.1/.rbs_meta.yaml +9 -0
  185. data/rbs/shims/thor/1.2.0.1/manifest.yaml +7 -0
  186. data/rbs/shims/thor/1.2.0.1/thor.rbs +17 -0
  187. data/rbs_collection.yaml +4 -4
  188. data/solargraph.gemspec +26 -5
  189. metadata +187 -15
  190. data/lib/.rubocop.yml +0 -22
  191. data/lib/solargraph/parser/node_methods.rb +0 -97
@@ -1,699 +1,814 @@
1
- # frozen_string_literal: true
2
-
3
- module Solargraph
4
- # A static analysis tool for validating data types.
5
- #
6
- class TypeChecker
7
- autoload :Problem, 'solargraph/type_checker/problem'
8
- autoload :ParamDef, 'solargraph/type_checker/param_def'
9
- autoload :Rules, 'solargraph/type_checker/rules'
10
- autoload :Checks, 'solargraph/type_checker/checks'
11
-
12
- include Checks
13
- include Parser::NodeMethods
14
-
15
- # @return [String]
16
- attr_reader :filename
17
-
18
- # @return [Rules]
19
- attr_reader :rules
20
-
21
- # @return [ApiMap]
22
- attr_reader :api_map
23
-
24
- # @param filename [String]
25
- # @param api_map [ApiMap, nil]
26
- # @param level [Symbol]
27
- def initialize filename, api_map: nil, level: :normal
28
- @filename = filename
29
- # @todo Smarter directory resolution
30
- @api_map = api_map || Solargraph::ApiMap.load(File.dirname(filename))
31
- @rules = Rules.new(level)
32
- # @type [Array<Range>]
33
- @marked_ranges = []
34
- end
35
-
36
- # @return [SourceMap]
37
- def source_map
38
- @source_map ||= api_map.source_map(filename)
39
- end
40
-
41
- # @return [Array<Problem>]
42
- def problems
43
- @problems ||= begin
44
- without_ignored(
45
- method_tag_problems
46
- .concat variable_type_tag_problems
47
- .concat const_problems
48
- .concat call_problems
49
- )
50
- end
51
- end
52
-
53
- class << self
54
- # @param filename [String]
55
- # @param level [Symbol]
56
- # @return [self]
57
- def load filename, level = :normal
58
- source = Solargraph::Source.load(filename)
59
- api_map = Solargraph::ApiMap.new
60
- api_map.map(source)
61
- new(filename, api_map: api_map, level: level)
62
- end
63
-
64
- # @param code [String]
65
- # @param filename [String, nil]
66
- # @param level [Symbol]
67
- # @return [self]
68
- def load_string code, filename = nil, level = :normal
69
- source = Solargraph::Source.load_string(code, filename)
70
- api_map = Solargraph::ApiMap.new
71
- api_map.map(source)
72
- new(filename, api_map: api_map, level: level)
73
- end
74
- end
75
-
76
- private
77
-
78
- # @return [Array<Problem>]
79
- def method_tag_problems
80
- result = []
81
- # @param pin [Pin::Method]
82
- source_map.pins_by_class(Pin::Method).each do |pin|
83
- result.concat method_return_type_problems_for(pin)
84
- result.concat method_param_type_problems_for(pin)
85
- end
86
- result
87
- end
88
-
89
- # @param pin [Pin::Method]
90
- # @return [Array<Problem>]
91
- def method_return_type_problems_for pin
92
- return [] if pin.is_a?(Pin::MethodAlias)
93
- result = []
94
- declared = pin.typify(api_map).self_to_type(pin.full_context).qualify(api_map, pin.full_context.tag)
95
- if declared.undefined?
96
- if pin.return_type.undefined? && rules.require_type_tags?
97
- if pin.attribute?
98
- inferred = pin.probe(api_map).self_to_type(pin.full_context)
99
- result.push Problem.new(pin.location, "Missing @return tag for #{pin.path}", pin: pin) unless inferred.defined?
100
- else
101
- result.push Problem.new(pin.location, "Missing @return tag for #{pin.path}", pin: pin)
102
- end
103
- elsif pin.return_type.defined? && !resolved_constant?(pin)
104
- result.push Problem.new(pin.location, "Unresolved return type #{pin.return_type} for #{pin.path}", pin: pin)
105
- elsif rules.must_tag_or_infer? && pin.probe(api_map).undefined?
106
- result.push Problem.new(pin.location, "Untyped method #{pin.path} could not be inferred")
107
- end
108
- elsif rules.validate_tags?
109
- unless pin.node.nil? || declared.void? || virtual_pin?(pin) || abstract?(pin)
110
- inferred = pin.probe(api_map).self_to_type(pin.full_context)
111
- if inferred.undefined?
112
- unless rules.ignore_all_undefined? || external?(pin)
113
- result.push Problem.new(pin.location, "#{pin.path} return type could not be inferred", pin: pin)
114
- end
115
- else
116
- unless (rules.require_all_return_types_match_inferred? ? all_types_match?(api_map, inferred, declared) : any_types_match?(api_map, declared, inferred))
117
- result.push Problem.new(pin.location, "Declared return type #{declared.rooted_tags} does not match inferred type #{inferred.rooted_tags} for #{pin.path}", pin: pin)
118
- end
119
- end
120
- end
121
- end
122
- result
123
- end
124
-
125
- # @todo This is not optimal. A better solution would probably be to mix
126
- # namespace alias into types at the ApiMap level.
127
- #
128
- # @param pin [Pin::Base]
129
- # @return [Boolean]
130
- def resolved_constant? pin
131
- return true if pin.typify(api_map).defined?
132
- constant_pins = api_map.get_constants('', *pin.closure.gates)
133
- .select { |p| p.name == pin.return_type.namespace }
134
- return true if constant_pins.find { |p| p.typify(api_map).defined? }
135
- # will need to probe when a constant name is assigned to a
136
- # class/module (alias)
137
- return true if constant_pins.find { |p| p.probe(api_map).defined? }
138
- false
139
- end
140
-
141
- # @param pin [Pin::Base]
142
- def virtual_pin? pin
143
- pin.location && source_map.source.comment_at?(pin.location.range.ending)
144
- end
145
-
146
- # @param pin [Pin::Method]
147
- # @return [Array<Problem>]
148
- def method_param_type_problems_for pin
149
- stack = api_map.get_method_stack(pin.namespace, pin.name, scope: pin.scope)
150
- params = first_param_hash(stack)
151
- result = []
152
- if rules.require_type_tags?
153
- pin.signatures.each do |sig|
154
- sig.parameters.each do |par|
155
- break if par.decl == :restarg || par.decl == :kwrestarg || par.decl == :blockarg
156
- unless params[par.name]
157
- if pin.attribute?
158
- inferred = pin.probe(api_map).self_to_type(pin.full_context)
159
- if inferred.undefined?
160
- result.push Problem.new(pin.location, "Missing @param tag for #{par.name} on #{pin.path}", pin: pin)
161
- end
162
- else
163
- result.push Problem.new(pin.location, "Missing @param tag for #{par.name} on #{pin.path}", pin: pin)
164
- end
165
- end
166
- end
167
- end
168
- end
169
- # @todo Should be able to probe type of name and data here
170
- # @param name [String]
171
- # @param data [Hash{Symbol => BasicObject}]
172
- params.each_pair do |name, data|
173
- # @type [ComplexType]
174
- type = data[:qualified]
175
- if type.undefined?
176
- result.push Problem.new(pin.location, "Unresolved type #{data[:tagged]} for #{name} param on #{pin.path}", pin: pin)
177
- end
178
- end
179
- result
180
- end
181
-
182
- # @return [Array<Pin::Base>]
183
- def ignored_pins
184
- @ignored_pins ||= []
185
- end
186
-
187
- # @return [Array<Problem>]
188
- def variable_type_tag_problems
189
- result = []
190
- all_variables.each do |pin|
191
- if pin.return_type.defined?
192
- declared = pin.typify(api_map)
193
- next if declared.duck_type?
194
- if declared.defined?
195
- if rules.validate_tags?
196
- inferred = pin.probe(api_map)
197
- if inferred.undefined?
198
- next if rules.ignore_all_undefined?
199
- if declared_externally?(pin)
200
- ignored_pins.push pin
201
- else
202
- result.push Problem.new(pin.location, "Variable type could not be inferred for #{pin.name}", pin: pin)
203
- end
204
- else
205
- unless any_types_match?(api_map, declared, inferred)
206
- result.push Problem.new(pin.location, "Declared type #{declared} does not match inferred type #{inferred} for variable #{pin.name}", pin: pin)
207
- end
208
- end
209
- elsif declared_externally?(pin)
210
- ignored_pins.push pin
211
- end
212
- elsif !pin.is_a?(Pin::Parameter) && !resolved_constant?(pin)
213
- result.push Problem.new(pin.location, "Unresolved type #{pin.return_type} for variable #{pin.name}", pin: pin)
214
- end
215
- else
216
- inferred = pin.probe(api_map)
217
- if inferred.undefined? && declared_externally?(pin)
218
- ignored_pins.push pin
219
- end
220
- end
221
- end
222
- result
223
- end
224
-
225
- # @return [Array<Pin::BaseVariable>]
226
- def all_variables
227
- source_map.pins_by_class(Pin::BaseVariable) + source_map.locals.select { |pin| pin.is_a?(Pin::LocalVariable) }
228
- end
229
-
230
- # @return [Array<Problem>]
231
- def const_problems
232
- return [] unless rules.validate_consts?
233
- result = []
234
- Solargraph::Parser::NodeMethods.const_nodes_from(source_map.source.node).each do |const|
235
- rng = Solargraph::Range.from_node(const)
236
- chain = Solargraph::Parser.chain(const, filename)
237
- block_pin = source_map.locate_block_pin(rng.start.line, rng.start.column)
238
- location = Location.new(filename, rng)
239
- locals = source_map.locals_at(location)
240
- pins = chain.define(api_map, block_pin, locals)
241
- if pins.empty?
242
- result.push Problem.new(location, "Unresolved constant #{Solargraph::Parser::NodeMethods.unpack_name(const)}")
243
- @marked_ranges.push location.range
244
- end
245
- end
246
- result
247
- end
248
-
249
- # @return [Array<Problem>]
250
- def call_problems
251
- result = []
252
- Solargraph::Parser::NodeMethods.call_nodes_from(source_map.source.node).each do |call|
253
- rng = Solargraph::Range.from_node(call)
254
- next if @marked_ranges.any? { |d| d.contain?(rng.start) }
255
- chain = Solargraph::Parser.chain(call, filename)
256
- block_pin = source_map.locate_block_pin(rng.start.line, rng.start.column)
257
- location = Location.new(filename, rng)
258
- locals = source_map.locals_at(location)
259
- type = chain.infer(api_map, block_pin, locals)
260
- if type.undefined? && !rules.ignore_all_undefined?
261
- base = chain
262
- missing = chain
263
- found = nil
264
- closest = ComplexType::UNDEFINED
265
- until base.links.first.undefined?
266
- found = base.define(api_map, block_pin, locals).first
267
- break if found
268
- missing = base
269
- base = base.base
270
- end
271
- closest = found.typify(api_map) if found
272
- # @todo remove the internal_or_core? check at a higher-than-strict level
273
- if !found || found.is_a?(Pin::BaseVariable) || (closest.defined? && internal_or_core?(found))
274
- unless closest.generic? || ignored_pins.include?(found)
275
- result.push Problem.new(location, "Unresolved call to #{missing.links.last.word}")
276
- @marked_ranges.push rng
277
- end
278
- end
279
- end
280
- result.concat argument_problems_for(chain, api_map, block_pin, locals, location)
281
- end
282
- result
283
- end
284
-
285
- # @param chain [Solargraph::Source::Chain]
286
- # @param api_map [Solargraph::ApiMap]
287
- # @param block_pin [Solargraph::Pin::Base]
288
- # @param locals [Array<Solargraph::Pin::Base>]
289
- # @param location [Solargraph::Location]
290
- # @return [Array<Problem>]
291
- def argument_problems_for chain, api_map, block_pin, locals, location
292
- result = []
293
- base = chain
294
- until base.links.length == 1 && base.undefined?
295
- last_base_link = base.links.last
296
- break unless last_base_link.is_a?(Solargraph::Source::Chain::Call)
297
-
298
- arguments = last_base_link.arguments
299
-
300
- pins = base.define(api_map, block_pin, locals)
301
-
302
- first_pin = pins.first
303
- if first_pin.is_a?(Pin::DelegatedMethod) && !first_pin.resolvable?(api_map)
304
- # Do nothing, as we can't find the actual method implementation
305
- elsif first_pin.is_a?(Pin::Method)
306
- # @type [Pin::Method]
307
- pin = first_pin
308
- ap = if base.links.last.is_a?(Solargraph::Source::Chain::ZSuper)
309
- arity_problems_for(pin, fake_args_for(block_pin), location)
310
- elsif pin.path == 'Class#new'
311
- fqns = if base.links.one?
312
- block_pin.namespace
313
- else
314
- base.base.infer(api_map, block_pin, locals).namespace
315
- end
316
- init = api_map.get_method_stack(fqns, 'initialize').first
317
- init ? arity_problems_for(init, arguments, location) : []
318
- else
319
- arity_problems_for(pin, arguments, location)
320
- end
321
- unless ap.empty?
322
- result.concat ap
323
- break
324
- end
325
- break if !rules.validate_calls? || base.links.first.is_a?(Solargraph::Source::Chain::ZSuper)
326
-
327
- params = first_param_hash(pins)
328
-
329
- all_errors = []
330
- pin.signatures.sort { |sig| sig.parameters.length }.each do |sig|
331
- errors = []
332
- sig.parameters.each_with_index do |par, idx|
333
- # @todo add logic mapping up restarg parameters with
334
- # arguments (including restarg arguments). Use tuples
335
- # when possible, and when not, ensure provably
336
- # incorrect situations are detected.
337
- break if par.decl == :restarg # bail out pending better arg processing
338
- argchain = arguments[idx]
339
- if argchain.nil?
340
- if par.decl == :arg
341
- final_arg = arguments.last
342
- if final_arg && final_arg.node.type == :splat
343
- argchain = final_arg
344
- next # don't try to apply the type of the splat - unlikely to be specific enough
345
- else
346
- errors.push Problem.new(location, "Not enough arguments to #{pin.path}")
347
- next
348
- end
349
- else
350
- final_arg = arguments.last
351
- argchain = final_arg if final_arg && [:kwsplat, :hash].include?(final_arg.node.type)
352
- end
353
- end
354
- if argchain
355
- if par.decl != :arg
356
- errors.concat kwarg_problems_for sig, argchain, api_map, block_pin, locals, location, pin, params, idx
357
- next
358
- else
359
- if argchain.node.type == :splat && argchain == arguments.last
360
- final_arg = argchain
361
- end
362
- if (final_arg && final_arg.node.type == :splat)
363
- # The final argument given has been seen and was a
364
- # splat, which doesn't give us useful types or
365
- # arities against positional parameters, so let's
366
- # continue on in case there are any required
367
- # kwargs we should warn about
368
- next
369
- end
370
-
371
- if argchain.node.type == :splat && par != sig.parameters.last
372
- # we have been given a splat and there are more
373
- # arguments to come.
374
-
375
- # @todo Improve this so that we can skip past the
376
- # rest of the positional parameters here but still
377
- # process the kwargs
378
- break
379
- end
380
- ptype = params.key?(par.name) ? params[par.name][:qualified] : ComplexType::UNDEFINED
381
- ptype = ptype.self_to_type(par.context)
382
- if ptype.nil?
383
- # @todo Some level (strong, I guess) should require the param here
384
- else
385
- argtype = argchain.infer(api_map, block_pin, locals)
386
- if argtype.defined? && ptype.defined? && !any_types_match?(api_map, ptype, argtype)
387
- errors.push Problem.new(location, "Wrong argument type for #{pin.path}: #{par.name} expected #{ptype}, received #{argtype}")
388
- next
389
- end
390
- end
391
- end
392
- elsif par.decl == :kwarg
393
- errors.push Problem.new(location, "Call to #{pin.path} is missing keyword argument #{par.name}")
394
- next
395
- end
396
- end
397
- if errors.empty?
398
- all_errors.clear
399
- break
400
- end
401
- all_errors.concat errors
402
- end
403
- result.concat all_errors
404
- end
405
- base = base.base
406
- end
407
- result
408
- end
409
-
410
- # @param sig [Pin::Signature]
411
- # @param argchain [Source::Chain]
412
- # @param api_map [ApiMap]
413
- # @param block_pin [Pin::Block]
414
- # @param locals [Array<Pin::LocalVariable>]
415
- # @param location [Location]
416
- # @param pin [Pin::Method]
417
- # @param params [Hash{String => Hash{Symbol => String, Solargraph::ComplexType}}]
418
- # @param idx [Integer]
419
- #
420
- # @return [Array<Problem>]
421
- def kwarg_problems_for sig, argchain, api_map, block_pin, locals, location, pin, params, idx
422
- result = []
423
- kwargs = convert_hash(argchain.node)
424
- par = sig.parameters[idx]
425
- argchain = kwargs[par.name.to_sym]
426
- if par.decl == :kwrestarg || (par.decl == :optarg && idx == pin.parameters.length - 1 && par.asgn_code == '{}')
427
- result.concat kwrestarg_problems_for(api_map, block_pin, locals, location, pin, params, kwargs)
428
- else
429
- if argchain
430
- data = params[par.name]
431
- if data.nil?
432
- # @todo Some level (strong, I guess) should require the param here
433
- else
434
- ptype = data[:qualified]
435
- unless ptype.undefined?
436
- argtype = argchain.infer(api_map, block_pin, locals)
437
- if argtype.defined? && ptype && !any_types_match?(api_map, ptype, argtype)
438
- result.push Problem.new(location, "Wrong argument type for #{pin.path}: #{par.name} expected #{ptype}, received #{argtype}")
439
- end
440
- end
441
- end
442
- elsif par.decl == :kwarg
443
- result.push Problem.new(location, "Call to #{pin.path} is missing keyword argument #{par.name}")
444
- end
445
- end
446
- result
447
- end
448
-
449
- # @param api_map [ApiMap]
450
- # @param block_pin [Pin::Block]
451
- # @param locals [Array<Pin::LocalVariable>]
452
- # @param location [Location]
453
- # @param pin [Pin::Method]
454
- # @param params [Hash{String => [nil, Hash]}]
455
- # @param kwargs [Hash{Symbol => Source::Chain}]
456
- # @return [Array<Problem>]
457
- def kwrestarg_problems_for(api_map, block_pin, locals, location, pin, params, kwargs)
458
- result = []
459
- kwargs.each_pair do |pname, argchain|
460
- next unless params.key?(pname.to_s)
461
- ptype = params[pname.to_s][:qualified]
462
- argtype = argchain.infer(api_map, block_pin, locals)
463
- if argtype.defined? && ptype && !any_types_match?(api_map, ptype, argtype)
464
- result.push Problem.new(location, "Wrong argument type for #{pin.path}: #{pname} expected #{ptype}, received #{argtype}")
465
- end
466
- end
467
- result
468
- end
469
-
470
- # @param pin [Pin::Method]
471
- # @return [Hash{String => Hash{Symbol => String, ComplexType}}]
472
- def param_hash(pin)
473
- # @type [Hash{String => Hash{Symbol => String, ComplexType}}]
474
- result = {}
475
- pin.parameters.each do |param|
476
- type = param.typify(api_map)
477
- next if type.nil? || type.undefined?
478
- result[param.name.to_s] = {
479
- tagged: type.tags,
480
- qualified: type
481
- }
482
- end
483
- # see if we have additional tags to pay attention to from YARD -
484
- # e.g., kwargs in a **restkwargs splat
485
- tags = pin.docstring.tags(:param)
486
- tags.each do |tag|
487
- next if result.key? tag.name.to_s
488
- next if tag.types.nil?
489
- result[tag.name.to_s] = {
490
- tagged: tag.types.join(', '),
491
- qualified: Solargraph::ComplexType.try_parse(*tag.types).qualify(api_map, pin.full_context.namespace)
492
- }
493
- end
494
- result
495
- end
496
-
497
- # @param pins [Array<Pin::Method>]
498
- # @return [Hash{String => Hash{Symbol => String, ComplexType}}]
499
- def first_param_hash(pins)
500
- return {} if pins.empty?
501
- first_pin_type = pins.first.typify(api_map)
502
- first_pin = pins.first.proxy first_pin_type
503
- param_names = first_pin.parameter_names
504
- results = param_hash(first_pin)
505
- pins[1..].each do |pin|
506
- # @todo this assignment from parametric use of Hash should not lose its generic
507
- # @type [Hash{String => Hash{Symbol => BasicObject}}]
508
-
509
- # documentation of types in superclasses should fail back to
510
- # subclasses if the subclass hasn't documented something
511
- superclass_results = param_hash(pin)
512
- superclass_results.each do |param_name, details|
513
- next unless param_names.include?(param_name)
514
-
515
- results[param_name] ||= {}
516
- results[param_name][:tagged] ||= details[:tagged]
517
- results[param_name][:qualified] ||= details[:qualified]
518
- end
519
- end
520
- results
521
- end
522
-
523
- # @param pin [Pin::Base]
524
- def internal? pin
525
- return false if pin.nil?
526
- pin.location && api_map.bundled?(pin.location.filename)
527
- end
528
-
529
- # True if the pin is either internal (part of the workspace) or from the core/stdlib
530
- # @param pin [Pin::Base]
531
- def internal_or_core? pin
532
- # @todo RBS pins are not necessarily core/stdlib pins
533
- internal?(pin) || pin.source == :rbs
534
- end
535
-
536
- # @param pin [Pin::Base]
537
- def external? pin
538
- !internal? pin
539
- end
540
-
541
- # @param pin [Pin::BaseVariable]
542
- def declared_externally? pin
543
- return true if pin.assignment.nil?
544
- chain = Solargraph::Parser.chain(pin.assignment, filename)
545
- rng = Solargraph::Range.from_node(pin.assignment)
546
- block_pin = source_map.locate_block_pin(rng.start.line, rng.start.column)
547
- location = Location.new(filename, Range.from_node(pin.assignment))
548
- locals = source_map.locals_at(location)
549
- type = chain.infer(api_map, block_pin, locals)
550
- if type.undefined? && !rules.ignore_all_undefined?
551
- base = chain
552
- missing = chain
553
- found = nil
554
- closest = ComplexType::UNDEFINED
555
- until base.links.first.undefined?
556
- found = base.define(api_map, block_pin, locals).first
557
- break if found
558
- missing = base
559
- base = base.base
560
- end
561
- closest = found.typify(api_map) if found
562
- if !found || closest.defined? || internal?(found)
563
- return false
564
- end
565
- end
566
- true
567
- end
568
-
569
- # @param pin [Pin::Method]
570
- # @param arguments [Array<Source::Chain>]
571
- # @param location [Location]
572
- # @return [Array<Problem>]
573
- def arity_problems_for pin, arguments, location
574
- results = pin.signatures.map do |sig|
575
- r = parameterized_arity_problems_for(pin, sig.parameters, arguments, location)
576
- return [] if r.empty?
577
- r
578
- end
579
- results.first
580
- end
581
-
582
- # @param pin [Pin::Method]
583
- # @param parameters [Array<Pin::Parameter>]
584
- # @param arguments [Array<Source::Chain>]
585
- # @param location [Location]
586
- # @return [Array<Problem>]
587
- def parameterized_arity_problems_for(pin, parameters, arguments, location)
588
- return [] unless pin.explicit?
589
- return [] if parameters.empty? && arguments.empty?
590
- return [] if pin.anon_splat?
591
- unchecked = arguments.dup # creates copy of and unthaws array
592
- add_params = 0
593
- if unchecked.empty? && parameters.any? { |param| param.decl == :kwarg }
594
- return [Problem.new(location, "Missing keyword arguments to #{pin.path}")]
595
- end
596
- settled_kwargs = 0
597
- unless unchecked.empty?
598
- if any_splatted_call?(unchecked.map(&:node))
599
- settled_kwargs = parameters.count(&:keyword?)
600
- else
601
- kwargs = convert_hash(unchecked.last.node)
602
- if parameters.any? { |param| [:kwarg, :kwoptarg].include?(param.decl) || param.kwrestarg? }
603
- if kwargs.empty?
604
- add_params += 1
605
- else
606
- unchecked.pop
607
- parameters.each do |param|
608
- next unless param.keyword?
609
- if kwargs.key?(param.name.to_sym)
610
- kwargs.delete param.name.to_sym
611
- settled_kwargs += 1
612
- elsif param.decl == :kwarg
613
- last_arg_last_link = arguments.last.links.last
614
- return [] if last_arg_last_link.is_a?(Solargraph::Source::Chain::Hash) && last_arg_last_link.splatted?
615
- return [Problem.new(location, "Missing keyword argument #{param.name} to #{pin.path}")]
616
- end
617
- end
618
- kwargs.clear if parameters.any?(&:kwrestarg?)
619
- unless kwargs.empty?
620
- return [Problem.new(location, "Unrecognized keyword argument #{kwargs.keys.first} to #{pin.path}")]
621
- end
622
- end
623
- end
624
- end
625
- end
626
- req = required_param_count(parameters)
627
- if req + add_params < unchecked.length
628
- return [] if parameters.any?(&:rest?)
629
- opt = optional_param_count(parameters)
630
- return [] if unchecked.length <= req + opt
631
- if req + add_params + 1 == unchecked.length && any_splatted_call?(unchecked.map(&:node)) && (parameters.map(&:decl) & [:kwarg, :kwoptarg, :kwrestarg]).any?
632
- return []
633
- end
634
- return [] if arguments.length - req == parameters.select { |p| [:optarg, :kwoptarg].include?(p.decl) }.length
635
- return [Problem.new(location, "Too many arguments to #{pin.path}")]
636
- elsif unchecked.length < req - settled_kwargs && (arguments.empty? || (!arguments.last.splat? && !arguments.last.links.last.is_a?(Solargraph::Source::Chain::Hash)))
637
- # HACK: Kernel#raise signature is incorrect in Ruby 2.7 core docs.
638
- # See https://github.com/castwide/solargraph/issues/418
639
- unless arguments.empty? && pin.path == 'Kernel#raise'
640
- return [Problem.new(location, "Not enough arguments to #{pin.path}")]
641
- end
642
- end
643
- []
644
- end
645
-
646
- # @param parameters [Enumerable<Pin::Parameter>]
647
- # @todo need to use generic types in method to choose correct
648
- # signature and generate Integer as return type
649
- # @sg-ignore
650
- # @return [Integer]
651
- def required_param_count(parameters)
652
- parameters.sum { |param| %i[arg kwarg].include?(param.decl) ? 1 : 0 }
653
- end
654
-
655
- # @param parameters [Enumerable<Pin::Parameter>]
656
- # @param pin [Pin::Method]
657
- # @return [Integer]
658
- def optional_param_count(parameters)
659
- parameters.select { |p| p.decl == :optarg }.length
660
- end
661
-
662
- # @param pin [Pin::Method]
663
- def abstract? pin
664
- pin.docstring.has_tag?('abstract') ||
665
- (pin.closure && pin.closure.docstring.has_tag?('abstract'))
666
- end
667
-
668
- # @param pin [Pin::Method]
669
- # @return [Array<Source::Chain>]
670
- def fake_args_for(pin)
671
- args = []
672
- with_opts = false
673
- with_block = false
674
- pin.parameters.each do |pin|
675
- if [:kwarg, :kwoptarg, :kwrestarg].include?(pin.decl)
676
- with_opts = true
677
- elsif pin.decl == :block
678
- with_block = true
679
- elsif pin.decl == :restarg
680
- args.push Solargraph::Source::Chain.new([Solargraph::Source::Chain::Variable.new(pin.name)], nil, true)
681
- else
682
- args.push Solargraph::Source::Chain.new([Solargraph::Source::Chain::Variable.new(pin.name)])
683
- end
684
- end
685
- args.push Solargraph::Parser.chain_string('{}') if with_opts
686
- args.push Solargraph::Parser.chain_string('&') if with_block
687
- args
688
- end
689
-
690
- # @param problems [Array<Problem>]
691
- # @return [Array<Problem>]
692
- def without_ignored problems
693
- problems.reject do |problem|
694
- node = source_map.source.node_at(problem.location.range.start.line, problem.location.range.start.column)
695
- node && source_map.source.comments_for(node)&.include?('@sg-ignore')
696
- end
697
- end
698
- end
699
- end
1
+ # frozen_string_literal: true
2
+
3
+ module Solargraph
4
+ # A static analysis tool for validating data types.
5
+ #
6
+ class TypeChecker
7
+ autoload :Problem, 'solargraph/type_checker/problem'
8
+ autoload :ParamDef, 'solargraph/type_checker/param_def'
9
+ autoload :Rules, 'solargraph/type_checker/rules'
10
+ autoload :Checks, 'solargraph/type_checker/checks'
11
+
12
+ include Checks
13
+ include Parser::NodeMethods
14
+
15
+ # @return [String]
16
+ attr_reader :filename
17
+
18
+ # @return [Rules]
19
+ attr_reader :rules
20
+
21
+ # @return [ApiMap]
22
+ attr_reader :api_map
23
+
24
+ # @param filename [String, nil]
25
+ # @param api_map [ApiMap, nil]
26
+ # @param level [Symbol] Don't complain about anything above this level
27
+ # @param workspace [Workspace, nil] Workspace to use for loading
28
+ # type checker rules modified by user config
29
+ # @param type_checker_rules [Hash{Symbol => Symbol}] Overrides for
30
+ # type checker rules - e.g., :report_undefined => :strong
31
+ # @param rules [Rules] Type checker rules object
32
+ def initialize filename,
33
+ api_map: nil,
34
+ level: :normal,
35
+ workspace: filename ? Workspace.new(File.dirname(filename)) : nil,
36
+ rules: workspace ? workspace.rules(level) : Rules.new(level, {})
37
+ @filename = filename
38
+ # @todo Smarter directory resolution
39
+ @api_map = api_map || Solargraph::ApiMap.load(File.dirname(filename))
40
+ @rules = rules
41
+ # @type [Array<Range>]
42
+ @marked_ranges = []
43
+ end
44
+
45
+ # @return [SourceMap]
46
+ def source_map
47
+ @source_map ||= api_map.source_map(filename)
48
+ end
49
+
50
+ # @return [Source]
51
+ def source
52
+ @source_map.source
53
+ end
54
+
55
+ # @return [Array<Problem>]
56
+ def problems
57
+ @problems ||= begin
58
+ all = method_tag_problems
59
+ .concat(variable_type_tag_problems)
60
+ .concat(const_problems)
61
+ .concat(call_problems)
62
+ unignored = without_ignored(all)
63
+ unignored.concat(unneeded_sgignore_problems)
64
+ end
65
+ end
66
+
67
+ class << self
68
+ # @param filename [String]
69
+ # @param level [Symbol]
70
+ # @return [self]
71
+ def load filename, level = :normal
72
+ source = Solargraph::Source.load(filename)
73
+ api_map = Solargraph::ApiMap.new
74
+ api_map.map(source)
75
+ new(filename, api_map: api_map, level: level)
76
+ end
77
+
78
+ # @param code [String]
79
+ # @param filename [String, nil]
80
+ # @param level [Symbol]
81
+ # @return [self]
82
+ def load_string code, filename = nil, level = :normal
83
+ source = Solargraph::Source.load_string(code, filename)
84
+ api_map = Solargraph::ApiMap.new
85
+ api_map.map(source)
86
+ new(filename, api_map: api_map, level: level)
87
+ end
88
+ end
89
+
90
+ private
91
+
92
+ # @return [Array<Problem>]
93
+ def method_tag_problems
94
+ result = []
95
+ # @param pin [Pin::Method]
96
+ source_map.pins_by_class(Pin::Method).each do |pin|
97
+ result.concat method_return_type_problems_for(pin)
98
+ result.concat method_param_type_problems_for(pin)
99
+ end
100
+ result
101
+ end
102
+
103
+ # @param pin [Pin::Method]
104
+ # @return [Array<Problem>]
105
+ def method_return_type_problems_for pin
106
+ return [] if pin.is_a?(Pin::MethodAlias)
107
+ result = []
108
+ declared = pin.typify(api_map).self_to_type(pin.full_context).qualify(api_map, *pin.gates)
109
+ if declared.undefined?
110
+ if pin.return_type.undefined? && rules.require_type_tags?
111
+ if pin.attribute?
112
+ inferred = pin.probe(api_map).self_to_type(pin.full_context)
113
+ result.push Problem.new(pin.location, "Missing @return tag for #{pin.path}", pin: pin) unless inferred.defined?
114
+ else
115
+ result.push Problem.new(pin.location, "Missing @return tag for #{pin.path}", pin: pin)
116
+ end
117
+ elsif pin.return_type.defined? && !resolved_constant?(pin)
118
+ result.push Problem.new(pin.location, "Unresolved return type #{pin.return_type} for #{pin.path}", pin: pin)
119
+ elsif rules.must_tag_or_infer? && pin.probe(api_map).undefined?
120
+ result.push Problem.new(pin.location, "Untyped method #{pin.path} could not be inferred")
121
+ end
122
+ elsif rules.validate_tags?
123
+ unless pin.node.nil? || declared.void? || virtual_pin?(pin) || abstract?(pin)
124
+ inferred = pin.probe(api_map).self_to_type(pin.full_context)
125
+ if inferred.undefined?
126
+ unless rules.ignore_all_undefined? || external?(pin)
127
+ result.push Problem.new(pin.location, "#{pin.path} return type could not be inferred", pin: pin)
128
+ end
129
+ else
130
+ unless (rules.require_all_return_types_match_inferred? ? all_types_match?(api_map, inferred, declared) : any_types_match?(api_map, declared, inferred))
131
+ result.push Problem.new(pin.location, "Declared return type #{declared.rooted_tags} does not match inferred type #{inferred.rooted_tags} for #{pin.path}", pin: pin)
132
+ end
133
+ end
134
+ end
135
+ end
136
+ result
137
+ end
138
+
139
+ # @todo This is not optimal. A better solution would probably be to mix
140
+ # namespace alias into types at the ApiMap level.
141
+ #
142
+ # @param pin [Pin::Base]
143
+ # @return [Boolean]
144
+ def resolved_constant? pin
145
+ return true if pin.typify(api_map).defined?
146
+ constant_pins = api_map.get_constants('', *pin.closure.gates)
147
+ .select { |p| p.name == pin.return_type.namespace }
148
+ return true if constant_pins.find { |p| p.typify(api_map).defined? }
149
+ # will need to probe when a constant name is assigned to a
150
+ # class/module (alias)
151
+ return true if constant_pins.find { |p| p.probe(api_map).defined? }
152
+ false
153
+ end
154
+
155
+ # @param pin [Pin::Base]
156
+ def virtual_pin? pin
157
+ pin.location && source.comment_at?(pin.location.range.ending)
158
+ end
159
+
160
+ # @param pin [Pin::Method]
161
+ # @return [Array<Problem>]
162
+ def method_param_type_problems_for pin
163
+ stack = api_map.get_method_stack(pin.namespace, pin.name, scope: pin.scope)
164
+ result = []
165
+ pin.signatures.each do |sig|
166
+ params = param_details_from_stack(sig, stack)
167
+ if rules.require_type_tags?
168
+ sig.parameters.each do |par|
169
+ break if par.decl == :restarg || par.decl == :kwrestarg || par.decl == :blockarg
170
+ unless params[par.name]
171
+ if pin.attribute?
172
+ inferred = pin.probe(api_map).self_to_type(pin.full_context)
173
+ if inferred.undefined?
174
+ result.push Problem.new(pin.location, "Missing @param tag for #{par.name} on #{pin.path}", pin: pin)
175
+ end
176
+ else
177
+ result.push Problem.new(pin.location, "Missing @param tag for #{par.name} on #{pin.path}", pin: pin)
178
+ end
179
+ end
180
+ end
181
+ end
182
+ # @param name [String]
183
+ # @param data [Hash{Symbol => BasicObject}]
184
+ params.each_pair do |name, data|
185
+ # @type [ComplexType]
186
+ type = data[:qualified]
187
+ if type.undefined?
188
+ result.push Problem.new(pin.location, "Unresolved type #{data[:tagged]} for #{name} param on #{pin.path}", pin: pin)
189
+ end
190
+ end
191
+ end
192
+ result
193
+ end
194
+
195
+ # @return [Array<Pin::Base>]
196
+ def ignored_pins
197
+ @ignored_pins ||= []
198
+ end
199
+
200
+ # @return [Array<Problem>]
201
+ def variable_type_tag_problems
202
+ result = []
203
+ all_variables.each do |pin|
204
+ if pin.return_type.defined?
205
+ declared = pin.typify(api_map)
206
+ next if declared.duck_type?
207
+ if declared.defined? && pin.assignment
208
+ if rules.validate_tags?
209
+ inferred = pin.probe(api_map)
210
+ if inferred.undefined?
211
+ next if rules.ignore_all_undefined?
212
+ if declared_externally?(pin)
213
+ ignored_pins.push pin
214
+ else
215
+ result.push Problem.new(pin.location, "Variable type could not be inferred for #{pin.name}", pin: pin)
216
+ end
217
+ else
218
+ unless any_types_match?(api_map, declared, inferred)
219
+ result.push Problem.new(pin.location, "Declared type #{declared} does not match inferred type #{inferred} for variable #{pin.name}", pin: pin)
220
+ end
221
+ end
222
+ elsif declared_externally?(pin)
223
+ ignored_pins.push pin
224
+ end
225
+ elsif !pin.is_a?(Pin::Parameter) && !resolved_constant?(pin)
226
+ result.push Problem.new(pin.location, "Unresolved type #{pin.return_type} for variable #{pin.name}", pin: pin)
227
+ end
228
+ elsif pin.assignment
229
+ inferred = pin.probe(api_map)
230
+ if inferred.undefined? && declared_externally?(pin)
231
+ ignored_pins.push pin
232
+ end
233
+ end
234
+ end
235
+ result
236
+ end
237
+
238
+ # @return [Array<Pin::BaseVariable>]
239
+ def all_variables
240
+ source_map.pins_by_class(Pin::BaseVariable) + source_map.locals.select { |pin| pin.is_a?(Pin::LocalVariable) }
241
+ end
242
+
243
+ # @return [Array<Problem>]
244
+ def const_problems
245
+ return [] unless rules.validate_consts?
246
+ result = []
247
+ Solargraph::Parser::NodeMethods.const_nodes_from(source.node).each do |const|
248
+ rng = Solargraph::Range.from_node(const)
249
+ chain = Solargraph::Parser.chain(const, filename)
250
+ closure_pin = source_map.locate_closure_pin(rng.start.line, rng.start.column)
251
+ closure_pin.rebind(api_map)
252
+ location = Location.new(filename, rng)
253
+ locals = source_map.locals_at(location)
254
+ pins = chain.define(api_map, closure_pin, locals)
255
+ if pins.empty?
256
+ result.push Problem.new(location, "Unresolved constant #{Solargraph::Parser::NodeMethods.unpack_name(const)}")
257
+ @marked_ranges.push location.range
258
+ end
259
+ end
260
+ result
261
+ end
262
+
263
+ # @return [Array<Problem>]
264
+ def call_problems
265
+ result = []
266
+ Solargraph::Parser::NodeMethods.call_nodes_from(source.node).each do |call|
267
+ rng = Solargraph::Range.from_node(call)
268
+ next if @marked_ranges.any? { |d| d.contain?(rng.start) }
269
+ chain = Solargraph::Parser.chain(call, filename)
270
+ closure_pin = source_map.locate_closure_pin(rng.start.line, rng.start.column)
271
+ namespace_pin = closure_pin
272
+ if call.type == :block
273
+ # blocks in the AST include the method call as well, so the
274
+ # node returned by #call_nodes_from needs to be backed out
275
+ # one closure
276
+ closure_pin = closure_pin.closure
277
+ end
278
+ closure_pin.rebind(api_map)
279
+ location = Location.new(filename, rng)
280
+ locals = source_map.locals_at(location)
281
+ type = chain.infer(api_map, closure_pin, locals)
282
+ if type.undefined? && !rules.ignore_all_undefined?
283
+ base = chain
284
+ missing = chain
285
+ found = nil
286
+ closest = ComplexType::UNDEFINED
287
+ until base.links.first.undefined?
288
+ found = base.define(api_map, closure_pin, locals).first
289
+ break if found
290
+ missing = base
291
+ base = base.base
292
+ end
293
+ closest = found.typify(api_map) if found
294
+ # @todo remove the internal_or_core? check at a higher-than-strict level
295
+ if !found || found.is_a?(Pin::BaseVariable) || (closest.defined? && internal_or_core?(found))
296
+ unless closest.generic? || ignored_pins.include?(found)
297
+ if closest.defined?
298
+ result.push Problem.new(location, "Unresolved call to #{missing.links.last.word} on #{closest}")
299
+ else
300
+ result.push Problem.new(location, "Unresolved call to #{missing.links.last.word}")
301
+ end
302
+ @marked_ranges.push rng
303
+ end
304
+ end
305
+ end
306
+ result.concat argument_problems_for(chain, api_map, closure_pin, locals, location)
307
+ end
308
+ result
309
+ end
310
+
311
+ # @param chain [Solargraph::Source::Chain]
312
+ # @param api_map [Solargraph::ApiMap]
313
+ # @param closure_pin [Solargraph::Pin::Closure]
314
+ # @param locals [Array<Solargraph::Pin::Base>]
315
+ # @param location [Solargraph::Location]
316
+ # @return [Array<Problem>]
317
+ def argument_problems_for chain, api_map, closure_pin, locals, location
318
+ result = []
319
+ base = chain
320
+ # @type last_base_link [Solargraph::Source::Chain::Call]
321
+ last_base_link = base.links.last
322
+ return [] unless last_base_link.is_a?(Solargraph::Source::Chain::Call)
323
+
324
+ arguments = last_base_link.arguments
325
+
326
+ pins = base.define(api_map, closure_pin, locals)
327
+
328
+ first_pin = pins.first
329
+ if first_pin.is_a?(Pin::DelegatedMethod) && !first_pin.resolvable?(api_map)
330
+ # Do nothing, as we can't find the actual method implementation
331
+ elsif first_pin.is_a?(Pin::Method)
332
+ # @type [Pin::Method]
333
+ pin = first_pin
334
+ ap = if base.links.last.is_a?(Solargraph::Source::Chain::ZSuper)
335
+ arity_problems_for(pin, fake_args_for(closure_pin), location)
336
+ elsif pin.path == 'Class#new'
337
+ fqns = if base.links.one?
338
+ closure_pin.namespace
339
+ else
340
+ base.base.infer(api_map, closure_pin, locals).namespace
341
+ end
342
+ init = api_map.get_method_stack(fqns, 'initialize').first
343
+ init ? arity_problems_for(init, arguments, location) : []
344
+ else
345
+ arity_problems_for(pin, arguments, location)
346
+ end
347
+ return ap unless ap.empty?
348
+ return [] if !rules.validate_calls? || base.links.first.is_a?(Solargraph::Source::Chain::ZSuper)
349
+
350
+ all_errors = []
351
+ pin.signatures.sort { |sig| sig.parameters.length }.each do |sig|
352
+ params = param_details_from_stack(sig, pins)
353
+
354
+ signature_errors = signature_argument_problems_for location, locals, closure_pin, params, arguments, sig, pin
355
+
356
+ if signature_errors.empty?
357
+ # we found a signature that works - meaning errors from
358
+ # other signatures don't matter.
359
+ return []
360
+ end
361
+ all_errors.concat signature_errors
362
+ end
363
+ result.concat all_errors
364
+ end
365
+ result
366
+ end
367
+
368
+ # @param location [Location]
369
+ # @param locals [Array<Pin::LocalVariable>]
370
+ # @param closure_pin [Pin::Closure]
371
+ # @param params [Hash{String => Hash{Symbol => String, Solargraph::ComplexType}}]
372
+ # @param arguments [Array<Source::Chain>]
373
+ # @param sig [Pin::Signature]
374
+ # @param pin [Pin::Method]
375
+ # @param pins [Array<Pin::Method>]
376
+ #
377
+ # @return [Array<Problem>]
378
+ def signature_argument_problems_for location, locals, closure_pin, params, arguments, sig, pin
379
+ errors = []
380
+ # @todo add logic mapping up restarg parameters with
381
+ # arguments (including restarg arguments). Use tuples
382
+ # when possible, and when not, ensure provably
383
+ # incorrect situations are detected.
384
+ sig.parameters.each_with_index do |par, idx|
385
+ return errors if par.decl == :restarg # bail out and assume the rest is valid pending better arg processing
386
+ argchain = arguments[idx]
387
+ if argchain.nil?
388
+ if par.decl == :arg
389
+ final_arg = arguments.last
390
+ if final_arg && final_arg.node.type == :splat
391
+ argchain = final_arg
392
+ return errors
393
+ else
394
+ errors.push Problem.new(location, "Not enough arguments to #{pin.path}")
395
+ end
396
+ else
397
+ final_arg = arguments.last
398
+ argchain = final_arg if final_arg && [:kwsplat, :hash].include?(final_arg.node.type)
399
+ end
400
+ end
401
+ if argchain
402
+ if par.decl != :arg
403
+ errors.concat kwarg_problems_for sig, argchain, api_map, closure_pin, locals, location, pin, params, idx
404
+ next
405
+ else
406
+ if argchain.node.type == :splat && argchain == arguments.last
407
+ final_arg = argchain
408
+ end
409
+ if (final_arg && final_arg.node.type == :splat)
410
+ # The final argument given has been seen and was a
411
+ # splat, which doesn't give us useful types or
412
+ # arities against positional parameters, so let's
413
+ # continue on in case there are any required
414
+ # kwargs we should warn about
415
+ next
416
+ end
417
+ if argchain.node.type == :splat && par != sig.parameters.last
418
+ # we have been given a splat and there are more
419
+ # arguments to come.
420
+
421
+ # @todo Improve this so that we can skip past the
422
+ # rest of the positional parameters here but still
423
+ # process the kwargs
424
+ return errors
425
+ end
426
+ ptype = params.key?(par.name) ? params[par.name][:qualified] : ComplexType::UNDEFINED
427
+ ptype = ptype.self_to_type(par.context)
428
+ if ptype.nil?
429
+ # @todo Some level (strong, I guess) should require the param here
430
+ else
431
+ argtype = argchain.infer(api_map, closure_pin, locals)
432
+ argtype = argtype.self_to_type(closure_pin.context)
433
+ if argtype.defined? && ptype.defined? && !any_types_match?(api_map, ptype, argtype)
434
+ errors.push Problem.new(location, "Wrong argument type for #{pin.path}: #{par.name} expected #{ptype}, received #{argtype}")
435
+ return errors
436
+ end
437
+ end
438
+ end
439
+ elsif par.decl == :kwarg
440
+ errors.push Problem.new(location, "Call to #{pin.path} is missing keyword argument #{par.name}")
441
+ next
442
+ end
443
+ end
444
+ errors
445
+ end
446
+
447
+ # @param sig [Pin::Signature]
448
+ # @param argchain [Source::Chain]
449
+ # @param api_map [ApiMap]
450
+ # @param closure_pin [Pin::Closure]
451
+ # @param locals [Array<Pin::LocalVariable>]
452
+ # @param location [Location]
453
+ # @param pin [Pin::Method]
454
+ # @param params [Hash{String => Hash{Symbol => String, Solargraph::ComplexType}}]
455
+ # @param idx [Integer]
456
+ #
457
+ # @return [Array<Problem>]
458
+ def kwarg_problems_for sig, argchain, api_map, closure_pin, locals, location, pin, params, idx
459
+ result = []
460
+ kwargs = convert_hash(argchain.node)
461
+ par = sig.parameters[idx]
462
+ argchain = kwargs[par.name.to_sym]
463
+ if par.decl == :kwrestarg || (par.decl == :optarg && idx == pin.parameters.length - 1 && par.asgn_code == '{}')
464
+ result.concat kwrestarg_problems_for(api_map, closure_pin, locals, location, pin, params, kwargs)
465
+ else
466
+ if argchain
467
+ data = params[par.name]
468
+ if data.nil?
469
+ # @todo Some level (strong, I guess) should require the param here
470
+ else
471
+ ptype = data[:qualified]
472
+ ptype = ptype.self_to_type(pin.context)
473
+ unless ptype.undefined?
474
+ # @sg-ignore https://github.com/castwide/solargraph/pull/1127
475
+ argtype = argchain.infer(api_map, closure_pin, locals).self_to_type(closure_pin.context)
476
+ # @sg-ignore Unresolved call to defined?
477
+ if argtype.defined? && ptype && !any_types_match?(api_map, ptype, argtype)
478
+ result.push Problem.new(location, "Wrong argument type for #{pin.path}: #{par.name} expected #{ptype}, received #{argtype}")
479
+ end
480
+ end
481
+ end
482
+ elsif par.decl == :kwarg
483
+ result.push Problem.new(location, "Call to #{pin.path} is missing keyword argument #{par.name}")
484
+ end
485
+ end
486
+ result
487
+ end
488
+
489
+ # @param api_map [ApiMap]
490
+ # @param closure_pin [Pin::Closure]
491
+ # @param locals [Array<Pin::LocalVariable>]
492
+ # @param location [Location]
493
+ # @param pin [Pin::Method]
494
+ # @param params [Hash{String => [nil, Hash]}]
495
+ # @param kwargs [Hash{Symbol => Source::Chain}]
496
+ # @return [Array<Problem>]
497
+ def kwrestarg_problems_for(api_map, closure_pin, locals, location, pin, params, kwargs)
498
+ result = []
499
+ kwargs.each_pair do |pname, argchain|
500
+ next unless params.key?(pname.to_s)
501
+ ptype = params[pname.to_s][:qualified]
502
+ ptype = ptype.self_to_type(pin.context)
503
+ argtype = argchain.infer(api_map, closure_pin, locals)
504
+ argtype = argtype.self_to_type(closure_pin.context)
505
+ if argtype.defined? && ptype && !any_types_match?(api_map, ptype, argtype)
506
+ result.push Problem.new(location, "Wrong argument type for #{pin.path}: #{pname} expected #{ptype}, received #{argtype}")
507
+ end
508
+ end
509
+ result
510
+ end
511
+
512
+ # @param param_details [Hash{String => Hash{Symbol => String, ComplexType}}]
513
+ # @param pin [Pin::Method, Pin::Signature]
514
+ # @param relevant_pin [Pin::Method, Pin::Signature] the pin which is under inspection
515
+ # @return [void]
516
+ def add_restkwarg_param_tag_details(param_details, pin, relevant_pin)
517
+ # see if we have additional tags to pay attention to from YARD -
518
+ # e.g., kwargs in a **restkwargs splat
519
+ tags = pin.docstring.tags(:param)
520
+ tags.each do |tag|
521
+ next if param_details.key? tag.name.to_s
522
+ next if tag.types.nil?
523
+ details = {
524
+ tagged: tag.types.join(', '),
525
+ qualified: Solargraph::ComplexType.try_parse(*tag.types).qualify(api_map, pin.full_context.namespace)
526
+ }
527
+ # don't complain about a param that didn't come from the pin we're looking at anyway
528
+ if details[:qualified].defined? ||
529
+ relevant_pin.parameter_names.include?(tag.name.to_s)
530
+ param_details[tag.name.to_s] = details
531
+ end
532
+ end
533
+ end
534
+
535
+ # @param pin [Pin::Signature]
536
+ # @return [Hash{String => Hash{Symbol => String, ComplexType}}]
537
+ def signature_param_details(pin)
538
+ # @type [Hash{String => Hash{Symbol => String, ComplexType}}]
539
+ result = {}
540
+ pin.parameters.each do |param|
541
+ type = param.typify(api_map)
542
+ next if type.nil? || type.undefined?
543
+ result[param.name.to_s] = {
544
+ tagged: type.tags,
545
+ qualified: type
546
+ }
547
+ end
548
+ # see if we have additional tags to pay attention to from YARD -
549
+ # e.g., kwargs in a **restkwargs splat
550
+ tags = pin.docstring.tags(:param)
551
+ tags.each do |tag|
552
+ next if result.key? tag.name.to_s
553
+ next if tag.types.nil?
554
+ result[tag.name.to_s] = {
555
+ tagged: tag.types.join(', '),
556
+ qualified: Solargraph::ComplexType.try_parse(*tag.types).qualify(api_map, *pin.closure.gates)
557
+ }
558
+ end
559
+ result
560
+ end
561
+
562
+ # The original signature defines the parameters, but other
563
+ # signatures and method pins can help by adding type information
564
+ #
565
+ # @param param_details [Hash{String => Hash{Symbol => String, ComplexType}}]
566
+ # @param param_names [Array<String>]
567
+ # @param new_param_details [Hash{String => Hash{Symbol => String, ComplexType}}]
568
+ #
569
+ # @return [void]
570
+ def add_to_param_details(param_details, param_names, new_param_details)
571
+ new_param_details.each do |param_name, details|
572
+ next unless param_names.include?(param_name)
573
+
574
+ param_details[param_name] ||= {}
575
+ param_details[param_name][:tagged] ||= details[:tagged]
576
+ param_details[param_name][:qualified] ||= details[:qualified]
577
+ end
578
+ end
579
+
580
+ # @param signature [Pin::Signature]
581
+ # @param method_pin_stack [Array<Pin::Method>]
582
+ # @return [Hash{String => Hash{Symbol => String, ComplexType}}]
583
+ def param_details_from_stack(signature, method_pin_stack)
584
+ signature_type = signature.typify(api_map)
585
+ signature = signature.proxy signature_type
586
+ param_details = signature_param_details(signature)
587
+ param_names = signature.parameter_names
588
+
589
+ method_pin_stack.each do |method_pin|
590
+ add_restkwarg_param_tag_details(param_details, method_pin, signature)
591
+
592
+ # documentation of types in superclasses should fail back to
593
+ # subclasses if the subclass hasn't documented something
594
+ method_pin.signatures.each do |sig|
595
+ add_restkwarg_param_tag_details(param_details, sig, signature)
596
+ add_to_param_details param_details, param_names, signature_param_details(sig)
597
+ end
598
+ end
599
+ param_details
600
+ end
601
+
602
+ # @param pin [Pin::Base]
603
+ def internal? pin
604
+ return false if pin.nil?
605
+ pin.location && api_map.bundled?(pin.location.filename)
606
+ end
607
+
608
+ # True if the pin is either internal (part of the workspace) or from the core/stdlib
609
+ # @param pin [Pin::Base]
610
+ def internal_or_core? pin
611
+ # @todo RBS pins are not necessarily core/stdlib pins
612
+ internal?(pin) || pin.source == :rbs
613
+ end
614
+
615
+ # @param pin [Pin::Base]
616
+ def external? pin
617
+ !internal? pin
618
+ end
619
+
620
+ # @param pin [Pin::BaseVariable]
621
+ def declared_externally? pin
622
+ raise "No assignment found" if pin.assignment.nil?
623
+
624
+ chain = Solargraph::Parser.chain(pin.assignment, filename)
625
+ rng = Solargraph::Range.from_node(pin.assignment)
626
+ closure_pin = source_map.locate_closure_pin(rng.start.line, rng.start.column)
627
+ location = Location.new(filename, Range.from_node(pin.assignment))
628
+ locals = source_map.locals_at(location)
629
+ type = chain.infer(api_map, closure_pin, locals)
630
+ if type.undefined? && !rules.ignore_all_undefined?
631
+ base = chain
632
+ missing = chain
633
+ found = nil
634
+ closest = ComplexType::UNDEFINED
635
+ until base.links.first.undefined?
636
+ found = base.define(api_map, closure_pin, locals).first
637
+ break if found
638
+ missing = base
639
+ base = base.base
640
+ end
641
+ closest = found.typify(api_map) if found
642
+ if !found || closest.defined? || internal?(found)
643
+ return false
644
+ end
645
+ end
646
+ true
647
+ end
648
+
649
+ # @param pin [Pin::Method]
650
+ # @param arguments [Array<Source::Chain>]
651
+ # @param location [Location]
652
+ # @return [Array<Problem>]
653
+ def arity_problems_for pin, arguments, location
654
+ results = pin.signatures.map do |sig|
655
+ r = parameterized_arity_problems_for(pin, sig.parameters, arguments, location)
656
+ return [] if r.empty?
657
+ r
658
+ end
659
+ results.first
660
+ end
661
+
662
+ # @param pin [Pin::Method]
663
+ # @param parameters [Array<Pin::Parameter>]
664
+ # @param arguments [Array<Source::Chain>]
665
+ # @param location [Location]
666
+ # @return [Array<Problem>]
667
+ def parameterized_arity_problems_for(pin, parameters, arguments, location)
668
+ return [] unless pin.explicit?
669
+ return [] if parameters.empty? && arguments.empty?
670
+ return [] if pin.anon_splat?
671
+ unchecked = arguments.dup # creates copy of and unthaws array
672
+ add_params = 0
673
+ if unchecked.empty? && parameters.any? { |param| param.decl == :kwarg }
674
+ return [Problem.new(location, "Missing keyword arguments to #{pin.path}")]
675
+ end
676
+ settled_kwargs = 0
677
+ unless unchecked.empty?
678
+ if any_splatted_call?(unchecked.map(&:node))
679
+ settled_kwargs = parameters.count(&:keyword?)
680
+ else
681
+ kwargs = convert_hash(unchecked.last.node)
682
+ if parameters.any? { |param| [:kwarg, :kwoptarg].include?(param.decl) || param.kwrestarg? }
683
+ if kwargs.empty?
684
+ add_params += 1
685
+ else
686
+ unchecked.pop
687
+ parameters.each do |param|
688
+ next unless param.keyword?
689
+ if kwargs.key?(param.name.to_sym)
690
+ kwargs.delete param.name.to_sym
691
+ settled_kwargs += 1
692
+ elsif param.decl == :kwarg
693
+ last_arg_last_link = arguments.last.links.last
694
+ return [] if last_arg_last_link.is_a?(Solargraph::Source::Chain::Hash) && last_arg_last_link.splatted?
695
+ return [Problem.new(location, "Missing keyword argument #{param.name} to #{pin.path}")]
696
+ end
697
+ end
698
+ kwargs.clear if parameters.any?(&:kwrestarg?)
699
+ unless kwargs.empty?
700
+ return [Problem.new(location, "Unrecognized keyword argument #{kwargs.keys.first} to #{pin.path}")]
701
+ end
702
+ end
703
+ end
704
+ end
705
+ end
706
+ req = required_param_count(parameters)
707
+ if req + add_params < unchecked.length
708
+ return [] if parameters.any?(&:rest?)
709
+ opt = optional_param_count(parameters)
710
+ return [] if unchecked.length <= req + opt
711
+ if req + add_params + 1 == unchecked.length && any_splatted_call?(unchecked.map(&:node)) && (parameters.map(&:decl) & [:kwarg, :kwoptarg, :kwrestarg]).any?
712
+ return []
713
+ end
714
+ return [] if arguments.length - req == parameters.select { |p| [:optarg, :kwoptarg].include?(p.decl) }.length
715
+ return [Problem.new(location, "Too many arguments to #{pin.path}")]
716
+ elsif unchecked.length < req - settled_kwargs && (arguments.empty? || (!arguments.last.splat? && !arguments.last.links.last.is_a?(Solargraph::Source::Chain::Hash)))
717
+ # HACK: Kernel#raise signature is incorrect in Ruby 2.7 core docs.
718
+ # See https://github.com/castwide/solargraph/issues/418
719
+ unless arguments.empty? && pin.path == 'Kernel#raise'
720
+ return [Problem.new(location, "Not enough arguments to #{pin.path}")]
721
+ end
722
+ end
723
+ []
724
+ end
725
+
726
+ # @param parameters [Enumerable<Pin::Parameter>]
727
+ # @todo need to use generic types in method to choose correct
728
+ # signature and generate Integer as return type
729
+ # @return [Integer]
730
+ def required_param_count(parameters)
731
+ parameters.sum { |param| %i[arg kwarg].include?(param.decl) ? 1 : 0 }
732
+ end
733
+
734
+ # @param parameters [Enumerable<Pin::Parameter>]
735
+ # @param pin [Pin::Method]
736
+ # @return [Integer]
737
+ def optional_param_count(parameters)
738
+ parameters.select { |p| p.decl == :optarg }.length
739
+ end
740
+
741
+ # @param pin [Pin::Method]
742
+ def abstract? pin
743
+ pin.docstring.has_tag?('abstract') ||
744
+ (pin.closure && pin.closure.docstring.has_tag?('abstract'))
745
+ end
746
+
747
+ # @param pin [Pin::Method]
748
+ # @return [Array<Source::Chain>]
749
+ def fake_args_for(pin)
750
+ args = []
751
+ with_opts = false
752
+ with_block = false
753
+ pin.parameters.each do |pin|
754
+ if [:kwarg, :kwoptarg, :kwrestarg].include?(pin.decl)
755
+ with_opts = true
756
+ elsif pin.decl == :block
757
+ with_block = true
758
+ elsif pin.decl == :restarg
759
+ args.push Solargraph::Source::Chain.new([Solargraph::Source::Chain::Variable.new(pin.name)], nil, true)
760
+ else
761
+ args.push Solargraph::Source::Chain.new([Solargraph::Source::Chain::Variable.new(pin.name)])
762
+ end
763
+ end
764
+ args.push Solargraph::Parser.chain_string('{}') if with_opts
765
+ args.push Solargraph::Parser.chain_string('&') if with_block
766
+ args
767
+ end
768
+
769
+ # @return [Set<Integer>]
770
+ def sg_ignore_lines_processed
771
+ @sg_ignore_lines_processed ||= Set.new
772
+ end
773
+
774
+ # @return [Set<Integer>]
775
+ def all_sg_ignore_lines
776
+ source.associated_comments.select do |_line, text|
777
+ text.include?('@sg-ignore')
778
+ end.keys.to_set
779
+ end
780
+
781
+ # @return [Array<Integer>]
782
+ def unprocessed_sg_ignore_lines
783
+ (all_sg_ignore_lines - sg_ignore_lines_processed).to_a.sort
784
+ end
785
+
786
+ # @return [Array<Problem>]
787
+ def unneeded_sgignore_problems
788
+ return [] unless rules.validate_sg_ignores?
789
+
790
+ unprocessed_sg_ignore_lines.map do |line|
791
+ Problem.new(
792
+ Location.new(filename, Range.from_to(line, 0, line, 0)),
793
+ 'Unneeded @sg-ignore comment'
794
+ )
795
+ end
796
+ end
797
+
798
+ # @param problems [Array<Problem>]
799
+ # @return [Array<Problem>]
800
+ def without_ignored problems
801
+ problems.reject do |problem|
802
+ node = source.node_at(problem.location.range.start.line, problem.location.range.start.column)
803
+ ignored = node && source.comments_for(node)&.include?('@sg-ignore')
804
+ unless !ignored || all_sg_ignore_lines.include?(problem.location.range.start.line)
805
+ # :nocov:
806
+ Solargraph.assert_or_log(:sg_ignore) { "@sg-ignore accounting issue - node is #{node}" }
807
+ # :nocov:
808
+ end
809
+ sg_ignore_lines_processed.add problem.location.range.start.line if ignored
810
+ ignored
811
+ end
812
+ end
813
+ end
814
+ end