simple_form 1.5.2 → 2.0.0

data/test/components/label_test.rb

@@ -1,7 +1,8 @@
 # encoding: UTF-8
 require 'test_helper'
 
-class LabelTest < ActionView::TestCase
+# Isolated tests for label without triggering f.label.
+class IsolatedLabelTest < ActionView::TestCase
   setup do
     SimpleForm::Inputs::Base.reset_i18n_cache :translate_required_html
   end
@@ -71,16 +72,16 @@ class LabelTest < ActionView::TestCase
     end
   end
 
-  test 'input should use i18n based only on attribute to lookup translation' do
-    store_translations(:en, :simple_form => { :labels => { :age => 'Idade' } } ) do
+  test 'input should use i18n under defaults to lookup translation' do
+    store_translations(:en, :simple_form => { :labels => { :defaults => {:age => 'Idade'} } } ) do
       with_label_for @user, :age, :integer
       assert_select 'label[for=user_age]', /Idade/
     end
   end
 
   test 'input should not use i18n label if translate is false' do
-    swap SimpleForm, :translate => false do
-      store_translations(:en, :simple_form => { :labels => { :age => 'Idade' } } ) do
+    swap SimpleForm, :translate_labels => false do
+      store_translations(:en, :simple_form => { :labels => { :defaults => {:age => 'Idade'} } } ) do
         with_label_for @user, :age, :integer
         assert_select 'label[for=user_age]', /Age/
       end
@@ -165,6 +166,21 @@ class LabelTest < ActionView::TestCase
     assert_select 'label.datetime'
   end
 
+  test 'label should not have css class from type when generate_additional_classes_for does not include :label' do
+    swap SimpleForm, :generate_additional_classes_for => [:wrapper, :input] do
+      with_label_for @user, :name, :string
+      assert_no_select 'label.string'
+      with_label_for @user, :description, :text
+      assert_no_select 'label.text'
+      with_label_for @user, :age, :integer
+      assert_no_select 'label.integer'
+      with_label_for @user, :born_at, :date
+      assert_no_select 'label.date'
+      with_label_for @user, :created_at, :datetime
+      assert_no_select 'label.datetime'
+    end
+  end
+
   test 'label should obtain required from ActiveModel::Validations when it is included' do
     with_label_for @validating_user, :name, :string
     assert_select 'label.required'
@@ -172,6 +188,15 @@ class LabelTest < ActionView::TestCase
     assert_select 'label.optional'
   end
 
+  test 'label should not obtain required from ActiveModel::Validations when generate_additional_classes_for does not include :label' do
+    swap SimpleForm, :generate_additional_classes_for => [:wrapper, :input] do
+      with_label_for @validating_user, :name, :string
+      assert_no_select 'label.required'
+      with_label_for @validating_user, :status, :string
+      assert_no_select 'label.optional'
+    end
+  end
+
   test 'label should allow overriding required when ActiveModel::Validations is included' do
     with_label_for @validating_user, :name, :string, :required => false
     assert_select 'label.optional'
@@ -246,6 +271,11 @@ class LabelTest < ActionView::TestCase
     assert_select 'label[for=project_name]', /Name/
   end
 
+  test 'label should include for attribute for select collection' do
+    with_label_for @user, :sex, :select, :collection => [:male, :female]
+    assert_select 'label[for=user_sex]'
+  end
+
   test 'label should use i18n properly when object is not present' do
     store_translations(:en, :simple_form => { :labels => {
       :project => { :name => 'Nome' }
@@ -268,4 +298,13 @@ class LabelTest < ActionView::TestCase
       assert_select 'label.my_custom_class'
     end
   end
+
+  test 'label strips extra classes even when label_class is nil' do
+    swap SimpleForm, :label_class => nil do
+      with_label_for @user, :name, :string
+      assert_select "label[class='string required']"
+      assert_no_select "label[class='string required ']"
+      assert_no_select "label[class=' string required']"
+    end
+  end
 end

data/test/form_builder/association_test.rb

@@ -0,0 +1,177 @@
+# encoding: UTF-8
+require 'test_helper'
+
+class AssociationTest < ActionView::TestCase
+  def with_association_for(object, *args)
+    with_concat_form_for(object) do |f|
+      f.association(*args)
+    end
+  end
+
+  test 'builder should not allow creating an association input when no object exists' do
+    assert_raise ArgumentError do
+      with_association_for :post, :author
+    end
+  end
+
+  test 'builder association with a block calls simple_fields_for' do
+    simple_form_for @user do |f|
+      f.association :posts do |posts_form|
+        assert posts_form.instance_of?(SimpleForm::FormBuilder)
+      end
+    end
+  end
+
+  test 'builder association forwards collection to simple_fields_for' do
+    calls = 0
+    simple_form_for @user do |f|
+      f.association :company, :collection => Company.all do |c|
+        calls += 1
+      end
+    end
+
+    assert_equal 3, calls
+  end
+
+  test 'builder association marks input as required based on both association and attribute' do
+    swap SimpleForm, :required_by_default => false do
+      with_association_for @validating_user, :company, :collection => []
+      assert_select 'label.required'
+    end
+  end
+
+  test 'builder preloads collection association' do
+    value = @user.tags
+    value.expects(:to_a).returns(value)
+    with_association_for @user, :tags
+    assert_select 'form select.select#user_tag_ids'
+    assert_select 'form select option[value=1]', 'Tag 1'
+    assert_select 'form select option[value=2]', 'Tag 2'
+    assert_select 'form select option[value=3]', 'Tag 3'
+  end
+
+  test 'builder does not preload collection association if preload is false' do
+    value = @user.company
+    value.expects(:to_a).never
+    with_association_for @user, :company, :preload => false
+    assert_select 'form select.select#user_company_id'
+    assert_select 'form select option[value=1]', 'Company 1'
+    assert_select 'form select option[value=2]', 'Company 2'
+    assert_select 'form select option[value=3]', 'Company 3'
+  end
+
+  test 'builder does not preload non-collection association' do
+    value = @user.company
+    value.expects(:to_a).never
+    with_association_for @user, :company, :preload => false
+    assert_select 'form select.select#user_company_id'
+    assert_select 'form select option[value=1]', 'Company 1'
+    assert_select 'form select option[value=2]', 'Company 2'
+    assert_select 'form select option[value=3]', 'Company 3'
+  end
+
+  # ASSOCIATIONS - BELONGS TO
+  test 'builder creates a select for belongs_to associations' do
+    with_association_for @user, :company
+    assert_select 'form select.select#user_company_id'
+    assert_select 'form select option[value=1]', 'Company 1'
+    assert_select 'form select option[value=2]', 'Company 2'
+    assert_select 'form select option[value=3]', 'Company 3'
+  end
+
+  test 'builder allows collection radio for belongs_to associations' do
+    with_association_for @user, :company, :as => :radio_buttons
+    assert_select 'form input.radio_buttons#user_company_id_1'
+    assert_select 'form input.radio_buttons#user_company_id_2'
+    assert_select 'form input.radio_buttons#user_company_id_3'
+  end
+
+  test 'builder marks the record which already belongs to the user' do
+    @user.company_id = 2
+    with_association_for @user, :company, :as => :radio_buttons
+    assert_no_select 'form input.radio_buttons#user_company_id_1[checked=checked]'
+    assert_select 'form input.radio_buttons#user_company_id_2[checked=checked]'
+    assert_no_select 'form input.radio_buttons#user_company_id_3[checked=checked]'
+  end
+
+  # ASSOCIATIONS - FINDERS
+  test 'builder should use reflection conditions to find collection' do
+    with_association_for @user, :special_company
+    assert_select 'form select.select#user_special_company_id'
+    assert_select 'form select option[value=1]'
+    assert_no_select 'form select option[value=2]'
+    assert_no_select 'form select option[value=3]'
+  end
+
+  test 'builder should allow overriding collection to association input' do
+    with_association_for @user, :company, :include_blank => false,
+                         :collection => [Company.new(999, 'Teste')]
+    assert_select 'form select.select#user_company_id'
+    assert_no_select 'form select option[value=1]'
+    assert_select 'form select option[value=999]', 'Teste'
+    assert_select 'form select option', :count => 1
+  end
+
+  # ASSOCIATIONS - has_*
+  test 'builder does not allow has_one associations' do
+    assert_raise RuntimeError do
+      with_association_for @user, :first_company, :as => :radio_buttons
+    end
+  end
+
+  test 'builder creates a select with multiple options for collection associations' do
+    with_association_for @user, :tags
+    assert_select 'form select.select#user_tag_ids'
+    assert_select 'form select[multiple=multiple][size=5]'
+    assert_select 'form select option[value=1]', 'Tag 1'
+    assert_select 'form select option[value=2]', 'Tag 2'
+    assert_select 'form select option[value=3]', 'Tag 3'
+  end
+
+  test 'builder allows size to be overwritten for collection associations' do
+    with_association_for @user, :tags, :input_html => { :size => 10 }
+    assert_select 'form select[multiple=multiple][size=10]'
+  end
+
+  test 'builder marks all selected records which already belongs to user' do
+    @user.tag_ids = [1, 2]
+    with_association_for @user, :tags
+    assert_select 'form select option[value=1][selected=selected]'
+    assert_select 'form select option[value=2][selected=selected]'
+    assert_no_select 'form select option[value=3][selected=selected]'
+  end
+
+  test 'builder allows a collection of check boxes for collection associations' do
+    @user.tag_ids = [1, 2]
+    with_association_for @user, :tags, :as => :check_boxes
+    assert_select 'form input#user_tag_ids_1[type=checkbox]'
+    assert_select 'form input#user_tag_ids_2[type=checkbox]'
+    assert_select 'form input#user_tag_ids_3[type=checkbox]'
+  end
+
+  test 'builder marks all selected records for collection boxes' do
+    @user.tag_ids = [1, 2]
+    with_association_for @user, :tags, :as => :check_boxes
+    assert_select 'form input[type=checkbox][value=1][checked=checked]'
+    assert_select 'form input[type=checkbox][value=2][checked=checked]'
+    assert_no_select 'form input[type=checkbox][value=3][checked=checked]'
+  end
+
+  test 'builder with collection support giving collection and item wrapper tags' do
+    with_association_for @user, :tags, :as => :check_boxes,
+      :collection_wrapper_tag => :ul, :item_wrapper_tag => :li
+
+    assert_select 'form ul', :count => 1
+    assert_select 'form ul li', :count => 3
+  end
+
+  test 'builder with collection support should not change the options hash' do
+    options = { :as => :check_boxes, :collection_wrapper_tag => :ul, :item_wrapper_tag => :li}
+    with_association_for @user, :tags, options
+
+    assert_select 'form ul', :count => 1
+    assert_select 'form ul li', :count => 3
+    assert_equal({ :as => :check_boxes, :collection_wrapper_tag => :ul, :item_wrapper_tag => :li},
+                 options)
+  end
+end

data/test/form_builder/button_test.rb

@@ -0,0 +1,47 @@
+# encoding: UTF-8
+require 'test_helper'
+
+class ButtonTest < ActionView::TestCase
+  def with_button_for(object, *args)
+    with_concat_form_for(object) do |f|
+      f.button(*args)
+    end
+  end
+
+  test 'builder should create buttons' do
+    with_button_for :post, :submit
+    assert_select 'form input.button[type=submit][value=Save Post]'
+  end
+
+  test 'builder should create buttons with options' do
+    with_button_for :post, :submit, :class => 'my_button'
+    assert_select 'form input.button.my_button[type=submit][value=Save Post]'
+  end
+
+  test 'builder should not modify the options hash' do
+    options = { :class => 'my_button' }
+    with_button_for :post, :submit, options
+    assert_select 'form input.button.my_button[type=submit][value=Save Post]'
+    assert_equal({ :class => 'my_button' }, options)
+  end
+
+  test 'builder should create buttons for records' do
+    @user.new_record!
+    with_button_for @user, :submit
+    assert_select 'form input.button[type=submit][value=Create User]'
+  end
+
+  test "builder should use the default class from the configuration" do
+    swap SimpleForm, :button_class => 'btn' do
+      with_button_for :post, :submit
+      assert_select 'form input.btn[type=submit][value=Save Post]'
+    end
+  end
+
+  if ActionView::Helpers::FormBuilder.method_defined?(:button)
+    test "allows to use Rails button helper when available" do
+      with_button_for :post, :button, 'Save!'
+      assert_select 'form button.button[type=submit]', 'Save!'
+    end
+  end
+end

data/test/{error_notification_test.rb → form_builder/error_notification_test.rb}

@@ -1,8 +1,8 @@
 # encoding: UTF-8
 require 'test_helper'
 
+# Tests for f.error_notification
 class ErrorNotificationTest < ActionView::TestCase
-
   def with_error_notification_for(object, options={}, &block)
     with_concat_form_for(object) do |f|
       f.error_notification(options)
@@ -11,6 +11,7 @@ class ErrorNotificationTest < ActionView::TestCase
 
   test 'error notification is not generated when the object has no error' do
     assert @validating_user.valid?
+
     with_error_notification_for @validating_user
     assert_no_select 'p.error_notification'
   end
@@ -59,4 +60,20 @@ class ErrorNotificationTest < ActionView::TestCase
       assert_select 'div.error_notification'
     end
   end
+
+  test 'error notification can contain HTML tags' do
+    with_error_notification_for @user, :message => 'Erro encontrado ao criar <b>usuário</b>'
+    assert_select 'p.error_notification', 'Erro encontrado ao criar usuário'
+    assert_select 'p.error_notification b', 'usuário'
+  end
+
+  test 'error notification uses I18n based on model to generate the notification message and accepts HTML' do
+    store_translations(:en, :simple_form => { :error_notification => { :user =>
+      'Alguns erros foram encontrados para o <b>usuário</b>:'
+    } }) do
+      with_error_notification_for @user
+      assert_select 'p.error_notification', 'Alguns erros foram encontrados para o usuário:'
+      assert_select 'p.error_notification b', 'usuário'
+    end
+  end
 end

data/test/form_builder/error_test.rb

@@ -0,0 +1,121 @@
+require 'test_helper'
+
+# Tests for f.error and f.full_error
+class ErrorTest < ActionView::TestCase
+  def with_error_for(object, *args)
+    with_concat_form_for(object) do |f|
+      f.error(*args)
+    end
+  end
+
+  def with_full_error_for(object, *args)
+    with_concat_form_for(object) do |f|
+      f.full_error(*args)
+    end
+  end
+
+  test 'error should not generate content for attribute without errors' do
+    with_error_for @user, :active
+    assert_no_select 'span.error'
+  end
+
+  test 'error should not generate messages when object is not present' do
+    with_error_for :project, :name
+    assert_no_select 'span.error'
+  end
+
+  test "error should not generate messages when object doesn't respond to errors method" do
+    @user.instance_eval { undef errors }
+    with_error_for @user, :name
+    assert_no_select 'span.error'
+  end
+
+  test 'error should generate messages for attribute with single error' do
+    with_error_for @user, :name
+    assert_select 'span.error', "can't be blank"
+  end
+
+  test 'error should generate messages for attribute with one error when using first' do
+    swap SimpleForm, :error_method => :first do
+      with_error_for @user, :age
+      assert_select 'span.error', 'is not a number'
+    end
+  end
+
+  test 'error should generate messages for attribute with several errors when using to_sentence' do
+    swap SimpleForm, :error_method => :to_sentence do
+      with_error_for @user, :age
+      assert_select 'span.error', 'is not a number and must be greater than 18'
+    end
+  end
+
+  test 'error should be able to pass html options' do
+    with_error_for @user, :name, :id => 'error', :class => 'yay'
+    assert_select 'span#error.error.yay'
+  end
+
+  test 'error should not modify the options hash' do
+    options = { :id => 'error', :class => 'yay' }
+    with_error_for @user, :name, options
+    assert_select 'span#error.error.yay'
+    assert_equal({ :id => 'error', :class => 'yay' }, options)
+  end
+
+  test 'error should find errors on attribute and association' do
+    with_error_for @user, :company_id, :as => :select,
+      :error_method => :to_sentence, :reflection => Association.new(Company, :company, {})
+    assert_select 'span.error', 'must be valid and company must be present'
+  end
+
+  test 'error should generate an error tag with a clean HTML' do
+    with_error_for @user, :name
+    assert_no_select 'span.error[error_html]'
+  end
+
+  test 'error should generate an error tag with a clean HTML when errors options are present' do
+    with_error_for @user, :name, :error_tag => :p, :error_prefix => 'Name', :error_method => :first
+    assert_no_select 'p.error[error_html]'
+    assert_no_select 'p.error[error_tag]'
+    assert_no_select 'p.error[error_prefix]'
+    assert_no_select 'p.error[error_method]'
+  end
+
+  test 'error should generate an error message with raw HTML tags' do
+    with_error_for @user, :name, :error_prefix => '<b>Name</b>'
+    assert_select 'span.error', "Name can't be blank"
+    assert_select 'span.error b', "Name"
+  end
+
+  # FULL ERRORS
+
+  test 'full error should generate an full error tag for the attribute' do
+    with_full_error_for @user, :name
+    assert_select 'span.error', "Super User Name! can't be blank"
+  end
+
+  test 'full error should generate an full error tag with a clean HTML' do
+    with_full_error_for @user, :name
+    assert_no_select 'span.error[error_html]'
+  end
+
+  test 'full error should allow passing options to full error tag' do
+    with_full_error_for @user, :name, :id => 'name_error', :error_prefix => "Your name"
+    assert_select 'span.error#name_error', "Your name can't be blank"
+  end
+
+  test 'full error should not modify the options hash' do
+    options = { :id => 'name_error' }
+    with_full_error_for @user, :name, options
+    assert_select 'span.error#name_error', "Super User Name! can't be blank"
+    assert_equal({ :id => 'name_error' }, options)
+  end
+
+  # CUSTOM WRAPPERS
+
+  test 'error with custom wrappers works' do
+    swap_wrapper do
+      with_error_for @user, :name
+      assert_select 'span.omg_error', "can't be blank"
+    end
+  end
+end