simple_form 1.5.2 → 2.0.0

data/test/form_builder/wrapper_test.rb

@@ -0,0 +1,149 @@
+require 'test_helper'
+
+class WrapperTest < ActionView::TestCase
+  test 'wrapper should not have error class for attribute without errors' do
+    with_form_for @user, :active
+    assert_no_select 'div.field_with_errors'
+  end
+
+  test 'wrapper should not have error class when object is not present' do
+    with_form_for :project, :name
+    assert_no_select 'div.field_with_errors'
+  end
+
+  test 'wrapper should add error class for attribute with errors' do
+    with_form_for @user, :name
+    assert_select 'div.field_with_errors'
+  end
+
+  test 'wrapper should add hint class for attribute with a hint' do
+    with_form_for @user, :name, :hint => 'hint'
+    assert_select 'div.field_with_hint'
+  end
+
+  test 'wrapper should not have disabled class by default' do
+    with_form_for @user, :active
+    assert_no_select 'div.disabled'
+  end
+
+  test 'wrapper should have disabled class when input is disabled' do
+    with_form_for @user, :active, :disabled => true
+    assert_select 'div.disabled'
+  end
+
+  test 'wrapper should support no wrapping when wrapper is false' do
+    with_form_for @user, :name, :wrapper => false
+    assert_select 'form > label[for=user_name]'
+    assert_select 'form > input#user_name.string'
+  end
+
+  test 'wrapper should support no wrapping when wrapper tag is false' do
+    with_form_for @user, :name, :wrapper => custom_wrapper_without_top_level
+    assert_select 'form > label[for=user_name]'
+    assert_select 'form > input#user_name.string'
+  end
+
+  test 'wrapper should wrapping tag adds required/optional css classes' do
+    with_form_for @user, :name
+    assert_select 'form div.input.required.string'
+
+    with_form_for @user, :age, :required => false
+    assert_select 'form div.input.optional.integer'
+  end
+
+  test 'wrapper should allow custom options to be given' do
+    with_form_for @user, :name, :wrapper_html => { :id => "super_cool", :class => 'yay' }
+    assert_select 'form #super_cool.required.string.yay'
+  end
+
+  test 'wrapper should allow tag to be given on demand' do
+    with_form_for @user, :name, :wrapper_tag => :b
+    assert_select 'form b.required.string'
+  end
+
+  test 'wrapper should allow wrapper class to be given on demand' do
+    with_form_for @user, :name, :wrapper_class => :wrapper
+    assert_select 'form div.wrapper.required.string'
+  end
+
+  test 'wrapper should skip additional classes when configured' do
+    swap SimpleForm, :generate_additional_classes_for => [:input, :label] do
+      with_form_for @user, :name, :wrapper_class => :wrapper
+      assert_select 'form div.wrapper'
+      assert_no_select 'div.required'
+      assert_no_select 'div.string'
+    end
+  end
+
+  # Custom wrapper test
+
+  test 'custom wrappers works' do
+    swap_wrapper do
+      with_form_for @user, :name, :hint => "cool"
+      assert_select "section.custom_wrapper div.another_wrapper label"
+      assert_select "section.custom_wrapper div.another_wrapper input.string"
+      assert_no_select "section.custom_wrapper div.another_wrapper span.omg_error"
+      assert_select "section.custom_wrapper div.error_wrapper span.omg_error"
+      assert_select "section.custom_wrapper > div.omg_hint", "cool"
+    end
+  end
+
+  test 'custom wrappers can be turned off' do
+    swap_wrapper do
+      with_form_for @user, :name, :another => false
+      assert_no_select "section.custom_wrapper div.another_wrapper label"
+      assert_no_select "section.custom_wrapper div.another_wrapper input.string"
+      assert_select "section.custom_wrapper div.error_wrapper span.omg_error"
+    end
+  end
+
+  test 'custom wrappers on a form basis' do
+    swap_wrapper :another do
+      concat simple_form_for(@user) { |f|
+        f.input :name
+      }
+
+      assert_no_select "section.custom_wrapper div.another_wrapper label"
+      assert_no_select "section.custom_wrapper div.another_wrapper input.string"
+
+      concat simple_form_for(@user, :wrapper => :another) { |f|
+        f.input :name
+      }
+
+      assert_select "section.custom_wrapper div.another_wrapper label"
+      assert_select "section.custom_wrapper div.another_wrapper input.string"
+    end
+  end
+
+  test 'custom wrappers on input basis' do
+    swap_wrapper :another do
+      with_form_for @user, :name
+      assert_no_select "section.custom_wrapper div.another_wrapper label"
+      assert_no_select "section.custom_wrapper div.another_wrapper input.string"
+      output_buffer.replace ""
+
+      with_form_for @user, :name, :wrapper => :another
+      assert_select "section.custom_wrapper div.another_wrapper label"
+      assert_select "section.custom_wrapper div.another_wrapper input.string"
+      output_buffer.replace ""
+    end
+
+    with_form_for @user, :name, :wrapper => custom_wrapper
+    assert_select "section.custom_wrapper div.another_wrapper label"
+    assert_select "section.custom_wrapper div.another_wrapper input.string"
+  end
+
+  test 'access wrappers with indifferent access' do
+    swap_wrapper :another do
+      with_form_for @user, :name, :wrapper => "another"
+      assert_select "section.custom_wrapper div.another_wrapper label"
+      assert_select "section.custom_wrapper div.another_wrapper input.string"
+    end
+  end
+
+  test 'raise error when wrapper not found' do
+    assert_raise SimpleForm::WrapperNotFound do
+      with_form_for @user, :name, :wrapper => :not_found
+    end
+  end
+end

data/test/generators/simple_form_generator_test.rb

@@ -0,0 +1,32 @@
+require 'test_helper'
+
+class SimpleFormGeneratorTest < Rails::Generators::TestCase
+  tests SimpleForm::Generators::InstallGenerator
+  destination File.expand_path('../../tmp', __FILE__)
+  setup :prepare_destination
+  teardown { rm_rf(destination_root) }
+
+  test 'generates example locale file' do
+    run_generator
+    assert_file 'config/locales/simple_form.en.yml'
+  end
+
+  test 'generates the simple_form initializer' do
+    run_generator
+    assert_file 'config/initializers/simple_form.rb',
+      /config\.default_wrapper = :default/, /config\.boolean_style = :nested/
+  end
+
+  test 'generates the simple_form initializer with the bootstrap wrappers' do
+    run_generator %w(--bootstrap)
+    assert_file 'config/initializers/simple_form.rb', /config\.wrappers :bootstrap/,
+      /config\.default_wrapper = :bootstrap/
+  end
+
+  %W(erb haml slim).each do |engine|
+    test "generates the scaffold template when using #{engine}" do
+      run_generator ['-e', engine]
+      assert_file "lib/templates/#{engine}/scaffold/_form.html.#{engine}"
+    end
+  end
+end

data/test/inputs/boolean_input_test.rb

@@ -0,0 +1,101 @@
+# encoding: UTF-8
+require 'test_helper'
+
+class BooleanInputTest < ActionView::TestCase
+  test 'input should generate a checkbox by default for boolean attributes' do
+    with_input_for @user, :active, :boolean
+    assert_select 'input[type=checkbox].boolean#user_active'
+    assert_select 'label.boolean.optional', 'Active'
+  end
+
+  test 'input does not generate the label with the checkbox when label option is false' do
+    with_input_for @user, :active, :boolean, :label => false
+    assert_select 'input[type=checkbox].boolean#user_active'
+    assert_no_select 'label'
+  end
+
+  test 'input uses inline boolean style by default' do
+    with_input_for @user, :active, :boolean
+    assert_select 'input.boolean + label.boolean.optional'
+    assert_no_select 'label > input'
+  end
+
+  test 'input allows changing default boolean style config to nested, generating a default label and a manual hidden field for checkbox' do
+    swap SimpleForm, :boolean_style => :nested do
+      with_input_for @user, :active, :boolean
+      assert_select 'label[for=user_active]', 'Active'
+      assert_select 'label.boolean > input.boolean'
+      assert_no_select 'input[type=checkbox] + label'
+    end
+  end
+
+  test 'input boolean with nested generates a manual hidden field for checkbox outside the label, to recreate Rails functionality with valid html5' do
+    swap SimpleForm, :boolean_style => :nested do
+      with_input_for @user, :active, :boolean
+
+      assert_select "input[type=hidden][name='user[active]'] + label.boolean > input.boolean"
+      assert_no_select 'input[type=checkbox] + label'
+    end
+  end
+
+  test 'input boolean with nested generates a disabled hidden field for checkbox outside the label, if the field is disabled' do
+    swap SimpleForm, :boolean_style => :nested do
+      with_input_for @user, :active, :boolean, :disabled => true
+
+      assert_select "input[type=hidden][name='user[active]'][disabled] + label.boolean > input.boolean[disabled]"
+    end
+  end
+
+  test 'input accepts changing boolean style to nested through given options' do
+    with_input_for @user, :active, :boolean, :boolean_style => :nested
+    assert_select 'label[for=user_active]', 'Active'
+    assert_select 'label.boolean > input.boolean'
+    assert_no_select 'input[type=checkbox] + label'
+  end
+
+  test 'input accepts changing boolean style to inline through given options, when default is nested' do
+    swap SimpleForm, :boolean_style => :nested do
+      with_input_for @user, :active, :boolean, :boolean_style => :inline
+      assert_select 'label[for=user_active]', 'Active'
+      assert_select 'input.boolean + label.boolean'
+      assert_no_select 'label > input'
+    end
+  end
+
+  test 'input with nested style allows disabling label' do
+    swap SimpleForm, :boolean_style => :nested do
+      with_input_for @user, :active, :boolean, :label => false
+      assert_select 'input.boolean'
+      assert_no_select 'label.boolean'
+    end
+  end
+
+  test 'input boolean works using :input only in wrapper config (no label_input)' do
+    swap_wrapper do
+      with_input_for @user, :active, :boolean
+
+      assert_select 'label.boolean + input[type=hidden] + input.boolean'
+      assert_no_select 'label.checkbox'
+    end
+  end
+
+  test 'input boolean with nested style works using :input only in wrapper config (no label_input), adding the extra "checkbox" label wrapper' do
+    swap_wrapper do
+      swap SimpleForm, :boolean_style => :nested do
+        with_input_for @user, :active, :boolean
+
+        assert_select 'label.boolean + input[type=hidden] + label.checkbox > input.boolean'
+      end
+    end
+  end
+
+  test 'input boolean with nested style works using :label_input in wrapper config, adding "checkbox" class to label' do
+    swap_wrapper :default, self.custom_wrapper_without_top_level do
+      swap SimpleForm, :boolean_style => :nested do
+        with_input_for @user, :active, :boolean
+
+        assert_select 'input[type=hidden] + label.boolean.checkbox > input.boolean'
+      end
+    end
+  end
+end

data/test/inputs/collection_check_boxes_input_test.rb

@@ -0,0 +1,224 @@
+# encoding: UTF-8
+require 'test_helper'
+
+class CollectionCheckBoxesInputTest < ActionView::TestCase
+  setup do
+    SimpleForm::Inputs::CollectionCheckBoxesInput.reset_i18n_cache :boolean_collection
+  end
+
+  test 'input check boxes should not include for attribute by default' do
+    with_input_for @user, :gender, :check_boxes, :collection => [:male, :female]
+    assert_select 'label'
+    assert_no_select 'label[for=user_gender]'
+  end
+
+  test 'input check boxes should include for attribute when giving as html option' do
+    with_input_for @user, :gender, :check_boxes, :collection => [:male, :female], :label_html => { :for => 'gender' }
+    assert_select 'label[for=gender]'
+  end
+
+  test 'collection input with check_boxes type should not generate required html attribute' do
+    with_input_for @user, :name, :check_boxes, :collection => ['Jose' , 'Carlos']
+    assert_select 'input.required'
+    assert_no_select 'input[required]'
+  end
+
+  test 'input should do automatic collection translation for check_box types using defaults key' do
+    store_translations(:en, :simple_form => { :options => { :defaults => {
+      :gender => { :male => 'Male', :female => 'Female'}
+    } } } ) do
+      with_input_for @user, :gender, :check_boxes, :collection => [:male, :female]
+      assert_select 'input[type=checkbox][value=male]'
+      assert_select 'input[type=checkbox][value=female]'
+      assert_select 'label.collection_check_boxes', 'Male'
+      assert_select 'label.collection_check_boxes', 'Female'
+    end
+  end
+
+  test 'input should do automatic collection translation for check_box types using specific object key' do
+    store_translations(:en, :simple_form => { :options => { :user => {
+      :gender => { :male => 'Male', :female => 'Female'}
+    } } } ) do
+      with_input_for @user, :gender, :check_boxes, :collection => [:male, :female]
+      assert_select 'input[type=checkbox][value=male]'
+      assert_select 'input[type=checkbox][value=female]'
+      assert_select 'label.collection_check_boxes', 'Male'
+      assert_select 'label.collection_check_boxes', 'Female'
+    end
+  end
+
+  test 'input check boxes does not wrap the collection by default' do
+    with_input_for @user, :active, :check_boxes
+
+    assert_select 'form input[type=checkbox]', :count => 2
+    assert_no_select 'form ul'
+  end
+
+  test 'input check boxes wraps the collection in the configured collection wrapper tag' do
+    swap SimpleForm, :collection_wrapper_tag => :ul do
+      with_input_for @user, :active, :check_boxes
+
+      assert_select 'form ul input[type=checkbox]', :count => 2
+    end
+  end
+
+  test 'input check boxes does not wrap the collection when configured with falsy values' do
+    swap SimpleForm, :collection_wrapper_tag => false do
+      with_input_for @user, :active, :check_boxes
+
+      assert_select 'form input[type=checkbox]', :count => 2
+      assert_no_select 'form ul'
+    end
+  end
+
+  test 'input check boxes allows overriding the collection wrapper tag at input level' do
+    swap SimpleForm, :collection_wrapper_tag => :ul do
+      with_input_for @user, :active, :check_boxes, :collection_wrapper_tag => :section
+
+      assert_select 'form section input[type=checkbox]', :count => 2
+      assert_no_select 'form ul'
+    end
+  end
+
+  test 'input check boxes allows disabling the collection wrapper tag at input level' do
+    swap SimpleForm, :collection_wrapper_tag => :ul do
+      with_input_for @user, :active, :check_boxes, :collection_wrapper_tag => false
+
+      assert_select 'form input[type=checkbox]', :count => 2
+      assert_no_select 'form ul'
+    end
+  end
+
+  test 'input check boxes renders the wrapper tag with the configured wrapper class' do
+    swap SimpleForm, :collection_wrapper_tag => :ul, :collection_wrapper_class => 'inputs-list' do
+      with_input_for @user, :active, :check_boxes
+
+      assert_select 'form ul.inputs-list input[type=checkbox]', :count => 2
+    end
+  end
+
+  test 'input check boxes allows giving wrapper class at input level only' do
+    swap SimpleForm, :collection_wrapper_tag => :ul do
+      with_input_for @user, :active, :check_boxes, :collection_wrapper_class => 'items-list'
+
+      assert_select 'form ul.items-list input[type=checkbox]', :count => 2
+    end
+  end
+
+  test 'input check boxes uses both configured and given wrapper classes for wrapper tag' do
+    swap SimpleForm, :collection_wrapper_tag => :ul, :collection_wrapper_class => 'inputs-list' do
+      with_input_for @user, :active, :check_boxes, :collection_wrapper_class => 'items-list'
+
+      assert_select 'form ul.inputs-list.items-list input[type=checkbox]', :count => 2
+    end
+  end
+
+  test 'input check boxes wraps each item in the configured item wrapper tag' do
+    swap SimpleForm, :item_wrapper_tag => :li do
+      with_input_for @user, :active, :check_boxes
+
+      assert_select 'form li input[type=checkbox]', :count => 2
+    end
+  end
+
+  test 'input check boxes does not wrap items when configured with falsy values' do
+    swap SimpleForm, :item_wrapper_tag => false do
+      with_input_for @user, :active, :check_boxes
+
+      assert_select 'form input[type=checkbox]', :count => 2
+      assert_no_select 'form li'
+    end
+  end
+
+  test 'input check boxes allows overriding the item wrapper tag at input level' do
+    swap SimpleForm, :item_wrapper_tag => :li do
+      with_input_for @user, :active, :check_boxes, :item_wrapper_tag => :dl
+
+      assert_select 'form dl input[type=checkbox]', :count => 2
+      assert_no_select 'form li'
+    end
+  end
+
+  test 'input check boxes allows disabling the item wrapper tag at input level' do
+    swap SimpleForm, :item_wrapper_tag => :ul do
+      with_input_for @user, :active, :check_boxes, :item_wrapper_tag => false
+
+      assert_select 'form input[type=checkbox]', :count => 2
+      assert_no_select 'form li'
+    end
+  end
+
+  test 'input check boxes wraps items in a span tag by default' do
+    with_input_for @user, :active, :check_boxes
+
+    assert_select 'form span input[type=checkbox]', :count => 2
+  end
+
+  test 'input check boxes renders the item wrapper tag with a default class "checkbox"' do
+    with_input_for @user, :active, :check_boxes, :item_wrapper_tag => :li
+
+    assert_select 'form li.checkbox input[type=checkbox]', :count => 2
+  end
+
+  test 'input check boxes renders the item wrapper tag with the configured item wrapper class' do
+    swap SimpleForm, :item_wrapper_tag => :li, :item_wrapper_class => 'item' do
+      with_input_for @user, :active, :check_boxes
+
+      assert_select 'form li.checkbox.item input[type=checkbox]', :count => 2
+    end
+  end
+
+  test 'input check boxes allows giving item wrapper class at input level only' do
+    swap SimpleForm, :item_wrapper_tag => :li do
+      with_input_for @user, :active, :check_boxes, :item_wrapper_class => 'item'
+
+      assert_select 'form li.checkbox.item input[type=checkbox]', :count => 2
+    end
+  end
+
+  test 'input check boxes uses both configured and given item wrapper classes for item wrapper tag' do
+    swap SimpleForm, :item_wrapper_tag => :li, :item_wrapper_class => 'item' do
+      with_input_for @user, :active, :check_boxes, :item_wrapper_class => 'inline'
+
+      assert_select 'form li.checkbox.item.inline input[type=checkbox]', :count => 2
+    end
+  end
+
+  test 'input check boxes respects the nested boolean style config, generating nested label > input' do
+    swap SimpleForm, :boolean_style => :nested do
+      with_input_for @user, :active, :check_boxes
+
+      assert_select 'label.checkbox > input#user_active_true[type=checkbox]'
+      assert_select 'label.checkbox', 'Yes'
+      assert_select 'label.checkbox > input#user_active_false[type=checkbox]'
+      assert_select 'label.checkbox', 'No'
+      assert_no_select 'label.collection_radio_buttons'
+    end
+  end
+
+  test 'input check boxes with nested style overrides configured item wrapper tag, forcing the :label' do
+    swap SimpleForm, :boolean_style => :nested, :item_wrapper_tag => :li do
+      with_input_for @user, :active, :check_boxes
+
+      assert_select 'label.checkbox > input'
+      assert_no_select 'li'
+    end
+  end
+
+  test 'input check boxes with nested style overrides given item wrapper tag, forcing the :label' do
+    swap SimpleForm, :boolean_style => :nested do
+      with_input_for @user, :active, :check_boxes, :item_wrapper_tag => :li
+
+      assert_select 'label.checkbox > input'
+      assert_no_select 'li'
+    end
+  end
+
+  test 'input check boxes with nested style accepts giving extra wrapper classes' do
+    swap SimpleForm, :boolean_style => :nested do
+      with_input_for @user, :active, :check_boxes, :item_wrapper_class => "inline"
+
+      assert_select 'label.checkbox.inline > input'
+    end
+  end
+end