shopify_api 9.2.0 → 9.5

data/test/collection_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class CollectionTest < Test::Unit::TestCase
@@ -6,23 +7,23 @@ class CollectionTest < Test::Unit::TestCase
     ShopifyAPI::Base.activate_session(available_version)
 
     fake(
-        'collections',
-        url: 'https://shop2.myshopify.com/admin/api/2020-01/collections/1.json',
-        method: :get,
-        status: 200,
-        body: load_fixture('collection'),
-        extension: false
+      'collections',
+      url: 'https://shop2.myshopify.com/admin/api/2020-01/collections/1.json',
+      method: :get,
+      status: 200,
+      body: load_fixture('collection'),
+      extension: false
     )
 
     collection = ShopifyAPI::Collection.find(1)
 
     fake(
-        'products',
-        url: 'https://shop2.myshopify.com/admin/api/2020-01/collections/1/products.json',
-        method: :get,
-        status: 200,
-        body: load_fixture('collection_products'),
-        extension: false
+      'products',
+      url: 'https://shop2.myshopify.com/admin/api/2020-01/collections/1/products.json',
+      method: :get,
+      status: 200,
+      body: load_fixture('collection_products'),
+      extension: false
     )
     assert_equal [632910392, 921728736], collection.products.map(&:id)
   end
@@ -32,17 +33,17 @@ class CollectionTest < Test::Unit::TestCase
     ShopifyAPI::Base.activate_session(old_version)
 
     fake(
-        'collections',
-        url: 'https://shop2.myshopify.com/admin/api/2019-10/collections/1.json',
-        method: :get,
-        status: 200,
-        body: load_fixture('collection'),
-        extension: false
+      'collections',
+      url: 'https://shop2.myshopify.com/admin/api/2019-10/collections/1.json',
+      method: :get,
+      status: 200,
+      body: load_fixture('collection'),
+      extension: false
     )
 
     collection = ShopifyAPI::Collection.find(1)
 
-    assert_raises NotImplementedError do
+    assert_raises(NotImplementedError) do
       collection.products
     end
   end

data/test/countable_test.rb

@@ -1,13 +1,14 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class CountableTest < Test::Unit::TestCase
   def setup
     super
-    fake "products/count", :body => '{"count": 16}'
+    fake("products/count", body: '{"count": 16}')
   end
 
   def test_count_products
     count = ShopifyAPI::Product.count
-    assert_equal 16, count
+    assert_equal(16, count)
   end
 end

data/test/currency_test.rb

@@ -4,17 +4,17 @@ require 'test_helper'
 class CurrencyTest < Test::Unit::TestCase
   def setup
     super
-    fake "currencies", method: :get, body: load_fixture('currencies')
+    fake("currencies", method: :get, body: load_fixture('currencies'))
   end
 
   context "Currency" do
     should 'return a list of enabled currencies' do
       currencies = ShopifyAPI::Currency.all
-      assert_equal 4, currencies.count
-      assert_equal %w(AUD EUR GBP HKD), currencies.map(&:currency)
-      assert_equal [true, true, true, false], currencies.map(&:enabled)
+      assert_equal(4, currencies.count)
+      assert_equal(%w(AUD EUR GBP HKD), currencies.map(&:currency))
+      assert_equal([true, true, true, false], currencies.map(&:enabled))
       currencies.each do |currency|
-        assert_equal "2018-10-03T14:44:08-04:00", currency.rate_updated_at
+        assert_equal("2018-10-03T14:44:08-04:00", currency.rate_updated_at)
       end
     end
   end

data/test/custom_collection_test.rb

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class CustomCollectionTest < Test::Unit::TestCase
   test "#create should create a custom collection" do
-    fake "custom_collections", :method => :post, :status => 201, :body => load_fixture('custom_collection')
-    link = ShopifyAPI::CustomCollection.create(:title => "Macbooks", :image => { :src => "http://example.com/rails_logo.gif" })
-    assert_equal 1063001463, link.id
+    fake("custom_collections", method: :post, status: 201, body: load_fixture('custom_collection'))
+    link = ShopifyAPI::CustomCollection.create(title: "Macbooks", image: { src: "http://example.com/rails_logo.gif" })
+    assert_equal(1063001463, link.id)
   end
 end

data/test/customer_saved_search_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class CustomerSavedSearchTest < Test::Unit::TestCase
@@ -7,21 +8,30 @@ class CustomerSavedSearchTest < Test::Unit::TestCase
   end
 
   def test_get_customers_from_customer_saved_search
-    fake 'customers/search.json?customer_saved_search_id=8899730', :body => load_fixture('customer_saved_search_customers'), :extension => false
-    assert_equal 1, @customer_saved_search.customers.length
-    assert_equal 112223902, @customer_saved_search.customers.first.id
+    fake(
+      'customers/search.json?customer_saved_search_id=8899730',
+      body: load_fixture('customer_saved_search_customers'),
+      extension: false
+    )
+    assert_equal(1, @customer_saved_search.customers.length)
+    assert_equal(112223902, @customer_saved_search.customers.first.id)
   end
 
   def test_get_customers_from_customer_saved_search_with_params
-    fake 'customers/search.json?customer_saved_search_id=8899730&limit=1', :body => load_fixture('customer_saved_search_customers'), :extension => false
-    customers = @customer_saved_search.customers(:limit => 1)
-    assert_equal 1, customers.length
-    assert_equal 112223902, customers.first.id
+    fake(
+      'customers/search.json?customer_saved_search_id=8899730&limit=1',
+      body: load_fixture('customer_saved_search_customers'),
+      extension: false
+    )
+    customers = @customer_saved_search.customers(limit: 1)
+    assert_equal(1, customers.length)
+    assert_equal(112223902, customers.first.id)
   end
 
   private
+
   def load_customer_saved_search
-    fake 'customer_saved_searches/8899730', :body => load_fixture('customer_saved_search')
+    fake('customer_saved_searches/8899730', body: load_fixture('customer_saved_search'))
     @customer_saved_search = ShopifyAPI::CustomerSavedSearch.find(8899730)
   end
 end

data/test/customer_test.rb

@@ -1,50 +1,58 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class CustomerTest < Test::Unit::TestCase
   def setup
     super
 
-    fake 'customers/207119551', body: load_fixture('customers')
+    fake('customers/207119551', body: load_fixture('customers'))
 
     @customer = ShopifyAPI::Customer.find(207119551)
   end
 
   test "search should get a customers collection" do
-    fake "customers/search.json?query=Bob+country%3AUnited+States", :extension => false, :body => load_fixture('customers_search')
+    fake(
+      "customers/search.json?query=Bob+country%3AUnited+States",
+      extension: false,
+      body: load_fixture('customers_search')
+    )
 
     results = ShopifyAPI::Customer.search(query: 'Bob country:United States')
-    assert_equal 'Bob', results.first.first_name
+    assert_equal('Bob', results.first.first_name)
   end
 
   test "account_activation_url should create an account activation url" do
-    fake "customers/207119551/account_activation_url", :method => :post, :body => load_fixture('customers_account_activation_url')
+    fake(
+      "customers/207119551/account_activation_url",
+      method: :post,
+      body: load_fixture('customers_account_activation_url')
+    )
 
     activation_url = "http://apple.myshopify.com/account/activate/207119551/86688abf23572680740b1c062fa37111-1458248616"
-    assert_equal activation_url, @customer.account_activation_url
+    assert_equal(activation_url, @customer.account_activation_url)
   end
 
   test "#send_invite with no params" do
     customer_invite_fixture = load_fixture('customer_invite')
     customer_invite = ActiveSupport::JSON.decode(customer_invite_fixture)
-    fake 'customers/207119551/send_invite', method: :post, body: customer_invite_fixture
+    fake('customers/207119551/send_invite', method: :post, body: customer_invite_fixture)
 
     customer_invite_response = @customer.send_invite
 
-    assert_equal '{"customer_invite":{}}', WebMock.last_request.body
-    assert_kind_of ShopifyAPI::CustomerInvite, customer_invite_response
-    assert_equal customer_invite['customer_invite']['to'], customer_invite_response.to
+    assert_equal('{"customer_invite":{}}', WebMock.last_request.body)
+    assert_kind_of(ShopifyAPI::CustomerInvite, customer_invite_response)
+    assert_equal(customer_invite['customer_invite']['to'], customer_invite_response.to)
   end
 
   test "#send_invite with params" do
     customer_invite_fixture = load_fixture('customer_invite')
     customer_invite = ActiveSupport::JSON.decode(customer_invite_fixture)
-    fake 'customers/207119551/send_invite', method: :post, body: customer_invite_fixture
-
+    fake('customers/207119551/send_invite', method: :post, body: customer_invite_fixture)
 
     customer_invite_response = @customer.send_invite(ShopifyAPI::CustomerInvite.new(customer_invite['customer_invite']))
 
-    assert_equal customer_invite, ActiveSupport::JSON.decode(WebMock.last_request.body)
-    assert_kind_of ShopifyAPI::CustomerInvite, customer_invite_response
-    assert_equal customer_invite['customer_invite']['to'], customer_invite_response.to
+    assert_equal(customer_invite, ActiveSupport::JSON.decode(WebMock.last_request.body))
+    assert_kind_of(ShopifyAPI::CustomerInvite, customer_invite_response)
+    assert_equal(customer_invite['customer_invite']['to'], customer_invite_response.to)
   end
 end

data/test/detailed_log_subscriber_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 require "active_support/log_subscriber/test_helper"
 require 'json'
@@ -9,18 +10,21 @@ class LogSubscriberTest < Test::Unit::TestCase
 
   def setup
     super
-    @page = { :page => { :id => 1, :title => 'Shopify API' } }.to_json
-    @ua_header = "\"User-Agent\"=>\"ShopifyAPI/#{ShopifyAPI::VERSION} ActiveResource/#{ActiveResource::VERSION::STRING} Ruby/#{RUBY_VERSION}\""
+    @page = { page: { id: 1, title: 'Shopify API' } }.to_json
+    @ua_header = "\"User-Agent\"=>\"ShopifyAPI/#{ShopifyAPI::VERSION} " \
+      "ActiveResource/#{ActiveResource::VERSION::STRING} Ruby/#{RUBY_VERSION}\""
     @request_headers = "Headers: {\"Accept\"=>\"application/json\", " \
-      "#{@ua_header}, \"X-Shopify-Access-Token\"=>\"access_token\"}"
+      "#{@ua_header}, \"X-Shopify-Access-Token\"=>\"[FILTERED]\"}"
 
     ShopifyAPI::Base.clear_session
-    fake("apis",
+    fake(
+      "apis",
       url: "https://app.shopify.com/services/apis.json",
       method: :get,
       status: 200,
       api_version: :stub,
-      body: load_fixture('apis'))
+      body: load_fixture('apis')
+    )
     ShopifyAPI::ApiVersion.fetch_known_versions
     session = ShopifyAPI::Session.new(
       domain: "https://this-is-my-test-shop.myshopify.com",
@@ -30,8 +34,8 @@ class LogSubscriberTest < Test::Unit::TestCase
 
     ShopifyAPI::Base.activate_session(session)
 
-    ActiveResource::LogSubscriber.attach_to :active_resource
-    ActiveResource::DetailedLogSubscriber.attach_to :active_resource_detailed
+    ActiveResource::LogSubscriber.attach_to(:active_resource)
+    ActiveResource::DetailedLogSubscriber.attach_to(:active_resource_detailed)
   end
 
   def teardown
@@ -45,7 +49,7 @@ class LogSubscriberTest < Test::Unit::TestCase
   end
 
   test "logging on #find" do
-    fake "pages/1", :method => :get, :body => @page
+    fake("pages/1", method: :get, body: @page)
 
     ShopifyAPI::Page.find(1)
 
@@ -64,9 +68,9 @@ class LogSubscriberTest < Test::Unit::TestCase
   end
 
   test "logging on #find with an error" do
-    fake "pages/2", :method => :get, :body => nil, :status => 404
+    fake("pages/2", method: :get, body: nil, status: 404)
 
-    assert_raises ActiveResource::ResourceNotFound do
+    assert_raises(ActiveResource::ResourceNotFound) do
       ShopifyAPI::Page.find(2)
     end
 
@@ -103,7 +107,7 @@ class LogSubscriberTest < Test::Unit::TestCase
 
     ShopifyAPI::Page.find(1)
 
-    assert_equal 1, @logger.logged(:warn).size
+    assert_equal(1, @logger.logged(:warn).size)
 
     assert_match(
       %r{\[DEPRECATED\] ShopifyAPI made a call to GET /admin/api/2019-01/pages/1.json},
@@ -125,7 +129,7 @@ class LogSubscriberTest < Test::Unit::TestCase
 
     ShopifyAPI::Page.find(1)
 
-    assert_equal 1, @logger.logged(:warn).size
+    assert_equal(1, @logger.logged(:warn).size)
 
     assert_match(
       %r{\[API Version Warning\] ShopifyAPI made a call to GET /admin/api/2019-01/pages/1.json},

data/test/discount_code_batch_test.rb

@@ -4,30 +4,31 @@ require 'test_helper'
 class DiscountCodeBatchTest < Test::Unit::TestCase
   def setup
     super
-    fake 'price_rules/102586120/batch/989355119', body: load_fixture('discount_code_batch')
+    fake('price_rules/102586120/batch/989355119', body: load_fixture('discount_code_batch'))
   end
 
   def test_get_batch
-    batch = ShopifyAPI::DiscountCodeBatch.find 989355119, params: { price_rule_id: 102586120 }
+    batch = ShopifyAPI::DiscountCodeBatch.find(989355119, params: { price_rule_id: 102586120 })
 
-    assert_equal 989355119, batch.id
+    assert_equal(989355119, batch.id)
   end
 
   def test_get_batch_discount_codes
-    fake 'price_rules/102586120/batch/989355119/discount_codes',
+    fake(
+      'price_rules/102586120/batch/989355119/discount_codes',
       method: :get,
       status: 200,
       body: load_fixture('discount_code_batch_discount_codes')
-
-    batch = ShopifyAPI::DiscountCodeBatch.find 989355119, params: { price_rule_id: 102586120 }
+    )
+    batch = ShopifyAPI::DiscountCodeBatch.find(989355119, params: { price_rule_id: 102586120 })
     discount_code_job = batch.discount_code_job
 
-    assert_equal 3, discount_code_job.count
-    assert discount_code_job[2].errors.present?
+    assert_equal(3, discount_code_job.count)
+    assert(discount_code_job[2].errors.present?)
   end
 
   def test_create_batch
-    fake 'price_rules/102586120/batch', method: :post, status: 201, body: load_fixture('discount_code_batch')
+    fake('price_rules/102586120/batch', method: :post, status: 201, body: load_fixture('discount_code_batch'))
     batch = ShopifyAPI::DiscountCodeBatch.new
     batch.prefix_options[:price_rule_id] = 102586120
     discount_codes = [{ "code": "SUMMER1" }, { "code": "SUMMER2" }, { "code": "SUMMER3" }]
@@ -35,6 +36,6 @@ class DiscountCodeBatchTest < Test::Unit::TestCase
     batch.save
 
     expected_body = { discount_codes: discount_codes }.to_json
-    assert_equal expected_body, WebMock.last_request.body
+    assert_equal(expected_body, WebMock.last_request.body)
   end
 end

data/test/discount_code_test.rb

@@ -1,36 +1,37 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class DiscountCodeTest < Test::Unit::TestCase
   def setup
     super
-    fake 'price_rules/102586120/discount_codes/1002091923', body: load_fixture('discount_code')
+    fake('price_rules/102586120/discount_codes/1002091923', body: load_fixture('discount_code'))
 
-    @discount_code = ShopifyAPI::DiscountCode.find(1002091923, params: {price_rule_id: 102586120})
+    @discount_code = ShopifyAPI::DiscountCode.find(1002091923, params: { price_rule_id: 102586120 })
   end
 
   def test_get_discount_code
-    fake 'price_rules/102586120/discount_codes', method: :get, status: 200, body: load_fixture('discount_code')
-    discount_code = ShopifyAPI::DiscountCode.find 1002091923, params: { price_rule_id: 102586120 }
+    fake('price_rules/102586120/discount_codes', method: :get, status: 200, body: load_fixture('discount_code'))
+    discount_code = ShopifyAPI::DiscountCode.find(1002091923, params: { price_rule_id: 102586120 })
 
-    assert_equal 1002091923, discount_code.id
+    assert_equal(1002091923, discount_code.id)
   end
 
   def test_get_all_discount_codes
-    fake 'price_rules/102586120/discount_codes', method: :get, status: 200, body: load_fixture('discount_codes')
-    discount_codes = ShopifyAPI::DiscountCode.all params: { price_rule_id: 102586120 }
+    fake('price_rules/102586120/discount_codes', method: :get, status: 200, body: load_fixture('discount_codes'))
+    discount_codes = ShopifyAPI::DiscountCode.all(params: { price_rule_id: 102586120 })
 
-    assert_equal 1, discount_codes.length
-    assert_equal 1002091923, discount_codes.first.id
+    assert_equal(1, discount_codes.length)
+    assert_equal(1002091923, discount_codes.first.id)
   end
 
   def test_create_discount_code
-    fake 'price_rules/102586120/discount_codes', method: :post, status: 201, body: load_fixture('discount_code')
+    fake('price_rules/102586120/discount_codes', method: :post, status: 201, body: load_fixture('discount_code'))
     discount_code = ShopifyAPI::DiscountCode.new
     discount_code.prefix_options[:price_rule_id] = 102586120
     discount_code.code = "SUMMERSALE10"
     discount_code.save
 
-    assert_equal '{"discount_code":{"code":"SUMMERSALE10"}}', WebMock.last_request.body
+    assert_equal('{"discount_code":{"code":"SUMMERSALE10"}}', WebMock.last_request.body)
   end
 
   def test_update_discount_code
@@ -38,16 +39,21 @@ class DiscountCodeTest < Test::Unit::TestCase
     discount_code_response['discount_code']['code'] = "WINTERSALE50"
     @discount_code.code = "WINTERSALE50"
 
-    fake 'price_rules/102586120/discount_codes/1002091923', method: :put, status: 200, body: ActiveSupport::JSON.encode(discount_code_response)
+    fake(
+      'price_rules/102586120/discount_codes/1002091923',
+      method: :put,
+      status: 200,
+      body: ActiveSupport::JSON.encode(discount_code_response)
+    )
 
     @discount_code.save
 
-    assert_equal discount_code_response['discount_code']['code'], @discount_code.code
+    assert_equal(discount_code_response['discount_code']['code'], @discount_code.code)
   end
 
   def test_delete_discount_code
-    fake 'price_rules/102586120/discount_codes/1002091923', method: :delete, body: 'destroyed'
+    fake('price_rules/102586120/discount_codes/1002091923', method: :delete, body: 'destroyed')
 
-    assert @discount_code.destroy
+    assert(@discount_code.destroy)
   end
 end