shopify_api 9.2.0 → 9.5

data/test/test_helper.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'rubygems'
 require 'minitest/autorun'
 require 'webmock/minitest'
@@ -23,7 +24,7 @@ module Test
         self.test("should_#{string}", &block)
       end
 
-      def self.context(string)
+      def self.context(_string)
         yield
       end
 
@@ -34,6 +35,7 @@ module Test
             const = mod.const_get(const)
             const.format = :json if const.respond_to?(:format=)
           rescue NameError
+            # Do nothing
           end
         end
 
@@ -68,7 +70,7 @@ module Test
 
       # Custom Assertions
       def assert_not(expression)
-        refute expression, "Expected <#{expression}> to be false!"
+        refute(expression, "Expected <#{expression}> to be false!")
       end
 
       def assert_nothing_raised
@@ -76,30 +78,30 @@ module Test
       end
 
       def assert_not_includes(array, value)
-        refute array.include?(value)
+        refute(array.include?(value))
       end
 
       def assert_includes(array, value)
-        assert array.include?(value)
+        assert(array.include?(value))
       end
 
-      def load_fixture(name, format=:json)
+      def load_fixture(name, format = :json)
         File.read(File.dirname(__FILE__) + "/fixtures/#{name}.#{format}")
       end
 
       def assert_request_body(expected)
-        assert_equal expected, WebMock.last_request.body
+        assert_equal(expected, WebMock.last_request.body)
       end
 
-      def fake(endpoint, options={})
-        request_body = options.has_key?(:request_body) ? options.delete(:request_body) : nil
-        body   = options.has_key?(:body) ? options.delete(:body) : load_fixture(endpoint)
+      def fake(endpoint, options = {})
+        request_body = options.key?(:request_body) ? options.delete(:request_body) : nil
+        body = options.key?(:body) ? options.delete(:body) : load_fixture(endpoint)
         format = options.delete(:format) || :json
         method = options.delete(:method) || :get
         api_version = options.delete(:api_version) || ShopifyAPI::ApiVersion.find_version('2019-01')
-        extension = ".#{options.delete(:extension)||'json'}" unless options[:extension]==false
+        extension = ".#{options.delete(:extension) || 'json'}" unless options[:extension] == false
         status = options.delete(:status) || 200
-        url = if options.has_key?(:url)
+        url = if options.key?(:url)
           options[:url]
         else
           "https://this-is-my-test-shop.myshopify.com#{api_version.construct_api_path("#{endpoint}#{extension}")}"

data/test/transaction_test.rb

@@ -1,16 +1,17 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class TransactionTest < Test::Unit::TestCase
   def setup
     super
-    fake "orders/450789469/transactions/389404469", :method => :get, :body => load_fixture('transaction')
+    fake("orders/450789469/transactions/389404469", method: :get, body: load_fixture('transaction'))
   end
 
   context "Transaction" do
     context "#find" do
       should "find a specific transaction" do
-        transaction = ShopifyAPI::Transaction.find(389404469, :params => {:order_id => 450789469})
-        assert_equal "409.94", transaction.amount
+        transaction = ShopifyAPI::Transaction.find(389404469, params: { order_id: 450789469 })
+        assert_equal("409.94", transaction.amount)
       end
     end
   end

data/test/usage_charge_test.rb

@@ -1,21 +1,25 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class UsageChargeTest < Test::Unit::TestCase
-
   def test_create_usage_charges
-    fake "recurring_application_charges/654381177/usage_charges", method: :post, body: load_fixture('usage_charge')
+    fake("recurring_application_charges/654381177/usage_charges", method: :post, body: load_fixture('usage_charge'))
 
     usage_charge = ShopifyAPI::UsageCharge.new(description: '1000 emails', price: 1.0)
-    usage_charge.prefix_options = {recurring_application_charge_id: 654381177}
-    assert usage_charge.save
+    usage_charge.prefix_options = { recurring_application_charge_id: 654381177 }
+    assert(usage_charge.save)
   end
 
   def test_get_usage_charges
-    fake "recurring_application_charges/654381177/usage_charges/359376002", method: :get, status: 201, body: load_fixture('usage_charge')
+    fake(
+      "recurring_application_charges/654381177/usage_charges/359376002",
+      method: :get,
+      status: 201,
+      body: load_fixture('usage_charge')
+    )
 
-    usage_charge = ShopifyAPI::UsageCharge.find(359376002, params: {recurring_application_charge_id: 654381177})
+    usage_charge = ShopifyAPI::UsageCharge.find(359376002, params: { recurring_application_charge_id: 654381177 })
 
-    assert_equal "1000 emails", usage_charge.description
+    assert_equal("1000 emails", usage_charge.description)
   end
-
 end

data/test/user_test.rb

@@ -1,16 +1,17 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class UserTest < Test::Unit::TestCase
   test 'get should get a user' do
     fake 'users/799407056', method: :get, status: 200, body: load_fixture('user')
-    
+
     user = ShopifyAPI::User.find(799407056)
     assert_equal 799407056, user.id
   end
-  
+
   test 'get should get all users' do
     fake 'users', method: :get, status: 200, body: load_fixture('users')
-    
+
     users = ShopifyAPI::User.all
     assert_equal 799407056, users.first.id
   end

data/test/variant_test.rb

@@ -1,60 +1,44 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class VariantTest < Test::Unit::TestCase
   def setup
     super
-    fake "products/632910392/variants/808950810", method: :get, body: load_fixture('variant')
-    @variant = ShopifyAPI::Variant.find(808950810, :params => {:product_id => 632910392})
+    refresh_variant
   end
 
   def test_get_variants
-    fake "products/632910392/variants", :method => :get, :body => load_fixture('variants')
+    fake("products/632910392/variants", method: :get, body: load_fixture('variants'))
 
-    variants = ShopifyAPI::Variant.find(:all, :params => { :product_id => 632910392 })
-    assert_equal variants.map(&:id).sort, [39072856, 49148385, 457924702, 808950810]
+    variants = ShopifyAPI::Variant.find(:all, params: { product_id: 632910392 })
+    assert_equal(variants.map(&:id).sort, [39072856, 49148385, 457924702, 808950810])
   end
 
   def test_get_variant_namespaced
-    assert_equal 632910392, @variant.product_id
+    assert_equal(632910392, @variant.product_id)
   end
 
   def test_get_variant
-    assert_equal 632910392, @variant.product_id
+    assert_equal(632910392, @variant.product_id)
   end
 
   def test_product_id_should_be_accessible_if_via_product_endpoint
-    assert_equal 632910392, @variant.product_id
+    assert_equal(632910392, @variant.product_id)
   end
 
   def test_product_id_should_be_accessible_if_via_variant_endpoint
-    assert_equal 632910392, @variant.product_id
+    assert_equal(632910392, @variant.product_id)
   end
 
   def test_delete_variant
-    fake "products/632910392/variants/808950810", :method => :delete, :body => 'destroyed'
-    assert @variant.destroy
+    fake("products/632910392/variants/808950810", method: :delete, body: 'destroyed')
+    assert(@variant.destroy)
   end
 
-  def test_deprecated_inventory_fields_are_included_in_2019_07
-    ShopifyAPI::Base.api_version = '2019-07'
-    assert @variant.as_json.include?('inventory_quantity')
-  end
-
-  def test_deprecated_inventory_fields_are_removed_in_2020_01
+  def test_read_only_inventory_quantity
     ShopifyAPI::Base.api_version = '2020-01'
-    refute @variant.as_json.include?('inventory_quantity')
-  end
-
-  def test_setting_variant_inventory_quantity_adjustment_passes_in_api_before_2019_10
-    ShopifyAPI::Base.api_version = '2019-07'
-    @variant.inventory_quantity_adjustment = 8
-  end
-
-  def test_setting_variant_inventory_quantity_adjustment_fails_in_2019_10_api
-    ShopifyAPI::Base.api_version = '2019-10'
-    assert_raises(ShopifyAPI::ValidationException) do
-      @variant.inventory_quantity_adjustment = 8
-    end
+    refresh_variant(api_version: ShopifyAPI::Base.api_version)
+    assert_equal(10, @variant.inventory_quantity)
   end
 
   def test_setting_variant_inventory_quantity_adjustment_fails_in_the_unstable_api
@@ -64,18 +48,6 @@ class VariantTest < Test::Unit::TestCase
     end
   end
 
-  def test_setting_variant_inventory_quantity_passes_in_api_before_2019_10
-    ShopifyAPI::Base.api_version = '2019-07'
-    @variant.inventory_quantity = 8
-  end
-
-  def test_setting_variant_inventory_quantity_fails_in_2019_10_api
-    ShopifyAPI::Base.api_version = '2019-10'
-    assert_raises(ShopifyAPI::ValidationException) do
-      @variant.inventory_quantity = 8
-    end
-  end
-
   def test_setting_variant_inventory_quantity_fails_in_the_unstable_api
     ShopifyAPI::Base.api_version = :unstable
     assert_raises(ShopifyAPI::ValidationException) do
@@ -83,22 +55,19 @@ class VariantTest < Test::Unit::TestCase
     end
   end
 
-  def test_setting_variant_old_inventory_quantity_passes_in_api_before_2019_10
-    ShopifyAPI::Base.api_version = '2019-07'
-    @variant.old_inventory_quantity = 8
-  end
-
-  def test_setting_variant_old_inventory_quantity_fails_in_2019_10_api
-    ShopifyAPI::Base.api_version = '2019-10'
-    assert_raises(ShopifyAPI::ValidationException) do
-      @variant.old_inventory_quantity = 8
-    end
-  end
-
   def test_setting_variant_old_inventory_quantity_fails_in_the_unstable_api
     ShopifyAPI::Base.api_version = :unstable
     assert_raises(ShopifyAPI::ValidationException) do
       @variant.old_inventory_quantity = 8
     end
   end
+
+  private
+
+  def refresh_variant(api_version: nil)
+    fake(
+      "products/632910392/variants/808950810", method: :get, body: load_fixture('variant'), api_version: api_version
+    )
+    @variant = ShopifyAPI::Variant.find(808950810, params: { product_id: 632910392 })
+  end
 end

data/test/webhook_test.rb

@@ -1,21 +1,24 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class WebhookTest < Test::Unit::TestCase
   test 'create should create a webhook' do
-    fake 'webhooks', :method => :post, :status => 201, :body => load_fixture('webhook')
-    webhook = ShopifyAPI::Webhook.create(address: "http://www.yoloship.it/webhook", topic: "orders/create", format: "json")
-    assert_equal "http://www.yoloship.it/webhook", webhook.address
+    fake('webhooks', method: :post, status: 201, body: load_fixture('webhook'))
+    webhook = ShopifyAPI::Webhook.create(
+      address: "http://www.yoloship.it/webhook", topic: "orders/create", format: "json"
+    )
+    assert_equal("http://www.yoloship.it/webhook", webhook.address)
   end
 
   test 'get should retrieve a webhook' do
-    fake 'webhooks/123456', :method => :get, :status => 200, :body => load_fixture('webhook')
+    fake('webhooks/123456', method: :get, status: 200, body: load_fixture('webhook'))
     webhook = ShopifyAPI::Webhook.find(123456)
-    assert_equal "http://www.yoloship.it/webhook", webhook.address
+    assert_equal("http://www.yoloship.it/webhook", webhook.address)
   end
 
   test 'find all should return all webhooks' do
-    fake 'webhooks', :method => :get, :status => 200, :body => load_fixture('webhooks')
+    fake('webhooks', method: :get, status: 200, body: load_fixture('webhooks'))
     webhook = ShopifyAPI::Webhook.all
-    assert_equal 123456, webhook.first.id
+    assert_equal(123456, webhook.first.id)
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shopify_api
 version: !ruby/object:Gem::Version
-  version: 9.2.0
+  version: '9.5'
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-07-14 00:00:00.000000000 Z
+date: 2021-10-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activeresource
@@ -58,6 +58,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: webrick
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
@@ -92,14 +106,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '5.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '5.14'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -129,7 +143,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: rubocop-shopify
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -170,10 +184,11 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: The Shopify API gem allows Ruby developers to programmatically access
-  the admin section of Shopify stores. The API is implemented as JSON or XML over
-  HTTP using all four verbs (GET/POST/PUT/DELETE). Each resource, like Order, Product,
-  or Collection, has its own URL and is manipulated in isolation.
+description: |
+  The Shopify API gem allows Ruby developers to programmatically access the admin
+  section of Shopify stores. The API is implemented as JSON or XML over HTTP using
+  all four verbs (GET/POST/PUT/DELETE). Each resource, like Order, Product, or
+  Collection, has its own URL and is manipulated in isolation.
 email: developers@jadedpixel.com
 executables: []
 extensions: []
@@ -183,15 +198,17 @@ extra_rdoc_files:
 files:
 - ".document"
 - ".github/CODEOWNERS"
+- ".github/ISSUE_TEMPLATE.md"
 - ".github/probots.yml"
+- ".github/workflows/build.yml"
 - ".gitignore"
-- ".rubocop-https---shopify-github-io-ruby-style-guide-rubocop-yml"
 - ".rubocop.yml"
-- ".travis.yml"
+- ".rubocop_todo.yml"
 - CHANGELOG.md
 - CONTRIBUTING.md
 - CONTRIBUTORS
 - Gemfile
+- Gemfile.lock
 - Gemfile_ar41
 - Gemfile_ar50
 - Gemfile_ar51
@@ -201,6 +218,7 @@ files:
 - RELEASING
 - Rakefile
 - SECURITY.md
+- dev.yml
 - docker-compose.yml
 - docs/_config.yml
 - docs/_includes/footer.html
@@ -212,6 +230,7 @@ files:
 - lib/active_resource/detailed_log_subscriber.rb
 - lib/active_resource/json_errors.rb
 - lib/shopify_api.rb
+- lib/shopify_api/api_access.rb
 - lib/shopify_api/api_version.rb
 - lib/shopify_api/connection.rb
 - lib/shopify_api/countable.rb
@@ -221,6 +240,7 @@ files:
 - lib/shopify_api/graphql/http_client.rb
 - lib/shopify_api/graphql/railtie.rb
 - lib/shopify_api/graphql/task.rake
+- lib/shopify_api/hmac_params.rb
 - lib/shopify_api/limits.rb
 - lib/shopify_api/message_enricher.rb
 - lib/shopify_api/meta.rb
@@ -327,6 +347,7 @@ files:
 - test/access_scope_test.rb
 - test/access_token_test.rb
 - test/active_resource/json_errors_test.rb
+- test/api_access_test.rb
 - test/api_permission_test.rb
 - test/api_version_test.rb
 - test/application_charge_test.rb
@@ -482,6 +503,7 @@ files:
 - test/gift_card_test.rb
 - test/graphql/http_client_test.rb
 - test/graphql_test.rb
+- test/hmac_params_test.rb
 - test/image_test.rb
 - test/inventory_level_test.rb
 - test/lib/webmock_extensions/last_request.rb
@@ -542,7 +564,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.2.20
 signing_key: 
 specification_version: 4
 summary: ShopifyAPI is a lightweight gem for accessing the Shopify admin REST web