shopify_api 9.2.0 → 9.3.0

data/test/application_credit_test.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class ApplicationCreditTest < Test::Unit::TestCase
   def test_application_credit_create
-    fake "application_credits", method: :post, status: 201, body: load_fixture('application_credit')
+    fake("application_credits", method: :post, status: 201, body: load_fixture('application_credit'))
 
     credit = ShopifyAPI::ApplicationCredit.create(
       description: "refund for application charge",
@@ -11,25 +12,25 @@ class ApplicationCreditTest < Test::Unit::TestCase
       shop_id: 487168
     )
 
-    assert_equal 'refund for application charge', credit.description
-    assert_equal '5.00', credit.amount
+    assert_equal('refund for application charge', credit.description)
+    assert_equal('5.00', credit.amount)
   end
 
   def test_get_application_credit
-    fake "application_credits/803742", method: :get, status: 201, body: load_fixture('application_credit')
+    fake("application_credits/803742", method: :get, status: 201, body: load_fixture('application_credit'))
 
     credit = ShopifyAPI::ApplicationCredit.find(803742)
 
-    assert_equal 'refund for application charge', credit.description
-    assert_equal '5.00', credit.amount
+    assert_equal('refund for application charge', credit.description)
+    assert_equal('5.00', credit.amount)
   end
 
   def test_list_application_credits
-    fake "application_credits", method: :get, status: 201, body: load_fixture('application_credits')
+    fake("application_credits", method: :get, status: 201, body: load_fixture('application_credits'))
 
     credit = ShopifyAPI::ApplicationCredit.find(:all)
 
-    assert_equal 2, credit.size
-    assert_equal '10.00', credit.last.amount
+    assert_equal(2, credit.size)
+    assert_equal('10.00', credit.last.amount)
   end
 end

data/test/article_test.rb

@@ -1,73 +1,72 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class ArticleTest < Test::Unit::TestCase
-
   def test_create_article
-    fake "blogs/1008414260/articles", :method => :post, :body => load_fixture('article')
-    article = ShopifyAPI::Article.new(:blog_id => 1008414260)
+    fake("blogs/1008414260/articles", method: :post, body: load_fixture('article'))
+    article = ShopifyAPI::Article.new(blog_id: 1008414260)
     article.save
-    assert_equal "First Post", article.title
+    assert_equal("First Post", article.title)
   end
 
   def test_get_article
-    fake "articles/6242736", :method => :get, :body => load_fixture('article')
+    fake("articles/6242736", method: :get, body: load_fixture('article'))
     article = ShopifyAPI::Article.find(6242736)
-    assert_equal "First Post", article.title
-    assert_equal 1008414260, article.blog_id
+    assert_equal("First Post", article.title)
+    assert_equal(1008414260, article.blog_id)
   end
 
   def test_get_articles
-    fake "articles", :method => :get, :body => load_fixture('articles')
+    fake("articles", method: :get, body: load_fixture('articles'))
     articles = ShopifyAPI::Article.all
-    assert_equal 3, articles.length
-    assert_equal 1008414260, articles.first.blog_id
+    assert_equal(3, articles.length)
+    assert_equal(1008414260, articles.first.blog_id)
   end
 
   def test_get_articles_namespaced
-    fake "blogs/1008414260/articles", :method => :get, :body => load_fixture('articles')
-    articles = ShopifyAPI::Article.find(:all, :params => {:blog_id => 1008414260})
-    assert_equal 3, articles.length
-    assert_equal 1008414260, articles.first.blog_id
+    fake("blogs/1008414260/articles", method: :get, body: load_fixture('articles'))
+    articles = ShopifyAPI::Article.find(:all, params: { blog_id: 1008414260 })
+    assert_equal(3, articles.length)
+    assert_equal(1008414260, articles.first.blog_id)
   end
 
   def test_get_article_namespaced
-    fake "blogs/1008414260/articles/6242736", :method => :get, :body => load_fixture('article')
-    article = ShopifyAPI::Article.find(6242736, :params => {:blog_id => 1008414260})
-    assert_equal "First Post", article.title
-    assert_equal 1008414260, article.blog_id
+    fake("blogs/1008414260/articles/6242736", method: :get, body: load_fixture('article'))
+    article = ShopifyAPI::Article.find(6242736, params: { blog_id: 1008414260 })
+    assert_equal("First Post", article.title)
+    assert_equal(1008414260, article.blog_id)
   end
 
   def test_get_authors
-    fake "articles/authors", :method => :get, :body => load_fixture('authors')
+    fake("articles/authors", method: :get, body: load_fixture('authors'))
     authors = ShopifyAPI::Article.authors
-    assert_equal "Shopify", authors.first
-    assert_equal "development shop", authors.last
+    assert_equal("Shopify", authors.first)
+    assert_equal("development shop", authors.last)
   end
 
   def test_get_authors_for_blog_id
-    fake "blogs/1008414260/articles/authors", :method => :get, :body => load_fixture('authors')
-    authors = ShopifyAPI::Article.authors(:blog_id => 1008414260)
-    assert_equal 3, authors.length
+    fake("blogs/1008414260/articles/authors", method: :get, body: load_fixture('authors'))
+    authors = ShopifyAPI::Article.authors(blog_id: 1008414260)
+    assert_equal(3, authors.length)
   end
 
   def test_get_tags
-    fake "articles/tags", :method => :get, :body => load_fixture('tags')
+    fake("articles/tags", method: :get, body: load_fixture('tags'))
     tags = ShopifyAPI::Article.tags
-    assert_equal "consequuntur", tags.first
-    assert_equal "repellendus", tags.last
+    assert_equal("consequuntur", tags.first)
+    assert_equal("repellendus", tags.last)
   end
 
   def test_get_tags_for_blog_id
-    fake "blogs/1008414260/articles/tags", :method => :get, :body => load_fixture('tags')
-    tags = ShopifyAPI::Article.tags(:blog_id => 1008414260)
-    assert_equal "consequuntur", tags.first
-    assert_equal "repellendus", tags.last
+    fake("blogs/1008414260/articles/tags", method: :get, body: load_fixture('tags'))
+    tags = ShopifyAPI::Article.tags(blog_id: 1008414260)
+    assert_equal("consequuntur", tags.first)
+    assert_equal("repellendus", tags.last)
   end
 
   def test_get_popular_tags
-    fake "articles/tags.json?limit=1&popular=1", :extension => false, :method => :get, :body => load_fixture('tags')
-    tags = ShopifyAPI::Article.tags(:popular => 1, :limit => 1)
-    assert_equal 3, tags.length
+    fake("articles/tags.json?limit=1&popular=1", extension: false, method: :get, body: load_fixture('tags'))
+    tags = ShopifyAPI::Article.tags(popular: 1, limit: 1)
+    assert_equal(3, tags.length)
   end
-
 end

data/test/asset_test.rb

@@ -1,18 +1,26 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class AssetTest < Test::Unit::TestCase
   def test_get_assetss
-    fake "themes/1/assets", :method => :get, :body => load_fixture('assets')
-    v = ShopifyAPI::Asset.find(:all, :params => {:theme_id => 1})
+    fake("themes/1/assets", method: :get, body: load_fixture('assets'))
+    ShopifyAPI::Asset.find(:all, params: { theme_id: 1 })
   end
 
   def test_get_asset_namespaced
-    fake "themes/1/assets.json?asset%5Bkey%5D=templates%2Findex.liquid&theme_id=1", :extension=> false, :method => :get, :body => load_fixture('asset')
-    v = ShopifyAPI::Asset.find('templates/index.liquid', :params => {:theme_id => 1})
+    fake(
+      "themes/1/assets.json?asset%5Bkey%5D=templates%2Findex.liquid&theme_id=1",
+      extension: false,
+      method: :get,
+      body: load_fixture('asset')
+    )
+    ShopifyAPI::Asset.find('templates/index.liquid', params: { theme_id: 1 })
   end
 
   def test_get_asset
-    fake "assets.json?asset%5Bkey%5D=templates%2Findex.liquid", :extension=> false, :method => :get, :body => load_fixture('asset')
-    v = ShopifyAPI::Asset.find('templates/index.liquid')
+    fake(
+      "assets.json?asset%5Bkey%5D=templates%2Findex.liquid", extension: false, method: :get, body: load_fixture('asset')
+    )
+    ShopifyAPI::Asset.find('templates/index.liquid')
   end
 end

data/test/assigned_fulfillment_order_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 require 'fulfillment_order_test_helper'
 
@@ -15,7 +16,7 @@ class AssignedFulFillmentOrderTest < Test::Unit::TestCase
       should "raise NotImplementedError when api_version is older than 2020-01" do
         url_prefix_for_activated_session_for('2019-10')
 
-        assert_raises NotImplementedError do
+        assert_raises(NotImplementedError) do
           ShopifyAPI::AssignedFulfillmentOrder.new(ActiveSupport::JSON.decode(@fulfillment_order_fixture))
         end
       end
@@ -31,7 +32,7 @@ class AssignedFulFillmentOrderTest < Test::Unit::TestCase
           body: @fulfillment_order_fixture,
           extension: false
 
-        assert_raises NotImplementedError do
+        assert_raises(NotImplementedError) do
           ShopifyAPI::AssignedFulfillmentOrder.all(params: { assigned_status: 'cancellation_requested' })
         end
       end
@@ -44,7 +45,7 @@ class AssignedFulFillmentOrderTest < Test::Unit::TestCase
           extension: false
 
         assigned_fulfillment_orders = ShopifyAPI::AssignedFulfillmentOrder.all(
-            params: { assigned_status: 'cancellation_requested' }
+          params: { assigned_status: 'cancellation_requested' }
         )
 
         assert_equal 2, assigned_fulfillment_orders.count
@@ -63,7 +64,7 @@ class AssignedFulFillmentOrderTest < Test::Unit::TestCase
           body: @fulfillment_order_fixture, extension: false
 
         assigned_fulfillment_orders = ShopifyAPI::AssignedFulfillmentOrder.all(
-            params: { location_ids: [assigned_location_id] }
+          params: { location_ids: [assigned_location_id] }
         )
 
         assert_equal 2, assigned_fulfillment_orders.count

data/test/base_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 require "active_support/log_subscriber/test_helper"
 
@@ -14,93 +15,92 @@ class BaseTest < Test::Unit::TestCase
   end
 
   test '#activate_session should set site and headers for given session' do
-    ShopifyAPI::Base.activate_session @session1
+    ShopifyAPI::Base.activate_session(@session1)
 
-    assert_nil ActiveResource::Base.site
-    assert_equal 'https://shop1.myshopify.com', ShopifyAPI::Base.site.to_s
-    assert_equal 'https://shop1.myshopify.com', ShopifyAPI::Shop.site.to_s
+    assert_nil(ActiveResource::Base.site)
+    assert_equal('https://shop1.myshopify.com', ShopifyAPI::Base.site.to_s)
+    assert_equal('https://shop1.myshopify.com', ShopifyAPI::Shop.site.to_s)
 
-    assert_nil ActiveResource::Base.headers['X-Shopify-Access-Token']
-    assert_equal 'token1', ShopifyAPI::Base.headers['X-Shopify-Access-Token']
-    assert_equal 'token1', ShopifyAPI::Shop.headers['X-Shopify-Access-Token']
+    assert_nil(ActiveResource::Base.headers['X-Shopify-Access-Token'])
+    assert_equal('token1', ShopifyAPI::Base.headers['X-Shopify-Access-Token'])
+    assert_equal('token1', ShopifyAPI::Shop.headers['X-Shopify-Access-Token'])
   end
 
   test '#clear_session should clear base site settings from Base' do
     ShopifyAPI::Base.site = "https://foo:bar@www.zombo.com"
 
-    assert_equal "foo", ShopifyAPI::Base.user
-    assert_equal "bar", ShopifyAPI::Base.password
+    assert_equal("foo", ShopifyAPI::Base.user)
+    assert_equal("bar", ShopifyAPI::Base.password)
 
     ShopifyAPI::Base.clear_session
 
-    assert_nil ShopifyAPI::Base.user
-    assert_nil ShopifyAPI::Base.password
-    assert_nil ShopifyAPI::Base.site
+    assert_nil(ShopifyAPI::Base.user)
+    assert_nil(ShopifyAPI::Base.password)
+    assert_nil(ShopifyAPI::Base.site)
   end
 
   # test to  check session reset api version remains the same after session reset
   test '#clear_session should not change the api_version' do
     ShopifyAPI::Base.site = "https://zoo:lion@www.zoo.com"
 
-
-    assert_equal "zoo", ShopifyAPI::Base.user
-    assert_equal "lion", ShopifyAPI::Base.password
+    assert_equal("zoo", ShopifyAPI::Base.user)
+    assert_equal("lion", ShopifyAPI::Base.password)
 
     ShopifyAPI::Base.clear_session
 
-    assert_nil ShopifyAPI::Base.user
-    assert_nil ShopifyAPI::Base.password
-    assert_nil ShopifyAPI::Base.site
-    assert_equal ShopifyAPI::Base.api_version,@session1.api_version
+    assert_nil(ShopifyAPI::Base.user)
+    assert_nil(ShopifyAPI::Base.password)
+    assert_nil(ShopifyAPI::Base.site)
+    assert_equal(ShopifyAPI::Base.api_version, @session1.api_version)
   end
 
   test '#clear_session should clear site and headers from Base' do
-    ShopifyAPI::Base.activate_session @session1
+    ShopifyAPI::Base.activate_session(@session1)
     ShopifyAPI::Base.clear_session
 
-    assert_nil ActiveResource::Base.site
-    assert_nil ShopifyAPI::Base.site
-    assert_nil ShopifyAPI::Shop.site
+    assert_nil(ActiveResource::Base.site)
+    assert_nil(ShopifyAPI::Base.site)
+    assert_nil(ShopifyAPI::Shop.site)
 
-    assert_nil ActiveResource::Base.headers['X-Shopify-Access-Token']
-    assert_nil ShopifyAPI::Base.headers['X-Shopify-Access-Token']
-    assert_nil ShopifyAPI::Shop.headers['X-Shopify-Access-Token']
+    assert_nil(ActiveResource::Base.headers['X-Shopify-Access-Token'])
+    assert_nil(ShopifyAPI::Base.headers['X-Shopify-Access-Token'])
+    assert_nil(ShopifyAPI::Shop.headers['X-Shopify-Access-Token'])
   end
 
   test '#activate_session with one session, then clearing and activating with another session should send request to correct shop' do
-    ShopifyAPI::Base.activate_session @session1
+    ShopifyAPI::Base.activate_session(@session1)
     ShopifyAPI::Base.clear_session
-    ShopifyAPI::Base.activate_session @session2
+    ShopifyAPI::Base.activate_session(@session2)
 
-    assert_nil ActiveResource::Base.site
-    assert_equal 'https://shop2.myshopify.com', ShopifyAPI::Base.site.to_s
-    assert_equal 'https://shop2.myshopify.com', ShopifyAPI::Shop.site.to_s
+    assert_nil(ActiveResource::Base.site)
+    assert_equal('https://shop2.myshopify.com', ShopifyAPI::Base.site.to_s)
+    assert_equal('https://shop2.myshopify.com', ShopifyAPI::Shop.site.to_s)
 
-    assert_nil ActiveResource::Base.headers['X-Shopify-Access-Token']
-    assert_equal 'token2', ShopifyAPI::Base.headers['X-Shopify-Access-Token']
-    assert_equal 'token2', ShopifyAPI::Shop.headers['X-Shopify-Access-Token']
+    assert_nil(ActiveResource::Base.headers['X-Shopify-Access-Token'])
+    assert_equal('token2', ShopifyAPI::Base.headers['X-Shopify-Access-Token'])
+    assert_equal('token2', ShopifyAPI::Shop.headers['X-Shopify-Access-Token'])
   end
 
   test '#activate_session with nil raises an InvalidSessionError' do
-    assert_raises ShopifyAPI::Base::InvalidSessionError do
-      ShopifyAPI::Base.activate_session nil
+    assert_raises(ShopifyAPI::Base::InvalidSessionError) do
+      ShopifyAPI::Base.activate_session(nil)
     end
   end
 
   test "#delete should send custom headers with request" do
-    ShopifyAPI::Base.activate_session @session1
+    ShopifyAPI::Base.activate_session(@session1)
     ShopifyAPI::Base.headers['X-Custom'] = 'abc'
     ShopifyAPI::Base.connection
       .expects(:delete)
       .with('/admin/api/2019-01/bases/1.json', has_entry('X-Custom', 'abc'))
-    ShopifyAPI::Base.delete "1"
+    ShopifyAPI::Base.delete("1")
   end
 
   test "#headers includes the User-Agent" do
     assert_not_includes ActiveResource::Base.headers.keys, 'User-Agent'
-    assert_includes ShopifyAPI::Base.headers.keys, 'User-Agent'
+    assert_includes(ShopifyAPI::Base.headers.keys, 'User-Agent')
     thread = Thread.new do
-      assert_includes ShopifyAPI::Base.headers.keys, 'User-Agent'
+      assert_includes(ShopifyAPI::Base.headers.keys, 'User-Agent')
     end
     thread.join
   end
@@ -116,28 +116,28 @@ class BaseTest < Test::Unit::TestCase
   end
 
   test "prefix= will raise an error if value starts with with /admin" do
-    assert_raises ArgumentError do
+    assert_raises(ArgumentError) do
       TestResource.prefix = '/admin/old/prefix/structure/'
     end
   end
 
   test "#headers propagates changes to subclasses" do
     ShopifyAPI::Base.headers['X-Custom'] = "the value"
-    assert_equal "the value", ShopifyAPI::Base.headers['X-Custom']
-    assert_equal "the value", ShopifyAPI::Product.headers['X-Custom']
+    assert_equal("the value", ShopifyAPI::Base.headers['X-Custom'])
+    assert_equal("the value", ShopifyAPI::Product.headers['X-Custom'])
   end
 
   test "#headers clears changes to subclasses" do
     ShopifyAPI::Base.headers['X-Custom'] = "the value"
-    assert_equal "the value", ShopifyAPI::Product.headers['X-Custom']
+    assert_equal("the value", ShopifyAPI::Product.headers['X-Custom'])
     ShopifyAPI::Base.headers['X-Custom'] = nil
-    assert_nil ShopifyAPI::Product.headers['X-Custom']
+    assert_nil(ShopifyAPI::Product.headers['X-Custom'])
   end
 
   test "#headers set in the main thread affect spawned threads" do
     ShopifyAPI::Base.headers['X-Custom'] = "the value"
     Thread.new do
-      assert_equal "the value", ShopifyAPI::Base.headers['X-Custom']
+      assert_equal("the value", ShopifyAPI::Base.headers['X-Custom'])
     end.join
   end
 
@@ -145,7 +145,7 @@ class BaseTest < Test::Unit::TestCase
     Thread.new do
       ShopifyAPI::Base.headers['X-Custom'] = "the value"
     end.join
-    assert_nil ShopifyAPI::Base.headers['X-Custom']
+    assert_nil(ShopifyAPI::Base.headers['X-Custom'])
   end
 
   test "using a different version changes the url" do
@@ -168,41 +168,40 @@ class BaseTest < Test::Unit::TestCase
     )
 
     ShopifyAPI::Base.activate_session(release_2019_01)
-    assert_equal 1, ShopifyAPI::Shop.current.id
+    assert_equal(1, ShopifyAPI::Shop.current.id)
 
     ShopifyAPI::Base.activate_session(unstable_version)
-    assert_equal 2, ShopifyAPI::Shop.current.id
+    assert_equal(2, ShopifyAPI::Shop.current.id)
   end
 
   test "#api_version= should set ApiVersion" do
     ShopifyAPI::Base.api_version = '2019-04'
-    assert_equal '2019-04', ShopifyAPI::Base.api_version.to_s
+    assert_equal('2019-04', ShopifyAPI::Base.api_version.to_s)
   end
 
   test "#api_version= nil should set ApiVersion to ShopifyAPI::ApiVersion::NullVersion" do
     ShopifyAPI::Base.api_version = nil
-    assert_equal ShopifyAPI::ApiVersion::NullVersion, ShopifyAPI::Base.api_version
+    assert_equal(ShopifyAPI::ApiVersion::NullVersion, ShopifyAPI::Base.api_version)
   end
 
   test "#api_version= ShopifyAPI::ApiVersion::NullVersion should set ApiVersion to ShopifyAPI::ApiVersion::NullVersion" do
     ShopifyAPI::Base.api_version = ShopifyAPI::ApiVersion::NullVersion
-    assert_equal ShopifyAPI::ApiVersion::NullVersion, ShopifyAPI::Base.api_version
+    assert_equal(ShopifyAPI::ApiVersion::NullVersion, ShopifyAPI::Base.api_version)
   end
 
   test "#version_validation! does not raise is api_version is newer or equal to minimum supported version" do
     ShopifyAPI::Base.api_version = '2020-01'
-    assert_nil ShopifyAPI::Base::version_validation!('2020-01')
+    assert_nil(ShopifyAPI::Base::version_validation!('2020-01'))
   end
 
   test "#version_validation! raises NotImplemetedError if api_version is older than minimum supported version" do
     ShopifyAPI::Base.api_version = '2019-10'
-    exception = assert_raises NotImplementedError do
+    exception = assert_raises(NotImplementedError) do
       ShopifyAPI::Base::version_validation!('2020-01')
     end
-    assert_equal 'The minimum supported version is 2020-01.', exception.message
+    assert_equal('The minimum supported version is 2020-01.', exception.message)
   end
 
-
   def clear_header(header)
     [ActiveResource::Base, ShopifyAPI::Base, ShopifyAPI::Product].each do |klass|
       klass.headers.delete(header)