shopify_api 9.2.0 → 9.3.0

data/test/order_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 require 'fulfillment_order_test_helper'
 
@@ -5,65 +6,79 @@ class OrderTest < Test::Unit::TestCase
   include FulfillmentOrderTestHelper
 
   test "create should create order" do
-    fake 'orders', :method => :post, :status => 201, :body => load_fixture('order')
-    order = ShopifyAPI::Order.create(line_items: [{quantity:1, variant_id:39072856}], financial_status:"authorized")
-    assert_equal 39072856, order.line_items.first.variant_id
+    fake('orders', method: :post, status: 201, body: load_fixture('order'))
+    order = ShopifyAPI::Order.create(
+      line_items: [{ quantity: 1, variant_id: 39072856 }],
+      financial_status: "authorized"
+    )
+    assert_equal(39072856, order.line_items.first.variant_id)
   end
 
   test "create should create an order with custom properties" do
-    props = [{ :"By default may label with \"Roasted for " => { :"Your First Name" => { :"\". If you want something specific on the label, enter it here:" => "" }}}]
-    fake 'orders', :method => :post, :status => 201, :body => load_fixture('order_with_properties')
-    order = ShopifyAPI::Order.create(line_items: [{quantity:1, variant_id:39072856, properties:props}], financial_status:"authorized")
-    assert_equal 39072856, order.line_items.first.variant_id
+    props = [
+      {
+        "By default may label with \"Roasted for ": {
+          "Your First Name": {
+            "\". If you want something specific on the label, enter it here:": "",
+          },
+        },
+      },
+    ]
+    fake('orders', method: :post, status: 201, body: load_fixture('order_with_properties'))
+    order = ShopifyAPI::Order.create(
+      line_items: [{ quantity: 1, variant_id: 39072856, properties: props }],
+      financial_status: "authorized"
+    )
+    assert_equal(39072856, order.line_items.first.variant_id)
   end
 
   test "get should get an order" do
-    fake 'orders/450789469', :method => :get, :status => 200, :body => load_fixture('order')
+    fake('orders/450789469', method: :get, status: 200, body: load_fixture('order'))
     order = ShopifyAPI::Order.find(450789469)
-    assert_equal 450789469, order.id
+    assert_equal(450789469, order.id)
   end
 
   test "get should get an order with custom properties" do
-    fake 'orders/450789469', :method => :get, :status => 200, :body => load_fixture('order_with_properties')
+    fake('orders/450789469', method: :get, status: 200, body: load_fixture('order_with_properties'))
     order = ShopifyAPI::Order.find(450789469)
-    assert_equal 450789469, order.id
+    assert_equal(450789469, order.id)
   end
 
   test "get all should get all orders" do
-    fake 'orders', :method => :get, :status => 200, :body => load_fixture('orders')
+    fake('orders', method: :get, status: 200, body: load_fixture('orders'))
     order = ShopifyAPI::Order.all
-    assert_equal 450789469, order.first.id
+    assert_equal(450789469, order.first.id)
   end
 
   test "add note should add a note to order" do
-    fake 'orders/450789469', :method => :get, :status => 200, :body => load_fixture('order')
+    fake('orders/450789469', method: :get, status: 200, body: load_fixture('order'))
     order = ShopifyAPI::Order.find(450789469)
     order.note = "Test note"
-    fake 'orders/450789469', :method => :put, :status => 200, :body => load_fixture('order')
+    fake('orders/450789469', method: :put, status: 200, body: load_fixture('order'))
     order.save
-    assert_equal "Test note", order.note
+    assert_equal("Test note", order.note)
   end
 
   test "delete should delete an order" do
-    fake 'orders/450789469', :method => :get, :status => 200, :body => load_fixture('order')
-    fake 'orders/450789469', :method => :delete, :body => 'destroyed'
+    fake('orders/450789469', method: :get, status: 200, body: load_fixture('order'))
+    fake('orders/450789469', method: :delete, body: 'destroyed')
     order = ShopifyAPI::Order.find(450789469)
-    assert order.destroy
+    assert(order.destroy)
   end
 
   test "cancel an order with params" do
-    fake 'orders/450789469', :method => :get, :status => 200, :body => load_fixture('order')
-    fake 'orders/450789469/cancel', :method => :post, :body => load_fixture('order')
+    fake('orders/450789469', method: :get, status: 200, body: load_fixture('order'))
+    fake('orders/450789469/cancel', method: :post, body: load_fixture('order'))
     order = ShopifyAPI::Order.find(450789469)
     order.cancel(email: false, restock: true)
-    assert_request_body({'email' => false, 'restock' => true}.to_json)
+    assert_request_body({ 'email' => false, 'restock' => true }.to_json)
   end
 
   test "capture an order with currency param" do
-    fake 'orders/450789469', body: load_fixture('order')
+    fake('orders/450789469', body: load_fixture('order'))
     order = ShopifyAPI::Order.find(450789469)
 
-    fake 'orders/450789469/transactions', method: :post, status: 201, body: load_fixture('transaction')
+    fake('orders/450789469/transactions', method: :post, status: 201, body: load_fixture('transaction'))
     order.capture(100.00, currency: 'CAD')
 
     assert_request_body({
@@ -98,10 +113,10 @@ class OrderTest < Test::Unit::TestCase
     )
     fulfillment_orders = order.fulfillment_orders
 
-    assert_equal [519788021, 519788022], fulfillment_orders.map(&:id).sort
+    assert_equal([519788021, 519788022], fulfillment_orders.map(&:id).sort)
     fulfillment_orders.each do |fulfillment_order|
-      assert fulfillment_order.is_a?(ShopifyAPI::FulfillmentOrder)
-      assert_equal 450789469, fulfillment_order.order_id
+      assert(fulfillment_order.is_a?(ShopifyAPI::FulfillmentOrder))
+      assert_equal(450789469, fulfillment_order.order_id)
     end
   end
 
@@ -118,7 +133,7 @@ class OrderTest < Test::Unit::TestCase
     )
     order = ShopifyAPI::Order.find(450789469)
 
-    assert_raises NotImplementedError do
+    assert_raises(NotImplementedError) do
       order.fulfillment_orders
     end
   end

data/test/pagination_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class PaginationTest < Test::Unit::TestCase
@@ -9,14 +10,16 @@ class PaginationTest < Test::Unit::TestCase
     @next_page_info = "eyJkaXJlY3Rpb24iOiJuZXh0IiwibGFzdF9pZCI6NDQwMDg5NDIzLCJsYXN0X3ZhbHVlIjoiNDQwMDg5NDIzIn0%3D"
     @previous_page_info = "eyJsYXN0X2lkIjoxMDg4MjgzMDksImxhc3RfdmFsdWUiOiIxMDg4MjgzMDkiLCJkaXJlY3Rpb24iOiJuZXh0In0%3D"
 
-    @next_link_header = "<https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/orders.json?page_info=#{@next_page_info}>; rel=\"next\""
-    @previous_link_header = "<https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/orders.json?page_info=#{@previous_page_info}>; rel=\"previous\""
+    @next_link_header = "<https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/" \
+      "orders.json?page_info=#{@next_page_info}>; rel=\"next\""
+    @previous_link_header = "<https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/" \
+      "orders.json?page_info=#{@previous_page_info}>; rel=\"previous\""
   end
 
   test "navigates using next and previous link headers with no original params" do
-    link_header ="#{@previous_link_header}, #{@next_link_header}"
+    link_header = "#{@previous_link_header}, #{@next_link_header}"
 
-    fake 'orders', :method => :get, :status => 200, api_version: @version, :body => load_fixture('orders'), :link => link_header
+    fake('orders', method: :get, status: 200, api_version: @version, body: load_fixture('orders'), link: link_header)
     orders = ShopifyAPI::Order.all
 
     fake(
@@ -27,7 +30,7 @@ class PaginationTest < Test::Unit::TestCase
       body: load_fixture('orders')
     )
     next_page = orders.fetch_next_page
-    assert_equal 450789469, next_page.first.id
+    assert_equal(450789469, next_page.first.id)
 
     fake(
       'orders',
@@ -38,12 +41,13 @@ class PaginationTest < Test::Unit::TestCase
     )
 
     previous_page = orders.fetch_previous_page
-    assert_equal 1122334455, previous_page.first.id
+    assert_equal(1122334455, previous_page.first.id)
   end
 
   test "uses all passed in querystring parameters" do
     params = "page_info=#{@next_page_info}&limit=50&fields=#{CGI.escape('id,created_at')}"
-    @next_link_header = "<https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/orders.json?#{params}>; rel=\"next\""
+    @next_link_header = "<https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/" \
+      "orders.json?#{params}>; rel=\"next\""
     fake(
       'orders',
       method: :get,
@@ -60,100 +64,127 @@ class PaginationTest < Test::Unit::TestCase
       method: :get,
       status: 200,
       api_version: @version,
-      url: "https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/orders.json?fields=id%2Ccreated_at&limit=50&page_info=#{@next_page_info}",
+      url: "https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/" \
+        "orders.json?fields=id%2Ccreated_at&limit=50&page_info=#{@next_page_info}",
       body: load_fixture('orders')
     )
     next_page = orders.fetch_next_page
-    assert_equal 450789469, next_page.first.id
+    assert_equal(450789469, next_page.first.id)
   end
 
   test "returns empty next page if just the previous page is present" do
-    fake 'orders', :method => :get, :status => 200, api_version: @version, :body => load_fixture('orders'), :link => @previous_link_header
+    fake(
+      'orders', method: :get, status: 200, api_version: @version,
+      body: load_fixture('orders'), link: @previous_link_header
+    )
     orders = ShopifyAPI::Order.all
 
     next_page = orders.fetch_next_page
-    assert_empty next_page
+    assert_empty(next_page)
   end
 
   test "returns an empty previous page if just the next page is present" do
-    fake 'orders', :method => :get, :status => 200, api_version: @version, :body => load_fixture('orders'), :link => @next_link_header
+    fake(
+      'orders', method: :get, status: 200, api_version: @version, body: load_fixture('orders'), link: @next_link_header
+    )
     orders = ShopifyAPI::Order.all
 
     next_page = orders.fetch_previous_page
-    assert_empty next_page
+    assert_empty(next_page)
   end
 
   test "#next_page? returns true if next page is present" do
-    fake 'orders', :method => :get, :status => 200, api_version: @version, :body => load_fixture('orders'), :link => @next_link_header
+    fake(
+      'orders', method: :get, status: 200, api_version: @version, body: load_fixture('orders'), link: @next_link_header
+    )
     orders = ShopifyAPI::Order.all
 
-    assert orders.next_page?
+    assert(orders.next_page?)
   end
 
   test "#next_page? returns false if next page is not present" do
-    fake 'orders', :method => :get, :status => 200, api_version: @version, :body => load_fixture('orders'), :link => @previous_link_header
+    fake(
+      'orders', method: :get, status: 200, api_version: @version,
+      body: load_fixture('orders'), link: @previous_link_header
+    )
     orders = ShopifyAPI::Order.all
 
-    refute orders.next_page?
+    refute(orders.next_page?)
   end
 
   test "#next_page_info returns next_page_info if next page is present" do
-    fake 'orders', :method => :get, :status => 200, api_version: @version, :body => load_fixture('orders'), :link => @next_link_header
+    fake(
+      'orders', method: :get, status: 200, api_version: @version, body: load_fixture('orders'), link: @next_link_header
+    )
     orders = ShopifyAPI::Order.all
 
-    assert_equal @next_page_info, orders.next_page_info
+    assert_equal(@next_page_info, orders.next_page_info)
   end
 
   test "#next_page_info returns nil if next page is not present" do
-    fake 'orders', :method => :get, :status => 200, api_version: @version, :body => load_fixture('orders'), :link => @previous_link_header
+    fake(
+      'orders', method: :get, status: 200, api_version: @version,
+      body: load_fixture('orders'), link: @previous_link_header
+    )
     orders = ShopifyAPI::Order.all
 
-    assert_nil orders.next_page_info
+    assert_nil(orders.next_page_info)
   end
 
   test "#previous_page? returns true if previous page is present" do
-    fake 'orders', :method => :get, :status => 200, api_version: @version, :body => load_fixture('orders'), :link => @previous_link_header
+    fake(
+      'orders', method: :get, status: 200, api_version: @version,
+      body: load_fixture('orders'), link: @previous_link_header
+    )
     orders = ShopifyAPI::Order.all
 
-    assert orders.previous_page?
+    assert(orders.previous_page?)
   end
 
   test "#previous_page? returns false if next page is not present" do
-    fake 'orders', :method => :get, :status => 200, api_version: @version, :body => load_fixture('orders'), :link => @next_link_header
+    fake(
+      'orders', method: :get, status: 200, api_version: @version, body: load_fixture('orders'), link: @next_link_header
+    )
     orders = ShopifyAPI::Order.all
 
-    refute orders.previous_page?
+    refute(orders.previous_page?)
   end
 
   test "#previous_page_info returns previous_page_info if next page is present" do
-    fake 'orders', :method => :get, :status => 200, api_version: @version, :body => load_fixture('orders'), :link => @previous_link_header
+    fake(
+      'orders', method: :get, status: 200, api_version: @version,
+      body: load_fixture('orders'), link: @previous_link_header
+    )
     orders = ShopifyAPI::Order.all
 
-    assert_equal @previous_page_info, orders.previous_page_info
+    assert_equal(@previous_page_info, orders.previous_page_info)
   end
 
   test "#previous_page_info returns nil if next page is not present" do
-    fake 'orders', :method => :get, :status => 200, api_version: @version, :body => load_fixture('orders'), :link => @next_link_header
+    fake(
+      'orders', method: :get, status: 200, api_version: @version, body: load_fixture('orders'), link: @next_link_header
+    )
     orders = ShopifyAPI::Order.all
 
-    assert_nil orders.previous_page_info
+    assert_nil(orders.previous_page_info)
   end
 
   test "pagination handles no link headers" do
-    fake 'orders', :method => :get, :status => 200, api_version: @version, :body => load_fixture('orders')
+    fake('orders', method: :get, status: 200, api_version: @version, body: load_fixture('orders'))
     orders = ShopifyAPI::Order.all
 
-    refute orders.next_page?
-    refute orders.previous_page?
-    assert_empty orders.fetch_next_page
-    assert_empty orders.fetch_previous_page
+    refute(orders.next_page?)
+    refute(orders.previous_page?)
+    assert_empty(orders.fetch_next_page)
+    assert_empty(orders.fetch_previous_page)
   end
 
   test "raises on invalid pagination links" do
-    link_header = "<https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/orders.json?page_info=#{@next_page_info}>;"
-    fake 'orders', :method => :get, :status => 200, api_version: @version, :body => load_fixture('orders'), :link => link_header
+    link_header = "<https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/" \
+      "orders.json?page_info=#{@next_page_info}>;"
+    fake('orders', method: :get, status: 200, api_version: @version, body: load_fixture('orders'), link: link_header)
 
-    assert_raises ShopifyAPI::InvalidPaginationLinksError do
+    assert_raises(ShopifyAPI::InvalidPaginationLinksError) do
       ShopifyAPI::Order.all
     end
   end
@@ -162,10 +193,10 @@ class PaginationTest < Test::Unit::TestCase
     version = ShopifyAPI::ApiVersion.find_version('2019-04')
     ShopifyAPI::Base.api_version = version.to_s
 
-    fake 'orders', :method => :get, :status => 200, api_version: version, :body => load_fixture('orders')
+    fake('orders', method: :get, status: 200, api_version: version, body: load_fixture('orders'))
     orders = ShopifyAPI::Order.all
 
-    assert_raises NotImplementedError do
+    assert_raises(NotImplementedError) do
       orders.fetch_next_page
     end
   end
@@ -174,10 +205,10 @@ class PaginationTest < Test::Unit::TestCase
     version = ShopifyAPI::ApiVersion.find_version('2019-07')
     ShopifyAPI::Base.api_version = version.to_s
 
-    fake 'orders', :method => :get, :status => 200, api_version: version, :body => load_fixture('orders')
+    fake('orders', method: :get, status: 200, api_version: version, body: load_fixture('orders'))
     orders = ShopifyAPI::Order.all
 
-    assert_raises NotImplementedError do
+    assert_raises(NotImplementedError) do
       orders.fetch_next_page
     end
   end
@@ -186,21 +217,22 @@ class PaginationTest < Test::Unit::TestCase
     version = ShopifyAPI::ApiVersion.find_version('2019-07')
     ShopifyAPI::Base.api_version = version.to_s
 
-    fake 'events', :method => :get, :status => 200, api_version: version, :body => load_fixture('events')
+    fake('events', method: :get, status: 200, api_version: version, body: load_fixture('events'))
     events = ShopifyAPI::Event.all
 
-    assert_empty events.fetch_next_page
-    assert_empty events.fetch_previous_page
+    assert_empty(events.fetch_next_page)
+    assert_empty(events.fetch_previous_page)
   end
 
   test "does not raise on the unstable version" do
     version = ShopifyAPI::ApiVersion.find_version('unstable')
     ShopifyAPI::Base.api_version = version.to_s
-    @next_link_header = "<https://this-is-my-test-shop.myshopify.com/admin/api/unstable/orders.json?page_info=#{@next_page_info}>; rel=\"next\""
+    @next_link_header = "<https://this-is-my-test-shop.myshopify.com/admin/api/unstable/" \
+      "orders.json?page_info=#{@next_page_info}>; rel=\"next\""
 
-    link_header ="#{@previous_link_header}, #{@next_link_header}"
+    link_header = "#{@previous_link_header}, #{@next_link_header}"
 
-    fake 'orders', :method => :get, :status => 200, api_version: version, :body => load_fixture('orders'), :link => link_header
+    fake('orders', method: :get, status: 200, api_version: version, body: load_fixture('orders'), link: link_header)
     orders = ShopifyAPI::Order.all
 
     fake(
@@ -212,7 +244,7 @@ class PaginationTest < Test::Unit::TestCase
     )
     assert_nothing_raised do
       next_page = orders.fetch_next_page
-      assert_equal 450789469, next_page.first.id
+      assert_equal(450789469, next_page.first.id)
     end
   end
 
@@ -225,9 +257,10 @@ class PaginationTest < Test::Unit::TestCase
       api_version: @version,
       url: "https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/orders.json?limit=5",
       body: load_fixture('orders'),
-      link: "<https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/orders.json?#{first_request_params}>; rel=\"next\""
+      link: "<https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/" \
+        "orders.json?#{first_request_params}>; rel=\"next\""
     )
-    orders = ShopifyAPI::Order.where(limit: 5)
+    ShopifyAPI::Order.where(limit: 5)
 
     second_request_params = "page_info=#{@next_page_info}&limit=5"
     fake(
@@ -237,21 +270,21 @@ class PaginationTest < Test::Unit::TestCase
       api_version: @version,
       url: "https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/orders.json?limit=10",
       body: load_fixture('orders'),
-      link: "<https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/orders.json?#{second_request_params}>; rel=\"next\""
+      link: "<https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/" \
+        "orders.json?#{second_request_params}>; rel=\"next\""
     )
-
-    orders2 = ShopifyAPI::Order.where(limit: 10)
+    orders = ShopifyAPI::Order.where(limit: 10)
 
     fake(
       'orders',
       method: :get,
       status: 200,
       api_version: @version,
-      url: "https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/orders.json?limit=5&page_info=#{@next_page_info}",
+      url: "https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/" \
+        "orders.json?limit=5&page_info=#{@next_page_info}",
       body: load_fixture('orders')
     )
     next_page = orders.fetch_next_page
-    assert_equal 450789469, next_page.first.id
+    assert_equal(450789469, next_page.first.id)
   end
-
 end

data/test/policy_test.rb

@@ -1,19 +1,20 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class PolicyTest < Test::Unit::TestCase
   def setup
     super
-    fake 'shop'
+    fake('shop')
   end
 
   def test_getting_the_list_of_policies
-    fake 'policies'
+    fake('policies')
 
     policies = ShopifyAPI::Policy.all
-    assert_equal 1, policies.length
+    assert_equal(1, policies.length)
 
     policy = policies.first
-    assert_equal 'Privacy Policy', policy.title
-    assert_equal 'Your privacy is important to us', policy.body
+    assert_equal('Privacy Policy', policy.title)
+    assert_equal('Your privacy is important to us', policy.body)
   end
 end