shopify_api 9.0.2 → 9.3.0

data/test/price_rule_test.rb

@@ -1,37 +1,38 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class PriceRuleTest < Test::Unit::TestCase
   def setup
     super
-    fake 'price_rules/102586120', body: load_fixture('price_rule')
+    fake('price_rules/102586120', body: load_fixture('price_rule'))
 
     @price_rule = ShopifyAPI::PriceRule.find(102586120)
   end
 
   def test_get_price_rule
-    fake 'price_rules/102586120', method: :get, status: 200, body: load_fixture('price_rule')
+    fake('price_rules/102586120', method: :get, status: 200, body: load_fixture('price_rule'))
     price_rule = ShopifyAPI::PriceRule.find(102586120)
 
-    assert_equal 102586120, price_rule.id
+    assert_equal(102586120, price_rule.id)
   end
 
   def test_get_all_price_rules
-    fake 'price_rules', method: :get, status: 200, body: load_fixture('price_rules')
+    fake('price_rules', method: :get, status: 200, body: load_fixture('price_rules'))
     price_rules = ShopifyAPI::PriceRule.all
 
-    assert_equal 1, price_rules.length
-    assert_equal 102586120, price_rules.first.id
+    assert_equal(1, price_rules.length)
+    assert_equal(102586120, price_rules.first.id)
   end
 
   def test_get_all_discount_codes_for_a_price_rule
-    fake 'price_rules/102586120/discount_codes', method: :get, status: 200, body: load_fixture('discount_codes')
+    fake('price_rules/102586120/discount_codes', method: :get, status: 200, body: load_fixture('discount_codes'))
     price_rule = ShopifyAPI::PriceRule.find(102586120)
 
-    assert_equal "SUMMERSALE10", price_rule.discount_codes.first.code
+    assert_equal("SUMMERSALE10", price_rule.discount_codes.first.code)
   end
 
   def test_create_price_rule
-    fake 'price_rules', method: :post, status: 201, body: load_fixture('price_rule')
+    fake('price_rules', method: :post, status: 201, body: load_fixture('price_rule'))
 
     price_rule = ShopifyAPI::PriceRule.create(
       target_type: "line_item",
@@ -42,24 +43,28 @@ class PriceRuleTest < Test::Unit::TestCase
       starts_at: "2017-01-19T00:00:00Z"
     )
 
-    assert_equal '{"price_rule":{"target_type":"line_item","allocation_method":"across","value_type":"fixed_amount","value":-10.0,"customer_selection":"all","starts_at":"2017-01-19T00:00:00Z"}}', WebMock.last_request.body
-    assert_equal -10, price_rule.value
+    assert_equal(
+      '{"price_rule":{"target_type":"line_item","allocation_method":"across","value_type":"fixed_amount",' \
+        '"value":-10.0,"customer_selection":"all","starts_at":"2017-01-19T00:00:00Z"}}',
+      WebMock.last_request.body
+    )
+    assert_equal(-10, price_rule.value)
   end
 
   def test_update_price_rule
     price_rule_response = ActiveSupport::JSON.decode(load_fixture('price_rule'))
     price_rule_response['price_rule']['value'] = -50.0
     @price_rule.value = -50.0
-    fake 'price_rules/102586120', method: :put, status: 200, body: ActiveSupport::JSON.encode(price_rule_response)
+    fake('price_rules/102586120', method: :put, status: 200, body: ActiveSupport::JSON.encode(price_rule_response))
 
     @price_rule.save
 
-    assert_equal price_rule_response['price_rule']['value'], @price_rule.value
+    assert_equal(price_rule_response['price_rule']['value'], @price_rule.value)
   end
 
   def test_delete_price_rule
-    fake 'price_rules/102586120', method: :delete, body: 'destroyed'
+    fake('price_rules/102586120', method: :delete, body: 'destroyed')
 
-    assert @price_rule.destroy
+    assert(@price_rule.destroy)
   end
 end

data/test/product_listing_test.rb

@@ -1,41 +1,41 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class ProductListingTest < Test::Unit::TestCase
-
   def test_get_product_listings
-    fake "product_listings", method: :get, status: 201, body: load_fixture('product_listings')
+    fake("product_listings", method: :get, status: 201, body: load_fixture('product_listings'))
 
     product_listings = ShopifyAPI::ProductListing.find(:all)
-    assert_equal 2, product_listings.count
-    assert_equal 2, product_listings.first.product_id
-    assert_equal 1, product_listings.last.product_id
-    assert_equal 'Synergistic Silk Chair', product_listings.first.title
-    assert_equal 'Rustic Copper Bottle', product_listings.last.title
+    assert_equal(2, product_listings.count)
+    assert_equal(2, product_listings.first.product_id)
+    assert_equal(1, product_listings.last.product_id)
+    assert_equal('Synergistic Silk Chair', product_listings.first.title)
+    assert_equal('Rustic Copper Bottle', product_listings.last.title)
   end
 
   def test_get_product_listing
-    fake "product_listings/2", method: :get, status: 201, body: load_fixture('product_listing')
+    fake("product_listings/2", method: :get, status: 201, body: load_fixture('product_listing'))
 
     product_listing = ShopifyAPI::ProductListing.find(2)
-    assert_equal 'Synergistic Silk Chair', product_listing.title
+    assert_equal('Synergistic Silk Chair', product_listing.title)
   end
 
   def test_reload_product_listing
-    fake "product_listings/2", method: :get, status: 201, body: load_fixture('product_listing')
+    fake("product_listings/2", method: :get, status: 201, body: load_fixture('product_listing'))
 
     product_listing = ShopifyAPI::ProductListing.new(product_id: 2)
     product_listing.reload
 
-    assert_equal 'Synergistic Silk Chair', product_listing.title
+    assert_equal('Synergistic Silk Chair', product_listing.title)
   end
 
   def test_get_product_listing_product_ids
-    fake "product_listings/product_ids", method: :get, status: 201, body: load_fixture('product_listing_product_ids')
+    fake("product_listings/product_ids", method: :get, status: 201, body: load_fixture('product_listing_product_ids'))
 
     product_ids = ShopifyAPI::ProductListing.product_ids
-    assert_equal 2, product_ids.count
-    assert_equal 4, product_ids.first
-    assert_equal 3, product_ids.last
+    assert_equal(2, product_ids.count)
+    assert_equal(4, product_ids.first)
+    assert_equal(3, product_ids.last)
   end
 
   def test_get_product_listing_product_ids_multi_page_with_cursor
@@ -58,8 +58,8 @@ class ProductListingTest < Test::Unit::TestCase
     )
 
     product_ids = ShopifyAPI::ProductListing.product_ids
-    assert_equal [4, 3], product_ids
-    assert product_ids.next_page?
+    assert_equal([4, 3], product_ids)
+    assert(product_ids.next_page?)
 
     fake(
       "product_listings/product_ids",
@@ -71,7 +71,7 @@ class ProductListingTest < Test::Unit::TestCase
     )
 
     next_page = product_ids.fetch_next_page
-    assert_equal [2, 1], next_page
+    assert_equal([2, 1], next_page)
   end
 
   def test_get_product_listing_product_ids_multi_page_with_cursor_fails_on_older_api_version
@@ -89,8 +89,8 @@ class ProductListingTest < Test::Unit::TestCase
     )
 
     product_ids = ShopifyAPI::ProductListing.product_ids
-    assert_equal [4, 3], product_ids
-    assert_raises NotImplementedError do
+    assert_equal([4, 3], product_ids)
+    assert_raises(NotImplementedError) do
       product_ids.next_page?
     end
   end

data/test/product_publication_test.rb

@@ -3,23 +3,23 @@ require 'test_helper'
 
 class ProductPublicationTest < Test::Unit::TestCase
   def test_get_all_product_publications
-    fake 'publications/55650051/product_publications', body: load_fixture('product_publications')
+    fake('publications/55650051/product_publications', body: load_fixture('product_publications'))
     product_publications = ShopifyAPI::ProductPublication.find(:all, params: { publication_id: 55650051 })
 
-    assert_equal 647162527768, product_publications.first.id
-    assert_equal 55650051, product_publications.first.publication_id
+    assert_equal(647162527768, product_publications.first.id)
+    assert_equal(55650051, product_publications.first.publication_id)
   end
 
   def test_get_product_publication
-    fake 'publications/55650051/product_publications/647162527768', body: load_fixture('product_publication')
+    fake('publications/55650051/product_publications/647162527768', body: load_fixture('product_publication'))
     product_publication = ShopifyAPI::ProductPublication.find(647162527768, params: { publication_id: 55650051 })
 
-    assert_equal 647162527768, product_publication.id
-    assert_equal 55650051, product_publication.publication_id
+    assert_equal(647162527768, product_publication.id)
+    assert_equal(55650051, product_publication.publication_id)
   end
 
   def test_create_product_publication
-    fake 'publications/55650051/product_publications', method: :post, body: load_fixture('product_publication')
+    fake('publications/55650051/product_publications', method: :post, body: load_fixture('product_publication'))
     ShopifyAPI::ProductPublication.create(
       publication_id: 55650051,
       published_at: "2018-01-29T14:06:08-05:00",
@@ -35,6 +35,6 @@ class ProductPublicationTest < Test::Unit::TestCase
       },
     }.to_json
 
-    assert_equal expected_body, WebMock.last_request.body
+    assert_equal(expected_body, WebMock.last_request.body)
   end
 end

data/test/product_test.rb

@@ -1,47 +1,54 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class ProductTest < Test::Unit::TestCase
   def setup
     super
 
-    fake "products/632910392", :body => load_fixture('product')
-    @product = ShopifyAPI::Product.find(632910392)
+    refresh_product
   end
 
   def test_add_metafields_to_product
-    fake "products/632910392/metafields", :method => :post, :status => 201, :body => load_fixture('metafield')
-
-    field = @product.add_metafield(ShopifyAPI::Metafield.new(:namespace => "contact", :key => "email", :value => "123@example.com", :value_type => "string"))
-    assert_equal ActiveSupport::JSON.decode('{"metafield":{"namespace":"contact","key":"email","value":"123@example.com","value_type":"string"}}'), ActiveSupport::JSON.decode(WebMock.last_request.body)
-    assert !field.new_record?
-    assert_equal "contact", field.namespace
-    assert_equal "email", field.key
-    assert_equal "123@example.com", field.value
+    fake("products/632910392/metafields", method: :post, status: 201, body: load_fixture('metafield'))
+
+    field = @product.add_metafield(
+      ShopifyAPI::Metafield.new(namespace: "contact", key: "email", value: "123@example.com", value_type: "string")
+    )
+    assert_equal(
+      ActiveSupport::JSON.decode(
+        '{"metafield":{"namespace":"contact","key":"email","value":"123@example.com","value_type":"string"}}'
+      ),
+      ActiveSupport::JSON.decode(WebMock.last_request.body)
+    )
+    assert(!field.new_record?)
+    assert_equal("contact", field.namespace)
+    assert_equal("email", field.key)
+    assert_equal("123@example.com", field.value)
   end
 
   def test_get_all_metafields_for_product
-    fake "products/632910392/metafields", :body => load_fixture('metafields')
+    fake("products/632910392/metafields", body: load_fixture('metafields'))
 
     metafields = @product.metafields
 
-    assert_equal 3, metafields.length
-    assert metafields.all?{ |m| m.is_a? ShopifyAPI::Metafield }
+    assert_equal(3, metafields.length)
+    assert(metafields.all? { |m| m.is_a?(ShopifyAPI::Metafield) })
   end
 
   def test_get_2_metafields_for_product
-    body = ActiveSupport::JSON.decode load_fixture 'metafields'
-    body['metafields'].slice! 2, 1
+    body = ActiveSupport::JSON.decode(load_fixture('metafields'))
+    body['metafields'].slice!(2, 1)
 
-    fake 'products/632910392/metafields.json?limit=2', body: body.to_json, extension: false
+    fake('products/632910392/metafields.json?limit=2', body: body.to_json, extension: false)
 
-    metafields = @product.metafields limit: 2
+    metafields = @product.metafields(limit: 2)
 
-    assert_equal 2, metafields.length
-    assert metafields.all?{ |m| m.is_a? ShopifyAPI::Metafield }
+    assert_equal(2, metafields.length)
+    assert(metafields.all? { |m| m.is_a?(ShopifyAPI::Metafield) })
   end
 
   def test_update_loaded_variant
-    fake "products/632910392/variants/808950810", :method => :put, :status => 200, :body => load_fixture('variant')
+    fake("products/632910392/variants/808950810", method: :put, status: 200, body: load_fixture('variant'))
 
     variant = @product.variants.first
     variant.price = "0.50"
@@ -57,4 +64,48 @@ class ProductTest < Test::Unit::TestCase
 
     assert_equal('100.00 - 199.00', @product.price_range)
   end
+
+  def test_read_only_variant_inventory_fields_not_removed_in_2020_01
+    ShopifyAPI::Base.api_version = '2020-01'
+    refresh_product(api_version: ShopifyAPI::Base.api_version)
+
+    variant = @product.variants.first
+    assert_equal(10, variant.inventory_quantity)
+  end
+
+  def test_deprecated_inventory_fields_are_removed_in_2020_01
+    ShopifyAPI::Base.api_version = '2020-01'
+    refresh_product(api_version: ShopifyAPI::Base.api_version)
+
+    refute(@product.as_json.include?('total_inventory'))
+  end
+
+  def test_setting_product_total_inventory_passes_in_api_before_2019_10
+    ShopifyAPI::Base.api_version = '2019-07'
+    refresh_product(api_version: ShopifyAPI::Base.api_version)
+    @product.total_inventory = 8
+  end
+
+  def test_setting_product_total_inventory_fails_in_2019_10_api
+    ShopifyAPI::Base.api_version = '2019-10'
+    refresh_product(api_version: ShopifyAPI::Base.api_version)
+    assert_raises(ShopifyAPI::ValidationException) do
+      @product.total_inventory = 8
+    end
+  end
+
+  def test_setting_product_total_inventory_fails_in_the_unstable_api
+    ShopifyAPI::Base.api_version = :unstable
+    refresh_product(api_version: ShopifyAPI::Base.api_version)
+    assert_raises(ShopifyAPI::ValidationException) do
+      @product.total_inventory = 8
+    end
+  end
+
+  private
+
+  def refresh_product(api_version: nil)
+    fake("products/632910392", body: load_fixture('product'), api_version: api_version)
+    @product = ShopifyAPI::Product.find(632910392)
+  end
 end

data/test/publication_test.rb

@@ -3,10 +3,10 @@ require 'test_helper'
 
 class PublicationTest < Test::Unit::TestCase
   def test_find_all_publications
-    fake 'publications'
+    fake('publications')
     publications = ShopifyAPI::Publication.find(:all)
 
-    assert_equal 55650051, publications.first.id
-    assert_equal "Buy Button", publications.first.name
+    assert_equal(55650051, publications.first.id)
+    assert_equal("Buy Button", publications.first.name)
   end
 end

data/test/recurring_application_charge_test.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class RecurringApplicationChargeTest < Test::Unit::TestCase
-
   def test_recurring_application_charges_create
-    fake "recurring_application_charges", method: :post, status: 201, body: load_fixture('recurring_application_charge')
+    fake(
+      "recurring_application_charges", method: :post, status: 201, body: load_fixture('recurring_application_charge')
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.create(
       name: "Default Plan",
@@ -11,132 +13,192 @@ class RecurringApplicationChargeTest < Test::Unit::TestCase
       return_url: "http://test.com/confirm"
     )
 
-    assert_equal 'http://apple.myshopify.com/admin/charges/654381177/confirm_recurring_application_charge?signature=BAhpBHkQASc%3D--419fc7424f8c290ac2b21b9004ed223e35b52164', charge.confirmation_url
+    assert_equal(
+      'http://apple.myshopify.com/admin/charges/654381177/confirm_recurring_application_charge?' \
+        'signature=BAhpBHkQASc%3D--419fc7424f8c290ac2b21b9004ed223e35b52164',
+      charge.confirmation_url
+    )
   end
 
   def test_get_recurring_application_charges
-    fake "recurring_application_charges/654381177", method: :get, status: 201, body: load_fixture('recurring_application_charge')
+    fake(
+      "recurring_application_charges/654381177",
+      method: :get,
+      status: 201,
+      body: load_fixture('recurring_application_charge')
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.find(654381177)
 
-    assert_equal "Super Duper Plan", charge.name
+    assert_equal("Super Duper Plan", charge.name)
   end
 
   def test_list_recurring_application_charges
-    fake "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    fake(
+      "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.find(:all)
 
-    assert_equal "Super Mega Plan", charge.last.name
+    assert_equal("Super Mega Plan", charge.last.name)
   end
 
   def test_list_since_recurring_application_charges
-    fake "recurring_application_charges.json?since_id=64512345",extension: false, method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    fake(
+      "recurring_application_charges.json?since_id=64512345",
+      extension: false,
+      method: :get,
+      status: 201,
+      body: load_fixture('recurring_application_charges')
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.find(:all, params: { since_id: '64512345' })
 
-    assert_equal "Super Mega Plan", charge.last.name
+    assert_equal("Super Mega Plan", charge.last.name)
   end
 
   def test_list_fields_recurring_application_charges
-    fake "recurring_application_charges.json?fields=name",extension: false, method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    fake(
+      "recurring_application_charges.json?fields=name",
+      extension: false,
+      method: :get,
+      status: 201,
+      body: load_fixture('recurring_application_charges')
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.find(:all, params: { fields: 'name' })
 
-    assert_equal "Super Mega Plan", charge.last.name
+    assert_equal("Super Mega Plan", charge.last.name)
   end
 
   def test_pending_recurring_application_charge
-    fake "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    fake(
+      "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.pending
 
-    assert_equal "Super Mega Plan2", charge.last.name
+    assert_equal("Super Mega Plan2", charge.last.name)
   end
 
   def test_cancelled_recurring_application_charge
-    fake "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    fake(
+      "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.cancelled
 
-    assert_equal "Super Mega Plan3", charge.last.name
+    assert_equal("Super Mega Plan3", charge.last.name)
   end
 
   def test_accepted_recurring_application_charge
-    fake "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    fake(
+      "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.accepted
 
-    assert_equal "Super Mega Plan4", charge.first.name
-    assert_equal "Super Mega Plan", charge.last.name
+    assert_equal("Super Mega Plan4", charge.first.name)
+    assert_equal("Super Mega Plan", charge.last.name)
   end
 
   def test_declined_recurring_application_charge
-    fake "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    fake(
+      "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.declined
 
-    assert_equal "Super Mega Plan5", charge.last.name
+    assert_equal("Super Mega Plan5", charge.last.name)
   end
 
   def test_activate_recurring_application_charge
-    fake "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
-    fake "recurring_application_charges/455696199/activate", method: :post, status: 200, body: "{}"
+    fake(
+      "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    )
+    fake("recurring_application_charges/455696199/activate", method: :post, status: 200, body: "{}")
 
     charge = ShopifyAPI::RecurringApplicationCharge.accepted
 
-    assert charge.last.activate
+    assert(charge.last.activate)
   end
 
   def test_adjust_recurring_application_charge
-    fake "recurring_application_charges/654381177", method: :get, status: 201, body: load_fixture('recurring_application_charge')
-    fake "recurring_application_charges/654381177/customize.json?recurring_application_charge%5Bcapped_amount%5D=200", method: :put, body: load_fixture('recurring_application_charge_adjustment'), extension: false
+    fake(
+      "recurring_application_charges/654381177",
+      method: :get,
+      status: 201,
+      body: load_fixture('recurring_application_charge')
+    )
+    fake(
+      "recurring_application_charges/654381177/customize.json?recurring_application_charge%5Bcapped_amount%5D=200",
+      method: :put,
+      body: load_fixture('recurring_application_charge_adjustment'),
+      extension: false
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.find(654381177)
 
-    assert charge.customize(capped_amount: 200)
+    assert(charge.customize(capped_amount: 200))
   end
 
   def test_cancel_recurring_application_charge
-    fake "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
-    fake "recurring_application_charges/455696194", method: :delete, status: 200, body: "{}"
+    fake(
+      "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    )
+    fake("recurring_application_charges/455696194", method: :delete, status: 200, body: "{}")
 
     charge = ShopifyAPI::RecurringApplicationCharge.current
-    assert charge.cancel
+    assert(charge.cancel)
   end
 
   def test_usage_charges_recurring_application_charge_found
-    fake "recurring_application_charges/654381177", method: :get, status: 201, body: load_fixture('recurring_application_charge')
-    fake "recurring_application_charges/654381177/usage_charges", method: :get, status: 201, body: load_fixture('usage_charges')
+    fake(
+      "recurring_application_charges/654381177",
+      method: :get,
+      status: 201,
+      body: load_fixture('recurring_application_charge')
+    )
+    fake(
+      "recurring_application_charges/654381177/usage_charges",
+      method: :get,
+      status: 201,
+      body: load_fixture('usage_charges')
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.find(654381177)
     usage_charges = charge.usage_charges
 
-    assert_equal 2, usage_charges.length
+    assert_equal(2, usage_charges.length)
   end
 
   def test_usage_charges_recurring_application_charge_not_found
-    fake "recurring_application_charges/654381177", method: :get, status: 201, body: load_fixture('recurring_application_charge')
-    fake "recurring_application_charges/654381177/usage_charges", method: :get, status: 201, body: "[]"
+    fake(
+      "recurring_application_charges/654381177",
+      method: :get,
+      status: 201,
+      body: load_fixture('recurring_application_charge')
+    )
+    fake("recurring_application_charges/654381177/usage_charges", method: :get, status: 201, body: "[]")
 
     charge = ShopifyAPI::RecurringApplicationCharge.find(654381177)
     usage_charges = charge.usage_charges
 
-    assert_equal 0, usage_charges.length
+    assert_equal(0, usage_charges.length)
   end
 
   def test_no_recurring_application_charge_found
-    fake "recurring_application_charges", body: {recurring_application_charges: []}.to_json
+    fake("recurring_application_charges", body: { recurring_application_charges: [] }.to_json)
 
-    assert_equal 0, ShopifyAPI::RecurringApplicationCharge.all.count
-    assert_nil ShopifyAPI::RecurringApplicationCharge.current
-    assert_equal [], ShopifyAPI::RecurringApplicationCharge.pending
+    assert_equal(0, ShopifyAPI::RecurringApplicationCharge.all.count)
+    assert_nil(ShopifyAPI::RecurringApplicationCharge.current)
+    assert_equal([], ShopifyAPI::RecurringApplicationCharge.pending)
   end
 
   def test_recurring_application_charge_not_found_error
-    fake "recurring_application_charges", body: '{"errors":"Not Found"}', status: 404
-    assert_nil ShopifyAPI::RecurringApplicationCharge.all
-    assert_nil ShopifyAPI::RecurringApplicationCharge.current
+    fake("recurring_application_charges", body: '{"errors":"Not Found"}', status: 404)
+    assert_nil(ShopifyAPI::RecurringApplicationCharge.all)
+    assert_nil(ShopifyAPI::RecurringApplicationCharge.current)
     assert_equal([], ShopifyAPI::RecurringApplicationCharge.pending)
   end
 end