shopify_api 9.0.2 → 9.3.0

data/test/image_test.rb

@@ -1,39 +1,41 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class ImageTest < Test::Unit::TestCase
   def test_create_image
-    fake "products/632910392/images", :method => :post, :body => load_fixture('image')
-    image = ShopifyAPI::Image.new(:product_id => 632910392)
+    fake("products/632910392/images", method: :post, body: load_fixture('image'))
+    image = ShopifyAPI::Image.new(product_id: 632910392)
     image.position = 1
-    image.attachment = "R0lGODlhbgCMAPf/APbr48VySrxTO7IgKt2qmKQdJeK8lsFjROG5p/nz7Zg3MNmnd7Q1MLNVS9GId71hSJMZIuzTu4UtKbeEeakhKMl8U8WYjfr18YQaIbAf=="
+    image.attachment = "R0lGODlhbgCMAPf/APbr48VySrxTO7IgKt2qmKQdJeK8lsFjROG5p/nz7Zg3MN" \
+      "mnd7Q1MLNVS9GId71hSJMZIuzTu4UtKbeEeakhKMl8U8WYjfr18YQaIbAf=="
     image.save
 
-    assert_equal 'http://cdn.shopify.com/s/files/1/0006/9093/3842/products/ipod-nano.png?v=1389388540', image.src
-    assert_equal 850703190, image.id
+    assert_equal('http://cdn.shopify.com/s/files/1/0006/9093/3842/products/ipod-nano.png?v=1389388540', image.src)
+    assert_equal(850703190, image.id)
   end
 
   def test_get_images
-    fake "products/632910392/images", :method => :get, :body => load_fixture('images')
-    image = ShopifyAPI::Image.find(:all, :params => {:product_id => 632910392})
-    assert_equal 2, image.size
+    fake("products/632910392/images", method: :get, body: load_fixture('images'))
+    image = ShopifyAPI::Image.find(:all, params: { product_id: 632910392 })
+    assert_equal(2, image.size)
   end
 
   def test_get_image
-    fake "products/632910392/images/850703190", :method => :get, :body => load_fixture('image')
-    image = ShopifyAPI::Image.find(850703190, :params => {:product_id => 632910392})
-    assert_equal 850703190, image.id
+    fake("products/632910392/images/850703190", method: :get, body: load_fixture('image'))
+    image = ShopifyAPI::Image.find(850703190, params: { product_id: 632910392 })
+    assert_equal(850703190, image.id)
   end
 
   def test_delete_image
-    fake "products/632910392/images/850703190", :method => :get, :body => load_fixture('image')
-    fake "products/632910392/images/850703190", :method => :delete, :body => "destroyed"
-    image = ShopifyAPI::Image.find(850703190, :params => {:product_id => 632910392})
-    assert image.destroy
+    fake("products/632910392/images/850703190", method: :get, body: load_fixture('image'))
+    fake("products/632910392/images/850703190", method: :delete, body: "destroyed")
+    image = ShopifyAPI::Image.find(850703190, params: { product_id: 632910392 })
+    assert(image.destroy)
   end
 
   def test_delete_image_without_fetching
-    fake "products/632910392/images/850703190", :method => :delete, :body => "destroyed"
+    fake("products/632910392/images/850703190", method: :delete, body: "destroyed")
     image = ShopifyAPI::Image.new(product_id: 632910392, id: 850703190)
-    assert image.destroy
+    assert(image.destroy)
   end
 end

data/test/inventory_level_test.rb

@@ -1,22 +1,31 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class InventoryLevelTest < Test::Unit::TestCase
   def setup
     super
-    @inventory_level_response = ActiveSupport::JSON.decode load_fixture('inventory_level')
+    @inventory_level_response = ActiveSupport::JSON.decode(load_fixture('inventory_level'))
     @inventory_level = ShopifyAPI::InventoryLevel.new(@inventory_level_response['inventory_level'])
   end
 
   test ".find with inventory_item_ids and location_ids returns expected inventory levels" do
     params = { inventory_item_ids: [808950810, 39072856], location_ids: [905684977, 487838322] }
-    fake "inventory_levels.json?#{params.to_param}", extension: false, method: :get,
-          status: 200, body: load_fixture('inventory_levels')
+    fake(
+      "inventory_levels.json?#{params.to_param}",
+      extension: false,
+      method: :get,
+      status: 200,
+      body: load_fixture('inventory_levels')
+    )
     inventory_levels = ShopifyAPI::InventoryLevel.find(:all, params: params)
 
-    assert inventory_levels.all? { |item|
-      params[:location_ids].include?(item.location_id) &&
-      params[:inventory_item_ids].include?(item.inventory_item_id)
-    }, message: 'Response contained inventory_items or locations not requested.'
+    assert(
+      inventory_levels.all? do |item|
+        params[:location_ids].include?(item.location_id) &&
+        params[:inventory_item_ids].include?(item.inventory_item_id)
+      end,
+      message: 'Response contained inventory_items or locations not requested.'
+    )
   end
 
   test '#adjust with adjustment value returns inventory_level with available increased by adjustment value' do
@@ -24,9 +33,9 @@ class InventoryLevelTest < Test::Unit::TestCase
     updated_available = @inventory_level.available + adjustment
     @inventory_level_response[:available] = updated_available
 
-    fake 'inventory_levels/adjust', method: :post, body: ActiveSupport::JSON.encode(@inventory_level_response)
+    fake('inventory_levels/adjust', method: :post, body: ActiveSupport::JSON.encode(@inventory_level_response))
     @inventory_level.adjust(adjustment)
-    assert_equal updated_available, @inventory_level.available
+    assert_equal(updated_available, @inventory_level.available)
   end
 
   test '#connect saves an inventory_level associated with inventory_item and location_id' do
@@ -34,16 +43,16 @@ class InventoryLevelTest < Test::Unit::TestCase
     response = params.clone
     response[:available] = 0
 
-    fake 'inventory_levels/connect', method: :post, body: ActiveSupport::JSON.encode(response)
+    fake('inventory_levels/connect', method: :post, body: ActiveSupport::JSON.encode(response))
     inventory_level = ShopifyAPI::InventoryLevel.new(params)
     inventory_level.connect
-    assert_equal 0, inventory_level.available, message: 'expected newly connected location to have 0 inventory'
+    assert_equal(0, inventory_level.available, message: 'expected newly connected location to have 0 inventory')
   end
 
   test '#destroy removes inventory_level and returns nil' do
     params = { inventory_item_id: @inventory_level.inventory_item_id, location_id: @inventory_level.location_id }
-    fake "inventory_levels.json?#{params.to_param}", extension: false, method: :delete, status: 204, body: nil
-    assert_nil @inventory_level.destroy
+    fake("inventory_levels.json?#{params.to_param}", extension: false, method: :delete, status: 204, body: nil)
+    assert_nil(@inventory_level.destroy)
   end
 
   test '#set with available value returns inventory_level with available as the available value' do
@@ -51,9 +60,9 @@ class InventoryLevelTest < Test::Unit::TestCase
     response = @inventory_level_response.clone
     response['inventory_level']['available'] = available
 
-    fake 'inventory_levels/set', method: :post, body: ActiveSupport::JSON.encode(response)
+    fake('inventory_levels/set', method: :post, body: ActiveSupport::JSON.encode(response))
     @inventory_level.set(available)
 
-    assert_equal available, @inventory_level.available
+    assert_equal(available, @inventory_level.available)
   end
 end

data/test/lib/webmock_extensions/last_request.rb

@@ -11,6 +11,6 @@ module LastRequest
 end
 
 WebMock.extend(LastRequest)
-WebMock.after_request do |request_signature, response|
+WebMock.after_request do |request_signature, _response|
   WebMock.last_request = request_signature
 end

data/test/limits_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class LimitsTest < Test::Unit::TestCase
@@ -30,7 +31,7 @@ class LimitsTest < Test::Unit::TestCase
     should "raise error when header doesn't exist" do
       @header_hash = {}
       ShopifyAPI::Base.connection.expects(:response).at_least(1).returns(@header_hash)
-      assert_raises ShopifyAPI::Limits::LimitUnavailable do
+      assert_raises(ShopifyAPI::Limits::LimitUnavailable) do
         ShopifyAPI.credit_left
       end
     end

data/test/location_test.rb

@@ -1,10 +1,11 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class LocationTest < Test::Unit::TestCase
   test '#inventory_levels returns all inventory_levels associated with this location' do
     location = ShopifyAPI::Location.new(id: 487838322)
     expected_body = JSON.parse(load_fixture('inventory_levels'))
-    expected_body['inventory_levels'].delete_if {|level| level['location_id'] != location.id }
+    expected_body['inventory_levels'].delete_if { |level| level['location_id'] != location.id }
     fake "locations/#{location.id}/inventory_levels", method: :get, status: 200, body: JSON(expected_body).to_s
     inventory_levels = location.inventory_levels
 

data/test/marketing_event_test.rb

@@ -1,56 +1,56 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class MarketingEventTest < Test::Unit::TestCase
-
   def test_get_marketing_events
-    fake "marketing_events", :method => :get, :body => load_fixture('marketing_events')
+    fake("marketing_events", method: :get, body: load_fixture('marketing_events'))
     marketing_events = ShopifyAPI::MarketingEvent.all
-    assert_equal 2, marketing_events.size
+    assert_equal(2, marketing_events.size)
   end
 
   def test_get_marketing_event
-    fake "marketing_events/1", :method => :get, :body => load_fixture('marketing_event')
+    fake("marketing_events/1", method: :get, body: load_fixture('marketing_event'))
     marketing_event = ShopifyAPI::MarketingEvent.find(1)
-    assert_equal 1, marketing_event.id
+    assert_equal(1, marketing_event.id)
   end
 
   def test_create_marketing_event
-    fake "marketing_events", :method => :post, :body => load_fixture('marketing_event')
+    fake("marketing_events", method: :post, body: load_fixture('marketing_event'))
     marketing_event = ShopifyAPI::MarketingEvent.new
     marketing_event.currency_code = 'GBP'
     marketing_event.event_target = 'facebook'
     marketing_event.event_type = 'post'
     marketing_event.save
 
-    assert_equal 'facebook', marketing_event.event_target
-    assert_equal 1, marketing_event.id
+    assert_equal('facebook', marketing_event.event_target)
+    assert_equal(1, marketing_event.id)
   end
 
   def test_delete_marketing_event
-    fake "marketing_events/1", :method => :get, :body => load_fixture('marketing_event')
-    fake "marketing_events/1", :method => :delete, :body => "destroyed"
+    fake("marketing_events/1", method: :get, body: load_fixture('marketing_event'))
+    fake("marketing_events/1", method: :delete, body: "destroyed")
     marketing_event = ShopifyAPI::MarketingEvent.find(1)
-    assert marketing_event.destroy
+    assert(marketing_event.destroy)
   end
 
   def test_update_marketing_event
-    fake 'marketing_events/1', :method => :get, :status => 200, :body => load_fixture('marketing_event')
+    fake('marketing_events/1', method: :get, status: 200, body: load_fixture('marketing_event'))
     marketing_event = ShopifyAPI::MarketingEvent.find(1)
     marketing_event.currency = 'USD'
-    fake 'marketing_events/1', :method => :put, :status => 200, :body => load_fixture('marketing_event')
-    assert marketing_event.save
+    fake('marketing_events/1', method: :put, status: 200, body: load_fixture('marketing_event'))
+    assert(marketing_event.save)
   end
 
   def test_count_marketing_events
-    fake "marketing_events/count", :method => :get, :body => '{"count": 2}'
+    fake("marketing_events/count", method: :get, body: '{"count": 2}')
     marketing_events_count = ShopifyAPI::MarketingEvent.count
-    assert_equal 2, marketing_events_count
+    assert_equal(2, marketing_events_count)
   end
 
   def test_add_engagements
-    fake "marketing_events/1", method: :get, body: load_fixture('marketing_event')
+    fake("marketing_events/1", method: :get, body: load_fixture('marketing_event'))
     marketing_event = ShopifyAPI::MarketingEvent.find(1)
-    fake "marketing_events/1/engagements", method: :post, status: 201, body: load_fixture('engagement')
+    fake("marketing_events/1/engagements", method: :post, status: 201, body: load_fixture('engagement'))
     engagement = {
       occurred_on: "2017-04-20",
       impressions_count: nil,
@@ -60,9 +60,9 @@ class MarketingEventTest < Test::Unit::TestCase
       favorites_count: nil,
       comments_count: nil,
       ad_spend: nil,
-      is_cumulative: true
+      is_cumulative: true,
     }
     marketing_event.add_engagements(engagement)
-    assert "2017-04-20", engagement[:occurred_on]
+    assert("2017-04-20", engagement[:occurred_on])
   end
 end

data/test/message_enricher_test.rb

@@ -1,35 +1,35 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class MessageEnricherTest < Test::Unit::TestCase
-
   def test_enriches_initial_message_when_body_contains_error
     response = enriched_response(422, 'InitialMessage', { error: 'My Error' })
 
-    assert_equal 'InitialMessage (My Error)', response.message
+    assert_equal('InitialMessage (My Error)', response.message)
   end
 
   def test_enriches_initial_message_when_body_contains_errors_array
     response = enriched_response(422, 'InitialMessage', { errors: ['My Error1', 'My Error2'] })
 
-    assert_equal 'InitialMessage (My Error1; My Error2)', response.message
+    assert_equal('InitialMessage (My Error1; My Error2)', response.message)
   end
 
   def test_enriches_initial_message_when_body_contains_errors_single_value
     response = enriched_response(422, 'InitialMessage', { errors: 'My Error1' })
 
-    assert_equal 'InitialMessage (My Error1)', response.message
+    assert_equal('InitialMessage (My Error1)', response.message)
   end
 
   def test_returns_initial_message_when_code_is_200
     response = enriched_response(200, 'InitialMessage', { result: 'Success' })
 
-    assert_equal 'InitialMessage', response.message
+    assert_equal('InitialMessage', response.message)
   end
 
   def test_returns_initial_message_when_body_cant_be_parsed
     response = enriched_response(422, 'InitialMessage', 'not a json')
 
-    assert_equal 'InitialMessage', response.message
+    assert_equal('InitialMessage', response.message)
   end
 
   private

data/test/meta_test.rb

@@ -8,42 +8,40 @@ class ApiVersionTest < Test::Unit::TestCase
         "handle": "2019-01",
         "display_name": "2019-01",
         "supported": true,
-        "latest_supported": false
+        "latest_supported": false,
       },
       {
         "handle": "2019-04",
         "latest_supported": false,
         "display_name": "2019-04",
-        "supported": true
+        "supported": true,
       },
       {
         "handle": "2019-07",
         "latest_supported": false,
         "display_name": "2019-07",
-        "supported": true
+        "supported": true,
       },
       {
         "handle": "2019-10",
         "latest_supported": false,
         "display_name": "2019-10",
-        "supported": true
+        "supported": true,
       },
       {
         "handle": "2020-01",
         "latest_supported": true,
         "display_name": "2020-01 (Latest)",
-        "supported": true
+        "supported": true,
       },
       {
         "handle": "unstable",
         "latest_supported": false,
         "display_name": "unstable",
-        "supported": false
-      }
+        "supported": false,
+      },
     ].to_json
 
-
     assert_equal versions, ShopifyAPI::Meta.admin_versions.to_json
-
   end
 end

data/test/metafield_test.rb

@@ -1,46 +1,56 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class MetafieldTest < Test::Unit::TestCase
   def test_get_metafields
-    fake "metafields", :method => :get, :body => load_fixture('metafields')
-    metafields = ShopifyAPI::Metafield.find(:all)
+    fake("metafields", method: :get, body: load_fixture('metafields'))
+    ShopifyAPI::Metafield.find(:all)
   end
 
   def test_get_metafield
-    fake "metafields/721389482", :method => :get, :body => load_fixture('metafield')
-    assert ShopifyAPI::Metafield.find(721389482)
+    fake("metafields/721389482", method: :get, body: load_fixture('metafield'))
+    assert(ShopifyAPI::Metafield.find(721389482))
   end
 
   def test_get_metafield_of_a_blog
-    fake "blogs/1008414260/metafields/721389482", :method => :get, :body => load_fixture('metafield')
-    metafield = ShopifyAPI::Metafield.find(721389482, :params => {:resource => "blogs", :resource_id => 1008414260})
-    assert_equal 1008414260, metafield.prefix_options[:resource_id]
+    fake("blogs/1008414260/metafields/721389482", method: :get, body: load_fixture('metafield'))
+    metafield = ShopifyAPI::Metafield.find(721389482, params: { resource: "blogs", resource_id: 1008414260 })
+    assert_equal(1008414260, metafield.prefix_options[:resource_id])
   end
 
   def test_create_metafield_for_a_blog
-    fake "blogs/1008414260", :method => :get, :body => load_fixture('blog')
-    fake "blogs/1008414260/metafields", :method => :post, :status => 201, :body => load_fixture('metafield')
+    fake("blogs/1008414260", method: :get, body: load_fixture('blog'))
+    fake("blogs/1008414260/metafields", method: :post, status: 201, body: load_fixture('metafield'))
 
     blog = ShopifyAPI::Blog.find(1008414260)
-    metafield = blog.add_metafield(ShopifyAPI::Metafield.new(:namespace => "summaries", :key => "First Summary", :value => "Make commerce better", :value_type => "string"))
-
-    assert_equal ActiveSupport::JSON.decode('{"metafield":{"namespace":"summaries","key":"First Summary","value":"Make commerce better","value_type":"string"}}'), ActiveSupport::JSON.decode(WebMock.last_request.body)
-    assert !metafield.new_record?
+    metafield = blog.add_metafield(
+      ShopifyAPI::Metafield.new(
+        namespace: "summaries", key: "First Summary", value: "Make commerce better", value_type: "string"
+      )
+    )
+
+    assert_equal(
+      ActiveSupport::JSON.decode(
+        '{"metafield":{"namespace":"summaries","key":"First Summary",' \
+          '"value":"Make commerce better","value_type":"string"}}'
+      ),
+      ActiveSupport::JSON.decode(WebMock.last_request.body)
+    )
+    assert(!metafield.new_record?)
   end
 
   def test_update_metafield
-    fake "metafields/721389482", :method => :get, :body => load_fixture('metafield')
-    fake "metafields/721389482", :method => :put, :status => 200, :body => load_fixture('metafield')
+    fake("metafields/721389482", method: :get, body: load_fixture('metafield'))
+    fake("metafields/721389482", method: :put, status: 200, body: load_fixture('metafield'))
     metafield = ShopifyAPI::Metafield.find(721389482)
     metafield.namespace = "teaser"
-    assert metafield.save
+    assert(metafield.save)
   end
 
   def test_delete_metafield
-    fake "metafields/721389482", :method => :get, :body => load_fixture('metafield')
-    fake "metafields/721389482", :method => :delete, :body => 'destroyed'
+    fake("metafields/721389482", method: :get, body: load_fixture('metafield'))
+    fake("metafields/721389482", method: :delete, body: 'destroyed')
     metafield = ShopifyAPI::Metafield.find(721389482)
-    assert metafield.destroy
+    assert(metafield.destroy)
   end
 end
-

data/test/order_risk_test.rb

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class OrderRiskTest < Test::Unit::TestCase
   def test_create_order_risk
-    fake "orders/450789469/risks", :method => :post, :body => load_fixture('order_risk')
-    v = ShopifyAPI::OrderRisk.new(:order_id => 450789469)
+    fake("orders/450789469/risks", method: :post, body: load_fixture('order_risk'))
+    v = ShopifyAPI::OrderRisk.new(order_id: 450789469)
     v.message = "This order was placed from a proxy IP"
     v.recommendation = "cancel"
     v.score = "1.0"
@@ -13,33 +14,33 @@ class OrderRiskTest < Test::Unit::TestCase
     v.cause_cancel = true
     v.save
 
-    assert_equal 284138680, v.id
+    assert_equal(284138680, v.id)
   end
 
   def test_get_order_risks
-    fake "orders/450789469/risks", :method => :get, :body => load_fixture('order_risks')
-    v = ShopifyAPI::OrderRisk.find(:all, :params => {:order_id => 450789469})
-    assert_equal 2, v.size
+    fake("orders/450789469/risks", method: :get, body: load_fixture('order_risks'))
+    v = ShopifyAPI::OrderRisk.find(:all, params: { order_id: 450789469 })
+    assert_equal(2, v.size)
   end
 
   def test_get_order_risk
-    fake "orders/450789469/risks/284138680", :method => :get, :body => load_fixture('order_risk')
-    v = ShopifyAPI::OrderRisk.find(284138680, :params => {:order_id => 450789469})
-    assert_equal 284138680, v.id
+    fake("orders/450789469/risks/284138680", method: :get, body: load_fixture('order_risk'))
+    v = ShopifyAPI::OrderRisk.find(284138680, params: { order_id: 450789469 })
+    assert_equal(284138680, v.id)
   end
 
   def test_delete_order_risk
-    fake "orders/450789469/risks/284138680", :method => :get, :body => load_fixture('order_risk')
-    fake "orders/450789469/risks/284138680", :method => :delete, :body => "destroyed"
-    v = ShopifyAPI::OrderRisk.find(284138680, :params => {:order_id => 450789469})
-    assert v.destroy
+    fake("orders/450789469/risks/284138680", method: :get, body: load_fixture('order_risk'))
+    fake("orders/450789469/risks/284138680", method: :delete, body: "destroyed")
+    v = ShopifyAPI::OrderRisk.find(284138680, params: { order_id: 450789469 })
+    assert(v.destroy)
   end
 
   def test_update_order_risk
-    fake "orders/450789469/risks/284138680", :method => :get, :body => load_fixture('order_risk')
-    fake "orders/450789469/risks/284138680", :method => :put, :body => load_fixture('order_risk')
+    fake("orders/450789469/risks/284138680", method: :get, body: load_fixture('order_risk'))
+    fake("orders/450789469/risks/284138680", method: :put, body: load_fixture('order_risk'))
 
-    v = ShopifyAPI::OrderRisk.find(284138680, :params => {:order_id => 450789469})
+    v = ShopifyAPI::OrderRisk.find(284138680, params: { order_id: 450789469 })
     v.position = 3
     v.save
   end