shipit-engine 0.39.0 → 0.40.0

data/test/jobs/github_sync_job_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit
@@ -46,34 +47,34 @@ module Shipit
         ["yoloshipit!", false],
         ["fix it!", false],
         ["sheep it!", false],
-        ["lets go", false],
+        ["lets go", false]
       ]
-      assert_equal initial_queue, @stack.undeployed_commits.map { |c| [c.title, c.locked?] }
+      assert_equal(initial_queue, @stack.undeployed_commits.map { |c| [c.title, c.locked?] })
 
       author = stub(
         id: 1234,
         login: 'bob',
         name: 'Bob the Builder',
         email: 'bob@bob.com',
-        date: '2011-04-14T16:00:49Z',
+        date: '2011-04-14T16:00:49Z'
       )
       @job.expects(:fetch_missing_commits).returns([
-        [
-          stub(
-            sha: '36514755579bfb5bc313f403b216f4347a027990',
-            author: author,
-            committer: author,
-            stats: nil,
-            commit: stub(
-              sha: '36514755579bfb5bc313f403b216f4347a027990',
-              message: 'Revert "fix it!"',
-              author: author,
-              committer: author,
-            ),
-          ),
-        ],
-        shipit_commits(:fifth),
-      ])
+                                                     [
+                                                       stub(
+                                                         sha: '36514755579bfb5bc313f403b216f4347a027990',
+                                                         author:,
+                                                         committer: author,
+                                                         stats: nil,
+                                                         commit: stub(
+                                                           sha: '36514755579bfb5bc313f403b216f4347a027990',
+                                                           message: 'Revert "fix it!"',
+                                                           author:,
+                                                           committer: author
+                                                         )
+                                                       )
+                                                     ],
+                                                     shipit_commits(:fifth)
+                                                   ])
       @job.perform(stack_id: @stack.id)
 
       final_queue = [
@@ -82,9 +83,9 @@ module Shipit
         ["yoloshipit!", true],
         ["fix it!", true],
         ["sheep it!", false],
-        ["lets go", false],
+        ["lets go", false]
       ]
-      assert_equal final_queue, @stack.reload.undeployed_commits.map { |c| [c.title, c.locked?] }
+      assert_equal(final_queue, @stack.reload.undeployed_commits.map { |c| [c.title, c.locked?] })
     end
 
     test "#fetch_missing_commits returns the commits in the reverse order if it doesn't know the parent" do

data/test/jobs/mark_deploy_healthy_job_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit

data/test/jobs/perform_task_job_test.rb

@@ -1,11 +1,11 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit
   class PerformTaskJobTest < ActiveSupport::TestCase
     class FakeSuccessfulCommand
-      def run
-      end
+      def run; end
 
       def success?
         true
@@ -94,7 +94,7 @@ module Shipit
     end
 
     test "marks deploy as `failed` if a command exit with an error code" do
-      Shipit::TaskExecutionStrategy::Default.any_instance.expects(:capture!).at_least_once.raises(Command::Error.new('something'))
+      Shipit::TaskExecutionStrategy::Default.any_instance.stubs(:capture!).at_least_once.raises(Command::Error.new('something'))
       @job.perform(@deploy)
       assert_equal 'failed', @deploy.reload.status
     end

data/test/jobs/process_merge_requests_job_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit
@@ -18,15 +19,15 @@ module Shipit
 
     test "#perform rejects unmergeable PRs and merge the others" do
       MergeRequest.any_instance.stubs(:refresh!)
-      stub_request(:put, "#{@pending_pr.api_url}/merge").to_return(status: %w(200 OK), body: {
+      stub_request(:put, "#{@pending_pr.api_url}/merge").to_return(status: %w[200 OK], body: {
         sha: "6dcb09b5b57875f334f61aebed695e2e4193db5e",
         merged: true,
-        message: "Pull Request successfully merged",
+        message: "Pull Request successfully merged"
       }.to_json)
       branch_url = "https://api.github.com/repos/shopify/shipit-engine/git/refs/heads/feature-62"
-      stub_request(:delete, branch_url).to_return(status: %w(204 No content))
+      stub_request(:delete, branch_url).to_return(status: %w[204 No content])
       pulls_url = "https://api.github.com/repos/shopify/shipit-engine/pulls?base=feature-62"
-      stub_request(:get, pulls_url).to_return(status: %w(200 OK), body: '[]')
+      stub_request(:get, pulls_url).to_return(status: %w[200 OK], body: '[]')
 
       @job.perform(@stack)
 
@@ -36,9 +37,9 @@ module Shipit
 
     test "#perform rejects PRs if the merge attempt fails" do
       MergeRequest.any_instance.stubs(:refresh!)
-      stub_request(:put, "#{@pending_pr.api_url}/merge").to_return(status: %w(405 Method not allowed), body: {
+      stub_request(:put, "#{@pending_pr.api_url}/merge").to_return(status: %w[405 Method not allowed], body: {
         message: "Pull Request is not mergeable",
-        documentation_url: "https://developer.github.com/v3/pulls/#merge-a-pull-request-merge-button",
+        documentation_url: "https://developer.github.com/v3/pulls/#merge-a-pull-request-merge-button"
       }.to_json)
 
       @job.perform(@stack)

data/test/jobs/purge_old_deliveries_job_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit

data/test/jobs/reap_dead_tasks_job_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit

data/test/jobs/refresh_github_user_job_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit

data/test/jobs/refresh_status_job_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit

data/test/jobs/shipit/background_job_test.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+module Shipit
+  class BackgroundJobTest < ActiveSupport::TestCase
+    setup do
+      @stack = shipit_stacks(:shipit)
+      @last_commit = @stack.commits.last
+      @job = CacheDeploySpecJob.new
+      @user = shipit_users(:walrus)
+    end
+
+    test "#perform retries on Octokit secondary rate limit exceptions" do
+      freeze_time do
+        Octokit::Forbidden.any_instance.expects(:response_headers)
+                          .returns({ "Retry-After" => 45 })
+
+        Shipit.github.api.expects(:user).with(@user.github_id).raises(Octokit::TooManyRequests)
+
+        assert_enqueued_with(job: BackgroundStubJob, at: Time.now + 45.seconds) do
+          BackgroundStubJob.perform_now(@user)
+        end
+      end
+    end
+
+    class BackgroundStubJob < BackgroundJob
+      queue_as :default
+
+      def perform(user)
+        Shipit.github.api.user(user.github_id)
+      end
+    end
+  end
+end

data/test/jobs/shipit/continuous_delivery_job_test.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+module Shipit
+  class ContinuousDeliveryJobTest < ActiveSupport::TestCase
+    test "calls trigger_continous_delivery" do
+      stack = shipit_stacks(:shipit)
+      stack.stubs(:continuous_deployment?).returns(true).once
+      stack.stubs(:occupied).returns(false).once
+      stack.expects(:trigger_continuous_delivery).once
+
+      Shipit::ContinuousDeliveryJob.new.perform(stack)
+    end
+
+    test "does not call trigger_continuous_delivery if outside of schedule" do
+      freeze_time do
+        monday_9am = Date.current.monday.at_beginning_of_day.advance(hours: 9)
+        travel_to(monday_9am)
+
+        stack = shipit_stacks(:shipit)
+        stack.create_continuous_delivery_schedule!(monday_start: "09:30")
+
+        stack.stubs(:continuous_deployment?).returns(true).once
+        stack.expects(:trigger_continuous_delivery).never
+
+        Shipit::ContinuousDeliveryJob.new.perform(stack)
+      end
+    end
+  end
+end

data/test/jobs/unique_job_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit
@@ -20,7 +21,8 @@ module Shipit
     test "the lock key is serialized" do
       task = shipit_tasks(:shipit_restart)
       job = ChunkRollupJob.new(task)
-      key = %(Shipit::ChunkRollupJob-{"_aj_globalid"=>"gid://shipit/Shipit::Task/#{task.id}"})
+      args = { "_aj_globalid" => "gid://shipit/Shipit::Task/#{task.id}" }
+      key = %(Shipit::ChunkRollupJob-#{args})
       assert_equal key, job.lock_key(*job.arguments)
     end
   end

data/test/jobs/update_github_last_deployed_ref_job_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit

data/test/middleware/same_site_cookie_middleware_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit
@@ -14,8 +15,7 @@ module Shipit
     end
 
     def env_for_url(url)
-      env = Rack::MockRequest.env_for(url)
-      env
+      Rack::MockRequest.env_for(url)
     end
 
     def middleware

data/test/models/api_client_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit

data/test/models/commit_checks_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 require 'tmpdir'
 
@@ -71,7 +72,7 @@ module Shipit
         '',
         '$ echo review',
         'review',
-        '',
+        ''
       ]
       assert_equal 'success', @checks.status
       assert_equal lines, @checks.output.lines.map(&:strip)

data/test/models/commit_deployment_status_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit
@@ -17,7 +18,7 @@ module Shipit
         'in_progress',
         target_url: "http://shipit.com/shopify/shipit-engine/production/deploys/#{@task.id}",
         description: "walrus triggered the deploy of shopify/shipit-engine/production to #{@deployment.short_sha}",
-        environment_url: "https://shipit.shopify.com",
+        environment_url: "https://shipit.shopify.com"
       ).returns(response)
 
       @status.create_on_github!

data/test/models/commit_deployment_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit
@@ -23,9 +24,9 @@ module Shipit
           shipit: {
             task_id: 4,
             from_sha: 'f890fd8b5f2be05d1fedb763a3605ee461c39074',
-            to_sha: '467578b362bf2b4df5903e1c7960929361c3435a',
-          },
-        }.to_json,
+            to_sha: '467578b362bf2b4df5903e1c7960929361c3435a'
+          }
+        }.to_json
       ).returns(deployment_response)
 
       @deployment.create_on_github!