shipit-engine 0.39.0 → 0.40.0

data/test/controllers/rollbacks_controller_test.rb

@@ -1,10 +1,11 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit
   class RollbacksControllerTest < ActionController::TestCase
     setup do
-      Deploy.where(status: %w(running pending)).update_all(status: 'success')
+      Deploy.where(status: %w[running pending]).update_all(status: 'success')
       @stack = shipit_stacks(:shipit)
       @deploy = shipit_deploys(:shipit)
       session[:user_id] = shipit_users(:walrus).id
@@ -18,7 +19,7 @@ module Shipit
 
     test ":create can receive an :env hash" do
       env = { 'SAFETY_DISABLED' => '1' }
-      post :create, params: { stack_id: @stack.to_param, rollback: { parent_id: @deploy.id, env: env } }
+      post :create, params: { stack_id: @stack.to_param, rollback: { parent_id: @deploy.id, env: } }
       new_rollback = Rollback.last
       assert_equal env, new_rollback.env
     end

data/test/controllers/stacks_controller_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit
@@ -54,7 +55,7 @@ module Shipit
       assert_response :forbidden
       assert_equal(
         'You must be a member of cyclimse/cooks or shopify/developers to access this application.',
-        response.body,
+        response.body
       )
     end
 
@@ -98,6 +99,7 @@ module Shipit
     test "#show handles locked stacks without a lock_author" do
       @stack.update!(lock_reason: "I am a lock with no author")
       get :show, params: { id: @stack.to_param }
+      assert_response :ok
     end
 
     test "#show auto-links URLs in lock reason" do
@@ -114,8 +116,8 @@ module Shipit
             repo_name: 'rails',
             repo_owner: 'rails',
             environment: 'staging',
-            branch: 'staging',
-          },
+            branch: 'staging'
+          }
         }
       end
 
@@ -240,8 +242,8 @@ module Shipit
           repo_owner: 'rails',
           environment: 'staging',
           branch: 'staging',
-          deploy_url: 'Javascript:alert(1);',
-        },
+          deploy_url: 'Javascript:alert(1);'
+        }
       }
       assert_response :success
       assert_equal 'Deploy url is invalid', flash[:warning]

data/test/controllers/status_controller_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit

data/test/controllers/tasks_controller_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit
@@ -54,7 +55,7 @@ module Shipit
     test "tasks with variables defined in the shipit.yml can be triggered with their variables set" do
       env = { "FOO" => "0" }
 
-      post :create, params: { stack_id: @stack, definition_id: @definition.id, task: { env: env }, force: 'true' }
+      post :create, params: { stack_id: @stack, definition_id: @definition.id, task: { env: }, force: 'true' }
 
       assert_redirected_to stack_tasks_path(@stack, Task.last)
     end
@@ -113,7 +114,7 @@ module Shipit
 
       get :tail, params: { stack_id: @stack.to_param, id: @task.id }, format: :json
       assert_response :success
-      assert_json_keys %w(url status output)
+      assert_json_keys %w[url status output]
       assert_json 'status', @task.status
       assert_json 'output', @task.chunk_output
       assert_json 'url', "/shopify/shipit-engine/production/tasks/#{@task.id}/tail?last_byte=#{last_chunk}"
@@ -125,7 +126,7 @@ module Shipit
 
       get :tail, params: { stack_id: @stack.to_param, id: @task.id, last_byte: "50" }, format: :json
       assert_response :success
-      assert_json_keys %w(url status output)
+      assert_json_keys %w[url status output]
     end
 
     test ":tail doesn't returns the next url if the task is finished" do
@@ -141,7 +142,7 @@ module Shipit
 
       get :tail, params: { stack_id: @stack.to_param, id: @task.id }, format: :json
       assert_response :success
-      assert_json_keys %w(status output rollback_url)
+      assert_json_keys %w[status output rollback_url]
     end
 
     test ":lookup returns stack task url if the task is an instance of Task" do

data/test/controllers/webhooks_controller_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit
@@ -24,7 +25,7 @@ module Shipit
 
       body = JSON.parse(payload(:push_master)).to_json
       assert_enqueued_with(job: GithubSyncJob, args: [stack_id: @stack.id]) do
-        post :create, body: body, as: :json
+        post :create, body:, as: :json
       end
     end
 
@@ -43,7 +44,7 @@ module Shipit
 
       body = JSON.parse(payload(:status_master)).merge(repository_params).to_json
       assert_difference 'commit.statuses.count', 1 do
-        post :create, body: body, as: :json
+        post :create, body:, as: :json
       end
 
       status = commit.statuses.last
@@ -74,7 +75,7 @@ module Shipit
 
       body = JSON.parse(payload(:check_suite_master)).to_json
       assert_enqueued_with(job: RefreshCheckRunsJob) do
-        post :create, body: body, as: :json
+        post :create, body:, as: :json
         assert_response :ok
       end
     end
@@ -107,11 +108,11 @@ module Shipit
       @request.headers['X-Github-Event'] = 'membership'
       assert_difference -> { Team.count }, 1 do
         post :create, as: :json, body: membership_params.merge(team: {
-          id: 48,
-          name: 'Ouiche Cooks',
-          slug: 'ouiche-cooks',
-          url: 'https://example.com',
-        }).to_json
+                                                                 id: 48,
+                                                                 name: 'Ouiche Cooks',
+                                                                 slug: 'ouiche-cooks',
+                                                                 url: 'https://example.com'
+                                                               }).to_json
         assert_response :ok
       end
     end
@@ -201,7 +202,7 @@ module Shipit
         login: 'george',
         email: 'george@cyclim.se',
         avatar_url: 'https://avatars.githubusercontent.com/u/42?v=3',
-        url: 'https://api.github.com/user/george',
+        url: 'https://api.github.com/user/george'
       )
     end
   end

data/test/dummy/config/application.rb

@@ -17,7 +17,7 @@ end
 
 module Shipit
   class Application < Rails::Application
-    config.load_defaults 7.1
+    config.load_defaults 8.0
     config.active_record.encryption.support_sha1_for_non_deterministic_encryption = true
   end
 end

data/test/dummy/db/schema.rb

@@ -10,8 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 2023_07_03_181143) do
-
+ActiveRecord::Schema[7.2].define(version: 2025_02_07_203053) do
   create_table "api_clients", force: :cascade do |t|
     t.text "permissions", limit: 65535
     t.integer "creator_id", limit: 4
@@ -52,7 +51,7 @@ ActiveRecord::Schema.define(version: 2023_07_03_181143) do
   create_table "commit_deployments", force: :cascade do |t|
     t.integer "commit_id"
     t.integer "task_id"
-    t.integer "github_id"
+    t.bigint "github_id"
     t.string "api_url"
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
@@ -87,6 +86,34 @@ ActiveRecord::Schema.define(version: 2023_07_03_181143) do
     t.index ["stack_id"], name: "index_commits_on_stack_id"
   end
 
+  create_table "continuous_delivery_schedules", force: :cascade do |t|
+    t.integer "stack_id", null: false
+    t.boolean "sunday_enabled", default: true, null: false
+    t.time "sunday_start", default: "2000-01-01 00:00:00", null: false
+    t.time "sunday_end", default: "2000-01-01 23:59:00", null: false
+    t.boolean "monday_enabled", default: true, null: false
+    t.time "monday_start", default: "2000-01-01 00:00:00", null: false
+    t.time "monday_end", default: "2000-01-01 23:59:00", null: false
+    t.boolean "tuesday_enabled", default: true, null: false
+    t.time "tuesday_start", default: "2000-01-01 00:00:00", null: false
+    t.time "tuesday_end", default: "2000-01-01 23:59:00", null: false
+    t.boolean "wednesday_enabled", default: true, null: false
+    t.time "wednesday_start", default: "2000-01-01 00:00:00", null: false
+    t.time "wednesday_end", default: "2000-01-01 23:59:00", null: false
+    t.boolean "thursday_enabled", default: true, null: false
+    t.time "thursday_start", default: "2000-01-01 00:00:00", null: false
+    t.time "thursday_end", default: "2000-01-01 23:59:00", null: false
+    t.boolean "friday_enabled", default: true, null: false
+    t.time "friday_start", default: "2000-01-01 00:00:00", null: false
+    t.time "friday_end", default: "2000-01-01 23:59:00", null: false
+    t.boolean "saturday_enabled", default: true, null: false
+    t.time "saturday_start", default: "2000-01-01 00:00:00", null: false
+    t.time "saturday_end", default: "2000-01-01 23:59:00", null: false
+    t.datetime "created_at", null: false
+    t.datetime "updated_at", null: false
+    t.index ["stack_id"], name: "index_continuous_delivery_schedules_on_stack_id", unique: true
+  end
+
   create_table "deliveries", force: :cascade do |t|
     t.integer "hook_id", limit: 4, null: false
     t.string "status", limit: 50, default: "pending", null: false
@@ -106,7 +133,7 @@ ActiveRecord::Schema.define(version: 2023_07_03_181143) do
 
   create_table "github_hooks", force: :cascade do |t|
     t.integer "stack_id", limit: 4
-    t.integer "github_id", limit: 4
+    t.bigint "github_id"
     t.string "event", limit: 50, null: false
     t.datetime "created_at"
     t.datetime "updated_at"
@@ -313,7 +340,7 @@ ActiveRecord::Schema.define(version: 2023_07_03_181143) do
   end
 
   create_table "teams", force: :cascade do |t|
-    t.integer "github_id", limit: 4
+    t.bigint "github_id"
     t.string "api_url", limit: 255
     t.string "slug", limit: 255
     t.string "name", limit: 255
@@ -324,7 +351,7 @@ ActiveRecord::Schema.define(version: 2023_07_03_181143) do
   end
 
   create_table "users", force: :cascade do |t|
-    t.integer "github_id", limit: 4
+    t.bigint "github_id"
     t.string "name", limit: 255, null: false
     t.string "email", limit: 255
     t.string "login", limit: 39

data/test/fixtures/shipit/commits.yml

@@ -258,7 +258,7 @@ canaries_fifth:
   updated_at: <%= 8.days.ago.to_formatted_s(:db) %>
   created_at: <%= 1.day.ago.to_formatted_s(:db) %>
 
-undeployed_1:
+undeployed1:
   id: 401
   sha: 4d9278037b872fd9a6690523e411ecb3aa181355
   message: "lets go"
@@ -271,7 +271,7 @@ undeployed_1:
   deletions: 24
   updated_at: <%= 8.days.ago.to_formatted_s(:db) %>
 
-undeployed_2:
+undeployed2:
   id: 402
   sha: 4890fd8b5f2be05d1fedb763a3605ee461c39074
   message: "sheep it!"
@@ -284,7 +284,7 @@ undeployed_2:
   deletions: 1
   updated_at: <%= 8.days.ago.to_formatted_s(:db) %>
 
-undeployed_3:
+undeployed3:
   id: 403
   sha: 467578b362bf2b4df5903e1c7960929361c39074
   message: "fix it!"
@@ -297,7 +297,7 @@ undeployed_3:
   deletions: 64
   updated_at: <%= 8.days.ago.to_formatted_s(:db) %>
 
-undeployed_4:
+undeployed4:
   id: 404
   sha: 447578b362bf2b4df5903e1c7960929361c3435a
   message: "Merge pull request #7 from shipit-engine/yoloshipit\n\nyoloshipit!"
@@ -310,7 +310,7 @@ undeployed_4:
   deletions: 342
   updated_at: <%= 8.days.ago.to_formatted_s(:db) %>
 
-undeployed_5:
+undeployed5:
   id: 405
   sha: 457578b362bf2b4df5903e1c7960929361c3435a
   message: "Merge pull request #7 from shipit-engine/yoloshipit\n\nyoloshipit!"
@@ -323,7 +323,7 @@ undeployed_5:
   deletions: 342
   updated_at: <%= 8.days.ago.to_formatted_s(:db) %>
 
-undeployed_6:
+undeployed6:
   id: 406
   sha: 467578b362bf2b4df5903e1c7960929361c3435a
   message: "Merge pull request #7 from shipit-engine/yoloshipit\n\nyoloshipit!"
@@ -336,7 +336,7 @@ undeployed_6:
   deletions: 342
   updated_at: <%= 8.days.ago.to_formatted_s(:db) %>
 
-undeployed_7:
+undeployed7:
   id: 407
   sha: 477578b362bf2b4df5903e1c7960929361c3435a
   message: "Merge pull request #7 from shipit-engine/yoloshipit\n\nyoloshipit!"

data/test/fixtures/shipit/stacks.yml

@@ -10,8 +10,7 @@ shipit:
   cached_deploy_spec: |-
     {
       "machine": {
-        "environment": {
-        }
+        "environment": {}
       },
       "review": {
         "checklist": [
@@ -28,9 +27,7 @@ shipit:
         ]
       },
       "dependencies": {
-        "override": [
-
-        ]
+        "override": []
       },
       "deploy": {
         "override": null,
@@ -494,8 +491,7 @@ review_stack:
   cached_deploy_spec: |-
     {
       "machine": {
-        "environment": {
-        }
+        "environment": {}
       },
       "review": {
         "checklist": [
@@ -512,9 +508,7 @@ review_stack:
         ]
       },
       "dependencies": {
-        "override": [
-
-        ]
+        "override": []
       },
       "deploy": {
         "override": null,

data/test/fixtures/shipit/tasks.yml

@@ -223,7 +223,7 @@ shipit_with_title_parsing_issue:
     {
       "id": "bad-title",
       "action": "Task with bad title",
-      "title": "Using the %{WRONG_VARIABLE_NAME}",
+      "title": "Using the %<WRONG_VARIABLE_NAME>",
       "description": "This task uses the wrong variable name",
       "variables": [
         {"name": "VARIABLE_NAME", "title": "Any old variable"}
@@ -238,7 +238,7 @@ shipit_with_title_parsing_issue:
   started_at: <%= (60 - 3).minutes.ago.to_formatted_s(:db) %>
   ended_at: <%= (60 - 4).minutes.ago.to_formatted_s(:db) %>
 
-shipit_undeployed_1:
+shipit_undeployed1:
   id: 201
   user: walrus
   since_commit_id: 401
@@ -252,7 +252,7 @@ shipit_undeployed_1:
   started_at: <%= (60 - 1).minutes.ago.to_formatted_s(:db) %>
   ended_at: <%= (60 - 3).minutes.ago.to_formatted_s(:db) %>
 
-shipit_undeployed_2:
+shipit_undeployed2:
   id: 202
   user: walrus
   since_commit_id: 402

data/test/helpers/api_helper.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module ApiHelper
   private
 
@@ -14,9 +15,7 @@ module Shipit
     private
 
     def process(_action, **kwargs)
-      if kwargs[:method] != "GET"
-        kwargs[:as] ||= :json
-      end
+      kwargs[:as] ||= :json if kwargs[:method] != "GET"
       super
     end
   end

data/test/helpers/fixture_aliases_helper.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module FixtureAliasesHelper
   def shipit_deploys(*args)
     shipit_tasks(*args)

data/test/helpers/hooks_helper.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module HooksHelper
   def expect_hook(event, stack = nil, payload = nil)
     spy_on_hook

data/test/helpers/json_helper.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module JSONHelper
   UNDEFINED = Object.new.freeze
   private_constant :UNDEFINED
@@ -8,7 +9,7 @@ module JSONHelper
   end
 
   def assert_json_document(document, path, expected_value = UNDEFINED)
-    value = follow_path(path.to_s.split('.'), document: document)
+    value = follow_path(path.to_s.split('.'), document:)
     if block_given?
       yield value
     elsif expected_value == UNDEFINED
@@ -26,7 +27,7 @@ module JSONHelper
       path = nil
     end
 
-    value = follow_path(path.to_s.split('.'), document: document)
+    value = follow_path(path.to_s.split('.'), document:)
     case value
     when Hash
       assert_equal(keys.sort, value.keys.sort)
@@ -38,7 +39,7 @@ module JSONHelper
   def assert_no_json(path, document: response.body)
     segments = path.to_s.split('.')
     last_segment = segments.pop
-    leaf = follow_path(segments, document: document)
+    leaf = follow_path(segments, document:)
     case leaf
     when Hash
       refute(leaf.key?(last_segment), "Expected #{leaf.inspect} not to include #{last_segment.inspect}")

data/test/helpers/links_helper.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
+
 module LinksHelper
-  LINKS_PATTERN = /\<(.*?)\>; rel="(\w+)"/
+  LINKS_PATTERN = /<(.*?)>; rel="(\w+)"/
 
   def assert_link(rel, url)
     assert_includes(response_links, rel)

data/test/helpers/payloads_helper.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module PayloadsHelper
   def payload(name)
     Shipit::Engine.root.join('test/fixtures/payloads', "#{name}.json").read

data/test/helpers/queries_helper.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module QueriesHelper
   def assert_no_queries(ignored_sql = nil, &block)
     assert_queries(0, ignored_sql, &block)
@@ -31,15 +32,14 @@ module QueriesHelper
       /^BEGIN/,
       /^COMMIT/,
       /^SHOW FULL FIELDS/,
-      /^SHOW TABLES LIKE/,
+      /^SHOW TABLES LIKE/
     ]
 
     # FIXME: this needs to be refactored so specific database can add their own
     # ignored SQL.  This ignored SQL is for Oracle.
     ignored_sql.concat([/^select .*nextval/i, /^SAVEPOINT/, /^ROLLBACK TO/, /^\s*select .* from all_triggers/im])
 
-    attr_reader :ignore
-    attr_reader :log
+    attr_reader :ignore, :log
 
     def initialize(ignore = nil)
       @ignore = ignore || self.class.ignored_sql
@@ -52,6 +52,7 @@ module QueriesHelper
       # FIXME: this seems bad. we should probably have a better way to indicate
       # the query was cached
       return if values[:name] == 'CACHE' || ignore.any? { |x| x =~ sql }
+
       log << sql
     end
   end

data/test/jobs/cache_deploy_spec_job_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit
@@ -10,12 +11,12 @@ module Shipit
     end
 
     test "#perform checkout the repository to the last recorded commit and cache the deploy spec" do
-      @stack.update!(cached_deploy_spec: DeploySpec.new('review' => { 'checklist' => %w(foo bar) }))
+      @stack.update!(cached_deploy_spec: DeploySpec.new('review' => { 'checklist' => %w[foo bar] }))
 
       dir = Pathname(Dir.tmpdir)
       StackCommands.any_instance.expects(:with_temporary_working_directory).with(commit: @last_commit).yields(dir)
 
-      assert_equal %w(foo bar), @stack.checklist
+      assert_equal %w[foo bar], @stack.checklist
       @job.perform(@stack)
       assert_equal [], @stack.reload.checklist
     end

data/test/jobs/chunk_rollup_job_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit
@@ -25,7 +26,7 @@ module Shipit
     test "#peform ignores non-finished jobs" do
       logger = mock
       logger.expects(:error).once
-      @job.stubs(logger: logger)
+      @job.stubs(logger:)
 
       @task.update_attribute(:status, :pending)
 
@@ -35,7 +36,7 @@ module Shipit
     test "#perform ignores tasks already rolled up" do
       logger = mock
       logger.expects(:error).once
-      @job.stubs(logger: logger)
+      @job.stubs(logger:)
 
       @task.rolled_up = true
 

data/test/jobs/deliver_hook_job_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit

data/test/jobs/destroy_repository_job_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit

data/test/jobs/destroy_stack_job_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit
@@ -24,5 +25,16 @@ module Shipit
         @job.perform(stack)
       end
     end
+
+    test "perform destroys the all Status of related commits" do
+      stack = shipit_stacks(:shipit)
+      Shipit.legacy_github_api.stubs(:remove_hook)
+
+      assert_changes -> { Status.count }, 'Statuses are not deleted' do
+        @job.perform(stack)
+      end
+
+      refute_predicate Status.count, :zero?
+    end
   end
 end

data/test/jobs/emit_event_job_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit

data/test/jobs/fetch_commit_stats_job_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit

data/test/jobs/fetch_deployed_revision_job_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit