shakapacker 7.0.2 → 7.1.0

data/lib/shakapacker/webpack_runner.rb

@@ -19,6 +19,7 @@ module Shakapacker
     def run
       env = Shakapacker::Compiler.env
       env["SHAKAPACKER_CONFIG"] = @shakapacker_config
+      env["NODE_OPTIONS"] = ENV["NODE_OPTIONS"] || ""
 
       cmd = if node_modules_bin_exist?
         ["#{@node_modules_bin_path}/webpack"]
@@ -36,15 +37,15 @@ module Shakapacker
       end
 
       if @argv.delete("--debug-shakapacker") || @argv.delete("--debug-webpacker")
-        cmd = ["node", "--inspect-brk"] + cmd
+        env["NODE_OPTIONS"] = "#{env["NODE_OPTIONS"]} --inspect-brk"
       end
 
       if @argv.delete "--trace-deprecation"
-        cmd = ["node", "--trace-deprecation"] + cmd
+        env["NODE_OPTIONS"] = "#{env["NODE_OPTIONS"]} --trace-deprecation"
       end
 
       if @argv.delete "--no-deprecation"
-        cmd = ["node", "--no-deprecation"] + cmd
+        env["NODE_OPTIONS"] = "#{env["NODE_OPTIONS"]} --no-deprecation"
       end
 
       # Webpack commands are not compatible with --config option.

data/lib/tasks/shakapacker/binstubs.rake

@@ -7,9 +7,9 @@ namespace :shakapacker do
     prefix = task.name.split(/#|shakapacker:binstubs/).first
 
     if Rails::VERSION::MAJOR >= 5
-      exec "#{RbConfig.ruby} #{bin_path}/rails #{prefix}app:template LOCATION='#{binstubs_template_path}'"
+      exec "#{RbConfig.ruby} '#{bin_path}/rails' #{prefix}app:template LOCATION='#{binstubs_template_path}'"
     else
-      exec "#{RbConfig.ruby} #{bin_path}/rake #{prefix}rails:template LOCATION='#{binstubs_template_path}'"
+      exec "#{RbConfig.ruby} '#{bin_path}/rake' #{prefix}rails:template LOCATION='#{binstubs_template_path}'"
     end
   end
 end

data/lib/tasks/shakapacker/check_binstubs.rake

@@ -1,12 +1,17 @@
 namespace :shakapacker do
   desc "Verifies that bin/shakapacker is present"
   task :check_binstubs do
-    verify_file_existance("bin/shakapacker", "bin/webpacker")
-    verify_file_existance("bin/shakapacker-dev-server", "bin/webpacker-dev-server")
+    verify_file_existence("bin/shakapacker", "bin/webpacker")
+    verify_file_existence("bin/shakapacker-dev-server", "bin/webpacker-dev-server")
   end
 end
 
 def verify_file_existance(main_file, alternative_file)
+  puts "verify_file_existance is deprecated - use verify_file_existence instead"
+  verify_file_existence(main_file, alternative_file)
+end
+
+def verify_file_existence(main_file, alternative_file)
   unless File.exist?(Rails.root.join(main_file))
     if File.exist?(Rails.root.join(alternative_file))
       Shakapacker.puts_deprecation_message(

data/lib/tasks/shakapacker/install.rake

@@ -9,9 +9,9 @@ namespace :shakapacker do
     prefix = task.name.split(/#|shakapacker:install/).first
 
     if Rails::VERSION::MAJOR >= 5
-      exec "#{RbConfig.ruby} #{bin_path}/rails #{prefix}app:template LOCATION='#{install_template_path}'"
+      exec "#{RbConfig.ruby} '#{bin_path}/rails' #{prefix}app:template LOCATION='#{install_template_path}'"
     else
-      exec "#{RbConfig.ruby} #{bin_path}/rake #{prefix}rails:template LOCATION='#{install_template_path}'"
+      exec "#{RbConfig.ruby} '#{bin_path}/rake' #{prefix}rails:template LOCATION='#{install_template_path}'"
     end
   end
 end

data/package/__tests__/index.js

@@ -1,4 +1,5 @@
 const index = require('../index')
+const { generateWebpackConfig } = require("../index");
 
 describe('index', () => {
   test('exports webpack-merge v5 functions', () => {
@@ -19,4 +20,27 @@ describe('index', () => {
     expect(webpackConfig2).not.toHaveProperty('newKey')
     expect(webpackConfig2.output.path).not.toEqual('new value')
   })
+
+  test('webpackConfig merges extra config', () => {
+    const { generateWebpackConfig } = require('../index')
+
+    const webpackConfig = generateWebpackConfig({
+       newKey: 'new value',
+       output: {
+         path: 'new path'
+      }
+    })
+
+    expect(webpackConfig).toHaveProperty('newKey', 'new value')
+    expect(webpackConfig).toHaveProperty('output.path', 'new path')
+    expect(webpackConfig).toHaveProperty('output.publicPath', '/packs/')
+  })
+
+  test('webpackConfig errors if multiple configs are provided', () => {
+    const { generateWebpackConfig } = require('../index')
+
+    expect(() => generateWebpackConfig({}, {})).toThrow(
+      'use webpack-merge to merge configs before passing them to Shakapacker'
+    )
+  })
 })

data/package/environments/__tests__/base-bc.js

@@ -1,6 +1,6 @@
 /* global test expect, describe, afterAll, beforeEach */
 
-// environment.js expects to find config/webapacker.yml and resolved modules from
+// environment.js expects to find config/webpacker.yml and resolved modules from
 // the root of a Rails project
 
 const { resetEnv, chdirWebpackerTestApp } = require('../../utils/helpers')

data/package/environments/__tests__/development.js

@@ -16,10 +16,10 @@ describe('Development specific config', () => {
     test('sets filename to use contentHash', () => {
       const config = require("../../config");
       config.useContentHash = true
-      const environmnetConfig = require('../development')
+      const environmentConfig = require('../development')
 
-      expect(environmnetConfig.output.filename).toEqual('js/[name]-[contenthash].js')
-      expect(environmnetConfig.output.chunkFilename).toEqual(
+      expect(environmentConfig.output.filename).toEqual('js/[name]-[contenthash].js')
+      expect(environmentConfig.output.chunkFilename).toEqual(
         'js/[name]-[contenthash].chunk.js'
       )
     })
@@ -29,10 +29,10 @@ describe('Development specific config', () => {
     test('sets filename without using contentHash', () => {
       const config = require("../../config");
       config.useContentHash = false
-      const environmnetConfig = require('../development')
+      const environmentConfig = require('../development')
 
-      expect(environmnetConfig.output.filename).toEqual('js/[name].js')
-      expect(environmnetConfig.output.chunkFilename).toEqual(
+      expect(environmentConfig.output.filename).toEqual('js/[name].js')
+      expect(environmentConfig.output.chunkFilename).toEqual(
         'js/[name].chunk.js'
       )
     })
@@ -42,10 +42,10 @@ describe('Development specific config', () => {
     test('sets filename without using contentHash', () => {
       const config = require("../../config");
       delete config.useContentHash
-      const environmnetConfig = require('../development')
+      const environmentConfig = require('../development')
 
-      expect(environmnetConfig.output.filename).toEqual('js/[name].js')
-      expect(environmnetConfig.output.chunkFilename).toEqual(
+      expect(environmentConfig.output.filename).toEqual('js/[name].js')
+      expect(environmentConfig.output.chunkFilename).toEqual(
         'js/[name].chunk.js'
       )
     })

data/package/environments/__tests__/production.js

@@ -16,10 +16,10 @@ describe('Production specific config', () => {
     test('sets filename to use contentHash', () => {
       const config = require("../../config");
       config.useContentHash = true
-      const environmnetConfig = require('../production')
+      const environmentConfig = require('../production')
 
-      expect(environmnetConfig.output.filename).toEqual('js/[name]-[contenthash].js')
-      expect(environmnetConfig.output.chunkFilename).toEqual(
+      expect(environmentConfig.output.filename).toEqual('js/[name]-[contenthash].js')
+      expect(environmentConfig.output.chunkFilename).toEqual(
         'js/[name]-[contenthash].chunk.js'
       )
     })
@@ -28,7 +28,7 @@ describe('Production specific config', () => {
       const consoleWarnSpy = jest.spyOn(console, 'warn');
       const config = require("../../config");
       config.useContentHash = true
-      const environmnetConfig = require('../production')
+      const environmentConfig = require('../production')
 
       expect(consoleWarnSpy).not.toHaveBeenCalledWith(
         expect.stringMatching(/Setting 'useContentHash' to 'false' in the production environment/)
@@ -42,10 +42,10 @@ describe('Production specific config', () => {
     test('sets filename to use contentHash', () => {
       const config = require("../../config");
       config.useContentHash = false
-      const environmnetConfig = require('../production')
+      const environmentConfig = require('../production')
 
-      expect(environmnetConfig.output.filename).toEqual('js/[name]-[contenthash].js')
-      expect(environmnetConfig.output.chunkFilename).toEqual(
+      expect(environmentConfig.output.filename).toEqual('js/[name]-[contenthash].js')
+      expect(environmentConfig.output.chunkFilename).toEqual(
         'js/[name]-[contenthash].chunk.js'
       )
     })
@@ -54,7 +54,7 @@ describe('Production specific config', () => {
       const consoleWarnSpy = jest.spyOn(console, 'warn');
       const config = require("../../config");
       config.useContentHash = false
-      const environmnetConfig = require('../production')
+      const environmentConfig = require('../production')
 
       expect(consoleWarnSpy).toHaveBeenCalledWith(
         expect.stringMatching(/Setting 'useContentHash' to 'false' in the production environment/)
@@ -68,10 +68,10 @@ describe('Production specific config', () => {
     test('sets filename to use contentHash', () => {
       const config = require("../../config");
       delete config.useContentHash
-      const environmnetConfig = require('../production')
+      const environmentConfig = require('../production')
 
-      expect(environmnetConfig.output.filename).toEqual('js/[name]-[contenthash].js')
-      expect(environmnetConfig.output.chunkFilename).toEqual(
+      expect(environmentConfig.output.filename).toEqual('js/[name]-[contenthash].js')
+      expect(environmentConfig.output.chunkFilename).toEqual(
         'js/[name]-[contenthash].chunk.js'
       )
     })
@@ -80,7 +80,7 @@ describe('Production specific config', () => {
       const consoleWarnSpy = jest.spyOn(console, 'warn');
       const config = require("../../config");
       delete config.useContentHash
-      const environmnetConfig = require('../production')
+      const environmentConfig = require('../production')
 
       expect(consoleWarnSpy).not.toHaveBeenCalledWith(
         expect.stringMatching(/Setting 'useContentHash' to 'false' in the production environment/)

data/package/index.d.ts

@@ -0,0 +1,61 @@
+declare module 'shakapacker' {
+  import { Configuration } from 'webpack'
+
+  export interface Config {
+    source_path: string
+    source_entry_path: string
+    nested_entries: boolean
+    css_extract_ignore_order_warnings: boolean
+    public_root_path: string
+    public_output_path: string
+    cache_path: string
+    webpack_compile_output: boolean
+    shakapacker_precompile: boolean
+    additional_paths: string[]
+    cache_manifest: boolean
+    webpack_loader: string
+    ensure_consistent_versioning: boolean
+    compiler_strategy: string
+    useContentHash: boolean
+    compile: boolean,
+    outputPath: string
+    publicPath: string
+    publicPathWithoutCDN: string
+    manifestPath: string
+  }
+
+  export interface Env {
+    railsEnv: string
+    nodeEnv: string
+    isProduction: boolean
+    isDevelopment: boolean
+    runningWebpackDevServer: boolean
+  }
+
+  export const config: Config
+  export const devServer: Record<string, unknown>
+  export function generateWebpackConfig(extraConfig?: Configuration): Configuration
+  export const globalMutableWebpackConfig: Configuration
+  export const baseConfig: Configuration
+  export const env: Env
+  export const rules: Record<string, unknown>
+  export function moduleExists(packageName: string): boolean
+  export function canProcess<T = unknown>(rule: string, fn: (modulePath: string) => T): T | null
+  export const inliningCss: boolean
+  export * from 'webpack-merge'
+}
+
+declare module 'shakapacker/package/babel/preset.js' {
+  import { ConfigAPI, PluginItem, TransformOptions } from '@babel/core'
+
+  interface RequiredTransformOptions {
+    plugins: PluginItem[]
+    presets: PluginItem[]
+  }
+
+  const defaultConfigFunc: (
+    api: ConfigAPI
+  ) => TransformOptions & RequiredTransformOptions
+
+  export = defaultConfigFunc
+}

data/package/index.js

@@ -19,9 +19,15 @@ const globalMutableWebpackConfig = () => {
   return environmentConfig
 }
 
-const generateWebpackConfig = () => {
+const generateWebpackConfig = (extraConfig = {}, ...extraArgs) => {
+  if (extraArgs.length > 0) {
+    throw new Error(
+      'Only one extra config may be passed here - use webpack-merge to merge configs before passing them to Shakapacker'
+    )
+  }
+
   const environmentConfig = globalMutableWebpackConfig()
-  const immutable = webpackMerge.merge({}, environmentConfig)
+  const immutable = webpackMerge.merge({}, environmentConfig, extraConfig)
   return immutable
 }
 

data/package.json

@@ -1,8 +1,9 @@
 {
   "name": "shakapacker",
-  "version": "7.0.2",
+  "version": "7.1.0",
   "description": "Use webpack to manage app-like JavaScript modules in Rails",
   "main": "package/index.js",
+  "types": "package/index.d.ts",
   "files": [
     "package",
     "lib/install/config/shakapacker.yml"
@@ -12,6 +13,8 @@
     "yarn": ">=1 <4"
   },
   "peerDependencies": {
+    "@types/babel__core": "^7.0.0",
+    "@types/webpack": "^5.0.0",
     "@babel/core": "^7.17.9",
     "@babel/plugin-transform-runtime": "^7.17.0",
     "@babel/preset-env": "^7.16.11",
@@ -25,6 +28,14 @@
     "webpack-dev-server": "^4.9.0",
     "webpack-merge": "^5.8.0"
   },
+  "peerDependenciesMeta": {
+    "@types/babel__core": {
+      "optional": true
+    },
+    "@types/webpack": {
+      "optional": true
+    }
+  },
   "dependencies": {
     "glob": "^7.2.0",
     "js-yaml": "^4.1.0",

data/rakelib/release.rake

@@ -25,7 +25,7 @@ Note, accept defaults for npmjs options. Script will pause to get 2FA tokens.
 
 Example: `rake release[2.1.0,false]`")
 task :create_release, %i[gem_version dry_run] do |_t, args|
-  # Check if there are uncommited changes
+  # Check if there are uncommitted changes
   Shakapacker::Utils::Misc.uncommitted_changes?(RaisingMessageHandler.new)
   args_hash = args.to_hash
 

data/spec/backward_compatibility_specs/compiler_spec.rb

@@ -26,7 +26,7 @@ describe "Webpacker::Compiler" do
     allow(Webpacker.compiler).to receive(:strategy).and_return(mocked_strategy)
 
     status = OpenStruct.new(success?: true)
-    allow(Open3).to receive(:capture3).and_return([:sterr, :stdout, status])
+    allow(Open3).to receive(:capture3).and_return([:stderr, :stdout, status])
 
     expect(Webpacker.compiler.compile).to be true
     expect(mocked_strategy).to have_received(:after_compile_hook)
@@ -40,7 +40,7 @@ describe "Webpacker::Compiler" do
     allow(Webpacker.compiler).to receive(:strategy).and_return(mocked_strategy)
 
     status = OpenStruct.new(success?: false)
-    allow(Open3).to receive(:capture3).and_return([:sterr, :stdout, status])
+    allow(Open3).to receive(:capture3).and_return([:stderr, :stdout, status])
 
     expect(Webpacker.compiler.compile).to be false
     expect(mocked_strategy).to have_received(:after_compile_hook)

data/spec/backward_compatibility_specs/compiler_strategy_spec.rb

@@ -2,17 +2,19 @@ require_relative "spec_helper_initializer"
 
 describe "Webpacker::CompilerStrategy" do
   describe "#from_config" do
-    it "returns and instance of MtimeStrategy when compiler_strategy is set to mtime" do
+    it "returns an instance of MtimeStrategy when compiler_strategy is set to mtime" do
       allow(Webpacker.config).to receive(:compiler_strategy).and_return("mtime")
+
       expect(Webpacker::CompilerStrategy.from_config).to be_an_instance_of(Webpacker::MtimeStrategy)
     end
 
-    it "returns and instance of DigestStrategy when compiler_strategy is set to digest" do
+    it "returns an instance of DigestStrategy when compiler_strategy is set to digest" do
       allow(Webpacker.config).to receive(:compiler_strategy).and_return("digest")
+
       expect(Webpacker::CompilerStrategy.from_config).to be_an_instance_of(Webpacker::DigestStrategy)
     end
 
-    it "raise exception for unknown compiler_strategy in the config file" do
+    it "raise an exception for unknown compiler_strategy in the config file" do
       expected_error_message = "Unknown strategy 'other'. Available options are 'mtime' and 'digest'."
       allow(Webpacker.config).to receive(:compiler_strategy).and_return("other")
 

data/spec/backward_compatibility_specs/configuration_spec.rb

@@ -14,36 +14,43 @@ describe "Webpacker::Configuration" do
 
     it "#source_path returns correct path" do
       source_path = File.expand_path File.join(File.dirname(__FILE__), "webpacker_test_app/app/packs").to_s
+
       expect(config.source_path.to_s).to eq source_path
     end
 
     it "#source_entry_path returns correct path" do
       source_entry_path = File.expand_path File.join(File.dirname(__FILE__), "webpacker_test_app/app/packs", "entrypoints").to_s
+
       expect(config.source_entry_path.to_s).to eq source_entry_path
     end
 
     it "#public_root_path returns correct path" do
       public_root_path = File.expand_path File.join(File.dirname(__FILE__), "webpacker_test_app/public").to_s
+
       expect(config.public_path.to_s).to eq public_root_path
     end
 
     it "#public_output_path returns correct path" do
       public_output_path = File.expand_path File.join(File.dirname(__FILE__), "webpacker_test_app/public/packs").to_s
+
       expect(config.public_output_path.to_s).to eq public_output_path
     end
 
     it "#public_manifest_path returns correct path" do
       public_manifest_path = File.expand_path File.join(File.dirname(__FILE__), "webpacker_test_app/public/packs", "manifest.json").to_s
+
       expect(config.public_manifest_path.to_s).to eq public_manifest_path
     end
 
     it "#manifest_path returns correct path" do
       manifest_path = File.expand_path File.join(File.dirname(__FILE__), "webpacker_test_app/public/packs", "manifest.json").to_s
+
       expect(config.manifest_path.to_s).to eq manifest_path
     end
 
     it "#cache_path returns correct path" do
       cache_path = File.expand_path File.join(File.dirname(__FILE__), "webpacker_test_app/tmp/webpacker").to_s
+
       expect(config.cache_path.to_s).to eq cache_path
     end
 
@@ -56,7 +63,7 @@ describe "Webpacker::Configuration" do
         expect(config.cache_manifest?).to be true
       end
 
-      it "returns false in developemnt environemnt" do
+      it "returns false in development environment" do
         with_rails_env("development") do
           expect(Webpacker.config.cache_manifest?).to be false
         end
@@ -74,13 +81,13 @@ describe "Webpacker::Configuration" do
         expect(config.compile?).to be false
       end
 
-      it "returns true in developemnt environemnt" do
+      it "returns true in development environment" do
         with_rails_env("development") do
           expect(Webpacker.config.compile?).to be true
         end
       end
 
-      it "returns true in test environemnt" do
+      it "returns true in test environment" do
         with_rails_env("test") do
           expect(Webpacker.config.compile?).to be true
         end
@@ -186,11 +193,12 @@ describe "Webpacker::Configuration" do
 
     it "#public_output_path returns correct path" do
       expected_public_output_path = File.expand_path File.join(File.dirname(__FILE__), "public/packs").to_s
+
       expect(config.public_output_path.to_s).to eq expected_public_output_path
     end
   end
 
-  context "with webpacker config file containing manifext_path entry" do
+  context "with webpacker config file containing manifest_path entry" do
     config = Webpacker::Configuration.new(
       root_path: ROOT_PATH,
       config_path: Pathname.new(File.expand_path("./webpacker_test_app/config/webpacker_manifest_path.yml", __dir__)),
@@ -199,6 +207,7 @@ describe "Webpacker::Configuration" do
 
     it "#manifest_path returns correct expected value" do
       expected_manifest_path = File.expand_path File.join(File.dirname(__FILE__), "webpacker_test_app/app/packs", "manifest.json").to_s
+
       expect(config.manifest_path.to_s).to eq expected_manifest_path
     end
   end
@@ -206,8 +215,8 @@ describe "Webpacker::Configuration" do
   context "with webpacker_precompile entry set to false" do
     describe "#webpacker_precompile?" do
       before :each do
-        ENV.delete("WEBPACKER_PRECOMPILE")
         ENV.delete("SHAKAPACKER_PRECOMPILE")
+        ENV.delete("WEBPACKER_PRECOMPILE")
       end
 
       let(:config) {
@@ -229,9 +238,8 @@ describe "Webpacker::Configuration" do
         expect(subject).to be true
       end
 
-      it "returns false with WEBPACKER_PRECOMPILE set to falsy value" do
-        # ENV["WEBPACKER_PRECOMPILE"] = "no"
-        ENV.delete("WEBPACKER_PRECOMPILE")
+      it "returns false with WEBPACKER_PRECOMPILE set to nil" do
+        ENV["SHAKAPACKER_PRECOMPILE"] = nil
         expect(subject).to be false
       end
     end

data/spec/backward_compatibility_specs/dev_server_runner_spec.rb

@@ -17,22 +17,25 @@ describe "DevServerRunner" do
 
   let(:test_app_path) { File.expand_path("webpacker_test_app", __dir__) }
 
-  it "run cmd via node modules" do
+  it "supports running via node modules" do
     cmd = ["#{test_app_path}/node_modules/.bin/webpack", "serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js"]
+
     verify_command(cmd, use_node_modules: true)
   end
 
-  it "run cmd via yarn" do
+  it "supports running via yarn" do
     cmd = ["yarn", "webpack", "serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js"]
+
     verify_command(cmd, use_node_modules: false)
   end
 
-  it "run cmd argv" do
+  it "passes on arguments" do
     cmd = ["#{test_app_path}/node_modules/.bin/webpack", "serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js", "--quiet"]
+
     verify_command(cmd, argv: (["--quiet"]))
   end
 
-  it "run cmd argv with https" do
+  it "supports the https flag" do
     cmd = ["#{test_app_path}/node_modules/.bin/webpack", "serve", "--config", "#{test_app_path}/config/webpack/webpack.config.js", "--https"]
 
     dev_server = double()
@@ -54,26 +57,24 @@ describe "DevServerRunner" do
     # ENV["WEBPACKER_CONFIG"] is the interface and env["SHAKAPACKER_CONFIG"] is internal
     ENV["WEBPACKER_CONFIG"] = env["SHAKAPACKER_CONFIG"] = "#{test_app_path}/config/webpacker_other_location.yml"
     env["WEBPACK_SERVE"] = "true"
+
     verify_command(cmd, env: env)
   end
 
   private
 
     def verify_command(cmd, use_node_modules: true, argv: [], env: Webpacker::Compiler.env)
-      cwd = Dir.pwd
-      Dir.chdir(test_app_path)
-      klass = Webpacker::DevServerRunner
-      instance = klass.new(argv)
-
-      allow(klass).to receive(:new).and_return(instance)
-      allow(instance).to receive(:node_modules_bin_exist?).and_return(use_node_modules)
-      allow(Kernel).to receive(:exec).with(env, *cmd)
+      Dir.chdir(test_app_path) do
+        klass = Webpacker::DevServerRunner
+        instance = klass.new(argv)
 
-      klass.run(argv)
+        allow(klass).to receive(:new).and_return(instance)
+        allow(instance).to receive(:node_modules_bin_exist?).and_return(use_node_modules)
+        allow(Kernel).to receive(:exec).with(env, *cmd)
 
-      expect(Kernel).to have_received(:exec).with(env, *cmd)
+        klass.run(argv)
 
-      ensure
-        Dir.chdir(cwd)
+        expect(Kernel).to have_received(:exec).with(env, *cmd)
+      end
     end
 end

data/spec/backward_compatibility_specs/dev_server_spec.rb

@@ -41,7 +41,7 @@ describe "DevServer" do
     end
   end
 
-  it "users SHAKAPACKER_DEV_SERVER for DEFAULT_ENV_PREFIX" do
+  it "uses SHAKAPACKER_DEV_SERVER for DEFAULT_ENV_PREFIX" do
     expect(Webpacker::DevServer::DEFAULT_ENV_PREFIX).to eq "SHAKAPACKER_DEV_SERVER"
   end
 end

data/spec/backward_compatibility_specs/digest_strategy_spec.rb

@@ -23,6 +23,7 @@ describe "DigestStrategy" do
 
   it "is fresh after compilation" do
     @digest_strategy.after_compile_hook
+
     expect(@digest_strategy.stale?).to be false
     expect(@digest_strategy.fresh?).to be true
   end
@@ -30,6 +31,7 @@ describe "DigestStrategy" do
   it "generates correct compilation_digest_path" do
     actual_path = @digest_strategy.send(:compilation_digest_path).basename.to_s
     expected_path = "last-compilation-digest-#{Webpacker.env}"
+
     expect(actual_path).to eq expected_path
   end
 end

data/spec/backward_compatibility_specs/engine_rake_tasks_spec.rb

@@ -11,11 +11,12 @@ describe "EngineRakeTasks" do
 
   it "mounts app:webpacker task successfully" do
     output = Dir.chdir(mounted_app_path) { `rake -T` }
+
     expect(output).to match /app:webpacker.+DEPRECATED/
     expect(output).to match /app:webpacker:binstubs.+DEPRECATED/
   end
 
-  it "binstubs adds only expected files to bin directory" do
+  it "only adds expected files to bin directory when binstubs is run" do
     Dir.chdir(mounted_app_path) { `bundle exec rake app:webpacker:binstubs` }
     expected_binstub_paths.each { |path| expect(File.exist?(path)).to be true }
   end