shakapacker 7.0.2 → 7.1.0

data/spec/shakapacker/manifest_spec.rb

@@ -3,7 +3,7 @@ require_relative "spec_helper_initializer"
 describe "Shakapacker::Manifest" do
   let(:manifest_path) { File.expand_path File.join(File.dirname(__FILE__), "./test_app/public/packs", "manifest.json").to_s }
 
-  it "#lookup! throws exception for a non-existing asset file" do
+  it "#lookup! raises an exception for a non-existing asset file" do
     asset_file = "calendar.js"
     expected_error_message = "Shakapacker can't find #{asset_file} in #{manifest_path}"
 
@@ -14,7 +14,7 @@ describe "Shakapacker::Manifest" do
     }.to raise_error(Shakapacker::Manifest::MissingEntryError, /#{expected_error_message}/)
   end
 
-  it "#lookup! throws exception for a non-existing asset file with type and without extension" do
+  it "#lookup! raises an exception for a non-existing asset file with type and without an extension" do
     asset_file = "calendar"
     expected_error_message = "Shakapacker can't find #{asset_file}.js in #{manifest_path}"
 
@@ -25,57 +25,57 @@ describe "Shakapacker::Manifest" do
     }.to raise_error(Shakapacker::Manifest::MissingEntryError, /#{expected_error_message}/)
   end
 
-  it "#lookup! returns path to bundled bootstrap.js" do
+  it "#lookup! returns the path to the bundled bootstrap.js" do
     actual = Shakapacker.manifest.lookup!("bootstrap.js")
     expected = "/packs/bootstrap-300631c4f0e0f9c865bc.js"
 
     expect(actual).to eq expected
   end
 
-  it "#lookup_pack_with_chunks! returns array of path to bundled bootstrap with type of javascript" do
+  it "#lookup_pack_with_chunks! returns an array of paths to the bundled bootstrap of type javascript" do
     actual = Shakapacker.manifest.lookup_pack_with_chunks!("bootstrap", type: :javascript)
     expected = ["/packs/bootstrap-300631c4f0e0f9c865bc.js"]
 
     expect(actual).to eq expected
   end
 
-  it "#lookup_with_chunks! returns array of path to bundled bootstrap.js with type of javascript" do
+  it "#lookup_with_chunks! returns an array of paths to the bundled bootstrap.js of type javascript" do
     actual = Shakapacker.manifest.lookup_pack_with_chunks!("bootstrap.js", type: :javascript)
     expected = ["/packs/bootstrap-300631c4f0e0f9c865bc.js"]
 
     expect(actual).to eq expected
   end
 
-  it "#lookup_with_chunks! returns array of path to bundled 'print/application' without extension and in a sub-directory" do
+  it "#lookup_with_chunks! returns an array of paths to the bundled 'print/application' without an extension and in a sub-directory" do
     actual = Shakapacker.manifest.lookup_pack_with_chunks!("print/application", type: :css)
     expected = ["/packs/print/application-983b6c164a47f7ed49cd.css"]
 
     expect(actual).to eq expected
   end
 
-  it "#lookup_with_chunks! returns array of path to bundled 'print/application.css' in a sub-directory" do
+  it "#lookup_with_chunks! returns an array of paths to the bundled 'print/application.css' in a sub-directory" do
     actual = Shakapacker.manifest.lookup_pack_with_chunks!("print/application.css", type: :css)
     expected = ["/packs/print/application-983b6c164a47f7ed49cd.css"]
 
     expect(actual).to eq expected
   end
 
-  it "#lookup returns nil for non-existing asset file" do
+  it "#lookup returns nil for non-existing asset files" do
     expect(Shakapacker.manifest.lookup("foo.js")).to be nil
   end
 
-  it "#lookup_pack_with_chunks returns nil for non-existing asset file" do
+  it "#lookup_pack_with_chunks returns nil for non-existing asset files" do
     expect(Shakapacker.manifest.lookup_pack_with_chunks("foo.js")).to be nil
   end
 
-  it "#lookup returns path for bootstrap.js" do
+  it "#lookup returns the path for bootstrap.js" do
     actual = Shakapacker.manifest.lookup("bootstrap.js")
     expected = "/packs/bootstrap-300631c4f0e0f9c865bc.js"
 
     expect(actual).to eq expected
   end
 
-  it "#lookup_pack_with_chunks! throws exception for a non-existing asset file" do
+  it "#lookup_pack_with_chunks! raises an exception for non-existing asset files" do
     asset_file = "calendar"
 
     expected_error_message = "Shakapacker can't find #{asset_file}.js in #{manifest_path}"
@@ -87,7 +87,7 @@ describe "Shakapacker::Manifest" do
     }.to raise_error(Shakapacker::Manifest::MissingEntryError, /#{expected_error_message}/)
   end
 
-  it "#lookup_pack_with_chunks! returns array of paths to bundled js files with 'application' in their name" do
+  it "#lookup_pack_with_chunks! returns an array of paths to bundled js files with 'application' in their name" do
     actual_application_entrypoints = Shakapacker.manifest.lookup_pack_with_chunks!("application", type: :javascript)
     expected_application_entrypoints = [
       "/packs/vendors~application~bootstrap-c20632e7baf2c81200d3.chunk.js",

data/spec/shakapacker/mtime_strategy_spec.rb

@@ -5,7 +5,7 @@ describe "Shakapacker::MtimeStrategy" do
   let(:manifest_timestamp) { Time.parse("2021-01-01 12:34:56 UTC") }
 
   describe "#fresh?" do
-    it "returns false when manifest is missing" do
+    it "returns false when the manifest is missing" do
       latest_timestamp = manifest_timestamp + 3600
 
       with_stubs(latest_timestamp: latest_timestamp.to_i, manifest_exists: false) do
@@ -13,7 +13,7 @@ describe "Shakapacker::MtimeStrategy" do
       end
     end
 
-    it "returns false when manifest is older" do
+    it "returns false when the manifest is older" do
       latest_timestamp = manifest_timestamp + 3600
 
       with_stubs(latest_timestamp: latest_timestamp.to_i) do
@@ -21,7 +21,7 @@ describe "Shakapacker::MtimeStrategy" do
       end
     end
 
-    it "returns true when manifest is new" do
+    it "returns true when the manifest is new" do
       latest_timestamp = manifest_timestamp - 3600
 
       with_stubs(latest_timestamp: latest_timestamp.to_i) do

data/spec/shakapacker/rake_tasks_spec.rb

@@ -18,22 +18,25 @@ describe "RakeTasks" do
 
   it "`shakapacker:check_binstubs` doesn't get 'webpack binstub not found' error" do
     output = Dir.chdir(TEST_APP_PATH) { `rake shakapacker:check_binstubs 2>&1` }
+
     expect(output).to_not include "webpack binstub not found."
   end
 
   it "`shakapacker:check_node` doesn't get 'shakapacker requires Node.js' error" do
     output = Dir.chdir(TEST_APP_PATH) { `rake shakapacker:check_node 2>&1` }
+
     expect(output).to_not include "Shakapacker requires Node.js"
   end
 
-  it "`shakapacker:check_yarn` doesn't get error related to yarn" do
+  it "`shakapacker:check_yarn` doesn't get errors related to yarn" do
     output = Dir.chdir(TEST_APP_PATH) { `rake shakapacker:check_yarn 2>&1` }
+
     expect(output).to_not include "Yarn not installed"
     expect(output).to_not include "Shakapacker requires Yarn"
   end
 
   describe "`shakapacker:check_binstubs`" do
-    def with_temporary_file(file_name, &block)
+    def with_temporary_file(file_name)
       FileUtils.touch(file_name, verbose: false)
       yield if block_given?
     ensure
@@ -44,7 +47,7 @@ describe "RakeTasks" do
       Dir.chdir(TEST_APP_PATH)
     end
 
-    context "with existing `./bin/shapapacker` and `./bin/shapapacker-dev-server`" do
+    context "with existing `./bin/shakapacker` and `./bin/shakapacker-dev-server`" do
       it "passes" do
         expect { system("bundle exec rake shakapacker:check_binstubs") }.to output("").to_stdout_from_any_process
       end

data/spec/shakapacker/shakapacker_spec.rb

@@ -12,11 +12,11 @@ describe "Shakapacker" do
       allow(dev_server).to receive(:running?).and_return(true)
     end
 
-    it "returns nil with disabled dev_server" do
+    it "returns nil when the dev server is disabled" do
       expect(Shakapacker.inlining_css?).to be nil
     end
 
-    it "returns true with enabled hmr" do
+    it "returns true when hmr is enabled" do
       allow(dev_server).to receive(:hmr?).and_return(true)
       allow(dev_server).to receive(:inline_css?).and_return(true)
 
@@ -25,7 +25,7 @@ describe "Shakapacker" do
       expect(Shakapacker.inlining_css?).to be true
     end
 
-    it "returns false with enabled hmr and explicitly setting inline_css to false" do
+    it "returns false when hmr is enabled and inline_css is explicitly set to false" do
       allow(dev_server).to receive(:hmr?).and_return(true)
       allow(dev_server).to receive(:inline_css?).and_return(false)
 
@@ -35,7 +35,7 @@ describe "Shakapacker" do
     end
   end
 
-  it "has app_autoload_paths cleanup" do
+  it "automatically cleans up app_autoload_paths" do
     expect($test_app_autoload_paths_in_initializer).to eq []
   end
 end