sequel 4.30.0 → 4.31.0

data/lib/sequel/extensions/mssql_emulate_lateral_with_apply.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The mssql_emulate_lateral_with_apply extension converts
 # queries that use LATERAL into queries that use CROSS/OUTER
 # APPLY, allowing code that works on databases that support

data/lib/sequel/extensions/named_timezones.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # Allows the use of named timezones via TZInfo (requires tzinfo).
 # Forces the use of DateTime as Sequel's datetime_class, since
 # ruby's Time class doesn't support timezones other than local

data/lib/sequel/extensions/null_dataset.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The null_dataset extension adds the Dataset#nullify method, which
 # returns a cloned dataset that will never issue a query to the
 # database.  It implements the null object pattern for datasets.

data/lib/sequel/extensions/pagination.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The pagination extension adds the Sequel::Dataset#paginate and #each_page methods,
 # which return paginated (limited and offset) datasets with the following methods
 # added that make creating a paginated display easier:

data/lib/sequel/extensions/pg_array.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The pg_array extension adds support for Sequel to handle
 # PostgreSQL's array types.
 #
@@ -74,14 +76,17 @@
 # customize the array type handling.  See the Sequel::Postgres::PGArray.register
 # method documentation.
 #
+# While this extension can parse PostgreSQL arrays with explicit bounds, it
+# currently ignores explicit bounds, so such values do not round
+# trip.
+#
 # If you want an easy way to call PostgreSQL array functions and
 # operators, look into the pg_array_ops extension.
 #
-# This extension requires the json, strscan, and delegate libraries.
+# This extension requires the strscan and delegate libraries.
 
 require 'delegate'
 require 'strscan'
-require 'json'
 Sequel.require 'adapters/utils/pg_types'
 
 module Sequel
@@ -121,10 +126,6 @@ module Sequel
       #               (usually a string), and should return the appropriate typecasted object.
       # :oid :: The PostgreSQL OID for the array type.  This is used by the Sequel postgres adapter
       #         to set up automatic type conversion on retrieval from the database.
-      # :parser :: Can be set to :json to use the faster JSON-based parser.  Note that the JSON-based
-      #            parser can only correctly handle integers values correctly.  It doesn't handle
-      #            full precision for numeric types, and doesn't handle NaN/Infinity values for
-      #            floating point types.
       # :scalar_oid :: Should be the PostgreSQL OID for the scalar version of this array type. If given,
       #                automatically sets the :converter option by looking for scalar conversion
       #                proc.
@@ -163,7 +164,7 @@ module Sequel
         end
 
         array_type = (opts[:array_type] || db_type).to_s.dup.freeze
-        creator = (opts[:parser] == :json ? JSONCreator : Creator).new(array_type, converter)
+        creator = Creator.new(array_type, converter)
 
         typecast_method_map[db_type] = :"#{type}_array"
 
@@ -343,7 +344,7 @@ module Sequel
         UNQUOTED_RE = /[{}",]|[^{}",]+/
         QUOTED_RE = /["\\]|[^"\\]+/
         NULL_RE = /NULL",/
-        OPEN_RE = /\{/
+        OPEN_RE = /((\[\d+:\d+\])+=)?\{/
 
         # Set the source for the input, and any converter callable
         # to call with objects to be created.  For nested parsers
@@ -353,7 +354,7 @@ module Sequel
           super(source)
           @converter = converter 
           @stack = [[]]
-          @recorded = ""
+          @recorded = String.new
         end
 
         # Take the buffer of recorded characters and add it to the array
@@ -367,7 +368,7 @@ module Sequel
               entry = @converter.call(entry)
             end
             @stack.last.push(entry)
-            @recorded = ""
+            @recorded = String.new
           end
         end
 
@@ -460,27 +461,6 @@ module Sequel
         end
       end
 
-      # Callable object that takes the input string and parses it using.
-      # a JSON parser.  This should be faster than the standard Creator,
-      # but only handles integer types correctly.
-      class JSONCreator < Creator
-        # Character conversion map mapping input strings to JSON replacements
-        SUBST = {'{'.freeze=>'['.freeze, '}'.freeze=>']'.freeze, 'NULL'.freeze=>'null'.freeze}
-
-        # Regular expression matching input strings to convert
-        SUBST_RE = %r[\{|\}|NULL].freeze
-
-        # Parse the input string by using a gsub to convert non-JSON characters to
-        # JSON, running it through a regular JSON parser. If a converter is used, a
-        # recursive map of the output is done to make sure that the entires in the
-        # correct type.
-        def call(string)
-          array = Sequel.parse_json(string.gsub(SUBST_RE){|m| SUBST[m]})
-          array = Sequel.recursive_map(array, @converter) if @converter
-          PGArray.new(array, @type)
-        end
-      end
-
       # The type of this array.  May be nil if no type was given. If a type
       # is provided, the array is automatically casted to this type when
       # literalizing.  This type is the underlying type, not the array type
@@ -532,9 +512,9 @@ module Sequel
 
       # Register all array types that this extension handles by default.
 
-      register('text', :oid=>1009, :type_symbol=>:string)
-      register('integer', :oid=>1007, :parser=>:json)
-      register('bigint', :oid=>1016, :parser=>:json, :scalar_typecast=>:integer)
+      register('text', :oid=>1009, :scalar_oid=>25, :type_symbol=>:string)
+      register('integer', :oid=>1007, :scalar_oid=>23)
+      register('bigint', :oid=>1016, :scalar_oid=>20, :scalar_typecast=>:integer)
       register('numeric', :oid=>1231, :scalar_oid=>1700, :type_symbol=>:decimal)
       register('double precision', :oid=>1022, :scalar_oid=>701, :type_symbol=>:float)
 
@@ -546,8 +526,8 @@ module Sequel
       register('time with time zone', :oid=>1270, :scalar_oid=>1083, :type_symbol=>:time_timezone, :scalar_typecast=>:time)
       register('timestamp with time zone', :oid=>1185, :scalar_oid=>1184, :type_symbol=>:datetime_timezone, :scalar_typecast=>:datetime)
 
-      register('smallint', :oid=>1005, :parser=>:json, :scalar_typecast=>:integer)
-      register('oid', :oid=>1028, :parser=>:json, :scalar_typecast=>:integer)
+      register('smallint', :oid=>1005, :scalar_oid=>21, :scalar_typecast=>:integer)
+      register('oid', :oid=>1028, :scalar_oid=>26, :scalar_typecast=>:integer)
       register('real', :oid=>1021, :scalar_oid=>700, :scalar_typecast=>:float)
       register('character', :oid=>1014, :array_type=>:text, :scalar_typecast=>:string)
       register('character varying', :oid=>1015, :scalar_typecast=>:string, :type_symbol=>:varchar)

data/lib/sequel/extensions/pg_array_ops.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The pg_array_ops extension adds support to Sequel's DSL to make
 # it easier to call PostgreSQL array functions and operators.
 #

data/lib/sequel/extensions/pg_enum.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The pg_enum extension adds support for Sequel to handle PostgreSQL's enum
 # types.  To use this extension, first load it into your Database instance:
 #
@@ -68,7 +70,8 @@ module Sequel
       # :before :: Add the new value before this existing value.
       # :if_not_exists :: Do not raise an error if the value already exists in the enum.
       def add_enum_value(enum, value, opts=OPTS)
-        sql = "ALTER TYPE #{quote_schema_table(enum)} ADD VALUE#{' IF NOT EXISTS' if opts[:if_not_exists]} #{literal(value.to_s)}"
+        sql = String.new
+        sql << "ALTER TYPE #{quote_schema_table(enum)} ADD VALUE#{' IF NOT EXISTS' if opts[:if_not_exists]} #{literal(value.to_s)}"
         if v = opts[:before]
           sql << " BEFORE #{literal(v.to_s)}"
         elsif v = opts[:after]

data/lib/sequel/extensions/pg_hstore.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The pg_hstore extension adds support for the PostgreSQL hstore type
 # to Sequel.  hstore is an extension that ships with PostgreSQL, and
 # the hstore type stores an arbitrary key-value table, where the keys
@@ -265,7 +267,7 @@ module Sequel
       # literal version of the hstore.  Separated out for use by
       # the bound argument code.
       def unquoted_literal
-        str = ''
+        str = String.new
         comma = false
         commas = COMMA
         quote = QUOTE

data/lib/sequel/extensions/pg_hstore_ops.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The pg_hstore_ops extension adds support to Sequel's DSL to make
 # it easier to call PostgreSQL hstore functions and operators.
 #

data/lib/sequel/extensions/pg_inet.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The pg_inet extension adds support for Sequel to handle
 # PostgreSQL's inet and cidr types using ruby's IPAddr class.
 #

data/lib/sequel/extensions/pg_inet_ops.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The pg_inet_ops extension adds support to Sequel's DSL to make
 # it easier to call PostgreSQL inet functions and operators.
 #

data/lib/sequel/extensions/pg_interval.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The pg_interval extension adds support for PostgreSQL's interval type.
 #
 # This extension integrates with Sequel's native postgres and jdbc/postgresql
@@ -49,7 +51,7 @@ module Sequel
       def self.literal_duration(duration)
         h = Hash.new(0)
         duration.parts.each{|unit, value| h[unit] += value}
-        s = ''
+        s = String.new
 
         DURATION_UNITS.each do |unit|
           if (v = h[unit]) != 0

data/lib/sequel/extensions/pg_json.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The pg_json extension adds support for Sequel to handle
 # PostgreSQL's json and jsonb types.  It is slightly more strict than the
 # PostgreSQL json types in that the object returned should be an

data/lib/sequel/extensions/pg_json_ops.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The pg_json_ops extension adds support to Sequel's DSL to make
 # it easier to call PostgreSQL JSON functions and operators (added
 # first in PostgreSQL 9.3).  It also supports the JSONB functions

data/lib/sequel/extensions/pg_loose_count.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The pg_loose_count extension looks at the table statistics
 # in the PostgreSQL system tables to get a fast approximate
 # count of the number of rows in a given table:

data/lib/sequel/extensions/pg_range.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The pg_range extension adds support for the PostgreSQL 9.2+ range
 # types to Sequel.  PostgreSQL range types are similar to ruby's
 # Range class, representating an array of values.  However, they

data/lib/sequel/extensions/pg_range_ops.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The pg_range_ops extension adds support to Sequel's DSL to make
 # it easier to call PostgreSQL range functions and operators.
 #

data/lib/sequel/extensions/pg_row.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The pg_row extension adds support for Sequel to handle
 # PostgreSQL's row-valued/composite types.
 #

data/lib/sequel/extensions/pg_row_ops.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The pg_row_ops extension adds support to Sequel's DSL to make
 # it easier to deal with PostgreSQL row-valued/composite types.
 #

data/lib/sequel/extensions/pg_static_cache_updater.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The pg_static_cache_updater extension is designed to
 # automatically update the caches in the models using the
 # static_cache plugin when changes to the underlying tables

data/lib/sequel/extensions/pretty_table.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The pretty_table extension adds Sequel::Dataset#print and the
 # Sequel::PrettyTable class for creating nice-looking plain-text
 # tables.  Example:

data/lib/sequel/extensions/query.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The query extension adds a query method which allows
 # a different way to construct queries instead of the usual
 # method chaining:

data/lib/sequel/extensions/query_literals.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The query_literals extension changes Sequel's default behavior of
 # the select, order and group methods so that if the first argument
 # is a regular string, it is treated as a literal string, with the

data/lib/sequel/extensions/round_timestamps.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The round_timestamps extension will automatically round timestamp
 # values to the database's supported level of precision before literalizing
 # them.

data/lib/sequel/extensions/ruby18_symbol_extensions.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The ruby18_symbol_extensions adds the <, <=, >, >= to Symbol
 # to reflect the mathmatical operators.  It also adds the [] method
 # to Symbol for creating SQL functions.

data/lib/sequel/extensions/schema_caching.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The schema_caching extension adds a few methods to Sequel::Database
 # that make it easy to dump the parsed schema information to a file,
 # and load it from that file.  Loading the schema information from a

data/lib/sequel/extensions/schema_dumper.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The schema_dumper extension supports dumping tables and indexes
 # in a Sequel::Migration format, so they can be restored on another
 # database (which can be the same type or a different type than
@@ -213,7 +215,8 @@ END_MIG
     # For the table and foreign key metadata array, return an alter_table
     # string that would add the foreign keys if run in a migration.
     def dump_add_fk_constraints(table, fks)
-      sfks = "alter_table(#{table.inspect}) do\n"
+      sfks = String.new
+      sfks << "alter_table(#{table.inspect}) do\n"
       sfks << create_table_generator do
         fks.sort_by{|fk| fk[:columns].map(&:to_s)}.each do |fk|
           foreign_key fk[:columns], fk

data/lib/sequel/extensions/select_remove.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The select_remove extension adds Sequel::Dataset#select_remove for removing existing selected
 # columns from a dataset.  It's not part of Sequel core as it is rarely needed and has
 # some corner cases where it can't work correctly.

data/lib/sequel/extensions/sequel_3_dataset_methods.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # This adds the following dataset methods:
 #
 # []= :: filter with the first argument, update with the second
@@ -107,7 +109,7 @@ module Sequel
     def to_csv(include_column_titles = true)
       n = naked
       cols = n.columns
-      csv = ''
+      csv = String.new
       csv << "#{cols.join(COMMA)}\r\n" if include_column_titles
       n.each{|r| csv << "#{cols.collect{|c| r[c]}.join(COMMA)}\r\n"}
       csv

data/lib/sequel/extensions/server_block.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The server_block extension adds the Database#with_server method, which takes a shard
 # argument and a block, and makes it so that access inside the block will use the
 # specified shard by default.

data/lib/sequel/extensions/set_overrides.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The set_overrides extension adds the Dataset#set_overrides and
 # Dataset#set_defaults methods which provide a crude way to
 # control the values used in INSERT/UPDATE statements if a hash

data/lib/sequel/extensions/split_array_nil.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The split_array_nil extension overrides Sequel's default handling of
 # IN/NOT IN with arrays of values to do specific nil checking.  For example,
 #

data/lib/sequel/extensions/sql_expr.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The sql_expr extension adds the sql_expr method to every object, which
 # returns an wrapped object that works nicely with Sequel's DSL by calling
 # Sequel.expr:

data/lib/sequel/extensions/string_date_time.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The string_date_time extension provides String instance methods
 # for converting the strings to a date (e.g. String#to_date), allowing
 # for backwards compatibility with legacy Sequel code.

data/lib/sequel/extensions/thread_local_timezones.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The thread_local_timezones extension allows you to set a per-thread timezone that
 # will override the default global timezone while the thread is executing.  The
 # main use case is for web applications that execute each request in its own thread,

data/lib/sequel/extensions/to_dot.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # This adds a <tt>Sequel::Dataset#to_dot</tt> method.  The +to_dot+ method
 # returns a string that can be processed by graphviz's +dot+ program in
 # order to get a visualization of the dataset.  Basically, it shows a version
@@ -123,7 +125,7 @@ module Sequel
         dot "PlaceholderLiteralString: #{str.inspect}"
         v(e.args, :args)
       when SQL::JoinClause
-        str = "#{e.join_type.to_s.upcase} JOIN"
+        str = "#{e.join_type.to_s.upcase} JOIN".dup
         if e.is_a?(SQL::JoinOnClause)
           str << " ON"
         elsif e.is_a?(SQL::JoinUsingClause)

data/lib/sequel/model.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+
 require 'sequel/core'
 
 module Sequel

data/lib/sequel/model/associations.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+
 module Sequel
   class Model
     # Associations are used in order to specify relationships between model classes
@@ -2553,7 +2555,7 @@ END
         # create large cartesian products.  If you must graph multiple one_to_many and many_to_many associations,
         # make sure your filters are narrow if you have a large database.
         # 
-        # Each association's order, if definied, is respected. +eager_graph+ probably
+        # Each association's order, if defined, is respected. +eager_graph+ probably
         # won't work correctly on a limited dataset, unless you are
         # only graphing many_to_one, one_to_one, and one_through_one associations.
         # 

data/lib/sequel/model/base.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+
 module Sequel
   class Model
     extend Enumerable
@@ -1134,7 +1136,9 @@ module Sequel
       attr_writer(*BOOLEAN_SETTINGS)
 
       # The hash of attribute values.  Keys are symbols with the names of the
-      # underlying database columns.
+      # underlying database columns. The returned hash is a reference to the
+      # receiver's values hash, and modifying it will also modify the receiver's
+      # values.
       #
       #   Artist.new(:name=>'Bob').values # => {:name=>'Bob'}
       #   Artist[1].values # => {:id=>1, :name=>'Jim', ...}