sequel 4.30.0 → 4.31.0

data/lib/sequel/database/dataset.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+
 module Sequel
   class Database
     # ---------------------

data/lib/sequel/database/dataset_defaults.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+
 module Sequel
   class Database
     # ---------------------

data/lib/sequel/database/features.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+
 module Sequel
   class Database
     # ---------------------

data/lib/sequel/database/logging.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+
 module Sequel
   class Database
     # ---------------------

data/lib/sequel/database/misc.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+
 module Sequel
   class Database
     # ---------------------

data/lib/sequel/database/query.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+
 module Sequel
   class Database
     # ---------------------

data/lib/sequel/database/schema_generator.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+
 module Sequel
   # The Schema module holds the schema generators.
   module Schema

data/lib/sequel/database/schema_methods.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+
 module Sequel
   class Database
     # ---------------------
@@ -530,7 +532,8 @@ module Sequel
 
     # SQL DDL fragment containing the column creation SQL for the given column.
     def column_definition_sql(column)
-      sql = "#{quote_identifier(column[:name])} #{type_literal(column)}"
+      sql = String.new
+      sql << "#{quote_identifier(column[:name])} #{type_literal(column)}"
       column_definition_order.each{|m| send(:"column_definition_#{m}_sql", sql, column)}
       sql
     end
@@ -601,7 +604,8 @@ module Sequel
 
     # SQL DDL fragment for column foreign key references
     def column_references_sql(column)
-      sql = " REFERENCES #{quote_schema_table(column[:table])}"
+      sql = String.new
+      sql << " REFERENCES #{quote_schema_table(column[:table])}"
       sql << "(#{Array(column[:key]).map{|x| quote_identifier(x)}.join(COMMA_SEPARATOR)})" if column[:key]
       sql << " ON DELETE #{on_delete_clause(column[:on_delete])}" if column[:on_delete]
       sql << " ON UPDATE #{on_update_clause(column[:on_update])}" if column[:on_update]
@@ -622,7 +626,8 @@ module Sequel
 
     # SQL DDL fragment specifying a constraint on a table.
     def constraint_definition_sql(constraint)
-      sql = constraint[:name] ? "CONSTRAINT #{quote_identifier(constraint[:name])} " : ""
+      sql = String.new
+      sql << "CONSTRAINT #{quote_identifier(constraint[:name])} " if constraint[:name] 
       case constraint[:type]
       when :check
         check = constraint[:check]
@@ -726,7 +731,8 @@ module Sequel
     # DDL statement for creating a view.
     def create_view_sql(name, source, options)
       source = source.sql if source.is_a?(Dataset)
-      sql = "#{create_view_prefix_sql(name, options)} AS #{source}"
+      sql = String.new
+      sql << "#{create_view_prefix_sql(name, options)} AS #{source}"
       if check = options[:check]
         sql << " WITH#{' LOCAL' if check == :local} CHECK OPTION"
       end
@@ -735,6 +741,7 @@ module Sequel
 
     # Append the column list to the SQL, if a column list is given.
     def create_view_sql_append_columns(sql, columns)
+      sql = sql.dup
       if columns
         sql << ' ('
         schema_utility_dataset.send(:identifier_list_append, sql, columns)

data/lib/sequel/database/transactions.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+
 module Sequel
   class Database
     # ---------------------

data/lib/sequel/dataset.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+
 module Sequel
   # A dataset represents an SQL query, or more generally, an abstract
   # set of rows in the database.  Datasets

data/lib/sequel/dataset/actions.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+
 module Sequel
   class Dataset
     # ---------------------

data/lib/sequel/dataset/features.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+
 module Sequel
   class Dataset
     # ---------------------

data/lib/sequel/dataset/graph.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+
 module Sequel
   class Dataset
     # ---------------------

data/lib/sequel/dataset/misc.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+
 module Sequel
   class Dataset
     # ---------------------

data/lib/sequel/dataset/mutation.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+
 module Sequel
   class Dataset
     # ---------------------

data/lib/sequel/dataset/placeholder_literalizer.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+
 module Sequel
   class Dataset
     # PlaceholderLiteralizer allows you to record the application of arbitrary changes
@@ -157,7 +159,7 @@ module Sequel
       # Return the SQL query to use for the given arguments.
       def sql(*args)
         raise Error, "wrong number of arguments (#{args.length} for #{@arity})" unless args.length == @arity
-        s = ''
+        s = String.new
         ds = @dataset
         @fragments.each do |sql, i, transformer|
           s << sql

data/lib/sequel/dataset/prepared_statements.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+
 module Sequel 
   class Dataset
     # ---------------------

data/lib/sequel/dataset/query.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+
 module Sequel
   class Dataset
     # ---------------------

data/lib/sequel/dataset/sql.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+
 module Sequel
   class Dataset
     # ---------------------
@@ -61,7 +63,7 @@ module Sequel
           literal_symbol_append(sql, v)
         else 
           unless l = db.literal_symbol(v)
-            l = ''
+            l = String.new
             literal_symbol_append(l, v)
             db.literal_symbol_set(v, l)
           end
@@ -121,7 +123,7 @@ module Sequel
         [insert_sql(columns, sql)]
       when :union
         c = false
-        sql = LiteralString.new('')
+        sql = LiteralString.new
         u = UNION_ALL_SELECT
         f = empty_from_sql
         values.each do |v|
@@ -154,7 +156,7 @@ module Sequel
       else
         check_truncation_allowed!
         raise(InvalidOperation, "Can't truncate filtered datasets") if opts[:where] || opts[:having]
-        t = ''
+        t = String.new
         source_list_append(t, opts[:from])
         _truncate_sql(t)
       end
@@ -339,7 +341,7 @@ module Sequel
     [:literal, :quote_identifier, :quote_schema_table].each do |meth|
       class_eval(<<-END, __FILE__, __LINE__ + 1)
         def #{meth}(*args, &block)
-          s = ''
+          s = ''.dup
           #{meth}_append(s, *args, &block)
           s
         end
@@ -1511,7 +1513,7 @@ module Sequel
     # The string that is appended to to create the SQL query, the empty
     # string by default
     def sql_string_origin
-      ''
+      String.new
     end
     
     # SQL to use if this dataset uses static SQL.  Since static SQL

data/lib/sequel/deprecated.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+
 module Sequel
   # This module makes it easy to print deprecation warnings with optional backtraces to a given stream.
   # There are a two accessors you can use to change how/where the deprecation methods are printed

data/lib/sequel/exceptions.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+
 module Sequel
   # The default exception class for exceptions raised by Sequel.
   # All exception classes defined by Sequel are descendants of this class.

data/lib/sequel/extensions/_pretty_table.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # This _pretty_table extension is only for internal use.
 # It adds the Sequel::PrettyTable class without modifying 
 # Sequel::Dataset.
@@ -53,7 +55,7 @@ module Sequel
     
     # String for each data line
     def self.data_line(columns, sizes, record) # :nodoc:
-      '|' << columns.map {|c| format_cell(sizes[c], record[c])}.join('|') << '|'
+      String.new << '|' << columns.map {|c| format_cell(sizes[c], record[c])}.join('|') << '|'
     end
     
     # Format the value so it takes up exactly size characters
@@ -70,12 +72,12 @@ module Sequel
     
     # String for header line
     def self.header_line(columns, sizes) # :nodoc:
-      '|' << columns.map {|c| "%-#{sizes[c]}s" % c.to_s}.join('|') << '|'
+      String.new << '|' << columns.map {|c| "%-#{sizes[c]}s" % c.to_s}.join('|') << '|'
     end
 
     # String for separtor line
     def self.separator_line(columns, sizes) # :nodoc:
-      '+' << columns.map {|c| '-' * sizes[c]}.join('+') << '+'
+      String.new << '+' << columns.map {|c| '-' * sizes[c]}.join('+') << '+'
     end
 
     private_class_method :column_sizes, :data_line, :format_cell, :header_line, :separator_line

data/lib/sequel/extensions/arbitrary_servers.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The arbitrary_servers extension allows you to connect to arbitrary
 # servers/shards that were not defined when you created the database.
 # To use it, you first load the extension into the Database object:

data/lib/sequel/extensions/blank.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The blank extension adds the blank? method to all objects (e.g. Object#blank?).
 #
 # To load the extension:

data/lib/sequel/extensions/columns_introspection.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The columns_introspection extension attempts to introspect the
 # selected columns for a dataset before issuing a query.  If it
 # thinks it can guess correctly at the columns the query will use,

data/lib/sequel/extensions/connection_validator.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The connection_validator extension modifies a database's
 # connection pool to validate that connections checked out
 # from the pool are still valid, before yielding them for

data/lib/sequel/extensions/constraint_validations.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The constraint_validations extension is designed to easily create database
 # constraints inside create_table and alter_table blocks.  It also adds
 # relevant metadata about the constraints to a separate table, which the

data/lib/sequel/extensions/core_extensions.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # These are extensions to core classes that Sequel enables by default.
 # They make using Sequel's DSL easier by adding methods to Array,
 # Hash, String, and Symbol to add methods that return Sequel

data/lib/sequel/extensions/core_refinements.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # These are refinements to core classes that allow the Sequel
 # DSL to be used without modifying the core classes directly.
 # After loading the extension via:

data/lib/sequel/extensions/current_datetime_timestamp.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The current_datetime_timestamp extension makes Dataset#current_datetime
 # return an object that operates like Sequel.datetime_class.now, but will
 # be literalized as CURRENT_TIMESTAMP.

data/lib/sequel/extensions/dataset_source_alias.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The dataset_source_alias extension changes Sequel's
 # default behavior of automatically aliasing datasets
 # from using t1, t2, etc. to using an alias based on

data/lib/sequel/extensions/date_arithmetic.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The date_arithmetic extension adds the ability to perform database-independent
 # addition/substraction of intervals to/from dates and timestamps.
 #
@@ -73,7 +75,7 @@ module Sequel
           expr = da.expr
           cast = case db_type = db.database_type
           when :postgres
-            interval = ""
+            interval = String.new
             each_valid_interval_unit(h, DEF_DURATION_UNITS) do |value, sql_unit|
               interval << "#{value} #{sql_unit} "
             end

data/lib/sequel/extensions/empty_array_consider_nulls.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # This changes Sequel's literalization of IN/NOT IN with an empty
 # array value to consider NULL values if one of the referenced
 # columns is NULL:

data/lib/sequel/extensions/empty_array_ignore_nulls.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # This only exists for backwards compatibility, as the behavior
 # added by this extension is now the default Sequel behavior. 
 Sequel::Dataset.register_extension(:empty_array_ignore_nulls){}

data/lib/sequel/extensions/error_sql.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The error_sql extension adds a DatabaseError#sql method
 # that you can use to get the sql that caused the error
 # to be raised.

data/lib/sequel/extensions/eval_inspect.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The eval_inspect extension changes #inspect for Sequel::SQL::Expression
 # subclasses to return a string suitable for ruby's eval, such that
 #

data/lib/sequel/extensions/filter_having.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The filter_having extension allows Dataset#filter, #and, #or
 # and #exclude to operate on the HAVING clause if the dataset
 # already has a HAVING clause, which was the historical behavior

data/lib/sequel/extensions/from_block.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The from_block extension changes Database#from so that blocks given
 # to it are treated as virtual rows applying to the FROM clause,
 # instead of virtual rows applying to the WHERE clause.  This will

data/lib/sequel/extensions/graph_each.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The graph_each extension adds Dataset#graph_each and
 # makes Dataset#each call #graph_each if the dataset has been graphed.
 # Dataset#graph_each splits result hashes into subhashes per table:

data/lib/sequel/extensions/hash_aliases.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The hash_aliases extension allows Dataset#select and Dataset#from
 # to treat a hash argument as an alias specification, with keys
 # being the expressions and values being the aliases, 

data/lib/sequel/extensions/inflector.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The inflector extension adds inflection instance methods to String, which allows the easy transformation of
 # words from singular to plural, class names to table names, modularized class
 # names to ones without, and class names to foreign keys.  It exists for 

data/lib/sequel/extensions/looser_typecasting.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The LooserTypecasting extension loosens the default database typecasting
 # for the following types:
 #

data/lib/sequel/extensions/meta_def.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # The meta_def extension is designed for backwards compatibility
 # with older Sequel code that uses the meta_def method on
 # Database, Dataset, and Model classes and/or instances.  It is

data/lib/sequel/extensions/migration.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+#
 # Adds the Sequel::Migration and Sequel::Migrator classes, which allow
 # the user to easily group schema changes and migrate the database
 # to a newer version or revert to a previous version.
@@ -467,6 +469,14 @@ module Sequel
       end
     end
 
+    # Load the migration file, raising an exception if the file does not define
+    # a single migration.
+    def load_migration_file(file)
+      n = Migration.descendants.length
+      load(file)
+      raise Error, "Migration file not containing a single migration detected" unless n + 1 == Migration.descendants.length
+    end
+
     # Remove all migration classes.  Done by the migrator to ensure that
     # the correct migration classes are picked up.
     def remove_migration_classes
@@ -564,7 +574,7 @@ module Sequel
       remove_migration_classes
 
       # load migration files
-      version_numbers.each{|n| load(files[n])}
+      version_numbers.each{|n| load_migration_file(files[n])}
       
       # get migration classes
       Migration.descendants
@@ -705,15 +715,15 @@ module Sequel
         if target
           if migration_version_from_file(f) > target
             if applied_migrations.include?(fi)
-              load(path)
+              load_migration_file(path)
               down_mts << [ms.last, f, :down]
             end
           elsif !applied_migrations.include?(fi)
-            load(path)
+            load_migration_file(path)
             up_mts << [ms.last, f, :up]
           end
         elsif !applied_migrations.include?(fi)
-          load(path)
+          load_migration_file(path)
           up_mts << [ms.last, f, :up]
         end
       end