sepa_king 0.0.4 → 0.0.5

data/spec/message_spec.rb

@@ -12,11 +12,18 @@ end
 
 describe SEPA::Message do
   describe :amount_total do
-    it 'should sum up transactions' do
+    it 'should sum up all transactions' do
       message = DummyMessage.new
-      message.add_transaction :amount => 1.1
-      message.add_transaction :amount => 2.2
+      message.add_transaction amount: 1.1
+      message.add_transaction amount: 2.2
       message.amount_total.should == 3.3
     end
+
+    it 'should sum up selected transactions' do
+      message = DummyMessage.new
+      message.add_transaction amount: 1.1
+      message.add_transaction amount: 2.2
+      message.amount_total([message.transactions[0]]).should == 1.1
+    end
   end
 end

data/spec/spec_helper.rb

@@ -5,10 +5,15 @@
 
 require 'simplecov'
 require 'coveralls'
-SimpleCov.formatter = Coveralls::SimpleCov::Formatter
-SimpleCov.start
 
-require 'xml'
+SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+  SimpleCov::Formatter::HTMLFormatter,
+  Coveralls::SimpleCov::Formatter
+]
+SimpleCov.start do
+  add_filter '/spec/'
+end
+
 require 'sepa_king'
 
 # Requires supporting ruby files with custom matchers and macros, etc,

data/spec/support/custom_matcher.rb

@@ -1,9 +1,52 @@
 require 'rspec/expectations'
+require 'nokogiri'
 
 RSpec::Matchers.define :validate_against do |xsd|
   match do |actual|
-    schema_doc = XML::Document.file("lib/schema/#{xsd}")
-    schema = XML::Schema.document(schema_doc)
-    actual.validate_schema(schema)
+    @schema = Nokogiri::XML::Schema(File.read("lib/schema/#{xsd}"))
+    @doc = Nokogiri::XML(actual)
+
+    @schema.should be_valid(@doc)
+  end
+
+  failure_message_for_should do |actual|
+    # Return the validation errors as string
+    @schema.validate(@doc).join("\n")
+  end
+end
+
+RSpec::Matchers.define :have_xml do |xpath, text|
+  match do |actual|
+    doc = Nokogiri::XML(actual)
+    doc.remove_namespaces! # so we can use shorter xpath's without any namespace
+
+    nodes = doc.xpath(xpath)
+    nodes.should_not be_empty
+    if text
+      nodes.each do |node|
+        node.content.should == text
+      end
+    end
+    true
+  end
+end
+
+RSpec::Matchers.define :accept do |*values, options|
+  attribute = options[:for]
+
+  match_for_should do |actual|
+    values.all? { |value|
+      expect(
+        actual.new(attribute => value)
+      ).to have(:no).errors_on(attribute)
+    }
+  end
+
+  match_for_should_not do |actual|
+    values.all? { |value|
+      expect(
+        actual.new(attribute => value)
+      ).to have_at_least(1).errors_on(attribute)
+    }
   end
 end

data/spec/support/factories.rb

@@ -0,0 +1,23 @@
+# encoding: utf-8
+
+def credit_transfer_transaction
+  { name:                   'Telekomiker AG',
+    bic:                    'PBNKDEFF370',
+    iban:                   'DE37112589611964645802',
+    amount:                 102.50,
+    reference:              'XYZ-1234/123',
+    remittance_information: 'Rechnung vom 22.08.2013'
+  }
+end
+
+def direct_debt_transaction
+  { name:                      'Müller & Schmidt oHG',
+    bic:                       'GENODEF1JEV',
+    iban:                      'DE68210501700012345678',
+    amount:                    750.00,
+    reference:                 'XYZ/2013-08-ABO/6789',
+    remittance_information:    'Vielen Dank für Ihren Einkauf!',
+    mandate_id:                'K-08-2010-42123',
+    mandate_date_of_signature: Date.new(2010,7,25)
+  }
+end

data/spec/support/validations.rb

@@ -13,7 +13,7 @@ module ::ActiveModel::Validations
   #     expect(model).to have(:no).errors_on(:attribute)
   #     expect(model).to have(1).error_on(:attribute)
   #     expect(model).to have(n).errors_on(:attribute)
-  #     expect(model).to have(n).errors_on(:attribute, :context => :create)
+  #     expect(model).to have(n).errors_on(:attribute, context: :create)
   #
   #     expect(model.errors_on(:attribute)).to include("can't be blank")
   def errors_on(attribute, options = {})

data/spec/transaction_spec.rb

@@ -2,111 +2,87 @@
 require 'spec_helper'
 
 describe SEPA::Transaction do
+  describe :new do
+    it 'should have default for reference' do
+      SEPA::Transaction.new.reference.should == 'NOTPROVIDED'
+    end
+
+    it 'should have default for requested_date' do
+      SEPA::Transaction.new.requested_date.should == Date.today.next
+    end
+
+    it 'should have default for batch_booking' do
+      SEPA::Transaction.new.batch_booking.should == true
+    end
+  end
+
   context 'Name' do
     it 'should accept valid value' do
-      [ 'Manfred Mustermann III.', 'Zahlemann & Söhne GbR', 'X' * 70 ].each do |value_value|
-        expect(
-          SEPA::Transaction.new :name => value_value
-        ).to have(:no).errors_on(:name)
-      end
+      SEPA::Transaction.should accept('Manfred Mustermann III.', 'Zahlemann & Söhne GbR', 'X' * 70, for: :name)
     end
 
     it 'should not accept invalid value' do
-      [ nil, '', 'X' * 71 ].each do |invalue_value|
-        expect(
-          SEPA::Transaction.new :name => invalue_value
-        ).to have_at_least(1).errors_on(:name)
-      end
+      SEPA::Transaction.should_not accept(nil, '', 'X' * 71, for: :name)
     end
   end
 
   context 'IBAN' do
     it 'should accept valid value' do
-      [ 'DE21500500009876543210', 'PL61109010140000071219812874' ].each do |value_value|
-        expect(
-          SEPA::Transaction.new :iban => value_value
-        ).to have(:no).errors_on(:iban)
-      end
+      SEPA::Transaction.should accept('DE21500500009876543210', 'PL61109010140000071219812874', for: :iban)
     end
 
     it 'should not accept invalid value' do
-      [ nil, '', 'invalid' ].each do |invalue_value|
-        expect(
-          SEPA::Transaction.new :iban => invalue_value
-        ).to have_at_least(1).errors_on(:iban)
-      end
+      SEPA::Transaction.should_not accept(nil, '', 'invalid', for: :iban)
     end
   end
 
   context 'BIC' do
     it 'should accept valid value' do
-      [ 'DEUTDEFF', 'DEUTDEFF500', 'SPUEDE2UXXX' ].each do |value_value|
-        expect(
-          SEPA::Transaction.new :bic => value_value
-        ).to have(:no).errors_on(:bic)
-      end
+      SEPA::Transaction.should accept('DEUTDEFF', 'DEUTDEFF500', 'SPUEDE2UXXX', for: :bic)
     end
 
     it 'should not accept invalid value' do
-      [ nil, '', 'invalid' ].each do |invalue_value|
-        expect(
-          SEPA::Transaction.new :bic => invalue_value
-        ).to have_at_least(1).errors_on(:bic)
-      end
+      SEPA::Transaction.should_not accept(nil, '', 'invalid', for: :bic)
     end
   end
 
   context 'Amount' do
     it 'should accept valid value' do
-      [ 0.01, 1, 100, 100.00, 99.99, 1234567890.12, BigDecimal('10'), '42', '42.51', '42.512', 1.23456 ].each do |value_value|
-        expect(
-          SEPA::Transaction.new :amount => value_value
-        ).to have(:no).errors_on(:amount)
-      end
+      SEPA::Transaction.should accept(0.01, 1, 100, 100.00, 99.99, 1234567890.12, BigDecimal('10'), '42', '42.51', '42.512', 1.23456, for: :amount)
     end
 
     it 'should not accept invalid value' do
-      [ nil, 0, -3, 'xz' ].each do |invalue_value|
-        expect(
-          SEPA::Transaction.new :amount => invalue_value
-        ).to have_at_least(1).errors_on(:amount)
-      end
+      SEPA::Transaction.should_not accept(nil, 0, -3, 'xz', for: :amount)
     end
   end
 
   context 'Reference' do
     it 'should accept valid value' do
-      [ nil, 'ABC-1234/78.0', 'X' * 35 ].each do |value_value|
-        expect(
-          SEPA::Transaction.new :reference => value_value
-        ).to have(:no).errors_on(:reference)
-      end
+      SEPA::Transaction.should accept(nil, 'ABC-1234/78.0', 'X' * 35, for: :reference)
     end
 
     it 'should not accept invalid value' do
-      [ '', 'X' * 36 ].each do |invalid_value|
-        expect(
-          SEPA::Transaction.new :reference => invalid_value
-        ).to have_at_least(1).errors_on(:reference)
-      end
+      SEPA::Transaction.should_not accept('', 'X' * 36, for: :amount)
     end
   end
 
   context 'Remittance information' do
     it 'should allow valid value' do
-      [ nil, 'Bonus', 'X' * 140 ].each do |valid_value|
-        expect(
-          SEPA::Transaction.new :remittance_information => valid_value
-        ).to have(:no).errors_on(:remittance_information)
-      end
+      SEPA::Transaction.should accept(nil, 'Bonus', 'X' * 140, for: :remittance_information)
+    end
+
+    it 'should not allow invalid value' do
+      SEPA::Transaction.should_not accept('', 'X' * 141, for: :remittance_information)
+    end
+  end
+
+  context 'Requested date' do
+    it 'should allow valid value' do
+      SEPA::Transaction.should accept(nil, Date.today.next, Date.today + 2, for: :requested_date)
     end
 
     it 'should not allow invalid value' do
-      [ '', 'X' * 141 ].each do |invalid_value|
-        expect(
-          SEPA::Transaction.new :remittance_information => invalid_value
-        ).to have_at_least(1).errors_on(:remittance_information)
-      end
+      SEPA::Transaction.should_not accept(Date.new(1995,12,21), Date.today - 1, Date.today, for: :requested_date)
     end
   end
 end

data/spec/validation_spec.rb

@@ -2,12 +2,20 @@ require 'spec_helper'
 
 describe 'Credit Transfer Initiation' do
   it "should validate example file" do
-    XML::Document.file('spec/examples/pain.001.002.03.xml').should validate_against('pain.001.002.03.xsd')
+    File.read('spec/examples/pain.001.002.03.xml').should validate_against('pain.001.002.03.xsd')
+  end
+
+  it 'should not validate dummy string' do
+    'foo'.should_not validate_against('pain.001.002.03.xsd')
   end
 end
 
 describe 'Direct Debit Initiation' do
   it 'should validate example file' do
-    XML::Document.file('spec/examples/pain.008.002.02.xml').should validate_against('pain.008.002.02.xsd')
+    File.read('spec/examples/pain.008.002.02.xml').should validate_against('pain.008.002.02.xsd')
+  end
+
+  it 'should not validate dummy string' do
+    'foo'.should_not validate_against('pain.008.002.02.xsd')
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sepa_king
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Georg Leciejewski
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-26 00:00:00.000000000 Z
+date: 2013-08-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -87,16 +87,16 @@ dependencies:
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.14'
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
@@ -110,7 +110,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: coveralls
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
@@ -138,7 +138,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: libxml-ruby
+  name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
@@ -162,9 +162,10 @@ files:
 - .gitignore
 - .rspec
 - .travis.yml
+- CONTRIBUTING.md
 - Gemfile
-- MIT-LICENSE
-- README.markdown
+- LICENSE.txt
+- README.md
 - Rakefile
 - lib/schema/pain.001.002.03.xsd
 - lib/schema/pain.008.002.02.xsd
@@ -179,6 +180,7 @@ files:
 - lib/sepa_king/transaction.rb
 - lib/sepa_king/transaction/credit_transfer_transaction.rb
 - lib/sepa_king/transaction/direct_debit_transaction.rb
+- lib/sepa_king/validator.rb
 - lib/sepa_king/version.rb
 - sepa_king.gemspec
 - spec/account_spec.rb
@@ -194,6 +196,7 @@ files:
 - spec/message_spec.rb
 - spec/spec_helper.rb
 - spec/support/custom_matcher.rb
+- spec/support/factories.rb
 - spec/support/validations.rb
 - spec/transaction_spec.rb
 - spec/validation_spec.rb
@@ -209,7 +212,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - '>='
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - '>='
@@ -220,7 +223,7 @@ rubyforge_project:
 rubygems_version: 2.0.7
 signing_key: 
 specification_version: 4
-summary: Generate SEPA XML files with Ruby ... the easy way
+summary: Ruby gem for creating SEPA XML files
 test_files:
 - spec/account_spec.rb
 - spec/converter_spec.rb
@@ -235,6 +238,7 @@ test_files:
 - spec/message_spec.rb
 - spec/spec_helper.rb
 - spec/support/custom_matcher.rb
+- spec/support/factories.rb
 - spec/support/validations.rb
 - spec/transaction_spec.rb
 - spec/validation_spec.rb

data/README.markdown

@@ -1,91 +0,0 @@
-# Handle SEPA like a king
-
-[![Build Status](https://secure.travis-ci.org/salesking/sepa_king.png)](http://travis-ci.org/salesking/sepa_king)
-[![Code Climate](https://codeclimate.com/github/salesking/sepa_king.png)](https://codeclimate.com/github/salesking/sepa_king)
-[![Coverage Status](https://coveralls.io/repos/salesking/sepa_king/badge.png)](https://coveralls.io/r/salesking/sepa_king)
-
-We love building payment applications! So after developing the [DTAUS library for Ruby](https://github.com/salesking/king_dtaus) we move on with SEPA!
-
-This is just the beginning. There is still a lot to do. Please stay tuned...
-
-
-## Features
-
-* Credit transfer (pain.001.002.03)
-* Debit transfer (pain.008.002.02)
-* 100% test coverage to ensure software quality
-* Tested with Ruby 1.9.3 and 2.0.0
-
-
-## Installation
-
-    gem install sepa_king
-
-
-## Examples
-
-How to create a SEPA file for direct debit ("Lastschrift")
-
-```ruby
-# First: Create the main object
-dd = SEPA::DirectDebit.new :name       => 'Gläubiger GmbH',
-                           :bic        => 'BANKDEFFXXX',
-                           :iban       => 'DE87200500001234567890',
-                           :identifier => 'DE98ZZZ09999999999'
-
-# Second: Add transactions
-dd.add_transaction :name                      => 'Zahlemann & Söhne GbR',
-                   :bic                       => 'SPUEDE2UXXX',
-                   :iban                      => 'DE21500500009876543210',
-                   :amount                    => 39.99,
-                   :reference                 => 'XYZ/2013-08-ABO/6789',
-                   :remittance_information    => 'Vielen Dank für Ihren Einkauf!',
-                   :mandate_id                => 'K-02-2011-12345',
-                   :mandate_date_of_signature => Date.new(2011,1,25)
-dd.add_transaction ...
-
-# Last: create XML string
-xml_string = dd.to_xml
-```
-
-
-How to create a SEPA file for credit transfer ("Überweisung")
-
-```ruby
-# First: Create the main object
-ct = SEPA::CreditTransfer.new :name       => 'Schuldner GmbH',
-                              :bic        => 'BANKDEFFXXX',
-                              :iban       => 'DE87200500001234567890'
-
-# Second: Add transactions
-ct.add_transaction :name                   => 'Telekomiker AG',
-                   :bic                    => 'PBNKDEFF370',
-                   :iban                   => 'DE37112589611964645802',
-                   :amount                 => 102.50,
-                   :reference              => 'XYZ-1234/123',
-                   :remittance_information => 'Rechnung vom 22.08.2013'
-ct.add_transaction ...
-
-# Last: create XML string
-xml_string = ct.to_xml
-```
-
-Make sure to read the code and the specs!
-
-
-## Changelog
-
-https://github.com/salesking/sepa_king/releases
-
-
-## Resources
-
-* http://www.ebics.de/index.php?id=77
-* SalesKing: http://salesking.eu
-
-
-## License
-
-Released under the MIT license
-
-Copyright (c) 2013 Georg Leciejewski (SalesKing), Georg Ledermann (https://github.com/ledermann)