sepa_king 0.0.4 → 0.0.5

data/lib/sepa_king/message/direct_debit.rb

@@ -4,98 +4,108 @@ module SEPA
   class DirectDebit < Message
     self.account_class = CreditorAccount
     self.transaction_class = DirectDebitTransaction
+    self.xml_main_tag = 'CstmrDrctDbtInitn'
 
-    def to_xml
-      super
-      builder = Builder::XmlMarkup.new :indent => 2
-      builder.instruct!
-      builder.Document :xmlns                => 'urn:iso:std:iso:20022:tech:xsd:pain.008.002.02',
-                       :'xmlns:xsi'          => 'http://www.w3.org/2001/XMLSchema-instance',
-                       :'xsi:schemaLocation' => 'urn:iso:std:iso:20022:tech:xsd:pain.008.002.02 pain.008.002.02.xsd' do
-        builder.CstmrDrctDbtInitn do
-          build_group_header(builder)
-          build_payment_information(builder)
-        end
+  private
+    # @return {Hash<Symbol=>String>} xml schema information used in output xml
+    def xml_schema
+      { :xmlns                => 'urn:iso:std:iso:20022:tech:xsd:pain.008.002.02',
+        :'xmlns:xsi'          => 'http://www.w3.org/2001/XMLSchema-instance',
+        :'xsi:schemaLocation' => 'urn:iso:std:iso:20022:tech:xsd:pain.008.002.02 pain.008.002.02.xsd' }
+    end
+
+    # Find groups of transactions which share the same values of some attributes
+    def grouped_transactions
+      transactions.group_by do |transaction|
+        { requested_date:   transaction.requested_date,
+          local_instrument: transaction.local_instrument,
+          sequence_type:    transaction.sequence_type,
+          batch_booking:    transaction.batch_booking
+        }
       end
     end
 
-  private
-    def build_payment_information(builder)
-      builder.PmtInf do
-        builder.PmtInfId(payment_information_identification)
-        builder.PmtMtd('DD')
-        builder.NbOfTxs(transactions.length)
-        builder.CtrlSum('%.2f' % amount_total)
-        builder.PmtTpInf do
-          builder.SvcLvl do
-            builder.Cd('SEPA')
+    def build_payment_informations(builder)
+      # Build a PmtInf block for every group of transactions
+      grouped_transactions.each do |group, transactions|
+        builder.PmtInf do
+          builder.PmtInfId(payment_information_identification)
+          builder.PmtMtd('DD')
+          builder.BtchBookg(group[:batch_booking])
+          builder.NbOfTxs(transactions.length)
+          builder.CtrlSum('%.2f' % amount_total(transactions))
+          builder.PmtTpInf do
+            builder.SvcLvl do
+              builder.Cd('SEPA')
+            end
+            builder.LclInstrm do
+              builder.Cd(group[:local_instrument])
+            end
+            builder.SeqTp(group[:sequence_type])
           end
-          builder.LclInstrm do
-            builder.Cd('CORE')
+          builder.ReqdColltnDt(group[:requested_date].iso8601)
+          builder.Cdtr do
+            builder.Nm(account.name)
           end
-          builder.SeqTp('OOFF')
-        end
-        builder.ReqdColltnDt(Date.today.next.iso8601)
-        builder.Cdtr do
-          builder.Nm(account.name)
-        end
-        builder.CdtrAcct do
-          builder.Id do
-            builder.IBAN(account.iban)
+          builder.CdtrAcct do
+            builder.Id do
+              builder.IBAN(account.iban)
+            end
           end
-        end
-        builder.CdtrAgt do
-          builder.FinInstnId do
-            builder.BIC(account.bic)
+          builder.CdtrAgt do
+            builder.FinInstnId do
+              builder.BIC(account.bic)
+            end
           end
-        end
-        builder.ChrgBr('SLEV')
-        builder.CdtrSchmeId do
-          builder.Id do
-            builder.PrvtId do
-              builder.Othr do
-                builder.Id(account.identifier)
-                builder.SchmeNm do
-                  builder.Prtry('SEPA')
+          builder.ChrgBr('SLEV')
+          builder.CdtrSchmeId do
+            builder.Id do
+              builder.PrvtId do
+                builder.Othr do
+                  builder.Id(account.creditor_identifier)
+                  builder.SchmeNm do
+                    builder.Prtry('SEPA')
+                  end
                 end
               end
             end
           end
+
+          transactions.each do |transaction|
+            build_transaction(builder, transaction)
+          end
         end
-        build_transactions(builder)
       end
     end
 
-    def build_transactions(builder)
-      transactions.each do |transaction|
-        builder.DrctDbtTxInf do
-          builder.PmtId do
-            builder.EndToEndId(transaction.reference || 'NOTPROVIDED')
-          end
-          builder.InstdAmt('%.2f' % transaction.amount, :Ccy => 'EUR')
-          builder.DrctDbtTx do
-            builder.MndtRltdInf do
-              builder.MndtId(transaction.mandate_id)
-              builder.DtOfSgntr(transaction.mandate_date_of_signature.iso8601)
-            end
-          end
-          builder.DbtrAgt do
-            builder.FinInstnId do
-              builder.BIC(transaction.bic)
-            end
+    def build_transaction(builder, transaction)
+      builder.DrctDbtTxInf do
+        builder.PmtId do
+          builder.EndToEndId(transaction.reference)
+        end
+        builder.InstdAmt('%.2f' % transaction.amount, Ccy: 'EUR')
+        builder.DrctDbtTx do
+          builder.MndtRltdInf do
+            builder.MndtId(transaction.mandate_id)
+            builder.DtOfSgntr(transaction.mandate_date_of_signature.iso8601)
           end
-          builder.Dbtr do
-            builder.Nm(transaction.name)
+        end
+        builder.DbtrAgt do
+          builder.FinInstnId do
+            builder.BIC(transaction.bic)
           end
-          builder.DbtrAcct do
-            builder.Id do
-              builder.IBAN(transaction.iban)
-            end
+        end
+        builder.Dbtr do
+          builder.Nm(transaction.name)
+        end
+        builder.DbtrAcct do
+          builder.Id do
+            builder.IBAN(transaction.iban)
           end
-          if transaction.remittance_information
-            builder.RmtInf do
-              builder.Ustrd(transaction.remittance_information)
-            end
+        end
+        if transaction.remittance_information
+          builder.RmtInf do
+            builder.Ustrd(transaction.remittance_information)
           end
         end
       end

data/lib/sepa_king/transaction.rb

@@ -1,22 +1,35 @@
 # encoding: utf-8
 module SEPA
   class Transaction
-    include ActiveModel::Model
+    include ActiveModel::Validations
     extend Converter
 
-    attr_accessor :name, :iban, :bic, :amount, :reference, :remittance_information
-    convert :name, :reference, :remittance_information, :to => :text
-    convert :amount, :to => :decimal
+    attr_accessor :name, :iban, :bic, :amount, :reference, :remittance_information, :requested_date, :batch_booking
+    convert :name, :reference, :remittance_information, to: :text
+    convert :amount, to: :decimal
 
-    validates_presence_of :name, :iban, :bic, :amount
-    validates_length_of :name, :maximum => 70
-    validates_length_of :bic, :within => 8..11
-    validates_length_of :reference, :maximum => 35, :minimum => 1, :allow_nil => true
-    validates_length_of :remittance_information, :minimum => 1, :maximum => 140, :allow_nil => true
-    validates_numericality_of :amount, :greater_than => 0
+    validates_length_of :name, within: 1..70
+    validates_length_of :reference, within: 1..35, allow_nil: true
+    validates_length_of :remittance_information, within: 1..140, allow_nil: true
+    validates_numericality_of :amount, greater_than: 0
+    validates_presence_of :requested_date
+    validates_inclusion_of :batch_booking, :in => [true, false]
+    validates_with BICValidator, IBANValidator
 
     validate do |t|
-      errors.add(:iban, 'is invalid') unless IBANTools::IBAN.valid?(t.iban.to_s)
+      if t.requested_date.is_a?(Date)
+        errors.add(:requested_date, 'is not in the future') if t.requested_date <= Date.today
+      end
+    end
+
+    def initialize(attributes = {})
+      attributes.each do |name, value|
+        send("#{name}=", value)
+      end
+
+      self.requested_date ||= Date.today.next
+      self.reference ||= 'NOTPROVIDED'
+      self.batch_booking = true if self.batch_booking.nil?
     end
   end
 end

data/lib/sepa_king/transaction/direct_debit_transaction.rb

@@ -1,10 +1,12 @@
 # encoding: utf-8
 module SEPA
   class DirectDebitTransaction < Transaction
-    attr_accessor :mandate_id, :mandate_date_of_signature
+    attr_accessor :mandate_id, :mandate_date_of_signature, :local_instrument, :sequence_type
 
-    validates_length_of :mandate_id, :within => 1..35
+    validates_length_of :mandate_id, within: 1..35
     validates_presence_of :mandate_date_of_signature
+    validates_inclusion_of :local_instrument, :in => %w(CORE B2B)
+    validates_inclusion_of :sequence_type, :in => %w(FRST OOFF RCUR FNAL)
 
     validate do |t|
       if t.mandate_date_of_signature.is_a?(Date)
@@ -13,5 +15,11 @@ module SEPA
         errors.add(:mandate_date_of_signature, 'is not a Date')
       end
     end
+
+    def initialize(attributes = {})
+      super
+      self.local_instrument ||= 'CORE'
+      self.sequence_type ||= 'OOFF'
+    end
   end
 end

data/lib/sepa_king/validator.rb

@@ -0,0 +1,36 @@
+# encoding: utf-8
+module SEPA
+  class IBANValidator < ActiveModel::Validator
+    def validate(record)
+      unless IBANTools::IBAN.valid?(record.iban.to_s)
+        record.errors.add(:iban, 'is invalid')
+      end
+    end
+  end
+
+  class BICValidator < ActiveModel::Validator
+    def validate(record)
+      unless record.bic.to_s.match /[A-Z]{6,6}[A-Z2-9][A-NP-Z0-9]([A-Z0-9]{3,3}){0,1}/
+        record.errors.add(:bic, 'is invalid')
+      end
+    end
+  end
+
+  class CreditorIdentifierValidator < ActiveModel::Validator
+    def validate(record)
+      unless valid?(record.creditor_identifier)
+        record.errors.add(:creditor_identifier, 'is invalid')
+      end
+    end
+
+    def valid?(creditor_identifier)
+      if ok = creditor_identifier.to_s.match(/[a-zA-Z]{2,2}[0-9]{2,2}([A-Za-z0-9]|[\+|\?|\/|\-|\:|\(|\)|\.|,|']){3,3}([A-Za-z0-9]|[\+|\?|\/|\-|:|\(|\)|\.|,|']){1,28}/)
+        # In Germany, the identifier has to be exactly 18 chars long
+        if creditor_identifier[0..1].match(/DE/i)
+          ok = creditor_identifier.length == 18
+        end
+      end
+      ok
+    end
+  end
+end

data/lib/sepa_king/version.rb

@@ -1,3 +1,3 @@
 module SEPA
-  VERSION = '0.0.4'
+  VERSION = '0.0.5'
 end

data/sepa_king.gemspec

@@ -9,7 +9,7 @@ Gem::Specification.new do |s|
   s.authors       = ['Georg Leciejewski', 'Georg Ledermann']
   s.email         = ['gl@salesking.eu', 'mail@georg-ledermann.de']
   s.description   = 'Implemention of pain.001.002.03 and pain.008.002.02 (ISO 20022)'
-  s.summary       = 'Generate SEPA XML files with Ruby ... the easy way'
+  s.summary       = 'Ruby gem for creating SEPA XML files'
   s.homepage      = 'http://github.com/salesking/sepa_king'
   s.license       = 'MIT'
 
@@ -18,15 +18,17 @@ Gem::Specification.new do |s|
   s.test_files    = s.files.grep(%r{^(test|spec|features)/})
   s.require_paths = ['lib']
 
+  s.required_ruby_version = '>= 1.9.3'
+
   s.add_runtime_dependency 'activemodel'
   s.add_runtime_dependency 'i18n'
   s.add_runtime_dependency 'builder'
   s.add_runtime_dependency 'iban-tools'
 
   s.add_development_dependency 'bundler', '~> 1.3'
-  s.add_development_dependency 'rspec'
-  s.add_development_dependency 'simplecov'
+  s.add_development_dependency 'rspec', '>=2.14'
   s.add_development_dependency 'coveralls'
+  s.add_development_dependency 'simplecov'
   s.add_development_dependency 'rake'
-  s.add_development_dependency 'libxml-ruby'
+  s.add_development_dependency 'nokogiri'
 end

data/spec/account_spec.rb

@@ -2,65 +2,41 @@
 require 'spec_helper'
 
 describe SEPA::Account do
-  describe 'Initialization' do
+  describe :new do
     it 'should not accept unknown keys' do
       expect {
-        SEPA::Account.new :foo => 'bar'
+        SEPA::Account.new foo: 'bar'
       }.to raise_error(NoMethodError)
     end
   end
 
   describe :name do
     it 'should accept valid value' do
-      [ 'Gläubiger GmbH', 'Zahlemann & Söhne GbR', 'X' * 70 ].each do |value_value|
-        expect(
-          SEPA::Account.new :name => value_value
-        ).to have(:no).errors_on(:name)
-      end
+      SEPA::Account.should accept('Gläubiger GmbH', 'Zahlemann & Söhne GbR', 'X' * 70, for: :name)
     end
 
     it 'should not accept invalid value' do
-      [ nil, '', 'X' * 71 ].each do |invalue_value|
-        expect(
-          SEPA::Account.new :name => invalue_value
-        ).to have_at_least(1).errors_on(:name)
-      end
+      SEPA::Account.should_not accept(nil, '', 'X' * 71, for: :name)
     end
   end
 
   describe :iban do
     it 'should accept valid value' do
-      [ 'DE21500500009876543210', 'PL61109010140000071219812874' ].each do |value_value|
-        expect(
-          SEPA::Account.new :iban => value_value
-        ).to have(:no).errors_on(:iban)
-      end
+      SEPA::Account.should accept('DE21500500009876543210', 'PL61109010140000071219812874', for: :iban)
     end
 
     it 'should not accept invalid value' do
-      [ nil, '', 'invalid' ].each do |invalue_value|
-        expect(
-          SEPA::Account.new :iban => invalue_value
-        ).to have_at_least(1).errors_on(:iban)
-      end
+      SEPA::Account.should_not accept(nil, '', 'invalid', for: :iban)
     end
   end
 
   describe :bic do
     it 'should accept valid value' do
-      [ 'DEUTDEFF', 'DEUTDEFF500', 'SPUEDE2UXXX' ].each do |value_value|
-        expect(
-          SEPA::Account.new :bic => value_value
-        ).to have(:no).errors_on(:bic)
-      end
+      SEPA::Account.should accept('DEUTDEFF', 'DEUTDEFF500', 'SPUEDE2UXXX', for: :bic)
     end
 
     it 'should not accept invalid value' do
-      [ nil, '', 'invalid' ].each do |invalue_value|
-        expect(
-          SEPA::Account.new :bic => invalue_value
-        ).to have_at_least(1).errors_on(:bic)
-      end
+      SEPA::Account.should_not accept(nil, '', 'invalid', for: :bic)
     end
   end
 end

data/spec/credit_transfer_spec.rb

@@ -3,13 +3,13 @@ require 'spec_helper'
 
 describe SEPA::CreditTransfer do
   let(:credit_transfer) {
-    SEPA::CreditTransfer.new :name       => 'Schuldner GmbH',
-                             :bic        => 'BANKDEFFXXX',
-                             :iban       => 'DE87200500001234567890'
+    SEPA::CreditTransfer.new name:       'Schuldner GmbH',
+                             bic:        'BANKDEFFXXX',
+                             iban:       'DE87200500001234567890'
   }
 
   describe :new do
-    it 'should accept mission options' do
+    it 'should accept missing options' do
       expect {
         SEPA::CreditTransfer.new
       }.to_not raise_error
@@ -18,52 +18,185 @@ describe SEPA::CreditTransfer do
 
   describe :add_transaction do
     it 'should add valid transactions' do
-      3.times {
-        credit_transfer.add_transaction :name                   => 'Telekomiker AG',
-                                        :bic                    => 'PBNKDEFF370',
-                                        :iban                   => 'DE37112589611964645802',
-                                        :amount                 => 102.50,
-                                        :reference              => 'XYZ-1234/123',
-                                        :remittance_information => 'Rechnung vom 22.08.2013'
-      }
+      3.times do
+        credit_transfer.add_transaction(credit_transfer_transaction)
+      end
 
       expect(credit_transfer).to have(3).transactions
     end
 
     it 'should fail for invalid transaction' do
       expect {
-        credit_transfer.add_transaction :name => ''
+        credit_transfer.add_transaction name: ''
       }.to raise_error(ArgumentError)
     end
   end
 
   describe :to_xml do
-    it 'should fail for invalid debtor' do
-      expect {
-        SEPA::CreditTransfer.new.to_xml
-      }.to raise_error(RuntimeError)
+    context 'for invalid debtor' do
+      it 'should fail' do
+        expect {
+          SEPA::CreditTransfer.new.to_xml
+        }.to raise_error(RuntimeError)
+      end
     end
 
-    it 'should create valid XML file' do
-      ct = credit_transfer
-
-      ct.add_transaction :name                   => 'Telekomiker AG',
-                         :bic                    => 'PBNKDEFF370',
-                         :iban                   => 'DE37112589611964645802',
-                         :amount                 => 102.50,
-                         :reference              => 'XYZ-1234/123',
-                         :remittance_information => 'Rechnung vom 22.08.2013'
-
-      ct.add_transaction :name                   => 'Amazonas GmbH',
-                         :bic                    => 'TUBDDEDDXXX',
-                         :iban                   => 'DE27793589132923472195',
-                         :amount                 => 59.00,
-                         :reference              => 'XYZ-5678/456',
-                         :remittance_information => 'Rechnung vom 21.08.2013'
-
-      expect(
-        XML::Document.string(ct.to_xml)
-      ).to validate_against('pain.001.002.03.xsd')
+    context 'for valid debtor' do
+      context 'without requested_date given' do
+        subject do
+          sct = credit_transfer
+
+          sct.add_transaction name:                   'Telekomiker AG',
+                              bic:                    'PBNKDEFF370',
+                              iban:                   'DE37112589611964645802',
+                              amount:                 102.50,
+                              reference:              'XYZ-1234/123',
+                              remittance_information: 'Rechnung vom 22.08.2013'
+
+          sct.add_transaction name:                   'Amazonas GmbH',
+                              bic:                    'TUBDDEDDXXX',
+                              iban:                   'DE27793589132923472195',
+                              amount:                 59.00,
+                              reference:              'XYZ-5678/456',
+                              remittance_information: 'Rechnung vom 21.08.2013'
+
+          sct.to_xml
+        end
+
+        it 'should create valid XML file' do
+          expect(subject).to validate_against('pain.001.002.03.xsd')
+        end
+
+        it 'should contain <PmtMtd>' do
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf/PmtMtd', 'TRF')
+        end
+
+        it 'should contain <BtchBookg>' do
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf/BtchBookg', 'true')
+        end
+
+        it 'should contain <NbOfTxs>' do
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf/NbOfTxs', '2')
+        end
+
+        it 'should contain <CtrlSum>' do
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf/CtrlSum', '161.50')
+        end
+
+        it 'should contain <Dbtr>' do
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf/Dbtr/Nm', 'Schuldner GmbH')
+        end
+
+        it 'should contain <DbtrAcct>' do
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf/DbtrAcct/Id/IBAN', 'DE87200500001234567890')
+        end
+
+        it 'should contain <DbtrAgt>' do
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf/DbtrAgt/FinInstnId/BIC', 'BANKDEFFXXX')
+        end
+
+        it 'should contain <EndToEndId>' do
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf/CdtTrfTxInf[1]/PmtId/EndToEndId', 'XYZ-1234/123')
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf/CdtTrfTxInf[2]/PmtId/EndToEndId', 'XYZ-5678/456')
+        end
+
+        it 'should contain <Amt>' do
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf/CdtTrfTxInf[1]/Amt/InstdAmt', '102.50')
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf/CdtTrfTxInf[2]/Amt/InstdAmt', '59.00')
+        end
+
+        it 'should contain <CdtrAgt>' do
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf/CdtTrfTxInf[1]/CdtrAgt/FinInstnId/BIC', 'PBNKDEFF370')
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf/CdtTrfTxInf[2]/CdtrAgt/FinInstnId/BIC', 'TUBDDEDDXXX')
+        end
+
+        it 'should contain <Cdtr>' do
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf/CdtTrfTxInf[1]/Cdtr/Nm', 'Telekomiker AG')
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf/CdtTrfTxInf[2]/Cdtr/Nm', 'Amazonas GmbH')
+        end
+
+        it 'should contain <CdtrAcct>' do
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf/CdtTrfTxInf[1]/CdtrAcct/Id/IBAN', 'DE37112589611964645802')
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf/CdtTrfTxInf[2]/CdtrAcct/Id/IBAN', 'DE27793589132923472195')
+        end
+
+        it 'should contain <RmtInf>' do
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf/CdtTrfTxInf[1]/RmtInf/Ustrd', 'Rechnung vom 22.08.2013')
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf/CdtTrfTxInf[2]/RmtInf/Ustrd', 'Rechnung vom 21.08.2013')
+        end
+      end
+
+      context 'with different requested_date given' do
+        subject do
+          sct = credit_transfer
+
+          sct.add_transaction(credit_transfer_transaction.merge requested_date: Date.today + 1)
+          sct.add_transaction(credit_transfer_transaction.merge requested_date: Date.today + 2)
+          sct.add_transaction(credit_transfer_transaction.merge requested_date: Date.today + 2)
+
+          sct.to_xml
+        end
+
+        it 'should contain two payment_informations with <ReqdExctnDt>' do
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf[1]/ReqdExctnDt', (Date.today + 1).iso8601)
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf[2]/ReqdExctnDt', (Date.today + 2).iso8601)
+
+          subject.should_not have_xml('//Document/CstmrCdtTrfInitn/PmtInf[3]')
+        end
+      end
+
+      context 'with different batch_booking given' do
+        subject do
+          sct = credit_transfer
+
+          sct.add_transaction(credit_transfer_transaction.merge batch_booking: false)
+          sct.add_transaction(credit_transfer_transaction.merge batch_booking: true)
+          sct.add_transaction(credit_transfer_transaction.merge batch_booking: true)
+
+          sct.to_xml
+        end
+
+        it 'should contain two payment_informations with <BtchBookg>' do
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf[1]/BtchBookg', 'false')
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf[2]/BtchBookg', 'true')
+
+          subject.should_not have_xml('//Document/CstmrCdtTrfInitn/PmtInf[3]')
+        end
+      end
+
+      context 'with transactions containing different group criteria' do
+        subject do
+          sct = credit_transfer
+
+          sct.add_transaction(credit_transfer_transaction.merge requested_date: Date.today + 1, batch_booking: false, amount: 1)
+          sct.add_transaction(credit_transfer_transaction.merge requested_date: Date.today + 1, batch_booking: true,  amount: 2)
+          sct.add_transaction(credit_transfer_transaction.merge requested_date: Date.today + 2, batch_booking: false, amount: 4)
+          sct.add_transaction(credit_transfer_transaction.merge requested_date: Date.today + 2, batch_booking: true,  amount: 8)
+
+          sct.to_xml
+        end
+
+        it 'should contain multiple payment_informations' do
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf[1]/ReqdExctnDt', (Date.today + 1).iso8601)
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf[1]/BtchBookg', 'false')
+
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf[2]/ReqdExctnDt', (Date.today + 1).iso8601)
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf[2]/BtchBookg', 'true')
+
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf[3]/ReqdExctnDt', (Date.today + 2).iso8601)
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf[3]/BtchBookg', 'false')
+
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf[4]/ReqdExctnDt', (Date.today + 2).iso8601)
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf[4]/BtchBookg', 'true')
+        end
+
+        it 'should have multiple control sums' do
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf[1]/CtrlSum', '1.00')
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf[2]/CtrlSum', '2.00')
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf[3]/CtrlSum', '4.00')
+          subject.should have_xml('//Document/CstmrCdtTrfInitn/PmtInf[4]/CtrlSum', '8.00')
+        end
+      end
     end
   end
 end