sendgrid4r 0.5.0 → 1.0.0

data/spec/rest/contacts/segments_spec.rb

@@ -6,9 +6,7 @@ describe SendGrid4r::REST::Contacts::Segments do
     before do
       begin
         Dotenv.load
-        @client = SendGrid4r::Client.new(
-          username: ENV['SENDGRID_USERNAME'],
-          password: ENV['SENDGRID_PASSWORD'])
+        @client = SendGrid4r::Client.new(api_key: ENV['API_KEY'])
         @name1 = 'test_segment1'
         @name2 = 'test_segment2'
         @edit_name1 = 'test_segment_edit'
@@ -21,24 +19,32 @@ describe SendGrid4r::REST::Contacts::Segments do
 
         # celan up test env(segment)
         @client.get_segments.segments.each do |segment|
-          @client.delete_segment(segment.id) if segment.name == @name1
-          @client.delete_segment(segment.id) if segment.name == @edit_name1
-          @client.delete_segment(segment.id) if segment.name == @name2
+          @client.delete_segment(
+            segment_id: segment.id
+          ) if segment.name == @name1
+          @client.delete_segment(
+            segment_id: segment.id
+          ) if segment.name == @edit_name1
+          @client.delete_segment(
+            segment_id: segment.id
+          ) if segment.name == @name2
         end
         # clean up test env(custom_fields)
         @client.get_custom_fields.custom_fields.each do |field|
-          @client.delete_custom_field(field.id) if field.name == @field
+          @client.delete_custom_field(
+            custom_field_id: field.id
+          ) if field.name == @field
         end
         # post a custom field and a segment
-        @client.post_custom_field(@field, 'text')
+        @client.post_custom_field(name: @field, type: 'text')
         @condition = @condition_factory.create(
           field: @field, value: @value, operator: @operator, and_or: @and_or
         )
         params1 = @segment_factory.create(
           name: @name1, conditions: [@condition]
         )
-        @segment1 = @client.post_segment(params1)
-      rescue => e
+        @segment1 = @client.post_segment(params: params1)
+      rescue RestClient::ExceptionWithResponse => e
         puts e.inspect
         raise e
       end
@@ -50,7 +56,7 @@ describe SendGrid4r::REST::Contacts::Segments do
           params2 = @segment_factory.create(
             name: @name2, conditions: [@condition]
           )
-          segment = @client.post_segment(params2)
+          segment = @client.post_segment(params: params2)
           expect(segment.id).to be_a(Fixnum)
           expect(segment.name).to eq(@name2)
           expect(segment.list_id).to eq(nil)
@@ -62,7 +68,7 @@ describe SendGrid4r::REST::Contacts::Segments do
           expect(condition.operator).to eq(@operator)
           expect(condition.and_or).to eq(nil)
           expect(segment.recipient_count).to eq(0)
-        rescue => e
+        rescue RestClient::ExceptionWithResponse => e
           puts e.inspect
           raise e
         end
@@ -76,7 +82,7 @@ describe SendGrid4r::REST::Contacts::Segments do
               segment
             ).to be_a(SendGrid4r::REST::Contacts::Segments::Segment)
           end
-        rescue => e
+        rescue RestClient::ExceptionWithResponse => e
           puts e.inspect
           raise e
         end
@@ -84,7 +90,7 @@ describe SendGrid4r::REST::Contacts::Segments do
 
       it '#get_segment' do
         begin
-          segment = @client.get_segment(@segment1.id)
+          segment = @client.get_segment(segment_id: @segment1.id)
           expect(segment.id).to eq(@segment1.id)
           expect(segment.name).to eq(@segment1.name)
           expect(segment.list_id).to eq(nil)
@@ -94,7 +100,7 @@ describe SendGrid4r::REST::Contacts::Segments do
           expect(condition.operator).to eq(@operator)
           expect(condition.and_or).to eq(nil)
           expect(segment.recipient_count).to be_a(Fixnum)
-        rescue => e
+        rescue RestClient::ExceptionWithResponse => e
           puts e.inspect
           raise e
         end
@@ -102,13 +108,15 @@ describe SendGrid4r::REST::Contacts::Segments do
 
       it '#put_segment' do
         begin
-          pending 'waiting sendgrid documentation update'
+          pending 'waiting for sendgrid documentation update'
           edit_params = @segment_factory.create(
             name: @edit_name1, conditions: [@condition]
           )
-          edit_segment = @client.put_segment(@segment1.id, edit_params)
+          edit_segment = @client.put_segment(
+            segment_id: @segment1.id, params: edit_params
+          )
           expect(edit_segment.name).to eq(@edit_name1)
-        rescue => e
+        rescue RestClient::ExceptionWithResponse => e
           puts e.inspect
           raise e
         end
@@ -117,13 +125,15 @@ describe SendGrid4r::REST::Contacts::Segments do
       it '#get_recipients_from_segment' do
         begin
           # list recipients from a single segment
-          recipients = @client.get_recipients_from_segment(@segment1.id)
+          recipients = @client.get_recipients_from_segment(
+            segment_id: @segment1.id
+          )
           recipients.recipients.each do |recipient|
             expect(
               recipient
             ).to be_a(SendGrid4r::REST::Contacts::Recipients::Recipient)
           end
-        rescue => e
+        rescue RestClient::ExceptionWithResponse => e
           puts e.inspect
           raise e
         end
@@ -132,8 +142,8 @@ describe SendGrid4r::REST::Contacts::Segments do
       it '#delete_segment' do
         begin
           # delete the segment
-          @client.delete_segment(@segment1.id)
-        rescue => e
+          @client.delete_segment(segment_id: @segment1.id)
+        rescue RestClient::ExceptionWithResponse => e
           puts e.inspect
           raise e
         end
@@ -145,7 +155,7 @@ describe SendGrid4r::REST::Contacts::Segments do
         params2 = @segment_factory.create(
           name: @name2, conditions: [@condition]
         )
-        @client.post_segment(params2) do |resp, req, res|
+        @client.post_segment(params: params2) do |resp, req, res|
           resp =
             SendGrid4r::REST::Contacts::Segments.create_segment(
               JSON.parse(resp)
@@ -169,7 +179,7 @@ describe SendGrid4r::REST::Contacts::Segments do
       end
 
       it '#get_segment' do
-        @client.get_segment(@segment1.id) do |resp, req, res|
+        @client.get_segment(segment_id: @segment1.id) do |resp, req, res|
           resp =
             SendGrid4r::REST::Contacts::Segments.create_segment(
               JSON.parse(resp)
@@ -181,11 +191,13 @@ describe SendGrid4r::REST::Contacts::Segments do
       end
 
       it '#put_segment' do
-        pending 'waiting sendgrid documentation update'
+        pending 'waiting for sendgrid documentation update'
         edit_params = @segment_factory.create(
           name: @edit_name1, conditions: [@condition]
         )
-        @client.put_segment(@segment1.id, edit_params) do |resp, req, res|
+        @client.put_segment(
+          segment_id: @segment1.id, params: edit_params
+        ) do |resp, req, res|
           resp =
             SendGrid4r::REST::Contacts::Segments.create_segment(
               JSON.parse(resp)
@@ -197,7 +209,9 @@ describe SendGrid4r::REST::Contacts::Segments do
       end
 
       it '#get_recipients_from_segment' do
-        @client.get_recipients_from_segment(@segment1.id) do |resp, req, res|
+        @client.get_recipients_from_segment(
+          segment_id: @segment1.id
+        ) do |resp, req, res|
           resp =
             SendGrid4r::REST::Contacts::Recipients.create_recipients(
               JSON.parse(resp)
@@ -211,7 +225,7 @@ describe SendGrid4r::REST::Contacts::Segments do
       end
 
       it '#delete_segment' do
-        @client.delete_segment(@segment1.id) do |resp, req, res|
+        @client.delete_segment(segment_id: @segment1.id) do |resp, req, res|
           expect(resp).to eq('')
           expect(req).to be_a(RestClient::Request)
           expect(res).to be_a(Net::HTTPNoContent)
@@ -308,7 +322,7 @@ describe SendGrid4r::REST::Contacts::Segments do
 
     it '#post_segment' do
       allow(client).to receive(:execute).and_return(segment)
-      actual = client.post_segment(nil)
+      actual = client.post_segment(params: nil)
       expect(actual).to be_a(SendGrid4r::REST::Contacts::Segments::Segment)
     end
 
@@ -320,25 +334,25 @@ describe SendGrid4r::REST::Contacts::Segments do
 
     it '#get_segment' do
       allow(client).to receive(:execute).and_return(segment)
-      actual = client.get_segment(0)
+      actual = client.get_segment(segment_id: 0)
       expect(actual).to be_a(SendGrid4r::REST::Contacts::Segments::Segment)
     end
 
     it '#put_segment' do
       allow(client).to receive(:execute).and_return(segment)
-      actual = client.put_segment(0, nil)
+      actual = client.put_segment(segment_id: 0, params: nil)
       expect(actual).to be_a(SendGrid4r::REST::Contacts::Segments::Segment)
     end
 
     it '#get_recipients_from_segment' do
       allow(client).to receive(:execute).and_return(recipients)
-      actual = client.get_recipients_from_segment(0)
+      actual = client.get_recipients_from_segment(segment_id: 0)
       expect(actual).to be_a(SendGrid4r::REST::Contacts::Recipients::Recipients)
     end
 
     it '#delete_segment' do
       allow(client).to receive(:execute).and_return('')
-      actual = client.delete_segment(0)
+      actual = client.delete_segment(segment_id: 0)
       expect(actual).to eq('')
     end
 

data/spec/rest/email_activity/email_activity_spec.rb

@@ -6,10 +6,8 @@ describe SendGrid4r::REST::EmailActivity do
     before do
       begin
         Dotenv.load
-        @client = SendGrid4r::Client.new(
-          username: ENV['SENDGRID_USERNAME'],
-          password: ENV['SENDGRID_PASSWORD'])
-      rescue => e
+        @client = SendGrid4r::Client.new(api_key: ENV['API_KEY'])
+      rescue RestClient::ExceptionWithResponse => e
         puts e.inspect
         raise e
       end
@@ -22,7 +20,7 @@ describe SendGrid4r::REST::EmailActivity do
           activities.each do |activity|
             expect(activity).to be_a(SendGrid4r::REST::EmailActivity::Activity)
           end
-        rescue => e
+        rescue RestClient::ExceptionWithResponse => e
           puts e.inspect
           raise e
         end
@@ -34,7 +32,7 @@ describe SendGrid4r::REST::EmailActivity do
           activities.each do |activity|
             expect(activity).to be_a(SendGrid4r::REST::EmailActivity::Activity)
           end
-        rescue => e
+        rescue RestClient::ExceptionWithResponse => e
           puts e.inspect
           raise e
         end
@@ -50,7 +48,7 @@ describe SendGrid4r::REST::EmailActivity do
             expect(activity).to be_a(SendGrid4r::REST::EmailActivity::Activity)
             expect(activity.event).to eq('drop')
           end
-        rescue => e
+        rescue RestClient::ExceptionWithResponse => e
           puts e.inspect
           raise e
         end
@@ -78,7 +76,7 @@ describe SendGrid4r::REST::EmailActivity do
           activities.each do |activity|
             expect(activity).to be_a(SendGrid4r::REST::EmailActivity::Activity)
           end
-        rescue => e
+        rescue RestClient::ExceptionWithResponse => e
           puts e.inspect
           raise e
         end
@@ -86,6 +84,7 @@ describe SendGrid4r::REST::EmailActivity do
 
       it '#get_email_activities with start_time and end_time' do
         begin
+          pending('unknown field')
           start_time = Time.local(2015, 5, 20, 12, 23, 45)
           end_time = Time.local(2015, 5, 23, 12, 23, 45)
           activities = @client.get_email_activities(
@@ -96,24 +95,12 @@ describe SendGrid4r::REST::EmailActivity do
             expect(activity).to be_a(SendGrid4r::REST::EmailActivity::Activity)
             puts activity.inspect
           end
-        rescue => e
+        rescue RestClient::ExceptionWithResponse => e
           puts e.inspect
           raise e
         end
       end
     end
-
-    context 'with block call' do
-      it '#get_email_activities' do
-        @client.get_api_keys do |resp, req, res|
-          resp =
-            SendGrid4r::REST::ApiKeys.create_api_keys(JSON.parse(resp))
-          expect(resp).to be_a(SendGrid4r::REST::ApiKeys::ApiKeys)
-          expect(req).to be_a(RestClient::Request)
-          expect(res).to be_a(Net::HTTPOK)
-        end
-      end
-    end
   end
 
   describe 'unit test', :ut do

data/spec/rest/ips/addresses_spec.rb

@@ -5,9 +5,7 @@ describe SendGrid4r::REST::Ips::Addresses do
   describe 'integration test', :it do
     before do
       Dotenv.load
-      @client = SendGrid4r::Client.new(
-        username: ENV['SENDGRID_USERNAME'],
-        password: ENV['SENDGRID_PASSWORD'])
+      @client = SendGrid4r::Client.new(api_key: ENV['API_KEY'])
     end
 
     context 'account is free' do
@@ -15,11 +13,11 @@ describe SendGrid4r::REST::Ips::Addresses do
         it 'raise error' do
           begin
             expect do
-              @client.get_ip('10.10.10.10').to raise_error(
+              @client.get_ip(ip: '10.10.10.10').to raise_error(
                 RestClient::Forbidden
               )
             end
-          rescue => e
+          rescue RestClient::ExceptionWithResponse => e
             puts e.inspect
             raise e
           end
@@ -32,16 +30,14 @@ describe SendGrid4r::REST::Ips::Addresses do
 
       before do
         begin
-          @client = SendGrid4r::Client.new(
-            username: ENV['SILVER_SENDGRID_USERNAME'],
-            password: ENV['SILVER_SENDGRID_PASSWORD'])
+          @client = SendGrid4r::Client.new(api_key: ENV['SILVER_API_KEY'])
           # refresh the pool
           pools = @client.get_pools
           pools.each do |pool|
-            @client.delete_pool(TEST_POOL) if pool.name == TEST_POOL
+            @client.delete_pool(name: TEST_POOL) if pool.name == TEST_POOL
           end
-          @client.post_pool(TEST_POOL)
-        rescue => e
+          @client.post_pool(name: TEST_POOL)
+        rescue RestClient::ExceptionWithResponse => e
           puts e.inspect
           raise e
         end
@@ -57,7 +53,7 @@ describe SendGrid4r::REST::Ips::Addresses do
             expect(ip.ip).to be_a(String)
             expect(ip.pools).to be_a(Array)
             expect(ip.warmup ? true : true).to eq(true)
-          rescue => e
+          rescue RestClient::ExceptionWithResponse => e
             puts e.inspect
             raise e
           end
@@ -68,7 +64,7 @@ describe SendGrid4r::REST::Ips::Addresses do
             ips = @client.get_ips_assigned
             expect(ips.length).to be > 0
             expect(ips[0]).to be_a(SendGrid4r::REST::Ips::Addresses::Address)
-          rescue => e
+          rescue RestClient::ExceptionWithResponse => e
             puts e.inspect
             raise e
           end
@@ -78,9 +74,9 @@ describe SendGrid4r::REST::Ips::Addresses do
           begin
             ips = @client.get_ips_assigned
             expect(
-              @client.get_ip(ips[0].ip)
+              @client.get_ip(ip: ips[0].ip)
             ).to be_a(SendGrid4r::REST::Ips::Addresses::Address)
-          rescue => e
+          rescue RestClient::ExceptionWithResponse => e
             puts e.inspect
             raise e
           end
@@ -89,74 +85,19 @@ describe SendGrid4r::REST::Ips::Addresses do
         it '#post_ip_to_pool' do
           begin
             ips = @client.get_ips_assigned
-            actual = @client.post_ip_to_pool(TEST_POOL, ips[0].ip)
+            actual = @client.post_ip_to_pool(
+              pool_name: TEST_POOL, ip: ips[0].ip
+            )
             expect(actual.ip).to eq(ips[0].ip)
             expect(actual.pools).to include(TEST_POOL)
             expect(actual.pools).to be_a(Array)
-            @client.delete_ip_from_pool(TEST_POOL, ips[0].ip)
-          rescue => e
+            @client.delete_ip_from_pool(pool_name: TEST_POOL, ip: ips[0].ip)
+          rescue RestClient::ExceptionWithResponse => e
             puts e.inspect
             raise e
           end
         end
       end
-
-      context 'with block call' do
-        it '#get_ips' do
-          @client.get_ips do |resp, req, res|
-            resp =
-              SendGrid4r::REST::Ips::Addresses.create_addresses(
-                JSON.parse(resp)
-              )
-            expect(resp).to be_a(Array)
-            expect(req).to be_a(RestClient::Request)
-            expect(res).to be_a(Net::HTTPOK)
-          end
-        end
-
-        it '#get_ips_assigned' do
-          @client.get_ips_assigned do |resp, req, res|
-            resp =
-              SendGrid4r::REST::Ips::Addresses.create_addresses(
-                JSON.parse(resp)
-              )
-            expect(resp).to be_a(Array)
-            expect(req).to be_a(RestClient::Request)
-            expect(res).to be_a(Net::HTTPOK)
-          end
-        end
-
-        it '#get_ip' do
-          ips = @client.get_ips_assigned
-          @client.get_ip(ips[0].ip) do |resp, req, res|
-            resp =
-              SendGrid4r::REST::Ips::Addresses.create_address(
-                JSON.parse(resp)
-              )
-            expect(resp).to be_a(SendGrid4r::REST::Ips::Addresses::Address)
-            expect(req).to be_a(RestClient::Request)
-            expect(res).to be_a(Net::HTTPOK)
-          end
-        end
-
-        it '#post_ip_to_pool' do
-          ips = @client.get_ips_assigned
-          @client.post_ip_to_pool(TEST_POOL, ips[0].ip) do |resp, req, res|
-            resp =
-              SendGrid4r::REST::Ips::Addresses.create_address(
-                JSON.parse(resp)
-              )
-            expect(resp).to be_a(SendGrid4r::REST::Ips::Addresses::Address)
-            expect(req).to be_a(RestClient::Request)
-            expect(res).to be_a(Net::HTTPCreated)
-          end
-          @client.delete_ip_from_pool(TEST_POOL, ips[0].ip) do |resp, req, res|
-            expect(resp).to eq('')
-            expect(req).to be_a(RestClient::Request)
-            expect(res).to be_a(Net::HTTPNoContent)
-          end
-        end
-      end
     end
 
     describe 'unit test', :ut do
@@ -213,13 +154,13 @@ describe SendGrid4r::REST::Ips::Addresses do
 
       it '#get_ip' do
         allow(client).to receive(:execute).and_return(address)
-        actual = client.get_ip('')
+        actual = client.get_ip(ip: '')
         expect(actual).to be_a(SendGrid4r::REST::Ips::Addresses::Address)
       end
 
       it '#post_ip_to_pool' do
         allow(client).to receive(:execute).and_return(address)
-        actual = client.post_ip_to_pool('', '')
+        actual = client.post_ip_to_pool(pool_name: '', ip: '')
         expect(actual).to be_a(SendGrid4r::REST::Ips::Addresses::Address)
       end
 

data/spec/rest/ips/pools_spec.rb

@@ -6,10 +6,7 @@ describe SendGrid4r::REST::Ips::Pools do
     before do
       begin
         Dotenv.load
-        @client = SendGrid4r::Client.new(
-          username: ENV['SILVER_SENDGRID_USERNAME'],
-          password: ENV['SILVER_SENDGRID_PASSWORD'])
-
+        @client = SendGrid4r::Client.new(api_key: ENV['SILVER_API_KEY'])
         @pool_name1 = 'pool_test1'
         @pool_name2 = 'pool_test2'
         @pool_edit1 = 'pool_edit1'
@@ -17,13 +14,13 @@ describe SendGrid4r::REST::Ips::Pools do
         # clean up test env
         pools = @client.get_pools
         pools.each do |pool|
-          @client.delete_pool(pool.name) if pool.name == @pool_name1
-          @client.delete_pool(pool.name) if pool.name == @pool_name2
-          @client.delete_pool(pool.name) if pool.name == @pool_edit1
+          @client.delete_pool(name: pool.name) if pool.name == @pool_name1
+          @client.delete_pool(name: pool.name) if pool.name == @pool_name2
+          @client.delete_pool(name: pool.name) if pool.name == @pool_edit1
         end
         # post a pool
-        @client.post_pool(@pool_name1)
-      rescue => e
+        @client.post_pool(name: @pool_name1)
+      rescue RestClient::ExceptionWithResponse => e
         puts e.inspect
         raise e
       end
@@ -33,9 +30,9 @@ describe SendGrid4r::REST::Ips::Pools do
       context 'without block call' do
         it '#post_pool' do
           begin
-            new_pool = @client.post_pool(@pool_name2)
+            new_pool = @client.post_pool(name: @pool_name2)
             expect(new_pool.name).to eq(@pool_name2)
-          rescue => e
+          rescue RestClient::ExceptionWithResponse => e
             puts e.inspect
             raise e
           end
@@ -49,7 +46,7 @@ describe SendGrid4r::REST::Ips::Pools do
               expect(pool).to be_a(SendGrid4r::REST::Ips::Pools::Pool)
               expect(pool.name).to be_a(String)
             end
-          rescue => e
+          rescue RestClient::ExceptionWithResponse => e
             puts e.inspect
             raise e
           end
@@ -57,11 +54,11 @@ describe SendGrid4r::REST::Ips::Pools do
 
         it '#get_pool' do
           begin
-            pool = @client.get_pool(@pool_name1)
+            pool = @client.get_pool(name: @pool_name1)
             expect(pool).to be_a(SendGrid4r::REST::Ips::Pools::Pool)
             expect(pool.pool_name).to eq(@pool_name1)
             expect(pool.ips).to be_a(Array)
-          rescue => e
+          rescue RestClient::ExceptionWithResponse => e
             puts e.inspect
             raise e
           end
@@ -69,9 +66,11 @@ describe SendGrid4r::REST::Ips::Pools do
 
         it '#put_pool' do
           begin
-            edit_pool = @client.put_pool(@pool_name1, @pool_edit1)
+            edit_pool = @client.put_pool(
+              name: @pool_name1, new_name: @pool_edit1
+            )
             expect(edit_pool.name).to eq(@pool_edit1)
-          rescue => e
+          rescue RestClient::ExceptionWithResponse => e
             puts e.inspect
             raise e
           end
@@ -79,71 +78,13 @@ describe SendGrid4r::REST::Ips::Pools do
 
         it '#delete_pool' do
           begin
-            @client.delete_pool(@pool_name1)
-          rescue => e
+            @client.delete_pool(name: @pool_name1)
+          rescue RestClient::ExceptionWithResponse => e
             puts e.inspect
             raise e
           end
         end
       end
-
-      context 'with block call' do
-        it '#post_pool' do
-          @client.post_pool(@pool_name2) do |resp, req, res|
-            resp =
-              SendGrid4r::REST::Ips::Pools.create_pool(
-                JSON.parse(resp)
-              )
-            expect(resp).to be_a(SendGrid4r::REST::Ips::Pools::Pool)
-            expect(req).to be_a(RestClient::Request)
-            expect(res).to be_a(Net::HTTPCreated)
-          end
-        end
-
-        it '#get_pools' do
-          @client.get_pools do |resp, req, res|
-            resp =
-              SendGrid4r::REST::Ips::Pools.create_pools(
-                JSON.parse(resp)
-              )
-            expect(resp).to be_a(Array)
-            expect(req).to be_a(RestClient::Request)
-            expect(res).to be_a(Net::HTTPOK)
-          end
-        end
-
-        it '#get_pool' do
-          @client.get_pool(@pool_name1) do |resp, req, res|
-            resp =
-              SendGrid4r::REST::Ips::Pools.create_pool(
-                JSON.parse(resp)
-              )
-            expect(resp).to be_a(SendGrid4r::REST::Ips::Pools::Pool)
-            expect(req).to be_a(RestClient::Request)
-            expect(res).to be_a(Net::HTTPOK)
-          end
-        end
-
-        it '#put_pool' do
-          @client.put_pool(@pool_name1, @pool_edit1) do |resp, req, res|
-            resp =
-              SendGrid4r::REST::Ips::Pools.create_pool(
-                JSON.parse(resp)
-              )
-            expect(resp).to be_a(SendGrid4r::REST::Ips::Pools::Pool)
-            expect(req).to be_a(RestClient::Request)
-            expect(res).to be_a(Net::HTTPOK)
-          end
-        end
-
-        it '#delete_pool' do
-          @client.delete_pool(@pool_name1) do |resp, req, res|
-            expect(resp).to eq('')
-            expect(req).to be_a(RestClient::Request)
-            expect(res).to be_a(Net::HTTPNoContent)
-          end
-        end
-      end
     end
   end
 
@@ -182,7 +123,7 @@ describe SendGrid4r::REST::Ips::Pools do
 
     it '#post_pool' do
       allow(client).to receive(:execute).and_return(pool)
-      actual = client.post_pool('')
+      actual = client.post_pool(name: '')
       expect(actual).to be_a(SendGrid4r::REST::Ips::Pools::Pool)
     end
 
@@ -197,19 +138,19 @@ describe SendGrid4r::REST::Ips::Pools do
 
     it '#get_pool' do
       allow(client).to receive(:execute).and_return(pool)
-      actual = client.get_pool('')
+      actual = client.get_pool(name: '')
       expect(actual).to be_a(SendGrid4r::REST::Ips::Pools::Pool)
     end
 
     it '#put_pool' do
       allow(client).to receive(:execute).and_return(pool)
-      actual = client.put_pool('', '')
+      actual = client.put_pool(name: '', new_name: '')
       expect(actual).to be_a(SendGrid4r::REST::Ips::Pools::Pool)
     end
 
     it '#delete_pool' do
       allow(client).to receive(:execute).and_return('')
-      actual = client.delete_pool('')
+      actual = client.delete_pool(name: '')
       expect(actual).to eq('')
     end