sendgrid4r 0.5.0 → 1.0.0

data/spec/client_spec.rb

@@ -32,6 +32,12 @@ describe SendGrid4r::Client do
         # Subusers
         expect(@client.respond_to?('get_subusers')).to eq(true)
         expect(@client.respond_to?('post_subuser')).to eq(true)
+        expect(@client.respond_to?('patch_subuser')).to eq(true)
+        expect(@client.respond_to?('delete_subuser')).to eq(true)
+        expect(@client.respond_to?('get_subuser_monitor')).to eq(true)
+        expect(@client.respond_to?('post_subuser_monitor')).to eq(true)
+        expect(@client.respond_to?('put_subuser_monitor')).to eq(true)
+        expect(@client.respond_to?('delete_subuser_monitor')).to eq(true)
         expect(@client.respond_to?('get_subuser_reputation')).to eq(true)
         expect(@client.respond_to?('put_subuser_assigned_ips')).to eq(true)
         # Api Keys
@@ -79,6 +85,58 @@ describe SendGrid4r::Client do
         # enforced_tls
         expect(@client.respond_to?('get_enforced_tls')).to eq(true)
         expect(@client.respond_to?('patch_enforced_tls')).to eq(true)
+        # mail
+        expect(@client.respond_to?('get_mail_settings')).to eq(true)
+        expect(
+          @client.respond_to?('get_settings_address_whitelist')
+        ).to eq(true)
+        expect(
+          @client.respond_to?('patch_settings_address_whitelist')
+        ).to eq(true)
+        expect(@client.respond_to?('get_settings_bcc')).to eq(true)
+        expect(@client.respond_to?('patch_settings_bcc')).to eq(true)
+        expect(@client.respond_to?('get_settings_bounce_purge')).to eq(true)
+        expect(@client.respond_to?('patch_settings_bounce_purge')).to eq(true)
+        expect(
+          @client.respond_to?('get_settings_event_notification')
+        ).to eq(true)
+        expect(
+          @client.respond_to?('patch_settings_event_notification')
+        ).to eq(true)
+        expect(
+          @client.respond_to?('test_settings_event_notification')
+        ).to eq(true)
+        expect(@client.respond_to?('get_settings_footer')).to eq(true)
+        expect(@client.respond_to?('patch_settings_footer')).to eq(true)
+        expect(@client.respond_to?('get_settings_forward_bounce')).to eq(true)
+        expect(@client.respond_to?('patch_settings_forward_bounce')).to eq(true)
+        expect(@client.respond_to?('get_settings_forward_spam')).to eq(true)
+        expect(@client.respond_to?('patch_settings_forward_spam')).to eq(true)
+        expect(@client.respond_to?('get_settings_template')).to eq(true)
+        expect(@client.respond_to?('patch_settings_template')).to eq(true)
+        expect(@client.respond_to?('get_settings_plain_content')).to eq(true)
+        expect(@client.respond_to?('patch_settings_plain_content')).to eq(true)
+
+        # partner
+        expect(@client.respond_to?('get_partner_settings')).to eq(true)
+        expect(@client.respond_to?('get_settings_new_relic')).to eq(true)
+        expect(@client.respond_to?('patch_settings_new_relic')).to eq(true)
+        expect(@client.respond_to?('get_settings_sendwithus')).to eq(true)
+        expect(@client.respond_to?('patch_settings_sendwithus')).to eq(true)
+
+        # tracking
+        expect(@client.respond_to?('get_tracking_settings')).to eq(true)
+        expect(@client.respond_to?('get_settings_click')).to eq(true)
+        expect(@client.respond_to?('patch_settings_click')).to eq(true)
+        expect(@client.respond_to?('get_settings_google_analytics')).to eq(true)
+        expect(
+          @client.respond_to?('patch_settings_google_analytics')
+        ).to eq(true)
+        expect(@client.respond_to?('get_settings_open')).to eq(true)
+        expect(@client.respond_to?('patch_settings_open')).to eq(true)
+        expect(@client.respond_to?('get_settings_subscription')).to eq(true)
+        expect(@client.respond_to?('patch_settings_subscription')).to eq(true)
+
         # Template Engine
         # templates
         expect(@client.respond_to?('get_templates')).to eq(true)
@@ -144,12 +202,46 @@ describe SendGrid4r::Client do
         expect(@client.respond_to?('put_segment')).to eq(true)
         expect(@client.respond_to?('delete_segment')).to eq(true)
         expect(@client.respond_to?('get_recipients_from_segment')).to eq(true)
+
+        # Whitelabel
+        # Domains
+        expect(@client.respond_to?('get_wl_domains')).to eq(true)
+        expect(@client.respond_to?('post_wl_domain')).to eq(true)
+        expect(@client.respond_to?('get_wl_domain')).to eq(true)
+        expect(@client.respond_to?('patch_wl_domain')).to eq(true)
+        expect(@client.respond_to?('delete_wl_domain')).to eq(true)
+        expect(@client.respond_to?('get_default_wl_domain')).to eq(true)
+        expect(@client.respond_to?('add_ip_to_wl_domain')).to eq(true)
+        expect(@client.respond_to?('remove_ip_from_wl_domain')).to eq(true)
+        expect(@client.respond_to?('validate_wl_domain')).to eq(true)
+        expect(@client.respond_to?('get_associated_wl_domain')).to eq(true)
+        expect(@client.respond_to?('disassociate_wl_domain')).to eq(true)
+        expect(@client.respond_to?('associate_wl_domain')).to eq(true)
+
+        # IPs
+        expect(@client.respond_to?('get_wl_ips')).to eq(true)
+        expect(@client.respond_to?('post_wl_ip')).to eq(true)
+        expect(@client.respond_to?('get_wl_ip')).to eq(true)
+        expect(@client.respond_to?('delete_wl_ip')).to eq(true)
+        expect(@client.respond_to?('validate_wl_ip')).to eq(true)
+
+        # Email Links
+        expect(@client.respond_to?('get_wl_links')).to eq(true)
+        expect(@client.respond_to?('post_wl_link')).to eq(true)
+        expect(@client.respond_to?('get_wl_link')).to eq(true)
+        expect(@client.respond_to?('patch_wl_link')).to eq(true)
+        expect(@client.respond_to?('delete_wl_link')).to eq(true)
+        expect(@client.respond_to?('get_default_wl_link')).to eq(true)
+        expect(@client.respond_to?('validate_wl_link')).to eq(true)
+        expect(@client.respond_to?('get_associated_wl_link')).to eq(true)
+        expect(@client.respond_to?('disassociate_wl_link')).to eq(true)
+        expect(@client.respond_to?('associate_wl_link')).to eq(true)
       end
     end
 
     describe 'VERSION' do
       it 'returns VERSION value' do
-        expect(SendGrid4r::VERSION).to eq('0.5.0')
+        expect(SendGrid4r::VERSION).to eq('1.0.0')
       end
     end
   end

data/spec/rest/api_keys/api_keys_spec.rb

@@ -14,14 +14,20 @@ describe SendGrid4r::REST::ApiKeys do
         # celan up test env(lists)
         api_keys = @client.get_api_keys
         api_keys.result.each do |api_key|
-          @client.delete_api_key(api_key.api_key_id) if api_key.name == @name1
-          @client.delete_api_key(api_key.api_key_id) if api_key.name == @name2
-          @client.delete_api_key(api_key.api_key_id) if api_key.name == @name1e
+          @client.delete_api_key(
+            api_key_id: api_key.api_key_id
+          ) if api_key.name == @name1
+          @client.delete_api_key(
+            api_key_id: api_key.api_key_id
+          ) if api_key.name == @name2
+          @client.delete_api_key(
+            api_key_id: api_key.api_key_id
+          ) if api_key.name == @name1e
         end
 
         # post api_key
-        @api_key1 = @client.post_api_key(@name1)
-      rescue => e
+        @api_key1 = @client.post_api_key(name: @name1)
+      rescue RestClient::ExceptionWithResponse => e
         puts e.inspect
         raise e
       end
@@ -33,7 +39,7 @@ describe SendGrid4r::REST::ApiKeys do
           api_keys = @client.get_api_keys
           expect(api_keys).to be_a(SendGrid4r::REST::ApiKeys::ApiKeys)
           expect(api_keys.result).to be_a(Array)
-        rescue => e
+        rescue RestClient::ExceptionWithResponse => e
           puts e.inspect
           raise e
         end
@@ -41,13 +47,13 @@ describe SendGrid4r::REST::ApiKeys do
 
       it '#post_api_key' do
         begin
-          api_key2 = @client.post_api_key(@name2)
+          api_key2 = @client.post_api_key(name: @name2)
           expect(api_key2).to be_a(SendGrid4r::REST::ApiKeys::ApiKey)
           expect(api_key2.name).to eq(@name2)
           expect(api_key2.api_key_id).to be_a(String)
           expect(api_key2.api_key).to be_a(String)
           expect(api_key2.scope_set_id).to be_a(String)
-        rescue => e
+        rescue RestClient::ExceptionWithResponse => e
           puts e.inspect
           raise e
         end
@@ -55,8 +61,8 @@ describe SendGrid4r::REST::ApiKeys do
 
       it '#delete_api_key' do
         begin
-          @client.delete_api_key(@api_key1.api_key_id)
-        rescue => e
+          @client.delete_api_key(api_key_id: @api_key1.api_key_id)
+        rescue RestClient::ExceptionWithResponse => e
           puts e.inspect
           raise e
         end
@@ -64,55 +70,17 @@ describe SendGrid4r::REST::ApiKeys do
 
       it '#patch_api_key' do
         begin
-          edit_api_key = @client.patch_api_key(@api_key1.api_key_id, @name1e)
+          edit_api_key = @client.patch_api_key(
+            api_key_id: @api_key1.api_key_id, name: @name1e
+          )
           expect(edit_api_key.api_key_id).to eq(@api_key1.api_key_id)
           expect(edit_api_key.name).to eq(@name1e)
-        rescue => e
+        rescue RestClient::ExceptionWithResponse => e
           puts e.inspect
           raise e
         end
       end
     end
-
-    context 'with block call' do
-      it '#get_api_keys' do
-        @client.get_api_keys do |resp, req, res|
-          resp =
-            SendGrid4r::REST::ApiKeys.create_api_keys(JSON.parse(resp))
-          expect(resp).to be_a(SendGrid4r::REST::ApiKeys::ApiKeys)
-          expect(req).to be_a(RestClient::Request)
-          expect(res).to be_a(Net::HTTPOK)
-        end
-      end
-
-      it '#post_api_key' do
-        @client.post_api_key(@name2) do |resp, req, res|
-          resp =
-            SendGrid4r::REST::ApiKeys.create_api_key(JSON.parse(resp))
-          expect(resp).to be_a(SendGrid4r::REST::ApiKeys::ApiKey)
-          expect(req).to be_a(RestClient::Request)
-          expect(res).to be_a(Net::HTTPCreated)
-        end
-      end
-
-      it '#delete_api_key' do
-        @client.delete_api_key(@api_key1.api_key_id) do |resp, req, res|
-          expect(resp).to eq('')
-          expect(req).to be_a(RestClient::Request)
-          expect(res).to be_a(Net::HTTPNoContent)
-        end
-      end
-
-      it '#patch_api_key' do
-        @client.patch_api_key(@api_key1.api_key_id, @name1e) do |resp, req, res|
-          resp =
-            SendGrid4r::REST::ApiKeys.create_api_key(JSON.parse(resp))
-          expect(resp).to be_a(SendGrid4r::REST::ApiKeys::ApiKey)
-          expect(req).to be_a(RestClient::Request)
-          expect(res).to be_a(Net::HTTPOK)
-        end
-      end
-    end
   end
 
   describe 'unit test', :ut do
@@ -150,19 +118,19 @@ describe SendGrid4r::REST::ApiKeys do
 
     it '#post_api_key' do
       allow(client).to receive(:execute).and_return(api_key)
-      actual = client.post_api_key('')
+      actual = client.post_api_key(name: '')
       expect(actual).to be_a(SendGrid4r::REST::ApiKeys::ApiKey)
     end
 
     it '#delete_api_key' do
       allow(client).to receive(:execute).and_return('')
-      actual = client.delete_api_key('')
+      actual = client.delete_api_key(api_key_id: '')
       expect(actual).to eq('')
     end
 
     it '#patch_api_key' do
       allow(client).to receive(:execute).and_return(api_key)
-      actual = client.patch_api_key('', '')
+      actual = client.patch_api_key(api_key_id: '', name: '')
       expect(actual).to be_a(SendGrid4r::REST::ApiKeys::ApiKey)
     end
 

data/spec/rest/asm/global_suppressions_spec.rb

@@ -6,26 +6,33 @@ describe SendGrid4r::REST::Asm::GlobalSuppressions do
     before do
       begin
         Dotenv.load
-        @client = SendGrid4r::Client.new(
-          username: ENV['SENDGRID_USERNAME'],
-          password: ENV['SENDGRID_PASSWORD'])
+        @client = SendGrid4r::Client.new(api_key: ENV['API_KEY'])
         @email1 = 'test1@test.com'
         @email2 = 'test2@test.com'
         @email3 = 'test3@test.com'
 
-        actual_email1 = @client.get_global_suppressed_email(@email1)
-        actual_email2 = @client.get_global_suppressed_email(@email2)
-        actual_email3 = @client.get_global_suppressed_email(@email3)
+        actual_email1 = @client.get_global_suppressed_email(
+          email_address: @email1
+        )
+        actual_email2 = @client.get_global_suppressed_email(
+          email_address: @email2
+        )
+        actual_email3 = @client.get_global_suppressed_email(
+          email_address: @email3
+        )
         @client.delete_global_suppressed_email(
-          @email1
+          email_address: @email1
         ) if actual_email1 == @email1
         @client.delete_global_suppressed_email(
-          @email2
+          email_address: @email2
         ) if actual_email2 == @email2
         @client.delete_global_suppressed_email(
-          @email3
+          email_address: @email3
         ) if actual_email3 == @email3
-      rescue => e
+        @client.post_global_suppressed_emails(
+          recipient_emails: [@email1]
+        )
+      rescue RestClient::ExceptionWithResponse => e
         puts e.inspect
         raise e
       end
@@ -35,13 +42,12 @@ describe SendGrid4r::REST::Asm::GlobalSuppressions do
       it '#post_global_suppressed_emails' do
         begin
           emails = @client.post_global_suppressed_emails(
-            [@email1, @email2, @email3]
+            recipient_emails: [@email2, @email3]
           )
-          expect(emails.recipient_emails.length).to eq(3)
-          expect(emails.recipient_emails.include? @email1).to eq(true)
+          expect(emails.recipient_emails.length).to eq(2)
           expect(emails.recipient_emails.include? @email2).to eq(true)
           expect(emails.recipient_emails.include? @email3).to eq(true)
-        rescue => e
+        rescue RestClient::ExceptionWithResponse => e
           puts e.inspect
           raise e
         end
@@ -49,15 +55,15 @@ describe SendGrid4r::REST::Asm::GlobalSuppressions do
 
       it '#get_global_suppressed_email' do
         begin
-          actual_email1 = @client.get_global_suppressed_email(@email1)
-          actual_email2 = @client.get_global_suppressed_email(@email2)
-          actual_email3 = @client.get_global_suppressed_email(@email3)
-          actual_notexist = @client.get_global_suppressed_email('notexist')
+          actual_email1 = @client.get_global_suppressed_email(
+            email_address: @email1
+          )
+          actual_notexist = @client.get_global_suppressed_email(
+            email_address: 'notexist'
+          )
           expect(actual_email1.recipient_email).to eq(@email1)
-          expect(actual_email2.recipient_email).to eq(@email2)
-          expect(actual_email3.recipient_email).to eq(@email3)
           expect(actual_notexist.recipient_email).to eq(nil)
-        rescue => e
+        rescue RestClient::ExceptionWithResponse => e
           puts e.inspect
           raise e
         end
@@ -65,55 +71,21 @@ describe SendGrid4r::REST::Asm::GlobalSuppressions do
 
       it '#delete_global_suppressed_email' do
         begin
-          expect(@client.delete_global_suppressed_email(@email1)).to eq('')
-          expect(@client.delete_global_suppressed_email(@email2)).to eq('')
-          expect(@client.delete_global_suppressed_email(@email3)).to eq('')
-        rescue => e
+          expect(
+            @client.delete_global_suppressed_email(email_address: @email1)
+          ).to eq('')
+          expect(
+            @client.delete_global_suppressed_email(email_address: @email2)
+          ).to eq('')
+          expect(
+            @client.delete_global_suppressed_email(email_address: @email3)
+          ).to eq('')
+        rescue RestClient::ExceptionWithResponse => e
           puts e.inspect
           raise e
         end
       end
     end
-
-    context 'with block call' do
-      it '#post_global_suppressed_emails' do
-        @client.post_global_suppressed_emails(
-          [@email1, @email2, @email3]
-        ) do |resp, req, res|
-          resp =
-            SendGrid4r::REST::Asm.create_recipient_emails(
-              JSON.parse(resp)
-            )
-          expect(resp).to be_a(
-            SendGrid4r::REST::Asm::RecipientEmails
-          )
-          expect(req).to be_a(RestClient::Request)
-          expect(res).to be_a(Net::HTTPCreated)
-        end
-      end
-
-      it '#get_global_suppressed_email' do
-        @client.get_global_suppressed_email(@email1) do |resp, req, res|
-          resp =
-            SendGrid4r::REST::Asm.create_recipient_email(
-              JSON.parse(resp)
-            )
-          expect(resp).to be_a(
-            SendGrid4r::REST::Asm::RecipientEmail
-          )
-          expect(req).to be_a(RestClient::Request)
-          expect(res).to be_a(Net::HTTPOK)
-        end
-      end
-
-      it '#delete_global_suppressed_email' do
-        @client.delete_global_suppressed_email(@email1) do |resp, req, res|
-          expect(resp).to eq('')
-          expect(req).to be_a(RestClient::Request)
-          expect(res).to be_a(Net::HTTPNoContent)
-        end
-      end
-    end
   end
 
   describe 'unit test', :ut do
@@ -142,19 +114,19 @@ describe SendGrid4r::REST::Asm::GlobalSuppressions do
 
     it '#post_global_suppressed_emails' do
       allow(client).to receive(:execute).and_return(recipient_emails)
-      emails = client.post_global_suppressed_emails([])
+      emails = client.post_global_suppressed_emails(recipient_emails: [])
       expect(emails).to be_a(SendGrid4r::REST::Asm::RecipientEmails)
     end
 
     it '#get_global_suppressed_email' do
       allow(client).to receive(:execute).and_return(recipient_email)
-      actual = client.get_global_suppressed_email('')
+      actual = client.get_global_suppressed_email(email_address: '')
       expect(actual).to be_a(SendGrid4r::REST::Asm::RecipientEmail)
     end
 
     it '#delete_global_suppressed_email' do
       allow(client).to receive(:execute).and_return('')
-      actual = client.delete_global_suppressed_email('')
+      actual = client.delete_global_suppressed_email(email_address: '')
       expect(actual).to eq('')
     end
   end

data/spec/rest/asm/groups_spec.rb

@@ -6,9 +6,7 @@ describe SendGrid4r::REST::Asm::Groups do
     before do
       begin
         Dotenv.load
-        @client = SendGrid4r::Client.new(
-          username: ENV['SENDGRID_USERNAME'],
-          password: ENV['SENDGRID_PASSWORD'])
+        @client = SendGrid4r::Client.new(api_key: ENV['API_KEY'])
         @group_name1 = 'group_test1'
         @group_name2 = 'group_test2'
         @group_name_edit1 = 'group_edit1'
@@ -18,13 +16,21 @@ describe SendGrid4r::REST::Asm::Groups do
         # celan up test env
         grps = @client.get_groups
         grps.each do |grp|
-          @client.delete_group(grp.id) if grp.name == @group_name1
-          @client.delete_group(grp.id) if grp.name == @group_name_edit1
-          @client.delete_group(grp.id) if grp.name == @group_name2
+          @client.delete_group(
+            group_id: grp.id
+          ) if grp.name == @group_name1
+          @client.delete_group(
+            group_id: grp.id
+          ) if grp.name == @group_name_edit1
+          @client.delete_group(
+            group_id: grp.id
+          ) if grp.name == @group_name2
         end
         # post a group
-        @group1 = @client.post_group(@group_name1, @group_desc)
-      rescue => e
+        @group1 = @client.post_group(
+          name: @group_name1, description: @group_desc
+        )
+      rescue RestClient::ExceptionWithResponse => e
         puts e.inspect
         raise e
       end
@@ -33,10 +39,12 @@ describe SendGrid4r::REST::Asm::Groups do
     context 'without block call' do
       it '#post_group' do
         begin
-          group2 = @client.post_group(@group_name2, @group_desc)
+          group2 = @client.post_group(
+            name: @group_name2, description: @group_desc
+          )
           expect(@group_name2).to eq(group2.name)
           expect(@group_desc).to eq(group2.description)
-        rescue => e
+        rescue RestClient::ExceptionWithResponse => e
           puts e.inspect
           raise e
         end
@@ -46,13 +54,15 @@ describe SendGrid4r::REST::Asm::Groups do
         begin
           @group1.name = @group_name_edit1
           @group1.description = @group_desc_edit
-          group_edit1 = @client.patch_group(@group1.id, @group1)
+          group_edit1 = @client.patch_group(
+            group_id: @group1.id, group: @group1
+          )
           expect(group_edit1.id).to be_a(Fixnum)
           expect(group_edit1.name).to eq(@group_name_edit1)
           expect(group_edit1.description).to eq(@group_desc_edit)
           expect(group_edit1.last_email_sent_at).to eq(nil)
           expect(group_edit1.unsubscribes).to eq(nil)
-        rescue => e
+        rescue RestClient::ExceptionWithResponse => e
           puts e.inspect
           raise e
         end
@@ -65,7 +75,7 @@ describe SendGrid4r::REST::Asm::Groups do
           groups.each do |group|
             expect(group).to be_a(SendGrid4r::REST::Asm::Groups::Group)
           end
-        rescue => e
+        rescue RestClient::ExceptionWithResponse => e
           puts e.inspect
           raise e
         end
@@ -73,13 +83,13 @@ describe SendGrid4r::REST::Asm::Groups do
 
       it '#get_group' do
         begin
-          group = @client.get_group(@group1.id)
+          group = @client.get_group(group_id: @group1.id)
           expect(group.id).to be_a(Fixnum)
           expect(group.name).to eq(@group_name1)
           expect(group.description).to eq(@group_desc)
           expect(group.last_email_sent_at).to eq(nil)
           expect(group.unsubscribes).to eq(0)
-        rescue => e
+        rescue RestClient::ExceptionWithResponse => e
           puts e.inspect
           raise e
         end
@@ -87,74 +97,13 @@ describe SendGrid4r::REST::Asm::Groups do
 
       it '#delete_group' do
         begin
-          @client.delete_group(@group1.id)
-        rescue => e
+          @client.delete_group(group_id: @group1.id)
+        rescue RestClient::ExceptionWithResponse => e
           puts e.inspect
           raise e
         end
       end
     end
-
-    context 'with block call' do
-      it '#post_group' do
-        @client.post_group(@group_name2, @group_desc) do |resp, req, res|
-          resp =
-            SendGrid4r::REST::Asm::Groups.create_group(
-              JSON.parse(resp)
-            )
-          expect(resp).to be_a(SendGrid4r::REST::Asm::Groups::Group)
-          expect(req).to be_a(RestClient::Request)
-          expect(res).to be_a(Net::HTTPCreated)
-        end
-      end
-
-      it '#patch_group' do
-        @client.patch_group(@group1.id, @group1) do |resp, req, res|
-          resp =
-            SendGrid4r::REST::Asm::Groups.create_group(
-              JSON.parse(resp)
-            )
-          expect(resp).to be_a(SendGrid4r::REST::Asm::Groups::Group)
-          expect(req).to be_a(RestClient::Request)
-          expect(res).to be_a(Net::HTTPOK)
-        end
-      end
-
-      it '#get_groups' do
-        @client.get_groups do |resp, req, res|
-          resp =
-            SendGrid4r::REST::Asm::Groups.create_groups(
-              JSON.parse(resp)
-            )
-          expect(resp).to be_a(Array)
-          resp.each do |group|
-            expect(group).to be_a(SendGrid4r::REST::Asm::Groups::Group)
-          end
-          expect(req).to be_a(RestClient::Request)
-          expect(res).to be_a(Net::HTTPOK)
-        end
-      end
-
-      it '#get_group' do
-        @client.get_group(@group1.id) do |resp, req, res|
-          resp =
-            SendGrid4r::REST::Asm::Groups.create_group(
-              JSON.parse(resp)
-            )
-          expect(resp).to be_a(SendGrid4r::REST::Asm::Groups::Group)
-          expect(req).to be_a(RestClient::Request)
-          expect(res).to be_a(Net::HTTPOK)
-        end
-      end
-
-      it '#delete_group' do
-        @client.delete_group(@group1.id) do |resp, req, res|
-          expect(resp).to eq('')
-          expect(req).to be_a(RestClient::Request)
-          expect(res).to be_a(Net::HTTPNoContent)
-        end
-      end
-    end
   end
 
   describe 'unit test', :ut do
@@ -197,13 +146,13 @@ describe SendGrid4r::REST::Asm::Groups do
 
     it '#post_group' do
       allow(client).to receive(:execute).and_return(group)
-      actual = client.post_group('', '')
+      actual = client.post_group(name: '', description: '')
       expect(actual).to be_a(SendGrid4r::REST::Asm::Groups::Group)
     end
 
     it '#patch_group' do
       allow(client).to receive(:execute).and_return(group)
-      actual = client.patch_group(0, nil)
+      actual = client.patch_group(group_id: 0, group: nil)
       expect(actual).to be_a(SendGrid4r::REST::Asm::Groups::Group)
     end
 
@@ -218,13 +167,13 @@ describe SendGrid4r::REST::Asm::Groups do
 
     it '#get_group' do
       allow(client).to receive(:execute).and_return(group)
-      actual = client.get_group(0)
+      actual = client.get_group(group_id: 0)
       expect(actual).to be_a(SendGrid4r::REST::Asm::Groups::Group)
     end
 
     it '#delete_group' do
       allow(client).to receive(:execute).and_return('')
-      actual = client.delete_group(0)
+      actual = client.delete_group(group_id: 0)
       expect(actual).to eq('')
     end