semantic_logger 4.2.0 → 4.2.1

data/test/appender/graylog_test.rb

@@ -9,11 +9,11 @@ module Appender
         @message  = 'AppenderGraylogTest log message'
       end
 
-      (SemanticLogger::LEVELS - [:info, :warn, :error, :fatal]).each do |level|
+      (SemanticLogger::LEVELS - %i[info warn error fatal]).each do |level|
         it "not send :#{level} notifications to Graylog" do
           hash = nil
-          @appender.notifier.stub(:notify!, -> h { hash = h }) do
-            @appender.send(level, "AppenderGraylogTest #{level.to_s} message")
+          @appender.notifier.stub(:notify!, ->(h) { hash = h }) do
+            @appender.send(level, "AppenderGraylogTest #{level} message")
           end
           assert_nil hash
         end
@@ -27,7 +27,7 @@ module Appender
         rescue Exception => e
           exc = e
         end
-        @appender.notifier.stub(:notify!, -> h { hash = h }) do
+        @appender.notifier.stub(:notify!, ->(h) { hash = h }) do
           @appender.error 'Reading File', exc
         end
         assert_equal 'Reading File', hash[:short_message]
@@ -45,7 +45,7 @@ module Appender
         rescue Exception => e
           exc = e
         end
-        @appender.notifier.stub(:notify!, -> h { hash = h }) do
+        @appender.notifier.stub(:notify!, ->(h) { hash = h }) do
           @appender.error exc
         end
         assert_equal exc.message, hash[:short_message]
@@ -57,7 +57,7 @@ module Appender
 
       it 'send error notifications to Graylog with severity' do
         hash = nil
-        @appender.notifier.stub(:notify!, -> h { hash = h }) do
+        @appender.notifier.stub(:notify!, ->(h) { hash = h }) do
           @appender.error @message
         end
         assert_equal @message, hash[:short_message]
@@ -67,8 +67,8 @@ module Appender
 
       it 'send notification to Graylog with custom attributes' do
         hash = nil
-        @appender.notifier.stub(:notify!, -> h { hash = h }) do
-          @appender.error @message, {key1: 1, key2: 'a'}
+        @appender.notifier.stub(:notify!, ->(h) { hash = h }) do
+          @appender.error @message, key1: 1, key2: 'a'
         end
         assert_equal @message, hash[:short_message]
         assert_equal 3, hash[:level]

data/test/appender/honeybadger_test.rb

@@ -13,25 +13,25 @@ module Appender
       SemanticLogger::LEVELS.each do |level|
         it "sends #{level} message" do
           hash = nil
-          Honeybadger.stub(:notify, -> h { hash = h }) do
+          Honeybadger.stub(:notify, ->(h) { hash = h }) do
             @appender.send(level, @message)
           end
           assert_equal @message, hash[:error_message]
           assert_equal 'SemanticLogger::Appender::Honeybadger', hash[:error_class]
 
-          if [:error, :fatal].include?(level)
-            assert hash.has_key?(:backtrace)
+          if %i[error fatal].include?(level)
+            assert hash.key?(:backtrace)
           else
-            refute hash.has_key?(:backtrace)
+            refute hash.key?(:backtrace)
           end
-          assert_equal true, hash.has_key?(:context)
+          assert_equal true, hash.key?(:context)
           assert_equal level, hash[:context][:level]
         end
 
         it "sends #{level} exceptions" do
           error     = RuntimeError.new('Oh no, Error.')
           exception = hash = nil
-          Honeybadger.stub(:notify, -> exc, h { exception = exc; hash = h }) do
+          Honeybadger.stub(:notify, ->(exc, h) { exception = exc; hash = h }) do
             @appender.send(level, @message, error)
           end
 
@@ -40,7 +40,6 @@ module Appender
           assert_equal @message, hash[:message], hash
         end
       end
-
     end
   end
 end

data/test/appender/http_test.rb

@@ -16,7 +16,7 @@ module Appender
       SemanticLogger::LEVELS.each do |level|
         it "send #{level}" do
           request = nil
-          @appender.http.stub(:request, -> r { request = r; response_mock.new('200', 'ok') }) do
+          @appender.http.stub(:request, ->(r) { request = r; response_mock.new('200', 'ok') }) do
             @appender.send(level, @message)
           end
           hash = JSON.parse(request.body)
@@ -33,7 +33,7 @@ module Appender
             exc = e
           end
           request = nil
-          @appender.http.stub(:request, -> r { request = r; response_mock.new('200', 'ok') }) do
+          @appender.http.stub(:request, ->(r) { request = r; response_mock.new('200', 'ok') }) do
             @appender.send(level, 'Reading File', exc)
           end
           hash = JSON.parse(request.body)
@@ -46,8 +46,8 @@ module Appender
 
         it "send #{level} custom attributes" do
           request = nil
-          @appender.http.stub(:request, -> r { request = r; response_mock.new('200', 'ok') }) do
-            @appender.send(level, @message, {key1: 1, key2: 'a'})
+          @appender.http.stub(:request, ->(r) { request = r; response_mock.new('200', 'ok') }) do
+            @appender.send(level, @message, key1: 1, key2: 'a')
           end
           hash = JSON.parse(request.body)
           assert_equal @message, hash['message']
@@ -57,7 +57,6 @@ module Appender
           assert_equal 1, payload['key1'], payload
           assert_equal 'a', payload['key2'], payload
         end
-
       end
     end
   end

data/test/appender/kafka_test.rb

@@ -5,19 +5,19 @@ module Appender
     describe SemanticLogger::Appender::Kafka do
       before do
         @appender = SemanticLogger::Appender::Kafka.new(
-          seed_brokers: ['http://localhost:9092']
+          seed_brokers: ['localhost:9092']
         )
         @message  = 'AppenderKafkaTest log message'
       end
 
       after do
-        @appender.close if @appender
+        @appender&.close
       end
 
       it 'sends log messages in JSON format' do
         message = nil
         options = nil
-        ::Kafka::Producer.stub_any_instance(:produce, -> value, **opts { message = value; options = opts }) do
+        ::Kafka::Producer.stub_any_instance(:produce, ->(value, **opts) { message = value; options = opts }) do
           @appender.info(@message)
           @appender.flush
         end
@@ -25,12 +25,11 @@ module Appender
         h = JSON.parse(message)
         assert_equal 'info', h['level']
         assert_equal @message, h['message']
-        assert_equal "SemanticLogger::Appender::Kafka", h['name']
-        assert_equal $$, h['pid']
+        assert_equal 'SemanticLogger::Appender::Kafka', h['name']
+        assert_equal $PROCESS_ID, h['pid']
 
         assert_equal 'log_messages', options[:topic]
       end
-
     end
   end
 end

data/test/appender/mongodb_test.rb

@@ -7,17 +7,17 @@ module Appender
       before do
         @appender           = SemanticLogger::Appender::MongoDB.new(
           uri:             'mongodb://127.0.0.1:27017/test',
-          collection_size: 10*1024**2, # 10MB
+          collection_size: 10 * 1024 ** 2, # 10MB
           host:        'test',
           application: 'test_application',
           level:       :trace
         )
-        @hash               = {tracking_number: 12345, session_id: 'HSSKLEU@JDK767'}
+        @hash               = {tracking_number: 12_345, session_id: 'HSSKLEU@JDK767'}
         Thread.current.name = 'thread'
       end
 
       after do
-        @appender.purge_all if @appender
+        @appender&.purge_all
       end
 
       describe 'format logs into documents' do
@@ -29,7 +29,7 @@ module Appender
           assert_equal 'thread', document['thread']
           assert document['time'].is_a?(Time)
           assert_nil document['payload']
-          assert_equal $$, document['pid']
+          assert_equal $PROCESS_ID, document['pid']
           assert_equal 'test', document['host']
           assert_equal 'test_application', document['application']
         end
@@ -43,9 +43,9 @@ module Appender
           assert_equal 'thread', document['thread']
           assert document['time'].is_a?(Time)
           assert payload = document['payload']
-          assert_equal 12345, payload['tracking_number'], payload
+          assert_equal 12_345, payload['tracking_number'], payload
           assert_equal 'HSSKLEU@JDK767', payload['session_id']
-          assert_equal $$, document['pid']
+          assert_equal $PROCESS_ID, document['pid']
           assert_equal 'test', document['host']
           assert_equal 'test_application', document['application']
         end
@@ -59,9 +59,9 @@ module Appender
           assert_equal 'thread', document['thread']
           assert document['time'].is_a?(Time)
           assert payload = document['payload']
-          assert_equal 12345, payload['tracking_number'], payload
+          assert_equal 12_345, payload['tracking_number'], payload
           assert_equal 'HSSKLEU@JDK767', payload['session_id']
-          assert_equal $$, document['pid']
+          assert_equal $PROCESS_ID, document['pid']
           assert_equal 'test', document['host']
           assert_equal 'test_application', document['application']
         end
@@ -74,7 +74,7 @@ module Appender
           assert_equal 'hello world', document['message']
           assert_equal 'thread', document['thread']
           assert document['time'].is_a?(Time)
-          assert_equal $$, document['pid']
+          assert_equal $PROCESS_ID, document['pid']
           assert_equal 'test', document['host']
           assert_equal 'test_application', document['application']
         end
@@ -91,16 +91,14 @@ module Appender
             assert_equal 'thread', document['thread']
             assert document['time'].is_a?(Time)
             assert payload = document['payload']
-            assert_equal 12345, payload['tracking_number'], payload
+            assert_equal 12_345, payload['tracking_number'], payload
             assert_equal 'HSSKLEU@JDK767', payload['session_id']
-            assert_equal $$, document['pid']
+            assert_equal $PROCESS_ID, document['pid']
             assert_equal 'test', document['host'], document.ai
             assert_equal 'test_application', document['application']
           end
         end
-
       end
-
     end
   end
 end

data/test/appender/new_relic_test.rb

@@ -6,18 +6,17 @@ require_relative '../test_helper'
 module Appender
   class NewRelicTest < Minitest::Test
     describe SemanticLogger::Appender::NewRelic do
-
       before do
         @appender = SemanticLogger::Appender::NewRelic.new
         @message  = 'AppenderNewRelicTest log message'
       end
 
-      (SemanticLogger::LEVELS - [:error, :fatal]).each do |level|
-        it "does not send :#{level.to_s} notifications to New Relic" do
+      (SemanticLogger::LEVELS - %i[error fatal]).each do |level|
+        it "does not send :#{level} notifications to New Relic" do
           exception = hash = nil
-          NewRelic::Agent.stub(:notice_error, -> exc, h { exception = exc; hash = h }) do
+          NewRelic::Agent.stub(:notice_error, ->(exc, h) { exception = exc; hash = h }) do
             @appender.tagged('test') do
-              @appender.send(level, "AppenderNewRelicTest #{level.to_s} message")
+              @appender.send(level, "AppenderNewRelicTest #{level} message")
             end
           end
           assert_nil exception
@@ -25,10 +24,10 @@ module Appender
         end
       end
 
-      [:error, :fatal].each do |level|
-        it "sends :#{level.to_s} notifications to New Relic" do
+      %i[error fatal].each do |level|
+        it "sends :#{level} notifications to New Relic" do
           exception = hash = nil
-          NewRelic::Agent.stub(:notice_error, -> exc, h { exception = exc; hash = h }) do
+          NewRelic::Agent.stub(:notice_error, ->(exc, h) { exception = exc; hash = h }) do
             @appender.tagged('test') do
               @appender.send(level, @message)
             end
@@ -43,7 +42,7 @@ module Appender
 
       it 'send notification to New Relic with custom attributes' do
         exception = hash = nil
-        NewRelic::Agent.stub(:notice_error, -> exc, h { exception = exc; hash = h }) do
+        NewRelic::Agent.stub(:notice_error, ->(exc, h) { exception = exc; hash = h }) do
           SemanticLogger.tagged('test') do
             SemanticLogger.named_tagged(key1: 1, key2: 'a') do
               @appender.measure_error(message: @message, payload: {key3: 4}) do

data/test/appender/newrelic_rpm.rb

@@ -8,7 +8,7 @@ module NewRelic
     def self.record_metric(name, secoonds)
     end
 
-    def self.increment_metric(name, count=1)
+    def self.increment_metric(name, count = 1)
     end
   end
 end

data/test/appender/sentry_test.rb

@@ -13,36 +13,35 @@ module Appender
       SemanticLogger::LEVELS.each do |level|
         it "sends #{level} message" do
           error_message = hash = nil
-          Raven.stub(:capture_message, -> msg, h { error_message = msg; hash = h }) do
+          Raven.stub(:capture_message, ->(msg, h) { error_message = msg; hash = h }) do
             @appender.send(level, @message)
           end
           assert_equal @message, error_message
           assert_equal 'SemanticLogger::Appender::Sentry', hash[:extra][:name]
 
-          if [:error, :fatal].include?(level)
-            assert hash[:extra].has_key?(:backtrace)
+          if %i[error fatal].include?(level)
+            assert hash[:extra].key?(:backtrace)
           else
-            refute hash[:extra].has_key?(:backtrace)
+            refute hash[:extra].key?(:backtrace)
           end
-          assert_equal true, hash.has_key?(:extra)
+          assert_equal true, hash.key?(:extra)
           assert_equal level, hash[:level]
         end
 
         it "sends #{level} exceptions" do
           error     = RuntimeError.new('Oh no, Error.')
           exception = hash = nil
-          Raven.stub(:capture_exception, -> exc, h { exception = exc; hash = h }) do
+          Raven.stub(:capture_exception, ->(exc, h) { exception = exc; hash = h }) do
             @appender.send(level, @message, error)
           end
 
           assert_equal error.class.to_s, exception.class.to_s
           assert_equal error.message, exception.message
-          assert_equal true, hash.has_key?(:extra)
+          assert_equal true, hash.key?(:extra)
           assert_equal @message, hash[:extra][:message], hash
           assert_equal level, hash[:level]
         end
       end
-
     end
   end
 end

data/test/appender/splunk_http_test.rb

@@ -19,7 +19,7 @@ module Appender
       SemanticLogger::LEVELS.each do |level|
         it "send #{level}" do
           request = nil
-          @appender.http.stub(:request, -> r { request = r; response_mock.new('200', 'ok') }) do
+          @appender.http.stub(:request, ->(r) { request = r; response_mock.new('200', 'ok') }) do
             @appender.send(level, @message)
           end
           body    = decompress_data(request.body)
@@ -37,7 +37,7 @@ module Appender
             exc = e
           end
           request = nil
-          @appender.http.stub(:request, -> r { request = r; response_mock.new('200', 'ok') }) do
+          @appender.http.stub(:request, ->(r) { request = r; response_mock.new('200', 'ok') }) do
             @appender.send(level, 'Reading File', exc)
           end
           body = decompress_data(request.body)
@@ -52,8 +52,8 @@ module Appender
 
         it "sends #{level} custom attributes" do
           request = nil
-          @appender.http.stub(:request, -> r { request = r; response_mock.new('200', 'ok') }) do
-            @appender.send(level, @message, {key1: 1, key2: 'a'})
+          @appender.http.stub(:request, ->(r) { request = r; response_mock.new('200', 'ok') }) do
+            @appender.send(level, @message, key1: 1, key2: 'a')
           end
           body    = decompress_data(request.body)
           message = JSON.parse(body)

data/test/appender/splunk_test.rb

@@ -4,7 +4,6 @@ require_relative '../test_helper'
 #
 module Appender
   class SplunkTest < Minitest::Test
-
     class Mock
       attr_accessor :message, :event
 
@@ -57,7 +56,7 @@ module Appender
         it "sends #{level} custom attributes" do
           mock = Mock.new
           @appender.stub(:service_index, mock) do
-            @appender.send(level, @message, {key1: 1, key2: 'a'})
+            @appender.send(level, @message, key1: 1, key2: 'a')
           end
           assert_equal @message, mock.message
 
@@ -80,6 +79,5 @@ module Appender
         assert_nil mock.message
       end
     end
-
   end
 end

data/test/appender/syslog_test.rb

@@ -6,11 +6,10 @@ require 'net/tcp_client'
 module Appender
   class SyslogTest < Minitest::Test
     describe SemanticLogger::Appender::Syslog do
-
       it 'handle local syslog' do
         message = nil
         Syslog.stub(:open, nil) do
-          Syslog.stub(:log, -> level, msg { message = msg }) do
+          Syslog.stub(:log, ->(_level, msg) { message = msg }) do
             syslog_appender = SemanticLogger::Appender::Syslog.new(level: :debug)
             syslog_appender.debug 'AppenderSyslogTest log message'
           end
@@ -23,7 +22,7 @@ module Appender
         Net::TCPClient.stub_any_instance(:closed?, false) do
           Net::TCPClient.stub_any_instance(:connect, nil) do
             syslog_appender = SemanticLogger::Appender::Syslog.new(url: 'tcp://localhost:88888', level: :debug)
-            syslog_appender.remote_syslog.stub(:write, Proc.new { |data| message = data }) do
+            syslog_appender.remote_syslog.stub(:write, proc { |data| message = data }) do
               syslog_appender.debug 'AppenderSyslogTest log message'
             end
           end
@@ -34,7 +33,7 @@ module Appender
       it 'handle remote syslog over UDP' do
         message         = nil
         syslog_appender = SemanticLogger::Appender::Syslog.new(url: 'udp://localhost:88888', level: :debug)
-        UDPSocket.stub_any_instance(:send, -> msg, num, host, port { message = msg }) do
+        UDPSocket.stub_any_instance(:send, ->(msg, _num, _host, _port) { message = msg }) do
           syslog_appender.debug 'AppenderSyslogTest log message'
         end
         assert_match(/<70>(.*?)SemanticLogger::Appender::Syslog -- AppenderSyslogTest log message/, message)
@@ -57,7 +56,6 @@ module Appender
         syslog_appender = SemanticLogger::Appender::Syslog.new
         syslog_appender.debug(message)
       end
-
     end
   end
 end

data/test/appender/tcp_test.rb

@@ -19,7 +19,7 @@ module Appender
       SemanticLogger::LEVELS.each do |level|
         it "send #{level}" do
           data = nil
-          @appender.tcp_client.stub(:write, -> d { data = d }) do
+          @appender.tcp_client.stub(:write, ->(d) { data = d }) do
             @appender.send(level, @message)
           end
           hash = JSON.parse(data)
@@ -36,7 +36,7 @@ module Appender
             exc = e
           end
           data = nil
-          @appender.tcp_client.stub(:write, -> d { data = d }) do
+          @appender.tcp_client.stub(:write, ->(d) { data = d }) do
             @appender.send(level, 'Reading File', exc)
           end
           hash = JSON.parse(data)
@@ -49,8 +49,8 @@ module Appender
 
         it "send #{level} custom attributes" do
           data = nil
-          @appender.tcp_client.stub(:write, -> d { data = d }) do
-            @appender.send(level, @message, {key1: 1, key2: 'a'})
+          @appender.tcp_client.stub(:write, ->(d) { data = d }) do
+            @appender.send(level, @message, key1: 1, key2: 'a')
           end
           hash = JSON.parse(data)
           assert_equal @message, hash['message']
@@ -60,7 +60,6 @@ module Appender
           assert_equal 1, payload['key1'], payload
           assert_equal 'a', payload['key2'], payload
         end
-
       end
     end
   end