semantic_logger 4.2.0 → 4.2.1

data/test/appender/udp_test.rb

@@ -12,7 +12,7 @@ module Appender
       SemanticLogger::LEVELS.each do |level|
         it "send #{level}" do
           data = nil
-          @appender.socket.stub(:send, -> d, flags { data = d }) do
+          @appender.socket.stub(:send, ->(d, _flags) { data = d }) do
             @appender.send(level, @message)
           end
           hash = JSON.parse(data)
@@ -29,7 +29,7 @@ module Appender
             exc = e
           end
           data = nil
-          @appender.socket.stub(:send, -> d, flags { data = d }) do
+          @appender.socket.stub(:send, ->(d, _flags) { data = d }) do
             @appender.send(level, 'Reading File', exc)
           end
           hash = JSON.parse(data)
@@ -42,8 +42,8 @@ module Appender
 
         it "send #{level} custom attributes" do
           data = nil
-          @appender.socket.stub(:send, -> d, flags { data = d }) do
-            @appender.send(level, @message, {key1: 1, key2: 'a'})
+          @appender.socket.stub(:send, ->(d, _flags) { data = d }) do
+            @appender.send(level, @message, key1: 1, key2: 'a')
           end
           hash = JSON.parse(data)
           assert_equal @message, hash['message']
@@ -53,7 +53,6 @@ module Appender
           assert_equal 1, payload['key1'], payload
           assert_equal 'a', payload['key2'], payload
         end
-
       end
     end
   end

data/test/appender/wrapper_test.rb

@@ -41,8 +41,8 @@ module Appender
         @time              = Time.new
         @mock_logger       = MockLogger.new
         @appender          = SemanticLogger::Appender::Wrapper.new(logger: @mock_logger)
-        @hash              = {session_id: 'HSSKLEU@JDK767', tracking_number: 12345}
-        @hash_str          = @hash.inspect.sub("{", "\\{").sub("}", "\\}")
+        @hash              = {session_id: 'HSSKLEU@JDK767', tracking_number: 12_345}
+        @hash_str          = @hash.inspect.sub('{', '\\{').sub('}', '\\}')
         @thread_name       = Thread.current.name
         @file_name_reg_exp = ' wrapper_test.rb:\d+'
       end
@@ -90,7 +90,6 @@ module Appender
           end
         end
       end
-
     end
   end
 end

data/test/concerns/compatibility_test.rb

@@ -113,6 +113,5 @@ class TestLogger < Minitest::Test
       assert_equal 'hello world', log.message
       assert_equal :info, log.level
     end
-
   end
 end

data/test/debug_as_trace_logger_test.rb

@@ -77,6 +77,5 @@ class DebugAsTraceLoggerTest < Minitest::Test
         assert_equal :trace, log.level
       end
     end
-
   end
 end

data/test/formatters/color_test.rb

@@ -70,7 +70,7 @@ module SemanticLogger
 
         describe 'tags' do
           it 'logs tags' do
-            log.tags = %w(first second third)
+            log.tags = %w[first second third]
             assert_equal "[#{color}first#{clear}] [#{color}second#{clear}] [#{color}third#{clear}]", formatter.tags
           end
         end
@@ -131,23 +131,22 @@ module SemanticLogger
 
         describe 'call' do
           it 'returns minimal elements' do
-            assert_equal "#{expected_time} #{color}D#{clear} [#{$$}:#{Thread.current.name}] #{color}ColorTest#{clear}", formatter.call(log, nil)
+            assert_equal "#{expected_time} #{color}D#{clear} [#{$PROCESS_ID}:#{Thread.current.name}] #{color}ColorTest#{clear}", formatter.call(log, nil)
           end
 
           it 'retuns all elements' do
-            log.tags       = %w(first second third)
+            log.tags       = %w[first second third]
             log.named_tags = {first: 1, second: 2, third: 3}
             log.duration   = 1.34567
-            log.message    = "Hello World"
+            log.message    = 'Hello World'
             log.payload    = {first: 1, second: 2, third: 3}
             log.backtrace  = backtrace
             set_exception
             duration = SemanticLogger::Formatters::Base::PRECISION == 3 ? '1' : '1.346'
-            str      = "#{expected_time} #{color}D#{clear} [#{$$}:#{Thread.current.name} default_test.rb:35] [#{color}first#{clear}] [#{color}second#{clear}] [#{color}third#{clear}] {#{color}first: 1#{clear}, #{color}second: 2#{clear}, #{color}third: 3#{clear}} (#{bold}#{duration}ms#{clear}) #{color}ColorTest#{clear} -- Hello World -- #{{:first => 1, :second => 2, :third => 3}.ai(multiline: false)} -- Exception: #{color}RuntimeError: Oh no#{clear}\n"
+            str      = "#{expected_time} #{color}D#{clear} [#{$PROCESS_ID}:#{Thread.current.name} default_test.rb:35] [#{color}first#{clear}] [#{color}second#{clear}] [#{color}third#{clear}] {#{color}first: 1#{clear}, #{color}second: 2#{clear}, #{color}third: 3#{clear}} (#{bold}#{duration}ms#{clear}) #{color}ColorTest#{clear} -- Hello World -- #{{first: 1, second: 2, third: 3}.ai(multiline: false)} -- Exception: #{color}RuntimeError: Oh no#{clear}\n"
             assert_equal str, formatter.call(log, nil).lines.first
           end
         end
-
       end
     end
   end

data/test/formatters/default_test.rb

@@ -56,7 +56,7 @@ module SemanticLogger
           end
 
           it 'supports time_format' do
-            formatter = SemanticLogger::Formatters::Default.new(time_format: "%H:%M:%S")
+            formatter = SemanticLogger::Formatters::Default.new(time_format: '%H:%M:%S')
             formatter.call(log, nil)
             assert_equal '08:32:05', formatter.time
           end
@@ -70,53 +70,53 @@ module SemanticLogger
 
         describe 'process_info' do
           it 'logs pid and thread name' do
-            assert_equal "[#{$$}:#{Thread.current.name}]", formatter.process_info
+            assert_equal "[#{$PROCESS_ID}:#{Thread.current.name}]", formatter.process_info
           end
 
           it 'logs pid, thread name, and file name' do
             set_exception
             log.backtrace = backtrace
-            assert_equal "[#{$$}:#{Thread.current.name} default_test.rb:99]", formatter.process_info
+            assert_equal "[#{$PROCESS_ID}:#{Thread.current.name} default_test.rb:99]", formatter.process_info
           end
         end
 
         describe 'tags' do
           it 'logs tags' do
-            log.tags = %w(first second third)
-            assert_equal "[first] [second] [third]", formatter.tags
+            log.tags = %w[first second third]
+            assert_equal '[first] [second] [third]', formatter.tags
           end
         end
 
         describe 'named_tags' do
           it 'logs named tags' do
             log.named_tags = {first: 1, second: 2, third: 3}
-            assert_equal "{first: 1, second: 2, third: 3}", formatter.named_tags
+            assert_equal '{first: 1, second: 2, third: 3}', formatter.named_tags
           end
         end
 
         describe 'duration' do
           it 'logs long duration' do
             log.duration = 1_000_000.34567
-            assert_equal "(16m 40s)", formatter.duration
+            assert_equal '(16m 40s)', formatter.duration
           end
 
           it 'logs short duration' do
             log.duration = 1.34567
-            duration     = SemanticLogger::Formatters::Base::PRECISION == 3 ? "(1ms)" : "(1.346ms)"
+            duration     = SemanticLogger::Formatters::Base::PRECISION == 3 ? '(1ms)' : '(1.346ms)'
             assert_equal duration, formatter.duration
           end
         end
 
         describe 'name' do
           it 'logs name' do
-            assert_equal "DefaultTest", formatter.name
+            assert_equal 'DefaultTest', formatter.name
           end
         end
 
         describe 'message' do
           it 'logs message' do
-            log.message = "Hello World"
-            assert_equal "-- Hello World", formatter.message
+            log.message = 'Hello World'
+            assert_equal '-- Hello World', formatter.message
           end
 
           it 'skips empty message' do
@@ -127,7 +127,7 @@ module SemanticLogger
         describe 'payload' do
           it 'logs hash payload' do
             log.payload = {first: 1, second: 2, third: 3}
-            assert_equal "-- {:first=>1, :second=>2, :third=>3}", formatter.payload
+            assert_equal '-- {:first=>1, :second=>2, :third=>3}', formatter.payload
           end
 
           it 'skips nil payload' do
@@ -153,23 +153,22 @@ module SemanticLogger
 
         describe 'call' do
           it 'returns minimal elements' do
-            assert_equal "#{expected_time} D [#{$$}:#{Thread.current.name}] DefaultTest", formatter.call(log, nil)
+            assert_equal "#{expected_time} D [#{$PROCESS_ID}:#{Thread.current.name}] DefaultTest", formatter.call(log, nil)
           end
 
           it 'retuns all elements' do
-            log.tags       = %w(first second third)
+            log.tags       = %w[first second third]
             log.named_tags = {first: 1, second: 2, third: 3}
             log.duration   = 1.34567
-            log.message    = "Hello World"
+            log.message    = 'Hello World'
             log.payload    = {first: 1, second: 2, third: 3}
             log.backtrace  = backtrace
             set_exception
             duration = SemanticLogger::Formatters::Base::PRECISION == 3 ? '1' : '1.346'
-            str      = "#{expected_time} D [#{$$}:#{Thread.current.name} default_test.rb:99] [first] [second] [third] {first: 1, second: 2, third: 3} (#{duration}ms) DefaultTest -- Hello World -- {:first=>1, :second=>2, :third=>3} -- Exception: RuntimeError: Oh no\n"
+            str      = "#{expected_time} D [#{$PROCESS_ID}:#{Thread.current.name} default_test.rb:99] [first] [second] [third] {first: 1, second: 2, third: 3} (#{duration}ms) DefaultTest -- Hello World -- {:first=>1, :second=>2, :third=>3} -- Exception: RuntimeError: Oh no\n"
             assert_equal str, formatter.call(log, nil).lines.first
           end
         end
-
       end
     end
   end

data/test/formatters/one_line_test.rb

@@ -36,7 +36,7 @@ module SemanticLogger
         describe 'message' do
           it 'logs message' do
             log.message = "Hello \nWorld\n"
-            assert_equal "-- Hello World", formatter.message
+            assert_equal '-- Hello World', formatter.message
           end
 
           it 'skips empty message' do
@@ -54,7 +54,6 @@ module SemanticLogger
             refute formatter.exception
           end
         end
-
       end
     end
   end

data/test/formatters/signalfx_test.rb

@@ -23,15 +23,15 @@ module SemanticLogger
         let :logs do
           3.times.collect do |i|
             l        = log.dup
-            l.metric = "/user/login#{i+1}"
+            l.metric = "/user/login#{i + 1}"
             l
           end
         end
 
         let :same_logs do
-          3.times.collect do |i|
+          3.times.collect do |_i|
             l        = log.dup
-            l.metric = "/user/login"
+            l.metric = '/user/login'
             l
           end
         end
@@ -73,7 +73,7 @@ module SemanticLogger
             assert_equal counter_metric_name, counter['metric'], counter
             assert_equal 1, counter['value'], counter
             assert_equal (log.time.to_i * 1_000).to_i, counter['timestamp'], counter
-            assert counter.has_key?('dimensions')
+            assert counter.key?('dimensions')
           end
 
           it 'send gauge metric when log includes duration' do
@@ -84,7 +84,7 @@ module SemanticLogger
             assert_equal average_metric_name, counter['metric'], counter
             assert_equal 1234, counter['value'], counter
             assert_equal (log.time.to_i * 1_000).to_i, counter['timestamp'], counter
-            assert counter.has_key?('dimensions')
+            assert counter.key?('dimensions')
           end
 
           it 'also sends counter metric when gauge metric is sent' do
@@ -95,12 +95,12 @@ module SemanticLogger
             assert_equal counter_metric_name, counter['metric'], counter
             assert_equal 1, counter['value'], counter
             assert_equal (log.time.to_i * 1_000).to_i, counter['timestamp'], counter
-            assert counter.has_key?('dimensions')
+            assert counter.key?('dimensions')
           end
 
           it 'only forwards whitelisted dimensions from named_tags' do
             log.named_tags       = {user_id: 47, tracking_number: 7474, session_id: 'hsdhngsd'}
-            formatter.dimensions = [:user_id, :application]
+            formatter.dimensions = %i[user_id application]
             hash                 = result
             assert counters = hash['counter'], hash
             assert counter = counters.first, hash
@@ -156,7 +156,7 @@ module SemanticLogger
 
           describe 'send custom' do
             let :logs do
-              3.times.collect do |i|
+              3.times.collect do |_i|
                 l            = log.dup
                 l.metric     = 'Filter/count'
                 l.dimensions = dimensions
@@ -175,7 +175,6 @@ module SemanticLogger
               assert_equal all_dimensions, counter['dimensions']
             end
           end
-
         end
 
         describe 'format batch logs with aggregation' do
@@ -192,9 +191,7 @@ module SemanticLogger
             assert_equal 3, counters[0]['value']
           end
         end
-
       end
-
     end
   end
 end

data/test/formatters_test.rb

@@ -18,15 +18,15 @@ class FormattersTest < Minitest::Test
       end
 
       it 'from a Hash (Symbol with options)' do
-        assert formatter = SemanticLogger::Formatters.factory(raw: {time_format: "%Y%m%d"})
+        assert formatter = SemanticLogger::Formatters.factory(raw: {time_format: '%Y%m%d'})
         assert formatter.is_a?(SemanticLogger::Formatters::Raw)
         assert result = formatter.call(log, appender)
         assert_equal 'Test', result[:name]
-        assert_equal Time.now.strftime("%Y%m%d"), result[:time]
+        assert_equal Time.now.strftime('%Y%m%d'), result[:time]
       end
 
       it 'from block' do
-        my_formatter = -> log, appender { log.name }
+        my_formatter = ->(log, _appender) { log.name }
         assert formatter = SemanticLogger::Formatters.factory(my_formatter)
         assert formatter.is_a?(Proc)
         assert_equal 'Test', formatter.call(log, appender)

data/test/in_memory_appender.rb

@@ -6,4 +6,3 @@ class InMemoryAppender < SemanticLogger::Subscriber
     self.message = log
   end
 end
-

data/test/in_memory_appender_helper.rb

@@ -15,7 +15,7 @@ InMemoryAppenderHelper = shared_description do
   end
 
   let :payload do
-    {session_id: 'HSSKLEU@JDK767', tracking_number: 12345}
+    {session_id: 'HSSKLEU@JDK767', tracking_number: 12_345}
   end
 
   let :logger do

data/test/in_memory_batch_appender.rb

@@ -6,4 +6,3 @@ class InMemoryBatchAppender < SemanticLogger::Subscriber
     self.message = logs
   end
 end
-

data/test/in_memory_metrics_appender.rb

@@ -11,4 +11,3 @@ class InMemoryMetricsAppender < SemanticLogger::Subscriber
     log.metric && meets_log_level?(log) && !filtered?(log)
   end
 end
-

data/test/loggable_test.rb

@@ -55,7 +55,7 @@ class AppenderFileTest < Minitest::Test
         base = Base.new
         base.perform
         called = false
-        Base.logger.stub(:info, -> description { called = true if description == 'perform' }) do
+        Base.logger.stub(:info, ->(description) { called = true if description == 'perform' }) do
           base.perform
         end
         assert called, 'Did not call the correct logger'
@@ -65,7 +65,7 @@ class AppenderFileTest < Minitest::Test
         subclass = Subclass.new
         subclass.process
         called = false
-        Subclass.logger.stub(:info, -> description { called = true if description == 'process' }) do
+        Subclass.logger.stub(:info, ->(description) { called = true if description == 'process' }) do
           subclass.process
         end
         assert called, 'Did not call the correct logger'
@@ -99,6 +99,5 @@ class AppenderFileTest < Minitest::Test
         end
       end
     end
-
   end
 end

data/test/logger_test.rb

@@ -11,7 +11,6 @@ class LoggerTest < Minitest::Test
 
     # Ensure that any log level can be logged
     SemanticLogger::LEVELS.each do |level|
-
       describe "##{level}" do
         describe 'positional parameter' do
           it 'logs message' do
@@ -44,7 +43,7 @@ class LoggerTest < Minitest::Test
               assert_equal 'hello world -- Calculations', log.message
               assert_equal payload, log.payload
               assert log.backtrace
-              assert log.backtrace.size > 0, log.backtrace
+              assert log.backtrace.size.positive?, log.backtrace
             end
           end
 
@@ -56,7 +55,7 @@ class LoggerTest < Minitest::Test
               assert log = log_message
               assert_equal 'hello world', log.message
               assert log.backtrace
-              assert log.backtrace.size > 0, log.backtrace
+              assert log.backtrace.size.positive?, log.backtrace
 
               assert log.exception
               refute log.exception.backtrace
@@ -153,7 +152,7 @@ class LoggerTest < Minitest::Test
         describe '#filter' do
           describe 'at the appender level' do
             it 'Proc' do
-              appender.filter = -> log { (/\AExclude/ =~ log.message).nil? }
+              appender.filter = ->(log) { (/\AExclude/ =~ log.message).nil? }
               logger.send(level, 'Exclude this log message', @hash) { 'Calculations' }
 
               refute log_message
@@ -161,7 +160,7 @@ class LoggerTest < Minitest::Test
 
             it 'RegExp' do
               filter          = /\ALogger/
-              appender.filter = -> log { (/\AExclude/ =~ log.message).nil? }
+              appender.filter = ->(log) { (/\AExclude/ =~ log.message).nil? }
               logger.send(level, 'Exclude this log message', @hash) { 'Calculations' }
 
               refute log_message
@@ -170,7 +169,7 @@ class LoggerTest < Minitest::Test
 
           describe 'at the logger level' do
             it 'Proc' do
-              logger.filter = -> log { (/\AExclude/ =~ log.message).nil? }
+              logger.filter = ->(log) { (/\AExclude/ =~ log.message).nil? }
               logger.send(level, 'Exclude this log message', @hash) { 'Calculations' }
 
               refute log_message
@@ -178,13 +177,12 @@ class LoggerTest < Minitest::Test
 
             it 'RegExp' do
               filter        = /\ALogger/
-              logger.filter = -> log { (/\AExclude/ =~ log.message).nil? }
+              logger.filter = ->(log) { (/\AExclude/ =~ log.message).nil? }
               logger.send(level, 'Exclude this log message', @hash) { 'Calculations' }
 
               refute log_message
             end
           end
-
         end
       end
     end
@@ -204,9 +202,9 @@ class LoggerTest < Minitest::Test
         it "log Ruby logger #{level} info" do
           logger.level = Logger::Severity.const_get(level)
           if level.to_s == 'UNKNOWN'
-            assert_equal Logger::Severity.const_get('ERROR')+1, logger.send(:level_index)
+            assert_equal Logger::Severity.const_get('ERROR') + 1, logger.send(:level_index)
           else
-            assert_equal Logger::Severity.const_get(level)+1, logger.send(:level_index)
+            assert_equal Logger::Severity.const_get(level) + 1, logger.send(:level_index)
           end
         end
       end
@@ -261,7 +259,7 @@ class LoggerTest < Minitest::Test
 
           assert log = log_message
           assert_equal 'hello world', log.message
-          assert_equal %w(12345 DJHSFK), log.tags
+          assert_equal %w[12345 DJHSFK], log.tags
         end
       end
 
@@ -292,15 +290,14 @@ class LoggerTest < Minitest::Test
       end
 
       it 'is compatible with rails logging that uses arrays and nils' do
-        logger.tagged('', ['12345', 'DJHSFK'], nil) do
+        logger.tagged('', %w[12345 DJHSFK], nil) do
           logger.info('hello world')
 
           assert log = log_message
           assert_equal 'hello world', log.message
-          assert_equal %w(12345 DJHSFK), log.tags
+          assert_equal %w[12345 DJHSFK], log.tags
         end
       end
     end
-
   end
 end