scss_lint 0.40.1 → 0.41.0

data/spec/scss_lint/linter/unnecessary_mantissa_spec.rb

@@ -64,4 +64,24 @@ describe SCSSLint::Linter::UnnecessaryMantissa do
 
     it { should_not report_lint }
   end
+
+  context 'when a decimal value appears in a single-quoted string' do
+    let(:scss) { <<-SCSS }
+      p {
+        content: '1.0';
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a decimal value appears in a double-quoted string' do
+    let(:scss) { <<-SCSS }
+      p {
+        content: "1.0";
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
 end

data/spec/scss_lint/linter_spec.rb

@@ -238,11 +238,32 @@ describe SCSSLint::Linter do
           // scss-lint:disable Fake
           border: fail2;
         }
+
+        p {
+          background: red; // [1]
+          //scss-lint:disable Fake
+          border: fail2;
+        }
       SCSS
 
       it { should_not report_lint }
     end
 
+    context 'when the command comment is below an attached comment and a lint' do
+      let(:scss) { <<-SCSS }
+        // 1. Some comment about my background
+        .foo {
+          background: fail1; // [1]
+          // scss-lint:disable Fake
+          border: fail1
+          // scss-lint:enable Fake
+        }
+      SCSS
+
+      it { should report_lint line: 3 }
+      it { should_not report_lint line: 5 }
+    end
+
     context 'when the command comment is at the end of a statement' do
       let(:scss) { <<-SCSS }
         p {

data/spec/scss_lint/report_lint_spec.rb

@@ -0,0 +1,268 @@
+require 'spec_helper'
+require 'rspec/matchers/fail_matchers'
+
+RSpec.configure do |config|
+  config.include RSpec::Matchers::FailMatchers
+end
+
+RSpec::Matchers.define_negated_matcher :succeed, :raise_error
+
+# In these tests, we cover all of the combinations of successful and failed
+# matches, expecting and _not_ expecting lints, specified and unspecified line
+# numbers, specified and unspecified lint counts, and singular and multiple
+# lints.
+describe 'report_lint' do
+  let(:subject) { SCSSLint::Linter::LeadingZero.new }
+
+  def run_with(scss)
+    subject.run(SCSSLint::Engine.new(code: scss), SCSSLint::Config.default.linter_options(subject))
+  end
+
+  context 'when expecting no lints' do
+    it 'matches zero expected lints' do
+      run_with('p { margin: .5em; }')
+
+      expect do
+        should_not report_lint
+      end.to succeed
+    end
+
+    it 'fails to match one lint with a meaningful message' do
+      run_with('p { margin: 0.5em; }')
+
+      expect do
+        should_not report_lint
+      end.to fail_with 'expected that a lint would not be reported'
+    end
+  end
+
+  context 'when expecting no lints on a certain line' do
+    it 'matches zero expected lints' do
+      run_with('p { margin: .5em; }')
+
+      expect do
+        should_not report_lint line: 1
+      end.to succeed
+    end
+
+    it 'matches zero expected lints on the specified line' do
+      run_with('p { margin: 0.5em; }')
+
+      expect do
+        should_not report_lint line: 10
+      end.to succeed
+    end
+
+    it 'fails to match one lint on the specified line with a meaningful message' do
+      run_with('p { margin: 0.5em; }')
+
+      expect do
+        should_not report_lint line: 1
+      end.to fail_with 'expected that a lint would not be reported'
+    end
+  end
+
+  context 'when expecting a lint' do
+    it 'matches one expected lint' do
+      run_with('p { margin: 0.5em; }')
+
+      expect do
+        should report_lint
+      end.to succeed
+    end
+
+    it 'matches multiple lints' do
+      run_with('p { margin: 0.5em 0.5em; }')
+
+      expect do
+        should report_lint
+      end.to succeed
+    end
+
+    it 'fails to match zero lints with a meaningful message' do
+      run_with('p { margin: .5em; }')
+
+      expect do
+        should report_lint
+      end.to fail_with 'expected that a lint would be reported'
+    end
+  end
+
+  context 'when expecting a lint on a certain line' do
+    it 'matches one expected lint' do
+      run_with('p { margin: 0.5em; }')
+
+      expect do
+        should report_lint line: 1
+      end.to succeed
+    end
+
+    it 'matches multiple lints' do
+      run_with('p { margin: 0.5em 0.5em; }')
+
+      expect do
+        should report_lint line: 1
+      end.to succeed
+    end
+
+    it 'fails to match zero lints with a meaningful message' do
+      run_with('p { margin: .5em; }')
+
+      expect do
+        should report_lint line: 1
+      end.to fail_with 'expected that a lint would be reported on line 1'
+    end
+
+    it 'fails to match lints on the wrong line with a meaningful message' do
+      run_with('p { margin: 0.5em; }')
+
+      expect do
+        should report_lint line: 10
+      end.to fail_with 'expected that a lint would be reported on line 10, ' \
+                       'but one lint was reported on line 1'
+    end
+  end
+
+  context 'when expecting exactly one lint' do
+    it 'matches one expected lint' do
+      run_with('p { margin: 0.5em; }')
+
+      expect do
+        should report_lint count: 1
+      end.to succeed
+    end
+
+    it 'fails to match zero lints with a meaningful message' do
+      run_with('p { margin: .5em; }')
+
+      expect do
+        should report_lint count: 1
+      end.to fail_with 'expected that exactly 1 lint would be reported'
+    end
+
+    it 'fails to match multiple lints with a meaningful message' do
+      run_with('p { margin: 0.5em 0.5em; }')
+
+      expect do
+        should report_lint count: 1
+      end.to fail_with 'expected that exactly 1 lint would be reported, ' \
+                       'but lints were reported on lines 1 and 1'
+    end
+
+    it 'fails to match lints on the wrong line with a meaningful message' do
+      run_with('p { margin: 0.5em; }')
+
+      expect do
+        should report_lint line: 10, count: 1
+      end.to fail_with 'expected that exactly 1 lint would be reported on ' \
+                       'line 10, but one lint was reported on line 1'
+    end
+  end
+
+  context 'when expecting multiple lints' do
+    it 'matches multiple lints' do
+      run_with('p { margin: 0.5em 0.5em; }')
+
+      expect do
+        should report_lint count: 2
+      end.to succeed
+    end
+
+    it 'fails to match zero lints with a meaningful message' do
+      run_with('p { margin: .5em; }')
+
+      expect do
+        should report_lint count: 2
+      end.to fail_with 'expected that exactly 2 lints would be reported'
+    end
+
+    it 'fails to match one lint with a meaningful message' do
+      run_with('p { margin: .5em; }')
+
+      expect do
+        should report_lint count: 2
+      end.to fail_with 'expected that exactly 2 lints would be reported'
+    end
+
+    it 'fails to match lints on the wrong line with a meaningful message' do
+      run_with('p { margin: 0.5em 0.5em; }')
+
+      expect do
+        should report_lint line: 10, count: 2
+      end.to fail_with 'expected that exactly 2 lints would be reported on ' \
+                       'line 10, but lints were reported on lines 1 and 1'
+    end
+  end
+
+  context 'when expecting exactly one lint on a certain line' do
+    it 'matches one expected lint' do
+      run_with('p { margin: 0.5em; }')
+
+      expect do
+        should report_lint line: 1, count: 1
+      end.to succeed
+    end
+
+    it 'fails to match zero lints with a meaningful message' do
+      run_with('p { margin: .5em; }')
+
+      expect do
+        should report_lint line: 1, count: 1
+      end.to fail_with 'expected that exactly 1 lint would be reported on line 1'
+    end
+
+    it 'fails to match multiple lints with a meaningful message' do
+      run_with('p { margin: 0.5em 0.5em; }')
+
+      expect do
+        should report_lint line: 1, count: 1
+      end.to fail_with 'expected that exactly 1 lint would be reported on ' \
+                       'line 1, but lints were reported on lines 1 and 1'
+    end
+
+    it 'fails to match lints on the wrong line with a meaningful message' do
+      run_with('p { margin: 0.5em; }')
+
+      expect do
+        should report_lint line: 10, count: 1
+      end.to fail_with 'expected that exactly 1 lint would be reported on ' \
+                       'line 10, but one lint was reported on line 1'
+    end
+  end
+
+  context 'when expecting multiple lints on a certain line' do
+    it 'matches one expected lint' do
+      run_with('p { margin: 0.5em 0.5em; }')
+
+      expect do
+        should report_lint line: 1, count: 2
+      end.to succeed
+    end
+
+    it 'fails to match zero lints with a meaningful message' do
+      run_with('p { margin: .5em; }')
+
+      expect do
+        should report_lint line: 1, count: 2
+      end.to fail_with 'expected that exactly 2 lints would be reported on line 1'
+    end
+
+    it 'fails to match one lint with a meaningful message' do
+      run_with('p { margin: 0.5em; }')
+
+      expect do
+        should report_lint line: 1, count: 2
+      end.to fail_with 'expected that exactly 2 lints would be reported on ' \
+                       'line 1, but one lint was reported on line 1'
+    end
+
+    it 'fails to match lints on the wrong line with a meaningful message' do
+      run_with('p { margin: 0.5em; }')
+
+      expect do
+        should report_lint line: 10, count: 2
+      end.to fail_with 'expected that exactly 2 lints would be reported on ' \
+                       'line 10, but one lint was reported on line 1'
+    end
+  end
+end

data/spec/scss_lint/reporter/clean_files_reporter_spec.rb

@@ -0,0 +1,73 @@
+require 'spec_helper'
+
+describe SCSSLint::Reporter::CleanFilesReporter do
+  subject { described_class.new(lints, files) }
+
+  describe '#report_lints' do
+    context 'when there are no lints and no files' do
+      let(:files) { [] }
+      let(:lints) { [] }
+
+      it 'returns nil' do
+        subject.report_lints.should be_nil
+      end
+    end
+
+    context 'when there are no lints but some files were linted' do
+      let(:files) { %w[c.scss b.scss a.scss] }
+      let(:lints) { [] }
+
+      it 'prints each file on its own line' do
+        subject.report_lints.count("\n").should == 3
+      end
+
+      it 'prints the files in order' do
+        subject.report_lints.split("\n")[0].should eq 'a.scss'
+        subject.report_lints.split("\n")[1].should eq 'b.scss'
+        subject.report_lints.split("\n")[2].should eq 'c.scss'
+      end
+
+      it 'prints a trailing newline' do
+        subject.report_lints[-1].should == "\n"
+      end
+    end
+
+    context 'when there are lints in some files' do
+      let(:dirty_files) { %w[a.scss b.scss] }
+      let(:clean_files) { %w[c.scss d.scss] }
+      let(:files) { dirty_files + clean_files }
+
+      let(:lints) do
+        dirty_files.map do |file|
+          SCSSLint::Lint.new(nil, file, SCSSLint::Location.new, '')
+        end
+      end
+
+      it 'prints the file for each lint' do
+        clean_files.each do |file|
+          subject.report_lints.scan(/#{file}/).count.should == 1
+        end
+      end
+
+      it 'does not print clean files' do
+        dirty_files.each do |file|
+          subject.report_lints.scan(/#{file}/).count.should == 0
+        end
+      end
+    end
+
+    context 'when there are lints in every file' do
+      let(:files) { %w[a.scss b.scss c.scss d.scss] }
+
+      let(:lints) do
+        files.map do |file|
+          SCSSLint::Lint.new(nil, file, SCSSLint::Location.new, '')
+        end
+      end
+
+      it 'does not print clean files' do
+        subject.report_lints.should be_nil
+      end
+    end
+  end
+end

data/spec/scss_lint/reporter/config_reporter_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe SCSSLint::Reporter::ConfigReporter do
   subject { YAML.load(result) }
-  let(:result) { described_class.new(lints).report_lints }
+  let(:result) { described_class.new(lints, []).report_lints }
 
   describe '#report_lints' do
     context 'when there are no lints' do

data/spec/scss_lint/reporter/default_reporter_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe SCSSLint::Reporter::DefaultReporter do
-  subject { SCSSLint::Reporter::DefaultReporter.new(lints) }
+  subject { SCSSLint::Reporter::DefaultReporter.new(lints, []) }
 
   describe '#report_lints' do
     context 'when there are no lints' do

data/spec/scss_lint/reporter/files_reporter_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe SCSSLint::Reporter::FilesReporter do
-  subject { described_class.new(lints) }
+  subject { described_class.new(lints, []) }
 
   describe '#report_lints' do
     context 'when there are no lints' do
@@ -13,7 +13,8 @@ describe SCSSLint::Reporter::FilesReporter do
     end
 
     context 'when there are lints' do
-      let(:filenames)    { ['some-filename.scss', 'some-filename.scss', 'other-filename.scss'] }
+      let(:filenames) { ['some-filename.scss', 'some-filename.scss', 'other-filename.scss'] }
+
       let(:lints) do
         filenames.map do |filename|
           SCSSLint::Lint.new(nil, filename, SCSSLint::Location.new, '')

data/spec/scss_lint/reporter/json_reporter_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe SCSSLint::Reporter::JSONReporter do
-  subject { SCSSLint::Reporter::JSONReporter.new(lints) }
+  subject { SCSSLint::Reporter::JSONReporter.new(lints, []) }
 
   describe '#report_lints' do
     let(:json) { JSON.parse(subject.report_lints) }

data/spec/spec_helper.rb

@@ -25,7 +25,7 @@ RSpec.configure do |config|
     # If running a linter spec, run the described linter against the CSS code
     # for each example. This significantly DRYs up our linter specs to contain
     # only tests, since all the setup code is now centralized here.
-    if described_class <= SCSSLint::Linter
+    if described_class && described_class <= SCSSLint::Linter
       initial_indent = scss[/\A(\s*)/, 1]
       normalized_css = scss.gsub(/^#{initial_indent}/, '')
 

data/spec/support/matchers/report_lint.rb

@@ -8,13 +8,22 @@ RSpec::Matchers.define :report_lint do |options|
   end
 
   failure_message do |linter|
-    'expected that a lint would be reported' +
+    expected_count =
+      if count.nil?
+        'a lint'
+      elsif count == 1
+        'exactly 1 lint'
+      else
+        "exactly #{count} lints"
+      end
+
+    "expected that #{expected_count} would be reported" +
       (expected_line ? " on line #{expected_line}" : '') +
       case linter.lints.count
       when 0
         ''
       when 1
-        ", but was on line #{linter.lints.first.location.line}"
+        ", but one lint was reported on line #{linter.lints.first.location.line}"
       else
         lines = lint_lines(linter)
         ", but lints were reported on lines #{lines[0...-1].join(', ')} and #{lines.last}"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: scss_lint
 version: !ruby/object:Gem::Version
-  version: 0.40.1
+  version: 0.41.0
 platform: ruby
 authors:
 - Brigade Engineering
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-30 00:00:00.000000000 Z
+date: 2015-08-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rainbow
@@ -31,28 +31,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.4.1
+        version: 3.4.15
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.4.1
+        version: 3.4.15
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: 3.3.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: 3.3.0
 description: Configurable tool for writing clean and consistent SCSS
 email:
 - eng@brigade.com
@@ -90,6 +90,7 @@ files:
 - lib/scss_lint/linter/compass/property_with_mixin.rb
 - lib/scss_lint/linter/debug_statement.rb
 - lib/scss_lint/linter/declaration_order.rb
+- lib/scss_lint/linter/disable_linter_reason.rb
 - lib/scss_lint/linter/duplicate_property.rb
 - lib/scss_lint/linter/else_placement.rb
 - lib/scss_lint/linter/empty_line_between_blocks.rb
@@ -122,12 +123,14 @@ files:
 - lib/scss_lint/linter/space_after_property_colon.rb
 - lib/scss_lint/linter/space_after_property_name.rb
 - lib/scss_lint/linter/space_after_variable_name.rb
+- lib/scss_lint/linter/space_around_operator.rb
 - lib/scss_lint/linter/space_before_brace.rb
 - lib/scss_lint/linter/space_between_parens.rb
 - lib/scss_lint/linter/string_quotes.rb
 - lib/scss_lint/linter/trailing_semicolon.rb
 - lib/scss_lint/linter/trailing_whitespace.rb
 - lib/scss_lint/linter/trailing_zero.rb
+- lib/scss_lint/linter/transition_all.rb
 - lib/scss_lint/linter/unnecessary_mantissa.rb
 - lib/scss_lint/linter/unnecessary_parent_reference.rb
 - lib/scss_lint/linter/url_format.rb
@@ -143,6 +146,7 @@ files:
 - lib/scss_lint/plugins/linter_gem.rb
 - lib/scss_lint/rake_task.rb
 - lib/scss_lint/reporter.rb
+- lib/scss_lint/reporter/clean_files_reporter.rb
 - lib/scss_lint/reporter/config_reporter.rb
 - lib/scss_lint/reporter/default_reporter.rb
 - lib/scss_lint/reporter/files_reporter.rb
@@ -167,6 +171,7 @@ files:
 - spec/scss_lint/linter/compass/property_with_mixin_spec.rb
 - spec/scss_lint/linter/debug_statement_spec.rb
 - spec/scss_lint/linter/declaration_order_spec.rb
+- spec/scss_lint/linter/disable_linter_reason_spec.rb
 - spec/scss_lint/linter/duplicate_property_spec.rb
 - spec/scss_lint/linter/else_placement_spec.rb
 - spec/scss_lint/linter/empty_line_between_blocks_spec.rb
@@ -199,12 +204,14 @@ files:
 - spec/scss_lint/linter/space_after_property_colon_spec.rb
 - spec/scss_lint/linter/space_after_property_name_spec.rb
 - spec/scss_lint/linter/space_after_variable_name_spec.rb
+- spec/scss_lint/linter/space_around_operator_spec.rb
 - spec/scss_lint/linter/space_before_brace_spec.rb
 - spec/scss_lint/linter/space_between_parens_spec.rb
 - spec/scss_lint/linter/string_quotes_spec.rb
 - spec/scss_lint/linter/trailing_semicolon_spec.rb
 - spec/scss_lint/linter/trailing_whitespace_spec.rb
 - spec/scss_lint/linter/trailing_zero_spec.rb
+- spec/scss_lint/linter/transition_all_spec.rb
 - spec/scss_lint/linter/unnecessary_mantissa_spec.rb
 - spec/scss_lint/linter/unnecessary_parent_reference_spec.rb
 - spec/scss_lint/linter/url_format_spec.rb
@@ -220,6 +227,8 @@ files:
 - spec/scss_lint/plugins/linter_gem_spec.rb
 - spec/scss_lint/plugins_spec.rb
 - spec/scss_lint/rake_task_spec.rb
+- spec/scss_lint/report_lint_spec.rb
+- spec/scss_lint/reporter/clean_files_reporter_spec.rb
 - spec/scss_lint/reporter/config_reporter_spec.rb
 - spec/scss_lint/reporter/default_reporter_spec.rb
 - spec/scss_lint/reporter/files_reporter_spec.rb
@@ -269,6 +278,7 @@ test_files:
 - spec/scss_lint/linter/compass/property_with_mixin_spec.rb
 - spec/scss_lint/linter/debug_statement_spec.rb
 - spec/scss_lint/linter/declaration_order_spec.rb
+- spec/scss_lint/linter/disable_linter_reason_spec.rb
 - spec/scss_lint/linter/duplicate_property_spec.rb
 - spec/scss_lint/linter/else_placement_spec.rb
 - spec/scss_lint/linter/empty_line_between_blocks_spec.rb
@@ -301,12 +311,14 @@ test_files:
 - spec/scss_lint/linter/space_after_property_colon_spec.rb
 - spec/scss_lint/linter/space_after_property_name_spec.rb
 - spec/scss_lint/linter/space_after_variable_name_spec.rb
+- spec/scss_lint/linter/space_around_operator_spec.rb
 - spec/scss_lint/linter/space_before_brace_spec.rb
 - spec/scss_lint/linter/space_between_parens_spec.rb
 - spec/scss_lint/linter/string_quotes_spec.rb
 - spec/scss_lint/linter/trailing_semicolon_spec.rb
 - spec/scss_lint/linter/trailing_whitespace_spec.rb
 - spec/scss_lint/linter/trailing_zero_spec.rb
+- spec/scss_lint/linter/transition_all_spec.rb
 - spec/scss_lint/linter/unnecessary_mantissa_spec.rb
 - spec/scss_lint/linter/unnecessary_parent_reference_spec.rb
 - spec/scss_lint/linter/url_format_spec.rb
@@ -322,6 +334,8 @@ test_files:
 - spec/scss_lint/plugins/linter_gem_spec.rb
 - spec/scss_lint/plugins_spec.rb
 - spec/scss_lint/rake_task_spec.rb
+- spec/scss_lint/report_lint_spec.rb
+- spec/scss_lint/reporter/clean_files_reporter_spec.rb
 - spec/scss_lint/reporter/config_reporter_spec.rb
 - spec/scss_lint/reporter/default_reporter_spec.rb
 - spec/scss_lint/reporter/files_reporter_spec.rb