scss_lint 0.40.1 → 0.41.0

data/lib/scss_lint/sass/script.rb

@@ -74,5 +74,24 @@ module Sass::Script
         [value]
       end
     end
+
+    # This monkey patch can be removed once scss-lint depends on a minimum
+    # version of the sass gem that includes a fix for
+    # https://github.com/sass/sass/issues/1799
+    class ListLiteral
+      def source_range
+        return @source_range if @elements.empty?
+        @source_range.end_pos = @elements.last.source_range.end_pos
+        @source_range
+      end
+    end
+
+    class MapLiteral
+      def source_range
+        return @source_range if @pairs.empty?
+        @source_range.end_pos = @pairs.last.last.source_range.end_pos
+        @source_range
+      end
+    end
   end
 end

data/lib/scss_lint/version.rb

@@ -1,4 +1,4 @@
 # Defines the gem version.
 module SCSSLint
-  VERSION = '0.40.1'
+  VERSION = '0.41.0'
 end

data/spec/scss_lint/linter/bang_format_spec.rb

@@ -105,7 +105,7 @@ describe SCSSLint::Linter::BangFormat do
     SCSS
 
     it 'does not loop forever' do
-      subject.should_not report_lint
+      should_not report_lint
     end
   end
 

data/spec/scss_lint/linter/disable_linter_reason_spec.rb

@@ -0,0 +1,63 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::DisableLinterReason do
+  context 'when no disabling instructions exist' do
+    let(:scss) { <<-SCSS }
+      // Comment.
+      p {
+        margin: 0;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when no reason accompanies a disabling comment' do
+    let(:scss) { <<-SCSS }
+      // scss-lint:disable BorderZero
+      p {
+        margin: 0;
+      }
+    SCSS
+
+    it { should report_lint line: 1 }
+  end
+
+  context 'when a reason immediately precedes a disabling comment' do
+    let(:scss) { <<-SCSS }
+      // We like using `border: none` in our CSS.
+      // scss-lint:disable BorderZero
+      p {
+        margin: 0;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a reason precedes a disabling comment, at a distance' do
+    let(:scss) { <<-SCSS }
+      // We like using `border: none` in our CSS.
+
+      // scss-lint:disable BorderZero
+      p {
+        margin: 0;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when no reason precedes an enabling comment' do
+    let(:scss) { <<-SCSS }
+      // Disable for now
+      // scss-lint:disable BorderZero
+      p {
+        border: none;
+      }
+      // scss-lint:enable BorderZero
+    SCSS
+
+    it { should_not report_lint }
+  end
+end

data/spec/scss_lint/linter/nesting_depth_spec.rb

@@ -155,6 +155,22 @@ describe SCSSLint::Linter::NestingDepth do
 
         it { should_not report_lint }
       end
+
+      context 'and sequence contains a keyframe' do
+        let(:linter_config) { super().merge('max_depth' => 1) }
+        let(:scss) { <<-SCSS }
+        @keyframe my_keyframe {
+            0% {
+                background: none;
+            }
+            50% {
+                background: red;
+            }
+        }
+        SCSS
+
+        it { should_not report_lint }
+      end
     end
 
     context 'when not ignoring parent selectors' do

data/spec/scss_lint/linter/single_line_per_selector_spec.rb

@@ -127,4 +127,27 @@ describe SCSSLint::Linter::SingleLinePerSelector do
 
     it { should_not report_lint }
   end
+
+  context 'when a selector sequence spans multiple lines' do
+    let(:scss) { <<-SCSS }
+      .one
+        .two
+        .three {
+      }
+    SCSS
+
+    it { should report_lint }
+  end
+
+  context 'when a selector sequence spans multiple lines in a comma sequence' do
+    let(:scss) { <<-SCSS }
+      .one
+        .two
+        .three,
+      .other {
+      }
+    SCSS
+
+    it { should report_lint }
+  end
 end

data/spec/scss_lint/linter/space_after_variable_name_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe SCSSLint::SpaceAfterVariableName do
+describe SCSSLint::Linter::SpaceAfterVariableName do
   let(:scss) { <<-SCSS }
     $none: #fff;
     $one : #fff;

data/spec/scss_lint/linter/space_around_operator_spec.rb

@@ -0,0 +1,240 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::SpaceAroundOperator do
+  let(:linter_config) { { 'style' => style } }
+
+  context 'when one space is preferred' do
+    let(:style) { 'one_space' }
+
+    context 'when no properties exist' do
+      let(:scss) { <<-SCSS }
+        p {
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when values without infix operators exist' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: 5px;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when values with properly-spaced infix operators exist' do
+      let(:scss) { <<-SCSS }
+        $x: 2px + 2px;
+
+        p {
+          margin: 5px + 5px;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when numeric values with infix operators exist' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: 5px+5px;
+          margin: 5px  +  5px;
+          margin: 4px*2;
+          margin: 20px%3;
+          font-family: sans-+serif;
+        }
+
+        $x: 10px+10px;
+        $x: 20px-10px;
+      SCSS
+
+      it { should report_lint line: 2 }
+      it { should report_lint line: 3 }
+      it { should report_lint line: 4 }
+      it { should report_lint line: 5 }
+      it { should report_lint line: 6 }
+      it { should report_lint line: 9 }
+      it { should report_lint line: 10 }
+    end
+
+    context 'when numeric values with infix operators and newlines exist' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: 7px+
+              7px;
+          padding: 9px
+              + 9px;
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+      it { should report_lint line: 4 }
+    end
+
+    context 'when numeric values with multiple infix operators exist' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: 5px*2+8px;
+        }
+      SCSS
+
+      it { should report_lint line: 2, count: 2 }
+    end
+
+    context 'when if nodes with comparison infix operators exist' do
+      let(:scss) { <<-SCSS }
+        p {
+          @if 3==2 {
+            margin: 5px;
+          }
+
+          @if 5>4 {
+            margin: 5px;
+          }
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+      it { should report_lint line: 6 }
+    end
+
+    context 'when values containing multiple operators exist' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: 2px+8px 18px+12px;
+        }
+      SCSS
+
+      it { should report_lint line: 2, count: 2 }
+    end
+
+    context 'when a function call contains a value with infix operators' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: some-function(2em+1em);
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when mixin include contains a value with infix operators' do
+      let(:scss) { <<-SCSS }
+        p {
+          @include some-mixin(4em-2em);
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when string contains an infix operator' do
+      let(:scss) { <<-SCSS }
+        p {
+          content: func("4em-2em");
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when string contains an interpolated infix operator' do
+      let(:scss) { <<-SCSS }
+        p {
+          content: "There are \#{11+1} months."
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when values with non-evaluated operations exist' do
+      let(:scss) { <<-SCSS }
+        $my-variable: 10px;
+
+        p {
+          font: 12px/10px;
+          margin: 2em-1em;
+          padding: $my-variable;
+          font-size: em(16px / $base-font-size);
+        }
+      SCSS
+
+      it { should report_lint line: 5 }
+    end
+
+    context 'when values with nested operators and proper space exist' do
+      let(:scss) { <<-SCSS }
+        p {
+          top: ($number) * -2;
+          top: (($number)) * ((2));
+          top: (($number  )  ) * ( ( 2 ) );
+          top: ($number
+                   ) * ( 2 );
+          top: 2px + 3px + 4px;
+          top: (2px + 3px) + 4px;
+          top: (  2px + 3px  ) + 4px;
+          top: 2px + (3px + 4px);
+          top: 2px + (  3px + 4px  );
+          top: (2px) + (3px) + (4px);
+          top: (  2px  ) + (  3px  ) + (  4px  );
+        }
+
+        @if $var == 1 or $var == 2 {
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when values with proper division operations exist' do
+      let(:scss) { <<-SCSS }
+        $x: 20px;
+        p {
+          width: $x/2;
+          width: round(1.5)/2;
+          width: (50px/2);
+          width: 10px + 20px/2;
+        }
+      SCSS
+
+      it { should report_lint line: 3 }
+      it { should report_lint line: 4 }
+      it { should report_lint line: 5 }
+      it { should report_lint line: 6 }
+    end
+  end
+  context 'when one space is preferred' do
+    let(:style) { 'no_space' }
+
+    context 'when values with single-spaced infix operators exist' do
+      let(:scss) { <<-SCSS }
+        $x: 2px + 2px;
+
+        p {
+          margin: 5px + 5px;
+          width: 5px   +       5px;
+        }
+      SCSS
+
+      it { should report_lint line: 1 }
+      it { should report_lint line: 4 }
+      it { should report_lint line: 5 }
+    end
+
+    context 'when values with no-spaced infix operators exist' do
+      let(:scss) { <<-SCSS }
+        $x: 2px+2px;
+
+        p {
+          margin: 5px+5px;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+  end
+end

data/spec/scss_lint/linter/space_between_parens_spec.rb

@@ -119,6 +119,26 @@ describe SCSSLint::Linter::SpaceBetweenParens do
     it { should_not report_lint }
   end
 
+  context 'when a 0-argument function has nothing between parens' do
+    let(:scss) { <<-SCSS }
+      p {
+        property: unique-id();
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a 0-argument function has space between parens' do
+    let(:scss) { <<-SCSS }
+      p {
+        property: unique-id(  );
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
   context 'when parens exist in a silent comment' do
     let(:scss) { <<-SCSS }
       p {
@@ -132,13 +152,167 @@ describe SCSSLint::Linter::SpaceBetweenParens do
   context 'when parens exist in an outputted comment' do
     let(:scss) { <<-SCSS }
       p {
-        margin: 0; /* Some comment ( with parens ) */
+        /*
+         * Some comment ( with parens )
+         */
+        margin: 0;
       }
     SCSS
 
     it { should_not report_lint }
   end
 
+  context 'when an import uses parens' do
+    let(:scss) { <<-SCSS }
+      @import url( foo );
+      @import url(bar);
+    SCSS
+
+    it { should report_lint line: 1, count: 2 }
+  end
+
+  context 'when a variable definition uses parens' do
+    let(:scss) { <<-SCSS }
+      $family: unquote( "Droid+Sans" );
+      $family: unquote("Droid+Sans");
+    SCSS
+
+    it { should report_lint line: 1, count: 2 }
+  end
+
+  context 'when a variable definition is wrapped in parens' do
+    let(:scss) { <<-SCSS }
+      $value-map: (text: #00ff00, background: #0000ff, border: #ff0000);
+      $value-map: ( text: #00ff00, background: #0000ff, border: #ff0000 );
+    SCSS
+
+    it { should report_lint line: 2, count: 2 }
+  end
+
+  context 'when a url uses parens' do
+    let(:scss) { <<-SCSS }
+      p {
+        background-image: url( 'bg1.png' );
+      }
+
+      code {
+        background-image: url('bg2.png');
+      }
+    SCSS
+
+    it { should report_lint line: 2, count: 2 }
+  end
+
+  context 'when a @media directive uses parens' do
+    let(:scss) { <<-SCSS }
+      @media screen and (orientation: landscape) {
+        // Stuff.
+      }
+
+      @media screen and ( orientation: landscape ) {
+        // Stuff.
+      }
+    SCSS
+
+    it { should report_lint line: 5, count: 2 }
+  end
+
+  context 'when an @at-root directive uses parens' do
+    let(:scss) { <<-SCSS }
+      @media screen {
+        @at-root (without: media) {
+          // Stuff.
+        }
+        @at-root ( with: media ) {
+          // Stuff.
+        }
+      }
+    SCSS
+
+    it { should report_lint line: 5, count: 2 }
+  end
+
+  context 'when an @if directive uses parens' do
+    let(:scss) { <<-SCSS }
+      p {
+        @if (1 + 2 == 2) { border: 1px; }
+
+        @if ( 1 + 2 == 2 ) { border: 1px; }
+      }
+    SCSS
+
+    it { should report_lint line: 4, count: 2 }
+  end
+
+  context 'when an @each directive uses parens around a list' do
+    let(:scss) { <<-SCSS }
+      @each $animal in (puma, sea-slug, egret) {
+        // Stuff.
+      }
+
+      @each $animal in ( puma, sea-slug, egret ) {
+        // Stuff.
+      }
+    SCSS
+
+    it { should report_lint line: 5, count: 2 }
+  end
+
+  context 'when an @each directive uses parens' do
+    let(:scss) { <<-SCSS }
+      /*@each $color, $cursor in (black, default), (blue, pointer) {
+        // Stuff.
+      }*/
+
+      @each $color, $cursor in ( black, default ), ( blue, pointer ) {
+        // Stuff.
+      }
+    SCSS
+
+    it { should report_lint line: 5, count: 4 }
+  end
+
+  context 'when a @mixin uses parens' do
+    let(:scss) { <<-SCSS }
+      @mixin sexy-border($color, $width) {
+        // Stuff.
+      }
+
+      @mixin rockin-border( $color, $width ) {
+        // Stuff.
+      }
+    SCSS
+
+    it { should report_lint line: 5, count: 2 }
+  end
+
+  context 'when an @include uses parens' do
+    let(:scss) { <<-SCSS }
+      @mixin sexy-border($color, $width) {
+        // Stuff.
+      }
+
+      a { @include sexy-border(blue, 1in); }
+      p { @include sexy-border( blue, 1in ); }
+    SCSS
+
+    it { should report_lint line: 6, count: 2 }
+  end
+
+  context 'when a @function uses parens' do
+    let(:scss) { <<-SCSS }
+      @function grid-width($n) {
+        @return $n * 2;
+      }
+
+      @function grid-height( $n ) {
+        @return $n * 2;
+      }
+    SCSS
+
+    it { should report_lint line: 5, count: 2 }
+  end
+
   context 'when the number of spaces has been explicitly set' do
     let(:linter_config) { { 'spaces' => 1 } }
 
@@ -259,5 +433,25 @@ describe SCSSLint::Linter::SpaceBetweenParens do
 
       it { should_not report_lint }
     end
+
+    context 'when a 0-argument function has nothing between parens' do
+      let(:scss) { <<-SCSS }
+        p {
+          property: unique-id();
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when a 0-argument function has one space between parens' do
+      let(:scss) { <<-SCSS }
+        p {
+          property: unique-id( );
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
   end
 end

data/spec/scss_lint/linter/transition_all_spec.rb

@@ -0,0 +1,81 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::TransitionAll do
+  context 'when transition-property is not set' do
+    let(:scss) { <<-SCSS }
+      p {
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when transition-property is set to none' do
+    let(:scss) { <<-SCSS }
+      p {
+        transition-property: none;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when transition-property is not set to all' do
+    let(:scss) { <<-SCSS }
+      p {
+        transition-property: color;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when transition-property is set to all' do
+    let(:scss) { <<-SCSS }
+      p {
+        transition-property: all;
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when transition shorthand for transition-property is not set' do
+    let(:scss) { <<-SCSS }
+      p {
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when transition shorthand for transition-property is set to none' do
+    let(:scss) { <<-SCSS }
+      p {
+        transition: none;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when transition shorthand for transition-property is not set to all' do
+    let(:scss) { <<-SCSS }
+      p {
+        transition: color 1s linear;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when transition shorthand for transition-property is set to all' do
+    let(:scss) { <<-SCSS }
+      p {
+        transition: all 1s linear;
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+end