scss-lint 0.29.0 → 0.30.0

data/spec/scss_lint/linter/trailing_semicolon_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe SCSSLint::Linter::TrailingSemicolon do
@@ -206,6 +208,24 @@ describe SCSSLint::Linter::TrailingSemicolon do
     it { should_not report_lint }
   end
 
+  context 'when @import ends with a semicolon' do
+    let(:css) { '@import "something";' }
+
+    it { should_not report_lint }
+  end
+
+  context 'when @import does not end with a semicolon' do
+    let(:css) { '@import "something"' }
+
+    it { should report_lint line: 1 }
+  end
+
+  context 'when @import has a space before a semicolon' do
+    let(:css) { '@import "something" ;' }
+
+    it { should report_lint line: 1 }
+  end
+
   context 'when variable declaration does not end with a semicolon' do
     let(:css) { <<-CSS }
       .foo {
@@ -235,4 +255,31 @@ describe SCSSLint::Linter::TrailingSemicolon do
 
     it { should report_lint line: 2 }
   end
+
+  context 'when interpolation within single quotes is followed by property' do
+    context 'and property has a trailing semicolon' do
+      let(:css) { "[class~='\#{$test}'] { width: 100%; }" }
+
+      it { should_not report_lint }
+    end
+
+    context 'and property does not have a trailing semicolon' do
+      let(:css) { "[class~='\#{$test}'] { width : 100% }" }
+
+      it { should report_lint }
+    end
+  end
+
+  context 'when triggering a bug based on Windows IBM437 encoding' do
+    CSS = <<-CSS
+      @charset "UTF-8";
+
+      .foo:before {
+        content: '▼';
+      }
+    CSS
+    let(:css) { CSS.force_encoding('IBM437') }
+
+    it { should_not report_lint }
+  end
 end

data/spec/scss_lint/linter/vendor_prefixes_spec.rb

@@ -0,0 +1,350 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::VendorPrefixes do
+  context 'when no vendor-prefix is used' do
+    let(:css) { <<-CSS }
+      div {
+        transition: none;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a rule is empty' do
+    let(:css) { <<-CSS }
+      div {
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  # Properties
+
+  context 'when a vendor-prefixed listed property is used' do
+    let(:css) { <<-CSS }
+      div {
+        -webkit-transition: none;
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when an unprefixed listed property is used' do
+    let(:css) { <<-CSS }
+      div {
+        transition: none;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a vendor-prefixed unlisted property is used' do
+    let(:css) { <<-CSS }
+      div {
+        -webkit-appearance: none;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a vendor-prefixed custom-listed property is used' do
+    let(:linter_config) { { 'identifier_list' => ['transform'] } }
+
+    let(:css) { <<-CSS }
+      div {
+        -webkit-transform: none;
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a proprietary unlisted vendor-prefixed property is used' do
+    let(:css) { <<-CSS }
+      div {
+        -moz-padding-end: 0;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a proprietary listed vendor-prefixed property is used' do
+    let(:linter_config) { { 'identifier_list' => ['padding-end'] } }
+
+    let(:css) { <<-CSS }
+      div {
+        -moz-padding-end: 0;
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+  end
+
+  # Selectors
+
+  context 'when a vendor-prefixed listed selector is used' do
+    let(:css) { <<-CSS }
+      ::-moz-placeholder {
+        color: red;
+      }
+      :-ms-placeholder {
+        color: pink;
+      }
+      :-moz-fullscreen p {
+        font-size: 200%;
+      }
+    CSS
+
+    it { should report_lint line: 1 }
+    it { should report_lint line: 4 }
+    it { should report_lint line: 7 }
+  end
+
+  context 'when an unprefixed listed selector is used' do
+    let(:css) { <<-CSS }
+      ::placeholder {
+        color: red;
+      }
+      :fullscreen p {
+        font-size: 200%;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a vendor-prefixed unlisted selector is used' do
+    let(:linter_config) { { 'identifier_list' => ['transform'] } }
+
+    let(:css) { <<-CSS }
+      ::-moz-placeholder {
+        color: red;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a vendor-prefixed custom-listed selector is used' do
+    let(:linter_config) { { 'identifier_list' => ['placeholder'] } }
+
+    let(:css) { <<-CSS }
+      ::-moz-placeholder {
+        color: red;
+      }
+    CSS
+
+    it { should report_lint line: 1 }
+  end
+
+  # Directives
+
+  context 'when a vendor-prefixed listed directive is used' do
+    let(:css) { <<-CSS }
+      @-webkit-keyframes anim {
+        0% { opacity: 0; }
+      }
+    CSS
+
+    it { should report_lint line: 1 }
+  end
+
+  context 'when an unprefixed listed directive is used' do
+    let(:css) { <<-CSS }
+      @keyframes anim {
+        0% { opacity: 0; }
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when an vendor-prefixed unlisted directive is used' do
+    let(:linter_config) { { 'identifier_list' => ['placeholder'] } }
+
+    let(:css) { <<-CSS }
+      @-webkit-keyframes anim {
+        0% { opacity: 0; }
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when an vendor-prefixed custom-listed directive is used' do
+    let(:linter_config) { { 'identifier_list' => ['keyframes'] } }
+
+    let(:css) { <<-CSS }
+      @-webkit-keyframes anim {
+        0% { opacity: 0; }
+      }
+    CSS
+
+    it { should report_lint line: 1 }
+  end
+
+  # Values
+
+  context 'when a vendor-prefixed listed value is used' do
+    let(:css) { <<-CSS }
+      div {
+        background-image: -webkit-linear-gradient(#000, #fff);
+        position: -moz-sticky;
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+    it { should report_lint line: 3 }
+  end
+
+  context 'when an unprefixed listed value is used' do
+    let(:css) { <<-CSS }
+      div {
+        background-image: linear-gradient(#000, #fff);
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a vendor-unprefixed unlisted value is used' do
+    let(:linter_config) { { 'identifier_list' => ['keyframes'] } }
+
+    let(:css) { <<-CSS }
+      div {
+        background-image: -webkit-linear-gradient(#000, #fff);
+        position: -moz-sticky;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a vendor-unprefixed custom-listed value is used' do
+    let(:linter_config) { { 'identifier_list' => ['linear-gradient'] } }
+
+    let(:css) { <<-CSS }
+      div {
+        background-image: -webkit-linear-gradient(#000, #fff);
+        position: -moz-sticky;
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+  end
+
+  # Identifier lists
+
+  context 'when using non-default named identifier list' do
+    let(:linter_config) { { 'identifier_list' => 'bourbon' } }
+
+    context 'and a standard vendor-prefixed property is used' do
+      let(:css) { <<-CSS }
+        div {
+          background-image: -webkit-linear-gradient(#000, #fff);
+        }
+      CSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'and a list-specific vendor-prefixed property is used' do
+      let(:css) { <<-CSS }
+        div {
+          image-rendering: -moz-crisp-edges;
+          -webkit-appearance: none;
+        }
+      CSS
+
+      it { should report_lint line: 2 }
+      it { should report_lint line: 3 }
+    end
+
+    context 'and a list-exempt vendor-prefixed property is used' do
+      let(:css) { <<-CSS }
+        div {
+          -webkit-mask-repeat: inherit;
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+  end
+
+  # Excluding and Including
+
+  context 'when manually excluding identifiers' do
+    let(:linter_config) { { 'exclude' => %w[transform selection] } }
+
+    let(:css) { <<-CSS }
+      div {
+        -wekit-transform: translateZ(0);
+      }
+      ::-moz-selection {
+        color: #000;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when manually including identifiers' do
+    let(:linter_config) { { 'include' => ['padding-end'] } }
+
+    let(:css) { <<-CSS }
+      div {
+        -moz-padding-end: 0;
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+  end
+
+  # More
+  context 'when dealing with many-hyphened vendor-prefixed identifiers' do
+    let(:css) { <<-CSS }
+      div {
+        -moz-animation-timing-function: ease-out;
+        -webkit-border-bottom-right-radius: 5px;
+        background: -o-repeating-radial-gradient(#000, #000 5px, #fff 5px, #fff 10px)
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+    it { should report_lint line: 3 }
+    it { should report_lint line: 4 }
+  end
+
+  context 'when dealing with many-hyphened unprefixed identifiers' do
+    let(:css) { <<-CSS }
+      div {
+        animation-timing-function: ease-out;
+        border-bottom-right-radius: 5px;
+        background: repeating-radial-gradient(#000, #000 5px, #fff 5px, #fff 10px)
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when vendor-prefixed media queries are used' do
+    let(:css) { <<-CSS }
+    @media
+      only screen and (-webkit-min-device-pixel-ratio: 1.3),
+      only screen and (-o-min-device-pixel-ratio: 13/10),
+      only screen and (min-resolution: 120dpi) {
+        body {
+          background: #fff;
+        }
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: scss-lint
 version: !ruby/object:Gem::Version
-  version: 0.29.0
+  version: 0.30.0
 platform: ruby
 authors:
 - Causes Engineering
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-07 00:00:00.000000000 Z
+date: 2014-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rainbow
@@ -93,6 +93,8 @@ files:
 - config/default.yml
 - data/properties.txt
 - data/property-sort-orders/concentric.txt
+- data/prefixed-identifiers/base.txt
+- data/prefixed-identifiers/bourbon.txt
 - lib/scss_lint/version.rb
 - lib/scss_lint/constants.rb
 - lib/scss_lint/utils.rb
@@ -114,6 +116,7 @@ files:
 - lib/scss_lint/config.rb
 - lib/scss_lint/linter/compass.rb
 - lib/scss_lint/linter/space_after_comma.rb
+- lib/scss_lint/linter/nesting_depth.rb
 - lib/scss_lint/linter/trailing_zero.rb
 - lib/scss_lint/linter/space_before_brace.rb
 - lib/scss_lint/linter/hex_length.rb
@@ -122,13 +125,16 @@ files:
 - lib/scss_lint/linter/single_line_per_property.rb
 - lib/scss_lint/linter/shorthand.rb
 - lib/scss_lint/linter/final_newline.rb
+- lib/scss_lint/linter/import_path.rb
 - lib/scss_lint/linter/id_with_extraneous_selector.rb
 - lib/scss_lint/linter/empty_line_between_blocks.rb
+- lib/scss_lint/linter/bang_format.rb
 - lib/scss_lint/linter/declaration_order.rb
 - lib/scss_lint/linter/zero_unit.rb
 - lib/scss_lint/linter/placeholder_in_extend.rb
 - lib/scss_lint/linter/selector_depth.rb
 - lib/scss_lint/linter/else_placement.rb
+- lib/scss_lint/linter/qualifying_element.rb
 - lib/scss_lint/linter/selector_format.rb
 - lib/scss_lint/linter/hex_validation.rb
 - lib/scss_lint/linter/compass/property_with_mixin.rb
@@ -151,6 +157,7 @@ files:
 - lib/scss_lint/linter/comment.rb
 - lib/scss_lint/linter/empty_rule.rb
 - lib/scss_lint/linter/single_line_per_selector.rb
+- lib/scss_lint/linter/vendor_prefixes.rb
 - lib/scss_lint/linter/hex_notation.rb
 - lib/scss_lint/linter/url_format.rb
 - lib/scss_lint/cli.rb
@@ -172,10 +179,13 @@ files:
 - spec/scss_lint/cli_spec.rb
 - spec/scss_lint/linter/final_newline_spec.rb
 - spec/scss_lint/linter/color_keyword_spec.rb
+- spec/scss_lint/linter/import_path_spec.rb
 - spec/scss_lint/linter/single_line_per_selector_spec.rb
 - spec/scss_lint/linter/empty_rule_spec.rb
 - spec/scss_lint/linter/hex_notation_spec.rb
+- spec/scss_lint/linter/bang_format_spec.rb
 - spec/scss_lint/linter/hex_length_spec.rb
+- spec/scss_lint/linter/vendor_prefixes_spec.rb
 - spec/scss_lint/linter/url_quotes_spec.rb
 - spec/scss_lint/linter/space_between_parens_spec.rb
 - spec/scss_lint/linter/selector_format_spec.rb
@@ -183,6 +193,7 @@ files:
 - spec/scss_lint/linter/property_spelling_spec.rb
 - spec/scss_lint/linter/property_sort_order_spec.rb
 - spec/scss_lint/linter/else_placement_spec.rb
+- spec/scss_lint/linter/qualifying_element_spec.rb
 - spec/scss_lint/linter/zero_unit_spec.rb
 - spec/scss_lint/linter/mergeable_selector_spec.rb
 - spec/scss_lint/linter/unnecessary_mantissa_spec.rb
@@ -204,6 +215,7 @@ files:
 - spec/scss_lint/linter/trailing_zero_spec.rb
 - spec/scss_lint/linter/url_format_spec.rb
 - spec/scss_lint/linter/comment_spec.rb
+- spec/scss_lint/linter/nesting_depth_spec.rb
 - spec/scss_lint/linter/trailing_semicolon_spec.rb
 - spec/scss_lint/linter/selector_depth_spec.rb
 - spec/scss_lint/linter/space_after_comma_spec.rb
@@ -254,10 +266,13 @@ test_files:
 - spec/scss_lint/cli_spec.rb
 - spec/scss_lint/linter/final_newline_spec.rb
 - spec/scss_lint/linter/color_keyword_spec.rb
+- spec/scss_lint/linter/import_path_spec.rb
 - spec/scss_lint/linter/single_line_per_selector_spec.rb
 - spec/scss_lint/linter/empty_rule_spec.rb
 - spec/scss_lint/linter/hex_notation_spec.rb
+- spec/scss_lint/linter/bang_format_spec.rb
 - spec/scss_lint/linter/hex_length_spec.rb
+- spec/scss_lint/linter/vendor_prefixes_spec.rb
 - spec/scss_lint/linter/url_quotes_spec.rb
 - spec/scss_lint/linter/space_between_parens_spec.rb
 - spec/scss_lint/linter/selector_format_spec.rb
@@ -265,6 +280,7 @@ test_files:
 - spec/scss_lint/linter/property_spelling_spec.rb
 - spec/scss_lint/linter/property_sort_order_spec.rb
 - spec/scss_lint/linter/else_placement_spec.rb
+- spec/scss_lint/linter/qualifying_element_spec.rb
 - spec/scss_lint/linter/zero_unit_spec.rb
 - spec/scss_lint/linter/mergeable_selector_spec.rb
 - spec/scss_lint/linter/unnecessary_mantissa_spec.rb
@@ -286,6 +302,7 @@ test_files:
 - spec/scss_lint/linter/trailing_zero_spec.rb
 - spec/scss_lint/linter/url_format_spec.rb
 - spec/scss_lint/linter/comment_spec.rb
+- spec/scss_lint/linter/nesting_depth_spec.rb
 - spec/scss_lint/linter/trailing_semicolon_spec.rb
 - spec/scss_lint/linter/selector_depth_spec.rb
 - spec/scss_lint/linter/space_after_comma_spec.rb