scss-lint 0.29.0 → 0.30.0

data/spec/scss_lint/linter/import_path_spec.rb

@@ -0,0 +1,300 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::ImportPath do
+  context 'when the path includes no directories' do
+    context 'and the filename has no leading underscore or filename extension' do
+      let(:css) { '@import "filename";' }
+
+      it { should_not report_lint }
+    end
+
+    context 'and the filename has a leading underscore' do
+      let(:css) { '@import "_filename";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and the filename has a filename extension' do
+      let(:css) { '@import "filename.scss";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and the filename has a leading underscore and a filename extension' do
+      let(:css) { '@import "_filename.scss";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and multiple files are @imported' do
+      context 'and neither have leading underscores or filename extensions' do
+        let(:css) { '@import "foo", "bar";' }
+
+        it { should_not report_lint }
+      end
+
+      context 'and the second has a leading underscore' do
+        let(:css) { '@import "foo", "_bar";' }
+
+        it { should report_lint line: 1 }
+      end
+
+      context 'and the first has a filename extension' do
+        let(:css) { '@import "foo.scss", "bar";' }
+
+        it { should report_lint line: 1 }
+      end
+    end
+  end
+
+  context 'when the path includes directories' do
+    context 'and the filename has no leading underscore or filename extension' do
+      let(:css) { '@import "path/to/filename";' }
+
+      it { should_not report_lint }
+    end
+
+    context 'and the filename has a leading underscore' do
+      let(:css) { '@import "../to/_filename";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and the filename has a filename extension' do
+      let(:css) { '@import "/path/to/filename.scss";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and the filename has a leading underscore and a filename extension' do
+      let(:css) { '@import "path/to/_filename.scss";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and multiple files are @imported' do
+      context 'and neither have leading underscores or filename extensions' do
+        let(:css) { '@import "path/to/foo", "../../bar";' }
+
+        it { should_not report_lint }
+      end
+
+      context 'and the second has a leading underscore' do
+        let(:css) { '@import "path/to/foo", "../../_bar";' }
+
+        it { should report_lint line: 1 }
+      end
+
+      context 'and the first has a filename extension' do
+        let(:css) { '@import "path/to/foo.scss", "../../bar";' }
+
+        it { should report_lint line: 1 }
+      end
+    end
+  end
+
+  context 'when option `leading_underscore` is true' do
+    let(:linter_config) { { 'leading_underscore' => true } }
+
+    context 'and the filename has no leading underscore or filename extension' do
+      let(:css) { '@import "path/to/filename";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and the filename has a leading underscore' do
+      let(:css) { '@import "../to/_filename";' }
+
+      it { should_not report_lint }
+    end
+
+    context 'and the filename has a filename extension' do
+      let(:css) { '@import "/path/to/filename.scss";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and the filename has a leading underscore and a filename extension' do
+      let(:css) { '@import "path/to/_filename.scss";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and multiple files are @imported' do
+      context 'and neither have leading underscores or filename extensions' do
+        let(:css) { '@import "path/to/foo", "../../bar";' }
+
+        it { should report_lint line: 1 }
+      end
+
+      context 'and both have a leading underscore' do
+        let(:css) { '@import "path/to/_foo", "../../_bar";' }
+
+        it { should_not report_lint }
+      end
+
+      context 'and only one has a leading underscore' do
+        let(:css) { '@import "path/to/foo.scss", "../../_bar";' }
+
+        it { should report_lint line: 1 }
+      end
+    end
+  end
+
+  context 'when option `filename_extension` is true' do
+    let(:linter_config) { { 'filename_extension' => true } }
+
+    context 'and the filename has no leading underscore or filename extension' do
+      let(:css) { '@import "path/to/filename";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and the filename has a leading underscore' do
+      let(:css) { '@import "../to/_filename";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and the filename has a filename extension' do
+      let(:css) { '@import "/path/to/filename.scss";' }
+
+      it { should_not report_lint }
+    end
+
+    context 'and the filename has a leading underscore and a filename extension' do
+      let(:css) { '@import "path/to/_filename.scss";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and multiple files are @imported' do
+      context 'and neither have leading underscores or filename extensions' do
+        let(:css) { '@import "path/to/foo", "../../bar";' }
+
+        it { should report_lint line: 1 }
+      end
+
+      context 'and both have filename extensions' do
+        let(:css) { '@import "path/to/foo.scss", "../../bar.scss";' }
+
+        it { should_not report_lint }
+      end
+
+      context 'and only one has a filename extensions' do
+        let(:css) { '@import "path/to/foo.scss", "../../bar";' }
+
+        it { should report_lint line: 1 }
+      end
+    end
+  end
+
+  context 'when options `leading_underscore` and `filename_extension` are true' do
+    let(:linter_config) { { 'leading_underscore' => true, 'filename_extension' => true } }
+
+    context 'and the filename has no leading underscore or filename extension' do
+      let(:css) { '@import "path/to/filename";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and the filename has a leading underscore' do
+      let(:css) { '@import "../to/_filename";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and the filename has a filename extension' do
+      let(:css) { '@import "/path/to/filename.scss";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and the filename has a leading underscore and a filename extension' do
+      let(:css) { '@import "path/to/_filename.scss";' }
+
+      it { should_not report_lint }
+    end
+
+    context 'and multiple files are @imported' do
+      context 'and neither have leading underscores or filename extensions' do
+        let(:css) { '@import "path/to/foo", "../../bar";' }
+
+        it { should report_lint line: 1 }
+      end
+
+      context 'and both have filename extensions and leading underscores' do
+        let(:css) { '@import "path/to/_foo.scss", "../../_bar.scss";' }
+
+        it { should_not report_lint }
+      end
+
+      context 'and only one has both a filename extension and a leading underscore' do
+        let(:css) { '@import "path/to/_foo.scss", "../../bar.scss";' }
+
+        it { should report_lint line: 1 }
+      end
+    end
+  end
+
+  context 'when the @import directive compiles directly to a CSS @import rule' do
+    context 'and the @import is a CSS file' do
+      let(:css) { '@import "_foo.css";' }
+
+      it { should_not report_lint }
+    end
+
+    context 'and the @import contains a protocol' do
+      let(:css) { '@import "http://foo.com/_bar.css";' }
+
+      it { should_not report_lint }
+    end
+
+    context 'and the @import contains a media query' do
+      let(:css) { '@import "_foo.css" screen;' }
+
+      it { should_not report_lint }
+    end
+
+    context 'and the @import is a URL' do
+      let(:css) { '@import url(_foo.css);' }
+
+      it { should_not report_lint }
+    end
+
+    context 'and the @import contains interpolation' do
+      let(:css) { <<-CSS }
+        $family: unquote("Droid+Sans");
+        @import url("http://fonts.googleapis.com/css?family=\#{$family}");
+      CSS
+
+      it { should_not report_lint }
+    end
+  end
+
+  context 'when the partial has the same name as its directory' do
+    context 'and the filename has no leading underscore or filename extension' do
+      let(:css) { '@import "foo/foo";' }
+
+      it { should_not report_lint }
+    end
+
+    context 'and the filename has a leading underscore' do
+      let(:css) { '@import "_foo/_foo";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and the filename has a filename extension' do
+      let(:css) { '@import "foo/foo.scss";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and the filename has a leading underscore and a filename extension' do
+      let(:css) { '@import "_foo/_foo.scss";' }
+
+      it { should report_lint line: 1 }
+    end
+  end
+end

data/spec/scss_lint/linter/nesting_depth_spec.rb

@@ -0,0 +1,114 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::NestingDepth do
+  context 'and selectors are nested up to depth 3' do
+    let(:css) { <<-CSS }
+      .one {
+        .two {
+          .three {
+            background: #f00;
+          }
+        }
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'and selectors are nested greater than depth 3' do
+    let(:css) { <<-CSS }
+      .one {
+        .two {
+          .three {
+            .four {
+              background: #f00;
+            }
+            .four-other {
+              background: #f00;
+            }
+          }
+        }
+      }
+    CSS
+
+    it { should report_lint line: 4 }
+    it { should report_lint line: 7 }
+  end
+
+  context 'when max_depth is set to 1' do
+    let(:linter_config) { { 'max_depth' => 1 } }
+
+    context 'when nesting has a depth of one' do
+      let(:css) { <<-CSS }
+        .one {
+          font-style: italic;
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when nesting has a depth of two' do
+      let(:css) { <<-CSS }
+        .one {
+          .two {
+            font-style: italic;
+          }
+        }
+        .one {
+          font-style: italic;
+        }
+      CSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when nesting has a depth of three' do
+      let(:css) { <<-CSS }
+        .one {
+          .two {
+            .three {
+              background: #f00;
+            }
+          }
+          .two-other {
+            font-style: italic;
+          }
+        }
+      CSS
+
+      it { should report_lint line: 2 }
+      it { should report_lint line: 7 }
+      it { should_not report_lint line: 3 }
+    end
+
+    context 'when nesting properties' do
+      let(:css) { <<-CSS }
+        .one {
+          font: {
+            family: monospace;
+            style: italic;
+          }
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when sequence contains a @keyframe' do
+      let(:css) { <<-CSS }
+        @keyframe my-keyframe {
+          0% {
+            background: #000;
+          }
+
+          50% {
+            background: #fff;
+          }
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+  end
+end

data/spec/scss_lint/linter/property_spelling_spec.rb

@@ -54,4 +54,31 @@ describe SCSSLint::Linter::PropertySpelling do
       it { should_not report_lint }
     end
   end
+
+  context 'with valid nested properties' do
+    let(:css) { <<-CSS }
+      p {
+        text: {
+          align: center;
+          transform: uppercase;
+        }
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'with invalid nested properties' do
+    let(:css) { <<-CSS }
+      p {
+        text: {
+          aligned: center;
+          transformed: uppercase;
+        }
+      }
+    CSS
+
+    it { should report_lint line: 3 }
+    it { should report_lint line: 4 }
+  end
 end

data/spec/scss_lint/linter/qualifying_element_spec.rb

@@ -0,0 +1,125 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::QualifyingElement do
+  context 'when selector does not include an element' do
+    let(:css) { <<-CSS }
+      .foo {}
+      #bar {}
+      [foobar] {}
+      .foo .bar {}
+      #bar > .foo {}
+      [foobar] #bar .foo {}
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when selector includes an element' do
+    context 'and element does not qualify' do
+      let(:css) { <<-CSS }
+        ul {}
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'and element qualifies class' do
+      let(:css) { <<-CSS }
+        ul.list {}
+      CSS
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and element qualifies attribute' do
+      let(:css) { <<-CSS }
+        a[href] {}
+      CSS
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and element qualifies id' do
+      let(:css) { <<-CSS }
+        ul#list {}
+      CSS
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and selector is in a group' do
+      context 'and element does not qualify' do
+        let(:css) { <<-CSS }
+          .list li,
+          .item > span {}
+        CSS
+
+        it { should_not report_lint }
+      end
+
+      context 'and element qualifies class' do
+        let(:css) { <<-CSS }
+          .item span,
+          ul > li.item {}
+        CSS
+
+        it { should report_lint line: 1 }
+      end
+
+      context 'and element qualifies attribute' do
+        let(:css) { <<-CSS }
+          .item + span,
+          li a[href] {}
+        CSS
+
+        it { should report_lint line: 1 }
+      end
+
+      context 'and element qualifies id' do
+        let(:css) { <<-CSS }
+          #foo,
+          li#item + li {}
+        CSS
+
+        it { should report_lint line: 1 }
+      end
+    end
+
+    context 'and selector involves a combinator' do
+      context 'and element does not qualify' do
+        let(:css) { <<-CSS }
+          .list li {}
+          .list > li {}
+          .item + li {}
+          .item ~ li {}
+        CSS
+
+        it { should_not report_lint }
+      end
+
+      context 'and element qualifies class' do
+        let(:css) { <<-CSS }
+          ul > li.item {}
+        CSS
+
+        it { should report_lint line: 1 }
+      end
+
+      context 'and element qualifies attribute' do
+        let(:css) { <<-CSS }
+          li a[href] {}
+        CSS
+
+        it { should report_lint line: 1 }
+      end
+
+      context 'and element qualifies id' do
+        let(:css) { <<-CSS }
+          li#item + li {}
+        CSS
+
+        it { should report_lint line: 1 }
+      end
+    end
+  end
+end