schema_plus_views 0.3.1 → 1.0.0

data/spec/migration_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 class Item < ActiveRecord::Base
@@ -13,100 +15,148 @@ describe "Migration" do
 
   let(:migration) { ActiveRecord::Migration }
   let(:connection) { ActiveRecord::Base.connection }
-  let(:schema) { ActiveRecord::Schema }
 
   before(:each) do
     define_schema_and_data
   end
 
-  context "creation" do
-    it "should create correct views" do
-      expect(AOnes.all.collect(&:s)).to eq(%W[one_one one_two])
-      expect(ABOnes.all.collect(&:s)).to eq(%W[one_one])
+  shared_examples 'view checks' do |options = {}|
+    context "creation" do
+      it "should create correct views" do
+        expect(AOnes.all.collect(&:s)).to eq(%W[one_one one_two])
+        expect(ABOnes.all.collect(&:s)).to eq(%W[one_one])
+      end
     end
-  end
 
-  context "duplicate creation" do
-    before(:each) do
-      migration.create_view('dupe_me', 'SELECT * FROM items WHERE (a=1)')
-    end
+    context "duplicate creation" do
+      before(:each) do
+        migration.create_view('dupe_me', 'SELECT * FROM items WHERE (a=1)', options)
+      end
 
-    it "should raise an error by default" do
-      expect {migration.create_view('dupe_me', 'SELECT * FROM items WHERE (a=2)')}.to raise_error ActiveRecord::StatementInvalid
-    end
+      it "should raise an error by default" do
+        expect { migration.create_view('dupe_me', 'SELECT * FROM items WHERE (a=2)', options) }.to raise_error ActiveRecord::StatementInvalid
+      end
 
-    it "should override existing definition if :force true" do
-      migration.create_view('dupe_me', 'SELECT * FROM items WHERE (a=2)', :force => true)
-      expect(connection.view_definition('dupe_me')).to match(%r{WHERE .*a.*=.*2}i)
-    end
- 
-    context "Postgres and MySQL only", :sqlite3 => :skip do
-      it "should override existing definition if :allow_replace is true" do
-        migration.create_view('dupe_me', 'SELECT * FROM items WHERE (a=2)', :allow_replace => true)
+      it "should override existing definition if :force true" do
+        migration.create_view('dupe_me', 'SELECT * FROM items WHERE (a=2)', options.merge(force: true))
         expect(connection.view_definition('dupe_me')).to match(%r{WHERE .*a.*=.*2}i)
       end
-    end
-  end
 
-  context "dropping" do
-    it "should raise an error if the view doesn't exist" do
-      expect { migration.drop_view('doesnt_exist') }.to raise_error ActiveRecord::StatementInvalid
+      unless options[:materialized]
+        context "Postgres and MySQL only", :sqlite3 => :skip do
+          it "should override existing definition if :allow_replace is true" do
+            migration.create_view('dupe_me', 'SELECT * FROM items WHERE (a=2)', options.merge(allow_replace: true))
+            expect(connection.view_definition('dupe_me')).to match(%r{WHERE .*a.*=.*2}i)
+          end
+        end
+      end
     end
 
-    it "should fail silently when using if_exists option" do
-      expect { migration.drop_view('doesnt_exist', :if_exists => true) }.not_to raise_error
+    context "dropping" do
+      it "should raise an error if the view doesn't exist" do
+        expect { migration.drop_view('doesnt_exist', options) }.to raise_error ActiveRecord::StatementInvalid
+      end
+
+      it "should fail silently when using if_exists option" do
+        expect { migration.drop_view('doesnt_exist', options.merge(if_exists: true)) }.not_to raise_error
+      end
+
+      context "with a view that exists" do
+        before { migration.create_view('view_that_exists', 'SELECT * FROM items WHERE (a=1)', options) }
+
+        it "should succeed" do
+          migration.drop_view('view_that_exists', options)
+          expect(connection.views).not_to include('view_that_exists')
+        end
+      end
     end
 
-    context "with a view that exists" do
-      before { migration.create_view('view_that_exists', 'SELECT * FROM items WHERE (a=1)') }
+    describe "rollback" do
+      it "properly rolls back a create_view" do
+        m = build_migration do
+          define_method(:change) {
+            create_view :copy, "SELECT * FROM items", options
+          }
+        end
+        m.migrate(:up)
+        expect(connection.views).to include("copy")
+        m.migrate(:down)
+        expect(connection.views).not_to include("copy")
+      end
 
-      it "should succeed" do
-        migration.drop_view('view_that_exists')
-        expect(connection.views).not_to include('view_that_exists')
+      it "raises error for drop_view" do
+        m = build_migration do
+          define_method(:change) {
+            drop_view :a_ones, options
+          }
+        end
+        expect { m.migrate(:down) }.to raise_error(::ActiveRecord::IrreversibleMigration)
       end
     end
   end
 
-  describe "rollback" do
-    it "properly rolls back a create_view" do
-      m = Class.new ::ActiveRecord::Migration do
-        define_method(:change) {
-          create_view :copy, "SELECT * FROM items"
-        }
+  describe 'regular views' do
+    before(:each) do
+      apply_migration do
+        create_view :a_ones, Item.select('b, s').where(:a => 1)
+        create_view :ab_ones, "select s from a_ones where b = 1"
       end
-      m.migrate(:up)
-      expect(connection.views).to include("copy")
-      m.migrate(:down)
-      expect(connection.views).not_to include("copy")
     end
 
-    it "raises error for drop_view" do
-      m = Class.new ::ActiveRecord::Migration do
-        define_method(:change) {
-          drop_view :a_ones
-        }
+    include_examples 'view checks'
+  end
+
+  describe 'materialized views', postgresql: :only do
+    before(:each) do
+      apply_migration do
+        create_view :a_ones, Item.select('b, s').where(:a => 1), materialized: true
+        create_view :ab_ones, "select s from items where a = 1 AND b = 1", materialized: true
       end
-      expect { m.migrate(:down) }.to raise_error(::ActiveRecord::IrreversibleMigration)
     end
-  end
 
+    include_examples 'view checks', materialized: true
+
+    describe 'refreshing the view' do
+      it "refreshes the view" do
+        expect(AOnes.count).to eq(2)
+        Item.create!(a: 1, b: 3, s: 'one_three')
+        expect(AOnes.count).to eq(2)
+        connection.refresh_view('a_ones')
+        expect(AOnes.count).to eq(3)
+      end
+    end
+
+    context 'with indexes' do
+      it 'allows creating indexes on the materialized view' do
+        apply_migration do
+          add_index :a_ones, :s
+          add_index :a_ones, :b, unique: true
+        end
+
+        expect(connection.indexes(:a_ones)).to contain_exactly(
+                                                 have_attributes(columns: ['s'], unique: false),
+                                                 have_attributes(columns: ['b'], unique: true)
+                                               )
+      end
+    end
+  end
 
   protected
 
   def define_schema_and_data
-    connection.views.each do |view| connection.drop_view view end
-    connection.tables.each do |table| connection.drop_table table, cascade: true end
-
-    schema.define do
+    connection.views.each do |view|
+      connection.drop_view view
+    end
+    connection.tables.each do |table|
+      connection.drop_table table, cascade: true
+    end
 
+    apply_migration do
       create_table :items, :force => true do |t|
         t.integer :a
         t.integer :b
-        t.string  :s
+        t.string :s
       end
-
-      create_view :a_ones, Item.select('b, s').where(:a => 1)
-      create_view :ab_ones, "select s from a_ones where b = 1"
     end
     connection.execute "insert into items (a, b, s) values (1, 1, 'one_one')"
     connection.execute "insert into items (a, b, s) values (1, 2, 'one_two')"

data/spec/named_schemas_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe "with multiple schemas" do
@@ -6,10 +8,10 @@ describe "with multiple schemas" do
   end
 
   before(:each) do
-    newdb = case connection.adapter_name
-            when /^mysql/i then      "CREATE SCHEMA IF NOT EXISTS schema_plus_views_test2"
-            when /^postgresql/i then "CREATE SCHEMA schema_plus_views_test2"
-            when /^sqlite/i then     "ATTACH ':memory:' AS schema_plus_views_test2"
+    newdb = case 
+            when SchemaDev::Rspec::Helpers.mysql? then      "CREATE SCHEMA IF NOT EXISTS schema_plus_views_test2"
+            when SchemaDev::Rspec::Helpers.postgresql? then "CREATE SCHEMA schema_plus_views_test2"
+            when SchemaDev::Rspec::Helpers.sqlite3? then    "ATTACH ':memory:' AS schema_plus_views_test2"
             end
     begin
       ActiveRecord::Base.connection.execute newdb
@@ -28,10 +30,10 @@ describe "with multiple schemas" do
     end
 
     connection.execute 'DROP TABLE IF EXISTS schema_plus_views_test2.users'
-    connection.execute 'CREATE TABLE schema_plus_views_test2.users (id ' + case connection.adapter_name
-          when /^mysql/i then      "integer primary key auto_increment"
-          when /^postgresql/i then "serial primary key"
-          when /^sqlite/i then     "integer primary key autoincrement"
+    connection.execute 'CREATE TABLE schema_plus_views_test2.users (id ' + case
+          when SchemaDev::Rspec::Helpers.mysql? then      "integer primary key auto_increment"
+          when SchemaDev::Rspec::Helpers.postgresql? then "serial primary key"
+          when SchemaDev::Rspec::Helpers.sqlite3? then    "integer primary key autoincrement"
           end + ", login varchar(255))"
   end
 
@@ -60,38 +62,4 @@ describe "with multiple schemas" do
     end
   end
 
-  context "when using PostGIS", :postgresql => :only do
-    before(:all) do
-      begin
-        connection.execute "CREATE SCHEMA postgis"
-      rescue ActiveRecord::StatementInvalid => e
-        raise unless e.message =~ /already exists/
-      end
-    end
-
-    around(:each) do |example|
-      begin
-        connection.execute "SET search_path to '$user','public','postgis'"
-        example.run
-      ensure
-        connection.execute "SET search_path to '$user','public'"
-      end
-    end
-
-    before(:each) do
-      allow(connection).to receive(:adapter_name).and_return('PostGIS')
-    end
-
-    it "should hide views in postgis schema" do
-      begin
-        connection.create_view "postgis.hidden", "select 1", :force => true
-        connection.create_view :myview, "select 2", :force => true
-        expect(connection.views).to eq(["myview"])
-      ensure
-        connection.execute 'DROP VIEW postgis.hidden' rescue nil
-        connection.execute 'DROP VIEW myview' rescue nil
-      end
-    end
-  end
-
 end

data/spec/sanity_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 

data/spec/spec_helper.rb

@@ -1,6 +1,7 @@
+# frozen_string_literal: true
+
 require 'simplecov'
-require 'simplecov-gem-profile'
-SimpleCov.start "gem"
+SimpleCov.start
 
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
@@ -12,7 +13,7 @@ require 'schema_dev/rspec'
 
 SchemaDev::Rspec.setup
 
-Dir[File.dirname(__FILE__) + "/support/**/*.rb"].each {|f| require f}
+Dir[File.dirname(__FILE__) + "/support/**/*.rb"].each { |f| require f }
 
 RSpec.configure do |config|
   config.warnings = true
@@ -29,4 +30,16 @@ RSpec.configure do |config|
   end
 end
 
+def apply_migration(config = {}, &block)
+  ActiveRecord::Schema.define do
+    instance_eval &block
+  end
+end
+
+def build_migration(version: 5.0, &block)
+  Class.new(::ActiveRecord::Migration[version]) do
+    instance_eval &block
+  end
+end
+
 SimpleCov.command_name "[ruby #{RUBY_VERSION} - ActiveRecord #{::ActiveRecord::VERSION::STRING} - #{ActiveRecord::Base.connection.adapter_name}]"

metadata

@@ -1,71 +1,77 @@
 --- !ruby/object:Gem::Specification
 name: schema_plus_views
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 1.0.0
 platform: ruby
 authors:
 - ronen barzel
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2016-03-24 00:00:00.000000000 Z
+date: 2022-05-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '5.2'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '6.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '5.2'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '6.1'
 - !ruby/object:Gem::Dependency
   name: schema_plus_core
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -86,60 +92,37 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.6'
+        version: '4.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.6'
-- !ruby/object:Gem::Dependency
-  name: simplecov
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: simplecov-gem-profile
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-description: 
+        version: '4.1'
+description:
 email:
 - ronen@barzel.org
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/prs.yml"
 - ".gitignore"
-- ".travis.yml"
+- ".simplecov"
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
 - gemfiles/Gemfile.base
-- gemfiles/activerecord-4.2/Gemfile.base
-- gemfiles/activerecord-4.2/Gemfile.mysql2
-- gemfiles/activerecord-4.2/Gemfile.postgresql
-- gemfiles/activerecord-4.2/Gemfile.sqlite3
+- gemfiles/activerecord-5.2/Gemfile.base
+- gemfiles/activerecord-5.2/Gemfile.mysql2
+- gemfiles/activerecord-5.2/Gemfile.postgresql
+- gemfiles/activerecord-5.2/Gemfile.sqlite3
+- gemfiles/activerecord-6.0/Gemfile.base
+- gemfiles/activerecord-6.0/Gemfile.mysql2
+- gemfiles/activerecord-6.0/Gemfile.postgresql
+- gemfiles/activerecord-6.0/Gemfile.sqlite3
 - lib/schema_plus/views.rb
 - lib/schema_plus/views/active_record/connection_adapters/abstract_adapter.rb
 - lib/schema_plus/views/active_record/connection_adapters/mysql2_adapter.rb
@@ -147,6 +130,7 @@ files:
 - lib/schema_plus/views/active_record/connection_adapters/sqlite3_adapter.rb
 - lib/schema_plus/views/active_record/migration/command_recorder.rb
 - lib/schema_plus/views/middleware.rb
+- lib/schema_plus/views/schema_dump.rb
 - lib/schema_plus/views/version.rb
 - lib/schema_plus_views.rb
 - schema_dev.yml
@@ -162,7 +146,7 @@ homepage: https://github.com/SchemaPlus/schema_plus_views
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -170,16 +154,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.2.2
-signing_key: 
+rubygems_version: 3.0.8
+signing_key:
 specification_version: 4
 summary: Adds support for views to ActiveRecord
 test_files:

data/.travis.yml

@@ -1,18 +0,0 @@
-# This file was auto-generated by the schema_dev tool, based on the data in
-#                 ./schema_dev.yml
-# Please do not edit this file; any changes will be overwritten next time
-# schema_dev gets run.
----
-sudo: false
-rvm:
-- 2.1.5
-gemfile:
-- gemfiles/activerecord-4.2/Gemfile.mysql2
-- gemfiles/activerecord-4.2/Gemfile.postgresql
-- gemfiles/activerecord-4.2/Gemfile.sqlite3
-env: POSTGRESQL_DB_USER=postgres MYSQL_DB_USER=travis
-addons:
-  postgresql: '9.4'
-before_script: bundle exec rake create_databases
-after_script: bundle exec rake drop_databases
-script: bundle exec rake travis

data/gemfiles/activerecord-4.2/Gemfile.base

@@ -1,3 +0,0 @@
-eval File.read File.expand_path('../../Gemfile.base', __FILE__)
-
-gem "activerecord", "~> 4.2.6"

data/gemfiles/activerecord-4.2/Gemfile.mysql2

@@ -1,10 +0,0 @@
-require "pathname"
-eval(Pathname.new(__FILE__).dirname.join("Gemfile.base").read, binding)
-
-platform :ruby do
-  gem "mysql2", '>= 0.3.18', '< 0.5'
-end
-
-platform :jruby do
-  gem 'activerecord-jdbcmysql-adapter'
-end

data/gemfiles/activerecord-4.2/Gemfile.postgresql

@@ -1,10 +0,0 @@
-require "pathname"
-eval(Pathname.new(__FILE__).dirname.join("Gemfile.base").read, binding)
-
-platform :ruby do
-  gem "pg"
-end
-
-platform :jruby do
-  gem 'activerecord-jdbcpostgresql-adapter'
-end