schema_plus_views 0.3.1 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: af2a18ccfac25ea4e3e6f15ee3955625ea1392c5
-  data.tar.gz: 9093bc5d4b94ca74b452a64a4be17ecbca2803ef
+SHA256:
+  metadata.gz: b6dc17514d0000f4bdfee9c6840afec09ce47fa0635d89cefbc82667f197b904
+  data.tar.gz: b12b99196f5d28b120e97aae3bd7bfc698a7e004439b6e0538ffbc2c079ecd13
 SHA512:
-  metadata.gz: 06efc28124b8d57232e72076b9f134a3f3699f8cccc4e3bf480e261026e32af33a3a3e4808ae7aa869cae3d45900ba8a56fc8de1dabfeadc72fb58c12b188e7d
-  data.tar.gz: b3456b0c828d5fb09b7ae30b9a2e5af9ddec51a4175475fbc2220ddc0378c412c459fdccf66c8bb5efb365c3da7222629db16dc7644082817341a12e1d0eaf9b
+  metadata.gz: 03666f035ea72b9f03a6ff2d20321adb8a1adb7e0c13682229e3f9f52e7c94876408e9597eb4c42c8b6eac5ae6c046c826d3cc7daa8ed2ab4b4afbf00326ba82
+  data.tar.gz: 192ccf942b56d1d09409895d7b9c9eb9693ec30fa497ddad80ec5114c0090f4d13a6db37ea070b3df124bd1e65af5d8069a2fcf76b56206aa0436745568a8d4f

data/.github/workflows/prs.yml

@@ -0,0 +1,194 @@
+# This file was auto-generated by the schema_dev tool, based on the data in
+#                 ./schema_dev.yml
+# Please do not edit this file; any changes will be overwritten next time
+# schema_dev gets run.
+---
+name: CI PR Builds
+'on':
+  push:
+    branches:
+    - master
+  pull_request:
+concurrency:
+  group: ci-${{ github.ref }}
+  cancel-in-progress: true
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby:
+        - '2.5'
+        - '2.7'
+        - '3.0'
+        activerecord:
+        - '5.2'
+        - '6.0'
+        db:
+        - mysql2
+        - sqlite3
+        - skip
+        dbversion:
+        - skip
+        exclude:
+        - ruby: '3.0'
+          activerecord: '5.2'
+        - db: skip
+          dbversion: skip
+        include:
+        - ruby: '2.5'
+          activerecord: '5.2'
+          db: postgresql
+          dbversion: '9.6'
+        - ruby: '2.5'
+          activerecord: '5.2'
+          db: postgresql
+          dbversion: '10'
+        - ruby: '2.5'
+          activerecord: '5.2'
+          db: postgresql
+          dbversion: '11'
+        - ruby: '2.5'
+          activerecord: '5.2'
+          db: postgresql
+          dbversion: '12'
+        - ruby: '2.5'
+          activerecord: '6.0'
+          db: postgresql
+          dbversion: '9.6'
+        - ruby: '2.5'
+          activerecord: '6.0'
+          db: postgresql
+          dbversion: '10'
+        - ruby: '2.5'
+          activerecord: '6.0'
+          db: postgresql
+          dbversion: '11'
+        - ruby: '2.5'
+          activerecord: '6.0'
+          db: postgresql
+          dbversion: '12'
+        - ruby: '2.7'
+          activerecord: '5.2'
+          db: postgresql
+          dbversion: '9.6'
+        - ruby: '2.7'
+          activerecord: '5.2'
+          db: postgresql
+          dbversion: '10'
+        - ruby: '2.7'
+          activerecord: '5.2'
+          db: postgresql
+          dbversion: '11'
+        - ruby: '2.7'
+          activerecord: '5.2'
+          db: postgresql
+          dbversion: '12'
+        - ruby: '2.7'
+          activerecord: '6.0'
+          db: postgresql
+          dbversion: '9.6'
+        - ruby: '2.7'
+          activerecord: '6.0'
+          db: postgresql
+          dbversion: '10'
+        - ruby: '2.7'
+          activerecord: '6.0'
+          db: postgresql
+          dbversion: '11'
+        - ruby: '2.7'
+          activerecord: '6.0'
+          db: postgresql
+          dbversion: '12'
+        - ruby: '3.0'
+          activerecord: '6.0'
+          db: postgresql
+          dbversion: '9.6'
+        - ruby: '3.0'
+          activerecord: '6.0'
+          db: postgresql
+          dbversion: '10'
+        - ruby: '3.0'
+          activerecord: '6.0'
+          db: postgresql
+          dbversion: '11'
+        - ruby: '3.0'
+          activerecord: '6.0'
+          db: postgresql
+          dbversion: '12'
+    env:
+      BUNDLE_GEMFILE: "${{ github.workspace }}/gemfiles/activerecord-${{ matrix.activerecord }}/Gemfile.${{ matrix.db }}"
+      MYSQL_DB_HOST: 127.0.0.1
+      MYSQL_DB_USER: root
+      MYSQL_DB_PASS: database
+      POSTGRESQL_DB_HOST: 127.0.0.1
+      POSTGRESQL_DB_USER: schema_plus_test
+      POSTGRESQL_DB_PASS: database
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: "${{ matrix.ruby }}"
+        bundler-cache: true
+    - name: Run bundle update
+      run: bundle update
+    - name: Start Mysql
+      if: matrix.db == 'mysql2'
+      run: |
+        docker run --rm --detach \
+          -e MYSQL_ROOT_PASSWORD=$MYSQL_DB_PASS \
+          -p 3306:3306 \
+          --health-cmd "mysqladmin ping --host=127.0.0.1 --password=$MYSQL_DB_PASS --silent" \
+          --health-interval 5s \
+          --health-timeout 5s \
+          --health-retries 5 \
+          --name database mysql:5.6
+    - name: Start Postgresql
+      if: matrix.db == 'postgresql'
+      run: |
+        docker run --rm --detach \
+          -e POSTGRES_USER=$POSTGRESQL_DB_USER \
+          -e POSTGRES_PASSWORD=$POSTGRESQL_DB_PASS \
+          -p 5432:5432 \
+          --health-cmd "pg_isready -q" \
+          --health-interval 5s \
+          --health-timeout 5s \
+          --health-retries 5 \
+          --name database postgres:${{ matrix.dbversion }}
+    - name: Wait for database to start
+      if: "(matrix.db == 'postgresql' || matrix.db == 'mysql2')"
+      run: |
+        COUNT=0
+        ATTEMPTS=20
+        until [[ $COUNT -eq $ATTEMPTS ]]; do
+          [ "$(docker inspect -f {{.State.Health.Status}} database)" == "healthy" ] && break
+          echo $(( COUNT++ )) > /dev/null
+          sleep 2
+        done
+    - name: Create testing database
+      if: "(matrix.db == 'postgresql' || matrix.db == 'mysql2')"
+      run: bundle exec rake create_ci_database
+    - name: Run tests
+      run: bundle exec rake spec
+    - name: Shutdown database
+      if: always() && (matrix.db == 'postgresql' || matrix.db == 'mysql2')
+      run: docker stop database
+    - name: Coveralls Parallel
+      if: "${{ !env.ACT }}"
+      uses: coverallsapp/github-action@master
+      with:
+        github-token: "${{ secrets.GITHUB_TOKEN }}"
+        flag-name: run-${{ matrix.ruby }}-${{ matrix.activerecord }}-${{ matrix.db }}-${{ matrix.dbversion }}
+        parallel: true
+  finish:
+    needs: test
+    runs-on: ubuntu-latest
+    steps:
+    - name: Coveralls Finished
+      if: "${{ !env.ACT }}"
+      uses: coverallsapp/github-action@master
+      with:
+        github-token: "${{ secrets.GITHUB_TOKEN }}"
+        parallel-finished: true

data/.gitignore

@@ -2,6 +2,7 @@
 /tmp
 /pkg
 /Gemfile.local
+/.idea
 
 *.lock
 *.log

data/.simplecov

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+SimpleCov.configure do
+  enable_coverage :branch
+  add_filter '/spec/'
+
+  add_group 'Binaries', '/bin/'
+  add_group 'Libraries', '/lib/'
+
+  if ENV['CI']
+    require 'simplecov-lcov'
+
+    SimpleCov::Formatter::LcovFormatter.config do |c|
+      c.report_with_single_file = true
+      c.single_report_path = 'coverage/lcov.info'
+    end
+
+    formatter SimpleCov::Formatter::LcovFormatter
+  end
+end

data/Gemfile

@@ -1,5 +1,8 @@
+# frozen_string_literal: true
+
 source "http://rubygems.org"
 
 gemspec
 
-File.exist?(gemfile_local = File.expand_path('../Gemfile.local', __FILE__)) and eval File.read(gemfile_local), binding, gemfile_local
+gemfile_local = File.expand_path '../Gemfile.local', __FILE__
+eval File.read(gemfile_local), binding, gemfile_local if File.exist? gemfile_local

data/README.md

@@ -1,7 +1,6 @@
 [![Gem Version](https://badge.fury.io/rb/schema_plus_views.svg)](http://badge.fury.io/rb/schema_plus_views)
-[![Build Status](https://secure.travis-ci.org/SchemaPlus/schema_plus_views.svg)](http://travis-ci.org/SchemaPlus/schema_plus_views)
-[![Coverage Status](https://img.shields.io/coveralls/SchemaPlus/schema_plus_views.svg)](https://coveralls.io/r/SchemaPlus/schema_plus_views)
-[![Dependency Status](https://gemnasium.com/lomba/schema_plus_views.svg)](https://gemnasium.com/SchemaPlus/schema_plus_views)
+[![Build Status](https://github.com/SchemaPlus/schema_plus_views/actions/workflows/pr.yml/badge.svg)](http://github.com/SchemaPlus/schema_plus_views/actions)
+[![Coverage Status](https://coveralls.io/github/SchemaPlus/schema_plus_views/badge.svg)](https://coveralls.io/github/SchemaPlus/schema_plus_views)
 
 # SchemaPlus::Views
 
@@ -28,7 +27,11 @@ SchemaPlus::Views is tested on:
 
 <!-- SCHEMA_DEV: MATRIX - begin -->
 <!-- These lines are auto-generated by schema_dev based on schema_dev.yml -->
-* ruby **2.1.5** with activerecord **4.2**, using **mysql2**, **sqlite3** or **postgresql**
+* ruby **2.5** with activerecord **5.2**, using **mysql2**, **sqlite3**, **postgresql:9.6**, **postgresql:10**, **postgresql:11** or **postgresql:12**
+* ruby **2.5** with activerecord **6.0**, using **mysql2**, **sqlite3**, **postgresql:9.6**, **postgresql:10**, **postgresql:11** or **postgresql:12**
+* ruby **2.7** with activerecord **5.2**, using **mysql2**, **sqlite3**, **postgresql:9.6**, **postgresql:10**, **postgresql:11** or **postgresql:12**
+* ruby **2.7** with activerecord **6.0**, using **mysql2**, **sqlite3**, **postgresql:9.6**, **postgresql:10**, **postgresql:11** or **postgresql:12**
+* ruby **3.0** with activerecord **6.0**, using **mysql2**, **sqlite3**, **postgresql:9.6**, **postgresql:10**, **postgresql:11** or **postgresql:12**
 
 <!-- SCHEMA_DEV: MATRIX - end -->
 
@@ -56,8 +59,30 @@ Additional options can be provided:
 
 * `:allow_replace => true` will use the command "CREATE OR REPLACE" when creating the view, for seamlessly redefining the view even if other views depend on it.  It's only supported by MySQL and PostgreSQL, and each has some limitations on when a view can be replaced; see their docs for details.
 
+* `:materialized => true` will create a materialized view instead of a standard view.  This view caches its contents on disk and must be refreshed to update its contents.  It is only supported on PostgreSQL. Further, allow_replace is not supported on materialized views.
+
 SchemaPlus::Views also arranges to include the `create_view` statements (with literal SQL) in the schema dump.
 
+#### Materialized views
+
+Materialized views persist their data when created and must be manually refreshed to see new data.
+Further materialized views can have indexes defined on them.
+
+```ruby
+create_view :posts_commented_by_staff, <<~SQL, materialized: true
+SELECT * FROM posts LEFT OUTER JOIN comments ON comments.post_id = posts.id WHERE comments.id IS NULL
+SQL
+
+add_index :posts_commented_by_staff, :category
+add_index :posts_commented_by_staff, :token, unique: true
+```
+
+To refresh a materialized view run the refresh_view connection command.
+
+```ruby
+ActiveRecord::Base.connection.refresh_view('posts_commented_by_staff')
+```
+
 ### Dropping views
 
 In a migration:
@@ -65,6 +90,10 @@ In a migration:
 ```ruby
 drop_view :posts_commented_by_staff
 drop_view :uncommented_posts, :if_exists => true
+
+# materialized views
+drop_view :posts_commented_by_staff, materialized: true
+drop_view :uncommented_posts, :if_exists => true, materialized: true
 ```
 
 ### Using views
@@ -86,14 +115,16 @@ You can look up the defined views analogously to looking up tables:
 
 ```ruby
 connection.tables # => array of table names [method provided by ActiveRecord]
-connection.views  # => array of view names [method provided by SchemaPlus::Views]
+connection.views  # => array of view names [method overridden by SchemaPlus::Views for postgres]
 ```
 
 Notes:
 
-1. For Mysql and SQLite3, ActiveRecord's `connection.tables` method would return views as well as tables; SchemaPlus::Views normalizes them to return only tables.
-
-2. For PostgreSQL, `connection.views` suppresses views prefixed with `pg_` as those are presumed to be internal.
+1. For PostgreSQL, `connection.views` suppresses views prefixed with `pg_` as those are presumed to be internal. Also it suppresses the "postgis" specifically named tables
+   - geography_columns
+   - geometry_columns
+   - raster_columns
+   - raster_overviews 
 
 ### Querying view definitions
 
@@ -105,26 +136,19 @@ connection.view_definition(view_name) # => returns SQL string
 
 This returns just the body of the definition, i.e. the part after the `CREATE VIEW 'name' AS` command.
 
-## Customization API: Middleware Stacks
+You can also lookup the type of view (regular or materialized) using
 
-All the methods defined by SchemaPlus::Views provide middleware stacks, in case you need to do any custom filtering, rewriting, triggering, or whatever.  For info on how to use middleware stacks, see the READMEs of [schema_monkey](https://github.com/SchemaPlus/schema_monkey) and [schema_plus_core](https://github.com/SchemaPlus/schema_plus_core).
-
-
-### `Schema::Views` stack
-
-Wraps the `connection.views` method.  Env contains:
+```ruby
+connection.view_type(view_name) # => returns a Symbol, either :view or :materialized
+```
 
-Env Field    | Description | Initialized
---- | --- | ---
-`:views`     | The result of the lookup | `[]`
-`:connection` | The current ActiveRecord connection | *context*
-`:query_name` | Optional label for ActiveRecord logging | *arg*
+## Customization API: Middleware Stacks
 
-The base implementation appends its results to `env.views`
+All the methods defined by SchemaPlus::Views provide middleware stacks, in case you need to do any custom filtering, rewriting, triggering, or whatever.  For info on how to use middleware stacks, see the READMEs of [schema_monkey](https://github.com/SchemaPlus/schema_monkey) and [schema_plus_core](https://github.com/SchemaPlus/schema_plus_core).
 
 ### `Schema::ViewDefinition` stack
 
-Wraps the `connection.view_definition` method.  Env contains:
+Wraps the `connection.view_full_definition` method.  Env contains:
 
 Env Field    | Description | Initialized
 --- | --- | ---
@@ -132,6 +156,7 @@ Env Field    | Description | Initialized
 `:view_name`  | The view to look up | *arg*
 `:query_name` | Optional label for ActiveRecord logging | *arg*
 `:definition` | The view definition SQL | `nil`
+`:view_type`  | The view type symbol. | :view`
 
 The base implementation looks up the definition of the view named
 `env.view_name` and assigns the result to `env.definition`
@@ -166,15 +191,18 @@ options in `env.options`
 
 ## History
 
-* 0.3.1 - Upgrade schema_plus_core and schema_dev dependencies
-* 0.3.0
+* **1.0.0** - Add ruby 3 and AR 6.0, drop Ruy < 2.5
+* **0.4.1** - Corrected spacing around dumped schema
+* **0.4.0** - Added support for Rails 5.2 and materialized views in PostgreSQL
+* **0.3.1** - Upgrade schema_plus_core and schema_dev dependencies
+* **0.3.0**
   - Added middleware stacks
   - Bug fix: view_definition: strip white space from result (postgresql)
-* 0.2.3 - Remove unnecessary escaping in dump; use single-quote heredoc
-* 0.2.2 - Prettier dumps: use heredoc for definition string
-* 0.2.1 - Fix db:rollback
-* 0.2.0 - Added :allow_replace option (thanks to [@hcarver](https://github.com/hcarver))
-* 0.1.0 - Initial release, extracted from schema_plus 1.x
+* **0.2.3** - Remove unnecessary escaping in dump; use single-quote heredoc
+* **0.2.2** - Prettier dumps: use heredoc for definition string
+* **0.2.1** - Fix db:rollback
+* **0.2.0** - Added :allow_replace option (thanks to [@hcarver](https://github.com/hcarver))
+* **0.1.0** - Initial release, extracted from schema_plus 1.x
 
 ## Development & Testing
 
@@ -187,7 +215,7 @@ Some things to know about to help you develop and test:
 * **schema_dev**:  SchemaPlus::Views uses [schema_dev](https://github.com/SchemaPlus/schema_dev) to
   facilitate running rspec tests on the matrix of ruby, activerecord, and database
   versions that the gem supports, both locally and on
-  [travis-ci](http://travis-ci.org/SchemaPlus/schema_plus_views)
+  [github actions](https://github.com/SchemaPlus/schema_plus_views/actions)
 
   To to run rspec locally on the full matrix, do:
 
@@ -199,7 +227,6 @@ Some things to know about to help you develop and test:
   The matrix of configurations is specified in `schema_dev.yml` in
   the project root.
 
-
 <!-- SCHEMA_DEV: TEMPLATE USES SCHEMA_DEV - end -->
 
 <!-- SCHEMA_DEV: TEMPLATE USES SCHEMA_PLUS_CORE - begin -->

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler'
 Bundler::GemHelper.install_tasks
 

data/gemfiles/Gemfile.base

@@ -1,4 +1,4 @@
 source 'https://rubygems.org'
-gemspec :path => File.expand_path('..', __FILE__)
+gemspec path: File.expand_path('..', __FILE__)
 
 File.exist?(gemfile_local = File.expand_path('../Gemfile.local', __FILE__)) and eval File.read(gemfile_local), binding, gemfile_local

data/gemfiles/activerecord-5.2/Gemfile.base

@@ -0,0 +1,4 @@
+base_gemfile = File.expand_path('../../Gemfile.base', __FILE__)
+eval File.read(base_gemfile)
+
+gem "activerecord", ">= 5.2.0.beta0", "< 5.3"

data/gemfiles/activerecord-5.2/Gemfile.mysql2

@@ -0,0 +1,10 @@
+base_gemfile = File.expand_path('../Gemfile.base', __FILE__)
+eval File.read(base_gemfile), binding, base_gemfile
+
+platform :ruby do
+  gem "mysql2"
+end
+
+platform :jruby do
+  gem 'activerecord-jdbcmysql-adapter'
+end

data/gemfiles/activerecord-5.2/Gemfile.postgresql

@@ -0,0 +1,10 @@
+base_gemfile = File.expand_path('../Gemfile.base', __FILE__)
+eval File.read(base_gemfile), binding, base_gemfile
+
+platform :ruby do
+  gem "pg"
+end
+
+platform :jruby do
+  gem 'activerecord-jdbcpostgresql-adapter'
+end

data/gemfiles/{activerecord-4.2 → activerecord-5.2}/Gemfile.sqlite3

@@ -1,5 +1,5 @@
-require "pathname"
-eval(Pathname.new(__FILE__).dirname.join("Gemfile.base").read, binding)
+base_gemfile = File.expand_path('../Gemfile.base', __FILE__)
+eval File.read(base_gemfile), binding, base_gemfile
 
 platform :ruby do
   gem "sqlite3"
@@ -7,4 +7,4 @@ end
 
 platform :jruby do
   gem 'activerecord-jdbcsqlite3-adapter', '>=1.3.0.beta2'
-end
+end

data/gemfiles/activerecord-6.0/Gemfile.base

@@ -0,0 +1,4 @@
+base_gemfile = File.expand_path('../../Gemfile.base', __FILE__)
+eval File.read(base_gemfile)
+
+gem "activerecord", ">= 6.0", "< 6.1"

data/gemfiles/activerecord-6.0/Gemfile.mysql2

@@ -0,0 +1,10 @@
+base_gemfile = File.expand_path('../Gemfile.base', __FILE__)
+eval File.read(base_gemfile), binding, base_gemfile
+
+platform :ruby do
+  gem "mysql2"
+end
+
+platform :jruby do
+  gem 'activerecord-jdbcmysql-adapter'
+end

data/gemfiles/activerecord-6.0/Gemfile.postgresql

@@ -0,0 +1,10 @@
+base_gemfile = File.expand_path('../Gemfile.base', __FILE__)
+eval File.read(base_gemfile), binding, base_gemfile
+
+platform :ruby do
+  gem "pg"
+end
+
+platform :jruby do
+  gem 'activerecord-jdbcpostgresql-adapter'
+end

data/gemfiles/activerecord-6.0/Gemfile.sqlite3

@@ -0,0 +1,10 @@
+base_gemfile = File.expand_path('../Gemfile.base', __FILE__)
+eval File.read(base_gemfile), binding, base_gemfile
+
+platform :ruby do
+  gem "sqlite3"
+end
+
+platform :jruby do
+  gem 'activerecord-jdbcsqlite3-adapter', '>=1.3.0.beta2'
+end

data/lib/schema_plus/views/active_record/connection_adapters/abstract_adapter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SchemaPlus::Views
   module ActiveRecord
     module ConnectionAdapters
@@ -6,6 +8,7 @@ module SchemaPlus::Views
         # to first drop the view if it already exists.
         def create_view(view_name, definition, options={})
           SchemaMonkey::Middleware::Migration::CreateView.start(connection: self, view_name: view_name, definition: definition, options: options) do |env|
+            raise ArgumentError, 'Materialized views are not implemented or supported on this database' if options[:materialized]
             definition = env.definition
             view_name = env.view_name
             options = env.options
@@ -28,6 +31,7 @@ module SchemaPlus::Views
         # to fail silently if the view doesn't exist.
         def drop_view(view_name, options = {})
           SchemaMonkey::Middleware::Migration::DropView.start(connection: self, view_name: view_name, options: options) do |env|
+            raise ArgumentError, 'Materialized views are not implemented or supported on this database' if options[:materialized]
             view_name = env.view_name
             options = env.options
             sql = "DROP VIEW"
@@ -37,19 +41,31 @@ module SchemaPlus::Views
           end
         end
 
+        # Returns the SQL definition of a given view.  This is
+        # the literal SQL would come after 'CREATVE VIEW viewname AS ' in
+        # the SQL statement to create a view.
+        def view_definition(view_name, name = nil)
+          view_full_definition(view_name, name).first
+        end
+
+        # Returns the view type of a given view.  This is either :view or :materialized
+        def view_type(view_name, name = nil)
+          view_full_definition(view_name, name).second
+        end
+
         #####################################################################
         #
         # The functions below here are abstract; each subclass should
         # define them all. Defining them here only for reference.
         #
 
-        # (abstract) Returns the names of all views, as an array of strings
-        def views(name = nil) raise "Internal Error: Connection adapter didn't override abstract function"; [] end
+        # (abstract) Refreshes the given materialized view.
+        def refresh_view(view_name, name = nil) raise "Internal Error: Connection adapter didn't override abstract function"; end
 
-        # (abstract) Returns the SQL definition of a given view.  This is
+        # (abstract) Returns the SQL definition and type of a given view.  This is
         # the literal SQL would come after 'CREATVE VIEW viewname AS ' in
-        # the SQL statement to create a view.
-        def view_definition(view_name, name = nil) raise "Internal Error: Connection adapter didn't override abstract function"; end
+        # the SQL statement to create a view. The type is either :view, or :materialized
+        def view_full_definition(view_name, name = nil) raise "Internal Error: Connection adapter didn't override abstract function"; end
       end
     end
   end

data/lib/schema_plus/views/active_record/connection_adapters/mysql2_adapter.rb

@@ -1,18 +1,12 @@
+# frozen_string_literal: true
+
 module SchemaPlus::Views
   module ActiveRecord
     module ConnectionAdapters
       module Mysql2Adapter
 
-        def views(name = nil)
-          SchemaMonkey::Middleware::Schema::Views.start(connection: self, query_name: name, views: []) { |env|
-            select_all("SELECT table_name FROM information_schema.views WHERE table_schema = SCHEMA()", env.query_name).each do |row|
-              env.views << row["table_name"]
-            end
-          }.views
-        end
-
-        def view_definition(view_name, name = nil)
-          SchemaMonkey::Middleware::Schema::ViewDefinition.start(connection: self, view_name: view_name, query_name: name) { |env|
+        def view_full_definition(view_name, name = nil)
+          data = SchemaMonkey::Middleware::Schema::ViewDefinition.start(connection: self, view_name: view_name, query_name: name, view_type: :view) { |env|
             results = select_all("SELECT view_definition, check_option FROM information_schema.views WHERE table_schema = SCHEMA() AND table_name = #{quote(view_name)}", name)
             if  results.any?
               row = results.first
@@ -24,7 +18,9 @@ module SchemaPlus::Views
               end
               env.definition = sql
             end
-          }.definition
+          }
+
+          [data.definition, data.view_type]
         end
 
       end