rubycritic 3.4.0 → 3.5.0

data/test/lib/rubycritic/smells_status_setter_test.rb

@@ -1,24 +0,0 @@
-# frozen_string_literal: true
-
-require 'test_helper'
-require 'rubycritic/core/smell'
-require 'rubycritic/smells_status_setter'
-
-describe RubyCritic::SmellsStatusSetter do
-  describe '::smells' do
-    before do
-      @smell = RubyCritic::Smell.new(context: '#bar')
-      @smells = [@smell]
-    end
-
-    it 'marks old smells' do
-      RubyCritic::SmellsStatusSetter.set(@smells, @smells)
-      @smell.status.must_equal :old
-    end
-
-    it 'marks new smells' do
-      RubyCritic::SmellsStatusSetter.set([], @smells)
-      @smell.status.must_equal :new
-    end
-  end
-end

data/test/lib/rubycritic/source_control_systems/base_test.rb

@@ -1,31 +0,0 @@
-# frozen_string_literal: true
-
-require 'test_helper'
-require 'rubycritic/source_control_systems/base'
-
-describe RubyCritic::SourceControlSystem::Base do
-  before do
-    RubyCritic::SourceControlSystem::Base.systems.each do |system|
-      system.stubs(:supported?).returns(false)
-    end
-  end
-
-  describe '::create' do
-    context 'when a source control system is found' do
-      it 'creates an instance of that source control system' do
-        RubyCritic::SourceControlSystem::Git.stubs(:supported?).returns(true)
-        system = RubyCritic::SourceControlSystem::Base.create
-        system.must_be_instance_of RubyCritic::SourceControlSystem::Git
-      end
-    end
-
-    context 'when no source control system is found' do
-      it 'creates a source control system double' do
-        capture_output_streams do
-          system = RubyCritic::SourceControlSystem::Base.create
-          system.must_be_instance_of RubyCritic::SourceControlSystem::Double
-        end
-      end
-    end
-  end
-end

data/test/lib/rubycritic/source_control_systems/double_test.rb

@@ -1,13 +0,0 @@
-# frozen_string_literal: true
-
-require 'test_helper'
-require 'rubycritic/source_control_systems/base'
-require_relative 'interfaces/basic'
-
-class DoubleTest < Minitest::Test
-  include BasicInterface
-
-  def setup
-    @system = RubyCritic::SourceControlSystem::Double.new
-  end
-end

data/test/lib/rubycritic/source_control_systems/git_test.rb

@@ -1,15 +0,0 @@
-# frozen_string_literal: true
-
-require 'test_helper'
-require 'rubycritic/source_control_systems/base'
-require_relative 'interfaces/basic'
-require_relative 'interfaces/time_travel'
-
-class GitTest < Minitest::Test
-  include BasicInterface
-  include TimeTravelInterface
-
-  def setup
-    @system = RubyCritic::SourceControlSystem::Git.new
-  end
-end

data/test/lib/rubycritic/source_control_systems/interfaces/basic.rb

@@ -1,9 +0,0 @@
-# frozen_string_literal: true
-
-module BasicInterface
-  def test_implements_basic_interface
-    assert_respond_to @system, :revisions_count
-    assert_respond_to @system, :date_of_last_commit
-    assert_respond_to @system, :revision?
-  end
-end

data/test/lib/rubycritic/source_control_systems/interfaces/time_travel.rb

@@ -1,9 +0,0 @@
-# frozen_string_literal: true
-
-# This interface is only used if `@system.revision?` returns `true`.
-module TimeTravelInterface
-  def test_implements_time_travel_interface
-    assert_respond_to @system, :head_reference
-    assert_respond_to @system, :travel_to_head
-  end
-end

data/test/lib/rubycritic/source_control_systems/mercurial_test.rb

@@ -1,13 +0,0 @@
-# frozen_string_literal: true
-
-require 'test_helper'
-require 'rubycritic/source_control_systems/base'
-require_relative 'interfaces/basic'
-
-class MercurialTest < Minitest::Test
-  include BasicInterface
-
-  def setup
-    @system = RubyCritic::SourceControlSystem::Mercurial.new
-  end
-end

data/test/lib/rubycritic/source_control_systems/perforce_test.rb

@@ -1,176 +0,0 @@
-# frozen_string_literal: true
-
-require 'test_helper'
-require 'rubycritic/source_control_systems/base'
-
-describe RubyCritic::SourceControlSystem::Perforce do
-  before do
-    @system = RubyCritic::SourceControlSystem::Perforce.new
-  end
-
-  describe RubyCritic::SourceControlSystem::Perforce do
-    describe '::supported?' do
-      let(:path) do
-        ['/some/path', File::PATH_SEPARATOR, '/perforce/path/p4', File::PATH_SEPARATOR + '/other/useless_path'].join
-      end
-      let(:p4_client) { 'UNIT_TEST_CLIENT' }
-
-      context 'directory is under p4 client' do
-        it 'detects if Perforce is the source control used' do
-          ENV['PATH'] = path
-          ENV['P4CLIENT'] = p4_client
-          Gem.stubs(:win_platform?).returns(false)
-          File.stubs(:executable?).with('/some/path/p4').returns(false)
-          File.stubs(:executable?).with('/perforce/path/p4/p4').returns(true)
-          RubyCritic::SourceControlSystem::Perforce.stubs(:in_client_directory?).returns(true)
-
-          RubyCritic::SourceControlSystem::Perforce.supported?.must_equal true
-        end
-      end
-
-      context 'directory is not under p4 client' do
-        it 'returns false if no p4 executables are found' do
-          ENV['PATH'] = path
-          ENV['P4CLIENT'] = nil
-          Gem.stubs(:win_platform?).returns(false)
-          File.stubs(:executable?).with('/some/path/p4').returns(false)
-          File.stubs(:executable?).with('/perforce/path/p4/p4').returns(false)
-          File.stubs(:executable?).with('/other/useless_path/p4').returns(false)
-
-          RubyCritic::SourceControlSystem::Perforce.supported?.must_equal false
-        end
-
-        it 'returns false if no p4 client is set in environment variables' do
-          ENV['PATH'] = path
-          ENV['P4CLIENT'] = nil
-          Gem.stubs(:win_platform?).returns(false)
-          File.stubs(:executable?).with('/some/path/p4').returns(false)
-          File.stubs(:executable?).with('/perforce/path/p4/p4').returns(true)
-
-          RubyCritic::SourceControlSystem::Perforce.supported?.must_equal false
-        end
-
-        it 'returns false if the current directory is not under p4 client' do
-          ENV['PATH'] = path
-          ENV['P4CLIENT'] = p4_client
-          Gem.stubs(:win_platform?).returns(false)
-          File.stubs(:executable?).with('/some/path/p4').returns(false)
-          File.stubs(:executable?).with('/perforce/path/p4/p4').returns(true)
-          RubyCritic::SourceControlSystem::Perforce.stubs(:in_client_directory?).returns(false)
-
-          RubyCritic::SourceControlSystem::Perforce.supported?.must_equal false
-        end
-      end
-    end
-
-    describe '::in_client_directory?' do
-      context 'current directory is in p4 client' do
-        let(:p4_info) do
-          <<-P4INFO
-User name: unit_test_user
-Client name: UNIT_TEST_CLIENT
-Client host: MACHINE_NAME
-Client root: /path/to/client/root
-Current directory: /path/to/client/root/ruby_project/unit_test
-Peer address: 127.0.0.1::3000
-Client address: 127.0.0.1
-Server address: the.server.address.com
-          P4INFO
-        end
-
-        it 'calls p4 info and parse the result' do
-          RubyCritic::SourceControlSystem::Perforce.stubs(:`).with('p4 info').returns(p4_info)
-          RubyCritic::SourceControlSystem::Perforce.in_client_directory?.must_equal true
-        end
-      end
-
-      context 'current directory is not in p4 client' do
-        let(:p4_info) do
-          <<-P4INFO
-User name: unit_test_user
-Client name: UNIT_TEST_CLIENT
-Client host: MACHINE_NAME
-Client root: /path/to/client/root
-Current directory: /somewhere/else/ruby_project/unit_test
-Peer address: 127.0.0.1::3000
-Client address: 127.0.0.1
-Server address: the.server.address.com
-          P4INFO
-        end
-
-        it 'calls p4 info and parse the result' do
-          RubyCritic::SourceControlSystem::Perforce.stubs(:`).with('p4 info').returns(p4_info)
-          RubyCritic::SourceControlSystem::Perforce.in_client_directory?.must_equal false
-        end
-      end
-    end
-
-    describe 'retrieve informations' do
-      let(:p4_stats) do
-        <<-P4STATS
-... clientFile /path/to/client/a_ruby_file.rb
-... headTime 1473075551
-... headRev 16
-... headChange 2103503
-
-... clientFile /path/to/client/second_ruby_file.rb
-... headTime 1464601668
-... action opened
-... headRev 12
-... headChange 2103504
-        P4STATS
-      end
-
-      describe 'build_file_cache' do
-        it 'builds the perforce file cache' do
-          RubyCritic::SourceControlSystem::Perforce.stubs(:`).returns(p4_stats)
-          file_cache = @system.send(:perforce_files)
-          file_cache.size.must_equal 2
-
-          first_file = file_cache['/path/to/client/a_ruby_file.rb']
-          first_file.filename.must_equal '/path/to/client/a_ruby_file.rb'
-          first_file.revision.must_equal '16'
-          first_file.last_commit.must_equal '1473075551'
-          first_file.head.must_equal '2103503'
-          first_file.opened?.must_equal false
-
-          second_file = file_cache['/path/to/client/second_ruby_file.rb']
-          second_file.filename.must_equal '/path/to/client/second_ruby_file.rb'
-          second_file.revision.must_equal '12'
-          second_file.last_commit.must_equal '1464601668'
-          second_file.head.must_equal '2103504'
-          second_file.opened?.must_equal true
-        end
-      end
-
-      it 'retrieves the number revisions of the ruby files' do
-        Dir.stubs(:getwd).returns('/path/to/client')
-        RubyCritic::SourceControlSystem::Perforce.stubs(:`).once.returns(p4_stats)
-        @system.revisions_count('a_ruby_file.rb').must_equal 16
-        @system.revisions_count('second_ruby_file.rb').must_equal 12
-      end
-
-      it 'retrieves the date of the last commit of the ruby files' do
-        oldtz = ENV['TZ']
-        ENV['TZ'] = 'utc'
-        Dir.stubs(:getwd).returns('/path/to/client')
-        RubyCritic::SourceControlSystem::Perforce.stubs(:`).once.returns(p4_stats)
-        @system.date_of_last_commit('a_ruby_file.rb').must_equal '2016-09-05 11:39:11 +0000'
-        @system.date_of_last_commit('second_ruby_file.rb').must_equal '2016-05-30 09:47:48 +0000'
-        ENV['TZ'] = oldtz
-      end
-
-      it 'retrieves the information if the ruby file is opened (in the changelist and ready to commit)' do
-        Dir.stubs(:getwd).returns('/path/to/client')
-        RubyCritic::SourceControlSystem::Perforce.stubs(:`).once.returns(p4_stats)
-        @system.revision?.must_equal true
-      end
-
-      it 'retrieves the head reference of the repository' do
-        Dir.stubs(:getwd).returns('/path/to/client')
-        RubyCritic::SourceControlSystem::Perforce.stubs(:`).once.returns(p4_stats)
-        @system.head_reference.must_equal '2103504'
-      end
-    end
-  end
-end

data/test/lib/rubycritic/source_locator_test.rb

@@ -1,80 +0,0 @@
-# frozen_string_literal: true
-
-require 'test_helper'
-require 'rubycritic/source_locator'
-
-describe RubyCritic::SourceLocator do
-  before do
-    @original_dir = Dir.getwd
-    Dir.chdir('test/samples/location')
-  end
-
-  describe '#paths' do
-    it 'finds a single file' do
-      paths = ['file0.rb']
-      RubyCritic::SourceLocator.new(paths).paths.must_equal paths
-    end
-
-    it 'finds all the files inside a given directory' do
-      initial_paths = ['dir1']
-      final_paths = ['dir1/file1.rb']
-      RubyCritic::SourceLocator.new(initial_paths).paths.must_equal final_paths
-    end
-
-    it 'finds files through multiple paths' do
-      paths = ['dir1/file1.rb', 'file0.rb']
-      RubyCritic::SourceLocator.new(paths).paths.must_match_array paths
-    end
-
-    it 'finds all the files' do
-      initial_paths = ['.']
-      final_paths = ['dir1/file1.rb', 'file0.rb', 'file0_symlink.rb']
-      RubyCritic::SourceLocator.new(initial_paths).paths.must_match_array final_paths
-    end
-
-    context 'when configured to deduplicate symlinks' do
-      it 'favors a file over a symlink if they both point to the same target' do
-        RubyCritic::Config.stubs(:deduplicate_symlinks).returns(true)
-        initial_paths = ['file0.rb', 'file0_symlink.rb']
-        final_paths = ['file0.rb']
-        RubyCritic::SourceLocator.new(initial_paths).paths.must_match_array final_paths
-      end
-    end
-
-    it 'cleans paths of consecutive slashes and useless dots' do
-      initial_paths = ['.//file0.rb']
-      final_paths = ['file0.rb']
-      RubyCritic::SourceLocator.new(initial_paths).paths.must_equal final_paths
-    end
-
-    it 'ignores paths to non-existent files' do
-      initial_paths = ['non_existent_dir1/non_existent_file1.rb', 'non_existent_file0.rb']
-      final_paths = []
-      RubyCritic::SourceLocator.new(initial_paths).paths.must_equal final_paths
-    end
-
-    it 'ignores paths to files that do not match the Ruby extension' do
-      initial_paths = ['file_with_no_extension', 'file_with_different_extension.py']
-      final_paths = []
-      RubyCritic::SourceLocator.new(initial_paths).paths.must_equal final_paths
-    end
-
-    it 'can deal with nil paths' do
-      paths = nil
-      final_paths = []
-      RubyCritic::SourceLocator.new(paths).paths.must_equal final_paths
-    end
-  end
-
-  describe '#pathnames' do
-    it 'finds a single file' do
-      initial_paths = ['file0.rb']
-      final_pathnames = [Pathname.new('file0.rb')]
-      RubyCritic::SourceLocator.new(initial_paths).pathnames.must_equal final_pathnames
-    end
-  end
-
-  after do
-    Dir.chdir(@original_dir)
-  end
-end

data/test/lib/rubycritic/version_test.rb

@@ -1,10 +0,0 @@
-# frozen_string_literal: true
-
-require 'test_helper'
-require 'rubycritic/version'
-
-describe 'RubyCritic version' do
-  it 'is defined' do
-    RubyCritic::VERSION.wont_be_nil
-  end
-end

data/test/samples/flay/smelly.rb

@@ -1,8 +0,0 @@
-class Ramsay
-  def flay(parts)
-    parts -= 1
-    parts -= 2
-    parts -= 3
-    parts -= 4
-  end
-end

data/test/samples/flay/smelly2.rb

@@ -1,8 +0,0 @@
-class Roose
-  def flay(parts)
-    parts -= 1
-    parts -= 2
-    parts -= 3
-    parts -= 4
-  end
-end

data/test/samples/flog/complex.rb

@@ -1,11 +0,0 @@
-class AllTheMethods
-  def method_missing(method, *args, &block)
-    message = "I"
-    eval "message = ' did not'"
-    eval "message << ' exist,'"
-    eval "message << ' but now'"
-    eval "message << ' I do.'"
-    self.class.send(:define_method, method) { "I did not exist, but now I do." }
-    self.send(method)
-  end
-end

data/test/samples/flog/smelly.rb

@@ -1,11 +0,0 @@
-class AllTheMethods
-  def method_missing(method, *args, &block)
-    message = "I"
-    eval "message = ' did not'"
-    eval "message << ' exist,'"
-    eval "message << ' but now'"
-    eval "message << ' I do.'"
-    self.class.send(:define_method, method) { "I did not exist, but now I do." }
-    self.send(method)
-  end
-end

data/test/samples/location/file0_symlink.rb

@@ -1 +0,0 @@
-test/samples/location/file0.rb