rubycritic 3.4.0 → 3.5.0

data/test/lib/rubycritic/analysers/smells/flay_test.rb

@@ -1,41 +0,0 @@
-# frozen_string_literal: true
-
-require 'test_helper'
-require 'rubycritic/analysers/smells/flay'
-require 'rubycritic/core/analysed_module'
-require 'pathname'
-
-describe RubyCritic::Analyser::FlaySmells do
-  context 'when analysing a bunch of files with duplicate code' do
-    before do
-      @analysed_modules = [
-        RubyCritic::AnalysedModule.new(pathname: Pathname.new('test/samples/flay/smelly.rb')),
-        RubyCritic::AnalysedModule.new(pathname: Pathname.new('test/samples/flay/smelly2.rb'))
-      ]
-      RubyCritic::Analyser::FlaySmells.new(@analysed_modules).run
-    end
-
-    it 'detects its smells' do
-      @analysed_modules.first.smells?.must_equal true
-    end
-
-    it 'creates smells with messages' do
-      smell = @analysed_modules.first.smells.first
-      smell.message.must_be_instance_of String
-    end
-
-    it 'creates smells with scores' do
-      smell = @analysed_modules.first.smells.first
-      smell.score.must_be_kind_of Numeric
-    end
-
-    it 'creates smells with more than one location' do
-      smell = @analysed_modules.first.smells.first
-      smell.multiple_locations?.must_equal true
-    end
-
-    it 'calculates the mass of duplicate code' do
-      @analysed_modules.first.duplication.must_be(:>, 0)
-    end
-  end
-end

data/test/lib/rubycritic/analysers/smells/flog_test.rb

@@ -1,28 +0,0 @@
-# frozen_string_literal: true
-
-require 'analysers_test_helper'
-require 'rubycritic/analysers/smells/flog'
-
-describe RubyCritic::Analyser::FlogSmells do
-  context 'when analysing a complex file' do
-    before do
-      @analysed_module = AnalysedModuleDouble.new(path: 'test/samples/flog/smelly.rb', smells: [])
-      analysed_modules = [@analysed_module]
-      RubyCritic::Analyser::FlogSmells.new(analysed_modules).run
-    end
-
-    it 'detects its smells' do
-      @analysed_module.smells.length.must_equal 1
-    end
-
-    it 'creates smells with messages' do
-      smell = @analysed_module.smells.first
-      smell.message.must_be_instance_of String
-    end
-
-    it 'creates smells with scores' do
-      smell = @analysed_module.smells.first
-      smell.score.must_be :>, 0
-    end
-  end
-end

data/test/lib/rubycritic/analysers/smells/reek_test.rb

@@ -1,32 +0,0 @@
-# frozen_string_literal: true
-
-require 'analysers_test_helper'
-require 'rubycritic/analysers/smells/reek'
-
-describe RubyCritic::Analyser::ReekSmells do
-  context 'when analysing a smelly file' do
-    before do
-      pathname = Pathname.new('test/samples/reek/smelly.rb')
-      @analysed_module = AnalysedModuleDouble.new(pathname: pathname, smells: [])
-      analysed_modules = [@analysed_module]
-      RubyCritic::Analyser::ReekSmells.new(analysed_modules).run
-    end
-
-    it 'detects its smells' do
-      @analysed_module.smells.length.must_equal 2
-    end
-
-    it 'respects the .reek file' do
-      messages = @analysed_module.smells.map(&:message)
-      messages.wont_include "has the parameter name 'a'"
-    end
-
-    it 'creates smells with messages' do
-      first_smell = @analysed_module.smells.first
-      first_smell.message.must_equal "has boolean parameter 'reek'"
-
-      last_smell = @analysed_module.smells.last
-      last_smell.message.must_equal 'has no descriptive comment'
-    end
-  end
-end

data/test/lib/rubycritic/analysis_summary_test.rb

@@ -1,30 +0,0 @@
-# frozen_string_literal: true
-
-require 'test_helper'
-require 'rubycritic/analysis_summary'
-
-module RubyCritic
-  describe AnalysisSummary do
-    before do
-      analysed_modules = AnalysedModulesCollectionDouble.new(
-        [
-          AnalysedModuleDouble.new(rating: 'A', churn: 2, smells: %i[a b c]),
-          AnalysedModuleDouble.new(rating: 'A', churn: 3, smells: [:b]),
-          AnalysedModuleDouble.new(rating: 'A', churn: 4, smells: %i[x y]),
-          AnalysedModuleDouble.new(rating: 'B', churn: 5, smells: %i[a z])
-        ]
-      )
-      @summary = RubyCritic::AnalysisSummary.generate(analysed_modules)
-    end
-
-    describe '.root' do
-      it 'computes correct summary' do
-        @summary['A'].to_a.must_equal({ files: 3, churns: 9, smells: 6 }.to_a)
-        @summary['B'].to_a.must_equal({ files: 1, churns: 5, smells: 2 }.to_a)
-        @summary['C'].to_a.must_equal({ files: 0, churns: 0, smells: 0 }.to_a)
-        @summary['D'].to_a.must_equal({ files: 0, churns: 0, smells: 0 }.to_a)
-        @summary['F'].to_a.must_equal({ files: 0, churns: 0, smells: 0 }.to_a)
-      end
-    end
-  end
-end

data/test/lib/rubycritic/browser_test.rb

@@ -1,18 +0,0 @@
-# frozen_string_literal: true
-
-require 'test_helper'
-require 'rubycritic/browser'
-
-describe RubyCritic::Browser do
-  before do
-    @report_path = 'tmp/rubycritic/overview.html'
-    @browser = RubyCritic::Browser.new @report_path
-  end
-
-  describe '#open' do
-    it 'should be open report with launch browser' do
-      Launchy.stubs(:open).returns(true)
-      @browser.open.must_equal true
-    end
-  end
-end

data/test/lib/rubycritic/commands/status_reporter_test.rb

@@ -1,81 +0,0 @@
-# frozen_string_literal: true
-
-require 'test_helper'
-require 'rubycritic/commands/status_reporter'
-require 'rubycritic/cli/options'
-
-describe RubyCritic::Command::StatusReporter do
-  let(:success_status) { RubyCritic::Command::StatusReporter::SUCCESS }
-  let(:score_below_minimum) { RubyCritic::Command::StatusReporter::SCORE_BELOW_MINIMUM }
-
-  describe 'with default options' do
-    before do
-      @options = RubyCritic::Cli::Options.new([])
-      @options.parse
-      @reporter = RubyCritic::Command::StatusReporter.new(@options.to_h)
-    end
-
-    it 'has a default' do
-      @reporter.status.must_equal success_status
-      @reporter.status_message.must_be_nil
-    end
-
-    it 'accept a score' do
-      @reporter.score = 50.0
-      @reporter.status.must_equal success_status
-      @reporter.status_message.must_equal 'Score: 50.0'
-    end
-
-    it 'should format the score' do
-      @reporter.score = 98.95258620689656
-      @reporter.status.must_equal success_status
-      @reporter.status_message.must_equal 'Score: 98.95'
-    end
-  end
-
-  describe 'with minimum-score option' do
-    before do
-      @options = RubyCritic::Cli::Options.new(['-s', '99'])
-      @options.parse
-      @reporter = RubyCritic::Command::StatusReporter.new(@options.to_h)
-    end
-
-    it 'has a default' do
-      @reporter.status.must_equal success_status
-      @reporter.status_message.must_be_nil
-    end
-
-    describe 'when score is below minimum' do
-      let(:score) { 98.0 }
-      it 'should return the correct status' do
-        @reporter.score = score
-        @reporter.status.must_equal score_below_minimum
-        @reporter.status_message.must_equal 'Score (98.0) is below the minimum 99.0'
-      end
-
-      it 'should format the score' do
-        @reporter.score = 98.95258620689656
-        @reporter.status.must_equal score_below_minimum
-        @reporter.status_message.must_equal 'Score (98.95) is below the minimum 99.0'
-      end
-    end
-
-    describe 'when score is equal the minimum' do
-      let(:score) { 99.0 }
-      it 'should return the correct status' do
-        @reporter.score = score
-        @reporter.status.must_equal success_status
-        @reporter.status_message.must_equal 'Score: 99.0'
-      end
-    end
-
-    describe 'when score is above the minimum' do
-      let(:score) { 100.0 }
-      it 'should return the correct status' do
-        @reporter.score = score
-        @reporter.status.must_equal success_status
-        @reporter.status_message.must_equal 'Score: 100.0'
-      end
-    end
-  end
-end

data/test/lib/rubycritic/configuration_test.rb

@@ -1,31 +0,0 @@
-# frozen_string_literal: true
-
-require 'test_helper'
-require 'rubycritic/configuration'
-
-describe RubyCritic::Configuration do
-  describe '#root' do
-    before do
-      RubyCritic::Config.set
-      @default = RubyCritic::Config.root
-    end
-
-    it 'has a default' do
-      RubyCritic::Config.root.must_be_instance_of String
-    end
-
-    it 'can be set to a relative path' do
-      RubyCritic::Config.root = 'foo'
-      RubyCritic::Config.root.must_equal File.expand_path('foo')
-    end
-
-    it 'can be set to an absolute path' do
-      RubyCritic::Config.root = '/foo'
-      RubyCritic::Config.root.must_equal '/foo'
-    end
-
-    after do
-      RubyCritic::Config.root = @default
-    end
-  end
-end

data/test/lib/rubycritic/core/analysed_module_test.rb

@@ -1,90 +0,0 @@
-# frozen_string_literal: true
-
-require 'test_helper'
-require 'rubycritic/core/analysed_module'
-require 'rubycritic/core/smell'
-
-describe RubyCritic::AnalysedModule do
-  describe 'attribute readers' do
-    before do
-      @name = 'Foo'
-      @pathname = Pathname.new('foo.rb')
-      @smells = []
-      @churn = 1
-      @complexity = 2
-      @analysed_module = RubyCritic::AnalysedModule.new(
-        name: @name,
-        pathname: @pathname,
-        smells: @smells,
-        churn: @churn,
-        complexity: @complexity
-      )
-    end
-
-    it 'has a name reader' do
-      @analysed_module.name.must_equal @name
-    end
-
-    it 'has a pathname reader' do
-      @analysed_module.pathname.must_equal @pathname
-    end
-
-    it 'has a path reader' do
-      @analysed_module.path.must_equal @pathname.to_s
-    end
-
-    it 'has a smells reader' do
-      @analysed_module.smells.must_equal @smells
-    end
-
-    it 'has a churn reader' do
-      @analysed_module.churn.must_equal @churn
-    end
-
-    it 'has a complexity reader' do
-      @analysed_module.complexity.must_equal @complexity
-    end
-  end
-
-  describe '#cost' do
-    it 'returns the remediation cost of fixing the analysed_module' do
-      smells = [SmellDouble.new(cost: 1), SmellDouble.new(cost: 2)]
-      analysed_module = RubyCritic::AnalysedModule.new(smells: smells, complexity: 0)
-      analysed_module.cost.must_equal 3
-    end
-  end
-
-  describe '#complexity_per_method' do
-    context 'when the file has no methods' do
-      it 'returns a placeholder' do
-        analysed_module = RubyCritic::AnalysedModule.new(complexity: 0, methods_count: 0)
-        analysed_module.complexity_per_method.must_equal 'N/A'
-      end
-    end
-
-    context 'when the file has at least one method' do
-      it 'returns the average complexity per method' do
-        analysed_module = RubyCritic::AnalysedModule.new(complexity: 10, methods_count: 2)
-        analysed_module.complexity_per_method.must_equal 5
-      end
-    end
-  end
-
-  describe '#smells?' do
-    it 'returns true if the analysed_module has at least one smell' do
-      analysed_module = RubyCritic::AnalysedModule.new(smells: [SmellDouble.new])
-      analysed_module.smells?.must_equal true
-    end
-  end
-
-  describe '#smells_at_location' do
-    it 'returns the smells of an analysed_module at a certain location' do
-      location = RubyCritic::Location.new('./foo', '42')
-      smells = [RubyCritic::Smell.new(locations: [location])]
-      analysed_module = RubyCritic::AnalysedModule.new(smells: smells)
-      analysed_module.smells_at_location(location).must_equal smells
-    end
-  end
-end
-
-class SmellDouble < OpenStruct; end

data/test/lib/rubycritic/core/analysed_modules_collection_test.rb

@@ -1,111 +0,0 @@
-# frozen_string_literal: true
-
-require 'test_helper'
-require 'rubycritic/core/analysed_modules_collection'
-
-describe RubyCritic::AnalysedModulesCollection do
-  subject { RubyCritic::AnalysedModulesCollection.new(paths) }
-
-  describe '.new' do
-    context 'with an empty path' do
-      let(:paths) { '' }
-
-      it 'returns an empty collection' do
-        subject.count.must_equal 0
-      end
-    end
-
-    context 'with a list of files' do
-      let(:paths) { %w[test/samples/doesnt_exist.rb test/samples/unparsable.rb test/samples/empty.rb] }
-
-      it 'registers one AnalysedModule element per existent file' do
-        subject.count.must_equal 2
-        subject.all? { |a| a.is_a?(RubyCritic::AnalysedModule) }.must_equal true
-      end
-    end
-
-    context 'with a directory' do
-      let(:paths) { 'test/samples/' }
-
-      it 'recursively registers all files' do
-        subject.count.must_equal Dir['test/samples/**/*.rb'].count
-      end
-    end
-
-    context 'with redundant paths' do
-      let(:paths) { %w[test/samples/flog test/samples/flog/complex.rb] }
-
-      it 'returns a redundant collection' do
-        subject.count.must_equal 3
-      end
-    end
-  end
-
-  describe '#score' do
-    context 'with no modules' do
-      let(:paths) { '' }
-
-      it 'returns zero' do
-        subject.score.must_equal 0.0
-      end
-    end
-
-    context 'with not analysed modules' do
-      let(:paths) { 'test/samples/flog' }
-
-      it 'returns zero' do
-        subject.score.must_equal 0.0
-      end
-    end
-
-    context 'with analysed modules' do
-      before do
-        subject.each_with_index do |mod, i|
-          mod.expects(:cost).returns costs[i]
-        end
-      end
-
-      let(:paths) { %w[test/samples/flog test/samples/flay] }
-
-      context 'with perfect modules' do
-        let(:costs) { [0.0, 0.0, 0.0, 0.0] }
-
-        it 'returns the maximum score' do
-          subject.score.must_equal 100.0
-        end
-      end
-
-      context 'with very bad modules' do
-        let(:costs) { [16.0, 16.0, 16.0, 16.0] }
-
-        it 'returns zero' do
-          subject.score.must_equal 0.0
-        end
-      end
-
-      context 'with horrible modules' do
-        let(:costs) { [32.0, 32.0, 32.0, 32.0] }
-
-        it 'returns zero' do
-          subject.score.must_equal 0.0
-        end
-      end
-
-      context 'with mixed modules' do
-        let(:costs) { [32.0, 2.0, 0.0, 2.0] }
-
-        it 'properly calculates the score' do
-          subject.score.must_equal 43.75
-        end
-      end
-
-      context 'with a module above the cost limit' do
-        let(:costs) { [220.0, 2.0, 0.0, 2.0] }
-
-        it 'reduces the impact in the result' do
-          subject.score.must_equal 43.75
-        end
-      end
-    end
-  end
-end