ruby_smb 2.0.2 → 2.0.3

data/spec/lib/ruby_smb/dcerpc/rpc_security_attributes_spec.rb

@@ -0,0 +1,161 @@
+RSpec.describe RubySMB::Dcerpc::RpcSecurityDescriptor do
+  subject(:packet) { described_class.new }
+
+  it { is_expected.to respond_to :lp_security_descriptor }
+  it { is_expected.to respond_to :cb_in_security_descriptor }
+  it { is_expected.to respond_to :cb_out_security_descriptor }
+
+  it 'is little endian' do
+    expect(described_class.fields.instance_variable_get(:@hints)[:endian]).to eq :little
+  end
+
+  describe '#lp_security_descriptor' do
+    it 'should be a NdrLpByteArray structure' do
+      expect(packet.lp_security_descriptor).to be_a RubySMB::Dcerpc::Ndr::NdrLpByteArray
+    end
+  end
+
+  describe '#cb_in_security_descriptor' do
+    it 'should be a 32-bit unsigned integer' do
+      expect(packet.cb_in_security_descriptor).to be_a BinData::Uint32le
+    end
+  end
+
+  describe '#cb_out_security_descriptor' do
+    it 'should be a 32-bit unsigned integer' do
+      expect(packet.cb_out_security_descriptor).to be_a BinData::Uint32le
+    end
+  end
+
+  describe '#read' do
+    context 'with a null pointer' do
+      it 'reads its own binary representation' do
+        raw = packet.to_binary_s
+        expect(described_class.read(raw)).to eq(packet)
+        expect(described_class.read(raw).to_binary_s).to eq(raw)
+      end
+    end
+
+    context 'with a normal RpcSecurityAttributes structure' do
+      it 'reads its own binary representation' do
+        packet.lp_security_descriptor = RubySMB::Dcerpc::Ndr::NdrLpByteArray.new([1, 2, 3])
+        packet.cb_in_security_descriptor = 90
+        packet.cb_out_security_descriptor = 33
+        raw = packet.to_binary_s
+        expect(described_class.read(raw)).to eq(packet)
+        expect(described_class.read(raw).to_binary_s).to eq(raw)
+      end
+    end
+  end
+end
+
+RSpec.describe RubySMB::Dcerpc::RpcSecurityAttributes do
+  subject(:packet) { described_class.new }
+
+  it { is_expected.to respond_to :n_length }
+  it { is_expected.to respond_to :rpc_security_descriptor }
+  it { is_expected.to respond_to :b_inheritHandle }
+
+  it 'is little endian' do
+    expect(described_class.fields.instance_variable_get(:@hints)[:endian]).to eq :little
+  end
+
+  describe '#n_length' do
+    it 'should be a 32-bit unsigned integer' do
+      expect(packet.n_length).to be_a BinData::Uint32le
+    end
+  end
+
+  describe '#rpc_security_descriptor' do
+    it 'should be a RpcSecurityDescriptor structure' do
+      expect(packet.rpc_security_descriptor).to be_a RubySMB::Dcerpc::RpcSecurityDescriptor
+    end
+  end
+
+  describe '#b_inheritHandle' do
+    it 'should be a 8-bit unsigned integer' do
+      expect(packet.b_inheritHandle).to be_a BinData::Uint8
+    end
+  end
+
+  describe '#read' do
+    context 'with a null pointer' do
+      it 'reads its own binary representation' do
+        raw = packet.to_binary_s
+        expect(described_class.read(raw)).to eq(packet)
+        expect(described_class.read(raw).to_binary_s).to eq(raw)
+      end
+    end
+
+    context 'with a normal RpcSecurityAttributes structure' do
+      it 'reads its own binary representation' do
+        packet.n_length = 3
+        packet.rpc_security_descriptor = RubySMB::Dcerpc::RpcSecurityDescriptor.new
+        packet.rpc_security_descriptor.lp_security_descriptor = [1, 2, 3]
+        packet.rpc_security_descriptor.cb_in_security_descriptor = 33
+        packet.rpc_security_descriptor.cb_out_security_descriptor = 22
+        packet.b_inheritHandle = 90
+        raw = packet.to_binary_s
+        expect(described_class.read(raw)).to eq(packet)
+        expect(described_class.read(raw).to_binary_s).to eq(raw)
+      end
+    end
+  end
+end
+
+RSpec.describe RubySMB::Dcerpc::PrpcSecurityAttributes do
+  it 'is NdrPointer subclass' do
+    expect(described_class).to be < RubySMB::Dcerpc::Ndr::NdrPointer
+  end
+
+  subject(:packet) { described_class.new }
+
+  it { is_expected.to respond_to :referent }
+
+  it 'is little endian' do
+    expect(described_class.fields.instance_variable_get(:@hints)[:endian]).to eq :little
+  end
+
+  describe '#referent' do
+    it 'should be a RpcSecurityAttributes structure' do
+      expect(packet.referent).to be_a RubySMB::Dcerpc::RpcSecurityAttributes
+    end
+
+    it 'exists if superclass #referent_id is not zero' do
+      packet.referent_id = 0xCCCC
+      expect(packet.referent?).to be true
+    end
+
+    it 'does not exist if superclass #referent_id is zero' do
+      packet.referent_id = 0
+      expect(packet.referent?).to be false
+    end
+  end
+
+  describe '#read' do
+    context 'with a null pointer' do
+      it 'reads its own binary representation' do
+        raw = packet.to_binary_s
+        expect(described_class.read(raw)).to eq(packet)
+        expect(described_class.read(raw).to_binary_s).to eq(raw)
+      end
+    end
+
+    context 'with a normal RpcSecurityAttributes structure' do
+      it 'reads its own binary representation' do
+        struct = RubySMB::Dcerpc::RpcSecurityAttributes.new
+        struct.n_length = 5
+        struct.rpc_security_descriptor = RubySMB::Dcerpc::RpcSecurityDescriptor.new
+        struct.rpc_security_descriptor.lp_security_descriptor = [1, 2, 3]
+        struct.rpc_security_descriptor.cb_in_security_descriptor = 33
+        struct.rpc_security_descriptor.cb_out_security_descriptor = 22
+        struct.b_inheritHandle = 4
+        packet.set(struct)
+        raw = packet.to_binary_s
+        expect(described_class.read(raw)).to eq(packet)
+        expect(described_class.read(raw).to_binary_s).to eq(raw)
+      end
+    end
+  end
+end
+

data/spec/lib/ruby_smb/dcerpc/rrp_unicode_string_spec.rb

@@ -13,10 +13,6 @@ RSpec.describe RubySMB::Dcerpc::RrpUnicodeString do
     it 'should be a 16-bit unsigned integer' do
       expect(packet.buffer_length).to be_a BinData::Uint16le
     end
-
-    it 'is set to 0 when #buffer in empty' do
-      expect(packet.buffer_length).to eq(0)
-    end
   end
 
   describe '#maximum_length' do
@@ -54,23 +50,44 @@ RSpec.describe RubySMB::Dcerpc::RrpUnicodeString do
       expect(packet.maximum_length).to eq(('spec_test'.size + 1) * 2)
     end
 
-    context 'when the value is 0' do
+    context 'when the value is :null' do
       it 'sets #buffer_length to 0' do
-        packet.set(0)
+        packet.buffer_length = 33
+        packet.set(:null)
         expect(packet.buffer_length).to eq(0)
       end
 
-      it 'sets #maximum_length to 0' do
-        packet.set(0)
-        expect(packet.maximum_length).to eq(0)
+      it 'does not set #maximum_length if it has already been set' do
+        packet.maximum_length = 33
+        packet.set(:null)
+        expect(packet.maximum_length).to eq(33)
+      end
+    end
+  end
+
+  describe '#read' do
+    context 'with a null pointer' do
+      it 'reads its own binary representation' do
+        raw = packet.to_binary_s
+        expect(described_class.read(raw)).to eq(packet)
+        expect(described_class.read(raw).to_binary_s).to eq(raw)
+      end
+    end
+
+    context 'with a normal string' do
+      it 'reads its own binary representation' do
+        packet.assign('my_test')
+        raw = packet.to_binary_s
+        expect(described_class.read(raw)).to eq(packet)
+        expect(described_class.read(raw).to_binary_s).to eq(raw)
       end
     end
   end
 end
 
 RSpec.describe RubySMB::Dcerpc::PrrpUnicodeString do
-  it 'is NdrTopLevelFullPointer subclass' do
-    expect(described_class).to be < RubySMB::Dcerpc::Ndr::NdrTopLevelFullPointer
+  it 'is NdrPointer subclass' do
+    expect(described_class).to be < RubySMB::Dcerpc::Ndr::NdrPointer
   end
 
   subject(:packet) { described_class.new }
@@ -87,12 +104,32 @@ RSpec.describe RubySMB::Dcerpc::PrrpUnicodeString do
     end
 
     it 'exists if superclass #referent_identifier is not zero' do
+      packet.referent_id = 0xCCCC
       expect(packet.referent?).to be true
     end
 
     it 'does not exist if superclass #referent_identifier is zero' do
-      packet.referent_identifier = 0
+      packet.referent_id = 0
       expect(packet.referent?).to be false
     end
   end
+
+  describe '#read' do
+    context 'with a null pointer' do
+      it 'reads its own binary representation' do
+        raw = packet.to_binary_s
+        expect(described_class.read(raw)).to eq(packet)
+        expect(described_class.read(raw).to_binary_s).to eq(raw)
+      end
+    end
+
+    context 'with a normal string' do
+      it 'reads its own binary representation' do
+        packet.assign('my_test')
+        raw = packet.to_binary_s
+        expect(described_class.read(raw)).to eq(packet)
+        expect(described_class.read(raw).to_binary_s).to eq(raw)
+      end
+    end
+  end
 end

data/spec/lib/ruby_smb/dcerpc/svcctl/change_service_config_w_request_spec.rb

@@ -0,0 +1,191 @@
+RSpec.describe RubySMB::Dcerpc::Svcctl::ChangeServiceConfigWRequest do
+  subject(:packet) { described_class.new }
+
+  it { is_expected.to respond_to :h_service }
+  it { is_expected.to respond_to :dw_service_type }
+  it { is_expected.to respond_to :dw_start_type }
+  it { is_expected.to respond_to :dw_error_control }
+  it { is_expected.to respond_to :lp_binary_path_name }
+  it { is_expected.to respond_to :pad1 }
+  it { is_expected.to respond_to :lp_load_order_group }
+  it { is_expected.to respond_to :pad2 }
+  it { is_expected.to respond_to :dw_tag_id }
+  it { is_expected.to respond_to :lp_dependencies }
+  it { is_expected.to respond_to :pad3 }
+  it { is_expected.to respond_to :dw_depend_size }
+  it { is_expected.to respond_to :lp_service_start_name }
+  it { is_expected.to respond_to :pad4 }
+  it { is_expected.to respond_to :lp_password }
+  it { is_expected.to respond_to :pad5 }
+  it { is_expected.to respond_to :dw_pw_size }
+  it { is_expected.to respond_to :lp_display_name }
+
+  it 'is little endian' do
+    expect(described_class.fields.instance_variable_get(:@hints)[:endian]).to eq :little
+  end
+
+  describe '#h_service' do
+    it 'is a ScRpcHandle structure' do
+      expect(packet.h_service).to be_a RubySMB::Dcerpc::Svcctl::ScRpcHandle
+    end
+  end
+
+  describe '#dw_service_type' do
+    it 'is a 32-bit unsigned integer' do
+      expect(packet.dw_service_type).to be_a BinData::Uint32le
+    end
+  end
+
+  describe '#dw_start_type' do
+    it 'is a 32-bit unsigned integer' do
+      expect(packet.dw_start_type).to be_a BinData::Uint32le
+    end
+  end
+
+  describe '#dw_start_type' do
+    it 'is a 32-bit unsigned integer' do
+      expect(packet.dw_start_type).to be_a BinData::Uint32le
+    end
+  end
+
+  describe '#lp_binary_path_name' do
+    it 'is a NdrLpStr structure' do
+      expect(packet.lp_binary_path_name).to be_a RubySMB::Dcerpc::Ndr::NdrLpStr
+    end
+  end
+
+  describe '#pad1' do
+    it 'is a string' do
+      expect(packet.pad1).to be_a BinData::String
+    end
+
+    it 'should keep #lp_load_order_group 4-byte aligned' do
+      packet.lp_binary_path_name = "test"
+      expect(packet.lp_load_order_group.abs_offset % 4).to eq 0
+    end
+  end
+
+  describe '#lp_load_order_group' do
+    it 'is a NdrLpStr structure' do
+      expect(packet.lp_load_order_group).to be_a RubySMB::Dcerpc::Ndr::NdrLpStr
+    end
+  end
+
+  describe '#pad2' do
+    it 'is a string' do
+      expect(packet.pad1).to be_a BinData::String
+    end
+
+    it 'should keep #dw_tag_id 4-byte aligned' do
+      packet.lp_load_order_group = "test"
+      expect(packet.dw_tag_id.abs_offset % 4).to eq 0
+    end
+  end
+
+  describe '#dw_tag_id' do
+    it 'is a NdrLpDword structure' do
+      expect(packet.dw_tag_id).to be_a RubySMB::Dcerpc::Ndr::NdrLpDword
+    end
+  end
+
+  describe '#lp_dependencies' do
+    it 'is a NdrLpByte structure' do
+      expect(packet.lp_dependencies).to be_a RubySMB::Dcerpc::Ndr::NdrLpByte
+    end
+  end
+
+  describe '#pad3' do
+    it 'is a string' do
+      expect(packet.pad1).to be_a BinData::String
+    end
+
+    it 'should keep #dw_depend_size 4-byte aligned' do
+      packet.lp_dependencies = [1, 2, 3, 4]
+      expect(packet.dw_depend_size.abs_offset % 4).to eq 0
+    end
+  end
+
+  describe '#dw_depend_size' do
+    it 'is a 32-bit unsigned integer' do
+      expect(packet.dw_depend_size).to be_a BinData::Uint32le
+    end
+  end
+
+  describe '#lp_service_start_name' do
+    it 'is a NdrLpStr structure' do
+      expect(packet.lp_service_start_name).to be_a RubySMB::Dcerpc::Ndr::NdrLpStr
+    end
+  end
+
+  describe '#pad4' do
+    it 'is a string' do
+      expect(packet.pad1).to be_a BinData::String
+    end
+
+    it 'should keep #lp_password 4-byte aligned' do
+      packet.lp_service_start_name = "test"
+      expect(packet.lp_password.abs_offset % 4).to eq 0
+    end
+  end
+
+  describe '#lp_password' do
+    it 'is a NdrLpByte structure' do
+      expect(packet.lp_password).to be_a RubySMB::Dcerpc::Ndr::NdrLpByte
+    end
+  end
+
+  describe '#pad5' do
+    it 'is a string' do
+      expect(packet.pad1).to be_a BinData::String
+    end
+
+    it 'should keep #dw_pw_size 4-byte aligned' do
+      packet.lp_password = [1, 2, 3, 4]
+      expect(packet.dw_pw_size.abs_offset % 4).to eq 0
+    end
+  end
+
+  describe '#dw_pw_size' do
+    it 'is a 32-bit unsigned integer' do
+      expect(packet.dw_pw_size).to be_a BinData::Uint32le
+    end
+
+    it 'has a value set to #lp_password.max_count' do
+      packet.lp_password.max_count = 33
+      expect(packet.dw_pw_size).to eq(33)
+    end
+  end
+
+  describe '#lp_display_name' do
+    it 'is a NdrLpStr structure' do
+      expect(packet.lp_display_name).to be_a RubySMB::Dcerpc::Ndr::NdrLpStr
+    end
+  end
+
+  describe '#initialize_instance' do
+    it 'sets #opnum to CHANGE_SERVICE_CONFIG_W constant' do
+      expect(packet.opnum).to eq(RubySMB::Dcerpc::Svcctl::CHANGE_SERVICE_CONFIG_W)
+    end
+  end
+
+  it 'reads its own binary representation and outputs the same packet' do
+    packet = described_class.new(
+      h_service: {context_handle_attributes: 0, context_handle_uuid: '367abb81-9844-35f1-ad32-98f038001003'},
+      dw_service_type: 33,
+      dw_start_type: 3,
+      dw_error_control: 11,
+      lp_binary_path_name: 'test',
+      lp_load_order_group: 'test2',
+      dw_tag_id: 4,
+      lp_dependencies: [1,2],
+      dw_depend_size: 2,
+      lp_service_start_name: 'test3',
+      lp_password: [1,2,3],
+      dw_pw_size: 3,
+      lp_display_name: 'test4'
+    )
+    binary = packet.to_binary_s
+    expect(described_class.read(binary)).to eq(packet)
+  end
+end
+

data/spec/lib/ruby_smb/dcerpc/svcctl/change_service_config_w_response_spec.rb

@@ -0,0 +1,38 @@
+RSpec.describe RubySMB::Dcerpc::Svcctl::ChangeServiceConfigWResponse do
+  subject(:packet) { described_class.new }
+
+  it { is_expected.to respond_to :dw_tag_id }
+  it { is_expected.to respond_to :error_status }
+
+  it 'is little endian' do
+    expect(described_class.fields.instance_variable_get(:@hints)[:endian]).to eq :little
+  end
+
+  describe '#dw_tag_id' do
+    it 'is a NdrLpDword structure' do
+      expect(packet.dw_tag_id).to be_a RubySMB::Dcerpc::Ndr::NdrLpDword
+    end
+  end
+
+  describe '#error_status' do
+    it 'is a 32-bit unsigned integer' do
+      expect(packet.error_status).to be_a BinData::Uint32le
+    end
+  end
+
+  describe '#initialize_instance' do
+    it 'sets #opnum to CHANGE_SERVICE_CONFIG_W constant' do
+      expect(packet.opnum).to eq(RubySMB::Dcerpc::Svcctl::CHANGE_SERVICE_CONFIG_W)
+    end
+  end
+
+  it 'reads its own binary representation and outputs the same packet' do
+    packet = described_class.new(
+      dw_tag_id: 4,
+      error_status: 1
+    )
+    binary = packet.to_binary_s
+    expect(described_class.read(binary)).to eq(packet)
+  end
+end
+