ruby_smb 0.0.18 → 0.0.19

data/spec/lib/ruby_smb/smb1/packet/nt_trans/create_request_spec.rb

@@ -92,8 +92,16 @@ RSpec.describe RubySMB::SMB1::Packet::NtTrans::CreateRequest do
       it { is_expected.to respond_to :name }
 
       describe '#desired_access' do
-        it 'is a File Access Mask' do
-          expect(parameters.desired_access).to be_a RubySMB::SMB1::BitField::FileAccessMask
+        it 'should be a DirectoryAccessMask when the file is a directory' do
+          parameters.ext_file_attribute.directory = 1
+          access_mask = parameters.desired_access.send(:current_choice)
+          expect(access_mask.class).to eq RubySMB::SMB1::BitField::DirectoryAccessMask
+        end
+
+        it 'should be a FileAccessMask when the file is not a directory' do
+          parameters.ext_file_attribute.directory = 0
+          access_mask = parameters.desired_access.send(:current_choice)
+          expect(access_mask.class).to eq RubySMB::SMB1::BitField::FileAccessMask
         end
       end
 
@@ -172,7 +180,7 @@ RSpec.describe RubySMB::SMB1::Packet::NtTrans::CreateRequest do
     end
 
     describe '#trans2_data' do
-      subject(:data) { data_block.trans2_data}
+      subject(:data) { data_block.trans2_data }
 
       it { is_expected.to respond_to :security_descriptor }
       it { is_expected.to respond_to :extended_attributes }
@@ -185,10 +193,9 @@ RSpec.describe RubySMB::SMB1::Packet::NtTrans::CreateRequest do
 
       describe '#extended_attributes' do
         it 'is a FileFullEAInfo struct' do
-          expect(data.extended_attributes).to be_a RubySMB::Field::FileFullEaInfo
+          expect(data.extended_attributes).to be_a RubySMB::Fscc::FileFullEaInfo
         end
       end
     end
-
   end
-end
+end

data/spec/lib/ruby_smb/smb1/packet/nt_trans/create_response_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 RSpec.describe RubySMB::SMB1::Packet::NtTrans::CreateResponse do
-
   subject(:packet) { described_class.new }
 
   describe '#smb_header' do
@@ -55,8 +54,6 @@ RSpec.describe RubySMB::SMB1::Packet::NtTrans::CreateResponse do
   describe '#data_block' do
     subject(:data_block) { packet.data_block }
 
-    it { is_expected.to be_a RubySMB::SMB1::Packet::Trans2::DataBlock }
-
     describe '#trans2_data' do
       it 'should be a 0-byte string' do
         expect(data_block.trans2_data.length).to eq 0
@@ -116,9 +113,6 @@ RSpec.describe RubySMB::SMB1::Packet::NtTrans::CreateResponse do
           expect(parameters.nmpipe_status).to be_a RubySMB::SMB1::BitField::SmbNmpipeStatus
         end
       end
-
     end
   end
-
-
-end
+end

data/spec/lib/ruby_smb/smb1/packet/nt_trans/request_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 RSpec.describe RubySMB::SMB1::Packet::NtTrans::Request do
-
   subject(:packet) { described_class.new }
 
   describe '#smb_header' do
@@ -39,7 +38,6 @@ RSpec.describe RubySMB::SMB1::Packet::NtTrans::Request do
     it { is_expected.to respond_to :data_offset }
     it { is_expected.to respond_to :setup_count }
 
-
     describe 'parameter_count' do
       it 'is a count of bytes in the data_block trans2_parameters field' do
         packet.data_block.trans2_parameters = "\x00\x01\x02\x03"
@@ -84,8 +82,5 @@ RSpec.describe RubySMB::SMB1::Packet::NtTrans::Request do
     it 'should keep #trans2_data 4-byte aligned' do
       expect(data_block.trans2_data.abs_offset % 4).to eq 0
     end
-
   end
-
-
-end
+end

data/spec/lib/ruby_smb/smb1/packet/nt_trans/response_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 RSpec.describe RubySMB::SMB1::Packet::NtTrans::Response do
-
   subject(:packet) { described_class.new }
 
   describe '#smb_header' do
@@ -35,7 +34,6 @@ RSpec.describe RubySMB::SMB1::Packet::NtTrans::Response do
     it { is_expected.to respond_to :data_offset }
     it { is_expected.to respond_to :setup_count }
 
-
     describe 'parameter_count' do
       it 'is a count of bytes in the data_block trans2_parameters field' do
         packet.data_block.trans2_parameters = "\x00\x01\x02\x03"
@@ -70,6 +68,4 @@ RSpec.describe RubySMB::SMB1::Packet::NtTrans::Response do
       expect(data_block).to be_a RubySMB::SMB1::Packet::NtTrans::Request::DataBlock
     end
   end
-
-
-end
+end

data/spec/lib/ruby_smb/smb1/packet/read_andx_request_spec.rb

@@ -0,0 +1,149 @@
+RSpec.describe RubySMB::SMB1::Packet::ReadAndxRequest do
+  subject(:packet) { described_class.new }
+
+  describe '#smb_header' do
+    subject(:header) { packet.smb_header }
+
+    it 'is a standard SMB Header' do
+      expect(header).to be_a RubySMB::SMB1::SMBHeader
+    end
+
+    it 'should have the command set to SMB_COM_READ_ANDX' do
+      expect(header.command).to eq RubySMB::SMB1::Commands::SMB_COM_READ_ANDX
+    end
+
+    it 'should not have the response flag set' do
+      expect(header.flags.reply).to eq 0
+    end
+  end
+
+  describe '#parameter_block' do
+    subject(:parameter_block) { packet.parameter_block }
+
+    it 'is a standard ParameterBlock' do
+      expect(parameter_block).to be_a RubySMB::SMB1::ParameterBlock
+    end
+
+    it 'is little endian' do
+      expect(parameter_block.get_parameter(:endian).endian).to eq :little
+    end
+
+    describe '#word_count' do
+      it 'is set to the correct default value' do
+        expect(parameter_block.word_count).to eq(0x0A)
+      end
+    end
+
+    it { is_expected.to respond_to :andx_block }
+    it { is_expected.to respond_to :fid }
+    it { is_expected.to respond_to :offset }
+    it { is_expected.to respond_to :max_count_of_bytes_to_return }
+    it { is_expected.to respond_to :min_count_of_bytes_to_return }
+    it { is_expected.to respond_to :timeout_or_max_count_high }
+    it { is_expected.to respond_to :remaining }
+    it { is_expected.to respond_to :offset_high }
+    it { is_expected.to respond_to :read_from_named_pipe }
+
+    describe '#andx_block' do
+      it 'is a AndXBlock struct' do
+        expect(parameter_block.andx_block).to be_a RubySMB::SMB1::AndXBlock
+      end
+    end
+
+    describe '#timeout_or_max_count_high' do
+      it 'is a #timeout field when the target is a named pipe' do
+        parameter_block.read_from_named_pipe = true
+        expect(parameter_block.timeout_or_max_count_high).to respond_to :timeout
+        expect(parameter_block.timeout_or_max_count_high).not_to respond_to :max_count_high
+      end
+
+      it 'is a #max_count_high field when the target is a file or a directory' do
+        parameter_block.read_from_named_pipe = false
+        expect(parameter_block.timeout_or_max_count_high).not_to respond_to :timeout
+        expect(parameter_block.timeout_or_max_count_high).to respond_to :max_count_high
+      end
+    end
+
+    describe '#offset_high' do
+      it 'exists when word_count is 0x0C' do
+        parameter_block.word_count = 0x0C
+        expect(parameter_block.offset_high?).to be true
+      end
+
+      it 'does not exist when word_count is 0x0A' do
+        parameter_block.word_count = 0x0A
+        expect(parameter_block.offset_high?).to be false
+      end
+    end
+
+    describe '#read_from_named_pipe' do
+      it 'is set to the correct default value' do
+        expect(parameter_block.read_from_named_pipe).to eq(false)
+      end
+    end
+  end
+
+  describe '#data_block' do
+    subject(:data_block) { packet.data_block }
+
+    it 'is a standard DataBlock' do
+      expect(data_block).to be_a RubySMB::SMB1::DataBlock
+    end
+
+    it 'should be empty' do
+      expect(data_block.byte_count).to eq(0)
+    end
+  end
+
+  describe '#set_read_from_named_pipe' do
+    it 'sets the #read_from_named_pipe variable to true' do
+      packet.parameter_block.read_from_named_pipe = false
+      packet.set_read_from_named_pipe(true)
+      expect(packet.parameter_block.read_from_named_pipe).to be true
+    end
+
+    it 'sets the #read_from_named_pipe variable to false' do
+      packet.parameter_block.read_from_named_pipe = true
+      packet.set_read_from_named_pipe(false)
+      expect(packet.parameter_block.read_from_named_pipe).to be false
+    end
+
+    it 'raises an exception when the value is a String' do
+      expect { packet.set_read_from_named_pipe('true') }.to raise_error(ArgumentError)
+    end
+
+    it 'raises an exception when the value is a Numeric' do
+      expect { packet.set_read_from_named_pipe(1) }.to raise_error(ArgumentError)
+    end
+
+    it 'raises an exception when the value is a Symbol' do
+      expect { packet.set_read_from_named_pipe(:true) }.to raise_error(ArgumentError)
+    end
+  end
+
+  describe '#set_64_bit_offset' do
+    it 'sets the #word_count field to 0x0C when passing true' do
+      packet.parameter_block.word_count = 0
+      packet.set_64_bit_offset(true)
+      expect(packet.parameter_block.word_count).to eq(0x0C)
+    end
+
+    it 'sets the #word_count field to 0x0A when passing false' do
+      packet.parameter_block.word_count = 0
+      packet.set_64_bit_offset(false)
+      expect(packet.parameter_block.word_count).to eq(0x0A)
+    end
+
+    it 'raises an exception when the value is a String' do
+      expect { packet.set_64_bit_offset('true') }.to raise_error(ArgumentError)
+    end
+
+    it 'raises an exception when the value is a Numeric' do
+      expect { packet.set_64_bit_offset(1) }.to raise_error(ArgumentError)
+    end
+
+    it 'raises an exception when the value is a Symbol' do
+      expect { packet.set_64_bit_offset(:true) }.to raise_error(ArgumentError)
+    end
+  end
+end

data/spec/lib/ruby_smb/smb1/packet/read_andx_response_spec.rb

@@ -0,0 +1,93 @@
+RSpec.describe RubySMB::SMB1::Packet::ReadAndxResponse do
+  subject(:packet) { described_class.new }
+
+  describe '#smb_header' do
+    subject(:header) { packet.smb_header }
+
+    it 'is a standard SMB Header' do
+      expect(header).to be_a RubySMB::SMB1::SMBHeader
+    end
+
+    it 'should have the command set to SMB_COM_READ_ANDX' do
+      expect(header.command).to eq RubySMB::SMB1::Commands::SMB_COM_READ_ANDX
+    end
+
+    it 'should have the response flag set' do
+      expect(header.flags.reply).to eq 1
+    end
+  end
+
+  describe '#parameter_block' do
+    subject(:parameter_block) { packet.parameter_block }
+
+    it 'is a standard ParameterBlock' do
+      expect(parameter_block).to be_a RubySMB::SMB1::ParameterBlock
+    end
+
+    it 'is little endian' do
+      expect(parameter_block.get_parameter(:endian).endian).to eq :little
+    end
+
+    it { is_expected.to respond_to :andx_block }
+    it { is_expected.to respond_to :available }
+    it { is_expected.to respond_to :data_compaction_mode }
+    it { is_expected.to respond_to :data_length }
+    it { is_expected.to respond_to :data_offset }
+    it { is_expected.to respond_to :data_length_high }
+
+    describe '#andx_block' do
+      it 'is a AndXBlock struct' do
+        expect(parameter_block.andx_block).to be_a RubySMB::SMB1::AndXBlock
+      end
+    end
+
+    describe '#data_compaction_mode' do
+      it 'is set to the correct default value' do
+        expect(parameter_block.data_compaction_mode).to eq(0x0000)
+      end
+    end
+  end
+
+  describe '#data_block' do
+    subject(:data_block) { packet.data_block }
+
+    it 'is a standard DataBlock' do
+      expect(data_block).to be_a RubySMB::SMB1::DataBlock
+    end
+
+    it 'is little endian' do
+      expect(data_block.get_parameter(:endian).endian).to eq :little
+    end
+
+    it { is_expected.to respond_to :pad }
+    it { is_expected.to respond_to :data }
+
+    describe '#pad' do
+      it 'does not exist if byte_count is zero (no data in the data_block)' do
+        data_block.byte_count = 0
+        expect(data_block.pad?).to be false
+      end
+
+      it 'does not exist if the data_length is equal to byte_count' do
+        packet.parameter_block.data_length = 5
+        data_block.byte_count = 5
+        expect(data_block.pad?).to be false
+      end
+
+      it 'exists if the data_length is one byte less than byte_count' do
+        packet.parameter_block.data_length = 4
+        data_block.byte_count = 5
+        expect(data_block.pad?).to be true
+      end
+    end
+
+    describe '#data' do
+      it 'reads the number of bytes specified in the data_length field' do
+        data = 'Testing...'
+        packet.parameter_block.data_length = 4
+        data_block.data.read(data)
+        expect(data_block.data).to eq(data[0, 4])
+      end
+    end
+  end
+end

data/spec/lib/ruby_smb/smb1/packet/session_setup_legacy_request_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 RSpec.describe RubySMB::SMB1::Packet::SessionSetupLegacyRequest do
-
   subject(:packet) { described_class.new }
 
   describe '#smb_header' do
@@ -55,8 +54,5 @@ RSpec.describe RubySMB::SMB1::Packet::SessionSetupLegacyRequest do
     it { is_expected.to respond_to :primary_domain }
     it { is_expected.to respond_to :native_os }
     it { is_expected.to respond_to :native_lan_man }
-
   end
-
-
-end
+end

data/spec/lib/ruby_smb/smb1/packet/session_setup_legacy_response_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 RSpec.describe RubySMB::SMB1::Packet::SessionSetupLegacyResponse do
-
   subject(:packet) { described_class.new }
 
   describe '#smb_header' do
@@ -30,7 +29,6 @@ RSpec.describe RubySMB::SMB1::Packet::SessionSetupLegacyResponse do
     it { is_expected.to respond_to :andx_block }
     it { is_expected.to respond_to :action }
 
-
     it 'has an AndXBlock' do
       expect(parameter_block.andx_block).to be_a RubySMB::SMB1::AndXBlock
     end
@@ -47,6 +45,4 @@ RSpec.describe RubySMB::SMB1::Packet::SessionSetupLegacyResponse do
     it { is_expected.to respond_to :native_os }
     it { is_expected.to respond_to :native_lan_man }
   end
-
-
-end
+end

data/spec/lib/ruby_smb/smb1/packet/session_setup_request_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 RSpec.describe RubySMB::SMB1::Packet::SessionSetupRequest do
-
   subject(:packet) { described_class.new }
 
   describe '#smb_header' do
@@ -50,11 +49,10 @@ RSpec.describe RubySMB::SMB1::Packet::SessionSetupRequest do
     it { is_expected.to respond_to :security_blob }
     it { is_expected.to respond_to :native_os }
     it { is_expected.to respond_to :native_lan_man }
-
   end
 
   describe '#set_type1_blob' do
-    let(:fake_message) { "foo" }
+    let(:fake_message) { 'foo' }
 
     it 'calls the #gss_type1 method to create a blob' do
       expect(RubySMB::Gss).to receive(:gss_type1).with(fake_message).and_return(fake_message)
@@ -75,7 +73,7 @@ RSpec.describe RubySMB::SMB1::Packet::SessionSetupRequest do
   end
 
   describe '#set_type3_blob' do
-    let(:fake_message) { "foo" }
+    let(:fake_message) { 'foo' }
 
     it 'calls the #gss_type3 method to create a blob' do
       expect(RubySMB::Gss).to receive(:gss_type3).with(fake_message).and_return(fake_message)
@@ -94,7 +92,4 @@ RSpec.describe RubySMB::SMB1::Packet::SessionSetupRequest do
       expect(packet.parameter_block.security_blob_length).to eq fake_message.length
     end
   end
-
-
-
-end
+end

data/spec/lib/ruby_smb/smb1/packet/session_setup_response_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 RSpec.describe RubySMB::SMB1::Packet::SessionSetupResponse do
-
   subject(:packet) { described_class.new }
 
   describe '#smb_header' do
@@ -49,7 +48,7 @@ RSpec.describe RubySMB::SMB1::Packet::SessionSetupResponse do
   end
 
   describe '#set_type2_blob' do
-    let(:fake_message) { "foo" }
+    let(:fake_message) { 'foo' }
 
     it 'calls the #gss_type2 method to create a blob' do
       expect(RubySMB::Gss).to receive(:gss_type2).with(fake_message).and_return(fake_message)
@@ -68,5 +67,4 @@ RSpec.describe RubySMB::SMB1::Packet::SessionSetupResponse do
       expect(packet.parameter_block.security_blob_length).to eq fake_message.length
     end
   end
-
-end
+end