ruby_smb 0.0.18 → 0.0.19

data/spec/lib/ruby_smb/smb1/packet/close_request_spec.rb

@@ -0,0 +1,54 @@
+RSpec.describe RubySMB::SMB1::Packet::CloseRequest do
+  subject(:packet) { described_class.new }
+
+  describe '#smb_header' do
+    subject(:header) { packet.smb_header }
+
+    it 'is a standard SMB Header' do
+      expect(header).to be_a RubySMB::SMB1::SMBHeader
+    end
+
+    it 'should have the command set to SMB_COM_CLOSE' do
+      expect(header.command).to eq RubySMB::SMB1::Commands::SMB_COM_CLOSE
+    end
+
+    it 'should not have the response flag set' do
+      expect(header.flags.reply).to eq 0
+    end
+  end
+
+  describe '#parameter_block' do
+    subject(:parameter_block) { packet.parameter_block }
+
+    it 'is a standard ParameterBlock' do
+      expect(parameter_block).to be_a RubySMB::SMB1::ParameterBlock
+    end
+
+    it 'is little endian' do
+      expect(parameter_block.get_parameter(:endian).endian).to eq :little
+    end
+
+    it { is_expected.to respond_to :fid }
+    it { is_expected.to respond_to :last_time_modified }
+
+    describe '#last_time_modified' do
+      it 'has the correct initial value' do
+        expect(parameter_block.last_time_modified).to eq(0xFFFFFFFF)
+      end
+    end
+  end
+
+  describe '#data_block' do
+    subject(:data_block) { packet.data_block }
+
+    it 'is a standard DataBlock' do
+      expect(data_block).to be_a RubySMB::SMB1::DataBlock
+    end
+
+    it 'should be empty' do
+      expect(data_block.byte_count).to eq(0)
+    end
+  end
+
+end
+

data/spec/lib/ruby_smb/smb1/packet/close_response_spec.rb

@@ -0,0 +1,45 @@
+RSpec.describe RubySMB::SMB1::Packet::CloseResponse do
+  subject(:packet) { described_class.new }
+
+  describe '#smb_header' do
+    subject(:header) { packet.smb_header }
+
+    it 'is a standard SMB Header' do
+      expect(header).to be_a RubySMB::SMB1::SMBHeader
+    end
+
+    it 'should have the command set to SMB_COM_CLOSE' do
+      expect(header.command).to eq RubySMB::SMB1::Commands::SMB_COM_CLOSE
+    end
+
+    it 'should not have the response flag set' do
+      expect(header.flags.reply).to eq 1
+    end
+  end
+
+  describe '#parameter_block' do
+    subject(:parameter_block) { packet.parameter_block }
+
+    it 'is a standard ParameterBlock' do
+      expect(parameter_block).to be_a RubySMB::SMB1::ParameterBlock
+    end
+
+    it 'should be empty' do
+      expect(parameter_block.word_count).to eq(0)
+    end
+  end
+
+  describe '#data_block' do
+    subject(:data_block) { packet.data_block }
+
+    it 'is a standard DataBlock' do
+      expect(data_block).to be_a RubySMB::SMB1::DataBlock
+    end
+
+    it 'should be empty' do
+      expect(data_block.byte_count).to eq(0)
+    end
+  end
+
+end
+

data/spec/lib/ruby_smb/smb1/packet/echo_request_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 RSpec.describe RubySMB::SMB1::Packet::EchoRequest do
-
   subject(:packet) { described_class.new }
 
   describe '#smb_header' do
@@ -39,6 +38,4 @@ RSpec.describe RubySMB::SMB1::Packet::EchoRequest do
       expect(data_block).to be_a RubySMB::SMB1::DataBlock
     end
   end
-
-
-end
+end

data/spec/lib/ruby_smb/smb1/packet/echo_response_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 RSpec.describe RubySMB::SMB1::Packet::EchoResponse do
-
   subject(:packet) { described_class.new }
 
   describe '#smb_header' do
@@ -39,6 +38,4 @@ RSpec.describe RubySMB::SMB1::Packet::EchoResponse do
       expect(data_block).to be_a RubySMB::SMB1::DataBlock
     end
   end
-
-
-end
+end

data/spec/lib/ruby_smb/smb1/packet/error_packet_spec.rb

@@ -9,7 +9,6 @@ RSpec.describe RubySMB::SMB1::Packet::EmptyPacket do
     it 'is a standard SMB Header' do
       expect(header).to be_a RubySMB::SMB1::SMBHeader
     end
-
   end
 
   describe '#parameter_block' do
@@ -35,5 +34,4 @@ RSpec.describe RubySMB::SMB1::Packet::EmptyPacket do
       expect(data_block.to_binary_s).to eq "\x00\x00"
     end
   end
-
-end
+end

data/spec/lib/ruby_smb/smb1/packet/logoff_request_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 RSpec.describe RubySMB::SMB1::Packet::LogoffRequest do
-
   subject(:packet) { described_class.new }
 
   describe '#smb_header' do
@@ -41,6 +40,4 @@ RSpec.describe RubySMB::SMB1::Packet::LogoffRequest do
       expect(data_block).to be_a RubySMB::SMB1::DataBlock
     end
   end
-
-
-end
+end

data/spec/lib/ruby_smb/smb1/packet/logoff_response_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 RSpec.describe RubySMB::SMB1::Packet::LogoffResponse do
-
   subject(:packet) { described_class.new }
 
   describe '#smb_header' do
@@ -41,6 +40,4 @@ RSpec.describe RubySMB::SMB1::Packet::LogoffResponse do
       expect(data_block).to be_a RubySMB::SMB1::DataBlock
     end
   end
-
-
-end
+end

data/spec/lib/ruby_smb/smb1/packet/negotiate_request_spec.rb

@@ -71,7 +71,7 @@ RSpec.describe RubySMB::SMB1::Packet::NegotiateRequest do
 
   describe '#dialects' do
     it 'returns a ruby array of the dialect hashes' do
-      expect(packet.dialects).to eq [{:buffer_format=>2, :dialect_string=>"NT LM 0.12"}]
+      expect(packet.dialects).to eq [{ buffer_format: 2, dialect_string: 'NT LM 0.12' }]
     end
   end
 end

data/spec/lib/ruby_smb/smb1/packet/negotiate_response_extended_spec.rb

@@ -146,4 +146,41 @@ RSpec.describe RubySMB::SMB1::Packet::NegotiateResponseExtended do
       expect(packet.valid?).to be false
     end
   end
+
+  context 'with dialects' do
+    let(:dialects) do
+      dialects = []
+      dialects << RubySMB::SMB1::Dialect.read("\x02\x4e\x54\x20\x4c\x4d\x20\x30\x2e\x31\x32\x00")
+      dialects << RubySMB::SMB1::Dialect.read("\x02\x53\x4d\x42\x20\x32\x2e\x30\x30\x32\x00")
+      dialects
+    end
+
+    describe '#dialects=' do
+      it 'sets #dialects to the array of Dialects passed as argument' do
+        packet.dialects = dialects
+        expect(packet.instance_variable_get(:@dialects)).to eq dialects
+      end
+
+      it 'returns #dialects' do
+        expect(packet.dialects = dialects).to eq dialects
+      end
+
+      it 'raises an exception when one of the element of dialects is not a Dialect object' do
+        dialects << 'My Dialect'
+        expect { packet.dialects = dialects }.to raise_error(ArgumentError)
+      end
+    end
+
+    describe '#negotiated_dialect' do
+      it 'returns an empty string if #dialects is empty' do
+        expect(packet.negotiated_dialect).to eq ''
+      end
+
+      it 'returns the negotiated dialect' do
+        packet.parameter_block.dialect_index = 1
+        packet.dialects = dialects
+        expect(packet.negotiated_dialect).to eq 'SMB 2.002'
+      end
+    end
+  end
 end

data/spec/lib/ruby_smb/smb1/packet/negotiate_response_spec.rb

@@ -147,4 +147,41 @@ RSpec.describe RubySMB::SMB1::Packet::NegotiateResponse do
       expect(packet.valid?).to be false
     end
   end
+
+  context 'with dialects' do
+    let(:dialects) do
+      dialects = []
+      dialects << RubySMB::SMB1::Dialect.read("\x02\x4e\x54\x20\x4c\x4d\x20\x30\x2e\x31\x32\x00")
+      dialects << RubySMB::SMB1::Dialect.read("\x02\x53\x4d\x42\x20\x32\x2e\x30\x30\x32\x00")
+      dialects
+    end
+
+    describe '#dialects=' do
+      it 'sets #dialects to the array of Dialects passed as argument' do
+        packet.dialects = dialects
+        expect(packet.instance_variable_get(:@dialects)).to eq dialects
+      end
+
+      it 'returns #dialects' do
+        expect(packet.dialects = dialects).to eq dialects
+      end
+
+      it 'raises an exception when one of the element of dialects is not a Dialect object' do
+        dialects << 'My Dialect'
+        expect { packet.dialects = dialects }.to raise_error(ArgumentError)
+      end
+    end
+
+    describe '#negotiated_dialect' do
+      it 'returns an empty string if #dialects is empty' do
+        expect(packet.negotiated_dialect).to eq ''
+      end
+
+      it 'returns the negotiated dialect' do
+        packet.parameter_block.dialect_index = 1
+        packet.dialects = dialects
+        expect(packet.negotiated_dialect).to eq 'SMB 2.002'
+      end
+    end
+  end
 end

data/spec/lib/ruby_smb/smb1/packet/nt_create_andx_request_spec.rb

@@ -0,0 +1,151 @@
+RSpec.describe RubySMB::SMB1::Packet::NtCreateAndxRequest do
+  subject(:packet) { described_class.new }
+
+  describe '#smb_header' do
+    subject(:header) { packet.smb_header }
+
+    it 'is a standard SMB Header' do
+      expect(header).to be_a RubySMB::SMB1::SMBHeader
+    end
+
+    it 'should have the command set to SMB_COM_NT_CREATE_ANDX' do
+      expect(header.command).to eq RubySMB::SMB1::Commands::SMB_COM_NT_CREATE_ANDX
+    end
+
+    it 'should not have the response flag set' do
+      expect(header.flags.reply).to eq 0
+    end
+  end
+
+  describe '#parameter_block' do
+    subject(:parameter_block) { packet.parameter_block }
+
+    it 'is a standard ParameterBlock' do
+      expect(parameter_block).to be_a RubySMB::SMB1::ParameterBlock
+    end
+
+    it 'is little endian' do
+      expect(parameter_block.get_parameter(:endian).endian).to eq :little
+    end
+
+    it { is_expected.to respond_to :andx_block }
+    it { is_expected.to respond_to :name_length }
+    it { is_expected.to respond_to :flags }
+    it { is_expected.to respond_to :root_directory_fid }
+    it { is_expected.to respond_to :desired_access }
+    it { is_expected.to respond_to :allocation_size }
+    it { is_expected.to respond_to :ext_file_attributes }
+    it { is_expected.to respond_to :share_access }
+    it { is_expected.to respond_to :create_disposition }
+    it { is_expected.to respond_to :create_options }
+    it { is_expected.to respond_to :impersonation_level }
+    it { is_expected.to respond_to :security_flags }
+
+    describe '#andx_block' do
+      it 'is a AndXBlock struct' do
+        expect(parameter_block.andx_block).to be_a RubySMB::SMB1::AndXBlock
+      end
+    end
+
+    describe '#name_length' do
+      it 'is updated according to the #file_name length' do
+        file_name = 'test_name'
+        packet.data_block.file_name = file_name
+        expect(parameter_block.name_length).to eq(file_name.length)
+      end
+    end
+
+    describe '#flags' do
+      subject(:flags) { parameter_block.flags }
+
+      it { is_expected.to respond_to :request_extended_response }
+      it { is_expected.to respond_to :open_target_dir }
+      it { is_expected.to respond_to :request_opbatch }
+      it { is_expected.to respond_to :request_oplock }
+
+      it 'is little endian' do
+        expect(flags.get_parameter(:endian).endian).to eq :little
+      end
+
+      describe '#request_extended_response' do
+        it 'is a 1-bit flag' do
+          expect(flags.request_extended_response).to be_a BinData::Bit1
+        end
+
+        it_behaves_like 'bit field with one flag set', :request_extended_response, 'V', 0x00000010
+      end
+
+      describe '#open_target_dir' do
+        it 'is a 1-bit flag' do
+          expect(flags.open_target_dir).to be_a BinData::Bit1
+        end
+
+        it_behaves_like 'bit field with one flag set', :open_target_dir, 'V', 0x00000008
+      end
+
+      describe '#request_opbatch' do
+        it 'is a 1-bit flag' do
+          expect(flags.request_opbatch).to be_a BinData::Bit1
+        end
+
+        it_behaves_like 'bit field with one flag set', :request_opbatch, 'V', 0x00000004
+      end
+
+      describe '#request_oplock' do
+        it 'is a 1-bit flag' do
+          expect(flags.request_oplock).to be_a BinData::Bit1
+        end
+
+        it_behaves_like 'bit field with one flag set', :request_oplock, 'V', 0x00000002
+      end
+    end
+
+    describe '#desired_access' do
+      it 'should be a DirectoryAccessMask when the file is a directory' do
+        parameter_block.ext_file_attributes.directory = 1
+        access_mask = parameter_block.desired_access.send(:current_choice)
+        expect(access_mask.class).to eq RubySMB::SMB1::BitField::DirectoryAccessMask
+      end
+
+      it 'should be a FileAccessMask when the file is not a directory' do
+        parameter_block.ext_file_attributes.directory = 0
+        access_mask = parameter_block.desired_access.send(:current_choice)
+        expect(access_mask.class).to eq RubySMB::SMB1::BitField::FileAccessMask
+      end
+    end
+
+    describe '#ext_file_attributes' do
+      it 'is a SmbExtFileAttributes bit-field' do
+        expect(parameter_block.ext_file_attributes).to be_a RubySMB::SMB1::BitField::SmbExtFileAttributes
+      end
+    end
+
+    describe '#share_access' do
+      it 'is a ShareAccess bit-field' do
+        expect(parameter_block.share_access).to be_a RubySMB::SMB1::BitField::ShareAccess
+      end
+    end
+
+    describe '#create_options' do
+      it 'is a CreateOptions bit-field' do
+        expect(parameter_block.create_options).to be_a RubySMB::SMB1::BitField::CreateOptions
+      end
+    end
+
+    describe '#security_flags' do
+      it 'is a SecurityFlags bit-field' do
+        expect(parameter_block.security_flags).to be_a RubySMB::SMB1::BitField::SecurityFlags
+      end
+    end
+  end
+
+  describe '#data_block' do
+    subject(:data_block) { packet.data_block }
+
+    it 'is a standard DataBlock' do
+      expect(data_block).to be_a RubySMB::SMB1::DataBlock
+    end
+
+    it { is_expected.to respond_to :file_name }
+  end
+end

data/spec/lib/ruby_smb/smb1/packet/nt_create_andx_response_spec.rb

@@ -0,0 +1,157 @@
+RSpec.describe RubySMB::SMB1::Packet::NtCreateAndxResponse do
+  subject(:packet) { described_class.new }
+
+  describe '#smb_header' do
+    subject(:header) { packet.smb_header }
+
+    it 'is a standard SMB Header' do
+      expect(header).to be_a RubySMB::SMB1::SMBHeader
+    end
+
+    it 'should have the command set to SMB_COM_NT_CREATE_ANDX' do
+      expect(header.command).to eq RubySMB::SMB1::Commands::SMB_COM_NT_CREATE_ANDX
+    end
+
+    it 'should have the response flag set' do
+      expect(header.flags.reply).to eq 1
+    end
+  end
+
+  describe '#parameter_block' do
+    subject(:parameter_block) { packet.parameter_block }
+
+    it 'is a standard ParameterBlock' do
+      expect(parameter_block).to be_a RubySMB::SMB1::ParameterBlock
+    end
+
+    it 'is little endian' do
+      expect(parameter_block.get_parameter(:endian).endian).to eq :little
+    end
+
+    it { is_expected.to respond_to :andx_block }
+    it { is_expected.to respond_to :oplock_level }
+    it { is_expected.to respond_to :fid }
+    it { is_expected.to respond_to :create_disposition }
+    it { is_expected.to respond_to :create_time }
+    it { is_expected.to respond_to :last_access_time }
+    it { is_expected.to respond_to :last_write_time }
+    it { is_expected.to respond_to :last_change_time }
+    it { is_expected.to respond_to :ext_file_attributes }
+    it { is_expected.to respond_to :allocation_size }
+    it { is_expected.to respond_to :end_of_file }
+    it { is_expected.to respond_to :resource_type }
+    it { is_expected.to respond_to :status_flags }
+    it { is_expected.to respond_to :directory }
+    it { is_expected.to respond_to :volume_guid }
+    it { is_expected.to respond_to :file_id }
+    it { is_expected.to respond_to :maximal_access_rights }
+    it { is_expected.to respond_to :guest_maximal_access_rights }
+
+    describe '#andx_block' do
+      it 'is a AndXBlock struct' do
+        expect(parameter_block.andx_block).to be_a RubySMB::SMB1::AndXBlock
+      end
+    end
+
+    describe '#create_time' do
+      it 'is as a FileTime struct' do
+        expect(parameter_block.create_time).to be_a RubySMB::Field::FileTime
+      end
+    end
+
+    describe '#last_access_time' do
+      it 'is as a FileTime struct' do
+        expect(parameter_block.last_access_time).to be_a RubySMB::Field::FileTime
+      end
+    end
+
+    describe '#last_write_time' do
+      it 'is as a FileTime struct' do
+        expect(parameter_block.last_write_time).to be_a RubySMB::Field::FileTime
+      end
+    end
+
+    describe '#last_change_time' do
+      it 'is as a FileTime struct' do
+        expect(parameter_block.last_change_time).to be_a RubySMB::Field::FileTime
+      end
+    end
+
+    describe '#ext_file_attributes' do
+      it 'is a SmbExtFileAttributes bit-field' do
+        expect(parameter_block.ext_file_attributes).to be_a RubySMB::SMB1::BitField::SmbExtFileAttributes
+      end
+    end
+
+    describe '#volume_guid' do
+      it 'has the correct length' do
+        expect(parameter_block.volume_guid.length).to eq 16
+      end
+    end
+
+    describe '#status_flag' do
+      it 'should be a SmbNmpipeStatus when the ResourceType is BYTE_MODE_PIPE' do
+        parameter_block.resource_type = RubySMB::SMB1::ResourceType::BYTE_MODE_PIPE
+        access_mask = parameter_block.status_flags.send(:current_choice)
+        expect(access_mask.class).to eq RubySMB::SMB1::BitField::SmbNmpipeStatus
+      end
+
+      it 'should be a SmbNmpipeStatus when the ResourceType is MESSAGE_MODE_PIPE' do
+        parameter_block.resource_type = RubySMB::SMB1::ResourceType::MESSAGE_MODE_PIPE
+        access_mask = parameter_block.status_flags.send(:current_choice)
+        expect(access_mask.class).to eq RubySMB::SMB1::BitField::SmbNmpipeStatus
+      end
+
+      it 'should be a SmbNmpipeStatus when the ResourceType is DISK' do
+        parameter_block.resource_type = RubySMB::SMB1::ResourceType::DISK
+        access_mask = parameter_block.status_flags.send(:current_choice)
+        expect(access_mask.class).to eq RubySMB::SMB1::BitField::FileStatusFlags
+      end
+
+      it 'should be a SmbNmpipeStatus when the ResourceType is BYTE_MODE_PIPE' do
+        parameter_block.resource_type = RubySMB::SMB1::ResourceType::PRINTER
+        expect(parameter_block.status_flags).to eq(0x0000)
+      end
+    end
+
+    describe '#maximal_access_rights' do
+      it 'should be a DirectoryAccessMask when the file is a directory' do
+        parameter_block.ext_file_attributes.directory = 1
+        access_mask = parameter_block.maximal_access_rights.send(:current_choice)
+        expect(access_mask.class).to eq RubySMB::SMB1::BitField::DirectoryAccessMask
+      end
+
+      it 'should be a FileAccessMask when the file is not a directory' do
+        parameter_block.ext_file_attributes.directory = 0
+        access_mask = parameter_block.maximal_access_rights.send(:current_choice)
+        expect(access_mask.class).to eq RubySMB::SMB1::BitField::FileAccessMask
+      end
+    end
+
+    describe '#guest_maximal_access_rights' do
+      it 'should be a DirectoryAccessMask when the file is a directory' do
+        parameter_block.ext_file_attributes.directory = 1
+        access_mask = parameter_block.guest_maximal_access_rights.send(:current_choice)
+        expect(access_mask.class).to eq RubySMB::SMB1::BitField::DirectoryAccessMask
+      end
+
+      it 'should be a FileAccessMask when the file is not a directory' do
+        parameter_block.ext_file_attributes.directory = 0
+        access_mask = parameter_block.guest_maximal_access_rights.send(:current_choice)
+        expect(access_mask.class).to eq RubySMB::SMB1::BitField::FileAccessMask
+      end
+    end
+  end
+
+  describe '#data_block' do
+    subject(:data_block) { packet.data_block }
+
+    it 'is a standard DataBlock' do
+      expect(data_block).to be_a RubySMB::SMB1::DataBlock
+    end
+
+    it 'should be empty' do
+      expect(data_block.byte_count).to eq(0)
+    end
+  end
+end