ruby_raider 3.13.0 → 4.0.0

data/spec/integration/scaffolding_e2e_spec.rb

@@ -20,13 +20,6 @@ end
 # End-to-end scaffolding tests that verify the scaffold command creates the right
 # files with the right content across all automation × framework combinations.
 describe 'Scaffolding E2E' do
-  def self.scaffold_style(framework)
-    case framework
-    when 'rspec'    then :spec
-    when 'cucumber' then :feature
-    end
-  end
-
   # Build a minimal mock project that the scaffolding system can detect.
   def self.build_mock_project(automation, framework)
     dir = File.expand_path("tmp_scaffold_e2e_#{framework}_#{automation}")
@@ -38,21 +31,13 @@ describe 'Scaffolding E2E' do
     FileUtils.mkdir_p("#{dir}/config")
     FileUtils.mkdir_p("#{dir}/models/data")
 
-    case framework
-    when 'rspec'    then FileUtils.mkdir_p("#{dir}/spec")
-    when 'cucumber' then FileUtils.mkdir_p("#{dir}/features/step_definitions")
-                         FileUtils.mkdir_p("#{dir}/features/support")
-    end
+    FileUtils.mkdir_p("#{dir}/spec")
 
     gems = []
     case automation
-    when 'selenium'  then gems << "gem 'selenium-webdriver'"
-    when 'watir'     then gems << "gem 'watir'"
-    end
-    case framework
-    when 'rspec'    then gems << "gem 'rspec'"
-    when 'cucumber' then gems << "gem 'cucumber'"
+    when 'selenium' then gems << "gem 'selenium-webdriver'"
     end
+    gems << "gem 'rspec'"
     File.write("#{dir}/Gemfile", "#{gems.join("\n")}\n")
     File.write("#{dir}/config/config.yml", "browser: chrome\nurl: http://localhost:3000\n")
     File.write("#{dir}/page_objects/abstract/page.rb", "class Page; end\n")
@@ -100,28 +85,6 @@ describe 'Scaffolding E2E' do
     it 'does not have capybara fill_in' do
       expect(page_content).not_to include('fill_in')
     end
-
-    it 'does not have watir browser.text_field' do
-      expect(page_content).not_to include('browser.text_field')
-    end
-  end
-
-  shared_examples 'watir scaffolded page' do
-    it 'has browser.text_field example' do
-      expect(page_content).to include('browser.text_field')
-    end
-
-    it 'has private section' do
-      expect(page_content).to include('private')
-    end
-
-    it 'does not have selenium find_element' do
-      expect(page_content).not_to include('driver.find_element')
-    end
-
-    it 'does not have capybara fill_in' do
-      expect(page_content).not_to include('fill_in')
-    end
   end
 
   # ──────────────────────────────────────────────
@@ -150,7 +113,7 @@ describe 'Scaffolding E2E' do
     end
 
     it 'has before block with navigation' do
-      expect(spec_content).to include('before do')
+      expect(spec_content).to include('before { page.visit }')
     end
   end
 
@@ -159,8 +122,9 @@ describe 'Scaffolding E2E' do
       expect(spec_content).to include('CheckoutPage.new(driver)')
     end
 
-    it 'navigates with driver' do
-      expect(spec_content).to include('driver.navigate.to')
+    it 'visits through the page object, which joins the config url and the page path' do
+      expect(spec_content).to include('before { page.visit }')
+      expect(spec_content).not_to include('project_config', 'driver.navigate.to')
     end
 
     it 'does not use capybara visit' do
@@ -168,80 +132,6 @@ describe 'Scaffolding E2E' do
     end
   end
 
-  shared_examples 'watir scaffolded spec' do
-    it 'instantiates page with browser' do
-      expect(spec_content).to include('CheckoutPage.new(browser)')
-    end
-
-    it 'navigates with browser.goto' do
-      expect(spec_content).to include('browser.goto')
-    end
-  end
-
-  # ──────────────────────────────────────────────
-  # Shared examples: Feature content (Cucumber)
-  # ──────────────────────────────────────────────
-
-  shared_examples 'valid scaffolded feature' do
-    it 'has Feature keyword' do
-      expect(feature_content).to include('Feature: Checkout')
-    end
-
-    it 'has Scenario keyword' do
-      expect(feature_content).to include('Scenario: Scenario name')
-    end
-
-    it 'has Given/When/Then steps' do
-      expect(feature_content).to include('Given I am on the checkout page')
-      expect(feature_content).to include('When I perform an action')
-      expect(feature_content).to include('Then I see the expected result')
-    end
-  end
-
-  # ──────────────────────────────────────────────
-  # Shared examples: Steps content (Cucumber)
-  # ──────────────────────────────────────────────
-
-  shared_examples 'valid scaffolded steps' do
-    it 'has frozen_string_literal' do
-      expect(steps_content).to have_frozen_string_literal
-    end
-
-    it 'has valid Ruby syntax' do
-      expect(steps_content).to have_valid_ruby_syntax
-    end
-
-    it 'requires the page object' do
-      expect(steps_content).to include("require_relative '../../page_objects/pages/checkout'")
-    end
-
-    it 'has Given/When/Then blocks' do
-      expect(steps_content).to include("Given('I am on the checkout page')")
-      expect(steps_content).to include("When('I perform an action')")
-      expect(steps_content).to include("Then('I see the expected result')")
-    end
-
-    it 'has pending steps' do
-      expect(steps_content).to include("pending 'implement step'")
-    end
-  end
-
-  shared_examples 'selenium scaffolded steps' do
-    it 'instantiates page with driver' do
-      expect(steps_content).to include('CheckoutPage.new(driver)')
-    end
-
-    it 'does not use capybara visit' do
-      expect(steps_content).not_to match(/^\s+visit '/)
-    end
-  end
-
-  shared_examples 'watir scaffolded steps' do
-    it 'instantiates page with browser' do
-      expect(steps_content).to include('CheckoutPage.new(browser)')
-    end
-  end
-
   # ──────────────────────────────────────────────
   # Shared examples: Helper content
   # ──────────────────────────────────────────────
@@ -287,22 +177,8 @@ describe 'Scaffolding E2E' do
   end
 
   shared_examples 'selenium scaffolded component' do
-    it 'has driver.find_element example' do
-      expect(component_content).to include('driver.find_element')
-    end
-
-    it 'has private section' do
-      expect(component_content).to include('private')
-    end
-
-    it 'has content method' do
-      expect(component_content).to include('def content')
-    end
-  end
-
-  shared_examples 'watir scaffolded component' do
-    it 'has browser.element example' do
-      expect(component_content).to include('browser.element')
+    it 'has component.find_element example' do
+      expect(component_content).to include('component.find_element')
     end
 
     it 'has private section' do
@@ -318,10 +194,8 @@ describe 'Scaffolding E2E' do
   # Test matrix: automation × framework
   # ══════════════════════════════════════════════
 
-  %w[selenium watir].each do |automation|
-    %w[rspec cucumber].each do |framework|
-      style = scaffold_style(framework)
-
+  %w[selenium].each do |automation|
+    %w[rspec].each do |framework|
       context "with #{framework} and #{automation}" do
         let(:scaffold) { ScaffoldingCommands }
 
@@ -350,56 +224,24 @@ describe 'Scaffolding E2E' do
           after do
             FileUtils.rm_f('page_objects/pages/checkout.rb')
             FileUtils.rm_f('spec/checkout_page_spec.rb')
-            if framework == 'cucumber'
-              FileUtils.rm_f('features/checkout.feature')
-              FileUtils.rm_f('features/step_definitions/checkout_steps.rb')
-            else
-              FileUtils.rm_rf('features')
-              FileUtils.rm_rf('spec') unless framework == 'rspec'
-            end
           end
 
-          # Page content validation
           let(:page_content) { File.read('page_objects/pages/checkout.rb') }
+          let(:spec_content) { File.read('spec/checkout_page_spec.rb') }
 
           it 'creates page object' do
             expect(Pathname.new('page_objects/pages/checkout.rb')).to be_file
           end
 
-          if style == :spec
-            it 'creates spec file' do
-              expect(Pathname.new('spec/checkout_page_spec.rb')).to be_file
-            end
-
-            it 'does not create feature file' do
-              expect(Pathname.new('features/checkout.feature')).not_to be_file
-            end
-          else # :feature
-            it 'creates feature file' do
-              expect(Pathname.new('features/checkout.feature')).to be_file
-            end
-
-            it 'creates steps file' do
-              expect(Pathname.new('features/step_definitions/checkout_steps.rb')).to be_file
-            end
+          it 'creates spec file' do
+            expect(Pathname.new('spec/checkout_page_spec.rb')).to be_file
           end
 
           include_examples 'valid scaffolded page'
           include_examples "#{automation} scaffolded page"
 
-          # Test content validation (depends on scaffold style)
-          if style == :spec
-            let(:spec_content) { File.read('spec/checkout_page_spec.rb') }
-            include_examples 'valid scaffolded spec'
-            include_examples "#{automation} scaffolded spec"
-          else # :feature
-            let(:feature_content) { File.read('features/checkout.feature') }
-            include_examples 'valid scaffolded feature'
-
-            let(:steps_content) { File.read('features/step_definitions/checkout_steps.rb') }
-            include_examples 'valid scaffolded steps'
-            include_examples "#{automation} scaffolded steps"
-          end
+          include_examples 'valid scaffolded spec'
+          include_examples "#{automation} scaffolded spec"
         end
 
         # ── Component scaffold ─────────────────
@@ -442,17 +284,13 @@ describe 'Scaffolding E2E' do
             %w[search filter].each do |name|
               FileUtils.rm_f("page_objects/pages/#{name}.rb")
               FileUtils.rm_f("spec/#{name}_page_spec.rb")
-              FileUtils.rm_f("features/#{name}.feature")
-              FileUtils.rm_f("features/step_definitions/#{name}_steps.rb")
             end
-            FileUtils.rm_rf('features') unless framework == 'cucumber'
-            FileUtils.rm_rf('spec') unless framework == 'rspec'
           end
 
           it 'generates multiple scaffolds at once' do
             scaffold.new.invoke(:scaffold, nil, %w[search filter])
             files = %w[search filter].flat_map do |name|
-              ["page_objects/pages/#{name}.rb", style == :spec ? "spec/#{name}_page_spec.rb" : "features/#{name}.feature"]
+              ["page_objects/pages/#{name}.rb", "spec/#{name}_page_spec.rb"]
             end
             expect(files.reject { |file| File.file?(file) }).to be_empty
           end

data/spec/integration/spec_helper.rb

@@ -5,21 +5,19 @@ require 'rspec'
 require_relative '../../lib/generators/invoke_generators'
 require_relative 'settings_helper'
 
-AUTOMATION_TYPES = %w[android ios selenium watir cross_platform].freeze
-FRAMEWORKS = %w[cucumber rspec].freeze
+AUTOMATION_TYPES = %w[android ios selenium cross_platform].freeze
+FRAMEWORKS = %w[rspec].freeze
 
 # Named constants for readable spec references — no more fragile numeric indices
 module FrameworkIndex
-  CUCUMBER  = FRAMEWORKS[0]
-  RSPEC     = FRAMEWORKS[1]
+  RSPEC = FRAMEWORKS[0]
 end
 
 module AutomationIndex
   ANDROID        = AUTOMATION_TYPES[0]
   IOS            = AUTOMATION_TYPES[1]
   SELENIUM       = AUTOMATION_TYPES[2]
-  WATIR          = AUTOMATION_TYPES[3]
-  CROSS_PLATFORM = AUTOMATION_TYPES[4]
+  CROSS_PLATFORM = AUTOMATION_TYPES[3]
 end
 
 # Lazy project generation — only generates a project the first time it's needed.

data/spec/integration/trace_format_checker.rb

@@ -10,7 +10,7 @@ module TraceFormatChecker
   ENTRY_NAME = %r{\Atrace\.json\z|\Asteps/\d{4}\.(jpg|png|html|xml)\z}
   TIMESTAMP = /\A\d{4}-\d\d-\d\dT\d\d:\d\d:\d\d\.\d{3}Z\z/
   KINDS = %w[navigate action group failure].freeze
-  STRATEGIES = %w[id css xpath name link_text partial_link_text class_name tag_name].freeze
+  STRATEGIES = %w[id css xpath name link_text partial_link_text class_name tag_name role label placeholder alt title text test_id].freeze
   # The required keys and the types each may have: the top level, then every step.
   FIELDS = {
     top: {
@@ -42,7 +42,7 @@ module TraceFormatChecker
     problems.concat(error_rules('test', trace['test'])) if trace['test'].is_a?(Hash)
     return problems unless trace['steps'].is_a?(Array)
 
-    problems.concat(steps(trace['steps'], names)).concat(events(trace))
+    problems.concat(steps(trace['steps'], names)).concat(events(trace)).concat(mocked_rules(trace['network']))
   rescue Zip::Error, JSON::ParserError, Errno::ENOENT => e
     ["not a readable trace.zip: #{e.class}: #{e.message}"]
   end
@@ -129,6 +129,15 @@ module TraceFormatChecker
     end
   end
 
+  # mocked is optional on a network entry: "fulfilled" or "failed".
+  def self.mocked_rules(network)
+    Array(network).each_with_index.filter_map do |entry, position|
+      next unless entry.is_a?(Hash) && entry.key?('mocked') && !%w[fulfilled failed].include?(entry['mocked'])
+
+      "network[#{position}].mocked #{entry['mocked'].inspect} is not fulfilled or failed"
+    end
+  end
+
   def self.events(trace)
     count = [trace['steps'].size, 1].max
     %w[network console].flat_map do |list|

data/spec/integration/trace_page_server.rb

@@ -3,7 +3,8 @@
 require 'socket'
 
 # Serves the trace e2e page over HTTP on 127.0.0.1 (never file://), so the browser makes
-# real requests that WebDriver BiDi reports: the page, its same-origin stylesheet and /api.
+# real requests that WebDriver BiDi reports: the page (behind a redirect at /start), its same-origin
+# stylesheet and /api.
 class TracePageServer
   CSS_RULE = '#title { color: rgb(1, 2, 3); }'
   PAGE = <<~HTML
@@ -17,7 +18,7 @@ class TracePageServer
         <h1 id="title">Trace</h1>
         <input type="password" id="pw" placeholder="Password">
         <input type="text" id="pw2" autocomplete="current-password" placeholder="Confirm password">
-        <input id="name" placeholder="Name">
+        <form id="form" onsubmit="return false"><input id="name" placeholder="Name"></form>
         <button id="go">Go</button>
         <p id="status"></p>
         <script>
@@ -30,14 +31,58 @@ class TracePageServer
       </body>
     </html>
   HTML
+  # The network mocking e2e page: each button fetches one URL and writes the outcome into its <p>.
+  # /api/cors is cross-origin and unresolvable, and the custom header forces a preflight: it only works mocked.
+  MOCK_PAGE = <<~HTML
+    <!DOCTYPE html>
+    <html>
+      <head><title>Mock e2e</title></head>
+      <body>
+        <button id="users">Users</button><p id="users-out"></p>
+        <button id="fail">Fail</button><p id="fail-out"></p>
+        <button id="echo">Echo</button><p id="echo-out"></p>
+        <button id="cors">Cors</button><p id="cors-out"></p>
+        <script>
+          function show(id, promise, format, failure) {
+            promise.then(function (response) { return response.json(); })
+              .then(function (body) { document.getElementById(id + '-out').textContent = format(body); })
+              .catch(function () { document.getElementById(id + '-out').textContent = failure; });
+          }
+          document.getElementById('users').addEventListener('click', function () {
+            show('users', fetch('/api/users'), function (body) { return body.users.join(','); }, 'users failed');
+          });
+          document.getElementById('fail').addEventListener('click', function () {
+            show('fail', fetch('/api/fail'), function () { return 'fail reached the server'; }, 'request failed');
+          });
+          document.getElementById('echo').addEventListener('click', function () {
+            show('echo', fetch('/api/echo', { headers: { 'x-raider': 'no' } }),
+                 function (body) { return 'echo ' + body.raider; }, 'echo failed');
+          });
+          document.getElementById('cors').addEventListener('click', function () {
+            show('cors', fetch('http://mock.raider.test/api/cors', { headers: { 'x-a': '1' } }),
+                 function (body) { return 'cors ' + body.ok; }, 'cors failed');
+          });
+        </script>
+      </body>
+    </html>
+  HTML
   ROUTES = {
+    '/mock' => ['200 OK', 'text/html; charset=utf-8', MOCK_PAGE],
+    '/api/users' => ['200 OK', 'application/json', '{"users":["real"]}'],
+    '/api/fail' => ['200 OK', 'application/json', '{"ok":true}'],
     '/' => ['200 OK', 'text/html; charset=utf-8', PAGE],
     '/style.css' => ['200 OK', 'text/css', "#{CSS_RULE}\n"],
     '/api' => ['200 OK', 'application/json', '{"status":"answered by /api"}']
   }.freeze
+  # A first page that redirects, as a login does; BiDi gives both hops the same request id.
+  REDIRECTS = { '/start' => '/' }.freeze
   NOT_FOUND = ['404 Not Found', 'text/plain', 'not found'].freeze
   # /api answers this late, so a network entry's duration_ms has something to measure.
   API_DELAY = 0.3
+  # The page answers this late too, so the navigation's duration_ms is measurable.
+  PAGE_DELAY = 0.1
+
+  DELAYS = { '/' => PAGE_DELAY, '/api' => API_DELAY }.freeze
 
   attr_reader :url
 
@@ -64,12 +109,34 @@ class TracePageServer
     nil
   end
 
+  def redirect(socket, location)
+    socket.write("HTTP/1.1 302 Found\r\nLocation: #{location}\r\nContent-Length: 0\r\n" \
+                 "Cache-Control: no-store\r\nConnection: close\r\n\r\n")
+  end
+
+  # { lowercase name => value } of the request headers.
+  def read_headers(socket)
+    headers = {}
+    while (line = socket.gets) && line != "\r\n"
+      name, value = line.split(':', 2)
+      headers[name.downcase] = value.to_s.strip
+    end
+    headers
+  end
+
+  # Answers with the request's x-raider header.
+  def echo(headers)
+    ['200 OK', 'application/json', %({"raider":"#{headers.fetch('x-raider', 'none')}"})]
+  end
+
   def answer(socket)
     request_line = socket.gets.to_s
-    nil while (line = socket.gets) && line != "\r\n"
+    headers = read_headers(socket)
     path = request_line.split[1].to_s.split('?').first
-    status, type, body = ROUTES.fetch(path, NOT_FOUND)
-    sleep(API_DELAY) if path == '/api'
+    return redirect(socket, REDIRECTS[path]) if REDIRECTS.key?(path)
+
+    status, type, body = path == '/api/echo' ? echo(headers) : ROUTES.fetch(path, NOT_FOUND)
+    sleep(DELAYS.fetch(path, 0))
     socket.write("HTTP/1.1 #{status}\r\nContent-Type: #{type}\r\nContent-Length: #{body.bytesize}\r\n" \
                  "Cache-Control: no-store\r\nConnection: close\r\n\r\n#{body}")
   rescue StandardError => e

data/spec/menus/menu_generator_spec.rb

@@ -28,20 +28,6 @@ RSpec.describe MenuGenerator do
   end
 
   describe '#choose_test_framework' do
-    context 'with a web automation' do
-      it 'presents test framework selection' do
-        menu = double('menu') # rubocop:disable RSpec/VerifiedDoubles
-        allow(menu).to receive(:choice)
-        allow(prompt).to receive(:select).with('Please select your test framework').and_yield(menu)
-
-        menu_generator.choose_test_framework('selenium')
-
-        expect(menu).to have_received(:choice).with(:Cucumber, anything)
-        expect(menu).to have_received(:choice).with(:Rspec, anything)
-        expect(menu).to have_received(:choice).with(:Quit, anything)
-      end
-    end
-
     context 'with appium' do
       it 'presents mobile platform selection' do
         menu = double('menu') # rubocop:disable RSpec/VerifiedDoubles
@@ -108,26 +94,6 @@ RSpec.describe MenuGenerator do
     end
   end
 
-  describe 'full flow: watir + cucumber' do
-    it 'calls set_up_framework with correct options' do
-      allow(menu_generator).to receive(:generate_framework)
-      allow(menu_generator).to receive(:system)
-      allow(prompt).to receive(:say)
-      allow(prompt).to receive(:yes?).and_return(false)
-
-      menu_generator.send(:create_framework, 'Cucumber', 'watir')
-
-      expect(menu_generator).to have_received(:generate_framework).with(
-        hash_including(
-          automation: 'watir',
-          framework: 'cucumber',
-          accessibility: false,
-          name: 'test_project'
-        )
-      )
-    end
-  end
-
   describe 'full flow: selenium + rspec + accessibility' do
     it 'passes accessibility flag through' do
       allow(menu_generator).to receive(:generate_framework)
@@ -219,14 +185,23 @@ RSpec.describe MenuGenerator do
       allow(prompt).to receive(:yes?).and_return(false)
     end
 
-    it 'is asked after the test framework question' do
-      allow(prompt).to receive(:select).with('Please select your test framework').and_yield(menu)
-      allow(menu).to receive(:choice).with(:Rspec, anything) { |_, action| action.call }
+    it 'asks for example tests straight away, with no test framework question' do
+      allow(prompt).to receive(:select)
       allow(menu_generator).to receive(:select_examples)
 
       menu_generator.choose_test_framework('selenium')
 
       expect(menu_generator).to have_received(:select_examples).with('Rspec', 'selenium')
+      expect(prompt).not_to have_received(:select).with('Please select your test framework')
+    end
+
+    it 'prompts for example tests without ever offering Cucumber' do
+      allow(prompt).to receive(:select).with('Do you want example tests?').and_yield(menu)
+
+      menu_generator.choose_test_framework('selenium')
+
+      expect(menu).not_to have_received(:choice).with(:Cucumber, anything)
+      expect(menu).to have_received(:choice).with(:Yes, anything)
     end
 
     it 'offers Yes first, so yes is the default' do
@@ -261,10 +236,10 @@ RSpec.describe MenuGenerator do
       allow(prompt).to receive(:select).with('Do you want example tests?').and_yield(menu)
       allow(menu).to receive(:choice).with(:No, anything) { |_, action| action.call }
 
-      menu_generator.send(:select_examples, 'Cucumber', 'ios')
+      menu_generator.send(:select_examples, 'Rspec', 'ios')
 
       expect(menu_generator).to have_received(:generate_framework).with(
-        hash_including(automation: 'ios', framework: 'cucumber', examples: false)
+        hash_including(automation: 'ios', framework: 'rspec', examples: false)
       )
     end
   end