ruby_raider 3.13.0 → 4.0.0

data/spec/integration/content/test_content_spec.rb

@@ -55,67 +55,6 @@ describe 'Test file content' do
     end
   end
 
-  shared_examples 'watir rspec spec' do |project_name|
-    subject(:spec) { read_generated(project_name, 'spec/login_page_spec.rb') }
-
-    it 'instantiates Login with browser' do
-      expect(spec).to include('Login.new(browser)')
-    end
-
-    it 'uses visit method' do
-      expect(spec).to include('.visit')
-      expect(spec).not_to include('.visit_page')
-    end
-  end
-
-  # --- Cucumber features and steps ---
-
-  shared_examples 'valid cucumber feature' do |project_name|
-    subject(:feature) { read_generated(project_name, 'features/login.feature') }
-
-    it 'has Feature keyword' do
-      expect(feature).to match(/Feature:/)
-    end
-
-    it 'has Scenario keyword' do
-      expect(feature).to match(/Scenario:/)
-    end
-
-    it 'has Given/When/Then steps' do
-      expect(feature).to match(/Given/)
-      expect(feature).to match(/When/)
-      expect(feature).to match(/Then/)
-    end
-  end
-
-  shared_examples 'valid cucumber env' do |project_name|
-    subject(:env) { read_generated(project_name, 'features/support/env.rb') }
-
-    it 'has valid Ruby syntax' do
-      expect(env).to have_valid_ruby_syntax
-    end
-  end
-
-  shared_examples 'valid cucumber world' do |project_name|
-    subject(:world) { read_generated(project_name, 'features/support/world.rb') }
-
-    it 'has valid Ruby syntax' do
-      expect(world).to have_valid_ruby_syntax
-    end
-  end
-
-  shared_examples 'valid cucumber config' do |project_name|
-    subject(:config) { read_generated(project_name, 'cucumber.yml') }
-
-    it 'has default profile' do
-      expect(config).to include('default:')
-    end
-
-    it 'uses the pretty and rerun formatters, with the reporter activated from env.rb' do
-      expect(config.strip).to eq('default: --format pretty --format rerun --out rerun.txt --publish-quiet --retry 0')
-    end
-  end
-
   shared_examples 'logged in example' do |project_name|
     it 'adds a :logged_in example that reuses the saved login and keeps the login example' do
       spec = read_generated(project_name, 'spec/login_page_spec.rb')
@@ -124,19 +63,6 @@ describe 'Test file content' do
     end
   end
 
-  shared_examples 'logged in scenario' do |project_name|
-    it 'adds a @logged_in scenario and keeps the login scenario' do
-      feature = read_generated(project_name, 'features/login.feature')
-      expect(feature).to include("@logged_in\nScenario: A logged-in user opens the account page",
-                                 "Given I'm a registered user\n", 'Scenario: A user can login')
-    end
-
-    it 'defines the step that picks the user without logging in' do
-      steps = read_generated(project_name, 'features/step_definitions/login_steps.rb')
-      expect(steps).to include(%q(Given("I'm a {user}") do |user|))
-    end
-  end
-
   # --- RSpec contexts ---
 
   context 'with rspec and selenium' do
@@ -145,91 +71,41 @@ describe 'Test file content' do
     include_examples 'selenium rspec spec', name
     include_examples 'logged in example', name
   end
-
-  context 'with rspec and watir' do
-    name = "#{FrameworkIndex::RSPEC}_#{AutomationIndex::WATIR}"
-    include_examples 'valid rspec spec', name
-    include_examples 'watir rspec spec', name
-    include_examples 'logged in example', name
-  end
-
-  # --- Cucumber contexts ---
-
-  context 'with cucumber and selenium' do
-    name = "#{FrameworkIndex::CUCUMBER}_#{AutomationIndex::SELENIUM}"
-    include_examples 'valid cucumber feature', name
-    include_examples 'valid cucumber env', name
-    include_examples 'valid cucumber world', name
-    include_examples 'valid cucumber config', name
-    include_examples 'logged in scenario', name
-  end
-
-  context 'with cucumber and watir' do
-    name = "#{FrameworkIndex::CUCUMBER}_#{AutomationIndex::WATIR}"
-    include_examples 'valid cucumber feature', name
-    include_examples 'valid cucumber env', name
-    include_examples 'valid cucumber world', name
-    include_examples 'valid cucumber config', name
-    include_examples 'logged in scenario', name
-  end
 end
 
-describe 'Cucumber world WaitHelper wiring' do
-  %w[selenium ios android cross_platform].each do |automation|
-    it "makes WaitHelper available to steps in #{automation}" do
-      world = read_generated("cucumber_#{automation}", 'features/support/world.rb')
-      expect(world).to include("require_relative '../../helpers/wait_helper'", 'World(WaitHelper)')
-    end
-  end
-
-  it 'leaves the watir world without WaitHelper' do
-    expect(read_generated('cucumber_watir', 'features/support/world.rb')).not_to include('WaitHelper')
+describe 'Accessibility spec' do
+  it 'wraps the axe check in an immediate find' do
+    name = 'content_axe_rspec_selenium'
+    InvokeGenerators.generate_framework(automation: 'selenium', framework: 'rspec', name:, accessibility: true)
+    expect(read_generated(name, 'spec/accessibility_spec.rb'))
+      .to include('Raider::Wait.immediately { expect(driver).to be_axe_clean }')
+  ensure
+    FileUtils.rm_rf(name)
   end
 end
 
-describe 'Example tests on the wait helper' do
-  it 'wraps every assertion of the selenium rspec spec in eventually' do
+describe 'Example tests' do
+  it 'asserts the selenium rspec spec with have_text and no eventually' do
     spec = read_generated('rspec_selenium', 'spec/login_page_spec.rb')
-    expect(spec.scan('eventually { expect(').size).to eq(3)
-    expect(spec.scan(/^ +expect\(/)).to be_empty
-  end
-
-  it "wraps the selenium cucumber Then step's assertion in eventually" do
-    steps = read_generated('cucumber_selenium', 'features/step_definitions/login_steps.rb')
-    expect(steps).to include('eventually { expect(account_page.header.customer_name).to eq ')
+    expect(spec.scan('expect { account_page.welcome_message }.to have_text("Welcome back #{user[\'name\']}")').size).to eq(2)
+    expect(spec).to include("expect { login_page.welcome_message }.to have_text('Login or register')")
+    expect(spec).not_to include('eventually')
   end
 
   %w[ios android cross_platform].each do |automation|
-    it "wraps the #{automation} rspec assertion in eventually" do
+    it "asserts the #{automation} rspec spec with have_text and no eventually" do
       spec = read_generated("rspec_#{automation}", 'spec/pdp_page_spec.rb')
-      expect(spec).to include("eventually { expect(pdp_page.add_to_cart_text).to eq 'Add to Cart' }")
+      expect(spec).to include("expect { pdp_page.add_to_cart_button }.to have_text('Add to Cart')")
+      expect(spec).not_to include('eventually')
     end
 
-    it "wraps the #{automation} cucumber Then step's assertion in eventually" do
-      steps = read_generated("cucumber_#{automation}", 'features/step_definitions/home_steps.rb')
-      expect(steps).to include("eventually { expect(pdp_page.add_to_cart_text).to eq 'Add to Cart' }")
-    end
-  end
-end
-
-# The Watir output must stay as master generated it (1274a66), plus the 3.12.1 lint fixes; the snapshots in
-# spec/fixtures/watir_master were generated from that commit's lib.
-# To regenerate: `git archive 1274a66 lib` into a scratch dir, generate rspec and cucumber Watir projects there,
-# then apply only the Readme deprecation-line delta (the `> **Deprecated:**` line under the heading block) and
-# the 3.12.1 changes: RuboCop lint fixes (page.rb loses its extra blank lines, login_steps.rb ends with a newline)
-# plus the frozen_string_literal comments the syntax spec requires (Style/FrozenStringLiteralComment is disabled
-# in the generated .rubocop.yml, so RuboCop does not ask for them) on the Watir page, world and user_factory files.
-describe 'Watir example output' do
-  snapshots = File.expand_path('../../fixtures/watir_master', __dir__)
-
-  { 'rspec_watir' => %w[page_objects/pages/login.rb page_objects/abstract/page.rb spec/login_page_spec.rb Readme.md],
-    'cucumber_watir' => %w[page_objects/pages/login.rb page_objects/abstract/page.rb
-                           features/step_definitions/login_steps.rb Readme.md] }.each do |project, files|
-    files.each do |file|
-      it "keeps #{project}/#{file} as master generates it" do
-        expected = File.read(File.join(snapshots, project, "#{file}.snapshot"))
-        expect(read_generated(project, file)).to eq(expected)
-      end
+    it "writes the #{automation} page objects in plain Appium" do
+      home = read_generated("rspec_#{automation}", 'page_objects/pages/home.rb')
+      pdp = read_generated("rspec_#{automation}", 'page_objects/pages/pdp.rb')
+      expect(home).to include('first_product.click')
+      expect(home).not_to match(/\btap\(/)
+      expect(pdp).to include('def add_to_cart_button').and match(/\b(driver\.find_element|element)\(/)
+      expect(pdp).not_to include('add_to_cart_text')
     end
   end
 end

data/spec/integration/end_to_end_features_spec.rb

@@ -117,18 +117,12 @@ describe 'End-to-End Feature Validation' do
       expect(helper).to include('config.verbose_retry = true')
       expect(helper).to include("ENV.fetch('RETRY_COUNT', 0)")
     end
-
-    it 'cucumber projects have --retry in cucumber.yml' do
-      cucumber_yml = read_generated("#{FrameworkIndex::CUCUMBER}_#{AutomationIndex::SELENIUM}", 'cucumber.yml')
-      expect(cucumber_yml).to include('--retry')
-    end
   end
 
   # --- Feature: Tag-based rake tasks (C5) ---
 
   context 'Tag-based rake tasks' do
     let(:rspec_project) { "#{FrameworkIndex::RSPEC}_#{AutomationIndex::SELENIUM}" }
-    let(:cucumber_project) { "#{FrameworkIndex::CUCUMBER}_#{AutomationIndex::SELENIUM}" }
 
     it 'rspec Rakefile has smoke task' do
       rakefile = read_generated(rspec_project, 'Rakefile')
@@ -142,11 +136,6 @@ describe 'End-to-End Feature Validation' do
       expect(rakefile).to include("'--tag regression'")
     end
 
-    it 'cucumber Rakefile has smoke task with cucumber tags' do
-      rakefile = read_generated(cucumber_project, 'Rakefile')
-      expect(rakefile).to include("'--tags @smoke'")
-    end
-
     it 'rspec smoke rake task works', :slow do
       skip 'Bundle install needed' unless bundle_install(rspec_project)
 
@@ -159,7 +148,6 @@ describe 'End-to-End Feature Validation' do
 
   context 'Re-run failed tests' do
     let(:rspec_project) { "#{FrameworkIndex::RSPEC}_#{AutomationIndex::SELENIUM}" }
-    let(:cucumber_project) { "#{FrameworkIndex::CUCUMBER}_#{AutomationIndex::SELENIUM}" }
 
     it 'rspec projects have .rspec file' do
       expect(File).to exist("#{rspec_project}/.rspec")
@@ -179,10 +167,6 @@ describe 'End-to-End Feature Validation' do
       gitignore = read_generated(rspec_project, '.gitignore')
       expect(gitignore).to include('spec/examples.txt')
     end
-
-    it 'cucumber projects do not have .rspec file' do
-      expect(File).not_to exist("#{cucumber_project}/.rspec")
-    end
   end
 
   # --- Feature: Accessibility addon (axe) ---
@@ -193,14 +177,10 @@ describe 'End-to-End Feature Validation' do
         automation: 'selenium', framework: 'rspec', name: 'e2e_axe_rspec',
         accessibility: true
       )
-      InvokeGenerators.generate_framework(
-        automation: 'selenium', framework: 'cucumber', name: 'e2e_axe_cucumber',
-        accessibility: true
-      )
     end
 
     after(:all) do # rubocop:disable RSpec/BeforeAfterAll
-      %w[e2e_axe_rspec e2e_axe_cucumber].each { |n| FileUtils.rm_rf(n) }
+      FileUtils.rm_rf('e2e_axe_rspec')
     end
 
     describe 'axe + RSpec' do
@@ -220,28 +200,6 @@ describe 'End-to-End Feature Validation' do
         expect { RubyVM::InstructionSequence.compile(content) }.not_to raise_error
       end
     end
-
-    describe 'axe + Cucumber' do
-      it 'creates accessibility.feature' do
-        expect(File).to exist('e2e_axe_cucumber/features/accessibility.feature')
-      end
-
-      it 'creates accessibility_steps.rb' do
-        expect(File).to exist('e2e_axe_cucumber/features/step_definitions/accessibility_steps.rb')
-      end
-
-      it 'includes axe gems in Gemfile' do
-        gemfile = File.read('e2e_axe_cucumber/Gemfile')
-        expect(gemfile).to include('axe')
-      end
-
-      it 'all Ruby files have valid syntax' do
-        ruby_files('e2e_axe_cucumber').each do |file|
-          content = File.read(file)
-          expect(content).to have_valid_ruby_syntax, "#{file} has invalid syntax"
-        end
-      end
-    end
   end
 
   # --- Feature: GitHub Actions CI ---