ruby-trello 2.2.0 → 2.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 05525435b0e8308a1adc45db693f314a91a17bb9f565efd8a87048b0dee6a4c6
-  data.tar.gz: 96229c421c262dba867848a91b23149bce1f947bb4ef7b4df36d8cf5d1693f3a
+  metadata.gz: 9e1ea37b580763f0d19ff63872dd1f93cb07084de9bfe26ad391f540ec2b8d04
+  data.tar.gz: 58e70f72fecd1dc5e318e065a6d368f7ec176df16816e78e12e8fb872933c326
 SHA512:
-  metadata.gz: fc91f9504c4666af90366c3b9cf18f49e50fd7afee11a9a1f9ff1bbbf70da7ab786ec1a56ffcaa3ff8f608012d439f7d9ee8fd5050a2f7ad609bc5a8941d8b09
-  data.tar.gz: c9034334cc3d962272dad40e9beb781108ee729d2f86137faab7695bd9da00bd94789ecf2c41fcb33e83ddc3151a9f33d449bc52cffd215360958ed33402b511
+  metadata.gz: dc1fa46dfff77359d8b6c9e233ae8410fed8a8219860efb9ce849e394071d3781f60b40ac14ab2557cb9f2293554013abe0c4c985cde8d089464eabb2a117efa
+  data.tar.gz: 9d96fb20595f45782f52ba891278bbca256d41fde6e1ecef3718061e3dd0cba2fcbbaf9a4940f5a3a1e8f00518a2945149ffcc3ae280c6b1f109a3338cfe4de5

data/README.md

@@ -1,7 +1,6 @@
 # Ruby Trello API
 
-[![Stories in Ready](http://badge.waffle.io/jeremytregunna/ruby-trello.png)](http://waffle.io/jeremytregunna/ruby-trello)
-[![Build Status](https://secure.travis-ci.org/jeremytregunna/ruby-trello.png)](http://travis-ci.org/jeremytregunna/ruby-trello)
+[![Build Status](https://secure.travis-ci.org/jeremytregunna/ruby-trello.svg)](http://travis-ci.org/jeremytregunna/ruby-trello)
 [![security](https://hakiri.io/github/jeremytregunna/ruby-trello/master.svg)](https://hakiri.io/github/jeremytregunna/ruby-trello/master)
 [![Code Climate](https://codeclimate.com/github/jeremytregunna/ruby-trello/badges/gpa.svg)](https://codeclimate.com/github/jeremytregunna/ruby-trello)
 
@@ -12,20 +11,22 @@ Seriously, [check it out](http://www.trello.com/).
 
 [Full API documentation](http://www.rubydoc.info/gems/ruby-trello).
 
-## Installation
-
-```
-# gem install ruby-trello
-```
-
 Full Disclosure: This library is mostly complete, if you do find anything missing or not functioning as you expect it
-to, please [let us know](https://trello.com/card/spot-a-bug-report-it/4f092b2ee23cb6fe6d1aaabd/17).
+to, please just [create an issue](https://github.com/jeremytregunna/ruby-trello/issues/new).
 
-Supports Ruby 2.1.0 or newer.
+## Requirements
 
+Use the newest version for Ruby 2.5.0 or newer support.
+Use version 2.2.1 or earlier for Ruby 2.1 ~ 2.4 support.
 Use version 1.3.0 or earlier for Ruby 1.9.3 support.
 Use version 1.4.x or earlier for Ruby 2.0.0 support.
 
+## Installation
+
+```
+# gem install ruby-trello
+```
+
 ## Configuration
 
 #### Basic authorization:
@@ -181,3 +182,41 @@ Several ways you can contribute. Documentation, code, tests, feature requests, b
 If you submit a pull request that's accepted, you'll be given commit access to this repository.
 
 Please see the `CONTRIBUTING.md` file for more information.
+
+## Local Development
+
+Init all Gemfile.lock.* files
+
+```bash
+make init
+```
+
+Bundle install for all Ruby versions
+
+```bash
+make bundle:all
+```
+
+Run tests for all Ruby versions
+
+```bash
+make test:all
+```
+
+Run tests for each Ruby versions individual
+
+```bash
+make test:ruby_2_5
+make test:ruby_2_6
+make test:ruby_2_7
+make test:jruby_9_2
+```
+
+Do development for each Ruby versions individual
+
+```bash
+make dev:ruby_2_5
+make dev:ruby_2_6
+make dev:ruby_2_7
+make dev:jruby_9_2
+```

data/lib/trello.rb

@@ -37,43 +37,55 @@ require 'addressable/uri'
 #
 # Feel free to {peruse and participate in our Trello board}[https://trello.com/board/ruby-trello/4f092b2ee23cb6fe6d1aaabd]. It's completely open to the public.
 module Trello
-  autoload :Error,             'trello/error'
-  autoload :Action,            'trello/action'
-  autoload :Comment,           'trello/comment'
-  autoload :Association,       'trello/association'
-  autoload :AssociationProxy,  'trello/association_proxy'
-  autoload :Attachment,        'trello/attachment'
-  autoload :CoverImage,        'trello/cover_image'
-  autoload :BasicData,         'trello/basic_data'
-  autoload :Board,             'trello/board'
-  autoload :Card,              'trello/card'
-  autoload :Checklist,         'trello/checklist'
-  autoload :Client,            'trello/client'
-  autoload :Configuration,     'trello/configuration'
-  autoload :CustomField,       'trello/custom_field'
-  autoload :CustomFieldItem,   'trello/custom_field_item'
-  autoload :CustomFieldOption, 'trello/custom_field_option'
-  autoload :HasActions,        'trello/has_actions'
-  autoload :Item,              'trello/item'
-  autoload :CheckItemState,    'trello/item_state'
-  autoload :Label,             'trello/label'
-  autoload :LabelName,         'trello/label_name'
-  autoload :List,              'trello/list'
-  autoload :Member,            'trello/member'
-  autoload :MultiAssociation,  'trello/multi_association'
-  autoload :Notification,      'trello/notification'
-  autoload :Organization,      'trello/organization'
-  autoload :PluginDatum,       'trello/plugin_datum'
-  autoload :Request,           'trello/net'
-  autoload :TInternet,         'trello/net'
-  autoload :Token,             'trello/token'
-  autoload :Webhook,           'trello/webhook'
-  autoload :JsonUtils,         'trello/json_utils'
+  autoload :Error,                'trello/error'
+  autoload :Action,               'trello/action'
+  autoload :Comment,              'trello/comment'
+  autoload :Association,          'trello/association'
+  autoload :AssociationProxy,     'trello/association_proxy'
+  autoload :Attachment,           'trello/attachment'
+  autoload :CoverImage,           'trello/cover_image'
+  autoload :BasicData,            'trello/basic_data'
+  autoload :Board,                'trello/board'
+  autoload :Card,                 'trello/card'
+  autoload :Checklist,            'trello/checklist'
+  autoload :Client,               'trello/client'
+  autoload :Configuration,        'trello/configuration'
+  autoload :CustomField,          'trello/custom_field'
+  autoload :CustomFieldItem,      'trello/custom_field_item'
+  autoload :CustomFieldOption,    'trello/custom_field_option'
+  autoload :HasActions,           'trello/has_actions'
+  autoload :Item,                 'trello/item'
+  autoload :CheckItemState,       'trello/item_state'
+  autoload :Label,                'trello/label'
+  autoload :LabelName,            'trello/label_name'
+  autoload :List,                 'trello/list'
+  autoload :Member,               'trello/member'
+  autoload :MultiAssociation,     'trello/multi_association'
+  autoload :Notification,         'trello/notification'
+  autoload :Organization,         'trello/organization'
+  autoload :PluginDatum,          'trello/plugin_datum'
+  autoload :Request,              'trello/net'
+  autoload :TInternet,            'trello/net'
+  autoload :Token,                'trello/token'
+  autoload :Webhook,              'trello/webhook'
+  autoload :JsonUtils,            'trello/json_utils'
+  autoload :AssociationInferTool, 'trello/association_infer_tool'
+  autoload :RegisterAttributes,   'trello/register_attributes'
 
   module Authorization
-    autoload :AuthPolicy,      'trello/authorization'
-    autoload :BasicAuthPolicy, 'trello/authorization'
-    autoload :OAuthPolicy,     'trello/authorization'
+    autoload :AuthPolicy,         'trello/authorization'
+    autoload :BasicAuthPolicy,    'trello/authorization'
+    autoload :OAuthPolicy,        'trello/authorization'
+  end
+
+  module AssociationFetcher
+    autoload :HasMany,            'trello/association_fetcher/has_many'
+    autoload :HasOne,            'trello/association_fetcher/has_one'
+  end
+
+  module AssociationBuilder
+    autoload :HasMany,            'trello/association_builder/has_many'
+    autoload :HasOne,            'trello/association_builder/has_one'
   end
 
   # Version of the Trello API that we use by default.

data/lib/trello/action.rb

@@ -62,7 +62,9 @@ module Trello
       List.from_response client.get("/actions/#{id}/list")
     end
 
-    # Returns the member who created the action.
-    one :member_creator, via: Member, path: :members, using: :member_creator_id
+    # Returns the list the action occurred on.
+    def member_creator
+      Member.from_response client.get("/actions/#{id}/memberCreator")
+    end
   end
 end

data/lib/trello/association_builder/has_many.rb

@@ -0,0 +1,17 @@
+module Trello
+  module AssociationBuilder
+    class HasMany
+      class << self
+        def build(model_klass, name, options)
+          model_klass.class_eval do
+            define_method(name) do |*args|
+              has_many_fetcher = AssociationFetcher::HasMany.new(self, name, options)
+              filter_params = args[0] || {}
+              has_many_fetcher.fetch(filter_params)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/trello/association_builder/has_one.rb

@@ -0,0 +1,16 @@
+module Trello
+  module AssociationBuilder
+    class HasOne
+      class << self
+        def build(model_klass, name, options)
+          model_klass.class_eval do
+            define_method(name) do |*args|
+              has_one_fetcher = AssociationFetcher::HasOne.new(self, name, options)
+              has_one_fetcher.fetch
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/trello/association_fetcher/has_many.rb

@@ -0,0 +1,26 @@
+module Trello
+  module AssociationFetcher
+    class HasMany
+      autoload :Params, 'trello/association_fetcher/has_many/params'
+      autoload :Fetch, 'trello/association_fetcher/has_many/fetch'
+
+      attr_reader :model, :name, :options
+
+      def initialize(model, name, options)
+        @model = model
+        @name = name
+        @options = options
+      end
+
+      def fetch(filter_params)
+        params = Params.new(
+          association_owner: model,
+          association_name: name,
+          association_options: options,
+          filter: filter_params 
+        )
+        Fetch.execute(params)
+      end
+    end
+  end
+end

data/lib/trello/association_fetcher/has_many/fetch.rb

@@ -0,0 +1,47 @@
+module Trello
+  module AssociationFetcher
+    class HasMany
+      class Fetch
+        class << self
+          def execute(params)
+            new(params).execute
+          end
+        end
+
+        attr_reader :params
+
+        def initialize(params)
+          @params = params
+        end
+
+        def execute
+          resources = client.find_many(association_class, path, filter_params)
+
+          MultiAssociation.new(association_owner, resources).proxy
+        end
+
+        private
+
+        def client
+          association_owner.client
+        end
+
+        def association_class
+          params.association_class
+        end
+
+        def path
+          params.fetch_path
+        end
+
+        def filter_params
+          params.filter_params
+        end
+
+        def association_owner
+          params.association_owner
+        end
+      end
+    end
+  end
+end

data/lib/trello/association_fetcher/has_many/params.rb

@@ -0,0 +1,56 @@
+module Trello
+  module AssociationFetcher
+    class HasMany
+      class Params
+        attr_reader :association_owner
+
+        def initialize(association_owner:, association_name:, association_options:, filter:)
+          @association_owner = association_owner
+          @association_name = association_name
+          @association_options = association_options || {}
+          @filter = filter || {}
+        end
+
+        def association_class
+          association_options[:via] || infer_class_on(association_name)
+        end
+
+        def fetch_path
+          "/#{parent_restful_resource}/#{parent_restful_resource_id}/#{target_restful_resource}"
+        end
+
+        def filter_params
+          default_filter.merge(filter)
+        end
+
+        private
+
+        attr_reader :association_name, :association_options, :filter
+
+        def default_filter
+          association_options.reject { |k, _| %w[via in path].include?(k.to_s) }
+        end
+
+        def parent_restful_resource
+          association_options[:in] || infer_restful_resource_on(association_owner.class)
+        end
+
+        def parent_restful_resource_id
+          association_owner.id
+        end
+
+        def target_restful_resource
+          association_options[:path] || association_name
+        end
+
+        def infer_restful_resource_on(klass)
+          AssociationInferTool.infer_restful_resource_on_class(klass)
+        end
+
+        def infer_class_on(name)
+          AssociationInferTool.infer_class_on_name(name)
+        end
+      end
+    end
+  end
+end

data/lib/trello/association_fetcher/has_one.rb

@@ -0,0 +1,25 @@
+module Trello
+  module AssociationFetcher
+    class HasOne
+      autoload :Params, 'trello/association_fetcher/has_one/params'
+      autoload :Fetch, 'trello/association_fetcher/has_one/fetch'
+
+      attr_reader :model, :name, :options
+
+      def initialize(model, name, options)
+        @model = model
+        @name = name
+        @options = options
+      end
+
+      def fetch
+        params = Params.new(
+          association_owner: model,
+          association_name: name,
+          association_options: options
+        )
+        Fetch.execute(params)
+      end
+    end
+  end
+end

data/lib/trello/association_fetcher/has_one/fetch.rb

@@ -0,0 +1,49 @@
+module Trello
+  module AssociationFetcher
+    class HasOne
+      class Fetch
+        class << self
+          def execute(params)
+            new(params).execute
+          end
+        end
+
+        def initialize(params)
+          @params = params
+        end
+
+        def execute
+          if association_restful_name
+            client.find(association_restful_name, association_restful_id)
+          else
+            association_class.find(association_restful_id)
+          end
+        end
+
+        private
+
+        attr_reader :params
+
+        def client
+          association_owner.client
+        end
+
+        def association_owner
+          params.association_owner
+        end
+
+        def association_restful_name
+          params.association_restful_name
+        end
+
+        def association_restful_id
+          params.association_restful_id
+        end
+
+        def association_class
+          params.association_class
+        end
+      end
+    end
+  end
+end