ruby-trello 2.2.0 → 2.3.0

data/spec/custom_field_item_spec.rb

@@ -114,5 +114,79 @@ module Trello
         expect(text_item.card).to be_a Card
       end
     end
+
+    describe '#update_fields' do
+
+      context 'when the fields argument is empty' do
+        let(:fields) { {} }
+
+        it 'custom field item does not set any fields' do
+          text_item.update_fields(fields)
+
+          expect(text_item.id).to eq text_field_details['id']
+          expect(text_item.option_id).to eq text_field_details['idValue']
+          expect(text_item.model_id).to eq text_field_details['idModel']
+          expect(text_item.custom_field_id).to eq text_field_details['idCustomField']
+          expect(text_item.model_type).to eq text_field_details['modelType']
+          expect(text_item.value).to eq text_field_details['value']
+        end
+      end
+
+      context 'when the fields argument has at least one field' do
+
+        context 'and the field does changed' do
+          let(:fields) { { value: { number: '42' } } }
+
+          it 'custom field item does set the changed fields' do
+            text_item.update_fields(fields)
+
+            expect(text_item.value).to eq( { number: '42' } )
+          end
+
+          it 'card has been mark as changed' do
+            text_item.update_fields(fields)
+
+            expect(text_item.changed?).to be_truthy
+          end
+        end
+
+        context "and the field doesn't changed" do
+          let(:fields) { { value: text_field_details['value'] } }
+
+          it "custom field item attributes doesn't changed" do
+            text_item.update_fields(fields)
+
+            expect(text_item.value).to eq(text_field_details['value'])
+          end
+
+          it "custom field item hasn't been mark as changed", pending: true do
+            text_item.update_fields(fields)
+
+            expect(text_item.changed?).to be_falsy
+          end
+        end
+
+        context "and the field isn't a correct attributes of the card" do
+          let(:fields) { { abc: 'abc' } }
+
+          it "custom field item attributes doesn't changed" do
+            text_item.update_fields(fields)
+
+            expect(text_item.id).to eq text_field_details['id']
+            expect(text_item.option_id).to eq text_field_details['idValue']
+            expect(text_item.model_id).to eq text_field_details['idModel']
+            expect(text_item.custom_field_id).to eq text_field_details['idCustomField']
+            expect(text_item.model_type).to eq text_field_details['modelType']
+            expect(text_item.value).to eq text_field_details['value']
+          end
+
+          it "custom field item hasn't been mark as changed" do
+            text_item.update_fields(fields)
+
+            expect(text_item.changed?).to be_falsy
+          end
+        end
+      end
+    end
   end
 end

data/spec/custom_field_spec.rb

@@ -181,5 +181,81 @@ module Trello
         custom_field.delete
       end
     end
+
+    describe '#update_fields' do
+      let(:custom_field_detail) { custom_fields_details.first }
+      let(:custom_field) { CustomField.new(custom_field_detail) }
+
+      context 'when the fields argument is empty' do
+        let(:fields) { {} }
+
+        it 'custom field does not set any fields' do
+          custom_field.update_fields(fields)
+
+          expect(custom_field.id).to eq custom_field_detail['id']
+          expect(custom_field.model_id).to eq custom_field_detail['idModel']
+          expect(custom_field.model_type).to eq custom_field_detail['modelType']
+          expect(custom_field.name).to eq custom_field_detail['name']
+          expect(custom_field.pos).to eq custom_field_detail['pos']
+          expect(custom_field.type).to eq custom_field_detail['type']
+        end
+      end
+
+      context 'when the fields argument has at least one field' do
+        context 'and the field does changed' do
+          let(:fields) { { name: 'Awesome Name' } }
+
+          it 'custom field does set the changed fields' do
+            custom_field.update_fields(fields)
+
+            expect(custom_field.name).to eq('Awesome Name')
+          end
+
+          it 'custom field has been mark as changed' do
+            custom_field.update_fields(fields)
+
+            expect(custom_field.changed?).to be_truthy
+          end
+        end
+
+        context "and the field doesn't changed" do
+          let(:fields) { { name: custom_field_detail['name'] } }
+
+          it "custom field attributes doesn't changed" do
+            custom_field.update_fields(fields)
+
+            expect(custom_field.name).to eq(custom_field_detail['name'])
+          end
+
+          it "custom field hasn't been mark as changed", pending: true do
+            custom_field.update_fields(fields)
+
+            expect(custom_field.changed?).to be_falsy
+          end
+        end
+
+        context "and the field isn't a correct attributes of the card" do
+          let(:fields) { { abc: 'abc' } }
+
+          it "custom field attributes doesn't changed" do
+            custom_field.update_fields(fields)
+
+            expect(custom_field.id).to eq custom_field_detail['id']
+            expect(custom_field.model_id).to eq custom_field_detail['idModel']
+            expect(custom_field.model_type).to eq custom_field_detail['modelType']
+            expect(custom_field.name).to eq custom_field_detail['name']
+            expect(custom_field.pos).to eq custom_field_detail['pos']
+            expect(custom_field.type).to eq custom_field_detail['type']
+          end
+
+          it "custom field hasn't been mark as changed" do
+            custom_field.update_fields(fields)
+
+            expect(custom_field.changed?).to be_falsy
+          end
+        end
+      end
+    end
+
   end
 end

data/spec/integration/basic_data/many_spec.rb

@@ -0,0 +1,123 @@
+require 'spec_helper'
+
+module Trello
+  describe BasicData do
+    describe '.many' do
+      let(:client_double) { double('client') }
+      let(:cards) { double('cards') }
+
+      around do |example|
+        class FakeCard < BasicData
+        end
+        class FakeBoard < BasicData
+          def update_fields(fields)
+            attributes[:id] = fields[:id]
+          end
+        end
+
+        example.run
+
+        Trello.send(:remove_const, 'FakeBoard')
+        Trello.send(:remove_const, 'FakeCard')
+      end
+
+      def mock_client_and_association(klass:, resource:, id:, path:, params:)
+        resources = double('resources')
+        allow(FakeBoard).to receive(:client).and_return(client_double)
+        allow_any_instance_of(FakeBoard).to receive(:client).and_return(client_double)
+        allow(client_double).to receive(:find_many).with(klass, "/#{resource}/#{id}/#{path}", params).and_return(resources)
+        allow(MultiAssociation).to receive(:new).with(FakeBoard, resources).and_return(double('association', proxy: cards))
+      end
+
+      context 'when only pass in the name' do
+        before do
+          FakeBoard.class_eval { many :fake_cards }
+
+          mock_client_and_association(
+            klass: Trello::FakeCard,
+            resource: 'fakeboards',
+            id: 1,
+            path: 'fake_cards',
+            params: {}
+          )
+        end
+
+        it 'can get cards from client' do
+          expect(FakeBoard.new(id: 1).fake_cards).to eq(cards)
+        end
+      end
+
+      context 'when pass in name with in:' do
+        before do
+          FakeBoard.class_eval { many :fake_cards, in: 'boards' }
+
+          mock_client_and_association(
+            klass: Trello::FakeCard,
+            resource: 'boards',
+            id: 1,
+            path: 'fake_cards',
+            params: {}
+          )
+        end
+
+        it 'can get cards from client' do
+          expect(FakeBoard.new(id: 1).fake_cards).to eq(cards)
+        end
+      end
+
+      context 'when pass in name with via:' do
+        before do
+          FakeBoard.class_eval { many :fake_cards, via: Card }
+
+          mock_client_and_association(
+            klass: Trello::Card,
+            resource: 'fakeboards',
+            id: 1,
+            path: 'fake_cards',
+            params: {}
+          )
+        end
+
+        it 'can get cards from client' do
+          expect(FakeBoard.new(id: 1).fake_cards).to eq(cards)
+        end
+      end
+
+      context 'when pass in name with path:' do
+        before do
+          FakeBoard.class_eval { many :fake_cards, path: 'test' }
+
+          mock_client_and_association(
+            klass: Trello::FakeCard,
+            resource: 'fakeboards',
+            id: 1,
+            path: 'test',
+            params: {}
+          )
+        end
+
+        it 'can get cards from client' do
+          expect(FakeBoard.new(id: 1).fake_cards).to eq(cards)
+        end
+      end
+
+      context 'when pass in name with other params' do
+        before do
+          FakeBoard.class_eval { many :fake_cards, test: 'test' }
+
+          mock_client_and_association(
+            klass: Trello::FakeCard,
+            resource: 'fakeboards',
+            id: 1,
+            path: 'fake_cards',
+            params: {test: 'test'}
+          )
+        end
+
+        it 'can get cards from client' do
+          expect(FakeBoard.new(id: 1).fake_cards).to eq(cards)
+        end
+      end
+    end
+  end
+end

data/spec/integration/basic_data/one_spec.rb

@@ -0,0 +1,84 @@
+require 'spec_helper'
+
+RSpec.describe 'Trello::BasicData.one' do
+
+  let(:client_double) { double('client') }
+  let(:organization) { double('organization') }
+
+  around do |example|
+    module Trello
+      class FakeOrganization < BasicData
+      end
+      class FakeBoard < BasicData
+        def update_fields(fields)
+          attributes[:id] = fields[:id]
+        end
+      end
+    end
+
+    example.run
+
+    Trello.send(:remove_const, 'FakeBoard')
+    Trello.send(:remove_const, 'FakeOrganization')
+  end
+
+  def mock_client_and_association(klass: Trello::FakeOrganization, id: 1, path: nil, id_field: :id)
+    association_restful_name = path
+    allow(Trello::FakeBoard).to receive(:client).and_return(client_double)
+    allow_any_instance_of(Trello::FakeBoard).to receive(:client).and_return(client_double)
+    allow_any_instance_of(Trello::FakeBoard).to receive(id_field).and_return(id)
+    if association_restful_name
+      allow(client_double).to receive(:find).with(association_restful_name, id).and_return(organization)
+    else
+      allow(klass).to receive(:find).with(id).and_return(organization)
+    end
+  end
+
+  context 'when only pass in the name' do
+    before do
+      Trello::FakeBoard.class_eval { one :fake_organization }
+
+      mock_client_and_association
+    end
+
+    it 'can get the association from client' do
+      expect(Trello::FakeBoard.new(id: 1).fake_organization).to eq(organization)
+    end
+  end
+
+  context 'when pass in name with path' do
+    before do
+      Trello::FakeBoard.class_eval { one :fake_organization, path: 'organizations' }
+
+      mock_client_and_association(path: 'organizations')
+    end
+
+    it 'can get the association from client' do
+      expect(Trello::FakeBoard.new(id: 1).fake_organization).to eq(organization)
+    end
+  end
+
+  context 'when pass in name with via' do
+    before do
+      Trello::FakeBoard.class_eval { one :fake_organization, via: Trello::FakeOrganization }
+
+      mock_client_and_association
+    end
+
+    it 'can get the association from client' do
+      expect(Trello::FakeBoard.new(id: 1).fake_organization).to eq(organization)
+    end
+  end
+
+  context 'when pass in name with using' do
+    before do
+      Trello::FakeBoard.class_eval { one :fake_organization, using: :test_id }
+
+      mock_client_and_association(id_field: :test_id)
+    end
+
+    it 'can get the association from client' do
+      expect(Trello::FakeBoard.new(id: 1).fake_organization).to eq(organization)
+    end
+  end
+end

data/spec/integration/basic_data/register_attributes_spec.rb

@@ -0,0 +1,75 @@
+require 'spec_helper'
+
+RSpec.describe 'Trello::BasicData.register_attributes' do
+
+  around do |example|
+    module Trello
+      class FakeBoard < BasicData
+      end
+    end
+
+    example.run
+
+    Trello.send(:remove_const, 'FakeBoard')
+  end
+
+  context 'when register attributes are all writable' do
+    before do
+      Trello::FakeBoard.class_eval do
+        register_attributes :id, :name, :description
+
+        def initialize(fields={})
+          attributes[:id] = fields[:id]
+          attributes[:name] = fields[:name]
+          attributes[:description] = fields[:description]
+        end
+      end
+    end
+
+    it 'create getter method for all attributes' do
+      expect(Trello::FakeBoard.new).to respond_to(:id, :name, :description)
+    end
+
+    it 'create setting method for all attributes' do
+      expect(Trello::FakeBoard.new).to respond_to(:id=, :name=, :description=)
+    end
+
+    it 'any attributes changes will caused the record being marked as changed' do
+      fake_board = Trello::FakeBoard.new(id: 1, name: 'test')
+      expect(fake_board.changed?).to eq(false)
+      fake_board.name = 'TEST'
+      expect(fake_board.changed?).to eq(true)
+    end
+  end
+
+  context 'when register attributes are partial read-only' do
+    before do
+      Trello::FakeBoard.class_eval do
+        register_attributes :id, :name, :description, readonly: [:id]
+
+        def initialize(fields={})
+          attributes[:id] = fields[:id]
+          attributes[:name] = fields[:name]
+          attributes[:description] = fields[:description]
+        end
+      end
+    end
+
+    it 'create getter method for all attributes' do
+      expect(Trello::FakeBoard.new).to respond_to(:id, :name, :description)
+    end
+
+    it 'create setting method for all writable attributes' do
+      expect(Trello::FakeBoard.new).to respond_to(:name=, :description=)
+      expect(Trello::FakeBoard.new).not_to respond_to(:id=)
+    end
+
+    it 'any writable attributes changes will caused the record being marked as changed' do
+      fake_board = Trello::FakeBoard.new(id: 1, name: 'test')
+      expect(fake_board.changed?).to eq(false)
+      fake_board.name = 'TEST'
+      expect(fake_board.changed?).to eq(true)
+    end
+  end
+
+end

data/spec/integration/board_lists_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+RSpec.describe 'Board - Lists API' do
+
+  before do
+    Trello.configure do |config|
+      config.developer_public_key = ENV['TRELLO_DEVELOPER_PUBLIC_KEY'] || 'developerpublickey'
+      config.member_token = ENV['TRELLO_MEMBER_TOKEN'] || 'membertoken'
+    end
+  end
+
+  it 'AssociationProxy#to_a, #to_ary' do
+    VCR.use_cassette('get_lists') do
+      board = Trello::Board.find('5e679be40c407034b479459c')
+      lists = board.lists
+      expect(lists.to_a).to be_a(Array)
+      expect(lists.to_ary).to be_a(Array)
+    end
+  end
+
+end