ruby-trello 2.2.0 → 2.3.0

data/lib/trello/member.rb

@@ -92,7 +92,7 @@ module Trello
 
     def save
       @previously_changed = changes
-      @changed_attributes.try(:clear)
+      @changed_attributes.clear if @changed_attributes.respond_to?(:clear)
       changes_applied if respond_to?(:changes_applied)
 
       return update! if id

data/lib/trello/register_attributes.rb

@@ -0,0 +1,54 @@
+module Trello
+  class RegisterAttributes
+    class << self
+      def execute(model_klass, names, readonly_names)
+        names ||= []
+        readonly_names ||= []
+
+        define_method_attributes(model_klass, names)
+        define_getters(model_klass, names)
+        define_setters(model_klass, names, readonly_names)
+        track_attributes_changes(model_klass, names)
+      end
+
+      private
+
+      def define_method_attributes(model_klass, names)
+        model_klass.class_eval do
+          define_method :attributes do
+            @__attributes ||= names.reduce({}) do |attrs, name|
+              attrs.merge(name.to_sym => nil)
+            end
+          end
+        end
+      end
+
+      def define_getters(model_klass, names)
+        model_klass.class_eval do
+          names.each do |key|
+            define_method(key) { @__attributes[key] }
+          end
+        end
+      end
+
+      def define_setters(model_klass, names, readonly_names)
+        model_klass.class_eval do
+          names.each do |key|
+            next if readonly_names.include?(key.to_sym)
+
+            define_method("#{key}=") do |value|
+              send("#{key}_will_change!") if value != @__attributes[key]
+              @__attributes[key] = value
+            end
+          end
+        end
+      end
+
+      def track_attributes_changes(model_klass, names)
+        model_klass.class_eval do
+          define_attribute_methods(names)
+        end
+      end
+    end
+  end
+end

data/spec/action_spec.rb

@@ -116,7 +116,7 @@ module Trello
       before do
         allow(client)
           .to receive(:get)
-          .with('/members/abcdef123456789123456789', {})
+          .with('/actions/4ee2482134a81a757a08af47/memberCreator')
           .and_return user_payload
       end
 

data/spec/card_spec.rb

@@ -187,6 +187,7 @@ module Trello
           .to receive(:put)
           .once
           .with("/cards/abcdef123456789123456789", payload)
+          .and_return(payload.to_json)
 
         card.name = expected_new_name
         card.save
@@ -199,7 +200,10 @@ module Trello
           desc: expected_new_desc,
         }
 
-        expect(client).to receive(:put).once.with("/cards/abcdef123456789123456789", payload)
+        expect(client)
+          .to receive(:put).once
+          .with("/cards/abcdef123456789123456789", payload)
+          .and_return(payload.to_json)
 
         card.desc = expected_new_desc
         card.save
@@ -307,7 +311,7 @@ module Trello
       before do
         allow(client)
           .to receive(:get)
-          .with("/attachments/abcdef123456789123456789", {})
+          .with("/cards/#{card.id}/attachments/abcdef123456789123456789", {})
           .and_return JSON.generate(attachments_details.first)
       end
 
@@ -473,7 +477,7 @@ module Trello
         card.move_to_list_on_any_board(other_list.id)
       end
 
-      it 'should not be moved if new board is identical with old board', focus: true do
+      it 'should not be moved if new board is identical with old board' do
         other_board = double(id: 'abcdef123456789123456789')
         expect(client).to_not receive(:put)
         card.move_to_board(other_board)
@@ -506,7 +510,7 @@ module Trello
 
         expect(client)
           .to receive(:post)
-          .with("/cards/abcdef123456789123456789/members", payload)
+          .with("/cards/abcdef123456789123456789/idMembers", payload)
 
         card.add_member(new_member)
       end
@@ -516,7 +520,7 @@ module Trello
 
         expect(client)
           .to receive(:delete)
-          .with("/cards/abcdef123456789123456789/members/#{existing_member.id}")
+          .with("/cards/abcdef123456789123456789/idMembers/#{existing_member.id}")
 
         card.remove_member(existing_member)
       end
@@ -788,6 +792,7 @@ module Trello
           .to receive(:put)
           .once
           .with("/cards/abcdef123456789123456789", payload)
+          .and_return(payload.to_json)
 
         card.close!
       end
@@ -805,6 +810,7 @@ module Trello
           .to receive(:put)
           .once
           .with("/cards/abcdef123456789123456789", payload)
+          .and_return(payload.to_json)
 
         card.due = due_date
         card.save
@@ -819,6 +825,7 @@ module Trello
           .to receive(:put)
           .once
           .with("/cards/abcdef123456789123456789", payload)
+          .and_return(payload.to_json)
 
         card.due_complete = true
         card.save
@@ -827,28 +834,97 @@ module Trello
       end
     end
 
-    describe "#update_fields" do
-      it "does not set any fields when the fields argument is empty" do
-        expected = cards_details.first
+    describe '#update_fields' do
+      context 'when the fields argument is empty' do
+        let(:fields) { {} }
+
+        it 'card does not set any fields' do
+          expected = cards_details.first
+
+          card = Card.new(expected)
+          card.client = client
+
+          card.update_fields(fields)
+
+          expected.each do |key, value|
+            if card.respond_to?(key) && key != 'labels'
+              expect(card.send(key)).to eq value
+            end
+
+            expect(card.labels).to eq expected['labels'].map { |lbl| Trello::Label.new(lbl) }
+            expect(card.short_id).to eq expected['idShort']
+            expect(card.short_url).to eq expected['shortUrl']
+            expect(card.board_id).to eq expected['idBoard']
+            expect(card.member_ids).to eq expected['idMembers']
+            expect(card.cover_image_id).to eq expected['idAttachmentCover']
+            expect(card.list_id).to eq expected['idList']
+            expect(card.card_labels).to eq expected['idLabels']
+          end
+        end
+      end
+
+      context 'when the fields argument has at least one field' do
+        let(:expected) { cards_details.first }
+        let(:card) {
+          card = Card.new(expected)
+          card.client = client
+          card
+        }
+
+        context 'and the field does changed' do
+          let(:fields) { { desc: 'Awesome things have changed.' } }
+
+          it 'card does set the changed fields' do
+            card.update_fields(fields)
 
-        card = Card.new(expected)
-        card.client = client
+            expect(card.desc).to eq('Awesome things have changed.')
+          end
+
+          it 'card has been mark as changed' do
+            card.update_fields(fields)
+
+            expect(card.changed?).to be_truthy
+          end
+        end
+
+        context "and the field doesn't changed" do
+          let(:fields) { { desc: expected[:desc] } }
+
+          it "card attributes doesn't changed" do
+            card.update_fields(fields)
 
-        card.update_fields({})
+            expect(card.desc).to eq(expected['desc'])
+          end
+
+          it "card hasn't been mark as changed", pending: true do
+            card.update_fields(fields)
 
-        expected.each do |key, value|
-          if card.respond_to?(key) && key != 'labels'
-            expect(card.send(key)).to eq value
+            expect(card.changed?).to be_falsy
           end
+        end
 
-          expect(card.labels).to eq expected['labels'].map { |lbl| Trello::Label.new(lbl) }
-          expect(card.short_id).to eq expected['idShort']
-          expect(card.short_url).to eq expected['shortUrl']
-          expect(card.board_id).to eq expected['idBoard']
-          expect(card.member_ids).to eq expected['idMembers']
-          expect(card.cover_image_id).to eq expected['idAttachmentCover']
-          expect(card.list_id).to eq expected['idList']
-          expect(card.card_labels).to eq expected['idLabels']
+        context "and the field isn't a correct attributes of the card" do
+          let(:fields) { { abc: 'abc' } }
+
+          it "card attributes doesn't changed" do
+            card.update_fields(fields)
+
+            expect(card.labels).to eq expected['labels'].map { |lbl| Trello::Label.new(lbl) }
+            expect(card.short_id).to eq expected['idShort']
+            expect(card.short_url).to eq expected['shortUrl']
+            expect(card.board_id).to eq expected['idBoard']
+            expect(card.member_ids).to eq expected['idMembers']
+            expect(card.cover_image_id).to eq expected['idAttachmentCover']
+            expect(card.list_id).to eq expected['idList']
+            expect(card.card_labels).to eq expected['idLabels']
+            expect(card.desc).to eq expected['desc']
+          end
+
+          it "card hasn't been mark as changed" do
+            card.update_fields(fields)
+
+            expect(card.changed?).to be_falsy
+          end
         end
       end
     end

data/spec/cassettes/can_add_a_file_from_url_on_a_card.yml

@@ -0,0 +1,189 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: https://api.trello.com/1/cards/5e95d1b4f43f9a06497f17f7?key=DEVELOPER_PUBLIC_KEY&token=MEMBER_TOKEN
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept:
+      - "*/*"
+      User-Agent:
+      - rest-client/2.1.0 (darwin19.2.0 x86_64) ruby/2.6.5p114
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Host:
+      - api.trello.com
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      X-Dns-Prefetch-Control:
+      - 'off'
+      X-Frame-Options:
+      - DENY
+      Strict-Transport-Security:
+      - max-age=15552000; includeSubDomains
+      X-Download-Options:
+      - noopen
+      Surrogate-Control:
+      - no-store
+      X-Content-Type-Options:
+      - nosniff
+      Referrer-Policy:
+      - strict-origin-when-cross-origin
+      X-Xss-Protection:
+      - 1; mode=block
+      X-Trello-Version:
+      - 1.2055.0
+      X-Trello-Environment:
+      - Production
+      Access-Control-Allow-Origin:
+      - "*"
+      Access-Control-Allow-Methods:
+      - GET, PUT, POST, DELETE
+      Access-Control-Allow-Headers:
+      - Authorization, Accept, Content-Type
+      Access-Control-Expose-Headers:
+      - x-rate-limit-api-key-interval-ms, x-rate-limit-api-key-max, x-rate-limit-api-key-remaining,
+        x-rate-limit-api-token-interval-ms, x-rate-limit-api-token-max, x-rate-limit-api-token-remaining
+      X-Rate-Limit-Api-Key-Interval-Ms:
+      - '10000'
+      X-Rate-Limit-Api-Key-Max:
+      - '300'
+      X-Rate-Limit-Api-Key-Remaining:
+      - '299'
+      X-Rate-Limit-Api-Token-Interval-Ms:
+      - '10000'
+      X-Rate-Limit-Api-Token-Max:
+      - '100'
+      X-Rate-Limit-Api-Token-Remaining:
+      - '99'
+      X-Rate-Limit-Member-Interval-Ms:
+      - '10000'
+      X-Rate-Limit-Member-Max:
+      - '200'
+      X-Rate-Limit-Member-Remaining:
+      - '199'
+      X-Server-Time:
+      - '1586956885846'
+      Content-Type:
+      - application/json; charset=utf-8
+      Vary:
+      - Accept-Encoding
+      Expires:
+      - Wed, 15 Apr 2020 13:21:25 GMT
+      Cache-Control:
+      - max-age=0, no-cache, no-store
+      Pragma:
+      - no-cache
+      Date:
+      - Wed, 15 Apr 2020 13:21:25 GMT
+      Content-Length:
+      - '997'
+      Connection:
+      - keep-alive
+      Set-Cookie:
+      - dsc=set_cookie_dsc; Path=/; Expires=Sat, 18 Apr 2020 13:21:25 GMT; Secure
+    body:
+      encoding: UTF-8
+      string: '{"id":"5e95d1b4f43f9a06497f17f7","checkItemStates":[],"closed":false,"dateLastActivity":"2020-04-15T13:18:04.471Z","desc":"","descData":null,"dueReminder":null,"idBoard":"5e94f5ded016b22c2437c13c","idList":"5e95d1b07f2ff83927319128","idMembersVoted":[],"idShort":2,"idAttachmentCover":null,"idLabels":[],"manualCoverAttachment":false,"name":"C2","pos":16384,"shortLink":"DeJYDbq0","isTemplate":false,"dueComplete":false,"due":null,"email":null,"labels":[],"shortUrl":"https://trello.com/c/DeJYDbq0","url":"https://trello.com/c/DeJYDbq0/2-c2","cover":{"idAttachment":null,"color":null,"idUploadedBackground":null,"size":"normal","brightness":"light"},"idMembers":[],"idChecklists":[],"badges":{"attachmentsByType":{"trello":{"board":0,"card":0}},"location":false,"votes":0,"viewingMemberVoted":false,"subscribed":false,"fogbugz":"","checkItems":0,"checkItemsChecked":0,"checkItemsEarliestDue":null,"comments":0,"attachments":1,"description":false,"due":null,"dueComplete":false},"subscribed":false}'
+    http_version: null
+  recorded_at: Wed, 15 Apr 2020 13:21:25 GMT
+- request:
+    method: post
+    uri: https://api.trello.com/1/cards/5e95d1b4f43f9a06497f17f7/attachments?key=DEVELOPER_PUBLIC_KEY&token=MEMBER_TOKEN
+    body:
+      encoding: UTF-8
+      string: url=https%3A%2F%2Fupload.wikimedia.org%2Fwikipedia%2Fen%2F6%2F6b%2FHello_Web_Series_%2528Wordmark%2529_Logo.png&name=hello.png
+    headers:
+      Accept:
+      - "*/*"
+      User-Agent:
+      - rest-client/2.1.0 (darwin19.2.0 x86_64) ruby/2.6.5p114
+      Content-Length:
+      - '126'
+      Content-Type:
+      - application/x-www-form-urlencoded
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Host:
+      - api.trello.com
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      X-Dns-Prefetch-Control:
+      - 'off'
+      X-Frame-Options:
+      - DENY
+      Strict-Transport-Security:
+      - max-age=15552000; includeSubDomains
+      X-Download-Options:
+      - noopen
+      Surrogate-Control:
+      - no-store
+      X-Content-Type-Options:
+      - nosniff
+      Referrer-Policy:
+      - strict-origin-when-cross-origin
+      X-Xss-Protection:
+      - 1; mode=block
+      X-Trello-Version:
+      - 1.2055.0
+      X-Trello-Environment:
+      - Production
+      Access-Control-Allow-Origin:
+      - "*"
+      Access-Control-Allow-Methods:
+      - GET, PUT, POST, DELETE
+      Access-Control-Allow-Headers:
+      - Authorization, Accept, Content-Type
+      Access-Control-Expose-Headers:
+      - x-rate-limit-api-key-interval-ms, x-rate-limit-api-key-max, x-rate-limit-api-key-remaining,
+        x-rate-limit-api-token-interval-ms, x-rate-limit-api-token-max, x-rate-limit-api-token-remaining
+      X-Rate-Limit-Api-Token-Interval-Ms:
+      - '10000'
+      X-Rate-Limit-Api-Token-Max:
+      - '100'
+      X-Rate-Limit-Api-Token-Remaining:
+      - '98'
+      X-Rate-Limit-Api-Key-Interval-Ms:
+      - '10000'
+      X-Rate-Limit-Api-Key-Max:
+      - '300'
+      X-Rate-Limit-Api-Key-Remaining:
+      - '298'
+      X-Rate-Limit-Member-Interval-Ms:
+      - '10000'
+      X-Rate-Limit-Member-Max:
+      - '200'
+      X-Rate-Limit-Member-Remaining:
+      - '197'
+      X-Server-Time:
+      - '1586956887595'
+      Content-Type:
+      - application/json; charset=utf-8
+      Vary:
+      - Accept-Encoding
+      Expires:
+      - Wed, 15 Apr 2020 13:21:27 GMT
+      Cache-Control:
+      - max-age=0, no-cache, no-store
+      Pragma:
+      - no-cache
+      Date:
+      - Wed, 15 Apr 2020 13:21:27 GMT
+      Content-Length:
+      - '2182'
+      Connection:
+      - keep-alive
+    body:
+      encoding: UTF-8
+      string: '{"id":"5e970a563812b3075bb192f1","bytes":92147,"date":"2020-04-15T13:21:26.794Z","edgeColor":null,"idMember":"5e679b808e6e8828784b30e1","isUpload":true,"mimeType":null,"name":"hello.png","previews":[{"id":"5e970a573812b3075bb1930e","_id":"5e970a573812b3075bb1930e","scaled":false,"url":"https://trello-attachments.s3.amazonaws.com/5e95d1b4f43f9a06497f17f7/70x50/f3c672acdd52be2ccff69bd3127fe575/hello.png","bytes":2380,"height":50,"width":70},{"id":"5e970a573812b3075bb1930f","_id":"5e970a573812b3075bb1930f","scaled":false,"url":"https://trello-attachments.s3.amazonaws.com/5e95d1b4f43f9a06497f17f7/250x150/f3c672acdd52be2ccff69bd3127fe575/hello.png","bytes":12261,"height":150,"width":250},{"id":"5e970a573812b3075bb19310","_id":"5e970a573812b3075bb19310","scaled":true,"url":"https://trello-attachments.s3.amazonaws.com/5e95d1b4f43f9a06497f17f7/149x84/f3c672acdd52be2ccff69bd3127fe575/hello.png","bytes":6486,"height":84,"width":149},{"id":"5e970a573812b3075bb19311","_id":"5e970a573812b3075bb19311","scaled":true,"url":"https://trello-attachments.s3.amazonaws.com/5e95d1b4f43f9a06497f17f7/300x169/f3c672acdd52be2ccff69bd3127fe575/hello.png","bytes":15654,"height":169,"width":300},{"id":"5e970a573812b3075bb19312","_id":"5e970a573812b3075bb19312","scaled":true,"url":"https://trello-attachments.s3.amazonaws.com/5e95d1b4f43f9a06497f17f7/600x338/f3c672acdd52be2ccff69bd3127fe575/hello.png","bytes":38279,"height":338,"width":600},{"id":"5e970a573812b3075bb19313","_id":"5e970a573812b3075bb19313","scaled":true,"url":"https://trello-attachments.s3.amazonaws.com/5e95d1b4f43f9a06497f17f7/1200x675/f3c672acdd52be2ccff69bd3127fe575/hello.png","bytes":102035,"height":675,"width":1200},{"id":"5e970a573812b3075bb19314","_id":"5e970a573812b3075bb19314","scaled":true,"url":"https://trello-attachments.s3.amazonaws.com/5e94f5ded016b22c2437c13c/5e95d1b4f43f9a06497f17f7/9566af90e112b494b57a76091635f882/Hello_Web_Series__28Wordmark_29_Logo.png","bytes":92147,"height":720,"width":1280}],"url":"https://trello-attachments.s3.amazonaws.com/5e94f5ded016b22c2437c13c/5e95d1b4f43f9a06497f17f7/9566af90e112b494b57a76091635f882/Hello_Web_Series__28Wordmark_29_Logo.png","pos":32768,"limits":{}}'
+    http_version: null
+  recorded_at: Wed, 15 Apr 2020 13:21:27 GMT
+recorded_with: VCR 5.1.0