ruby-trello 2.3.1 → 3.2.0

data/spec/board_spec.rb

@@ -6,7 +6,7 @@ module Trello
 
     let(:board) { client.find(:board, 'abcdef123456789123456789') }
     let(:client) { Client.new }
-    let(:member) { Member.new(user_payload) }
+    let(:member) { Member.new(JSON.parse(user_payload)) }
 
     before do
       allow(client)
@@ -21,7 +21,7 @@ module Trello
       it "delegates to client#find" do
         expect(client)
           .to receive(:find)
-          .with(:board, 'abcdef123456789123456789', {})
+          .with('board', 'abcdef123456789123456789', {})
 
         Board.find('abcdef123456789123456789')
       end
@@ -31,6 +31,35 @@ module Trello
       end
     end
 
+    describe '.create' do
+      before { allow(Board).to receive(:client).and_return(client) }
+
+      it 'will call create on client with correct parameters' do
+        params = {
+          name: 'Board Name',
+          use_default_labels: true,
+          use_default_lists: true,
+          description: 'description...',
+          organization_id: 11111,
+          source_board_id: 22222,
+          keep_cards_from_source: true,
+          power_ups: 'all',
+          visibility_level: 'org',
+          voting_permission_level: 'org',
+          comment_permission_level: 'org',
+          invitation_permission_level: 'admins',
+          enable_self_join: true,
+          enable_card_covers: true,
+          background_color: 'orange',
+          card_aging_type: 'pirate'
+        }
+
+        expect(client).to receive(:create).with('board', params)
+
+        Board.create(params)
+      end
+    end
+
     context "self.all" do
       let(:client) { Trello.client }
 
@@ -133,12 +162,10 @@ module Trello
         expect(labels[2].id).to  eq('cbcdef123456789123456789')
         expect(labels[2].board_id).to  eq('abcdef123456789123456789')
         expect(labels[2].name).to  eq('deploy')
-        expect(labels[2].uses).to  eq(2)
         expect(labels[3].color).to  eq('blue')
         expect(labels[3].id).to  eq('dbcdef123456789123456789')
         expect(labels[3].board_id).to  eq('abcdef123456789123456789')
         expect(labels[3].name).to  eq('on hold')
-        expect(labels[3].uses).to  eq(6)
       end
 
       it "passes the label limit" do
@@ -170,7 +197,7 @@ module Trello
       it "adds a member to the board as a normal user (default)" do
         expect(client)
           .to receive(:put)
-          .with("/boards/abcdef123456789123456789/members/id", type: :normal)
+          .with("/boards/abcdef123456789123456789/members/#{member.id}", type: :normal)
 
         board.add_member(member)
       end
@@ -178,7 +205,7 @@ module Trello
       it "adds a member to the board as an admin" do
         expect(client)
           .to receive(:put)
-          .with("/boards/abcdef123456789123456789/members/id", type: :admin)
+          .with("/boards/abcdef123456789123456789/members/#{member.id}", type: :admin)
 
         board.add_member(member, :admin)
       end
@@ -193,7 +220,7 @@ module Trello
       it "removes a member from the board" do
         expect(client)
           .to receive(:delete)
-          .with("/boards/abcdef123456789123456789/members/id")
+          .with("/boards/abcdef123456789123456789/members/#{member.id}")
 
         board.remove_member(member)
       end
@@ -264,62 +291,15 @@ module Trello
       end
     end
 
-    it "is not closed" do
-      expect(board).not_to be_closed
-    end
-
-    it "is not starred" do
-      expect(board).not_to be_starred
-    end
-
-    describe "#update_fields" do
-      it "does not set any fields when the fields argument is empty" do
-        expected = {
-         'id' => "id",
-         'name' => "name",
-         'desc' => "desc",
-         'closed' => false,
-         'starred' => false,
-         'url' => "url",
-         'idOrganization' => "org_id"
-        }
-
-        board = Board.new(expected)
-        board.client = client
-
-        board.update_fields({})
-
-        expected.each_pair do |key, value|
-          if board.respond_to?(key)
-            expect(board.send(key)).to eq value
-          end
-        end
-
-        expect(board.description).to eq expected['desc']
-        expect(board.organization_id).to eq expected['idOrganization']
-      end
-
-      it "initializes all fields from response-like formatted hash" do
-        board_details = boards_details.first
-        board = Board.new(board_details)
-        expect(board.id).to                 eq board_details['id']
-        expect(board.name).to               eq board_details['name']
-        expect(board.description).to        eq board_details['desc']
-        expect(board.closed).to             eq board_details['closed']
-        expect(board.starred).to            eq board_details['starred']
-        expect(board.organization_id).to    eq board_details['idOrganization']
-        expect(board.url).to                eq board_details['url']
-        expect(board.last_activity_date).to eq board_details['dateLastActivity']
+    describe '#closed?' do
+      it "returns the closed attribute" do
+        expect(board.closed?).to be_falsy
       end
+    end
 
-      it "initializes all fields from options-like formatted hash" do
-        board_details = boards_details[1]
-        board = Board.new(board_details)
-        expect(board.name).to            eq board_details[:name]
-        expect(board.description).to     eq board_details[:desc]
-        expect(board.closed).to          eq board_details[:closed]
-        expect(board.starred).to         eq board_details[:starred]
-        expect(board.organization_id).to eq board_details[:organization_id]
+    describe '#starred?' do
+      it "returns the starred attribute" do
+        expect(board.starred?).to be_falsy
       end
     end
 
@@ -342,17 +322,6 @@ module Trello
         }.to raise_error(Trello::ConfigurationError)
       end
 
-      it "puts all fields except id" do
-        expected_fields = %w{ name desc closed starred idOrganization}.map { |s| s.to_sym }
-
-        expect(client).to receive(:put) do |anything, body|
-          expect(body.keys).to match expected_fields
-          any_board_json
-        end
-
-        Board.new('id' => "xxx").save
-      end
-
       it "mutates the current instance" do
         allow(client)
           .to receive(:put)
@@ -366,7 +335,7 @@ module Trello
         expected_resource_id = "xxx_board_id_xxx"
 
         expect(client).to receive(:put) do |path, anything|
-          expect(path).to match(/#{expected_resource_id}\/\z/)
+          expect(path).to match(/#{expected_resource_id}\z/)
           any_board_json
         end
 
@@ -376,35 +345,6 @@ module Trello
       it "saves OR updates depending on whether or not it has an id set"
     end
 
-    describe '#update!' do
-      let(:client) { Trello.client }
-
-      let(:any_board_json) do
-        JSON.generate(boards_details.first)
-      end
-
-      it "puts basic attributes" do
-        board = Board.new 'id' => "board_id"
-
-        board.name        = "new name"
-        board.description = "new description"
-        board.closed      = true
-        board.starred     = true
-
-        expect(client)
-          .to receive(:put)
-          .with("/boards/#{board.id}/", {
-            name: "new name",
-            desc: "new description",
-            closed: true,
-            starred: true,
-            idOrganization: nil })
-          .and_return any_board_json
-
-        board.update!
-      end
-    end
-
     describe "Repository" do
       include Helpers
 
@@ -421,7 +361,7 @@ module Trello
 
       it "creates a new board with whatever attributes are supplied " do
         expected_attributes = { name: "Any new board name", description: "Any new board desription" }
-        sent_attributes = { name: expected_attributes[:name], desc: expected_attributes[:description] }
+        sent_attributes = { 'name' => expected_attributes[:name], 'desc' => expected_attributes[:description] }
 
         expect(client)
           .to receive(:post)

data/spec/card_spec.rb

@@ -25,7 +25,7 @@ module Trello
       it "delegates to Trello.client#find" do
         expect(client)
           .to receive(:find)
-          .with(:card, 'abcdef123456789123456789', {})
+          .with('card', 'abcdef123456789123456789', {})
 
         Card.find('abcdef123456789123456789')
       end
@@ -62,7 +62,8 @@ module Trello
         expect(card.url).to                eq(card_details['url'])
         expect(card.short_url).to          eq(card_details['shortUrl'])
         expect(card.pos).to                eq(card_details['pos'])
-        expect(card.last_activity_date).to eq(card_details['dateLastActivity'])
+        expect(card.last_activity_date).to be_a(Time)
+        expect(card.last_activity_date).to eq(Time.iso8601(card_details['dateLastActivity']))
       end
 
       it 'properly initializes all fields from options-like formatted hash' do
@@ -73,7 +74,7 @@ module Trello
         expect(card.desc).to                   eq(card_details[:desc])
         expect(card.member_ids).to             eq(card_details[:member_ids])
         expect(card.card_labels).to            eq(card_details[:card_labels])
-        expect(card.due).to                    eq(card_details[:due])
+        expect(card.due).to                    eq(card_details[:due].to_time)
         expect(card.pos).to                    eq(card_details[:pos])
         expect(card.source_card_id).to         eq(card_details[:source_card_id])
         expect(card.source_card_properties).to eq(card_details[:source_card_properties])
@@ -96,17 +97,18 @@ module Trello
           card_labels: "abcdef123456789123456789"
         }
 
-        result = JSON.generate(cards_details.first.merge(payload.merge(idList: lists_details.first['id'])))
-
-        expected_payload = {name: "Test Card", desc: nil, idList: "abcdef123456789123456789",
-                            idMembers: nil, idLabels: "abcdef123456789123456789", pos: nil, due: nil, dueComplete: false, idCardSource: nil, keepFromSource: 'all'}
+        expected_payload = {
+          'name' => "Test Card",
+          'idList' => "abcdef123456789123456789",
+          'idLabels' => "abcdef123456789123456789",
+        }
 
         expect(client)
           .to receive(:post)
           .with("/cards", expected_payload)
-          .and_return result
+          .and_return JSON.generate(cards_details.first.merge(payload.merge(idList: lists_details.first['id'])))
 
-        card = Card.create(cards_details.first.merge(payload.merge(list_id: lists_details.first['id'])))
+        card = Card.create(payload.merge(list_id: lists_details.first['id']))
 
         expect(card).to be_a Card
       end
@@ -118,15 +120,17 @@ module Trello
 
         result = JSON.generate(cards_details.first.merge(payload.merge(idList: lists_details.first['id'])))
 
-        expected_payload = {name: nil, desc: nil, idList: "abcdef123456789123456789",
-                            idMembers: nil, idLabels: nil, pos: nil, due: nil, dueComplete: false, idCardSource: cards_details.first['id'], keepFromSource: 'all'}
+        expected_payload = {
+          'idList' => "abcdef123456789123456789",
+          'idCardSource' => cards_details.first['id'],
+        }
 
         expect(client)
           .to receive(:post)
           .with("/cards", expected_payload)
           .and_return result
 
-        card = Card.create(cards_details.first.merge(payload.merge(list_id: lists_details.first['id'])))
+        card = Card.create(payload.merge(list_id: lists_details.first['id']))
 
         expect(card).to be_a Card
       end
@@ -139,15 +143,18 @@ module Trello
 
         result = JSON.generate(cards_details.first.merge(payload.merge(idList: lists_details.first['id'])))
 
-        expected_payload = {name: nil, desc: nil, idList: "abcdef123456789123456789",
-                            idMembers: nil, idLabels: nil, pos: nil, due: nil, dueComplete: false, idCardSource: cards_details.first['id'], keepFromSource: ['due', 'checklists']}
+        expected_payload = {
+          'idList' => "abcdef123456789123456789",
+          'idCardSource' => cards_details.first['id'],
+          'keepFromSource' => ['due', 'checklists']
+        }
 
         expect(client)
           .to receive(:post)
           .with("/cards", expected_payload)
           .and_return result
 
-        card = Card.create(cards_details.first.merge(payload.merge(list_id: lists_details.first['id'])))
+        card = Card.create(payload.merge(list_id: lists_details.first['id']))
 
         expect(card).to be_a Card
       end
@@ -160,15 +167,17 @@ module Trello
 
         result = JSON.generate(cards_details.first.merge(payload.merge(idList: lists_details.first['id'])))
 
-        expected_payload = {name: nil, desc: nil, idList: "abcdef123456789123456789",
-                            idMembers: nil, idLabels: nil, pos: nil, due: nil, dueComplete: false, idCardSource: cards_details.first['id'], keepFromSource: nil}
+        expected_payload = {
+          'idList' => "abcdef123456789123456789",
+          'idCardSource' => cards_details.first['id'],
+        }
 
         expect(client)
           .to receive(:post)
           .with("/cards", expected_payload)
           .and_return result
 
-        card = Card.create(cards_details.first.merge(payload.merge(list_id: lists_details.first['id'])))
+        card = Card.create(payload.merge(list_id: lists_details.first['id']))
 
         expect(card).to be_a Card
       end
@@ -180,7 +189,7 @@ module Trello
         expected_new_name = "xxx"
 
         payload = {
-          name: expected_new_name,
+          'name' => expected_new_name,
         }
 
         expect(client)
@@ -197,7 +206,7 @@ module Trello
         expected_new_desc = "xxx"
 
         payload = {
-          desc: expected_new_desc,
+          'desc' => expected_new_desc,
         }
 
         expect(client)
@@ -358,17 +367,26 @@ module Trello
 
         expect(client)
           .to receive(:put)
-          .with("/card/abcdef123456789123456789/customField/abcdef123456789123456789/item", params)
+          .with("/cards/abcdef123456789123456789/customField/abcdef123456789123456789/item", params)
 
         card.custom_field_items.last.remove
       end
 
       it "updates a custom field value" do
-        payload = { value: { text: 'Test Text' } }
+        payload = { 'value' => { 'text' => 'Test Text' } }
 
         expect(client)
           .to receive(:put)
-          .with("/card/abcdef123456789123456789/customField/abcdef123456789123456789/item", payload)
+          .with("/cards/abcdef123456789123456789/customField/abcdef123456789123456789/item", payload)
+          .and_return(JSON.generate({
+            "id" => "5e68e885e4baf545ec8ce7ba",
+            "value" => {
+              "text" => "Test Text"
+            },
+            "idCustomField" => "abcdef123456789123456789",
+            "idModel" => "abcdef123456789123456789",
+            "modelType" => "card"
+          }))
 
         text_custom_field = card.custom_field_items.last
         text_custom_field.value = { text: 'Test Text' }
@@ -626,12 +644,10 @@ module Trello
         expect(labels[0].id).to       eq('abcdef123456789123456789')
         expect(labels[0].board_id).to eq('abcdef123456789123456789')
         expect(labels[0].name).to     eq('iOS')
-        expect(labels[0].uses).to     eq(3)
         expect(labels[1].color).to    eq('purple')
         expect(labels[1].id).to       eq('bbcdef123456789123456789')
         expect(labels[1].board_id).to eq('abcdef123456789123456789')
         expect(labels[1].name).to     eq('Issue or bug')
-        expect(labels[1].uses).to     eq(1)
       end
 
       it "includes label ids list" do
@@ -691,18 +707,18 @@ module Trello
 
         first_plugin = card.plugin_data.first
         expect(first_plugin.id).to eq plugin_data_details[0]["id"]
-        expect(first_plugin.idPlugin).to eq plugin_data_details[0]["idPlugin"]
+        expect(first_plugin.plugin_id).to eq plugin_data_details[0]["idPlugin"]
         expect(first_plugin.scope).to eq plugin_data_details[0]["scope"]
-        expect(first_plugin.idModel).to eq plugin_data_details[0]["idModel"]
-        expect(first_plugin.value).to eq JSON.parse plugin_data_details[0]["value"]
+        expect(first_plugin.model_id).to eq plugin_data_details[0]["idModel"]
+        expect(first_plugin.value).to eq plugin_data_details[0]["value"]
         expect(first_plugin.access).to eq plugin_data_details[0]["access"]
 
         second_plugin = card.plugin_data[1]
         expect(second_plugin.id).to eq plugin_data_details[1]["id"]
-        expect(second_plugin.idPlugin).to eq plugin_data_details[1]["idPlugin"]
+        expect(second_plugin.plugin_id).to eq plugin_data_details[1]["idPlugin"]
         expect(second_plugin.scope).to eq plugin_data_details[1]["scope"]
-        expect(second_plugin.idModel).to eq plugin_data_details[1]["idModel"]
-        expect(second_plugin.value).to eq JSON.parse plugin_data_details[1]["value"]
+        expect(second_plugin.model_id).to eq plugin_data_details[1]["idModel"]
+        expect(second_plugin.value).to eq plugin_data_details[1]["value"]
         expect(second_plugin.access).to eq plugin_data_details[1]["access"]
 
       end
@@ -786,7 +802,7 @@ module Trello
 
     describe "#close!" do
       it "updates the close attribute to true and saves the list" do
-        payload = { closed: true }
+        payload = { 'closed' => true }
 
         expect(client)
           .to receive(:put)
@@ -803,7 +819,7 @@ module Trello
         due_date = Time.now
 
         payload = {
-          due: due_date,
+          'due' => due_date.strftime('%FT%T.%LZ'),
         }
 
         expect(client)
@@ -816,21 +832,6 @@ module Trello
         card.save
 
         expect(card.due).to_not be_nil
-
-        payload = {
-          dueComplete: true
-        }
-
-        expect(client)
-          .to receive(:put)
-          .once
-          .with("/cards/abcdef123456789123456789", payload)
-          .and_return(payload.to_json)
-
-        card.due_complete = true
-        card.save
-
-        expect(card.due_complete).to be true
       end
     end
 
@@ -888,7 +889,7 @@ module Trello
         end
 
         context "and the field doesn't changed" do
-          let(:fields) { { desc: expected[:desc] } }
+          let(:fields) { { desc: expected['desc'] } }
 
           it "card attributes doesn't changed" do
             card.update_fields(fields)
@@ -896,7 +897,7 @@ module Trello
             expect(card.desc).to eq(expected['desc'])
           end
 
-          it "card hasn't been mark as changed", pending: true do
+          it "card hasn't been mark as changed" do
             card.update_fields(fields)
 
             expect(card.changed?).to be_falsy

data/spec/cassettes/action_find_with_id_and_get_all_fields.yml

@@ -0,0 +1,104 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: https://api.trello.com/1/actions/5f60f07958388d26dc063c30?key=DEVELOPER_PUBLIC_KEY&token=MEMBER_TOKEN
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept:
+      - "*/*"
+      User-Agent:
+      - rest-client/2.1.0 (linux-gnu x86_64) ruby/2.6.6p146
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Host:
+      - api.trello.com
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      X-Dns-Prefetch-Control:
+      - 'off'
+      X-Frame-Options:
+      - DENY
+      X-Download-Options:
+      - noopen
+      X-Permitted-Cross-Domain-Policies:
+      - none
+      Referrer-Policy:
+      - strict-origin-when-cross-origin
+      Surrogate-Control:
+      - no-store
+      Cache-Control:
+      - max-age=0, must-revalidate, no-cache, no-store
+      Pragma:
+      - no-cache
+      Expires:
+      - Thu, 01 Jan 1970 00:00:00
+      X-Trello-Version:
+      - 1.2239.2
+      X-Trello-Environment:
+      - Production
+      Set-Cookie:
+      - dsc=set_cookie_dsc; Path=/; Expires=Thu, 01 Oct 2020 14:31:36 GMT; Secure
+      Access-Control-Allow-Origin:
+      - "*"
+      Access-Control-Allow-Methods:
+      - GET, PUT, POST, DELETE
+      Access-Control-Allow-Headers:
+      - Authorization, Accept, Content-Type
+      Access-Control-Expose-Headers:
+      - x-rate-limit-api-key-interval-ms, x-rate-limit-api-key-max, x-rate-limit-api-key-remaining,
+        x-rate-limit-api-token-interval-ms, x-rate-limit-api-token-max, x-rate-limit-api-token-remaining
+      X-Rate-Limit-Api-Token-Interval-Ms:
+      - '10000'
+      X-Rate-Limit-Api-Token-Max:
+      - '100'
+      X-Rate-Limit-Api-Token-Remaining:
+      - '99'
+      X-Rate-Limit-Api-Key-Interval-Ms:
+      - '10000'
+      X-Rate-Limit-Api-Key-Max:
+      - '300'
+      X-Rate-Limit-Api-Key-Remaining:
+      - '299'
+      X-Rate-Limit-Member-Interval-Ms:
+      - '10000'
+      X-Rate-Limit-Member-Max:
+      - '200'
+      X-Rate-Limit-Member-Remaining:
+      - '199'
+      X-Server-Time:
+      - '1601303496725'
+      Content-Type:
+      - application/json; charset=utf-8
+      Date:
+      - Mon, 28 Sep 2020 14:31:36 GMT
+      X-Envoy-Upstream-Service-Time:
+      - '159'
+      Expect-Ct:
+      - report-uri="https://web-security-reports.services.atlassian.com/expect-ct-report/trello-edge",
+        max-age=86400
+      Strict-Transport-Security:
+      - max-age=63072000; preload
+      X-Content-Type-Options:
+      - nosniff
+      X-Xss-Protection:
+      - 1; mode=block
+      Server:
+      - globaledge-envoy
+      Transfer-Encoding:
+      - chunked
+    body:
+      encoding: ASCII-8BIT
+      string: '{"id":"5f60f07958388d26dc063c30","idMemberCreator":"5e679b808e6e8828784b30e1","data":{"board":{"id":"5e93ba98614ac22d22f085c4","name":"IT
+        2","shortLink":"y1TF9GTa"},"customField":{"id":"5f60f07958388d26dc063c2d","name":"Test"}},"type":"createCustomField","date":"2020-09-15T16:48:57.454Z","limits":{},"appCreator":null,"display":{"translationKey":"action_create_custom_field","entities":{"board":{"type":"board","id":"5e93ba98614ac22d22f085c4","text":"IT
+        2","shortLink":"y1TF9GTa"},"customField":{"type":"customField","id":"5f60f07958388d26dc063c2d","text":"Test"},"memberCreator":{"type":"member","id":"5e679b808e6e8828784b30e1","username":"hoppertest","text":"Hopper
+        Test"}}},"memberCreator":{"id":"5e679b808e6e8828784b30e1","username":"hoppertest","activityBlocked":false,"avatarHash":null,"avatarUrl":null,"fullName":"Hopper
+        Test","idMemberReferrer":null,"initials":"HT","nonPublic":{},"nonPublicAvailable":true}}'
+    http_version: null
+  recorded_at: Mon, 28 Sep 2020 14:31:36 GMT
+recorded_with: VCR 5.1.0